radarsys Commit - r20:391e0c460449 · Jicamarca Repository

Views: Display "Page not found (404)" in case there is no object with the given pk....

Miguel Urco -

r20:391e0c460449

parent child

Context file:

r20:391e0c460449

Collapse all files

apps/dds/views.py +3 -3

             # Create your views here.
-            from django.shortcuts import redirect, render
+            from django.shortcuts import redirect, render, get_object_or_404
             from apps.main.models import Experiment, Configuration
             from .models import DDSConfiguration
             def dds_conf(request, id_conf):
-                conf = DDSConfiguration.objects.get(pk=id_conf)
+                conf = get_object_or_404(DDSConfiguration, pk=id_conf)
                 kwargs = {}
                 kwargs['dev_conf'] = conf
             def dds_conf_edit(request, id_conf):
-                conf = DDSConfiguration.objects.get(pk=id_conf)
+                conf = get_object_or_404(DDSConfiguration, pk=id_conf)
                 if request.method=='GET':
                     form = DDSConfigurationForm(instance=conf)

apps/main/views.py +13 -13

-            from django.shortcuts import render, redirect, HttpResponse
+            from django.shortcuts import render, redirect, get_object_or_404, HttpResponse
             from .forms import CampaignForm, ExperimentForm, DeviceForm, ConfigurationForm
             from apps.cgs.forms import CGSConfigurationForm
             def device(request, id_dev):
-                device = Device.objects.get(pk=id_dev)
+                device = get_object_or_404(Device, pk=id_dev)
                 kwargs = {}
                 kwargs['device'] = device
             def device_edit(request, id_dev):
-                device = Device.objects.get(pk=id_dev)
+                device = get_object_or_404(Device, pk=id_dev)
                 if request.method=='GET':
                     form = DeviceForm(instance=device)
             def device_delete(request, id_dev):
-                device = Device.objects.get(pk=id_dev)
+                device = get_object_or_404(Device, pk=id_dev)
                 if request.method=='POST':
             def campaign(request, id_camp):
-                campaign = Campaign.objects.get(pk=id_camp)
+                campaign = get_object_or_404(Campaign, pk=id_camp)
                 experiments = Experiment.objects.filter(campaign=campaign)
                 form = CampaignForm(instance=campaign)
             def campaign_edit(request, id_camp):
-                campaign = Campaign.objects.get(pk=id_camp)
+                campaign = get_object_or_404(Campaign, pk=id_camp)
                 if request.method=='GET':
                     form = CampaignForm(instance=campaign)
             def campaign_delete(request, id_camp):
-                campaign = Campaign.objects.get(pk=id_camp)
+                campaign = get_object_or_404(Campaign, pk=id_camp)
                 if request.method=='POST':
                     if request.user.is_staff:
             def experiment(request, id_exp):
-                experiment = Experiment.objects.get(pk=id_exp)
+                experiment = get_object_or_404(Experiment, pk=id_exp)
                 experiments = Experiment.objects.filter(campaign=experiment.campaign)
                 configurations = Configuration.objects.filter(experiment=experiment)
             def experiment_edit(request, id_exp):
-                experiment = Experiment.objects.get(pk=id_exp)
+                experiment = get_object_or_404(Experiment, pk=id_exp)
                 if request.method == 'GET':
                     form = ExperimentForm(instance=experiment)
             def experiment_delete(request, id_exp):
-                experiment = Experiment.objects.get(pk=id_exp)
+                experiment = get_object_or_404(Experiment, pk=id_exp)
                 if request.method=='POST':
                     if request.user.is_staff:
             def dev_conf(request, id_conf):
-                conf = Configuration.objects.get(pk=id_conf)
+                conf = get_object_or_404(Configuration, pk=id_conf)
                 DevConfModel = CONF_MODELS[conf.device.device_type.name]
                 dev_conf = DevConfModel.objects.get(pk=id_conf)
             def dev_conf_edit(request, id_conf):
-                conf = Configuration.objects.get(pk=id_conf)
+                conf = get_object_or_404(Configuration, pk=id_conf)
                 DevConfModel = CONF_MODELS[conf.device.device_type.name]
                 DevConfForm = CONF_FORMS[conf.device.device_type.name]
             def dev_conf_delete(request, id_conf):
-                conf = Configuration.objects.get(pk=id_conf)
+                conf = get_object_or_404(Configuration, pk=id_conf)
                 if request.method=='POST':
                     if request.user.is_staff:

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages