jro_apps/redmine Commit - r15304:ff50094d3e45

Include url helpers in helper tests....

Jean-Philippe Lang -

r15304:ff50094d3e45

parent child

Context file:

r15304:ff50094d3e45

Collapse all files

test/unit/helpers/groups_helper_test.rb +1 0

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class GroupsHelperTest < Redmine::HelperTest
               include Redmine::I18n
               include ERB::Util
               include GroupsHelper
+              include Rails.application.routes.url_helpers
               fixtures :users
               def test_render_principals_for_new_group_users
                 group = Group.generate!
                 result = render_principals_for_new_group_users(group)
                 assert_select_in result, 'input[name=?][value="2"]', 'user_ids[]'
               end
               def test_render_principals_for_new_group_users_with_limited_results_should_paginate
                 group = Group.generate!
                 result = render_principals_for_new_group_users(group, 3)
                 assert_select_in result, 'span.pagination'
                 assert_select_in result, 'span.pagination li.current span', :text => '1'
                 assert_select_in result, 'a[href=?]', "/groups/#{group.id}/autocomplete_for_user.js?page=2", :text => '2'
               end
             end

test/unit/helpers/issues_helper_test.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class IssuesHelperTest < Redmine::HelperTest
               include Redmine::I18n
               include IssuesHelper
               include CustomFieldsHelper
               include ERB::Util
               include Rails.application.routes.url_helpers
               fixtures :projects, :trackers, :issue_statuses, :issues,
                        :enumerations, :users, :issue_categories,
                        :projects_trackers,
                        :roles,
                        :member_roles,
                        :members,
                        :enabled_modules,
                        :custom_fields,
                        :attachments,
                        :versions
               def setup
                 super
                 set_language_if_valid('en')
                 User.current = nil
               end
               def test_issue_heading
                 assert_equal "Bug #1", issue_heading(Issue.find(1))
               end
               def test_issues_destroy_confirmation_message_with_one_root_issue
                 assert_equal l(:text_issues_destroy_confirmation),
                              issues_destroy_confirmation_message(Issue.find(1))
               end
               def test_issues_destroy_confirmation_message_with_an_arrayt_of_root_issues
                 assert_equal l(:text_issues_destroy_confirmation),
                              issues_destroy_confirmation_message(Issue.find([1, 2]))
               end
               def test_issues_destroy_confirmation_message_with_one_parent_issue
-                Issue.find(2).update_attribute :parent_issue_id, 1
+                Issue.find(2).update! :parent_issue_id => 1
                 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
                                l(:text_issues_destroy_descendants_confirmation, :count => 1),
                              issues_destroy_confirmation_message(Issue.find(1))
               end
               def test_issues_destroy_confirmation_message_with_one_parent_issue_and_its_child
-                Issue.find(2).update_attribute :parent_issue_id, 1
+                Issue.find(2).update! :parent_issue_id => 1
                 assert_equal l(:text_issues_destroy_confirmation),
                              issues_destroy_confirmation_message(Issue.find([1, 2]))
               end
               def test_issues_destroy_confirmation_message_with_issues_that_share_descendants
                 root = Issue.generate!
                 child = Issue.generate!(:parent_issue_id => root.id)
                 Issue.generate!(:parent_issue_id => child.id)
                 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
                                l(:text_issues_destroy_descendants_confirmation, :count => 1),
                              issues_destroy_confirmation_message([root.reload, child.reload])
               end
               test 'show_detail with no_html should show a changing attribute' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
                                            :value => '100', :prop_key => 'done_ratio')
                 assert_equal "% Done changed from 40 to 100", show_detail(detail, true)
               end
               test 'show_detail with no_html should show a new attribute' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
                                            :value => '100', :prop_key => 'done_ratio')
                 assert_equal "% Done set to 100", show_detail(detail, true)
               end
               test 'show_detail with no_html should show a deleted attribute' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
                                            :value => nil, :prop_key => 'done_ratio')
                 assert_equal "% Done deleted (50)", show_detail(detail, true)
               end
               test 'show_detail with html should show a changing attribute with HTML highlights' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
                                            :value => '100', :prop_key => 'done_ratio')
                 html = show_detail(detail, false)
                 assert_include '<strong>% Done</strong>', html
                 assert_include '<i>40</i>', html
                 assert_include '<i>100</i>', html
               end
               test 'show_detail with html should show a new attribute with HTML highlights' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
                                            :value => '100', :prop_key => 'done_ratio')
                 html = show_detail(detail, false)
                 assert_include '<strong>% Done</strong>', html
                 assert_include '<i>100</i>', html
               end
               test 'show_detail with html should show a deleted attribute with HTML highlights' do
                 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
                                            :value => nil, :prop_key => 'done_ratio')
                 html = show_detail(detail, false)
                 assert_include '<strong>% Done</strong>', html
                 assert_include '<del><i>50</i></del>', html
               end
               test 'show_detail with a start_date attribute should format the dates' do
                 detail = JournalDetail.new(
                            :property  => 'attr',
                            :old_value => '2010-01-01',
                            :value     => '2010-01-31',
                            :prop_key  => 'start_date'
                         )
                 with_settings :date_format => '%m/%d/%Y' do
                   assert_match "01/31/2010", show_detail(detail, true)
                   assert_match "01/01/2010", show_detail(detail, true)
                 end
               end
               test 'show_detail with a due_date attribute should format the dates' do
                 detail = JournalDetail.new(
                           :property  => 'attr',
                           :old_value => '2010-01-01',
                           :value     => '2010-01-31',
                           :prop_key  => 'due_date'
                         )
                 with_settings :date_format => '%m/%d/%Y' do
                   assert_match "01/31/2010", show_detail(detail, true)
                   assert_match "01/01/2010", show_detail(detail, true)
                 end
               end
               test 'show_detail should show old and new values with a project attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'project_id',
                                            :old_value => 1, :value => 2)
                 assert_match 'eCookbook', show_detail(detail, true)
                 assert_match 'OnlineStore', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a issue status attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'status_id',
                                            :old_value => 1, :value => 2)
                 assert_match 'New', show_detail(detail, true)
                 assert_match 'Assigned', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a tracker attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'tracker_id',
                                            :old_value => 1, :value => 2)
                 assert_match 'Bug', show_detail(detail, true)
                 assert_match 'Feature request', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a assigned to attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'assigned_to_id',
                                            :old_value => 1, :value => 2)
                 assert_match 'Redmine Admin', show_detail(detail, true)
                 assert_match 'John Smith', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a priority attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'priority_id',
                                            :old_value => 4, :value => 5)
                 assert_match 'Low', show_detail(detail, true)
                 assert_match 'Normal', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a category attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'category_id',
                                            :old_value => 1, :value => 2)
                 assert_match 'Printing', show_detail(detail, true)
                 assert_match 'Recipes', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a fixed version attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'fixed_version_id',
                                            :old_value => 1, :value => 2)
                 assert_match '0.1', show_detail(detail, true)
                 assert_match '1.0', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a estimated hours attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'estimated_hours',
                                            :old_value => '5', :value => '6.3')
                 assert_match '5.00', show_detail(detail, true)
                 assert_match '6.30', show_detail(detail, true)
               end
               test 'show_detail should not show values with a description attribute' do
                 detail = JournalDetail.new(:property => 'attr', :prop_key => 'description',
                                            :old_value => 'Foo', :value => 'Bar')
                 assert_equal 'Description updated', show_detail(detail, true)
               end
               test 'show_detail should show old and new values with a custom field' do
                 detail = JournalDetail.new(:property => 'cf', :prop_key => '1',
                                            :old_value => 'MySQL', :value => 'PostgreSQL')
                 assert_equal 'Database changed from MySQL to PostgreSQL', show_detail(detail, true)
               end
               test 'show_detail should not show values with a long text custom field' do
                 field = IssueCustomField.create!(:name => "Long field", :field_format => 'text')
                 detail = JournalDetail.new(:property => 'cf', :prop_key => field.id,
                                            :old_value => 'Foo', :value => 'Bar')
                 assert_equal 'Long field updated', show_detail(detail, true)
               end
               test 'show_detail should show added file' do
                 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
                                            :old_value => nil, :value => 'error281.txt')
                 assert_match 'error281.txt', show_detail(detail, true)
               end
               test 'show_detail should show removed file' do
                 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
                                            :old_value => 'error281.txt', :value => nil)
                 assert_match 'error281.txt', show_detail(detail, true)
               end
               def test_show_detail_relation_added
                 detail = JournalDetail.new(:property => 'relation',
                                            :prop_key => 'precedes',
                                            :value    => 1)
                 assert_equal "Precedes Bug #1: Cannot print recipes added", show_detail(detail, true)
                 str = link_to("Bug #1", "/issues/1", :class => Issue.find(1).css_classes)
                 assert_equal "<strong>Precedes</strong> <i>#{str}: Cannot print recipes</i> added",
                               show_detail(detail, false)
               end
               def test_show_detail_relation_added_with_inexistant_issue
                 inexistant_issue_number = 9999
                 assert_nil  Issue.find_by_id(inexistant_issue_number)
                 detail = JournalDetail.new(:property => 'relation',
                                            :prop_key => 'precedes',
                                            :value    => inexistant_issue_number)
                 assert_equal "Precedes Issue ##{inexistant_issue_number} added", show_detail(detail, true)
                 assert_equal "<strong>Precedes</strong> <i>Issue ##{inexistant_issue_number}</i> added", show_detail(detail, false)
               end
               def test_show_detail_relation_added_should_not_disclose_issue_that_is_not_visible
                 issue = Issue.generate!(:is_private => true)
                 detail = JournalDetail.new(:property => 'relation',
                                            :prop_key => 'precedes',
                                            :value    => issue.id)
                 assert_equal "Precedes Issue ##{issue.id} added", show_detail(detail, true)
                 assert_equal "<strong>Precedes</strong> <i>Issue ##{issue.id}</i> added", show_detail(detail, false)
               end
               def test_show_detail_relation_deleted
                 detail = JournalDetail.new(:property  => 'relation',
                                            :prop_key  => 'precedes',
                                            :old_value => 1)
                 assert_equal "Precedes deleted (Bug #1: Cannot print recipes)", show_detail(detail, true)
                 str = link_to("Bug #1",
                               "/issues/1",
                               :class => Issue.find(1).css_classes)
                 assert_equal "<strong>Precedes</strong> deleted (<i>#{str}: Cannot print recipes</i>)",
                              show_detail(detail, false)
               end
               def test_show_detail_relation_deleted_with_inexistant_issue
                 inexistant_issue_number = 9999
                 assert_nil  Issue.find_by_id(inexistant_issue_number)
                 detail = JournalDetail.new(:property  => 'relation',
                                            :prop_key  => 'precedes',
                                            :old_value => inexistant_issue_number)
                 assert_equal "Precedes deleted (Issue #9999)", show_detail(detail, true)
                 assert_equal "<strong>Precedes</strong> deleted (<i>Issue #9999</i>)", show_detail(detail, false)
               end
               def test_show_detail_relation_deleted_should_not_disclose_issue_that_is_not_visible
                 issue = Issue.generate!(:is_private => true)
                 detail = JournalDetail.new(:property => 'relation',
                                            :prop_key => 'precedes',
                                            :old_value    => issue.id)
                 assert_equal "Precedes deleted (Issue ##{issue.id})", show_detail(detail, true)
                 assert_equal "<strong>Precedes</strong> deleted (<i>Issue ##{issue.id}</i>)", show_detail(detail, false)
               end
               def test_details_to_strings_with_multiple_values_removed_from_custom_field
                 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
                 details = []
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '1', :value => nil)
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '3', :value => nil)
                 assert_equal ["User deleted (Dave Lopper, Redmine Admin)"], details_to_strings(details, true)
                 assert_equal ["<strong>User</strong> deleted (<del><i>Dave Lopper, Redmine Admin</i></del>)"], details_to_strings(details, false)
               end
               def test_details_to_strings_with_multiple_values_added_to_custom_field
                 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
                 details = []
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '1')
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '3')
                 assert_equal ["User Dave Lopper, Redmine Admin added"], details_to_strings(details, true)
                 assert_equal ["<strong>User</strong> <i>Dave Lopper, Redmine Admin</i> added"], details_to_strings(details, false)
               end
               def test_details_to_strings_with_multiple_values_added_and_removed_from_custom_field
                 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
                 details = []
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '1')
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '2', :value => nil)
                 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '3', :value => nil)
                 assert_equal [
                   "User Redmine Admin added",
                   "User deleted (Dave Lopper, John Smith)"
                   ], details_to_strings(details, true)
                 assert_equal [
                   "<strong>User</strong> <i>Redmine Admin</i> added",
                   "<strong>User</strong> deleted (<del><i>Dave Lopper, John Smith</i></del>)"
                   ], details_to_strings(details, false)
               end
               def test_find_name_by_reflection_should_return_nil_for_missing_record
                 assert_nil find_name_by_reflection('status', 99)
               end
             end

test/unit/helpers/members_helper_test.rb +1 0

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class MembersHelperTest < Redmine::HelperTest
               include Redmine::I18n
               include ERB::Util
               include MembersHelper
+              include Rails.application.routes.url_helpers
               fixtures :projects, :users, :members, :member_roles,
                        :trackers, :issue_statuses
               def test_render_principals_for_new_members
                 project = Project.generate!
                 result = render_principals_for_new_members(project)
                 assert_select_in result, 'input[name=?][value="2"]', 'membership[user_ids][]'
               end
               def test_render_principals_for_new_members_with_limited_results_should_paginate
                 project = Project.generate!
                 result = render_principals_for_new_members(project, 3)
                 assert_select_in result, 'span.pagination'
                 assert_select_in result, 'span.pagination li.current span', :text => '1'
                 assert_select_in result, 'a[href=?]', "/projects/#{project.identifier}/memberships/autocomplete.js?page=2", :text => '2'
               end
             end

test/unit/lib/redmine/helpers/gantt_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../../../test_helper', __FILE__)
-            class Redmine::Helpers::GanttHelperTest < ActionView::TestCase
+            class Redmine::Helpers::GanttHelperTest < Redmine::HelperTest
               fixtures :projects, :trackers, :issue_statuses,
                        :enumerations, :users, :issue_categories
               include ProjectsHelper
               include IssuesHelper
               include ERB::Util
               include Rails.application.routes.url_helpers
               def setup
                 setup_with_controller
                 User.current = User.find(1)
               end
               def today
                 @today ||= Date.today
               end
               private :today
               def gantt_start
                 @gantt.date_from
               end
               # Creates a Gantt chart for a 4 week span
               def create_gantt(project=Project.generate!, options={})
                 @project = project
                 @gantt = Redmine::Helpers::Gantt.new(options)
                 @gantt.project = @project
                 @gantt.query = IssueQuery.new(:project => @project, :name => 'Gantt')
                 @gantt.view = self
                 @gantt.instance_variable_set('@date_from', options[:date_from] || (today - 14))
                 @gantt.instance_variable_set('@date_to', options[:date_to] || (today + 14))
               end
               private :create_gantt
               test "#number_of_rows with one project should return the number of rows just for that project" do
                 p1, p2 = Project.generate!, Project.generate!
                 i1, i2 = Issue.generate!(:project => p1), Issue.generate!(:project => p2)
                 create_gantt(p1)
                 assert_equal 2, @gantt.number_of_rows
               end
               test "#number_of_rows with no project should return the total number of rows for all the projects, resursively" do
                 p1, p2 = Project.generate!, Project.generate!
                 create_gantt(nil)
                 # fix the return value of #number_of_rows_on_project() to an arbitrary value
                 # so that we really only test #number_of_rows
                 @gantt.stubs(:number_of_rows_on_project).returns(7)
                 # also fix #projects because we want to test #number_of_rows in isolation
                 @gantt.stubs(:projects).returns(Project.all)
                 # actual test
                 assert_equal Project.count*7, @gantt.number_of_rows
               end
               test "#number_of_rows should not exceed max_rows option" do
                 p = Project.generate!
 .times do
                   Issue.generate!(:project => p)
                 end
                 create_gantt(p)
                 @gantt.render
                 assert_equal 6, @gantt.number_of_rows
                 assert !@gantt.truncated
                 create_gantt(p, :max_rows => 3)
                 @gantt.render
                 assert_equal 3, @gantt.number_of_rows
                 assert @gantt.truncated
               end
               test "#number_of_rows_on_project should count 0 for an empty the project" do
                 create_gantt
                 assert_equal 0, @gantt.number_of_rows_on_project(@project)
               end
               test "#number_of_rows_on_project should count the number of issues without a version" do
                 create_gantt
                 @project.issues << Issue.generate!(:project => @project, :fixed_version => nil)
                 assert_equal 2, @gantt.number_of_rows_on_project(@project)
               end
               test "#number_of_rows_on_project should count the number of issues on versions, including cross-project" do
                 create_gantt
                 version = Version.generate!
                 @project.versions << version
                 @project.issues << Issue.generate!(:project => @project, :fixed_version => version)
                 assert_equal 3, @gantt.number_of_rows_on_project(@project)
               end
               def setup_subjects
                 create_gantt
                 @project.enabled_module_names = [:issue_tracking]
                 @tracker = Tracker.generate!
                 @project.trackers << @tracker
                 @version = Version.generate!(:effective_date => (today + 7), :sharing => 'none')
                 @project.versions << @version
                 @issue = Issue.generate!(:fixed_version => @version,
                                            :subject => "gantt#line_for_project",
                                            :tracker => @tracker,
                                            :project => @project,
                                            :done_ratio => 30,
                                            :start_date => (today - 1),
                                            :due_date => (today + 7))
                 @project.issues << @issue
               end
               private :setup_subjects
               # TODO: more of an integration test
               test "#subjects project should be rendered" do
                 setup_subjects
                 @output_buffer = @gantt.subjects
                 assert_select "div.project-name a", /#{@project.name}/
                 assert_select 'div.project-name[style*="left:4px"]'
               end
               test "#subjects version should be rendered" do
                 setup_subjects
                 @output_buffer = @gantt.subjects
                 assert_select "div.version-name a", /#{@version.name}/
                 assert_select 'div.version-name[style*="left:24px"]'
               end
               test "#subjects version without assigned issues should not be rendered" do
                 setup_subjects
                 @version = Version.generate!(:effective_date => (today + 14),
                                                    :sharing => 'none',
                                                    :name => 'empty_version')
                 @project.versions << @version
                 @output_buffer = @gantt.subjects
                 assert_select "div.version-name a", :text => /#{@version.name}/, :count => 0
               end
               test "#subjects issue should be rendered" do
                 setup_subjects
                 @output_buffer = @gantt.subjects
                 assert_select "div.issue-subject", /#{@issue.subject}/
                 assert_select 'div.issue-subject[style*="left:44px"]'
               end
               test "#subjects issue assigned to a shared version of another project should be rendered" do
                 setup_subjects
                 p = Project.generate!
                 p.enabled_module_names = [:issue_tracking]
                 @shared_version = Version.generate!(:sharing => 'system')
                 p.versions << @shared_version
                 # Reassign the issue to a shared version of another project
                 @issue = Issue.generate!(:fixed_version => @shared_version,
                                                :subject => "gantt#assigned_to_shared_version",
                                                :tracker => @tracker,
                                                :project => @project,
                                                :done_ratio => 30,
                                                :start_date => (today - 1),
                                                :due_date => (today + 7))
                 @project.issues << @issue
                 @output_buffer = @gantt.subjects
                 assert_select "div.issue-subject", /#{@issue.subject}/
               end
               test "#subjects issue with subtasks should indent subtasks" do
                 setup_subjects
                 attrs = {:project => @project, :tracker => @tracker, :fixed_version => @version}
                 @child1 = Issue.generate!(
                                    attrs.merge(:subject => 'child1',
                                                :parent_issue_id => @issue.id,
                                                :start_date => (today - 1),
                                                :due_date => (today + 2))
                                   )
                 @child2 = Issue.generate!(
                                    attrs.merge(:subject => 'child2',
                                                :parent_issue_id => @issue.id,
                                                :start_date => today,
                                                :due_date => (today + 7))
                                    )
                 @grandchild = Issue.generate!(
                                       attrs.merge(:subject => 'grandchild',
                                                   :parent_issue_id => @child1.id,
                                                   :start_date => (today - 1),
                                                   :due_date => (today + 2))
                                       )
                 @output_buffer = @gantt.subjects
                 # parent task 44px
                 assert_select 'div.issue-subject[style*="left:44px"]', /#{@issue.subject}/
                 # children 64px
                 assert_select 'div.issue-subject[style*="left:64px"]', /child1/
                 assert_select 'div.issue-subject[style*="left:64px"]', /child2/
                 # grandchild 84px
                 assert_select 'div.issue-subject[style*="left:84px"]', /grandchild/, @output_buffer
               end
               test "#lines" do
                 create_gantt
                 @project.enabled_module_names = [:issue_tracking]
                 @tracker = Tracker.generate!
                 @project.trackers << @tracker
                 @version = Version.generate!(:effective_date => (today + 7))
                 @project.versions << @version
                 @issue = Issue.generate!(:fixed_version => @version,
                                          :subject => "gantt#line_for_project",
                                          :tracker => @tracker,
                                          :project => @project,
                                          :done_ratio => 30,
                                          :start_date => (today - 1),
                                          :due_date => (today + 7))
                 @project.issues << @issue
                 @output_buffer = @gantt.lines
                 assert_select "div.project.task_todo"
                 assert_select "div.project.starting"
                 assert_select "div.project.ending"
                 assert_select "div.label.project", /#{@project.name}/
                 assert_select "div.version.task_todo"
                 assert_select "div.version.starting"
                 assert_select "div.version.ending"
                 assert_select "div.label.version", /#{@version.name}/
                 assert_select "div.task_todo"
                 assert_select "div.task.label", /#{@issue.done_ratio}/
                 assert_select "div.tooltip", /#{@issue.subject}/
               end
               test "#subject_for_project" do
                 create_gantt
                 @output_buffer = @gantt.subject_for_project(@project, :format => :html)
                 assert_select 'a[href=?]', "/projects/#{@project.identifier}", :text => /#{@project.name}/
               end
               test "#subject_for_project should style overdue projects" do
                 create_gantt
                 @project.stubs(:overdue?).returns(true)
                 @output_buffer = @gantt.subject_for_project(@project, :format => :html)
                 assert_select 'div span.project-overdue'
               end
               test "#subject_for_version" do
                 create_gantt
                 version = Version.generate!(:name => 'Foo', :effective_date => today, :project => @project)
                 @output_buffer = @gantt.subject_for_version(version, :format => :html)
                 assert_select 'a[href=?]', "/versions/#{version.to_param}", :text => /Foo/
               end
               test "#subject_for_version should style overdue versions" do
                 create_gantt
                 version = Version.generate!(:name => 'Foo', :effective_date => today, :project => @project)
                 version.stubs(:overdue?).returns(true)
                 @output_buffer = @gantt.subject_for_version(version, :format => :html)
                 assert_select 'div span.version-overdue'
               end
               test "#subject_for_version should style behind schedule versions" do
                 create_gantt
                 version = Version.generate!(:name => 'Foo', :effective_date => today, :project => @project)
                 version.stubs(:behind_schedule?).returns(true)
                 @output_buffer = @gantt.subject_for_version(version, :format => :html)
                 assert_select 'div span.version-behind-schedule'
               end
               test "#subject_for_issue" do
                 create_gantt
                 issue = Issue.generate!(:project => @project)
                 @output_buffer = @gantt.subject_for_issue(issue, :format => :html)
                 assert_select 'div', :text => /#{issue.subject}/
                 assert_select 'a[href=?]', "/issues/#{issue.to_param}", :text => /#{issue.tracker.name} ##{issue.id}/
               end
               test "#subject_for_issue should style overdue issues" do
                 create_gantt
                 issue = Issue.generate!(:project => @project)
                 issue.stubs(:overdue?).returns(true)
                 @output_buffer = @gantt.subject_for_issue(issue, :format => :html)
                 assert_select 'div span.issue-overdue'
               end
               test "#subject should add an absolute positioned div" do
                 create_gantt
                 @output_buffer = @gantt.subject('subject', :format => :html)
                 assert_select "div[style*=absolute]", :text => 'subject'
               end
               test "#subject should use the indent option to move the div to the right" do
                 create_gantt
                 @output_buffer = @gantt.subject('subject', :format => :html, :indent => 40)
                 assert_select 'div[style*="left:40"]'
               end
               test "#line_for_project" do
                 create_gantt
                 @project.stubs(:start_date).returns(today - 7)
                 @project.stubs(:due_date).returns(today + 7)
                 @output_buffer = @gantt.line_for_project(@project, :format => :html)
                 assert_select "div.project.label", :text => @project.name
               end
               test "#line_for_version" do
                 create_gantt
                 version = Version.generate!(:name => 'Foo', :project => @project)
                 version.stubs(:start_date).returns(today - 7)
                 version.stubs(:due_date).returns(today + 7)
                 version.stubs(:completed_percent).returns(30)
                 @output_buffer = @gantt.line_for_version(version, :format => :html)
                 assert_select "div.version.label", :text => /Foo/
                 assert_select "div.version.label", :text => /30%/
               end
               test "#line_for_issue" do
                 create_gantt
                 issue = Issue.generate!(:project => @project, :start_date => today - 7, :due_date => today + 7, :done_ratio => 30)
                 @output_buffer = @gantt.line_for_issue(issue, :format => :html)
                 assert_select "div.task.label", :text => /#{issue.status.name}/
                 assert_select "div.task.label", :text => /30%/
                 assert_select "div.tooltip", /#{issue.subject}/
               end
               test "#line todo line should start from the starting point on the left" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_todo[style*="left:28px"]', 1
               end
               test "#line todo line should be the total width" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_todo[style*="width:58px"]', 1
               end
               test "#line late line should start from the starting point on the left" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_late[style*="left:28px"]', 1
               end
               test "#line late line should be the total delayed width" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_late[style*="width:30px"]', 1
               end
               test "#line done line should start from the starting point on the left" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_done[style*="left:28px"]', 1
               end
               test "#line done line should be the width for the done ratio" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, false, 'line', :format => :html, :zoom => 4)
                 # 15 days * 4 px * 30% - 2 px for borders = 16 px
                 assert_select 'div.task_done[style*="width:16px"]', 1
               end
               test "#line done line should be the total width for 100% done ratio" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 100, false, 'line', :format => :html, :zoom => 4)
                 # 15 days * 4 px - 2 px for borders = 58 px
                 assert_select 'div.task_done[style*="width:58px"]', 1
               end
               test "#line done line should be the total width for 100% done ratio with same start and end dates" do
                 create_gantt
                 @output_buffer = @gantt.line(today + 7, today + 7, 100, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_done[style*="width:2px"]', 1
               end
               test "#line done line should not be the total done width if the gantt starts after start date" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 16, today - 2, 30, false, 'line', :format => :html, :zoom => 4)
                 assert_select 'div.task_done[style*="left:0px"]', 1
                 assert_select 'div.task_done[style*="width:8px"]', 1
               end
               test "#line starting marker should appear at the start date" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, true, 'line', :format => :html, :zoom => 4)
                 assert_select "div.starting", 1
                 assert_select 'div.starting[style*="left:28px"]', 1
               end
               test "#line starting marker should not appear if the start date is before gantt start date" do
                 create_gantt
                 @output_buffer = @gantt.line(gantt_start - 2, today + 7, 30, true, 'line', :format => :html, :zoom => 4)
                 assert_select "div.starting", 0
               end
               test "#line ending marker should appear at the end date" do
                 create_gantt
                 @output_buffer = @gantt.line(today - 7, today + 7, 30, true, 'line', :format => :html, :zoom => 4)
                 assert_select "div.ending", 1
                 assert_select 'div.ending[style*="left:88px"]', 1
               end
               test "#line ending marker should not appear if the end date is before gantt start date" do
                 create_gantt
                 @output_buffer = @gantt.line(gantt_start - 30, gantt_start - 21, 30, true, 'line', :format => :html)
                 assert_select "div.ending", 0
               end
               test "#line label should appear at the far left, even if it's before gantt start date" do
                 create_gantt
                 @output_buffer = @gantt.line(gantt_start - 30, gantt_start - 21, 30, true, 'line', :format => :html)
                 assert_select "div.label", :text => 'line'
               end
               def test_sort_issues_no_date
                 project = Project.generate!
                 issue1 = Issue.generate!(:subject => "test", :project => project)
                 issue2 = Issue.generate!(:subject => "test", :project => project)
                 assert issue1.root_id < issue2.root_id
                 child1 = Issue.generate!(:parent_issue_id => issue1.id, :subject => 'child',
                                          :project => project)
                 child2 = Issue.generate!(:parent_issue_id => issue1.id, :subject => 'child',
                                          :project => project)
                 child3 = Issue.generate!(:parent_issue_id => child1.id, :subject => 'child',
                                          :project => project)
                 assert_equal child1.root_id, child2.root_id
                 assert child1.lft < child2.lft
                 assert child3.lft < child2.lft
                 issues = [child3, child2, child1, issue2, issue1]
                 Redmine::Helpers::Gantt.sort_issues!(issues)
                 assert_equal [issue1.id, child1.id, child3.id, child2.id, issue2.id],
                               issues.map{|v| v.id}
               end
               def test_sort_issues_root_only
                 project = Project.generate!
                 issue1 = Issue.generate!(:subject => "test", :project => project)
                 issue2 = Issue.generate!(:subject => "test", :project => project)
                 issue3 = Issue.generate!(:subject => "test", :project => project,
                                          :start_date => (today - 1))
                 issue4 = Issue.generate!(:subject => "test", :project => project,
                                          :start_date => (today - 2))
                 issues = [issue4, issue3, issue2, issue1]
                 Redmine::Helpers::Gantt.sort_issues!(issues)
                 assert_equal [issue1.id, issue2.id, issue4.id, issue3.id],
                               issues.map{|v| v.id}
               end
               def test_sort_issues_tree
                 project = Project.generate!
                 issue1 = Issue.generate!(:subject => "test", :project => project)
                 issue2 = Issue.generate!(:subject => "test", :project => project,
                                          :start_date => (today - 2))
                 issue1_child1 =
                          Issue.generate!(:parent_issue_id => issue1.id, :subject => 'child',
                                          :project => project)
                 issue1_child2 =
                          Issue.generate!(:parent_issue_id => issue1.id, :subject => 'child',
                                          :project => project, :start_date => (today - 10))
                 issue1_child1_child1 =
                          Issue.generate!(:parent_issue_id => issue1_child1.id, :subject => 'child',
                                          :project => project, :start_date => (today - 8))
                 issue1_child1_child2 =
                          Issue.generate!(:parent_issue_id => issue1_child1.id, :subject => 'child',
                                          :project => project, :start_date => (today - 9))
                 issue1_child1_child1_logic = Redmine::Helpers::Gantt.sort_issue_logic(issue1_child1_child1)
                 assert_equal [[today - 10, issue1.id], [today - 9, issue1_child1.id],
                               [today - 8, issue1_child1_child1.id]],
                              issue1_child1_child1_logic
                 issue1_child1_child2_logic = Redmine::Helpers::Gantt.sort_issue_logic(issue1_child1_child2)
                 assert_equal [[today - 10, issue1.id], [today - 9, issue1_child1.id],
                               [today - 9, issue1_child1_child2.id]],
                              issue1_child1_child2_logic
                 issues = [issue1_child1_child2, issue1_child1_child1, issue1_child2,
                           issue1_child1, issue2, issue1]
                 Redmine::Helpers::Gantt.sort_issues!(issues)
                 assert_equal [issue1.id, issue1_child1.id, issue1_child2.id,
                               issue1_child1_child2.id, issue1_child1_child1.id, issue2.id],
                              issues.map{|v| v.id}
               end
               def test_sort_versions
                 project = Project.generate!
                 versions = []
                 versions << Version.create!(:project => project, :name => 'test1')
                 versions << Version.create!(:project => project, :name => 'test2', :effective_date => '2013-10-25')
                 versions << Version.create!(:project => project, :name => 'test3')
                 versions << Version.create!(:project => project, :name => 'test4', :effective_date => '2013-10-02')
                 assert_equal versions.sort, Redmine::Helpers::Gantt.sort_versions!(versions.dup)
               end
             end

test/unit/lib/redmine/menu_manager/menu_helper_test.rb +3 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../../../test_helper', __FILE__)
-            class Redmine::MenuManager::MenuHelperTest < ActionView::TestCase
+            class Redmine::MenuManager::MenuHelperTest < Redmine::HelperTest
               include Redmine::MenuManager::MenuHelper
               include ERB::Util
+              include Rails.application.routes.url_helpers
               fixtures :users, :members, :projects, :enabled_modules, :roles, :member_roles
               def setup
                 setup_with_controller
                 # Stub the current menu item in the controller
                 def current_menu_item
                   :index
                 end
               end
               def test_render_single_menu_node
                 node = Redmine::MenuManager::MenuItem.new(:testing, '/test', { })
                 @output_buffer = render_single_menu_node(node, 'This is a test', node.url, false)
                 assert_select("a.testing", "This is a test")
               end
               def test_render_menu_node
                 single_node = Redmine::MenuManager::MenuItem.new(:single_node, '/test', { })
                 @output_buffer = render_menu_node(single_node, nil)
                 assert_select("li") do
                   assert_select("a.single-node", "Single node")
                 end
               end
               def test_render_menu_node_with_symbol_as_url
                 node = Redmine::MenuManager::MenuItem.new(:testing, :issues_path)
                 @output_buffer = render_menu_node(node, nil)
                 assert_select 'a[href="/issues"]', "Testing"
               end
               def test_render_menu_node_with_symbol_as_url_and_project
                 node = Redmine::MenuManager::MenuItem.new(:testing, :project_issues_path)
                 @output_buffer = render_menu_node(node, Project.find(1))
                 assert_select 'a[href="/projects/ecookbook/issues"]', "Testing"
               end
               def test_render_menu_node_with_nested_items
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node, '/test', { })
                 parent_node << Redmine::MenuManager::MenuItem.new(:child_one_node, '/test', { })
                 parent_node << Redmine::MenuManager::MenuItem.new(:child_two_node, '/test', { })
                 parent_node <<
                   Redmine::MenuManager::MenuItem.new(:child_three_node, '/test', { }) <<
                   Redmine::MenuManager::MenuItem.new(:child_three_inner_node, '/test', { })
                 @output_buffer = render_menu_node(parent_node, nil)
                 assert_select("li") do
                   assert_select("a.parent-node", "Parent node")
                   assert_select("ul") do
                     assert_select("li a.child-one-node", "Child one node")
                     assert_select("li a.child-two-node", "Child two node")
                     assert_select("li") do
                       assert_select("a.child-three-node", "Child three node")
                       assert_select("ul") do
                         assert_select("li a.child-three-inner-node", "Child three inner node")
                       end
                     end
                   end
                 end
               end
               def test_render_menu_node_with_children
                 User.current = User.find(2)
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
                                                                  '/test',
                                                                  {
                                                                    :children => Proc.new {|p|
                                                                      children = []
 .times do |time|
                                                                        children << Redmine::MenuManager::MenuItem.new("test_child_#{time}",
                                                                                                                          {:controller => 'issues', :action => 'index'},
                                                                                                                          {})
                                                                      end
                                                                      children
                                                                    }
                                                                  })
                 @output_buffer = render_menu_node(parent_node, Project.find(1))
                 assert_select("li") do
                   assert_select("a.parent-node", "Parent node")
                   assert_select("ul") do
                     assert_select("li a.test-child-0", "Test child 0")
                     assert_select("li a.test-child-1", "Test child 1")
                     assert_select("li a.test-child-2", "Test child 2")
                   end
                 end
               end
               def test_render_menu_node_with_nested_items_and_children
                 User.current = User.find(2)
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
                                                                  {:controller => 'issues', :action => 'index'},
                                                                  {
                                                                    :children => Proc.new {|p|
                                                                      children = []
 .times do |time|
                                                                        children << Redmine::MenuManager::MenuItem.new("test_child_#{time}", {:controller => 'issues', :action => 'index'}, {})
                                                                      end
                                                                      children
                                                                    }
                                                                  })
                 parent_node << Redmine::MenuManager::MenuItem.new(:child_node,
                                                                  {:controller => 'issues', :action => 'index'},
                                                                  {
                                                                    :children => Proc.new {|p|
                                                                      children = []
 .times do |time|
                                                                         children << Redmine::MenuManager::MenuItem.new("test_dynamic_child_#{time}", {:controller => 'issues', :action => 'index'}, {})
                                                                      end
                                                                      children
                                                                    }
                                                                  })
                 @output_buffer = render_menu_node(parent_node, Project.find(1))
                 assert_select("li") do
                   assert_select("a.parent-node", "Parent node")
                   assert_select("ul") do
                     assert_select("li a.child-node", "Child node")
                     assert_select("ul") do
                       assert_select("li a.test-dynamic-child-0", "Test dynamic child 0")
                       assert_select("li a.test-dynamic-child-1", "Test dynamic child 1")
                       assert_select("li a.test-dynamic-child-2", "Test dynamic child 2")
                       assert_select("li a.test-dynamic-child-3", "Test dynamic child 3")
                       assert_select("li a.test-dynamic-child-4", "Test dynamic child 4")
                       assert_select("li a.test-dynamic-child-5", "Test dynamic child 5")
                     end
                     assert_select("li a.test-child-0", "Test child 0")
                     assert_select("li a.test-child-1", "Test child 1")
                     assert_select("li a.test-child-2", "Test child 2")
                   end
                 end
               end
               def test_render_menu_node_with_allowed_and_unallowed_unattached_children
                 User.current = User.find(2)
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
                                                                  {:controller => 'issues', :action => 'index'},
                                                                  {
                                                                    :children => Proc.new {|p|
                                                                      [
                                                                        Redmine::MenuManager::MenuItem.new("test_child_allowed", {:controller => 'issues', :action => 'index'}, {}),
                                                                        Redmine::MenuManager::MenuItem.new("test_child_unallowed", {:controller => 'issues', :action => 'unallowed'}, {}),
                                                                      ]
                                                                    }
                                                                  })
                 @output_buffer = render_menu_node(parent_node, Project.find(1))
                 assert_select("li") do
                   assert_select("a.parent-node", "Parent node")
                   assert_select("ul.menu-children.unattached") do
                     assert_select("li a.test-child-allowed", "Test child allowed")
                     assert_select("li a.test-child-unallowed", false)
                   end
                 end
               end
               def test_render_menu_node_with_allowed_and_unallowed_standard_children
                 User.current = User.find(6)
                 Redmine::MenuManager.map :some_menu do |menu|
                   menu.push(:parent_node, {:controller => 'issues', :action => 'index'}, { })
                   menu.push(:test_child_allowed, {:controller => 'issues', :action => 'index'}, {:parent => :parent_node})
                   menu.push(:test_child_unallowed, {:controller => 'issues', :action => 'new'}, {:parent => :parent_node})
                 end
                 @output_buffer = render_menu(:some_menu, Project.find(1))
                 assert_select("li") do
                   assert_select("a.parent-node", "Parent node")
                   assert_select("ul.menu-children.unattached", false)
                   assert_select("ul.menu-children") do
                     assert_select("li a.test-child-allowed", "Test child allowed")
                     assert_select("li a.test-child-unallowed", false)
                   end
                 end
               end
               def test_render_empty_virtual_menu_node_with_children
                 # only empty item with no click target
                 Redmine::MenuManager.map :menu1 do |menu|
                   menu.push(:parent_node, nil, { })
                 end
                 # parent with unallowed unattached child
                 Redmine::MenuManager.map :menu2 do |menu|
                   menu.push(:parent_node, nil, {:children => Proc.new {|p|
                      [Redmine::MenuManager::MenuItem.new("test_child_unallowed", {:controller => 'issues', :action => 'new'}, {})]
                    } })
                 end
                 # parent with unallowed standard child
                 Redmine::MenuManager.map :menu3 do |menu|
                   menu.push(:parent_node, nil, {})
                   menu.push(:test_child_unallowed, {:controller =>'issues', :action => 'new'}, {:parent => :parent_node})
                 end
                 # should not be displayed to anonymous
                 User.current = User.find(6)
                 assert_nil render_menu(:menu1, Project.find(1))
                 assert_nil render_menu(:menu2, Project.find(1))
                 assert_nil render_menu(:menu3, Project.find(1))
                 # should be displayed to an admin
                 User.current = User.find(1)
                 @output_buffer = render_menu(:menu2, Project.find(1))
                 assert_select("ul li a.parent-node", "Parent node")
                 @output_buffer = render_menu(:menu3, Project.find(1))
                 assert_select("ul li a.parent-node", "Parent node")
               end
               def test_render_menu_node_with_children_without_an_array
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
                                                                  '/test',
                                                                  {
                                                                    :children => Proc.new {|p| Redmine::MenuManager::MenuItem.new("test_child", "/testing", {})}
                                                                  })
                 assert_raises Redmine::MenuManager::MenuError, ":children must be an array of MenuItems" do
                   @output_buffer = render_menu_node(parent_node, Project.find(1))
                 end
               end
               def test_render_menu_node_with_incorrect_children
                 parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
                                                                  '/test',
                                                                  {
                                                                    :children => Proc.new {|p| ["a string"] }
                                                                  })
                 assert_raises Redmine::MenuManager::MenuError, ":children must be an array of MenuItems" do
                   @output_buffer = render_menu_node(parent_node, Project.find(1))
                 end
               end
               def test_menu_items_for_should_yield_all_items_if_passed_a_block
                 menu_name = :test_menu_items_for_should_yield_all_items_if_passed_a_block
                 Redmine::MenuManager.map menu_name do |menu|
                   menu.push(:a_menu, '/', { })
                   menu.push(:a_menu_2, '/', { })
                   menu.push(:a_menu_3, '/', { })
                 end
                 items_yielded = []
                 menu_items_for(menu_name) do |item|
                   items_yielded << item
                 end
                 assert_equal 3, items_yielded.size
               end
               def test_menu_items_for_should_return_all_items
                 menu_name = :test_menu_items_for_should_return_all_items
                 Redmine::MenuManager.map menu_name do |menu|
                   menu.push(:a_menu, '/', { })
                   menu.push(:a_menu_2, '/', { })
                   menu.push(:a_menu_3, '/', { })
                 end
                 items = menu_items_for(menu_name)
                 assert_equal 3, items.size
               end
               def test_menu_items_for_should_skip_unallowed_items_on_a_project
                 menu_name = :test_menu_items_for_should_skip_unallowed_items_on_a_project
                 Redmine::MenuManager.map menu_name do |menu|
                   menu.push(:a_menu, {:controller => 'issues', :action => 'index' }, { })
                   menu.push(:a_menu_2, {:controller => 'issues', :action => 'index' }, { })
                   menu.push(:unallowed, {:controller => 'issues', :action => 'unallowed' }, { })
                 end
                 User.current = User.find(2)
                 items = menu_items_for(menu_name, Project.find(1))
                 assert_equal 2, items.size
               end
               def test_menu_items_for_should_skip_items_that_fail_the_permission
                 menu_name = :test_menu_items_for_should_skip_items_that_fail_the_permission
                 Redmine::MenuManager.map menu_name do |menu|
                   menu.push(:a_menu, :project_issues_path)
                   menu.push(:unallowed, :project_issues_path, :permission => :unallowed)
                 end
                 User.current = User.find(2)
                 items = menu_items_for(menu_name, Project.find(1))
                 assert_equal 1, items.size
               end
               def test_menu_items_for_should_skip_items_that_fail_the_conditions
                 menu_name = :test_menu_items_for_should_skip_items_that_fail_the_conditions
                 Redmine::MenuManager.map menu_name do |menu|
                   menu.push(:a_menu, {:controller => 'issues', :action => 'index' }, { })
                   menu.push(:unallowed,
                             {:controller => 'issues', :action => 'index' },
                             { :if => Proc.new { false }})
                 end
                 User.current = User.find(2)
                 items = menu_items_for(menu_name, Project.find(1))
                 assert_equal 1, items.size
               end
             end

test/unit/lib/redmine/views/labelled_form_builder_test.rb +2 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../../../test_helper', __FILE__)
-            class Redmine::Views::LabelledFormBuilderTest < ActionView::TestCase
+            class Redmine::Views::LabelledFormBuilderTest < Redmine::HelperTest
+              include Rails.application.routes.url_helpers
               def test_label_should_output_one_element
                 set_language_if_valid 'en'
                 labelled_form_for(Issue.new) do |f|
                   output = f.label :subject
                   assert_equal output, '<label for="issue_subject">Subject</label>'
                 end
               end
             end

test/unit/lib/redmine/wiki_formatting/macros_test.rb +2 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../../../test_helper', __FILE__)
-            class Redmine::WikiFormatting::MacrosTest < ActionView::TestCase
+            class Redmine::WikiFormatting::MacrosTest < Redmine::HelperTest
               include ApplicationHelper
               include ActionView::Helpers::TextHelper
               include ActionView::Helpers::SanitizeHelper
               include ERB::Util
+              include Rails.application.routes.url_helpers
               extend ActionView::Helpers::SanitizeHelper::ClassMethods
               fixtures :projects, :roles, :enabled_modules, :users,
                                   :repositories, :changesets,
                                   :trackers, :issue_statuses, :issues,
                                   :versions, :documents,
                                   :wikis, :wiki_pages, :wiki_contents,
                                   :boards, :messages,
                                   :attachments
               def setup
                 super
                 @project = nil
               end
               def teardown
               end
               def test_macro_registration
                 Redmine::WikiFormatting::Macros.register do
                   macro :foo do |obj, args|
                     "Foo: #{args.size} (#{args.join(',')}) (#{args.class.name})"
                   end
                 end
                 assert_equal '<p>Foo: 0 () (Array)</p>', textilizable("{{foo}}")
                 assert_equal '<p>Foo: 0 () (Array)</p>', textilizable("{{foo()}}")
                 assert_equal '<p>Foo: 1 (arg1) (Array)</p>', textilizable("{{foo(arg1)}}")
                 assert_equal '<p>Foo: 2 (arg1,arg2) (Array)</p>', textilizable("{{foo(arg1, arg2)}}")
               end
               def test_macro_registration_parse_args_set_to_false_should_disable_arguments_parsing
                 Redmine::WikiFormatting::Macros.register do
                   macro :bar, :parse_args => false do |obj, args|
                     "Bar: (#{args}) (#{args.class.name})"
                   end
                 end
                 assert_equal '<p>Bar: (args, more args) (String)</p>', textilizable("{{bar(args, more args)}}")
                 assert_equal '<p>Bar: () (String)</p>', textilizable("{{bar}}")
                 assert_equal '<p>Bar: () (String)</p>', textilizable("{{bar()}}")
               end
               def test_macro_registration_with_3_args_should_receive_text_argument
                 Redmine::WikiFormatting::Macros.register do
                   macro :baz do |obj, args, text|
                     "Baz: (#{args.join(',')}) (#{text.class.name}) (#{text})"
                   end
                 end
                 assert_equal "<p>Baz: () (NilClass) ()</p>", textilizable("{{baz}}")
                 assert_equal "<p>Baz: () (NilClass) ()</p>", textilizable("{{baz()}}")
                 assert_equal "<p>Baz: () (String) (line1\nline2)</p>", textilizable("{{baz()\nline1\nline2\n}}")
                 assert_equal "<p>Baz: (arg1,arg2) (String) (line1\nline2)</p>", textilizable("{{baz(arg1, arg2)\nline1\nline2\n}}")
               end
               def test_macro_name_with_upper_case
                 Redmine::WikiFormatting::Macros.macro(:UpperCase) {|obj, args| "Upper"}
                 assert_equal "<p>Upper</p>", textilizable("{{UpperCase}}")
               end
               def test_multiple_macros_on_the_same_line
                 Redmine::WikiFormatting::Macros.macro :foo do |obj, args|
                   args.any? ? "args: #{args.join(',')}" : "no args"
                 end
                 assert_equal '<p>no args no args</p>', textilizable("{{foo}} {{foo}}")
                 assert_equal '<p>args: a,b no args</p>', textilizable("{{foo(a,b)}} {{foo}}")
                 assert_equal '<p>args: a,b args: c,d</p>', textilizable("{{foo(a,b)}} {{foo(c,d)}}")
                 assert_equal '<p>no args args: c,d</p>', textilizable("{{foo}} {{foo(c,d)}}")
               end
               def test_macro_should_receive_the_object_as_argument_when_with_object_and_attribute
                 issue = Issue.find(1)
                 issue.description = "{{hello_world}}"
                 assert_equal '<p>Hello world! Object: Issue, Called with no argument and no block of text.</p>', textilizable(issue, :description)
               end
               def test_macro_should_receive_the_object_as_argument_when_called_with_object_option
                 text = "{{hello_world}}"
                 assert_equal '<p>Hello world! Object: Issue, Called with no argument and no block of text.</p>', textilizable(text, :object => Issue.find(1))
               end
               def test_extract_macro_options_should_with_args
                 options = extract_macro_options(["arg1", "arg2"], :foo, :size)
                 assert_equal([["arg1", "arg2"], {}], options)
               end
               def test_extract_macro_options_should_with_options
                 options = extract_macro_options(["foo=bar", "size=2"], :foo, :size)
                 assert_equal([[], {:foo => "bar", :size => "2"}], options)
               end
               def test_extract_macro_options_should_with_args_and_options
                 options = extract_macro_options(["arg1", "arg2", "foo=bar", "size=2"], :foo, :size)
                 assert_equal([["arg1", "arg2"], {:foo => "bar", :size => "2"}], options)
               end
               def test_extract_macro_options_should_parse_options_lazily
                 options = extract_macro_options(["params=x=1&y=2"], :params)
                 assert_equal([[], {:params => "x=1&y=2"}], options)
               end
               def test_macro_exception_should_be_displayed
                 Redmine::WikiFormatting::Macros.macro :exception do |obj, args|
                   raise "My message"
                 end
                 text = "{{exception}}"
                 assert_include '<div class="flash error">Error executing the <strong>exception</strong> macro (My message)</div>', textilizable(text)
               end
               def test_macro_arguments_should_not_be_parsed_by_formatters
                 text = '{{hello_world(http://www.redmine.org, #1)}}'
                 assert_include 'Arguments: http://www.redmine.org, #1', textilizable(text)
               end
               def test_exclamation_mark_should_not_run_macros
                 text = "!{{hello_world}}"
                 assert_equal '<p>{{hello_world}}</p>', textilizable(text)
               end
               def test_exclamation_mark_should_escape_macros
                 text = "!{{hello_world(<tag>)}}"
                 assert_equal '<p>{{hello_world(&lt;tag&gt;)}}</p>', textilizable(text)
               end
               def test_unknown_macros_should_not_be_replaced
                 text = "{{unknown}}"
                 assert_equal '<p>{{unknown}}</p>', textilizable(text)
               end
               def test_unknown_macros_should_parsed_as_text
                 text = "{{unknown(*test*)}}"
                 assert_equal '<p>{{unknown(<strong>test</strong>)}}</p>', textilizable(text)
               end
               def test_unknown_macros_should_be_escaped
                 text = "{{unknown(<tag>)}}"
                 assert_equal '<p>{{unknown(&lt;tag&gt;)}}</p>', textilizable(text)
               end
               def test_html_safe_macro_output_should_not_be_escaped
                 Redmine::WikiFormatting::Macros.macro :safe_macro do |obj, args|
                   "<tag>".html_safe
                 end
                 assert_equal '<p><tag></p>', textilizable("{{safe_macro}}")
               end
               def test_macro_hello_world
                 text = "{{hello_world}}"
                 assert textilizable(text).match(/Hello world!/)
               end
               def test_macro_hello_world_should_escape_arguments
                 text = "{{hello_world(<tag>)}}"
                 assert_include 'Arguments: &lt;tag&gt;', textilizable(text)
               end
               def test_macro_macro_list
                 text = "{{macro_list}}"
                 assert_match %r{<code>hello_world</code>}, textilizable(text)
               end
               def test_macro_include
                 @project = Project.find(1)
                 # include a page of the current project wiki
                 text = "{{include(Another page)}}"
                 assert_include 'This is a link to a ticket', textilizable(text)
                 @project = nil
                 # include a page of a specific project wiki
                 text = "{{include(ecookbook:Another page)}}"
                 assert_include 'This is a link to a ticket', textilizable(text)
                 text = "{{include(ecookbook:)}}"
                 assert_include 'CookBook documentation', textilizable(text)
                 text = "{{include(unknowidentifier:somepage)}}"
                 assert_include 'Page not found', textilizable(text)
               end
               def test_macro_collapse
                 text = "{{collapse\n*Collapsed* block of text\n}}"
                 with_locale 'en' do
                   result = textilizable(text)
                   assert_select_in result, 'div.collapsed-text'
                   assert_select_in result, 'strong', :text => 'Collapsed'
                   assert_select_in result, 'a.collapsible.collapsed', :text => 'Show'
                   assert_select_in result, 'a.collapsible', :text => 'Hide'
                 end
               end
               def test_macro_collapse_with_one_arg
                 text = "{{collapse(Example)\n*Collapsed* block of text\n}}"
                 result = textilizable(text)
                 assert_select_in result, 'div.collapsed-text'
                 assert_select_in result, 'strong', :text => 'Collapsed'
                 assert_select_in result, 'a.collapsible.collapsed', :text => 'Example'
                 assert_select_in result, 'a.collapsible', :text => 'Example'
               end
               def test_macro_collapse_with_two_args
                 text = "{{collapse(Show example, Hide example)\n*Collapsed* block of text\n}}"
                 result = textilizable(text)
                 assert_select_in result, 'div.collapsed-text'
                 assert_select_in result, 'strong', :text => 'Collapsed'
                 assert_select_in result, 'a.collapsible.collapsed', :text => 'Show example'
                 assert_select_in result, 'a.collapsible', :text => 'Hide example'
               end
               def test_macro_collapse_should_not_break_toc
                 text =  <<-RAW
             {{toc}}
             h1. Title
             {{collapse(Show example, Hide example)
             h2. Heading
             }}"
             RAW
                 expected_toc = '<ul class="toc"><li><a href="#Title">Title</a><ul><li><a href="#Heading">Heading</a></li></ul></li></ul>'
                 assert_include expected_toc, textilizable(text).gsub(/[\r\n]/, '')
               end
               def test_macro_child_pages
                 expected =  "<p><ul class=\"pages-hierarchy\">\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_1\">Child 1</a>\n" +
                              "<ul class=\"pages-hierarchy\">\n<li><a href=\"/projects/ecookbook/wiki/Child_1_1\">Child 1 1</a></li>\n</ul>\n</li>\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_2\">Child 2</a></li>\n" +
                              "</ul>\n</p>"
                 @project = Project.find(1)
                 # child pages of the current wiki page
                 assert_equal expected, textilizable("{{child_pages}}", :object => WikiPage.find(2).content)
                 # child pages of another page
                 assert_equal expected, textilizable("{{child_pages(Another_page)}}", :object => WikiPage.find(1).content)
                 @project = Project.find(2)
                 assert_equal expected, textilizable("{{child_pages(ecookbook:Another_page)}}", :object => WikiPage.find(1).content)
               end
               def test_macro_child_pages_with_parent_option
                 expected =  "<p><ul class=\"pages-hierarchy\">\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Another_page\">Another page</a>\n" +
                              "<ul class=\"pages-hierarchy\">\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_1\">Child 1</a>\n" +
                              "<ul class=\"pages-hierarchy\">\n<li><a href=\"/projects/ecookbook/wiki/Child_1_1\">Child 1 1</a></li>\n</ul>\n</li>\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_2\">Child 2</a></li>\n" +
                              "</ul>\n</li>\n</ul>\n</p>"
                 @project = Project.find(1)
                 # child pages of the current wiki page
                 assert_equal expected, textilizable("{{child_pages(parent=1)}}", :object => WikiPage.find(2).content)
                 # child pages of another page
                 assert_equal expected, textilizable("{{child_pages(Another_page, parent=1)}}", :object => WikiPage.find(1).content)
                 @project = Project.find(2)
                 assert_equal expected, textilizable("{{child_pages(ecookbook:Another_page, parent=1)}}", :object => WikiPage.find(1).content)
               end
               def test_macro_child_pages_with_depth_option
                 expected =  "<p><ul class=\"pages-hierarchy\">\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_1\">Child 1</a></li>\n" +
                              "<li><a href=\"/projects/ecookbook/wiki/Child_2\">Child 2</a></li>\n" +
                              "</ul>\n</p>"
                 @project = Project.find(1)
                 assert_equal expected, textilizable("{{child_pages(depth=1)}}", :object => WikiPage.find(2).content)
               end
               def test_macro_child_pages_without_wiki_page_should_fail
                 assert_match /can be called from wiki pages only/, textilizable("{{child_pages}}")
               end
               def test_macro_thumbnail
                 link = link_to('<img alt="testfile.PNG" src="/attachments/thumbnail/17" />'.html_safe,
                                "/attachments/17",
                                :class => "thumbnail",
                                :title => "testfile.PNG")
                 assert_equal "<p>#{link}</p>",
                              textilizable("{{thumbnail(testfile.png)}}", :object => Issue.find(14))
               end
               def test_macro_thumbnail_with_full_path
                 link = link_to('<img alt="testfile.PNG" src="http://test.host/attachments/thumbnail/17" />'.html_safe,
                                "http://test.host/attachments/17",
                                :class => "thumbnail",
                                :title => "testfile.PNG")
                 assert_equal "<p>#{link}</p>",
                              textilizable("{{thumbnail(testfile.png)}}", :object => Issue.find(14), :only_path => false)
               end
               def test_macro_thumbnail_with_size
                 link = link_to('<img alt="testfile.PNG" src="/attachments/thumbnail/17/200" />'.html_safe,
                                "/attachments/17",
                                :class => "thumbnail",
                                :title => "testfile.PNG")
                 assert_equal "<p>#{link}</p>",
                              textilizable("{{thumbnail(testfile.png, size=200)}}", :object => Issue.find(14))
               end
               def test_macro_thumbnail_with_title
                 link = link_to('<img alt="testfile.PNG" src="/attachments/thumbnail/17" />'.html_safe,
                                "/attachments/17",
                                :class => "thumbnail",
                                :title => "Cool image")
                 assert_equal "<p>#{link}</p>",
                              textilizable("{{thumbnail(testfile.png, title=Cool image)}}", :object => Issue.find(14))
               end
               def test_macro_thumbnail_with_invalid_filename_should_fail
                 assert_include 'test.png not found',
                   textilizable("{{thumbnail(test.png)}}", :object => Issue.find(14))
               end
               def test_macros_should_not_be_executed_in_pre_tags
                 text = <<-RAW
             {{hello_world(foo)}}
             <pre>
             {{hello_world(pre)}}
             !{{hello_world(pre)}}
             </pre>
             {{hello_world(bar)}}
             RAW
                 expected = <<-EXPECTED
             <p>Hello world! Object: NilClass, Arguments: foo and no block of text.</p>
             <pre>
             {{hello_world(pre)}}
             !{{hello_world(pre)}}
             </pre>
             <p>Hello world! Object: NilClass, Arguments: bar and no block of text.</p>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(text).gsub(%r{[\r\n\t]}, '')
               end
               def test_macros_should_be_escaped_in_pre_tags
                 text = "<pre>{{hello_world(<tag>)}}</pre>"
                 assert_equal "<pre>{{hello_world(&lt;tag&gt;)}}</pre>", textilizable(text)
               end
               def test_macros_should_not_mangle_next_macros_outputs
                 text = '{{macro(2)}} !{{macro(2)}} {{hello_world(foo)}}'
                 assert_equal '<p>{{macro(2)}} {{macro(2)}} Hello world! Object: NilClass, Arguments: foo and no block of text.</p>', textilizable(text)
               end
               def test_macros_with_text_should_not_mangle_following_macros
                 text = <<-RAW
             {{hello_world
             Line of text
             }}
             {{hello_world
             Another line of text
             }}
             RAW
                 expected = <<-EXPECTED
             <p>Hello world! Object: NilClass, Called with no argument and a 12 bytes long block of text.</p>
             <p>Hello world! Object: NilClass, Called with no argument and a 20 bytes long block of text.</p>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(text).gsub(%r{[\r\n\t]}, '')
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages