##// END OF EJS Templates
Merged r15223 and r15225 (#22127)....
Jean-Philippe Lang -
r14849:fdc0782be1d6
parent child
Show More
@@ -1,1651 +1,1662
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21 include Redmine::I18n
22 22 before_save :set_parent_id
23 23 include Redmine::NestedSet::IssueNestedSet
24 24
25 25 belongs_to :project
26 26 belongs_to :tracker
27 27 belongs_to :status, :class_name => 'IssueStatus'
28 28 belongs_to :author, :class_name => 'User'
29 29 belongs_to :assigned_to, :class_name => 'Principal'
30 30 belongs_to :fixed_version, :class_name => 'Version'
31 31 belongs_to :priority, :class_name => 'IssuePriority'
32 32 belongs_to :category, :class_name => 'IssueCategory'
33 33
34 34 has_many :journals, :as => :journalized, :dependent => :destroy, :inverse_of => :journalized
35 35 has_many :visible_journals,
36 36 lambda {where(["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false])},
37 37 :class_name => 'Journal',
38 38 :as => :journalized
39 39
40 40 has_many :time_entries, :dependent => :destroy
41 41 has_and_belongs_to_many :changesets, lambda {order("#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC")}
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
47 47 acts_as_customizable
48 48 acts_as_watchable
49 49 acts_as_searchable :columns => ['subject', "#{table_name}.description"],
50 50 :preload => [:project, :status, :tracker],
51 51 :scope => lambda {|options| options[:open_issues] ? self.open : self.all}
52 52
53 53 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
54 54 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
55 55 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
56 56
57 57 acts_as_activity_provider :scope => preload(:project, :author, :tracker),
58 58 :author_key => :author_id
59 59
60 60 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
61 61
62 62 attr_reader :current_journal
63 63 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
64 64
65 65 validates_presence_of :subject, :project, :tracker
66 66 validates_presence_of :priority, :if => Proc.new {|issue| issue.new_record? || issue.priority_id_changed?}
67 67 validates_presence_of :status, :if => Proc.new {|issue| issue.new_record? || issue.status_id_changed?}
68 68 validates_presence_of :author, :if => Proc.new {|issue| issue.new_record? || issue.author_id_changed?}
69 69
70 70 validates_length_of :subject, :maximum => 255
71 71 validates_inclusion_of :done_ratio, :in => 0..100
72 72 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
73 73 validates :start_date, :date => true
74 74 validates :due_date, :date => true
75 75 validate :validate_issue, :validate_required_fields
76 76 attr_protected :id
77 77
78 78 scope :visible, lambda {|*args|
79 79 joins(:project).
80 80 where(Issue.visible_condition(args.shift || User.current, *args))
81 81 }
82 82
83 83 scope :open, lambda {|*args|
84 84 is_closed = args.size > 0 ? !args.first : false
85 85 joins(:status).
86 86 where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
87 87 }
88 88
89 89 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
90 90 scope :on_active_project, lambda {
91 91 joins(:project).
92 92 where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
93 93 }
94 94 scope :fixed_version, lambda {|versions|
95 95 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
96 96 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
97 97 }
98 98
99 99 before_validation :clear_disabled_fields
100 100 before_create :default_assign
101 101 before_save :close_duplicates, :update_done_ratio_from_issue_status,
102 102 :force_updated_on_change, :update_closed_on, :set_assigned_to_was
103 103 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
104 104 after_save :reschedule_following_issues, :update_nested_set_attributes,
105 105 :update_parent_attributes, :create_journal
106 106 # Should be after_create but would be called before previous after_save callbacks
107 107 after_save :after_create_from_copy
108 108 after_destroy :update_parent_attributes
109 109 after_create :send_notification
110 110 # Keep it at the end of after_save callbacks
111 111 after_save :clear_assigned_to_was
112 112
113 113 # Returns a SQL conditions string used to find all issues visible by the specified user
114 114 def self.visible_condition(user, options={})
115 115 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
116 116 if user.id && user.logged?
117 117 case role.issues_visibility
118 118 when 'all'
119 119 nil
120 120 when 'default'
121 121 user_ids = [user.id] + user.groups.map(&:id).compact
122 122 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
123 123 when 'own'
124 124 user_ids = [user.id] + user.groups.map(&:id).compact
125 125 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
126 126 else
127 127 '1=0'
128 128 end
129 129 else
130 130 "(#{table_name}.is_private = #{connection.quoted_false})"
131 131 end
132 132 end
133 133 end
134 134
135 135 # Returns true if usr or current user is allowed to view the issue
136 136 def visible?(usr=nil)
137 137 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
138 138 if user.logged?
139 139 case role.issues_visibility
140 140 when 'all'
141 141 true
142 142 when 'default'
143 143 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
144 144 when 'own'
145 145 self.author == user || user.is_or_belongs_to?(assigned_to)
146 146 else
147 147 false
148 148 end
149 149 else
150 150 !self.is_private?
151 151 end
152 152 end
153 153 end
154 154
155 155 # Returns true if user or current user is allowed to edit or add a note to the issue
156 156 def editable?(user=User.current)
157 157 attributes_editable?(user) || user.allowed_to?(:add_issue_notes, project)
158 158 end
159 159
160 160 # Returns true if user or current user is allowed to edit the issue
161 161 def attributes_editable?(user=User.current)
162 162 user.allowed_to?(:edit_issues, project)
163 163 end
164 164
165 165 def initialize(attributes=nil, *args)
166 166 super
167 167 if new_record?
168 168 # set default values for new records only
169 169 self.priority ||= IssuePriority.default
170 170 self.watcher_user_ids = []
171 171 end
172 172 end
173 173
174 174 def create_or_update
175 175 super
176 176 ensure
177 177 @status_was = nil
178 178 end
179 179 private :create_or_update
180 180
181 181 # AR#Persistence#destroy would raise and RecordNotFound exception
182 182 # if the issue was already deleted or updated (non matching lock_version).
183 183 # This is a problem when bulk deleting issues or deleting a project
184 184 # (because an issue may already be deleted if its parent was deleted
185 185 # first).
186 186 # The issue is reloaded by the nested_set before being deleted so
187 187 # the lock_version condition should not be an issue but we handle it.
188 188 def destroy
189 189 super
190 190 rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotFound
191 191 # Stale or already deleted
192 192 begin
193 193 reload
194 194 rescue ActiveRecord::RecordNotFound
195 195 # The issue was actually already deleted
196 196 @destroyed = true
197 197 return freeze
198 198 end
199 199 # The issue was stale, retry to destroy
200 200 super
201 201 end
202 202
203 203 alias :base_reload :reload
204 204 def reload(*args)
205 205 @workflow_rule_by_attribute = nil
206 206 @assignable_versions = nil
207 207 @relations = nil
208 208 @spent_hours = nil
209 209 @total_spent_hours = nil
210 210 @total_estimated_hours = nil
211 211 base_reload(*args)
212 212 end
213 213
214 214 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
215 215 def available_custom_fields
216 216 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
217 217 end
218 218
219 219 def visible_custom_field_values(user=nil)
220 220 user_real = user || User.current
221 221 custom_field_values.select do |value|
222 222 value.custom_field.visible_by?(project, user_real)
223 223 end
224 224 end
225 225
226 226 # Copies attributes from another issue, arg can be an id or an Issue
227 227 def copy_from(arg, options={})
228 228 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
229 229 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
230 230 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
231 231 self.status = issue.status
232 232 self.author = User.current
233 233 unless options[:attachments] == false
234 234 self.attachments = issue.attachments.map do |attachement|
235 235 attachement.copy(:container => self)
236 236 end
237 237 end
238 238 @copied_from = issue
239 239 @copy_options = options
240 240 self
241 241 end
242 242
243 243 # Returns an unsaved copy of the issue
244 244 def copy(attributes=nil, copy_options={})
245 245 copy = self.class.new.copy_from(self, copy_options)
246 246 copy.attributes = attributes if attributes
247 247 copy
248 248 end
249 249
250 250 # Returns true if the issue is a copy
251 251 def copy?
252 252 @copied_from.present?
253 253 end
254 254
255 255 def status_id=(status_id)
256 256 if status_id.to_s != self.status_id.to_s
257 257 self.status = (status_id.present? ? IssueStatus.find_by_id(status_id) : nil)
258 258 end
259 259 self.status_id
260 260 end
261 261
262 262 # Sets the status.
263 263 def status=(status)
264 264 if status != self.status
265 265 @workflow_rule_by_attribute = nil
266 266 end
267 267 association(:status).writer(status)
268 268 end
269 269
270 270 def priority_id=(pid)
271 271 self.priority = nil
272 272 write_attribute(:priority_id, pid)
273 273 end
274 274
275 275 def category_id=(cid)
276 276 self.category = nil
277 277 write_attribute(:category_id, cid)
278 278 end
279 279
280 280 def fixed_version_id=(vid)
281 281 self.fixed_version = nil
282 282 write_attribute(:fixed_version_id, vid)
283 283 end
284 284
285 285 def tracker_id=(tracker_id)
286 286 if tracker_id.to_s != self.tracker_id.to_s
287 287 self.tracker = (tracker_id.present? ? Tracker.find_by_id(tracker_id) : nil)
288 288 end
289 289 self.tracker_id
290 290 end
291 291
292 292 # Sets the tracker.
293 293 # This will set the status to the default status of the new tracker if:
294 294 # * the status was the default for the previous tracker
295 295 # * or if the status was not part of the new tracker statuses
296 296 # * or the status was nil
297 297 def tracker=(tracker)
298 298 if tracker != self.tracker
299 299 if status == default_status
300 300 self.status = nil
301 301 elsif status && tracker && !tracker.issue_status_ids.include?(status.id)
302 302 self.status = nil
303 303 end
304 304 @custom_field_values = nil
305 305 @workflow_rule_by_attribute = nil
306 306 end
307 307 association(:tracker).writer(tracker)
308 308 self.status ||= default_status
309 309 self.tracker
310 310 end
311 311
312 312 def project_id=(project_id)
313 313 if project_id.to_s != self.project_id.to_s
314 314 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
315 315 end
316 316 self.project_id
317 317 end
318 318
319 319 # Sets the project.
320 320 # Unless keep_tracker argument is set to true, this will change the tracker
321 321 # to the first tracker of the new project if the previous tracker is not part
322 322 # of the new project trackers.
323 323 # This will clear the fixed_version is it's no longer valid for the new project.
324 324 # This will clear the parent issue if it's no longer valid for the new project.
325 325 # This will set the category to the category with the same name in the new
326 326 # project if it exists, or clear it if it doesn't.
327 327 def project=(project, keep_tracker=false)
328 328 project_was = self.project
329 329 association(:project).writer(project)
330 330 if project_was && project && project_was != project
331 331 @assignable_versions = nil
332 332
333 333 unless keep_tracker || project.trackers.include?(tracker)
334 334 self.tracker = project.trackers.first
335 335 end
336 336 # Reassign to the category with same name if any
337 337 if category
338 338 self.category = project.issue_categories.find_by_name(category.name)
339 339 end
340 340 # Keep the fixed_version if it's still valid in the new_project
341 341 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
342 342 self.fixed_version = nil
343 343 end
344 344 # Clear the parent task if it's no longer valid
345 345 unless valid_parent_project?
346 346 self.parent_issue_id = nil
347 347 end
348 348 @custom_field_values = nil
349 349 @workflow_rule_by_attribute = nil
350 350 end
351 351 self.project
352 352 end
353 353
354 354 def description=(arg)
355 355 if arg.is_a?(String)
356 356 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
357 357 end
358 358 write_attribute(:description, arg)
359 359 end
360 360
361 361 # Overrides assign_attributes so that project and tracker get assigned first
362 362 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
363 363 return if new_attributes.nil?
364 364 attrs = new_attributes.dup
365 365 attrs.stringify_keys!
366 366
367 367 %w(project project_id tracker tracker_id).each do |attr|
368 368 if attrs.has_key?(attr)
369 369 send "#{attr}=", attrs.delete(attr)
370 370 end
371 371 end
372 372 send :assign_attributes_without_project_and_tracker_first, attrs, *args
373 373 end
374 374 # Do not redefine alias chain on reload (see #4838)
375 375 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
376 376
377 377 def attributes=(new_attributes)
378 378 assign_attributes new_attributes
379 379 end
380 380
381 381 def estimated_hours=(h)
382 382 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
383 383 end
384 384
385 385 safe_attributes 'project_id',
386 386 'tracker_id',
387 387 'status_id',
388 388 'category_id',
389 389 'assigned_to_id',
390 390 'priority_id',
391 391 'fixed_version_id',
392 392 'subject',
393 393 'description',
394 394 'start_date',
395 395 'due_date',
396 396 'done_ratio',
397 397 'estimated_hours',
398 398 'custom_field_values',
399 399 'custom_fields',
400 400 'lock_version',
401 401 'notes',
402 402 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
403 403
404 404 safe_attributes 'notes',
405 405 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
406 406
407 407 safe_attributes 'private_notes',
408 408 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
409 409
410 410 safe_attributes 'watcher_user_ids',
411 411 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
412 412
413 413 safe_attributes 'is_private',
414 414 :if => lambda {|issue, user|
415 415 user.allowed_to?(:set_issues_private, issue.project) ||
416 416 (issue.author_id == user.id && user.allowed_to?(:set_own_issues_private, issue.project))
417 417 }
418 418
419 419 safe_attributes 'parent_issue_id',
420 420 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
421 421 user.allowed_to?(:manage_subtasks, issue.project)}
422 422
423 423 def safe_attribute_names(user=nil)
424 424 names = super
425 425 names -= disabled_core_fields
426 426 names -= read_only_attribute_names(user)
427 427 if new_record?
428 428 # Make sure that project_id can always be set for new issues
429 429 names |= %w(project_id)
430 430 end
431 431 if dates_derived?
432 432 names -= %w(start_date due_date)
433 433 end
434 434 if priority_derived?
435 435 names -= %w(priority_id)
436 436 end
437 437 if done_ratio_derived?
438 438 names -= %w(done_ratio)
439 439 end
440 440 names
441 441 end
442 442
443 443 # Safely sets attributes
444 444 # Should be called from controllers instead of #attributes=
445 445 # attr_accessible is too rough because we still want things like
446 446 # Issue.new(:project => foo) to work
447 447 def safe_attributes=(attrs, user=User.current)
448 448 return unless attrs.is_a?(Hash)
449 449
450 450 attrs = attrs.deep_dup
451 451
452 452 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
453 453 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
454 454 if allowed_target_projects(user).where(:id => p.to_i).exists?
455 455 self.project_id = p
456 456 end
457 457 end
458 458
459 459 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
460 460 self.tracker_id = t
461 461 end
462 462 if project
463 463 # Set the default tracker to accept custom field values
464 464 # even if tracker is not specified
465 465 self.tracker ||= project.trackers.first
466 466 end
467 467
468 468 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
469 469 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
470 470 self.status_id = s
471 471 end
472 472 end
473 if (u = attrs.delete('assigned_to_id')) && safe_attribute?('assigned_to_id')
474 if u.blank?
475 self.assigned_to_id = nil
476 else
477 u = u.to_i
478 if assignable_users.any?{|assignable_user| assignable_user.id == u}
479 self.assigned_to_id = u
480 end
481 end
482 end
483
473 484
474 485 attrs = delete_unsafe_attributes(attrs, user)
475 486 return if attrs.empty?
476 487
477 488 if attrs['parent_issue_id'].present?
478 489 s = attrs['parent_issue_id'].to_s
479 490 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
480 491 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
481 492 end
482 493 end
483 494
484 495 if attrs['custom_field_values'].present?
485 496 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
486 497 attrs['custom_field_values'].select! {|k, v| editable_custom_field_ids.include?(k.to_s)}
487 498 end
488 499
489 500 if attrs['custom_fields'].present?
490 501 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
491 502 attrs['custom_fields'].select! {|c| editable_custom_field_ids.include?(c['id'].to_s)}
492 503 end
493 504
494 505 # mass-assignment security bypass
495 506 assign_attributes attrs, :without_protection => true
496 507 end
497 508
498 509 def disabled_core_fields
499 510 tracker ? tracker.disabled_core_fields : []
500 511 end
501 512
502 513 # Returns the custom_field_values that can be edited by the given user
503 514 def editable_custom_field_values(user=nil)
504 515 visible_custom_field_values(user).reject do |value|
505 516 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
506 517 end
507 518 end
508 519
509 520 # Returns the custom fields that can be edited by the given user
510 521 def editable_custom_fields(user=nil)
511 522 editable_custom_field_values(user).map(&:custom_field).uniq
512 523 end
513 524
514 525 # Returns the names of attributes that are read-only for user or the current user
515 526 # For users with multiple roles, the read-only fields are the intersection of
516 527 # read-only fields of each role
517 528 # The result is an array of strings where sustom fields are represented with their ids
518 529 #
519 530 # Examples:
520 531 # issue.read_only_attribute_names # => ['due_date', '2']
521 532 # issue.read_only_attribute_names(user) # => []
522 533 def read_only_attribute_names(user=nil)
523 534 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
524 535 end
525 536
526 537 # Returns the names of required attributes for user or the current user
527 538 # For users with multiple roles, the required fields are the intersection of
528 539 # required fields of each role
529 540 # The result is an array of strings where sustom fields are represented with their ids
530 541 #
531 542 # Examples:
532 543 # issue.required_attribute_names # => ['due_date', '2']
533 544 # issue.required_attribute_names(user) # => []
534 545 def required_attribute_names(user=nil)
535 546 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
536 547 end
537 548
538 549 # Returns true if the attribute is required for user
539 550 def required_attribute?(name, user=nil)
540 551 required_attribute_names(user).include?(name.to_s)
541 552 end
542 553
543 554 # Returns a hash of the workflow rule by attribute for the given user
544 555 #
545 556 # Examples:
546 557 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
547 558 def workflow_rule_by_attribute(user=nil)
548 559 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
549 560
550 561 user_real = user || User.current
551 562 roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
552 563 roles = roles.select(&:consider_workflow?)
553 564 return {} if roles.empty?
554 565
555 566 result = {}
556 567 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).to_a
557 568 if workflow_permissions.any?
558 569 workflow_rules = workflow_permissions.inject({}) do |h, wp|
559 570 h[wp.field_name] ||= {}
560 571 h[wp.field_name][wp.role_id] = wp.rule
561 572 h
562 573 end
563 574 fields_with_roles = {}
564 575 IssueCustomField.where(:visible => false).joins(:roles).pluck(:id, "role_id").each do |field_id, role_id|
565 576 fields_with_roles[field_id] ||= []
566 577 fields_with_roles[field_id] << role_id
567 578 end
568 579 roles.each do |role|
569 580 fields_with_roles.each do |field_id, role_ids|
570 581 unless role_ids.include?(role.id)
571 582 field_name = field_id.to_s
572 583 workflow_rules[field_name] ||= {}
573 584 workflow_rules[field_name][role.id] = 'readonly'
574 585 end
575 586 end
576 587 end
577 588 workflow_rules.each do |attr, rules|
578 589 next if rules.size < roles.size
579 590 uniq_rules = rules.values.uniq
580 591 if uniq_rules.size == 1
581 592 result[attr] = uniq_rules.first
582 593 else
583 594 result[attr] = 'required'
584 595 end
585 596 end
586 597 end
587 598 @workflow_rule_by_attribute = result if user.nil?
588 599 result
589 600 end
590 601 private :workflow_rule_by_attribute
591 602
592 603 def done_ratio
593 604 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
594 605 status.default_done_ratio
595 606 else
596 607 read_attribute(:done_ratio)
597 608 end
598 609 end
599 610
600 611 def self.use_status_for_done_ratio?
601 612 Setting.issue_done_ratio == 'issue_status'
602 613 end
603 614
604 615 def self.use_field_for_done_ratio?
605 616 Setting.issue_done_ratio == 'issue_field'
606 617 end
607 618
608 619 def validate_issue
609 620 if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
610 621 errors.add :due_date, :greater_than_start_date
611 622 end
612 623
613 624 if start_date && start_date_changed? && soonest_start && start_date < soonest_start
614 625 errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
615 626 end
616 627
617 628 if fixed_version
618 629 if !assignable_versions.include?(fixed_version)
619 630 errors.add :fixed_version_id, :inclusion
620 631 elsif reopening? && fixed_version.closed?
621 632 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
622 633 end
623 634 end
624 635
625 636 # Checks that the issue can not be added/moved to a disabled tracker
626 637 if project && (tracker_id_changed? || project_id_changed?)
627 638 unless project.trackers.include?(tracker)
628 639 errors.add :tracker_id, :inclusion
629 640 end
630 641 end
631 642
632 643 # Checks parent issue assignment
633 644 if @invalid_parent_issue_id.present?
634 645 errors.add :parent_issue_id, :invalid
635 646 elsif @parent_issue
636 647 if !valid_parent_project?(@parent_issue)
637 648 errors.add :parent_issue_id, :invalid
638 649 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
639 650 errors.add :parent_issue_id, :invalid
640 651 elsif !new_record?
641 652 # moving an existing issue
642 653 if move_possible?(@parent_issue)
643 654 # move accepted
644 655 else
645 656 errors.add :parent_issue_id, :invalid
646 657 end
647 658 end
648 659 end
649 660 end
650 661
651 662 # Validates the issue against additional workflow requirements
652 663 def validate_required_fields
653 664 user = new_record? ? author : current_journal.try(:user)
654 665
655 666 required_attribute_names(user).each do |attribute|
656 667 if attribute =~ /^\d+$/
657 668 attribute = attribute.to_i
658 669 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
659 670 if v && Array(v.value).detect(&:present?).nil?
660 671 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
661 672 end
662 673 else
663 674 if respond_to?(attribute) && send(attribute).blank? && !disabled_core_fields.include?(attribute)
664 675 errors.add attribute, :blank
665 676 end
666 677 end
667 678 end
668 679 end
669 680
670 681 # Overrides Redmine::Acts::Customizable::InstanceMethods#validate_custom_field_values
671 682 # so that custom values that are not editable are not validated (eg. a custom field that
672 683 # is marked as required should not trigger a validation error if the user is not allowed
673 684 # to edit this field).
674 685 def validate_custom_field_values
675 686 user = new_record? ? author : current_journal.try(:user)
676 687 if new_record? || custom_field_values_changed?
677 688 editable_custom_field_values(user).each(&:validate_value)
678 689 end
679 690 end
680 691
681 692 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
682 693 # even if the user turns off the setting later
683 694 def update_done_ratio_from_issue_status
684 695 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
685 696 self.done_ratio = status.default_done_ratio
686 697 end
687 698 end
688 699
689 700 def init_journal(user, notes = "")
690 701 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
691 702 end
692 703
693 704 # Returns the current journal or nil if it's not initialized
694 705 def current_journal
695 706 @current_journal
696 707 end
697 708
698 709 # Returns the names of attributes that are journalized when updating the issue
699 710 def journalized_attribute_names
700 711 names = Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)
701 712 if tracker
702 713 names -= tracker.disabled_core_fields
703 714 end
704 715 names
705 716 end
706 717
707 718 # Returns the id of the last journal or nil
708 719 def last_journal_id
709 720 if new_record?
710 721 nil
711 722 else
712 723 journals.maximum(:id)
713 724 end
714 725 end
715 726
716 727 # Returns a scope for journals that have an id greater than journal_id
717 728 def journals_after(journal_id)
718 729 scope = journals.reorder("#{Journal.table_name}.id ASC")
719 730 if journal_id.present?
720 731 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
721 732 end
722 733 scope
723 734 end
724 735
725 736 # Returns the initial status of the issue
726 737 # Returns nil for a new issue
727 738 def status_was
728 739 if status_id_changed?
729 740 if status_id_was.to_i > 0
730 741 @status_was ||= IssueStatus.find_by_id(status_id_was)
731 742 end
732 743 else
733 744 @status_was ||= status
734 745 end
735 746 end
736 747
737 748 # Return true if the issue is closed, otherwise false
738 749 def closed?
739 750 status.present? && status.is_closed?
740 751 end
741 752
742 753 # Returns true if the issue was closed when loaded
743 754 def was_closed?
744 755 status_was.present? && status_was.is_closed?
745 756 end
746 757
747 758 # Return true if the issue is being reopened
748 759 def reopening?
749 760 if new_record?
750 761 false
751 762 else
752 763 status_id_changed? && !closed? && was_closed?
753 764 end
754 765 end
755 766 alias :reopened? :reopening?
756 767
757 768 # Return true if the issue is being closed
758 769 def closing?
759 770 if new_record?
760 771 closed?
761 772 else
762 773 status_id_changed? && closed? && !was_closed?
763 774 end
764 775 end
765 776
766 777 # Returns true if the issue is overdue
767 778 def overdue?
768 779 due_date.present? && (due_date < Date.today) && !closed?
769 780 end
770 781
771 782 # Is the amount of work done less than it should for the due date
772 783 def behind_schedule?
773 784 return false if start_date.nil? || due_date.nil?
774 785 done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
775 786 return done_date <= Date.today
776 787 end
777 788
778 789 # Does this issue have children?
779 790 def children?
780 791 !leaf?
781 792 end
782 793
783 794 # Users the issue can be assigned to
784 795 def assignable_users
785 796 users = project.assignable_users.to_a
786 797 users << author if author && author.active?
787 798 users << assigned_to if assigned_to
788 799 users.uniq.sort
789 800 end
790 801
791 802 # Versions that the issue can be assigned to
792 803 def assignable_versions
793 804 return @assignable_versions if @assignable_versions
794 805
795 806 versions = project.shared_versions.open.to_a
796 807 if fixed_version
797 808 if fixed_version_id_changed?
798 809 # nothing to do
799 810 elsif project_id_changed?
800 811 if project.shared_versions.include?(fixed_version)
801 812 versions << fixed_version
802 813 end
803 814 else
804 815 versions << fixed_version
805 816 end
806 817 end
807 818 @assignable_versions = versions.uniq.sort
808 819 end
809 820
810 821 # Returns true if this issue is blocked by another issue that is still open
811 822 def blocked?
812 823 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
813 824 end
814 825
815 826 # Returns the default status of the issue based on its tracker
816 827 # Returns nil if tracker is nil
817 828 def default_status
818 829 tracker.try(:default_status)
819 830 end
820 831
821 832 # Returns an array of statuses that user is able to apply
822 833 def new_statuses_allowed_to(user=User.current, include_default=false)
823 834 if new_record? && @copied_from
824 835 [default_status, @copied_from.status].compact.uniq.sort
825 836 else
826 837 initial_status = nil
827 838 if new_record?
828 839 initial_status = default_status
829 840 elsif tracker_id_changed?
830 841 if Tracker.where(:id => tracker_id_was, :default_status_id => status_id_was).any?
831 842 initial_status = default_status
832 843 elsif tracker.issue_status_ids.include?(status_id_was)
833 844 initial_status = IssueStatus.find_by_id(status_id_was)
834 845 else
835 846 initial_status = default_status
836 847 end
837 848 else
838 849 initial_status = status_was
839 850 end
840 851
841 852 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
842 853 assignee_transitions_allowed = initial_assigned_to_id.present? &&
843 854 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
844 855
845 856 statuses = []
846 857 if initial_status
847 858 statuses += initial_status.find_new_statuses_allowed_to(
848 859 user.admin ? Role.all.to_a : user.roles_for_project(project),
849 860 tracker,
850 861 author == user,
851 862 assignee_transitions_allowed
852 863 )
853 864 end
854 865 statuses << initial_status unless statuses.empty?
855 866 statuses << default_status if include_default
856 867 statuses = statuses.compact.uniq.sort
857 868 if blocked?
858 869 statuses.reject!(&:is_closed?)
859 870 end
860 871 statuses
861 872 end
862 873 end
863 874
864 875 # Returns the previous assignee (user or group) if changed
865 876 def assigned_to_was
866 877 # assigned_to_id_was is reset before after_save callbacks
867 878 user_id = @previous_assigned_to_id || assigned_to_id_was
868 879 if user_id && user_id != assigned_to_id
869 880 @assigned_to_was ||= Principal.find_by_id(user_id)
870 881 end
871 882 end
872 883
873 884 # Returns the users that should be notified
874 885 def notified_users
875 886 notified = []
876 887 # Author and assignee are always notified unless they have been
877 888 # locked or don't want to be notified
878 889 notified << author if author
879 890 if assigned_to
880 891 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
881 892 end
882 893 if assigned_to_was
883 894 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
884 895 end
885 896 notified = notified.select {|u| u.active? && u.notify_about?(self)}
886 897
887 898 notified += project.notified_users
888 899 notified.uniq!
889 900 # Remove users that can not view the issue
890 901 notified.reject! {|user| !visible?(user)}
891 902 notified
892 903 end
893 904
894 905 # Returns the email addresses that should be notified
895 906 def recipients
896 907 notified_users.collect(&:mail)
897 908 end
898 909
899 910 def each_notification(users, &block)
900 911 if users.any?
901 912 if custom_field_values.detect {|value| !value.custom_field.visible?}
902 913 users_by_custom_field_visibility = users.group_by do |user|
903 914 visible_custom_field_values(user).map(&:custom_field_id).sort
904 915 end
905 916 users_by_custom_field_visibility.values.each do |users|
906 917 yield(users)
907 918 end
908 919 else
909 920 yield(users)
910 921 end
911 922 end
912 923 end
913 924
914 925 # Returns the number of hours spent on this issue
915 926 def spent_hours
916 927 @spent_hours ||= time_entries.sum(:hours) || 0
917 928 end
918 929
919 930 # Returns the total number of hours spent on this issue and its descendants
920 931 def total_spent_hours
921 932 @total_spent_hours ||= if leaf?
922 933 spent_hours
923 934 else
924 935 self_and_descendants.joins(:time_entries).sum("#{TimeEntry.table_name}.hours").to_f || 0.0
925 936 end
926 937 end
927 938
928 939 def total_estimated_hours
929 940 if leaf?
930 941 estimated_hours
931 942 else
932 943 @total_estimated_hours ||= self_and_descendants.sum(:estimated_hours)
933 944 end
934 945 end
935 946
936 947 def relations
937 948 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
938 949 end
939 950
940 951 # Preloads relations for a collection of issues
941 952 def self.load_relations(issues)
942 953 if issues.any?
943 954 relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
944 955 issues.each do |issue|
945 956 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
946 957 end
947 958 end
948 959 end
949 960
950 961 # Preloads visible spent time for a collection of issues
951 962 def self.load_visible_spent_hours(issues, user=User.current)
952 963 if issues.any?
953 964 hours_by_issue_id = TimeEntry.visible(user).where(:issue_id => issues.map(&:id)).group(:issue_id).sum(:hours)
954 965 issues.each do |issue|
955 966 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
956 967 end
957 968 end
958 969 end
959 970
960 971 # Preloads visible total spent time for a collection of issues
961 972 def self.load_visible_total_spent_hours(issues, user=User.current)
962 973 if issues.any?
963 974 hours_by_issue_id = TimeEntry.visible(user).joins(:issue).
964 975 joins("JOIN #{Issue.table_name} parent ON parent.root_id = #{Issue.table_name}.root_id" +
965 976 " AND parent.lft <= #{Issue.table_name}.lft AND parent.rgt >= #{Issue.table_name}.rgt").
966 977 where("parent.id IN (?)", issues.map(&:id)).group("parent.id").sum(:hours)
967 978 issues.each do |issue|
968 979 issue.instance_variable_set "@total_spent_hours", (hours_by_issue_id[issue.id] || 0)
969 980 end
970 981 end
971 982 end
972 983
973 984 # Preloads visible relations for a collection of issues
974 985 def self.load_visible_relations(issues, user=User.current)
975 986 if issues.any?
976 987 issue_ids = issues.map(&:id)
977 988 # Relations with issue_from in given issues and visible issue_to
978 989 relations_from = IssueRelation.joins(:issue_to => :project).
979 990 where(visible_condition(user)).where(:issue_from_id => issue_ids).to_a
980 991 # Relations with issue_to in given issues and visible issue_from
981 992 relations_to = IssueRelation.joins(:issue_from => :project).
982 993 where(visible_condition(user)).
983 994 where(:issue_to_id => issue_ids).to_a
984 995 issues.each do |issue|
985 996 relations =
986 997 relations_from.select {|relation| relation.issue_from_id == issue.id} +
987 998 relations_to.select {|relation| relation.issue_to_id == issue.id}
988 999
989 1000 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
990 1001 end
991 1002 end
992 1003 end
993 1004
994 1005 # Finds an issue relation given its id.
995 1006 def find_relation(relation_id)
996 1007 IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
997 1008 end
998 1009
999 1010 # Returns all the other issues that depend on the issue
1000 1011 # The algorithm is a modified breadth first search (bfs)
1001 1012 def all_dependent_issues(except=[])
1002 1013 # The found dependencies
1003 1014 dependencies = []
1004 1015
1005 1016 # The visited flag for every node (issue) used by the breadth first search
1006 1017 eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
1007 1018
1008 1019 ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
1009 1020 # the issue when it is processed.
1010 1021
1011 1022 ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
1012 1023 # but its children will not be added to the queue when it is processed.
1013 1024
1014 1025 eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
1015 1026 # the queue, but its children have not been added.
1016 1027
1017 1028 ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
1018 1029 # the children still need to be processed.
1019 1030
1020 1031 eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
1021 1032 # added as dependent issues. It needs no further processing.
1022 1033
1023 1034 issue_status = Hash.new(eNOT_DISCOVERED)
1024 1035
1025 1036 # The queue
1026 1037 queue = []
1027 1038
1028 1039 # Initialize the bfs, add start node (self) to the queue
1029 1040 queue << self
1030 1041 issue_status[self] = ePROCESS_ALL
1031 1042
1032 1043 while (!queue.empty?) do
1033 1044 current_issue = queue.shift
1034 1045 current_issue_status = issue_status[current_issue]
1035 1046 dependencies << current_issue
1036 1047
1037 1048 # Add parent to queue, if not already in it.
1038 1049 parent = current_issue.parent
1039 1050 parent_status = issue_status[parent]
1040 1051
1041 1052 if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
1042 1053 queue << parent
1043 1054 issue_status[parent] = ePROCESS_RELATIONS_ONLY
1044 1055 end
1045 1056
1046 1057 # Add children to queue, but only if they are not already in it and
1047 1058 # the children of the current node need to be processed.
1048 1059 if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
1049 1060 current_issue.children.each do |child|
1050 1061 next if except.include?(child)
1051 1062
1052 1063 if (issue_status[child] == eNOT_DISCOVERED)
1053 1064 queue << child
1054 1065 issue_status[child] = ePROCESS_ALL
1055 1066 elsif (issue_status[child] == eRELATIONS_PROCESSED)
1056 1067 queue << child
1057 1068 issue_status[child] = ePROCESS_CHILDREN_ONLY
1058 1069 elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
1059 1070 queue << child
1060 1071 issue_status[child] = ePROCESS_ALL
1061 1072 end
1062 1073 end
1063 1074 end
1064 1075
1065 1076 # Add related issues to the queue, if they are not already in it.
1066 1077 current_issue.relations_from.map(&:issue_to).each do |related_issue|
1067 1078 next if except.include?(related_issue)
1068 1079
1069 1080 if (issue_status[related_issue] == eNOT_DISCOVERED)
1070 1081 queue << related_issue
1071 1082 issue_status[related_issue] = ePROCESS_ALL
1072 1083 elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
1073 1084 queue << related_issue
1074 1085 issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
1075 1086 elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
1076 1087 queue << related_issue
1077 1088 issue_status[related_issue] = ePROCESS_ALL
1078 1089 end
1079 1090 end
1080 1091
1081 1092 # Set new status for current issue
1082 1093 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
1083 1094 issue_status[current_issue] = eALL_PROCESSED
1084 1095 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
1085 1096 issue_status[current_issue] = eRELATIONS_PROCESSED
1086 1097 end
1087 1098 end # while
1088 1099
1089 1100 # Remove the issues from the "except" parameter from the result array
1090 1101 dependencies -= except
1091 1102 dependencies.delete(self)
1092 1103
1093 1104 dependencies
1094 1105 end
1095 1106
1096 1107 # Returns an array of issues that duplicate this one
1097 1108 def duplicates
1098 1109 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
1099 1110 end
1100 1111
1101 1112 # Returns the due date or the target due date if any
1102 1113 # Used on gantt chart
1103 1114 def due_before
1104 1115 due_date || (fixed_version ? fixed_version.effective_date : nil)
1105 1116 end
1106 1117
1107 1118 # Returns the time scheduled for this issue.
1108 1119 #
1109 1120 # Example:
1110 1121 # Start Date: 2/26/09, End Date: 3/04/09
1111 1122 # duration => 6
1112 1123 def duration
1113 1124 (start_date && due_date) ? due_date - start_date : 0
1114 1125 end
1115 1126
1116 1127 # Returns the duration in working days
1117 1128 def working_duration
1118 1129 (start_date && due_date) ? working_days(start_date, due_date) : 0
1119 1130 end
1120 1131
1121 1132 def soonest_start(reload=false)
1122 1133 if @soonest_start.nil? || reload
1123 1134 dates = relations_to(reload).collect{|relation| relation.successor_soonest_start}
1124 1135 p = @parent_issue || parent
1125 1136 if p && Setting.parent_issue_dates == 'derived'
1126 1137 dates << p.soonest_start
1127 1138 end
1128 1139 @soonest_start = dates.compact.max
1129 1140 end
1130 1141 @soonest_start
1131 1142 end
1132 1143
1133 1144 # Sets start_date on the given date or the next working day
1134 1145 # and changes due_date to keep the same working duration.
1135 1146 def reschedule_on(date)
1136 1147 wd = working_duration
1137 1148 date = next_working_date(date)
1138 1149 self.start_date = date
1139 1150 self.due_date = add_working_days(date, wd)
1140 1151 end
1141 1152
1142 1153 # Reschedules the issue on the given date or the next working day and saves the record.
1143 1154 # If the issue is a parent task, this is done by rescheduling its subtasks.
1144 1155 def reschedule_on!(date)
1145 1156 return if date.nil?
1146 1157 if leaf? || !dates_derived?
1147 1158 if start_date.nil? || start_date != date
1148 1159 if start_date && start_date > date
1149 1160 # Issue can not be moved earlier than its soonest start date
1150 1161 date = [soonest_start(true), date].compact.max
1151 1162 end
1152 1163 reschedule_on(date)
1153 1164 begin
1154 1165 save
1155 1166 rescue ActiveRecord::StaleObjectError
1156 1167 reload
1157 1168 reschedule_on(date)
1158 1169 save
1159 1170 end
1160 1171 end
1161 1172 else
1162 1173 leaves.each do |leaf|
1163 1174 if leaf.start_date
1164 1175 # Only move subtask if it starts at the same date as the parent
1165 1176 # or if it starts before the given date
1166 1177 if start_date == leaf.start_date || date > leaf.start_date
1167 1178 leaf.reschedule_on!(date)
1168 1179 end
1169 1180 else
1170 1181 leaf.reschedule_on!(date)
1171 1182 end
1172 1183 end
1173 1184 end
1174 1185 end
1175 1186
1176 1187 def dates_derived?
1177 1188 !leaf? && Setting.parent_issue_dates == 'derived'
1178 1189 end
1179 1190
1180 1191 def priority_derived?
1181 1192 !leaf? && Setting.parent_issue_priority == 'derived'
1182 1193 end
1183 1194
1184 1195 def done_ratio_derived?
1185 1196 !leaf? && Setting.parent_issue_done_ratio == 'derived'
1186 1197 end
1187 1198
1188 1199 def <=>(issue)
1189 1200 if issue.nil?
1190 1201 -1
1191 1202 elsif root_id != issue.root_id
1192 1203 (root_id || 0) <=> (issue.root_id || 0)
1193 1204 else
1194 1205 (lft || 0) <=> (issue.lft || 0)
1195 1206 end
1196 1207 end
1197 1208
1198 1209 def to_s
1199 1210 "#{tracker} ##{id}: #{subject}"
1200 1211 end
1201 1212
1202 1213 # Returns a string of css classes that apply to the issue
1203 1214 def css_classes(user=User.current)
1204 1215 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
1205 1216 s << ' closed' if closed?
1206 1217 s << ' overdue' if overdue?
1207 1218 s << ' child' if child?
1208 1219 s << ' parent' unless leaf?
1209 1220 s << ' private' if is_private?
1210 1221 if user.logged?
1211 1222 s << ' created-by-me' if author_id == user.id
1212 1223 s << ' assigned-to-me' if assigned_to_id == user.id
1213 1224 s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
1214 1225 end
1215 1226 s
1216 1227 end
1217 1228
1218 1229 # Unassigns issues from +version+ if it's no longer shared with issue's project
1219 1230 def self.update_versions_from_sharing_change(version)
1220 1231 # Update issues assigned to the version
1221 1232 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1222 1233 end
1223 1234
1224 1235 # Unassigns issues from versions that are no longer shared
1225 1236 # after +project+ was moved
1226 1237 def self.update_versions_from_hierarchy_change(project)
1227 1238 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1228 1239 # Update issues of the moved projects and issues assigned to a version of a moved project
1229 1240 Issue.update_versions(
1230 1241 ["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)",
1231 1242 moved_project_ids, moved_project_ids]
1232 1243 )
1233 1244 end
1234 1245
1235 1246 def parent_issue_id=(arg)
1236 1247 s = arg.to_s.strip.presence
1237 1248 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1238 1249 @invalid_parent_issue_id = nil
1239 1250 elsif s.blank?
1240 1251 @parent_issue = nil
1241 1252 @invalid_parent_issue_id = nil
1242 1253 else
1243 1254 @parent_issue = nil
1244 1255 @invalid_parent_issue_id = arg
1245 1256 end
1246 1257 end
1247 1258
1248 1259 def parent_issue_id
1249 1260 if @invalid_parent_issue_id
1250 1261 @invalid_parent_issue_id
1251 1262 elsif instance_variable_defined? :@parent_issue
1252 1263 @parent_issue.nil? ? nil : @parent_issue.id
1253 1264 else
1254 1265 parent_id
1255 1266 end
1256 1267 end
1257 1268
1258 1269 def set_parent_id
1259 1270 self.parent_id = parent_issue_id
1260 1271 end
1261 1272
1262 1273 # Returns true if issue's project is a valid
1263 1274 # parent issue project
1264 1275 def valid_parent_project?(issue=parent)
1265 1276 return true if issue.nil? || issue.project_id == project_id
1266 1277
1267 1278 case Setting.cross_project_subtasks
1268 1279 when 'system'
1269 1280 true
1270 1281 when 'tree'
1271 1282 issue.project.root == project.root
1272 1283 when 'hierarchy'
1273 1284 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1274 1285 when 'descendants'
1275 1286 issue.project.is_or_is_ancestor_of?(project)
1276 1287 else
1277 1288 false
1278 1289 end
1279 1290 end
1280 1291
1281 1292 # Returns an issue scope based on project and scope
1282 1293 def self.cross_project_scope(project, scope=nil)
1283 1294 if project.nil?
1284 1295 return Issue
1285 1296 end
1286 1297 case scope
1287 1298 when 'all', 'system'
1288 1299 Issue
1289 1300 when 'tree'
1290 1301 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1291 1302 :lft => project.root.lft, :rgt => project.root.rgt)
1292 1303 when 'hierarchy'
1293 1304 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt) OR (#{Project.table_name}.lft < :lft AND #{Project.table_name}.rgt > :rgt)",
1294 1305 :lft => project.lft, :rgt => project.rgt)
1295 1306 when 'descendants'
1296 1307 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1297 1308 :lft => project.lft, :rgt => project.rgt)
1298 1309 else
1299 1310 Issue.where(:project_id => project.id)
1300 1311 end
1301 1312 end
1302 1313
1303 1314 def self.by_tracker(project)
1304 1315 count_and_group_by(:project => project, :association => :tracker)
1305 1316 end
1306 1317
1307 1318 def self.by_version(project)
1308 1319 count_and_group_by(:project => project, :association => :fixed_version)
1309 1320 end
1310 1321
1311 1322 def self.by_priority(project)
1312 1323 count_and_group_by(:project => project, :association => :priority)
1313 1324 end
1314 1325
1315 1326 def self.by_category(project)
1316 1327 count_and_group_by(:project => project, :association => :category)
1317 1328 end
1318 1329
1319 1330 def self.by_assigned_to(project)
1320 1331 count_and_group_by(:project => project, :association => :assigned_to)
1321 1332 end
1322 1333
1323 1334 def self.by_author(project)
1324 1335 count_and_group_by(:project => project, :association => :author)
1325 1336 end
1326 1337
1327 1338 def self.by_subproject(project)
1328 1339 r = count_and_group_by(:project => project, :with_subprojects => true, :association => :project)
1329 1340 r.reject {|r| r["project_id"] == project.id.to_s}
1330 1341 end
1331 1342
1332 1343 # Query generator for selecting groups of issue counts for a project
1333 1344 # based on specific criteria
1334 1345 #
1335 1346 # Options
1336 1347 # * project - Project to search in.
1337 1348 # * with_subprojects - Includes subprojects issues if set to true.
1338 1349 # * association - Symbol. Association for grouping.
1339 1350 def self.count_and_group_by(options)
1340 1351 assoc = reflect_on_association(options[:association])
1341 1352 select_field = assoc.foreign_key
1342 1353
1343 1354 Issue.
1344 1355 visible(User.current, :project => options[:project], :with_subprojects => options[:with_subprojects]).
1345 1356 joins(:status, assoc.name).
1346 1357 group(:status_id, :is_closed, select_field).
1347 1358 count.
1348 1359 map do |columns, total|
1349 1360 status_id, is_closed, field_value = columns
1350 1361 is_closed = ['t', 'true', '1'].include?(is_closed.to_s)
1351 1362 {
1352 1363 "status_id" => status_id.to_s,
1353 1364 "closed" => is_closed,
1354 1365 select_field => field_value.to_s,
1355 1366 "total" => total.to_s
1356 1367 }
1357 1368 end
1358 1369 end
1359 1370
1360 1371 # Returns a scope of projects that user can assign the issue to
1361 1372 def allowed_target_projects(user=User.current)
1362 1373 current_project = new_record? ? nil : project
1363 1374 self.class.allowed_target_projects(user, current_project)
1364 1375 end
1365 1376
1366 1377 # Returns a scope of projects that user can assign issues to
1367 1378 # If current_project is given, it will be included in the scope
1368 1379 def self.allowed_target_projects(user=User.current, current_project=nil)
1369 1380 condition = Project.allowed_to_condition(user, :add_issues)
1370 1381 if current_project
1371 1382 condition = ["(#{condition}) OR #{Project.table_name}.id = ?", current_project.id]
1372 1383 end
1373 1384 Project.where(condition)
1374 1385 end
1375 1386
1376 1387 private
1377 1388
1378 1389 def after_project_change
1379 1390 # Update project_id on related time entries
1380 1391 TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
1381 1392
1382 1393 # Delete issue relations
1383 1394 unless Setting.cross_project_issue_relations?
1384 1395 relations_from.clear
1385 1396 relations_to.clear
1386 1397 end
1387 1398
1388 1399 # Move subtasks that were in the same project
1389 1400 children.each do |child|
1390 1401 next unless child.project_id == project_id_was
1391 1402 # Change project and keep project
1392 1403 child.send :project=, project, true
1393 1404 unless child.save
1394 1405 raise ActiveRecord::Rollback
1395 1406 end
1396 1407 end
1397 1408 end
1398 1409
1399 1410 # Callback for after the creation of an issue by copy
1400 1411 # * adds a "copied to" relation with the copied issue
1401 1412 # * copies subtasks from the copied issue
1402 1413 def after_create_from_copy
1403 1414 return unless copy? && !@after_create_from_copy_handled
1404 1415
1405 1416 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1406 1417 if @current_journal
1407 1418 @copied_from.init_journal(@current_journal.user)
1408 1419 end
1409 1420 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1410 1421 unless relation.save
1411 1422 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1412 1423 end
1413 1424 end
1414 1425
1415 1426 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1416 1427 copy_options = (@copy_options || {}).merge(:subtasks => false)
1417 1428 copied_issue_ids = {@copied_from.id => self.id}
1418 1429 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1419 1430 # Do not copy self when copying an issue as a descendant of the copied issue
1420 1431 next if child == self
1421 1432 # Do not copy subtasks of issues that were not copied
1422 1433 next unless copied_issue_ids[child.parent_id]
1423 1434 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1424 1435 unless child.visible?
1425 1436 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1426 1437 next
1427 1438 end
1428 1439 copy = Issue.new.copy_from(child, copy_options)
1429 1440 if @current_journal
1430 1441 copy.init_journal(@current_journal.user)
1431 1442 end
1432 1443 copy.author = author
1433 1444 copy.project = project
1434 1445 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1435 1446 unless copy.save
1436 1447 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1437 1448 next
1438 1449 end
1439 1450 copied_issue_ids[child.id] = copy.id
1440 1451 end
1441 1452 end
1442 1453 @after_create_from_copy_handled = true
1443 1454 end
1444 1455
1445 1456 def update_nested_set_attributes
1446 1457 if parent_id_changed?
1447 1458 update_nested_set_attributes_on_parent_change
1448 1459 end
1449 1460 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1450 1461 end
1451 1462
1452 1463 # Updates the nested set for when an existing issue is moved
1453 1464 def update_nested_set_attributes_on_parent_change
1454 1465 former_parent_id = parent_id_was
1455 1466 # delete invalid relations of all descendants
1456 1467 self_and_descendants.each do |issue|
1457 1468 issue.relations.each do |relation|
1458 1469 relation.destroy unless relation.valid?
1459 1470 end
1460 1471 end
1461 1472 # update former parent
1462 1473 recalculate_attributes_for(former_parent_id) if former_parent_id
1463 1474 end
1464 1475
1465 1476 def update_parent_attributes
1466 1477 if parent_id
1467 1478 recalculate_attributes_for(parent_id)
1468 1479 association(:parent).reset
1469 1480 end
1470 1481 end
1471 1482
1472 1483 def recalculate_attributes_for(issue_id)
1473 1484 if issue_id && p = Issue.find_by_id(issue_id)
1474 1485 if p.priority_derived?
1475 1486 # priority = highest priority of children
1476 1487 if priority_position = p.children.joins(:priority).maximum("#{IssuePriority.table_name}.position")
1477 1488 p.priority = IssuePriority.find_by_position(priority_position)
1478 1489 end
1479 1490 end
1480 1491
1481 1492 if p.dates_derived?
1482 1493 # start/due dates = lowest/highest dates of children
1483 1494 p.start_date = p.children.minimum(:start_date)
1484 1495 p.due_date = p.children.maximum(:due_date)
1485 1496 if p.start_date && p.due_date && p.due_date < p.start_date
1486 1497 p.start_date, p.due_date = p.due_date, p.start_date
1487 1498 end
1488 1499 end
1489 1500
1490 1501 if p.done_ratio_derived?
1491 1502 # done ratio = weighted average ratio of leaves
1492 1503 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1493 1504 leaves_count = p.leaves.count
1494 1505 if leaves_count > 0
1495 1506 average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
1496 1507 if average == 0
1497 1508 average = 1
1498 1509 end
1499 1510 done = p.leaves.joins(:status).
1500 1511 sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
1501 1512 "* (CASE WHEN is_closed = #{self.class.connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
1502 1513 progress = done / (average * leaves_count)
1503 1514 p.done_ratio = progress.round
1504 1515 end
1505 1516 end
1506 1517 end
1507 1518
1508 1519 # ancestors will be recursively updated
1509 1520 p.save(:validate => false)
1510 1521 end
1511 1522 end
1512 1523
1513 1524 # Update issues so their versions are not pointing to a
1514 1525 # fixed_version that is not shared with the issue's project
1515 1526 def self.update_versions(conditions=nil)
1516 1527 # Only need to update issues with a fixed_version from
1517 1528 # a different project and that is not systemwide shared
1518 1529 Issue.joins(:project, :fixed_version).
1519 1530 where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1520 1531 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1521 1532 " AND #{Version.table_name}.sharing <> 'system'").
1522 1533 where(conditions).each do |issue|
1523 1534 next if issue.project.nil? || issue.fixed_version.nil?
1524 1535 unless issue.project.shared_versions.include?(issue.fixed_version)
1525 1536 issue.init_journal(User.current)
1526 1537 issue.fixed_version = nil
1527 1538 issue.save
1528 1539 end
1529 1540 end
1530 1541 end
1531 1542
1532 1543 # Callback on file attachment
1533 1544 def attachment_added(attachment)
1534 1545 if current_journal && !attachment.new_record?
1535 1546 current_journal.journalize_attachment(attachment, :added)
1536 1547 end
1537 1548 end
1538 1549
1539 1550 # Callback on attachment deletion
1540 1551 def attachment_removed(attachment)
1541 1552 if current_journal && !attachment.new_record?
1542 1553 current_journal.journalize_attachment(attachment, :removed)
1543 1554 current_journal.save
1544 1555 end
1545 1556 end
1546 1557
1547 1558 # Called after a relation is added
1548 1559 def relation_added(relation)
1549 1560 if current_journal
1550 1561 current_journal.journalize_relation(relation, :added)
1551 1562 current_journal.save
1552 1563 end
1553 1564 end
1554 1565
1555 1566 # Called after a relation is removed
1556 1567 def relation_removed(relation)
1557 1568 if current_journal
1558 1569 current_journal.journalize_relation(relation, :removed)
1559 1570 current_journal.save
1560 1571 end
1561 1572 end
1562 1573
1563 1574 # Default assignment based on category
1564 1575 def default_assign
1565 1576 if assigned_to.nil? && category && category.assigned_to
1566 1577 self.assigned_to = category.assigned_to
1567 1578 end
1568 1579 end
1569 1580
1570 1581 # Updates start/due dates of following issues
1571 1582 def reschedule_following_issues
1572 1583 if start_date_changed? || due_date_changed?
1573 1584 relations_from.each do |relation|
1574 1585 relation.set_issue_to_dates
1575 1586 end
1576 1587 end
1577 1588 end
1578 1589
1579 1590 # Closes duplicates if the issue is being closed
1580 1591 def close_duplicates
1581 1592 if closing?
1582 1593 duplicates.each do |duplicate|
1583 1594 # Reload is needed in case the duplicate was updated by a previous duplicate
1584 1595 duplicate.reload
1585 1596 # Don't re-close it if it's already closed
1586 1597 next if duplicate.closed?
1587 1598 # Same user and notes
1588 1599 if @current_journal
1589 1600 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1590 1601 duplicate.private_notes = @current_journal.private_notes
1591 1602 end
1592 1603 duplicate.update_attribute :status, self.status
1593 1604 end
1594 1605 end
1595 1606 end
1596 1607
1597 1608 # Make sure updated_on is updated when adding a note and set updated_on now
1598 1609 # so we can set closed_on with the same value on closing
1599 1610 def force_updated_on_change
1600 1611 if @current_journal || changed?
1601 1612 self.updated_on = current_time_from_proper_timezone
1602 1613 if new_record?
1603 1614 self.created_on = updated_on
1604 1615 end
1605 1616 end
1606 1617 end
1607 1618
1608 1619 # Callback for setting closed_on when the issue is closed.
1609 1620 # The closed_on attribute stores the time of the last closing
1610 1621 # and is preserved when the issue is reopened.
1611 1622 def update_closed_on
1612 1623 if closing?
1613 1624 self.closed_on = updated_on
1614 1625 end
1615 1626 end
1616 1627
1617 1628 # Saves the changes in a Journal
1618 1629 # Called after_save
1619 1630 def create_journal
1620 1631 if current_journal
1621 1632 current_journal.save
1622 1633 end
1623 1634 end
1624 1635
1625 1636 def send_notification
1626 1637 if Setting.notified_events.include?('issue_added')
1627 1638 Mailer.deliver_issue_add(self)
1628 1639 end
1629 1640 end
1630 1641
1631 1642 # Stores the previous assignee so we can still have access
1632 1643 # to it during after_save callbacks (assigned_to_id_was is reset)
1633 1644 def set_assigned_to_was
1634 1645 @previous_assigned_to_id = assigned_to_id_was
1635 1646 end
1636 1647
1637 1648 # Clears the previous assignee at the end of after_save callbacks
1638 1649 def clear_assigned_to_was
1639 1650 @assigned_to_was = nil
1640 1651 @previous_assigned_to_id = nil
1641 1652 end
1642 1653
1643 1654 def clear_disabled_fields
1644 1655 if tracker
1645 1656 tracker.disabled_core_fields.each do |attribute|
1646 1657 send "#{attribute}=", nil
1647 1658 end
1648 1659 self.done_ratio ||= 0
1649 1660 end
1650 1661 end
1651 1662 end
@@ -1,4310 +1,4312
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users, :email_addresses,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :issue_relations,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries,
45 45 :repositories,
46 46 :changesets
47 47
48 48 include Redmine::I18n
49 49
50 50 def setup
51 51 User.current = nil
52 52 end
53 53
54 54 def test_index
55 55 with_settings :default_language => "en" do
56 56 get :index
57 57 assert_response :success
58 58 assert_template 'index'
59 59 assert_not_nil assigns(:issues)
60 60 assert_nil assigns(:project)
61 61
62 62 # links to visible issues
63 63 assert_select 'a[href="/issues/1"]', :text => /Cannot print recipes/
64 64 assert_select 'a[href="/issues/5"]', :text => /Subproject issue/
65 65 # private projects hidden
66 66 assert_select 'a[href="/issues/6"]', 0
67 67 assert_select 'a[href="/issues/4"]', 0
68 68 # project column
69 69 assert_select 'th', :text => /Project/
70 70 end
71 71 end
72 72
73 73 def test_index_should_not_list_issues_when_module_disabled
74 74 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
75 75 get :index
76 76 assert_response :success
77 77 assert_template 'index'
78 78 assert_not_nil assigns(:issues)
79 79 assert_nil assigns(:project)
80 80
81 81 assert_select 'a[href="/issues/1"]', 0
82 82 assert_select 'a[href="/issues/5"]', :text => /Subproject issue/
83 83 end
84 84
85 85 def test_index_should_list_visible_issues_only
86 86 get :index, :per_page => 100
87 87 assert_response :success
88 88 assert_not_nil assigns(:issues)
89 89 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
90 90 end
91 91
92 92 def test_index_with_project
93 93 Setting.display_subprojects_issues = 0
94 94 get :index, :project_id => 1
95 95 assert_response :success
96 96 assert_template 'index'
97 97 assert_not_nil assigns(:issues)
98 98
99 99 assert_select 'a[href="/issues/1"]', :text => /Cannot print recipes/
100 100 assert_select 'a[href="/issues/5"]', 0
101 101 end
102 102
103 103 def test_index_with_project_and_subprojects
104 104 Setting.display_subprojects_issues = 1
105 105 get :index, :project_id => 1
106 106 assert_response :success
107 107 assert_template 'index'
108 108 assert_not_nil assigns(:issues)
109 109
110 110 assert_select 'a[href="/issues/1"]', :text => /Cannot print recipes/
111 111 assert_select 'a[href="/issues/5"]', :text => /Subproject issue/
112 112 assert_select 'a[href="/issues/6"]', 0
113 113 end
114 114
115 115 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
116 116 @request.session[:user_id] = 2
117 117 Setting.display_subprojects_issues = 1
118 118 get :index, :project_id => 1
119 119 assert_response :success
120 120 assert_template 'index'
121 121 assert_not_nil assigns(:issues)
122 122
123 123 assert_select 'a[href="/issues/1"]', :text => /Cannot print recipes/
124 124 assert_select 'a[href="/issues/5"]', :text => /Subproject issue/
125 125 assert_select 'a[href="/issues/6"]', :text => /Issue of a private subproject/
126 126 end
127 127
128 128 def test_index_with_project_and_default_filter
129 129 get :index, :project_id => 1, :set_filter => 1
130 130 assert_response :success
131 131 assert_template 'index'
132 132 assert_not_nil assigns(:issues)
133 133
134 134 query = assigns(:query)
135 135 assert_not_nil query
136 136 # default filter
137 137 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
138 138 end
139 139
140 140 def test_index_with_project_and_filter
141 141 get :index, :project_id => 1, :set_filter => 1,
142 142 :f => ['tracker_id'],
143 143 :op => {'tracker_id' => '='},
144 144 :v => {'tracker_id' => ['1']}
145 145 assert_response :success
146 146 assert_template 'index'
147 147 assert_not_nil assigns(:issues)
148 148
149 149 query = assigns(:query)
150 150 assert_not_nil query
151 151 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
152 152 end
153 153
154 154 def test_index_with_short_filters
155 155 to_test = {
156 156 'status_id' => {
157 157 'o' => { :op => 'o', :values => [''] },
158 158 'c' => { :op => 'c', :values => [''] },
159 159 '7' => { :op => '=', :values => ['7'] },
160 160 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
161 161 '=7' => { :op => '=', :values => ['7'] },
162 162 '!3' => { :op => '!', :values => ['3'] },
163 163 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
164 164 'subject' => {
165 165 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
166 166 'o' => { :op => '=', :values => ['o'] },
167 167 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
168 168 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
169 169 'tracker_id' => {
170 170 '3' => { :op => '=', :values => ['3'] },
171 171 '=3' => { :op => '=', :values => ['3'] }},
172 172 'start_date' => {
173 173 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
175 175 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
176 176 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
177 177 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
178 178 '<t+2' => { :op => '<t+', :values => ['2'] },
179 179 '>t+2' => { :op => '>t+', :values => ['2'] },
180 180 't+2' => { :op => 't+', :values => ['2'] },
181 181 't' => { :op => 't', :values => [''] },
182 182 'w' => { :op => 'w', :values => [''] },
183 183 '>t-2' => { :op => '>t-', :values => ['2'] },
184 184 '<t-2' => { :op => '<t-', :values => ['2'] },
185 185 't-2' => { :op => 't-', :values => ['2'] }},
186 186 'created_on' => {
187 187 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
188 188 '<t-2' => { :op => '<t-', :values => ['2'] },
189 189 '>t-2' => { :op => '>t-', :values => ['2'] },
190 190 't-2' => { :op => 't-', :values => ['2'] }},
191 191 'cf_1' => {
192 192 'c' => { :op => '=', :values => ['c'] },
193 193 '!c' => { :op => '!', :values => ['c'] },
194 194 '!*' => { :op => '!*', :values => [''] },
195 195 '*' => { :op => '*', :values => [''] }},
196 196 'estimated_hours' => {
197 197 '=13.4' => { :op => '=', :values => ['13.4'] },
198 198 '>=45' => { :op => '>=', :values => ['45'] },
199 199 '<=125' => { :op => '<=', :values => ['125'] },
200 200 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
201 201 '!*' => { :op => '!*', :values => [''] },
202 202 '*' => { :op => '*', :values => [''] }}
203 203 }
204 204
205 205 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
206 206
207 207 to_test.each do |field, expression_and_expected|
208 208 expression_and_expected.each do |filter_expression, expected|
209 209
210 210 get :index, :set_filter => 1, field => filter_expression
211 211
212 212 assert_response :success
213 213 assert_template 'index'
214 214 assert_not_nil assigns(:issues)
215 215
216 216 query = assigns(:query)
217 217 assert_not_nil query
218 218 assert query.has_filter?(field)
219 219 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
220 220 end
221 221 end
222 222 end
223 223
224 224 def test_index_with_project_and_empty_filters
225 225 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
226 226 assert_response :success
227 227 assert_template 'index'
228 228 assert_not_nil assigns(:issues)
229 229
230 230 query = assigns(:query)
231 231 assert_not_nil query
232 232 # no filter
233 233 assert_equal({}, query.filters)
234 234 end
235 235
236 236 def test_index_with_project_custom_field_filter
237 237 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
239 239 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
240 240 filter_name = "project.cf_#{field.id}"
241 241 @request.session[:user_id] = 1
242 242
243 243 get :index, :set_filter => 1,
244 244 :f => [filter_name],
245 245 :op => {filter_name => '='},
246 246 :v => {filter_name => ['Foo']}
247 247 assert_response :success
248 248 assert_template 'index'
249 249 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
250 250 end
251 251
252 252 def test_index_with_query
253 253 get :index, :project_id => 1, :query_id => 5
254 254 assert_response :success
255 255 assert_template 'index'
256 256 assert_not_nil assigns(:issues)
257 257 assert_nil assigns(:issue_count_by_group)
258 258 end
259 259
260 260 def test_index_with_query_grouped_by_tracker
261 261 get :index, :project_id => 1, :query_id => 6
262 262 assert_response :success
263 263 assert_template 'index'
264 264 assert_not_nil assigns(:issues)
265 265 assert_not_nil assigns(:issue_count_by_group)
266 266 end
267 267
268 268 def test_index_with_query_grouped_and_sorted_by_category
269 269 get :index, :project_id => 1, :set_filter => 1, :group_by => "category", :sort => "category"
270 270 assert_response :success
271 271 assert_template 'index'
272 272 assert_not_nil assigns(:issues)
273 273 assert_not_nil assigns(:issue_count_by_group)
274 274 end
275 275
276 276 def test_index_with_query_grouped_by_list_custom_field
277 277 get :index, :project_id => 1, :query_id => 9
278 278 assert_response :success
279 279 assert_template 'index'
280 280 assert_not_nil assigns(:issues)
281 281 assert_not_nil assigns(:issue_count_by_group)
282 282 end
283 283
284 284 def test_index_with_query_grouped_by_user_custom_field
285 285 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
286 286 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
287 287 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
288 288 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
289 289 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
290 290
291 291 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
292 292 assert_response :success
293 293
294 294 assert_select 'tr.group', 3
295 295 assert_select 'tr.group' do
296 296 assert_select 'a', :text => 'John Smith'
297 297 assert_select 'span.count', :text => '1'
298 298 end
299 299 assert_select 'tr.group' do
300 300 assert_select 'a', :text => 'Dave Lopper'
301 301 assert_select 'span.count', :text => '2'
302 302 end
303 303 end
304 304
305 305 def test_index_grouped_by_boolean_custom_field_should_distinguish_blank_and_false_values
306 306 cf = IssueCustomField.create!(:name => 'Bool', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'bool')
307 307 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '1')
308 308 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '0')
309 309 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '')
310 310
311 311 with_settings :default_language => 'en' do
312 312 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
313 313 assert_response :success
314 314 end
315 315
316 316 assert_select 'tr.group', 3
317 317 assert_select 'tr.group', :text => /Yes/
318 318 assert_select 'tr.group', :text => /No/
319 319 assert_select 'tr.group', :text => /blank/
320 320 end
321 321
322 322 def test_index_grouped_by_boolean_custom_field_with_false_group_in_first_position_should_show_the_group
323 323 cf = IssueCustomField.create!(:name => 'Bool', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'bool', :is_filter => true)
324 324 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '0')
325 325 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '0')
326 326
327 327 with_settings :default_language => 'en' do
328 328 get :index, :project_id => 1, :set_filter => 1, "cf_#{cf.id}" => "*", :group_by => "cf_#{cf.id}"
329 329 assert_response :success
330 330 assert_equal [1, 2], assigns(:issues).map(&:id).sort
331 331 end
332 332
333 333 assert_select 'tr.group', 1
334 334 assert_select 'tr.group', :text => /No/
335 335 end
336 336
337 337 def test_index_with_query_grouped_by_tracker_in_normal_order
338 338 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
339 339
340 340 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
341 341 assert_response :success
342 342
343 343 trackers = assigns(:issues).map(&:tracker).uniq
344 344 assert_equal [1, 2, 3], trackers.map(&:id)
345 345 end
346 346
347 347 def test_index_with_query_grouped_by_tracker_in_reverse_order
348 348 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
349 349
350 350 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
351 351 assert_response :success
352 352
353 353 trackers = assigns(:issues).map(&:tracker).uniq
354 354 assert_equal [3, 2, 1], trackers.map(&:id)
355 355 end
356 356
357 357 def test_index_with_query_id_and_project_id_should_set_session_query
358 358 get :index, :project_id => 1, :query_id => 4
359 359 assert_response :success
360 360 assert_kind_of Hash, session[:query]
361 361 assert_equal 4, session[:query][:id]
362 362 assert_equal 1, session[:query][:project_id]
363 363 end
364 364
365 365 def test_index_with_invalid_query_id_should_respond_404
366 366 get :index, :project_id => 1, :query_id => 999
367 367 assert_response 404
368 368 end
369 369
370 370 def test_index_with_cross_project_query_in_session_should_show_project_issues
371 371 q = IssueQuery.create!(:name => "test", :user_id => 2, :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
372 372 @request.session[:query] = {:id => q.id, :project_id => 1}
373 373
374 374 with_settings :display_subprojects_issues => '0' do
375 375 get :index, :project_id => 1
376 376 end
377 377 assert_response :success
378 378 assert_not_nil assigns(:query)
379 379 assert_equal q.id, assigns(:query).id
380 380 assert_equal 1, assigns(:query).project_id
381 381 assert_equal [1], assigns(:issues).map(&:project_id).uniq
382 382 end
383 383
384 384 def test_private_query_should_not_be_available_to_other_users
385 385 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
386 386 @request.session[:user_id] = 3
387 387
388 388 get :index, :query_id => q.id
389 389 assert_response 403
390 390 end
391 391
392 392 def test_private_query_should_be_available_to_its_user
393 393 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
394 394 @request.session[:user_id] = 2
395 395
396 396 get :index, :query_id => q.id
397 397 assert_response :success
398 398 end
399 399
400 400 def test_public_query_should_be_available_to_other_users
401 401 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PUBLIC, :project => nil)
402 402 @request.session[:user_id] = 3
403 403
404 404 get :index, :query_id => q.id
405 405 assert_response :success
406 406 end
407 407
408 408 def test_index_should_omit_page_param_in_export_links
409 409 get :index, :page => 2
410 410 assert_response :success
411 411 assert_select 'a.atom[href="/issues.atom"]'
412 412 assert_select 'a.csv[href="/issues.csv"]'
413 413 assert_select 'a.pdf[href="/issues.pdf"]'
414 414 assert_select 'form#csv-export-form[action="/issues.csv"]'
415 415 end
416 416
417 417 def test_index_should_not_warn_when_not_exceeding_export_limit
418 418 with_settings :issues_export_limit => 200 do
419 419 get :index
420 420 assert_select '#csv-export-options p.icon-warning', 0
421 421 end
422 422 end
423 423
424 424 def test_index_should_warn_when_exceeding_export_limit
425 425 with_settings :issues_export_limit => 2 do
426 426 get :index
427 427 assert_select '#csv-export-options p.icon-warning', :text => %r{limit: 2}
428 428 end
429 429 end
430 430
431 431 def test_index_csv
432 432 get :index, :format => 'csv'
433 433 assert_response :success
434 434 assert_not_nil assigns(:issues)
435 435 assert_equal 'text/csv; header=present', @response.content_type
436 436 assert @response.body.starts_with?("#,")
437 437 lines = @response.body.chomp.split("\n")
438 438 assert_equal assigns(:query).columns.size, lines[0].split(',').size
439 439 end
440 440
441 441 def test_index_csv_with_project
442 442 get :index, :project_id => 1, :format => 'csv'
443 443 assert_response :success
444 444 assert_not_nil assigns(:issues)
445 445 assert_equal 'text/csv; header=present', @response.content_type
446 446 end
447 447
448 448 def test_index_csv_with_description
449 449 Issue.generate!(:description => 'test_index_csv_with_description')
450 450
451 451 with_settings :default_language => 'en' do
452 452 get :index, :format => 'csv', :description => '1'
453 453 assert_response :success
454 454 assert_not_nil assigns(:issues)
455 455 end
456 456
457 457 assert_equal 'text/csv; header=present', response.content_type
458 458 headers = response.body.chomp.split("\n").first.split(',')
459 459 assert_include 'Description', headers
460 460 assert_include 'test_index_csv_with_description', response.body
461 461 end
462 462
463 463 def test_index_csv_with_spent_time_column
464 464 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
465 465 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
466 466
467 467 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
468 468 assert_response :success
469 469 assert_equal 'text/csv; header=present', @response.content_type
470 470 lines = @response.body.chomp.split("\n")
471 471 assert_include "#{issue.id},#{issue.subject},7.33", lines
472 472 end
473 473
474 474 def test_index_csv_with_all_columns
475 475 get :index, :format => 'csv', :columns => 'all'
476 476 assert_response :success
477 477 assert_not_nil assigns(:issues)
478 478 assert_equal 'text/csv; header=present', @response.content_type
479 479 assert_match /\A#,/, response.body
480 480 lines = response.body.chomp.split("\n")
481 481 assert_equal assigns(:query).available_inline_columns.size, lines[0].split(',').size
482 482 end
483 483
484 484 def test_index_csv_with_multi_column_field
485 485 CustomField.find(1).update_attribute :multiple, true
486 486 issue = Issue.find(1)
487 487 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
488 488 issue.save!
489 489
490 490 get :index, :format => 'csv', :columns => 'all'
491 491 assert_response :success
492 492 lines = @response.body.chomp.split("\n")
493 493 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
494 494 end
495 495
496 496 def test_index_csv_should_format_float_custom_fields_with_csv_decimal_separator
497 497 field = IssueCustomField.create!(:name => 'Float', :is_for_all => true, :tracker_ids => [1], :field_format => 'float')
498 498 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'})
499 499
500 500 with_settings :default_language => 'fr' do
501 501 get :index, :format => 'csv', :columns => 'all'
502 502 assert_response :success
503 503 issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s}
504 504 assert_include '185,60', issue_line
505 505 end
506 506
507 507 with_settings :default_language => 'en' do
508 508 get :index, :format => 'csv', :columns => 'all'
509 509 assert_response :success
510 510 issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s}
511 511 assert_include '185.60', issue_line
512 512 end
513 513 end
514 514
515 515 def test_index_csv_should_fill_parent_column_with_parent_id
516 516 Issue.delete_all
517 517 parent = Issue.generate!
518 518 child = Issue.generate!(:parent_issue_id => parent.id)
519 519
520 520 with_settings :default_language => 'en' do
521 521 get :index, :format => 'csv', :c => %w(parent)
522 522 end
523 523 lines = response.body.split("\n")
524 524 assert_include "#{child.id},#{parent.id}", lines
525 525 end
526 526
527 527 def test_index_csv_big_5
528 528 with_settings :default_language => "zh-TW" do
529 529 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88".force_encoding('UTF-8')
530 530 str_big5 = "\xa4@\xa4\xeb".force_encoding('Big5')
531 531 issue = Issue.generate!(:subject => str_utf8)
532 532
533 533 get :index, :project_id => 1,
534 534 :f => ['subject'],
535 535 :op => '=', :values => [str_utf8],
536 536 :format => 'csv'
537 537 assert_equal 'text/csv; header=present', @response.content_type
538 538 lines = @response.body.chomp.split("\n")
539 539 header = lines[0]
540 540 status = "\xaa\xac\xbaA".force_encoding('Big5')
541 541 assert header.include?(status)
542 542 issue_line = lines.find {|l| l =~ /^#{issue.id},/}
543 543 assert issue_line.include?(str_big5)
544 544 end
545 545 end
546 546
547 547 def test_index_csv_cannot_convert_should_be_replaced_big_5
548 548 with_settings :default_language => "zh-TW" do
549 549 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85".force_encoding('UTF-8')
550 550 issue = Issue.generate!(:subject => str_utf8)
551 551
552 552 get :index, :project_id => 1,
553 553 :f => ['subject'],
554 554 :op => '=', :values => [str_utf8],
555 555 :c => ['status', 'subject'],
556 556 :format => 'csv',
557 557 :set_filter => 1
558 558 assert_equal 'text/csv; header=present', @response.content_type
559 559 lines = @response.body.chomp.split("\n")
560 560 header = lines[0]
561 561 issue_line = lines.find {|l| l =~ /^#{issue.id},/}
562 562 s1 = "\xaa\xac\xbaA".force_encoding('Big5') # status
563 563 assert header.include?(s1)
564 564 s2 = issue_line.split(",")[2]
565 565 s3 = "\xa5H?".force_encoding('Big5') # subject
566 566 assert_equal s3, s2
567 567 end
568 568 end
569 569
570 570 def test_index_csv_tw
571 571 with_settings :default_language => "zh-TW" do
572 572 str1 = "test_index_csv_tw"
573 573 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
574 574
575 575 get :index, :project_id => 1,
576 576 :f => ['subject'],
577 577 :op => '=', :values => [str1],
578 578 :c => ['estimated_hours', 'subject'],
579 579 :format => 'csv',
580 580 :set_filter => 1
581 581 assert_equal 'text/csv; header=present', @response.content_type
582 582 lines = @response.body.chomp.split("\n")
583 583 assert_include "#{issue.id},1234.50,#{str1}", lines
584 584 end
585 585 end
586 586
587 587 def test_index_csv_fr
588 588 with_settings :default_language => "fr" do
589 589 str1 = "test_index_csv_fr"
590 590 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
591 591
592 592 get :index, :project_id => 1,
593 593 :f => ['subject'],
594 594 :op => '=', :values => [str1],
595 595 :c => ['estimated_hours', 'subject'],
596 596 :format => 'csv',
597 597 :set_filter => 1
598 598 assert_equal 'text/csv; header=present', @response.content_type
599 599 lines = @response.body.chomp.split("\n")
600 600 assert_include "#{issue.id};1234,50;#{str1}", lines
601 601 end
602 602 end
603 603
604 604 def test_index_pdf
605 605 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
606 606 with_settings :default_language => lang do
607 607
608 608 get :index
609 609 assert_response :success
610 610 assert_template 'index'
611 611
612 612 get :index, :format => 'pdf'
613 613 assert_response :success
614 614 assert_not_nil assigns(:issues)
615 615 assert_equal 'application/pdf', @response.content_type
616 616
617 617 get :index, :project_id => 1, :format => 'pdf'
618 618 assert_response :success
619 619 assert_not_nil assigns(:issues)
620 620 assert_equal 'application/pdf', @response.content_type
621 621
622 622 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
623 623 assert_response :success
624 624 assert_not_nil assigns(:issues)
625 625 assert_equal 'application/pdf', @response.content_type
626 626 end
627 627 end
628 628 end
629 629
630 630 def test_index_pdf_with_query_grouped_by_list_custom_field
631 631 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
632 632 assert_response :success
633 633 assert_not_nil assigns(:issues)
634 634 assert_not_nil assigns(:issue_count_by_group)
635 635 assert_equal 'application/pdf', @response.content_type
636 636 end
637 637
638 638 def test_index_atom
639 639 get :index, :project_id => 'ecookbook', :format => 'atom'
640 640 assert_response :success
641 641 assert_template 'common/feed'
642 642 assert_equal 'application/atom+xml', response.content_type
643 643
644 644 assert_select 'feed' do
645 645 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
646 646 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
647 647 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
648 648 end
649 649 end
650 650
651 651 def test_index_sort
652 652 get :index, :sort => 'tracker,id:desc'
653 653 assert_response :success
654 654
655 655 sort_params = @request.session['issues_index_sort']
656 656 assert sort_params.is_a?(String)
657 657 assert_equal 'tracker,id:desc', sort_params
658 658
659 659 issues = assigns(:issues)
660 660 assert_not_nil issues
661 661 assert !issues.empty?
662 662 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
663 663 assert_select 'table.issues.sort-by-tracker.sort-asc'
664 664 end
665 665
666 666 def test_index_sort_by_field_not_included_in_columns
667 667 Setting.issue_list_default_columns = %w(subject author)
668 668 get :index, :sort => 'tracker'
669 669 end
670 670
671 671 def test_index_sort_by_assigned_to
672 672 get :index, :sort => 'assigned_to'
673 673 assert_response :success
674 674 assignees = assigns(:issues).collect(&:assigned_to).compact
675 675 assert_equal assignees.sort, assignees
676 676 assert_select 'table.issues.sort-by-assigned-to.sort-asc'
677 677 end
678 678
679 679 def test_index_sort_by_assigned_to_desc
680 680 get :index, :sort => 'assigned_to:desc'
681 681 assert_response :success
682 682 assignees = assigns(:issues).collect(&:assigned_to).compact
683 683 assert_equal assignees.sort.reverse, assignees
684 684 assert_select 'table.issues.sort-by-assigned-to.sort-desc'
685 685 end
686 686
687 687 def test_index_group_by_assigned_to
688 688 get :index, :group_by => 'assigned_to', :sort => 'priority'
689 689 assert_response :success
690 690 end
691 691
692 692 def test_index_sort_by_author
693 693 get :index, :sort => 'author'
694 694 assert_response :success
695 695 authors = assigns(:issues).collect(&:author)
696 696 assert_equal authors.sort, authors
697 697 end
698 698
699 699 def test_index_sort_by_author_desc
700 700 get :index, :sort => 'author:desc'
701 701 assert_response :success
702 702 authors = assigns(:issues).collect(&:author)
703 703 assert_equal authors.sort.reverse, authors
704 704 end
705 705
706 706 def test_index_group_by_author
707 707 get :index, :group_by => 'author', :sort => 'priority'
708 708 assert_response :success
709 709 end
710 710
711 711 def test_index_sort_by_spent_hours
712 712 get :index, :sort => 'spent_hours:desc'
713 713 assert_response :success
714 714 hours = assigns(:issues).collect(&:spent_hours)
715 715 assert_equal hours.sort.reverse, hours
716 716 end
717 717
718 718 def test_index_sort_by_total_spent_hours
719 719 get :index, :sort => 'total_spent_hours:desc'
720 720 assert_response :success
721 721 hours = assigns(:issues).collect(&:total_spent_hours)
722 722 assert_equal hours.sort.reverse, hours
723 723 end
724 724
725 725 def test_index_sort_by_total_estimated_hours
726 726 get :index, :sort => 'total_estimated_hours:desc'
727 727 assert_response :success
728 728 hours = assigns(:issues).collect(&:total_estimated_hours)
729 729 assert_equal hours.sort.reverse, hours
730 730 end
731 731
732 732 def test_index_sort_by_user_custom_field
733 733 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
734 734 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
735 735 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
736 736 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
737 737 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
738 738
739 739 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
740 740 assert_response :success
741 741
742 742 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
743 743 end
744 744
745 745 def test_index_with_columns
746 746 columns = ['tracker', 'subject', 'assigned_to']
747 747 get :index, :set_filter => 1, :c => columns
748 748 assert_response :success
749 749
750 750 # query should use specified columns
751 751 query = assigns(:query)
752 752 assert_kind_of IssueQuery, query
753 753 assert_equal columns, query.column_names.map(&:to_s)
754 754
755 755 # columns should be stored in session
756 756 assert_kind_of Hash, session[:query]
757 757 assert_kind_of Array, session[:query][:column_names]
758 758 assert_equal columns, session[:query][:column_names].map(&:to_s)
759 759
760 760 # ensure only these columns are kept in the selected columns list
761 761 assert_select 'select#selected_columns option' do
762 762 assert_select 'option', 3
763 763 assert_select 'option[value=tracker]'
764 764 assert_select 'option[value=project]', 0
765 765 end
766 766 end
767 767
768 768 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
769 769 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
770 770 get :index, :set_filter => 1
771 771
772 772 # query should use specified columns
773 773 query = assigns(:query)
774 774 assert_kind_of IssueQuery, query
775 775 assert_equal [:id, :project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
776 776 end
777 777
778 778 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
779 779 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
780 780 columns = ['id', 'tracker', 'subject', 'assigned_to']
781 781 get :index, :set_filter => 1, :c => columns
782 782
783 783 # query should use specified columns
784 784 query = assigns(:query)
785 785 assert_kind_of IssueQuery, query
786 786 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
787 787 end
788 788
789 789 def test_index_with_default_columns_should_respect_default_columns_order
790 790 columns = ['assigned_to', 'subject', 'status', 'tracker']
791 791 with_settings :issue_list_default_columns => columns do
792 792 get :index, :project_id => 1, :set_filter => 1
793 793
794 794 query = assigns(:query)
795 795 assert_equal (['id'] + columns).map(&:to_sym), query.columns.map(&:name)
796 796 end
797 797 end
798 798
799 799 def test_index_with_custom_field_column
800 800 columns = %w(tracker subject cf_2)
801 801 get :index, :set_filter => 1, :c => columns
802 802 assert_response :success
803 803
804 804 # query should use specified columns
805 805 query = assigns(:query)
806 806 assert_kind_of IssueQuery, query
807 807 assert_equal columns, query.column_names.map(&:to_s)
808 808
809 809 assert_select 'table.issues td.cf_2.string'
810 810 end
811 811
812 812 def test_index_with_multi_custom_field_column
813 813 field = CustomField.find(1)
814 814 field.update_attribute :multiple, true
815 815 issue = Issue.find(1)
816 816 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
817 817 issue.save!
818 818
819 819 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
820 820 assert_response :success
821 821
822 822 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
823 823 end
824 824
825 825 def test_index_with_multi_user_custom_field_column
826 826 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
827 827 :tracker_ids => [1], :is_for_all => true)
828 828 issue = Issue.find(1)
829 829 issue.custom_field_values = {field.id => ['2', '3']}
830 830 issue.save!
831 831
832 832 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
833 833 assert_response :success
834 834
835 835 assert_select "table.issues td.cf_#{field.id}" do
836 836 assert_select 'a', 2
837 837 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
838 838 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
839 839 end
840 840 end
841 841
842 842 def test_index_with_date_column
843 843 with_settings :date_format => '%d/%m/%Y' do
844 844 Issue.find(1).update_attribute :start_date, '1987-08-24'
845 845 get :index, :set_filter => 1, :c => %w(start_date)
846 846 assert_select "table.issues td.start_date", :text => '24/08/1987'
847 847 end
848 848 end
849 849
850 850 def test_index_with_done_ratio_column
851 851 Issue.find(1).update_attribute :done_ratio, 40
852 852 get :index, :set_filter => 1, :c => %w(done_ratio)
853 853 assert_select 'table.issues td.done_ratio' do
854 854 assert_select 'table.progress' do
855 855 assert_select 'td.closed[style=?]', 'width: 40%;'
856 856 end
857 857 end
858 858 end
859 859
860 860 def test_index_with_spent_hours_column
861 861 Issue.expects(:load_visible_spent_hours).once
862 862 get :index, :set_filter => 1, :c => %w(subject spent_hours)
863 863 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
864 864 end
865 865
866 866 def test_index_with_total_spent_hours_column
867 867 Issue.expects(:load_visible_total_spent_hours).once
868 868 get :index, :set_filter => 1, :c => %w(subject total_spent_hours)
869 869 assert_select 'table.issues tr#issue-3 td.total_spent_hours', :text => '1.00'
870 870 end
871 871
872 872 def test_index_with_total_estimated_hours_column
873 873 get :index, :set_filter => 1, :c => %w(subject total_estimated_hours)
874 874 assert_select 'table.issues td.total_estimated_hours'
875 875 end
876 876
877 877 def test_index_should_not_show_spent_hours_column_without_permission
878 878 Role.anonymous.remove_permission! :view_time_entries
879 879 get :index, :set_filter => 1, :c => %w(subject spent_hours)
880 880 assert_select 'td.spent_hours', 0
881 881 end
882 882
883 883 def test_index_with_fixed_version_column
884 884 get :index, :set_filter => 1, :c => %w(fixed_version)
885 885 assert_select 'table.issues td.fixed_version' do
886 886 assert_select 'a[href=?]', '/versions/2', :text => 'eCookbook - 1.0'
887 887 end
888 888 end
889 889
890 890 def test_index_with_relations_column
891 891 IssueRelation.delete_all
892 892 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
893 893 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
894 894 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
895 895 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
896 896
897 897 get :index, :set_filter => 1, :c => %w(subject relations)
898 898 assert_response :success
899 899 assert_select "tr#issue-1 td.relations" do
900 900 assert_select "span", 3
901 901 assert_select "span", :text => "Related to #7"
902 902 assert_select "span", :text => "Related to #8"
903 903 assert_select "span", :text => "Blocks #11"
904 904 end
905 905 assert_select "tr#issue-2 td.relations" do
906 906 assert_select "span", 1
907 907 assert_select "span", :text => "Blocked by #12"
908 908 end
909 909 assert_select "tr#issue-3 td.relations" do
910 910 assert_select "span", 0
911 911 end
912 912
913 913 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
914 914 assert_response :success
915 915 assert_equal 'text/csv; header=present', response.content_type
916 916 lines = response.body.chomp.split("\n")
917 917 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
918 918 assert_include '2,Blocked by #12', lines
919 919 assert_include '3,""', lines
920 920
921 921 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
922 922 assert_response :success
923 923 assert_equal 'application/pdf', response.content_type
924 924 end
925 925
926 926 def test_index_with_description_column
927 927 get :index, :set_filter => 1, :c => %w(subject description)
928 928
929 929 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
930 930 assert_select 'td.description[colspan="3"]', :text => 'Unable to print recipes'
931 931
932 932 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
933 933 assert_response :success
934 934 assert_equal 'application/pdf', response.content_type
935 935 end
936 936
937 937 def test_index_with_parent_column
938 938 Issue.delete_all
939 939 parent = Issue.generate!
940 940 child = Issue.generate!(:parent_issue_id => parent.id)
941 941
942 942 get :index, :c => %w(parent)
943 943
944 944 assert_select 'td.parent', :text => "#{parent.tracker} ##{parent.id}"
945 945 assert_select 'td.parent a[title=?]', parent.subject
946 946 end
947 947
948 948 def test_index_send_html_if_query_is_invalid
949 949 get :index, :f => ['start_date'], :op => {:start_date => '='}
950 950 assert_equal 'text/html', @response.content_type
951 951 assert_template 'index'
952 952 end
953 953
954 954 def test_index_send_nothing_if_query_is_invalid
955 955 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
956 956 assert_equal 'text/csv', @response.content_type
957 957 assert @response.body.blank?
958 958 end
959 959
960 960 def test_show_by_anonymous
961 961 get :show, :id => 1
962 962 assert_response :success
963 963 assert_template 'show'
964 964 assert_equal Issue.find(1), assigns(:issue)
965 965 assert_select 'div.issue div.description', :text => /Unable to print recipes/
966 966 # anonymous role is allowed to add a note
967 967 assert_select 'form#issue-form' do
968 968 assert_select 'fieldset' do
969 969 assert_select 'legend', :text => 'Notes'
970 970 assert_select 'textarea[name=?]', 'issue[notes]'
971 971 end
972 972 end
973 973 assert_select 'title', :text => "Bug #1: Cannot print recipes - eCookbook - Redmine"
974 974 end
975 975
976 976 def test_show_by_manager
977 977 @request.session[:user_id] = 2
978 978 get :show, :id => 1
979 979 assert_response :success
980 980 assert_select 'a', :text => /Quote/
981 981 assert_select 'form#issue-form' do
982 982 assert_select 'fieldset' do
983 983 assert_select 'legend', :text => 'Change properties'
984 984 assert_select 'input[name=?]', 'issue[subject]'
985 985 end
986 986 assert_select 'fieldset' do
987 987 assert_select 'legend', :text => 'Log time'
988 988 assert_select 'input[name=?]', 'time_entry[hours]'
989 989 end
990 990 assert_select 'fieldset' do
991 991 assert_select 'legend', :text => 'Notes'
992 992 assert_select 'textarea[name=?]', 'issue[notes]'
993 993 end
994 994 end
995 995 end
996 996
997 997 def test_show_should_display_update_form
998 998 @request.session[:user_id] = 2
999 999 get :show, :id => 1
1000 1000 assert_response :success
1001 1001
1002 1002 assert_select 'form#issue-form' do
1003 1003 assert_select 'input[name=?]', 'issue[is_private]'
1004 1004 assert_select 'select[name=?]', 'issue[project_id]'
1005 1005 assert_select 'select[name=?]', 'issue[tracker_id]'
1006 1006 assert_select 'input[name=?]', 'issue[subject]'
1007 1007 assert_select 'textarea[name=?]', 'issue[description]'
1008 1008 assert_select 'select[name=?]', 'issue[status_id]'
1009 1009 assert_select 'select[name=?]', 'issue[priority_id]'
1010 1010 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1011 1011 assert_select 'select[name=?]', 'issue[category_id]'
1012 1012 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1013 1013 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1014 1014 assert_select 'input[name=?]', 'issue[start_date]'
1015 1015 assert_select 'input[name=?]', 'issue[due_date]'
1016 1016 assert_select 'select[name=?]', 'issue[done_ratio]'
1017 1017 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
1018 1018 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1019 1019 assert_select 'textarea[name=?]', 'issue[notes]'
1020 1020 end
1021 1021 end
1022 1022
1023 1023 def test_show_should_display_update_form_with_minimal_permissions
1024 1024 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
1025 1025 WorkflowTransition.delete_all :role_id => 1
1026 1026
1027 1027 @request.session[:user_id] = 2
1028 1028 get :show, :id => 1
1029 1029 assert_response :success
1030 1030
1031 1031 assert_select 'form#issue-form' do
1032 1032 assert_select 'input[name=?]', 'issue[is_private]', 0
1033 1033 assert_select 'select[name=?]', 'issue[project_id]', 0
1034 1034 assert_select 'select[name=?]', 'issue[tracker_id]', 0
1035 1035 assert_select 'input[name=?]', 'issue[subject]', 0
1036 1036 assert_select 'textarea[name=?]', 'issue[description]', 0
1037 1037 assert_select 'select[name=?]', 'issue[status_id]', 0
1038 1038 assert_select 'select[name=?]', 'issue[priority_id]', 0
1039 1039 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
1040 1040 assert_select 'select[name=?]', 'issue[category_id]', 0
1041 1041 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
1042 1042 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1043 1043 assert_select 'input[name=?]', 'issue[start_date]', 0
1044 1044 assert_select 'input[name=?]', 'issue[due_date]', 0
1045 1045 assert_select 'select[name=?]', 'issue[done_ratio]', 0
1046 1046 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
1047 1047 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1048 1048 assert_select 'textarea[name=?]', 'issue[notes]'
1049 1049 end
1050 1050 end
1051 1051
1052 1052 def test_show_should_not_display_update_form_without_permissions
1053 1053 Role.find(1).update_attribute :permissions, [:view_issues]
1054 1054
1055 1055 @request.session[:user_id] = 2
1056 1056 get :show, :id => 1
1057 1057 assert_response :success
1058 1058
1059 1059 assert_select 'form#issue-form', 0
1060 1060 end
1061 1061
1062 1062 def test_update_form_should_not_display_inactive_enumerations
1063 1063 assert !IssuePriority.find(15).active?
1064 1064
1065 1065 @request.session[:user_id] = 2
1066 1066 get :show, :id => 1
1067 1067 assert_response :success
1068 1068
1069 1069 assert_select 'form#issue-form' do
1070 1070 assert_select 'select[name=?]', 'issue[priority_id]' do
1071 1071 assert_select 'option[value="4"]'
1072 1072 assert_select 'option[value="15"]', 0
1073 1073 end
1074 1074 end
1075 1075 end
1076 1076
1077 1077 def test_update_form_should_allow_attachment_upload
1078 1078 @request.session[:user_id] = 2
1079 1079 get :show, :id => 1
1080 1080
1081 1081 assert_select 'form#issue-form[method=post][enctype="multipart/form-data"]' do
1082 1082 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1083 1083 end
1084 1084 end
1085 1085
1086 1086 def test_show_should_deny_anonymous_access_without_permission
1087 1087 Role.anonymous.remove_permission!(:view_issues)
1088 1088 get :show, :id => 1
1089 1089 assert_response :redirect
1090 1090 end
1091 1091
1092 1092 def test_show_should_deny_anonymous_access_to_private_issue
1093 1093 Issue.where(:id => 1).update_all(["is_private = ?", true])
1094 1094 get :show, :id => 1
1095 1095 assert_response :redirect
1096 1096 end
1097 1097
1098 1098 def test_show_should_deny_non_member_access_without_permission
1099 1099 Role.non_member.remove_permission!(:view_issues)
1100 1100 @request.session[:user_id] = 9
1101 1101 get :show, :id => 1
1102 1102 assert_response 403
1103 1103 end
1104 1104
1105 1105 def test_show_should_deny_non_member_access_to_private_issue
1106 1106 Issue.where(:id => 1).update_all(["is_private = ?", true])
1107 1107 @request.session[:user_id] = 9
1108 1108 get :show, :id => 1
1109 1109 assert_response 403
1110 1110 end
1111 1111
1112 1112 def test_show_should_deny_member_access_without_permission
1113 1113 Role.find(1).remove_permission!(:view_issues)
1114 1114 @request.session[:user_id] = 2
1115 1115 get :show, :id => 1
1116 1116 assert_response 403
1117 1117 end
1118 1118
1119 1119 def test_show_should_deny_member_access_to_private_issue_without_permission
1120 1120 Issue.where(:id => 1).update_all(["is_private = ?", true])
1121 1121 @request.session[:user_id] = 3
1122 1122 get :show, :id => 1
1123 1123 assert_response 403
1124 1124 end
1125 1125
1126 1126 def test_show_should_allow_author_access_to_private_issue
1127 1127 Issue.where(:id => 1).update_all(["is_private = ?, author_id = 3", true])
1128 1128 @request.session[:user_id] = 3
1129 1129 get :show, :id => 1
1130 1130 assert_response :success
1131 1131 end
1132 1132
1133 1133 def test_show_should_allow_assignee_access_to_private_issue
1134 1134 Issue.where(:id => 1).update_all(["is_private = ?, assigned_to_id = 3", true])
1135 1135 @request.session[:user_id] = 3
1136 1136 get :show, :id => 1
1137 1137 assert_response :success
1138 1138 end
1139 1139
1140 1140 def test_show_should_allow_member_access_to_private_issue_with_permission
1141 1141 Issue.where(:id => 1).update_all(["is_private = ?", true])
1142 1142 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1143 1143 @request.session[:user_id] = 3
1144 1144 get :show, :id => 1
1145 1145 assert_response :success
1146 1146 end
1147 1147
1148 1148 def test_show_should_not_disclose_relations_to_invisible_issues
1149 1149 Setting.cross_project_issue_relations = '1'
1150 1150 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1151 1151 # Relation to a private project issue
1152 1152 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1153 1153
1154 1154 get :show, :id => 1
1155 1155 assert_response :success
1156 1156
1157 1157 assert_select 'div#relations' do
1158 1158 assert_select 'a', :text => /#2$/
1159 1159 assert_select 'a', :text => /#4$/, :count => 0
1160 1160 end
1161 1161 end
1162 1162
1163 1163 def test_show_should_list_subtasks
1164 1164 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1165 1165
1166 1166 get :show, :id => 1
1167 1167 assert_response :success
1168 1168
1169 1169 assert_select 'div#issue_tree' do
1170 1170 assert_select 'td.subject', :text => /Child Issue/
1171 1171 end
1172 1172 end
1173 1173
1174 1174 def test_show_should_list_parents
1175 1175 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1176 1176
1177 1177 get :show, :id => issue.id
1178 1178 assert_response :success
1179 1179
1180 1180 assert_select 'div.subject' do
1181 1181 assert_select 'h3', 'Child Issue'
1182 1182 assert_select 'a[href="/issues/1"]'
1183 1183 end
1184 1184 end
1185 1185
1186 1186 def test_show_should_not_display_prev_next_links_without_query_in_session
1187 1187 get :show, :id => 1
1188 1188 assert_response :success
1189 1189 assert_nil assigns(:prev_issue_id)
1190 1190 assert_nil assigns(:next_issue_id)
1191 1191
1192 1192 assert_select 'div.next-prev-links', 0
1193 1193 end
1194 1194
1195 1195 def test_show_should_display_prev_next_links_with_query_in_session
1196 1196 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1197 1197 @request.session['issues_index_sort'] = 'id'
1198 1198
1199 1199 with_settings :display_subprojects_issues => '0' do
1200 1200 get :show, :id => 3
1201 1201 end
1202 1202
1203 1203 assert_response :success
1204 1204 # Previous and next issues for all projects
1205 1205 assert_equal 2, assigns(:prev_issue_id)
1206 1206 assert_equal 5, assigns(:next_issue_id)
1207 1207
1208 1208 count = Issue.open.visible.count
1209 1209
1210 1210 assert_select 'div.next-prev-links' do
1211 1211 assert_select 'a[href="/issues/2"]', :text => /Previous/
1212 1212 assert_select 'a[href="/issues/5"]', :text => /Next/
1213 1213 assert_select 'span.position', :text => "3 of #{count}"
1214 1214 end
1215 1215 end
1216 1216
1217 1217 def test_show_should_display_prev_next_links_with_saved_query_in_session
1218 1218 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1,
1219 1219 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1220 1220 :sort_criteria => [['id', 'asc']])
1221 1221 @request.session[:query] = {:id => query.id, :project_id => nil}
1222 1222
1223 1223 get :show, :id => 11
1224 1224
1225 1225 assert_response :success
1226 1226 assert_equal query, assigns(:query)
1227 1227 # Previous and next issues for all projects
1228 1228 assert_equal 8, assigns(:prev_issue_id)
1229 1229 assert_equal 12, assigns(:next_issue_id)
1230 1230
1231 1231 assert_select 'div.next-prev-links' do
1232 1232 assert_select 'a[href="/issues/8"]', :text => /Previous/
1233 1233 assert_select 'a[href="/issues/12"]', :text => /Next/
1234 1234 end
1235 1235 end
1236 1236
1237 1237 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1238 1238 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1239 1239
1240 1240 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1241 1241 @request.session['issues_index_sort'] = assoc_sort
1242 1242
1243 1243 get :show, :id => 3
1244 1244 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1245 1245
1246 1246 assert_select 'div.next-prev-links' do
1247 1247 assert_select 'a', :text => /(Previous|Next)/
1248 1248 end
1249 1249 end
1250 1250 end
1251 1251
1252 1252 def test_show_should_display_prev_next_links_with_project_query_in_session
1253 1253 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1254 1254 @request.session['issues_index_sort'] = 'id'
1255 1255
1256 1256 with_settings :display_subprojects_issues => '0' do
1257 1257 get :show, :id => 3
1258 1258 end
1259 1259
1260 1260 assert_response :success
1261 1261 # Previous and next issues inside project
1262 1262 assert_equal 2, assigns(:prev_issue_id)
1263 1263 assert_equal 7, assigns(:next_issue_id)
1264 1264
1265 1265 assert_select 'div.next-prev-links' do
1266 1266 assert_select 'a[href="/issues/2"]', :text => /Previous/
1267 1267 assert_select 'a[href="/issues/7"]', :text => /Next/
1268 1268 end
1269 1269 end
1270 1270
1271 1271 def test_show_should_not_display_prev_link_for_first_issue
1272 1272 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1273 1273 @request.session['issues_index_sort'] = 'id'
1274 1274
1275 1275 with_settings :display_subprojects_issues => '0' do
1276 1276 get :show, :id => 1
1277 1277 end
1278 1278
1279 1279 assert_response :success
1280 1280 assert_nil assigns(:prev_issue_id)
1281 1281 assert_equal 2, assigns(:next_issue_id)
1282 1282
1283 1283 assert_select 'div.next-prev-links' do
1284 1284 assert_select 'a', :text => /Previous/, :count => 0
1285 1285 assert_select 'a[href="/issues/2"]', :text => /Next/
1286 1286 end
1287 1287 end
1288 1288
1289 1289 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1290 1290 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1291 1291 @request.session['issues_index_sort'] = 'id'
1292 1292
1293 1293 get :show, :id => 1
1294 1294
1295 1295 assert_response :success
1296 1296 assert_nil assigns(:prev_issue_id)
1297 1297 assert_nil assigns(:next_issue_id)
1298 1298
1299 1299 assert_select 'a', :text => /Previous/, :count => 0
1300 1300 assert_select 'a', :text => /Next/, :count => 0
1301 1301 end
1302 1302
1303 1303 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1304 1304 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1305 1305 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1306 1306 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1307 1307 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1308 1308 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1309 1309
1310 1310 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1, :filters => {},
1311 1311 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1312 1312 @request.session[:query] = {:id => query.id, :project_id => nil}
1313 1313
1314 1314 get :show, :id => 3
1315 1315 assert_response :success
1316 1316
1317 1317 assert_equal 2, assigns(:prev_issue_id)
1318 1318 assert_equal 1, assigns(:next_issue_id)
1319 1319
1320 1320 assert_select 'div.next-prev-links' do
1321 1321 assert_select 'a[href="/issues/2"]', :text => /Previous/
1322 1322 assert_select 'a[href="/issues/1"]', :text => /Next/
1323 1323 end
1324 1324 end
1325 1325
1326 1326 def test_show_should_display_link_to_the_assignee
1327 1327 get :show, :id => 2
1328 1328 assert_response :success
1329 1329 assert_select '.assigned-to' do
1330 1330 assert_select 'a[href="/users/3"]'
1331 1331 end
1332 1332 end
1333 1333
1334 1334 def test_show_should_display_visible_changesets_from_other_projects
1335 1335 project = Project.find(2)
1336 1336 issue = project.issues.first
1337 1337 issue.changeset_ids = [102]
1338 1338 issue.save!
1339 1339 # changesets from other projects should be displayed even if repository
1340 1340 # is disabled on issue's project
1341 1341 project.disable_module! :repository
1342 1342
1343 1343 @request.session[:user_id] = 2
1344 1344 get :show, :id => issue.id
1345 1345
1346 1346 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1347 1347 end
1348 1348
1349 1349 def test_show_should_display_watchers
1350 1350 @request.session[:user_id] = 2
1351 1351 Issue.find(1).add_watcher User.find(2)
1352 1352
1353 1353 get :show, :id => 1
1354 1354 assert_select 'div#watchers ul' do
1355 1355 assert_select 'li' do
1356 1356 assert_select 'a[href="/users/2"]'
1357 1357 assert_select 'a img[alt=Delete]'
1358 1358 end
1359 1359 end
1360 1360 end
1361 1361
1362 1362 def test_show_should_display_watchers_with_gravatars
1363 1363 @request.session[:user_id] = 2
1364 1364 Issue.find(1).add_watcher User.find(2)
1365 1365
1366 1366 with_settings :gravatar_enabled => '1' do
1367 1367 get :show, :id => 1
1368 1368 end
1369 1369
1370 1370 assert_select 'div#watchers ul' do
1371 1371 assert_select 'li' do
1372 1372 assert_select 'img.gravatar'
1373 1373 assert_select 'a[href="/users/2"]'
1374 1374 assert_select 'a img[alt=Delete]'
1375 1375 end
1376 1376 end
1377 1377 end
1378 1378
1379 1379 def test_show_with_thumbnails_enabled_should_display_thumbnails
1380 1380 @request.session[:user_id] = 2
1381 1381
1382 1382 with_settings :thumbnails_enabled => '1' do
1383 1383 get :show, :id => 14
1384 1384 assert_response :success
1385 1385 end
1386 1386
1387 1387 assert_select 'div.thumbnails' do
1388 1388 assert_select 'a[href="/attachments/16/testfile.png"]' do
1389 1389 assert_select 'img[src="/attachments/thumbnail/16"]'
1390 1390 end
1391 1391 end
1392 1392 end
1393 1393
1394 1394 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1395 1395 @request.session[:user_id] = 2
1396 1396
1397 1397 with_settings :thumbnails_enabled => '0' do
1398 1398 get :show, :id => 14
1399 1399 assert_response :success
1400 1400 end
1401 1401
1402 1402 assert_select 'div.thumbnails', 0
1403 1403 end
1404 1404
1405 1405 def test_show_with_multi_custom_field
1406 1406 field = CustomField.find(1)
1407 1407 field.update_attribute :multiple, true
1408 1408 issue = Issue.find(1)
1409 1409 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1410 1410 issue.save!
1411 1411
1412 1412 get :show, :id => 1
1413 1413 assert_response :success
1414 1414
1415 1415 assert_select 'td', :text => 'MySQL, Oracle'
1416 1416 end
1417 1417
1418 1418 def test_show_with_multi_user_custom_field
1419 1419 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1420 1420 :tracker_ids => [1], :is_for_all => true)
1421 1421 issue = Issue.find(1)
1422 1422 issue.custom_field_values = {field.id => ['2', '3']}
1423 1423 issue.save!
1424 1424
1425 1425 get :show, :id => 1
1426 1426 assert_response :success
1427 1427
1428 1428 assert_select "td.cf_#{field.id}", :text => 'Dave Lopper, John Smith' do
1429 1429 assert_select 'a', :text => 'Dave Lopper'
1430 1430 assert_select 'a', :text => 'John Smith'
1431 1431 end
1432 1432 end
1433 1433
1434 1434 def test_show_should_display_private_notes_with_permission_only
1435 1435 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1436 1436 @request.session[:user_id] = 2
1437 1437
1438 1438 get :show, :id => 2
1439 1439 assert_response :success
1440 1440 assert_include journal, assigns(:journals)
1441 1441
1442 1442 Role.find(1).remove_permission! :view_private_notes
1443 1443 get :show, :id => 2
1444 1444 assert_response :success
1445 1445 assert_not_include journal, assigns(:journals)
1446 1446 end
1447 1447
1448 1448 def test_show_atom
1449 1449 get :show, :id => 2, :format => 'atom'
1450 1450 assert_response :success
1451 1451 assert_template 'journals/index'
1452 1452 # Inline image
1453 1453 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1454 1454 end
1455 1455
1456 1456 def test_show_export_to_pdf
1457 1457 issue = Issue.find(3)
1458 1458 assert issue.relations.select{|r| r.other_issue(issue).visible?}.present?
1459 1459 get :show, :id => 3, :format => 'pdf'
1460 1460 assert_response :success
1461 1461 assert_equal 'application/pdf', @response.content_type
1462 1462 assert @response.body.starts_with?('%PDF')
1463 1463 assert_not_nil assigns(:issue)
1464 1464 end
1465 1465
1466 1466 def test_export_to_pdf_with_utf8_u_fffd
1467 1467 # U+FFFD
1468 1468 s = "\xef\xbf\xbd"
1469 1469 s.force_encoding('UTF-8') if s.respond_to?(:force_encoding)
1470 1470 issue = Issue.generate!(:subject => s)
1471 1471 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
1472 1472 with_settings :default_language => lang do
1473 1473 get :show, :id => issue.id, :format => 'pdf'
1474 1474 assert_response :success
1475 1475 assert_equal 'application/pdf', @response.content_type
1476 1476 assert @response.body.starts_with?('%PDF')
1477 1477 assert_not_nil assigns(:issue)
1478 1478 end
1479 1479 end
1480 1480 end
1481 1481
1482 1482 def test_show_export_to_pdf_with_ancestors
1483 1483 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1484 1484
1485 1485 get :show, :id => issue.id, :format => 'pdf'
1486 1486 assert_response :success
1487 1487 assert_equal 'application/pdf', @response.content_type
1488 1488 assert @response.body.starts_with?('%PDF')
1489 1489 end
1490 1490
1491 1491 def test_show_export_to_pdf_with_descendants
1492 1492 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1493 1493 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1494 1494 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1495 1495
1496 1496 get :show, :id => 1, :format => 'pdf'
1497 1497 assert_response :success
1498 1498 assert_equal 'application/pdf', @response.content_type
1499 1499 assert @response.body.starts_with?('%PDF')
1500 1500 end
1501 1501
1502 1502 def test_show_export_to_pdf_with_journals
1503 1503 get :show, :id => 1, :format => 'pdf'
1504 1504 assert_response :success
1505 1505 assert_equal 'application/pdf', @response.content_type
1506 1506 assert @response.body.starts_with?('%PDF')
1507 1507 end
1508 1508
1509 1509 def test_show_export_to_pdf_with_changesets
1510 1510 [[100], [100, 101], [100, 101, 102]].each do |cs|
1511 1511 issue1 = Issue.find(3)
1512 1512 issue1.changesets = Changeset.find(cs)
1513 1513 issue1.save!
1514 1514 issue = Issue.find(3)
1515 1515 assert_equal issue.changesets.count, cs.size
1516 1516 get :show, :id => 3, :format => 'pdf'
1517 1517 assert_response :success
1518 1518 assert_equal 'application/pdf', @response.content_type
1519 1519 assert @response.body.starts_with?('%PDF')
1520 1520 end
1521 1521 end
1522 1522
1523 1523 def test_show_invalid_should_respond_with_404
1524 1524 get :show, :id => 999
1525 1525 assert_response 404
1526 1526 end
1527 1527
1528 1528 def test_get_new
1529 1529 @request.session[:user_id] = 2
1530 1530 get :new, :project_id => 1, :tracker_id => 1
1531 1531 assert_response :success
1532 1532 assert_template 'new'
1533 1533
1534 1534 assert_select 'form#issue-form[action=?]', '/projects/ecookbook/issues'
1535 1535 assert_select 'form#issue-form' do
1536 1536 assert_select 'input[name=?]', 'issue[is_private]'
1537 1537 assert_select 'select[name=?]', 'issue[project_id]', 0
1538 1538 assert_select 'select[name=?]', 'issue[tracker_id]'
1539 1539 assert_select 'input[name=?]', 'issue[subject]'
1540 1540 assert_select 'textarea[name=?]', 'issue[description]'
1541 1541 assert_select 'select[name=?]', 'issue[status_id]'
1542 1542 assert_select 'select[name=?]', 'issue[priority_id]'
1543 1543 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1544 1544 assert_select 'select[name=?]', 'issue[category_id]'
1545 1545 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1546 1546 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1547 1547 assert_select 'input[name=?]', 'issue[start_date]'
1548 1548 assert_select 'input[name=?]', 'issue[due_date]'
1549 1549 assert_select 'select[name=?]', 'issue[done_ratio]'
1550 1550 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1551 1551 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1552 1552 end
1553 1553
1554 1554 # Be sure we don't display inactive IssuePriorities
1555 1555 assert ! IssuePriority.find(15).active?
1556 1556 assert_select 'select[name=?]', 'issue[priority_id]' do
1557 1557 assert_select 'option[value="15"]', 0
1558 1558 end
1559 1559 end
1560 1560
1561 1561 def test_get_new_with_minimal_permissions
1562 1562 Role.find(1).update_attribute :permissions, [:add_issues]
1563 1563 WorkflowTransition.delete_all :role_id => 1
1564 1564
1565 1565 @request.session[:user_id] = 2
1566 1566 get :new, :project_id => 1, :tracker_id => 1
1567 1567 assert_response :success
1568 1568 assert_template 'new'
1569 1569
1570 1570 assert_select 'form#issue-form' do
1571 1571 assert_select 'input[name=?]', 'issue[is_private]', 0
1572 1572 assert_select 'select[name=?]', 'issue[project_id]', 0
1573 1573 assert_select 'select[name=?]', 'issue[tracker_id]'
1574 1574 assert_select 'input[name=?]', 'issue[subject]'
1575 1575 assert_select 'textarea[name=?]', 'issue[description]'
1576 1576 assert_select 'select[name=?]', 'issue[status_id]'
1577 1577 assert_select 'select[name=?]', 'issue[priority_id]'
1578 1578 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1579 1579 assert_select 'select[name=?]', 'issue[category_id]'
1580 1580 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1581 1581 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1582 1582 assert_select 'input[name=?]', 'issue[start_date]'
1583 1583 assert_select 'input[name=?]', 'issue[due_date]'
1584 1584 assert_select 'select[name=?]', 'issue[done_ratio]'
1585 1585 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1586 1586 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1587 1587 end
1588 1588 end
1589 1589
1590 1590 def test_new_without_project_id
1591 1591 @request.session[:user_id] = 2
1592 1592 get :new
1593 1593 assert_response :success
1594 1594 assert_template 'new'
1595 1595
1596 1596 assert_select 'form#issue-form[action=?]', '/issues'
1597 1597 assert_select 'form#issue-form' do
1598 1598 assert_select 'select[name=?]', 'issue[project_id]'
1599 1599 end
1600 1600
1601 1601 assert_nil assigns(:project)
1602 1602 assert_not_nil assigns(:issue)
1603 1603 end
1604 1604
1605 1605 def test_new_should_select_default_status
1606 1606 @request.session[:user_id] = 2
1607 1607
1608 1608 get :new, :project_id => 1
1609 1609 assert_response :success
1610 1610 assert_template 'new'
1611 1611 assert_select 'select[name=?]', 'issue[status_id]' do
1612 1612 assert_select 'option[value="1"][selected=selected]'
1613 1613 end
1614 1614 assert_select 'input[name=was_default_status][value="1"]'
1615 1615 end
1616 1616
1617 1617 def test_get_new_with_list_custom_field
1618 1618 @request.session[:user_id] = 2
1619 1619 get :new, :project_id => 1, :tracker_id => 1
1620 1620 assert_response :success
1621 1621 assert_template 'new'
1622 1622
1623 1623 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1624 1624 assert_select 'option', 4
1625 1625 assert_select 'option[value=MySQL]', :text => 'MySQL'
1626 1626 end
1627 1627 end
1628 1628
1629 1629 def test_get_new_with_multi_custom_field
1630 1630 field = IssueCustomField.find(1)
1631 1631 field.update_attribute :multiple, true
1632 1632
1633 1633 @request.session[:user_id] = 2
1634 1634 get :new, :project_id => 1, :tracker_id => 1
1635 1635 assert_response :success
1636 1636 assert_template 'new'
1637 1637
1638 1638 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1639 1639 assert_select 'option', 3
1640 1640 assert_select 'option[value=MySQL]', :text => 'MySQL'
1641 1641 end
1642 1642 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1643 1643 end
1644 1644
1645 1645 def test_get_new_with_multi_user_custom_field
1646 1646 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1647 1647 :tracker_ids => [1], :is_for_all => true)
1648 1648
1649 1649 @request.session[:user_id] = 2
1650 1650 get :new, :project_id => 1, :tracker_id => 1
1651 1651 assert_response :success
1652 1652 assert_template 'new'
1653 1653
1654 1654 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1655 1655 assert_select 'option', Project.find(1).users.count
1656 1656 assert_select 'option[value="2"]', :text => 'John Smith'
1657 1657 end
1658 1658 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1659 1659 end
1660 1660
1661 1661 def test_get_new_with_date_custom_field
1662 1662 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1663 1663
1664 1664 @request.session[:user_id] = 2
1665 1665 get :new, :project_id => 1, :tracker_id => 1
1666 1666 assert_response :success
1667 1667
1668 1668 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1669 1669 end
1670 1670
1671 1671 def test_get_new_with_text_custom_field
1672 1672 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1673 1673
1674 1674 @request.session[:user_id] = 2
1675 1675 get :new, :project_id => 1, :tracker_id => 1
1676 1676 assert_response :success
1677 1677
1678 1678 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1679 1679 end
1680 1680
1681 1681 def test_get_new_without_default_start_date_is_creation_date
1682 1682 with_settings :default_issue_start_date_to_creation_date => 0 do
1683 1683 @request.session[:user_id] = 2
1684 1684 get :new, :project_id => 1, :tracker_id => 1
1685 1685 assert_response :success
1686 1686 assert_template 'new'
1687 1687 assert_select 'input[name=?]', 'issue[start_date]'
1688 1688 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1689 1689 end
1690 1690 end
1691 1691
1692 1692 def test_get_new_with_default_start_date_is_creation_date
1693 1693 with_settings :default_issue_start_date_to_creation_date => 1 do
1694 1694 @request.session[:user_id] = 2
1695 1695 get :new, :project_id => 1, :tracker_id => 1
1696 1696 assert_response :success
1697 1697 assert_template 'new'
1698 1698 assert_select 'input[name=?][value=?]', 'issue[start_date]',
1699 1699 Date.today.to_s
1700 1700 end
1701 1701 end
1702 1702
1703 1703 def test_get_new_form_should_allow_attachment_upload
1704 1704 @request.session[:user_id] = 2
1705 1705 get :new, :project_id => 1, :tracker_id => 1
1706 1706
1707 1707 assert_select 'form[id=issue-form][method=post][enctype="multipart/form-data"]' do
1708 1708 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1709 1709 end
1710 1710 end
1711 1711
1712 1712 def test_get_new_should_prefill_the_form_from_params
1713 1713 @request.session[:user_id] = 2
1714 1714 get :new, :project_id => 1,
1715 1715 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1716 1716
1717 1717 issue = assigns(:issue)
1718 1718 assert_equal 3, issue.tracker_id
1719 1719 assert_equal 'Prefilled', issue.description
1720 1720 assert_equal 'Custom field value', issue.custom_field_value(2)
1721 1721
1722 1722 assert_select 'select[name=?]', 'issue[tracker_id]' do
1723 1723 assert_select 'option[value="3"][selected=selected]'
1724 1724 end
1725 1725 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1726 1726 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1727 1727 end
1728 1728
1729 1729 def test_get_new_should_mark_required_fields
1730 1730 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1731 1731 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1732 1732 WorkflowPermission.delete_all
1733 1733 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1734 1734 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1735 1735 @request.session[:user_id] = 2
1736 1736
1737 1737 get :new, :project_id => 1
1738 1738 assert_response :success
1739 1739 assert_template 'new'
1740 1740
1741 1741 assert_select 'label[for=issue_start_date]' do
1742 1742 assert_select 'span[class=required]', 0
1743 1743 end
1744 1744 assert_select 'label[for=issue_due_date]' do
1745 1745 assert_select 'span[class=required]'
1746 1746 end
1747 1747 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1748 1748 assert_select 'span[class=required]', 0
1749 1749 end
1750 1750 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1751 1751 assert_select 'span[class=required]'
1752 1752 end
1753 1753 end
1754 1754
1755 1755 def test_get_new_should_not_display_readonly_fields
1756 1756 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1757 1757 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1758 1758 WorkflowPermission.delete_all
1759 1759 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1760 1760 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1761 1761 @request.session[:user_id] = 2
1762 1762
1763 1763 get :new, :project_id => 1
1764 1764 assert_response :success
1765 1765 assert_template 'new'
1766 1766
1767 1767 assert_select 'input[name=?]', 'issue[start_date]'
1768 1768 assert_select 'input[name=?]', 'issue[due_date]', 0
1769 1769 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1770 1770 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1771 1771 end
1772 1772
1773 1773 def test_new_with_tracker_set_as_readonly_should_accept_status
1774 1774 WorkflowPermission.delete_all
1775 1775 [1, 2].each do |status_id|
1776 1776 WorkflowPermission.create!(:tracker_id => 1, :old_status_id => status_id, :role_id => 1, :field_name => 'tracker_id', :rule => 'readonly')
1777 1777 end
1778 1778 @request.session[:user_id] = 2
1779 1779
1780 1780 get :new, :project_id => 1, :issue => {:status_id => 2}
1781 1781 assert_select 'select[name=?]', 'issue[tracker_id]', 0
1782 1782 assert_equal 2, assigns(:issue).status_id
1783 1783 end
1784 1784
1785 1785 def test_get_new_without_tracker_id
1786 1786 @request.session[:user_id] = 2
1787 1787 get :new, :project_id => 1
1788 1788 assert_response :success
1789 1789 assert_template 'new'
1790 1790
1791 1791 issue = assigns(:issue)
1792 1792 assert_not_nil issue
1793 1793 assert_equal Project.find(1).trackers.first, issue.tracker
1794 1794 end
1795 1795
1796 1796 def test_get_new_with_no_default_status_should_display_an_error
1797 1797 @request.session[:user_id] = 2
1798 1798 IssueStatus.delete_all
1799 1799
1800 1800 get :new, :project_id => 1
1801 1801 assert_response 500
1802 1802 assert_select_error /No default issue/
1803 1803 end
1804 1804
1805 1805 def test_get_new_with_no_tracker_should_display_an_error
1806 1806 @request.session[:user_id] = 2
1807 1807 Tracker.delete_all
1808 1808
1809 1809 get :new, :project_id => 1
1810 1810 assert_response 500
1811 1811 assert_select_error /No tracker/
1812 1812 end
1813 1813
1814 1814 def test_new_with_invalid_project_id
1815 1815 @request.session[:user_id] = 1
1816 1816 get :new, :project_id => 'invalid'
1817 1817 assert_response 404
1818 1818 end
1819 1819
1820 1820 def test_update_form_for_new_issue
1821 1821 @request.session[:user_id] = 2
1822 1822 xhr :post, :new, :project_id => 1,
1823 1823 :issue => {:tracker_id => 2,
1824 1824 :subject => 'This is the test_new issue',
1825 1825 :description => 'This is the description',
1826 1826 :priority_id => 5}
1827 1827 assert_response :success
1828 1828 assert_template 'new'
1829 1829 assert_template :partial => '_form'
1830 1830 assert_equal 'text/javascript', response.content_type
1831 1831
1832 1832 issue = assigns(:issue)
1833 1833 assert_kind_of Issue, issue
1834 1834 assert_equal 1, issue.project_id
1835 1835 assert_equal 2, issue.tracker_id
1836 1836 assert_equal 'This is the test_new issue', issue.subject
1837 1837 end
1838 1838
1839 1839 def test_update_form_for_new_issue_should_propose_transitions_based_on_initial_status
1840 1840 @request.session[:user_id] = 2
1841 1841 WorkflowTransition.delete_all
1842 1842 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1843 1843 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1844 1844 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1845 1845
1846 1846 xhr :post, :new, :project_id => 1,
1847 1847 :issue => {:tracker_id => 1,
1848 1848 :status_id => 5,
1849 1849 :subject => 'This is an issue'}
1850 1850
1851 1851 assert_equal 5, assigns(:issue).status_id
1852 1852 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1853 1853 end
1854 1854
1855 1855 def test_update_form_with_default_status_should_ignore_submitted_status_id_if_equals
1856 1856 @request.session[:user_id] = 2
1857 1857 tracker = Tracker.find(2)
1858 1858 tracker.update! :default_status_id => 2
1859 1859 tracker.generate_transitions! 2, 1, :clear => true
1860 1860
1861 1861 xhr :post, :new, :project_id => 1,
1862 1862 :issue => {:tracker_id => 2,
1863 1863 :status_id => 1},
1864 1864 :was_default_status => 1
1865 1865
1866 1866 assert_equal 2, assigns(:issue).status_id
1867 1867 end
1868 1868
1869 1869 def test_post_create
1870 1870 @request.session[:user_id] = 2
1871 1871 assert_difference 'Issue.count' do
1872 1872 assert_no_difference 'Journal.count' do
1873 1873 post :create, :project_id => 1,
1874 1874 :issue => {:tracker_id => 3,
1875 1875 :status_id => 2,
1876 1876 :subject => 'This is the test_new issue',
1877 1877 :description => 'This is the description',
1878 1878 :priority_id => 5,
1879 1879 :start_date => '2010-11-07',
1880 1880 :estimated_hours => '',
1881 1881 :custom_field_values => {'2' => 'Value for field 2'}}
1882 1882 end
1883 1883 end
1884 1884 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1885 1885
1886 1886 issue = Issue.find_by_subject('This is the test_new issue')
1887 1887 assert_not_nil issue
1888 1888 assert_equal 2, issue.author_id
1889 1889 assert_equal 3, issue.tracker_id
1890 1890 assert_equal 2, issue.status_id
1891 1891 assert_equal Date.parse('2010-11-07'), issue.start_date
1892 1892 assert_nil issue.estimated_hours
1893 1893 v = issue.custom_values.where(:custom_field_id => 2).first
1894 1894 assert_not_nil v
1895 1895 assert_equal 'Value for field 2', v.value
1896 1896 end
1897 1897
1898 1898 def test_post_new_with_group_assignment
1899 1899 group = Group.find(11)
1900 1900 project = Project.find(1)
1901 1901 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1902 1902
1903 1903 with_settings :issue_group_assignment => '1' do
1904 1904 @request.session[:user_id] = 2
1905 1905 assert_difference 'Issue.count' do
1906 1906 post :create, :project_id => project.id,
1907 1907 :issue => {:tracker_id => 3,
1908 1908 :status_id => 1,
1909 1909 :subject => 'This is the test_new_with_group_assignment issue',
1910 1910 :assigned_to_id => group.id}
1911 1911 end
1912 1912 end
1913 1913 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1914 1914
1915 1915 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1916 1916 assert_not_nil issue
1917 1917 assert_equal group, issue.assigned_to
1918 1918 end
1919 1919
1920 1920 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1921 1921 with_settings :default_issue_start_date_to_creation_date => 0 do
1922 1922 @request.session[:user_id] = 2
1923 1923 assert_difference 'Issue.count' do
1924 1924 post :create, :project_id => 1,
1925 1925 :issue => {:tracker_id => 3,
1926 1926 :status_id => 2,
1927 1927 :subject => 'This is the test_new issue',
1928 1928 :description => 'This is the description',
1929 1929 :priority_id => 5,
1930 1930 :estimated_hours => '',
1931 1931 :custom_field_values => {'2' => 'Value for field 2'}}
1932 1932 end
1933 1933 assert_redirected_to :controller => 'issues', :action => 'show',
1934 1934 :id => Issue.last.id
1935 1935 issue = Issue.find_by_subject('This is the test_new issue')
1936 1936 assert_not_nil issue
1937 1937 assert_nil issue.start_date
1938 1938 end
1939 1939 end
1940 1940
1941 1941 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1942 1942 with_settings :default_issue_start_date_to_creation_date => 1 do
1943 1943 @request.session[:user_id] = 2
1944 1944 assert_difference 'Issue.count' do
1945 1945 post :create, :project_id => 1,
1946 1946 :issue => {:tracker_id => 3,
1947 1947 :status_id => 2,
1948 1948 :subject => 'This is the test_new issue',
1949 1949 :description => 'This is the description',
1950 1950 :priority_id => 5,
1951 1951 :estimated_hours => '',
1952 1952 :custom_field_values => {'2' => 'Value for field 2'}}
1953 1953 end
1954 1954 assert_redirected_to :controller => 'issues', :action => 'show',
1955 1955 :id => Issue.last.id
1956 1956 issue = Issue.find_by_subject('This is the test_new issue')
1957 1957 assert_not_nil issue
1958 1958 assert_equal Date.today, issue.start_date
1959 1959 end
1960 1960 end
1961 1961
1962 1962 def test_post_create_and_continue
1963 1963 @request.session[:user_id] = 2
1964 1964 assert_difference 'Issue.count' do
1965 1965 post :create, :project_id => 1,
1966 1966 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1967 1967 :continue => ''
1968 1968 end
1969 1969
1970 1970 issue = Issue.order('id DESC').first
1971 1971 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1972 1972 assert_not_nil flash[:notice], "flash was not set"
1973 1973 assert_select_in flash[:notice],
1974 1974 'a[href=?][title=?]', "/issues/#{issue.id}", "This is first issue", :text => "##{issue.id}"
1975 1975 end
1976 1976
1977 1977 def test_post_create_without_custom_fields_param
1978 1978 @request.session[:user_id] = 2
1979 1979 assert_difference 'Issue.count' do
1980 1980 post :create, :project_id => 1,
1981 1981 :issue => {:tracker_id => 1,
1982 1982 :subject => 'This is the test_new issue',
1983 1983 :description => 'This is the description',
1984 1984 :priority_id => 5}
1985 1985 end
1986 1986 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1987 1987 end
1988 1988
1989 1989 def test_post_create_with_multi_custom_field
1990 1990 field = IssueCustomField.find_by_name('Database')
1991 1991 field.update_attribute(:multiple, true)
1992 1992
1993 1993 @request.session[:user_id] = 2
1994 1994 assert_difference 'Issue.count' do
1995 1995 post :create, :project_id => 1,
1996 1996 :issue => {:tracker_id => 1,
1997 1997 :subject => 'This is the test_new issue',
1998 1998 :description => 'This is the description',
1999 1999 :priority_id => 5,
2000 2000 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
2001 2001 end
2002 2002 assert_response 302
2003 2003 issue = Issue.order('id DESC').first
2004 2004 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
2005 2005 end
2006 2006
2007 2007 def test_post_create_with_empty_multi_custom_field
2008 2008 field = IssueCustomField.find_by_name('Database')
2009 2009 field.update_attribute(:multiple, true)
2010 2010
2011 2011 @request.session[:user_id] = 2
2012 2012 assert_difference 'Issue.count' do
2013 2013 post :create, :project_id => 1,
2014 2014 :issue => {:tracker_id => 1,
2015 2015 :subject => 'This is the test_new issue',
2016 2016 :description => 'This is the description',
2017 2017 :priority_id => 5,
2018 2018 :custom_field_values => {'1' => ['']}}
2019 2019 end
2020 2020 assert_response 302
2021 2021 issue = Issue.order('id DESC').first
2022 2022 assert_equal [''], issue.custom_field_value(1).sort
2023 2023 end
2024 2024
2025 2025 def test_post_create_with_multi_user_custom_field
2026 2026 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
2027 2027 :tracker_ids => [1], :is_for_all => true)
2028 2028
2029 2029 @request.session[:user_id] = 2
2030 2030 assert_difference 'Issue.count' do
2031 2031 post :create, :project_id => 1,
2032 2032 :issue => {:tracker_id => 1,
2033 2033 :subject => 'This is the test_new issue',
2034 2034 :description => 'This is the description',
2035 2035 :priority_id => 5,
2036 2036 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
2037 2037 end
2038 2038 assert_response 302
2039 2039 issue = Issue.order('id DESC').first
2040 2040 assert_equal ['2', '3'], issue.custom_field_value(field).sort
2041 2041 end
2042 2042
2043 2043 def test_post_create_with_required_custom_field_and_without_custom_fields_param
2044 2044 field = IssueCustomField.find_by_name('Database')
2045 2045 field.update_attribute(:is_required, true)
2046 2046
2047 2047 @request.session[:user_id] = 2
2048 2048 assert_no_difference 'Issue.count' do
2049 2049 post :create, :project_id => 1,
2050 2050 :issue => {:tracker_id => 1,
2051 2051 :subject => 'This is the test_new issue',
2052 2052 :description => 'This is the description',
2053 2053 :priority_id => 5}
2054 2054 end
2055 2055 assert_response :success
2056 2056 assert_template 'new'
2057 2057 issue = assigns(:issue)
2058 2058 assert_not_nil issue
2059 2059 assert_select_error /Database cannot be blank/
2060 2060 end
2061 2061
2062 2062 def test_create_should_validate_required_fields
2063 2063 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
2064 2064 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
2065 2065 WorkflowPermission.delete_all
2066 2066 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
2067 2067 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
2068 2068 @request.session[:user_id] = 2
2069 2069
2070 2070 assert_no_difference 'Issue.count' do
2071 2071 post :create, :project_id => 1, :issue => {
2072 2072 :tracker_id => 2,
2073 2073 :status_id => 1,
2074 2074 :subject => 'Test',
2075 2075 :start_date => '',
2076 2076 :due_date => '',
2077 2077 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
2078 2078 }
2079 2079 assert_response :success
2080 2080 assert_template 'new'
2081 2081 end
2082 2082
2083 2083 assert_select_error /Due date cannot be blank/i
2084 2084 assert_select_error /Bar cannot be blank/i
2085 2085 end
2086 2086
2087 2087 def test_create_should_validate_required_list_fields
2088 2088 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'list', :is_for_all => true, :tracker_ids => [1, 2], :multiple => false, :possible_values => ['a', 'b'])
2089 2089 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'list', :is_for_all => true, :tracker_ids => [1, 2], :multiple => true, :possible_values => ['a', 'b'])
2090 2090 WorkflowPermission.delete_all
2091 2091 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf1.id.to_s, :rule => 'required')
2092 2092 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
2093 2093 @request.session[:user_id] = 2
2094 2094
2095 2095 assert_no_difference 'Issue.count' do
2096 2096 post :create, :project_id => 1, :issue => {
2097 2097 :tracker_id => 2,
2098 2098 :status_id => 1,
2099 2099 :subject => 'Test',
2100 2100 :start_date => '',
2101 2101 :due_date => '',
2102 2102 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ['']}
2103 2103 }
2104 2104 assert_response :success
2105 2105 assert_template 'new'
2106 2106 end
2107 2107
2108 2108 assert_select_error /Foo cannot be blank/i
2109 2109 assert_select_error /Bar cannot be blank/i
2110 2110 end
2111 2111
2112 2112 def test_create_should_ignore_readonly_fields
2113 2113 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
2114 2114 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
2115 2115 WorkflowPermission.delete_all
2116 2116 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
2117 2117 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
2118 2118 @request.session[:user_id] = 2
2119 2119
2120 2120 assert_difference 'Issue.count' do
2121 2121 post :create, :project_id => 1, :issue => {
2122 2122 :tracker_id => 2,
2123 2123 :status_id => 1,
2124 2124 :subject => 'Test',
2125 2125 :start_date => '2012-07-14',
2126 2126 :due_date => '2012-07-16',
2127 2127 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
2128 2128 }
2129 2129 assert_response 302
2130 2130 end
2131 2131
2132 2132 issue = Issue.order('id DESC').first
2133 2133 assert_equal Date.parse('2012-07-14'), issue.start_date
2134 2134 assert_nil issue.due_date
2135 2135 assert_equal 'value1', issue.custom_field_value(cf1)
2136 2136 assert_nil issue.custom_field_value(cf2)
2137 2137 end
2138 2138
2139 2139 def test_post_create_with_watchers
2140 2140 @request.session[:user_id] = 2
2141 2141 ActionMailer::Base.deliveries.clear
2142 2142
2143 2143 with_settings :notified_events => %w(issue_added) do
2144 2144 assert_difference 'Watcher.count', 2 do
2145 2145 post :create, :project_id => 1,
2146 2146 :issue => {:tracker_id => 1,
2147 2147 :subject => 'This is a new issue with watchers',
2148 2148 :description => 'This is the description',
2149 2149 :priority_id => 5,
2150 2150 :watcher_user_ids => ['2', '3']}
2151 2151 end
2152 2152 end
2153 2153 issue = Issue.find_by_subject('This is a new issue with watchers')
2154 2154 assert_not_nil issue
2155 2155 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
2156 2156
2157 2157 # Watchers added
2158 2158 assert_equal [2, 3], issue.watcher_user_ids.sort
2159 2159 assert issue.watched_by?(User.find(3))
2160 2160 # Watchers notified
2161 2161 mail = ActionMailer::Base.deliveries.last
2162 2162 assert_not_nil mail
2163 2163 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
2164 2164 end
2165 2165
2166 2166 def test_post_create_subissue
2167 2167 @request.session[:user_id] = 2
2168 2168
2169 2169 assert_difference 'Issue.count' do
2170 2170 post :create, :project_id => 1,
2171 2171 :issue => {:tracker_id => 1,
2172 2172 :subject => 'This is a child issue',
2173 2173 :parent_issue_id => '2'}
2174 2174 assert_response 302
2175 2175 end
2176 2176 issue = Issue.order('id DESC').first
2177 2177 assert_equal Issue.find(2), issue.parent
2178 2178 end
2179 2179
2180 2180 def test_post_create_subissue_with_sharp_parent_id
2181 2181 @request.session[:user_id] = 2
2182 2182
2183 2183 assert_difference 'Issue.count' do
2184 2184 post :create, :project_id => 1,
2185 2185 :issue => {:tracker_id => 1,
2186 2186 :subject => 'This is a child issue',
2187 2187 :parent_issue_id => '#2'}
2188 2188 assert_response 302
2189 2189 end
2190 2190 issue = Issue.order('id DESC').first
2191 2191 assert_equal Issue.find(2), issue.parent
2192 2192 end
2193 2193
2194 2194 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2195 2195 @request.session[:user_id] = 2
2196 2196
2197 2197 assert_no_difference 'Issue.count' do
2198 2198 post :create, :project_id => 1,
2199 2199 :issue => {:tracker_id => 1,
2200 2200 :subject => 'This is a child issue',
2201 2201 :parent_issue_id => '4'}
2202 2202
2203 2203 assert_response :success
2204 2204 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2205 2205 assert_select_error /Parent task is invalid/i
2206 2206 end
2207 2207 end
2208 2208
2209 2209 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2210 2210 @request.session[:user_id] = 2
2211 2211
2212 2212 assert_no_difference 'Issue.count' do
2213 2213 post :create, :project_id => 1,
2214 2214 :issue => {:tracker_id => 1,
2215 2215 :subject => 'This is a child issue',
2216 2216 :parent_issue_id => '01ABC'}
2217 2217
2218 2218 assert_response :success
2219 2219 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2220 2220 assert_select_error /Parent task is invalid/i
2221 2221 end
2222 2222 end
2223 2223
2224 2224 def test_post_create_private
2225 2225 @request.session[:user_id] = 2
2226 2226
2227 2227 assert_difference 'Issue.count' do
2228 2228 post :create, :project_id => 1,
2229 2229 :issue => {:tracker_id => 1,
2230 2230 :subject => 'This is a private issue',
2231 2231 :is_private => '1'}
2232 2232 end
2233 2233 issue = Issue.order('id DESC').first
2234 2234 assert issue.is_private?
2235 2235 end
2236 2236
2237 2237 def test_post_create_private_with_set_own_issues_private_permission
2238 2238 role = Role.find(1)
2239 2239 role.remove_permission! :set_issues_private
2240 2240 role.add_permission! :set_own_issues_private
2241 2241
2242 2242 @request.session[:user_id] = 2
2243 2243
2244 2244 assert_difference 'Issue.count' do
2245 2245 post :create, :project_id => 1,
2246 2246 :issue => {:tracker_id => 1,
2247 2247 :subject => 'This is a private issue',
2248 2248 :is_private => '1'}
2249 2249 end
2250 2250 issue = Issue.order('id DESC').first
2251 2251 assert issue.is_private?
2252 2252 end
2253 2253
2254 2254 def test_create_without_project_id
2255 2255 @request.session[:user_id] = 2
2256 2256
2257 2257 assert_difference 'Issue.count' do
2258 2258 post :create,
2259 2259 :issue => {:project_id => 3,
2260 2260 :tracker_id => 2,
2261 2261 :subject => 'Foo'}
2262 2262 assert_response 302
2263 2263 end
2264 2264 issue = Issue.order('id DESC').first
2265 2265 assert_equal 3, issue.project_id
2266 2266 assert_equal 2, issue.tracker_id
2267 2267 end
2268 2268
2269 2269 def test_create_without_project_id_and_continue_should_redirect_without_project_id
2270 2270 @request.session[:user_id] = 2
2271 2271
2272 2272 assert_difference 'Issue.count' do
2273 2273 post :create,
2274 2274 :issue => {:project_id => 3,
2275 2275 :tracker_id => 2,
2276 2276 :subject => 'Foo'},
2277 2277 :continue => '1'
2278 2278 assert_redirected_to '/issues/new?issue%5Bproject_id%5D=3&issue%5Btracker_id%5D=2'
2279 2279 end
2280 2280 end
2281 2281
2282 2282 def test_create_without_project_id_should_be_denied_without_permission
2283 2283 Role.non_member.remove_permission! :add_issues
2284 2284 Role.anonymous.remove_permission! :add_issues
2285 2285 @request.session[:user_id] = 2
2286 2286
2287 2287 assert_no_difference 'Issue.count' do
2288 2288 post :create,
2289 2289 :issue => {:project_id => 3,
2290 2290 :tracker_id => 2,
2291 2291 :subject => 'Foo'}
2292 2292 assert_response 422
2293 2293 end
2294 2294 end
2295 2295
2296 2296 def test_create_without_project_id_with_failure
2297 2297 @request.session[:user_id] = 2
2298 2298
2299 2299 post :create,
2300 2300 :issue => {:project_id => 3,
2301 2301 :tracker_id => 2,
2302 2302 :subject => ''}
2303 2303 assert_response :success
2304 2304 assert_nil assigns(:project)
2305 2305 end
2306 2306
2307 2307 def test_post_create_should_send_a_notification
2308 2308 ActionMailer::Base.deliveries.clear
2309 2309 @request.session[:user_id] = 2
2310 2310 with_settings :notified_events => %w(issue_added) do
2311 2311 assert_difference 'Issue.count' do
2312 2312 post :create, :project_id => 1,
2313 2313 :issue => {:tracker_id => 3,
2314 2314 :subject => 'This is the test_new issue',
2315 2315 :description => 'This is the description',
2316 2316 :priority_id => 5,
2317 2317 :estimated_hours => '',
2318 2318 :custom_field_values => {'2' => 'Value for field 2'}}
2319 2319 end
2320 2320 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2321 2321
2322 2322 assert_equal 1, ActionMailer::Base.deliveries.size
2323 2323 end
2324 2324 end
2325 2325
2326 2326 def test_post_create_should_preserve_fields_values_on_validation_failure
2327 2327 @request.session[:user_id] = 2
2328 2328 post :create, :project_id => 1,
2329 2329 :issue => {:tracker_id => 1,
2330 2330 # empty subject
2331 2331 :subject => '',
2332 2332 :description => 'This is a description',
2333 2333 :priority_id => 6,
2334 2334 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2335 2335 assert_response :success
2336 2336 assert_template 'new'
2337 2337
2338 2338 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2339 2339 assert_select 'select[name=?]', 'issue[priority_id]' do
2340 2340 assert_select 'option[value="6"][selected=selected]', :text => 'High'
2341 2341 end
2342 2342 # Custom fields
2343 2343 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2344 2344 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2345 2345 end
2346 2346 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2347 2347 end
2348 2348
2349 2349 def test_post_create_with_failure_should_preserve_watchers
2350 2350 assert !User.find(8).member_of?(Project.find(1))
2351 2351
2352 2352 @request.session[:user_id] = 2
2353 2353 post :create, :project_id => 1,
2354 2354 :issue => {:tracker_id => 1,
2355 2355 :watcher_user_ids => ['3', '8']}
2356 2356 assert_response :success
2357 2357 assert_template 'new'
2358 2358
2359 2359 assert_select 'input[name=?][value="2"]:not(checked)', 'issue[watcher_user_ids][]'
2360 2360 assert_select 'input[name=?][value="3"][checked=checked]', 'issue[watcher_user_ids][]'
2361 2361 assert_select 'input[name=?][value="8"][checked=checked]', 'issue[watcher_user_ids][]'
2362 2362 end
2363 2363
2364 2364 def test_post_create_should_ignore_non_safe_attributes
2365 2365 @request.session[:user_id] = 2
2366 2366 assert_nothing_raised do
2367 2367 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2368 2368 end
2369 2369 end
2370 2370
2371 2371 def test_post_create_with_attachment
2372 2372 set_tmp_attachments_directory
2373 2373 @request.session[:user_id] = 2
2374 2374
2375 2375 assert_difference 'Issue.count' do
2376 2376 assert_difference 'Attachment.count' do
2377 2377 assert_no_difference 'Journal.count' do
2378 2378 post :create, :project_id => 1,
2379 2379 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2380 2380 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2381 2381 end
2382 2382 end
2383 2383 end
2384 2384
2385 2385 issue = Issue.order('id DESC').first
2386 2386 attachment = Attachment.order('id DESC').first
2387 2387
2388 2388 assert_equal issue, attachment.container
2389 2389 assert_equal 2, attachment.author_id
2390 2390 assert_equal 'testfile.txt', attachment.filename
2391 2391 assert_equal 'text/plain', attachment.content_type
2392 2392 assert_equal 'test file', attachment.description
2393 2393 assert_equal 59, attachment.filesize
2394 2394 assert File.exists?(attachment.diskfile)
2395 2395 assert_equal 59, File.size(attachment.diskfile)
2396 2396 end
2397 2397
2398 2398 def test_post_create_with_attachment_should_notify_with_attachments
2399 2399 ActionMailer::Base.deliveries.clear
2400 2400 set_tmp_attachments_directory
2401 2401 @request.session[:user_id] = 2
2402 2402
2403 2403 with_settings :host_name => 'mydomain.foo', :protocol => 'http', :notified_events => %w(issue_added) do
2404 2404 assert_difference 'Issue.count' do
2405 2405 post :create, :project_id => 1,
2406 2406 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2407 2407 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2408 2408 end
2409 2409 end
2410 2410
2411 2411 assert_not_nil ActionMailer::Base.deliveries.last
2412 2412 assert_select_email do
2413 2413 assert_select 'a[href^=?]', 'http://mydomain.foo/attachments/download', 'testfile.txt'
2414 2414 end
2415 2415 end
2416 2416
2417 2417 def test_post_create_with_failure_should_save_attachments
2418 2418 set_tmp_attachments_directory
2419 2419 @request.session[:user_id] = 2
2420 2420
2421 2421 assert_no_difference 'Issue.count' do
2422 2422 assert_difference 'Attachment.count' do
2423 2423 post :create, :project_id => 1,
2424 2424 :issue => { :tracker_id => '1', :subject => '' },
2425 2425 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2426 2426 assert_response :success
2427 2427 assert_template 'new'
2428 2428 end
2429 2429 end
2430 2430
2431 2431 attachment = Attachment.order('id DESC').first
2432 2432 assert_equal 'testfile.txt', attachment.filename
2433 2433 assert File.exists?(attachment.diskfile)
2434 2434 assert_nil attachment.container
2435 2435
2436 2436 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2437 2437 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2438 2438 end
2439 2439
2440 2440 def test_post_create_with_failure_should_keep_saved_attachments
2441 2441 set_tmp_attachments_directory
2442 2442 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2443 2443 @request.session[:user_id] = 2
2444 2444
2445 2445 assert_no_difference 'Issue.count' do
2446 2446 assert_no_difference 'Attachment.count' do
2447 2447 post :create, :project_id => 1,
2448 2448 :issue => { :tracker_id => '1', :subject => '' },
2449 2449 :attachments => {'p0' => {'token' => attachment.token}}
2450 2450 assert_response :success
2451 2451 assert_template 'new'
2452 2452 end
2453 2453 end
2454 2454
2455 2455 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2456 2456 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2457 2457 end
2458 2458
2459 2459 def test_post_create_should_attach_saved_attachments
2460 2460 set_tmp_attachments_directory
2461 2461 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2462 2462 @request.session[:user_id] = 2
2463 2463
2464 2464 assert_difference 'Issue.count' do
2465 2465 assert_no_difference 'Attachment.count' do
2466 2466 post :create, :project_id => 1,
2467 2467 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2468 2468 :attachments => {'p0' => {'token' => attachment.token}}
2469 2469 assert_response 302
2470 2470 end
2471 2471 end
2472 2472
2473 2473 issue = Issue.order('id DESC').first
2474 2474 assert_equal 1, issue.attachments.count
2475 2475
2476 2476 attachment.reload
2477 2477 assert_equal issue, attachment.container
2478 2478 end
2479 2479
2480 2480 def setup_without_workflow_privilege
2481 2481 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2482 2482 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2483 2483 end
2484 2484 private :setup_without_workflow_privilege
2485 2485
2486 2486 test "without workflow privilege #new should propose default status only" do
2487 2487 setup_without_workflow_privilege
2488 2488 get :new, :project_id => 1
2489 2489 assert_response :success
2490 2490 assert_template 'new'
2491 2491
2492 2492 issue = assigns(:issue)
2493 2493 assert_not_nil issue.default_status
2494 2494
2495 2495 assert_select 'select[name=?]', 'issue[status_id]' do
2496 2496 assert_select 'option', 1
2497 2497 assert_select 'option[value=?]', issue.default_status.id.to_s
2498 2498 end
2499 2499 end
2500 2500
2501 2501 test "without workflow privilege #create should accept default status" do
2502 2502 setup_without_workflow_privilege
2503 2503 assert_difference 'Issue.count' do
2504 2504 post :create, :project_id => 1,
2505 2505 :issue => {:tracker_id => 1,
2506 2506 :subject => 'This is an issue',
2507 2507 :status_id => 1}
2508 2508 end
2509 2509 issue = Issue.order('id').last
2510 2510 assert_not_nil issue.default_status
2511 2511 assert_equal issue.default_status, issue.status
2512 2512 end
2513 2513
2514 2514 test "without workflow privilege #create should ignore unauthorized status" do
2515 2515 setup_without_workflow_privilege
2516 2516 assert_difference 'Issue.count' do
2517 2517 post :create, :project_id => 1,
2518 2518 :issue => {:tracker_id => 1,
2519 2519 :subject => 'This is an issue',
2520 2520 :status_id => 3}
2521 2521 end
2522 2522 issue = Issue.order('id').last
2523 2523 assert_not_nil issue.default_status
2524 2524 assert_equal issue.default_status, issue.status
2525 2525 end
2526 2526
2527 2527 test "without workflow privilege #update should ignore status change" do
2528 2528 setup_without_workflow_privilege
2529 2529 assert_difference 'Journal.count' do
2530 2530 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2531 2531 end
2532 2532 assert_equal 1, Issue.find(1).status_id
2533 2533 end
2534 2534
2535 2535 test "without workflow privilege #update ignore attributes changes" do
2536 2536 setup_without_workflow_privilege
2537 2537 assert_difference 'Journal.count' do
2538 2538 put :update, :id => 1,
2539 2539 :issue => {:subject => 'changed', :assigned_to_id => 2,
2540 2540 :notes => 'just trying'}
2541 2541 end
2542 2542 issue = Issue.find(1)
2543 2543 assert_equal "Cannot print recipes", issue.subject
2544 2544 assert_nil issue.assigned_to
2545 2545 end
2546 2546
2547 2547 def setup_with_workflow_privilege
2548 2548 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2549 2549 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1,
2550 2550 :old_status_id => 1, :new_status_id => 3)
2551 2551 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1,
2552 2552 :old_status_id => 1, :new_status_id => 4)
2553 2553 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2554 2554 end
2555 2555 private :setup_with_workflow_privilege
2556 2556
2557 2557 def setup_with_workflow_privilege_and_edit_issues_permission
2558 2558 setup_with_workflow_privilege
2559 2559 Role.anonymous.add_permission! :add_issues, :edit_issues
2560 2560 end
2561 2561 private :setup_with_workflow_privilege_and_edit_issues_permission
2562 2562
2563 2563 test "with workflow privilege and :edit_issues permission should accept authorized status" do
2564 2564 setup_with_workflow_privilege_and_edit_issues_permission
2565 2565 assert_difference 'Journal.count' do
2566 2566 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2567 2567 end
2568 2568 assert_equal 3, Issue.find(1).status_id
2569 2569 end
2570 2570
2571 2571 test "with workflow privilege and :edit_issues permission should ignore unauthorized status" do
2572 2572 setup_with_workflow_privilege_and_edit_issues_permission
2573 2573 assert_difference 'Journal.count' do
2574 2574 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2575 2575 end
2576 2576 assert_equal 1, Issue.find(1).status_id
2577 2577 end
2578 2578
2579 2579 test "with workflow privilege and :edit_issues permission should accept authorized attributes changes" do
2580 2580 setup_with_workflow_privilege_and_edit_issues_permission
2581 2581 assert_difference 'Journal.count' do
2582 2582 put :update, :id => 1,
2583 2583 :issue => {:subject => 'changed', :assigned_to_id => 2,
2584 2584 :notes => 'just trying'}
2585 2585 end
2586 2586 issue = Issue.find(1)
2587 2587 assert_equal "changed", issue.subject
2588 2588 assert_equal 2, issue.assigned_to_id
2589 2589 end
2590 2590
2591 2591 def test_new_as_copy
2592 2592 @request.session[:user_id] = 2
2593 2593 get :new, :project_id => 1, :copy_from => 1
2594 2594
2595 2595 assert_response :success
2596 2596 assert_template 'new'
2597 2597
2598 2598 assert_not_nil assigns(:issue)
2599 2599 orig = Issue.find(1)
2600 2600 assert_equal 1, assigns(:issue).project_id
2601 2601 assert_equal orig.subject, assigns(:issue).subject
2602 2602 assert assigns(:issue).copy?
2603 2603
2604 2604 assert_select 'form[id=issue-form][action="/projects/ecookbook/issues"]' do
2605 2605 assert_select 'select[name=?]', 'issue[project_id]' do
2606 2606 assert_select 'option[value="1"][selected=selected]', :text => 'eCookbook'
2607 2607 assert_select 'option[value="2"]:not([selected])', :text => 'OnlineStore'
2608 2608 end
2609 2609 assert_select 'input[name=copy_from][value="1"]'
2610 2610 end
2611 2611
2612 2612 # "New issue" menu item should not link to copy
2613 2613 assert_select '#main-menu a.new-issue[href="/projects/ecookbook/issues/new"]'
2614 2614 end
2615 2615
2616 2616 def test_new_as_copy_without_add_issues_permission_should_not_propose_current_project_as_target
2617 2617 user = setup_user_with_copy_but_not_add_permission
2618 2618
2619 2619 @request.session[:user_id] = user.id
2620 2620 get :new, :project_id => 1, :copy_from => 1
2621 2621
2622 2622 assert_response :success
2623 2623 assert_template 'new'
2624 2624 assert_select 'select[name=?]', 'issue[project_id]' do
2625 2625 assert_select 'option[value="1"]', 0
2626 2626 assert_select 'option[value="2"]', :text => 'OnlineStore'
2627 2627 end
2628 2628 end
2629 2629
2630 2630 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2631 2631 @request.session[:user_id] = 2
2632 2632 issue = Issue.find(3)
2633 2633 assert issue.attachments.count > 0
2634 2634 get :new, :project_id => 1, :copy_from => 3
2635 2635
2636 2636 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value="1"]'
2637 2637 end
2638 2638
2639 2639 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2640 2640 @request.session[:user_id] = 2
2641 2641 issue = Issue.find(3)
2642 2642 issue.attachments.delete_all
2643 2643 get :new, :project_id => 1, :copy_from => 3
2644 2644
2645 2645 assert_select 'input[name=copy_attachments]', 0
2646 2646 end
2647 2647
2648 2648 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2649 2649 @request.session[:user_id] = 2
2650 2650 issue = Issue.generate_with_descendants!
2651 2651 get :new, :project_id => 1, :copy_from => issue.id
2652 2652
2653 2653 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value="1"]'
2654 2654 end
2655 2655
2656 2656 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2657 2657 @request.session[:user_id] = 2
2658 2658 get :new, :project_id => 1, :copy_from => 99999
2659 2659 assert_response 404
2660 2660 end
2661 2661
2662 2662 def test_create_as_copy_on_different_project
2663 2663 @request.session[:user_id] = 2
2664 2664 assert_difference 'Issue.count' do
2665 2665 post :create, :project_id => 1, :copy_from => 1,
2666 2666 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2667 2667
2668 2668 assert_not_nil assigns(:issue)
2669 2669 assert assigns(:issue).copy?
2670 2670 end
2671 2671 issue = Issue.order('id DESC').first
2672 2672 assert_redirected_to "/issues/#{issue.id}"
2673 2673
2674 2674 assert_equal 2, issue.project_id
2675 2675 assert_equal 3, issue.tracker_id
2676 2676 assert_equal 'Copy', issue.subject
2677 2677 end
2678 2678
2679 2679 def test_create_as_copy_should_allow_status_to_be_set_to_default
2680 2680 copied = Issue.generate! :status_id => 2
2681 2681 assert_equal 2, copied.reload.status_id
2682 2682
2683 2683 @request.session[:user_id] = 2
2684 2684 assert_difference 'Issue.count' do
2685 2685 post :create, :project_id => 1, :copy_from => copied.id,
2686 2686 :issue => {:project_id => '1', :tracker_id => '1', :status_id => '1'},
2687 2687 :was_default_status => '1'
2688 2688 end
2689 2689 issue = Issue.order('id DESC').first
2690 2690 assert_equal 1, issue.status_id
2691 2691 end
2692 2692
2693 2693 def test_create_as_copy_should_copy_attachments
2694 2694 @request.session[:user_id] = 2
2695 2695 issue = Issue.find(3)
2696 2696 count = issue.attachments.count
2697 2697 assert count > 0
2698 2698 assert_difference 'Issue.count' do
2699 2699 assert_difference 'Attachment.count', count do
2700 2700 post :create, :project_id => 1, :copy_from => 3,
2701 2701 :issue => {:project_id => '1', :tracker_id => '3',
2702 2702 :status_id => '1', :subject => 'Copy with attachments'},
2703 2703 :copy_attachments => '1'
2704 2704 end
2705 2705 end
2706 2706 copy = Issue.order('id DESC').first
2707 2707 assert_equal count, copy.attachments.count
2708 2708 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2709 2709 end
2710 2710
2711 2711 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2712 2712 @request.session[:user_id] = 2
2713 2713 issue = Issue.find(3)
2714 2714 count = issue.attachments.count
2715 2715 assert count > 0
2716 2716 assert_difference 'Issue.count' do
2717 2717 assert_no_difference 'Attachment.count' do
2718 2718 post :create, :project_id => 1, :copy_from => 3,
2719 2719 :issue => {:project_id => '1', :tracker_id => '3',
2720 2720 :status_id => '1', :subject => 'Copy with attachments'}
2721 2721 end
2722 2722 end
2723 2723 copy = Issue.order('id DESC').first
2724 2724 assert_equal 0, copy.attachments.count
2725 2725 end
2726 2726
2727 2727 def test_create_as_copy_with_attachments_should_also_add_new_files
2728 2728 @request.session[:user_id] = 2
2729 2729 issue = Issue.find(3)
2730 2730 count = issue.attachments.count
2731 2731 assert count > 0
2732 2732 assert_difference 'Issue.count' do
2733 2733 assert_difference 'Attachment.count', count + 1 do
2734 2734 post :create, :project_id => 1, :copy_from => 3,
2735 2735 :issue => {:project_id => '1', :tracker_id => '3',
2736 2736 :status_id => '1', :subject => 'Copy with attachments'},
2737 2737 :copy_attachments => '1',
2738 2738 :attachments => {'1' =>
2739 2739 {'file' => uploaded_test_file('testfile.txt', 'text/plain'),
2740 2740 'description' => 'test file'}}
2741 2741 end
2742 2742 end
2743 2743 copy = Issue.order('id DESC').first
2744 2744 assert_equal count + 1, copy.attachments.count
2745 2745 end
2746 2746
2747 2747 def test_create_as_copy_should_add_relation_with_copied_issue
2748 2748 @request.session[:user_id] = 2
2749 2749 assert_difference 'Issue.count' do
2750 2750 assert_difference 'IssueRelation.count' do
2751 2751 post :create, :project_id => 1, :copy_from => 1, :link_copy => '1',
2752 2752 :issue => {:project_id => '1', :tracker_id => '3',
2753 2753 :status_id => '1', :subject => 'Copy'}
2754 2754 end
2755 2755 end
2756 2756 copy = Issue.order('id DESC').first
2757 2757 assert_equal 1, copy.relations.size
2758 2758 end
2759 2759
2760 2760 def test_create_as_copy_should_allow_not_to_add_relation_with_copied_issue
2761 2761 @request.session[:user_id] = 2
2762 2762 assert_difference 'Issue.count' do
2763 2763 assert_no_difference 'IssueRelation.count' do
2764 2764 post :create, :project_id => 1, :copy_from => 1,
2765 2765 :issue => {:subject => 'Copy'}
2766 2766 end
2767 2767 end
2768 2768 end
2769 2769
2770 2770 def test_create_as_copy_should_always_add_relation_with_copied_issue_by_setting
2771 2771 with_settings :link_copied_issue => 'yes' do
2772 2772 @request.session[:user_id] = 2
2773 2773 assert_difference 'Issue.count' do
2774 2774 assert_difference 'IssueRelation.count' do
2775 2775 post :create, :project_id => 1, :copy_from => 1,
2776 2776 :issue => {:subject => 'Copy'}
2777 2777 end
2778 2778 end
2779 2779 end
2780 2780 end
2781 2781
2782 2782 def test_create_as_copy_should_never_add_relation_with_copied_issue_by_setting
2783 2783 with_settings :link_copied_issue => 'no' do
2784 2784 @request.session[:user_id] = 2
2785 2785 assert_difference 'Issue.count' do
2786 2786 assert_no_difference 'IssueRelation.count' do
2787 2787 post :create, :project_id => 1, :copy_from => 1, :link_copy => '1',
2788 2788 :issue => {:subject => 'Copy'}
2789 2789 end
2790 2790 end
2791 2791 end
2792 2792 end
2793 2793
2794 2794 def test_create_as_copy_should_copy_subtasks
2795 2795 @request.session[:user_id] = 2
2796 2796 issue = Issue.generate_with_descendants!
2797 2797 count = issue.descendants.count
2798 2798 assert_difference 'Issue.count', count + 1 do
2799 2799 post :create, :project_id => 1, :copy_from => issue.id,
2800 2800 :issue => {:project_id => '1', :tracker_id => '3',
2801 2801 :status_id => '1', :subject => 'Copy with subtasks'},
2802 2802 :copy_subtasks => '1'
2803 2803 end
2804 2804 copy = Issue.where(:parent_id => nil).order('id DESC').first
2805 2805 assert_equal count, copy.descendants.count
2806 2806 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2807 2807 end
2808 2808
2809 2809 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2810 2810 @request.session[:user_id] = 2
2811 2811 issue = Issue.generate_with_descendants!
2812 2812 assert_difference 'Issue.count', 1 do
2813 2813 post :create, :project_id => 1, :copy_from => 3,
2814 2814 :issue => {:project_id => '1', :tracker_id => '3',
2815 2815 :status_id => '1', :subject => 'Copy with subtasks'}
2816 2816 end
2817 2817 copy = Issue.where(:parent_id => nil).order('id DESC').first
2818 2818 assert_equal 0, copy.descendants.count
2819 2819 end
2820 2820
2821 2821 def test_create_as_copy_with_failure
2822 2822 @request.session[:user_id] = 2
2823 2823 post :create, :project_id => 1, :copy_from => 1,
2824 2824 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2825 2825
2826 2826 assert_response :success
2827 2827 assert_template 'new'
2828 2828
2829 2829 assert_not_nil assigns(:issue)
2830 2830 assert assigns(:issue).copy?
2831 2831
2832 2832 assert_select 'form#issue-form[action="/projects/ecookbook/issues"]' do
2833 2833 assert_select 'select[name=?]', 'issue[project_id]' do
2834 2834 assert_select 'option[value="1"]:not([selected])', :text => 'eCookbook'
2835 2835 assert_select 'option[value="2"][selected=selected]', :text => 'OnlineStore'
2836 2836 end
2837 2837 assert_select 'input[name=copy_from][value="1"]'
2838 2838 end
2839 2839 end
2840 2840
2841 2841 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2842 2842 @request.session[:user_id] = 2
2843 2843 assert !User.find(2).member_of?(Project.find(4))
2844 2844
2845 2845 assert_difference 'Issue.count' do
2846 2846 post :create, :project_id => 1, :copy_from => 1,
2847 2847 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2848 2848 end
2849 2849 issue = Issue.order('id DESC').first
2850 2850 assert_equal 1, issue.project_id
2851 2851 end
2852 2852
2853 2853 def test_get_edit
2854 2854 @request.session[:user_id] = 2
2855 2855 get :edit, :id => 1
2856 2856 assert_response :success
2857 2857 assert_template 'edit'
2858 2858 assert_not_nil assigns(:issue)
2859 2859 assert_equal Issue.find(1), assigns(:issue)
2860 2860
2861 2861 # Be sure we don't display inactive IssuePriorities
2862 2862 assert ! IssuePriority.find(15).active?
2863 2863 assert_select 'select[name=?]', 'issue[priority_id]' do
2864 2864 assert_select 'option[value="15"]', 0
2865 2865 end
2866 2866 end
2867 2867
2868 2868 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2869 2869 @request.session[:user_id] = 2
2870 2870 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2871 2871
2872 2872 get :edit, :id => 1
2873 2873 assert_select 'input[name=?]', 'time_entry[hours]'
2874 2874 end
2875 2875
2876 2876 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2877 2877 @request.session[:user_id] = 2
2878 2878 Role.find_by_name('Manager').remove_permission! :log_time
2879 2879
2880 2880 get :edit, :id => 1
2881 2881 assert_select 'input[name=?]', 'time_entry[hours]', 0
2882 2882 end
2883 2883
2884 2884 def test_get_edit_with_params
2885 2885 @request.session[:user_id] = 2
2886 2886 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2887 2887 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2888 2888 assert_response :success
2889 2889 assert_template 'edit'
2890 2890
2891 2891 issue = assigns(:issue)
2892 2892 assert_not_nil issue
2893 2893
2894 2894 assert_equal 5, issue.status_id
2895 2895 assert_select 'select[name=?]', 'issue[status_id]' do
2896 2896 assert_select 'option[value="5"][selected=selected]', :text => 'Closed'
2897 2897 end
2898 2898
2899 2899 assert_equal 7, issue.priority_id
2900 2900 assert_select 'select[name=?]', 'issue[priority_id]' do
2901 2901 assert_select 'option[value="7"][selected=selected]', :text => 'Urgent'
2902 2902 end
2903 2903
2904 2904 assert_select 'input[name=?][value="2.5"]', 'time_entry[hours]'
2905 2905 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2906 2906 assert_select 'option[value="10"][selected=selected]', :text => 'Development'
2907 2907 end
2908 2908 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2909 2909 end
2910 2910
2911 2911 def test_get_edit_with_multi_custom_field
2912 2912 field = CustomField.find(1)
2913 2913 field.update_attribute :multiple, true
2914 2914 issue = Issue.find(1)
2915 2915 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2916 2916 issue.save!
2917 2917
2918 2918 @request.session[:user_id] = 2
2919 2919 get :edit, :id => 1
2920 2920 assert_response :success
2921 2921 assert_template 'edit'
2922 2922
2923 2923 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2924 2924 assert_select 'option', 3
2925 2925 assert_select 'option[value=MySQL][selected=selected]'
2926 2926 assert_select 'option[value=Oracle][selected=selected]'
2927 2927 assert_select 'option[value=PostgreSQL]:not([selected])'
2928 2928 end
2929 2929 end
2930 2930
2931 2931 def test_update_form_for_existing_issue
2932 2932 @request.session[:user_id] = 2
2933 2933 xhr :patch, :edit, :id => 1,
2934 2934 :issue => {:tracker_id => 2,
2935 2935 :subject => 'This is the test_new issue',
2936 2936 :description => 'This is the description',
2937 2937 :priority_id => 5}
2938 2938 assert_response :success
2939 2939 assert_equal 'text/javascript', response.content_type
2940 2940 assert_template 'edit'
2941 2941 assert_template :partial => '_form'
2942 2942
2943 2943 issue = assigns(:issue)
2944 2944 assert_kind_of Issue, issue
2945 2945 assert_equal 1, issue.id
2946 2946 assert_equal 1, issue.project_id
2947 2947 assert_equal 2, issue.tracker_id
2948 2948 assert_equal 'This is the test_new issue', issue.subject
2949 2949 end
2950 2950
2951 2951 def test_update_form_for_existing_issue_should_keep_issue_author
2952 2952 @request.session[:user_id] = 3
2953 2953 xhr :patch, :edit, :id => 1, :issue => {:subject => 'Changed'}
2954 2954 assert_response :success
2955 2955 assert_equal 'text/javascript', response.content_type
2956 2956
2957 2957 issue = assigns(:issue)
2958 2958 assert_equal User.find(2), issue.author
2959 2959 assert_equal 2, issue.author_id
2960 2960 assert_not_equal User.current, issue.author
2961 2961 end
2962 2962
2963 2963 def test_update_form_for_existing_issue_should_propose_transitions_based_on_initial_status
2964 2964 @request.session[:user_id] = 2
2965 2965 WorkflowTransition.delete_all
2966 2966 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2967 2967 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2968 2968 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2969 2969
2970 2970 xhr :patch, :edit, :id => 2,
2971 2971 :issue => {:tracker_id => 2,
2972 2972 :status_id => 5,
2973 2973 :subject => 'This is an issue'}
2974 2974
2975 2975 assert_equal 5, assigns(:issue).status_id
2976 2976 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2977 2977 end
2978 2978
2979 2979 def test_update_form_for_existing_issue_with_project_change
2980 2980 @request.session[:user_id] = 2
2981 2981 xhr :patch, :edit, :id => 1,
2982 2982 :issue => {:project_id => 2,
2983 2983 :tracker_id => 2,
2984 2984 :subject => 'This is the test_new issue',
2985 2985 :description => 'This is the description',
2986 2986 :priority_id => 5}
2987 2987 assert_response :success
2988 2988 assert_template :partial => '_form'
2989 2989
2990 2990 issue = assigns(:issue)
2991 2991 assert_kind_of Issue, issue
2992 2992 assert_equal 1, issue.id
2993 2993 assert_equal 2, issue.project_id
2994 2994 assert_equal 2, issue.tracker_id
2995 2995 assert_equal 'This is the test_new issue', issue.subject
2996 2996 end
2997 2997
2998 2998 def test_update_form_should_propose_default_status_for_existing_issue
2999 2999 @request.session[:user_id] = 2
3000 3000 WorkflowTransition.delete_all
3001 3001 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3002 3002
3003 3003 xhr :patch, :edit, :id => 2
3004 3004 assert_response :success
3005 3005 assert_equal [2,3], assigns(:allowed_statuses).map(&:id).sort
3006 3006 end
3007 3007
3008 3008 def test_put_update_without_custom_fields_param
3009 3009 @request.session[:user_id] = 2
3010 3010
3011 3011 issue = Issue.find(1)
3012 3012 assert_equal '125', issue.custom_value_for(2).value
3013 3013
3014 3014 assert_difference('Journal.count') do
3015 3015 assert_difference('JournalDetail.count') do
3016 3016 put :update, :id => 1, :issue => {:subject => 'New subject'}
3017 3017 end
3018 3018 end
3019 3019 assert_redirected_to :action => 'show', :id => '1'
3020 3020 issue.reload
3021 3021 assert_equal 'New subject', issue.subject
3022 3022 # Make sure custom fields were not cleared
3023 3023 assert_equal '125', issue.custom_value_for(2).value
3024 3024 end
3025 3025
3026 3026 def test_put_update_with_project_change
3027 3027 @request.session[:user_id] = 2
3028 3028 ActionMailer::Base.deliveries.clear
3029 3029
3030 3030 with_settings :notified_events => %w(issue_updated) do
3031 3031 assert_difference('Journal.count') do
3032 3032 assert_difference('JournalDetail.count', 3) do
3033 3033 put :update, :id => 1, :issue => {:project_id => '2',
3034 3034 :tracker_id => '1', # no change
3035 3035 :priority_id => '6',
3036 3036 :category_id => '3'
3037 3037 }
3038 3038 end
3039 3039 end
3040 3040 end
3041 3041 assert_redirected_to :action => 'show', :id => '1'
3042 3042 issue = Issue.find(1)
3043 3043 assert_equal 2, issue.project_id
3044 3044 assert_equal 1, issue.tracker_id
3045 3045 assert_equal 6, issue.priority_id
3046 3046 assert_equal 3, issue.category_id
3047 3047
3048 3048 mail = ActionMailer::Base.deliveries.last
3049 3049 assert_not_nil mail
3050 3050 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
3051 3051 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
3052 3052 end
3053 3053
3054 3054 def test_put_update_with_tracker_change
3055 3055 @request.session[:user_id] = 2
3056 3056 ActionMailer::Base.deliveries.clear
3057 3057
3058 3058 with_settings :notified_events => %w(issue_updated) do
3059 3059 assert_difference('Journal.count') do
3060 3060 assert_difference('JournalDetail.count', 2) do
3061 3061 put :update, :id => 1, :issue => {:project_id => '1',
3062 3062 :tracker_id => '2',
3063 3063 :priority_id => '6'
3064 3064 }
3065 3065 end
3066 3066 end
3067 3067 end
3068 3068 assert_redirected_to :action => 'show', :id => '1'
3069 3069 issue = Issue.find(1)
3070 3070 assert_equal 1, issue.project_id
3071 3071 assert_equal 2, issue.tracker_id
3072 3072 assert_equal 6, issue.priority_id
3073 3073 assert_equal 1, issue.category_id
3074 3074
3075 3075 mail = ActionMailer::Base.deliveries.last
3076 3076 assert_not_nil mail
3077 3077 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
3078 3078 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
3079 3079 end
3080 3080
3081 3081 def test_put_update_with_custom_field_change
3082 3082 @request.session[:user_id] = 2
3083 3083 issue = Issue.find(1)
3084 3084 assert_equal '125', issue.custom_value_for(2).value
3085 3085
3086 3086 with_settings :notified_events => %w(issue_updated) do
3087 3087 assert_difference('Journal.count') do
3088 3088 assert_difference('JournalDetail.count', 3) do
3089 3089 put :update, :id => 1, :issue => {:subject => 'Custom field change',
3090 3090 :priority_id => '6',
3091 3091 :category_id => '1', # no change
3092 3092 :custom_field_values => { '2' => 'New custom value' }
3093 3093 }
3094 3094 end
3095 3095 end
3096 3096 end
3097 3097 assert_redirected_to :action => 'show', :id => '1'
3098 3098 issue.reload
3099 3099 assert_equal 'New custom value', issue.custom_value_for(2).value
3100 3100
3101 3101 mail = ActionMailer::Base.deliveries.last
3102 3102 assert_not_nil mail
3103 3103 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
3104 3104 end
3105 3105
3106 3106 def test_put_update_with_multi_custom_field_change
3107 3107 field = CustomField.find(1)
3108 3108 field.update_attribute :multiple, true
3109 3109 issue = Issue.find(1)
3110 3110 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
3111 3111 issue.save!
3112 3112
3113 3113 @request.session[:user_id] = 2
3114 3114 assert_difference('Journal.count') do
3115 3115 assert_difference('JournalDetail.count', 3) do
3116 3116 put :update, :id => 1,
3117 3117 :issue => {
3118 3118 :subject => 'Custom field change',
3119 3119 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
3120 3120 }
3121 3121 end
3122 3122 end
3123 3123 assert_redirected_to :action => 'show', :id => '1'
3124 3124 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
3125 3125 end
3126 3126
3127 3127 def test_put_update_with_status_and_assignee_change
3128 3128 issue = Issue.find(1)
3129 3129 assert_equal 1, issue.status_id
3130 3130 @request.session[:user_id] = 2
3131 3131
3132 3132 with_settings :notified_events => %w(issue_updated) do
3133 3133 assert_difference('TimeEntry.count', 0) do
3134 3134 put :update,
3135 3135 :id => 1,
3136 3136 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
3137 3137 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
3138 3138 end
3139 3139 end
3140 3140 assert_redirected_to :action => 'show', :id => '1'
3141 3141 issue.reload
3142 3142 assert_equal 2, issue.status_id
3143 3143 j = Journal.order('id DESC').first
3144 3144 assert_equal 'Assigned to dlopper', j.notes
3145 3145 assert_equal 2, j.details.size
3146 3146
3147 3147 mail = ActionMailer::Base.deliveries.last
3148 3148 assert_mail_body_match "Status changed from New to Assigned", mail
3149 3149 # subject should contain the new status
3150 3150 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
3151 3151 end
3152 3152
3153 3153 def test_put_update_with_note_only
3154 3154 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
3155 3155
3156 3156 with_settings :notified_events => %w(issue_updated) do
3157 3157 # anonymous user
3158 3158 put :update,
3159 3159 :id => 1,
3160 3160 :issue => { :notes => notes }
3161 3161 end
3162 3162 assert_redirected_to :action => 'show', :id => '1'
3163 3163 j = Journal.order('id DESC').first
3164 3164 assert_equal notes, j.notes
3165 3165 assert_equal 0, j.details.size
3166 3166 assert_equal User.anonymous, j.user
3167 3167
3168 3168 mail = ActionMailer::Base.deliveries.last
3169 3169 assert_mail_body_match notes, mail
3170 3170 end
3171 3171
3172 3172 def test_put_update_with_private_note_only
3173 3173 notes = 'Private note'
3174 3174 @request.session[:user_id] = 2
3175 3175
3176 3176 assert_difference 'Journal.count' do
3177 3177 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
3178 3178 assert_redirected_to :action => 'show', :id => '1'
3179 3179 end
3180 3180
3181 3181 j = Journal.order('id DESC').first
3182 3182 assert_equal notes, j.notes
3183 3183 assert_equal true, j.private_notes
3184 3184 end
3185 3185
3186 3186 def test_put_update_with_private_note_and_changes
3187 3187 notes = 'Private note'
3188 3188 @request.session[:user_id] = 2
3189 3189
3190 3190 assert_difference 'Journal.count', 2 do
3191 3191 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
3192 3192 assert_redirected_to :action => 'show', :id => '1'
3193 3193 end
3194 3194
3195 3195 j = Journal.order('id DESC').first
3196 3196 assert_equal notes, j.notes
3197 3197 assert_equal true, j.private_notes
3198 3198 assert_equal 0, j.details.count
3199 3199
3200 3200 j = Journal.order('id DESC').offset(1).first
3201 3201 assert_nil j.notes
3202 3202 assert_equal false, j.private_notes
3203 3203 assert_equal 1, j.details.count
3204 3204 end
3205 3205
3206 3206 def test_put_update_with_note_and_spent_time
3207 3207 @request.session[:user_id] = 2
3208 3208 spent_hours_before = Issue.find(1).spent_hours
3209 3209 assert_difference('TimeEntry.count') do
3210 3210 put :update,
3211 3211 :id => 1,
3212 3212 :issue => { :notes => '2.5 hours added' },
3213 3213 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
3214 3214 end
3215 3215 assert_redirected_to :action => 'show', :id => '1'
3216 3216
3217 3217 issue = Issue.find(1)
3218 3218
3219 3219 j = Journal.order('id DESC').first
3220 3220 assert_equal '2.5 hours added', j.notes
3221 3221 assert_equal 0, j.details.size
3222 3222
3223 3223 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
3224 3224 assert_not_nil t
3225 3225 assert_equal 2.5, t.hours
3226 3226 assert_equal spent_hours_before + 2.5, issue.spent_hours
3227 3227 end
3228 3228
3229 3229 def test_put_update_should_preserve_parent_issue_even_if_not_visible
3230 3230 parent = Issue.generate!(:project_id => 1, :is_private => true)
3231 3231 issue = Issue.generate!(:parent_issue_id => parent.id)
3232 3232 assert !parent.visible?(User.find(3))
3233 3233 @request.session[:user_id] = 3
3234 3234
3235 3235 get :edit, :id => issue.id
3236 3236 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
3237 3237
3238 3238 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
3239 3239 assert_response 302
3240 3240 assert_equal parent, issue.parent
3241 3241 end
3242 3242
3243 3243 def test_put_update_with_attachment_only
3244 3244 set_tmp_attachments_directory
3245 3245
3246 3246 # Delete all fixtured journals, a race condition can occur causing the wrong
3247 3247 # journal to get fetched in the next find.
3248 3248 Journal.delete_all
3249 3249
3250 3250 with_settings :notified_events => %w(issue_updated) do
3251 3251 # anonymous user
3252 3252 assert_difference 'Attachment.count' do
3253 3253 put :update, :id => 1,
3254 3254 :issue => {:notes => ''},
3255 3255 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
3256 3256 end
3257 3257 end
3258 3258
3259 3259 assert_redirected_to :action => 'show', :id => '1'
3260 3260 j = Issue.find(1).journals.reorder('id DESC').first
3261 3261 assert j.notes.blank?
3262 3262 assert_equal 1, j.details.size
3263 3263 assert_equal 'testfile.txt', j.details.first.value
3264 3264 assert_equal User.anonymous, j.user
3265 3265
3266 3266 attachment = Attachment.order('id DESC').first
3267 3267 assert_equal Issue.find(1), attachment.container
3268 3268 assert_equal User.anonymous, attachment.author
3269 3269 assert_equal 'testfile.txt', attachment.filename
3270 3270 assert_equal 'text/plain', attachment.content_type
3271 3271 assert_equal 'test file', attachment.description
3272 3272 assert_equal 59, attachment.filesize
3273 3273 assert File.exists?(attachment.diskfile)
3274 3274 assert_equal 59, File.size(attachment.diskfile)
3275 3275
3276 3276 mail = ActionMailer::Base.deliveries.last
3277 3277 assert_mail_body_match 'testfile.txt', mail
3278 3278 end
3279 3279
3280 3280 def test_put_update_with_failure_should_save_attachments
3281 3281 set_tmp_attachments_directory
3282 3282 @request.session[:user_id] = 2
3283 3283
3284 3284 assert_no_difference 'Journal.count' do
3285 3285 assert_difference 'Attachment.count' do
3286 3286 put :update, :id => 1,
3287 3287 :issue => { :subject => '' },
3288 3288 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
3289 3289 assert_response :success
3290 3290 assert_template 'edit'
3291 3291 end
3292 3292 end
3293 3293
3294 3294 attachment = Attachment.order('id DESC').first
3295 3295 assert_equal 'testfile.txt', attachment.filename
3296 3296 assert File.exists?(attachment.diskfile)
3297 3297 assert_nil attachment.container
3298 3298
3299 3299 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3300 3300 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3301 3301 end
3302 3302
3303 3303 def test_put_update_with_failure_should_keep_saved_attachments
3304 3304 set_tmp_attachments_directory
3305 3305 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3306 3306 @request.session[:user_id] = 2
3307 3307
3308 3308 assert_no_difference 'Journal.count' do
3309 3309 assert_no_difference 'Attachment.count' do
3310 3310 put :update, :id => 1,
3311 3311 :issue => { :subject => '' },
3312 3312 :attachments => {'p0' => {'token' => attachment.token}}
3313 3313 assert_response :success
3314 3314 assert_template 'edit'
3315 3315 end
3316 3316 end
3317 3317
3318 3318 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3319 3319 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3320 3320 end
3321 3321
3322 3322 def test_put_update_should_attach_saved_attachments
3323 3323 set_tmp_attachments_directory
3324 3324 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3325 3325 @request.session[:user_id] = 2
3326 3326
3327 3327 assert_difference 'Journal.count' do
3328 3328 assert_difference 'JournalDetail.count' do
3329 3329 assert_no_difference 'Attachment.count' do
3330 3330 put :update, :id => 1,
3331 3331 :issue => {:notes => 'Attachment added'},
3332 3332 :attachments => {'p0' => {'token' => attachment.token}}
3333 3333 assert_redirected_to '/issues/1'
3334 3334 end
3335 3335 end
3336 3336 end
3337 3337
3338 3338 attachment.reload
3339 3339 assert_equal Issue.find(1), attachment.container
3340 3340
3341 3341 journal = Journal.order('id DESC').first
3342 3342 assert_equal 1, journal.details.size
3343 3343 assert_equal 'testfile.txt', journal.details.first.value
3344 3344 end
3345 3345
3346 3346 def test_put_update_with_attachment_that_fails_to_save
3347 3347 set_tmp_attachments_directory
3348 3348
3349 3349 # anonymous user
3350 3350 with_settings :attachment_max_size => 0 do
3351 3351 put :update,
3352 3352 :id => 1,
3353 3353 :issue => {:notes => ''},
3354 3354 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3355 3355 assert_redirected_to :action => 'show', :id => '1'
3356 3356 assert_equal '1 file(s) could not be saved.', flash[:warning]
3357 3357 end
3358 3358 end
3359 3359
3360 3360 def test_put_update_with_no_change
3361 3361 issue = Issue.find(1)
3362 3362 issue.journals.clear
3363 3363 ActionMailer::Base.deliveries.clear
3364 3364
3365 3365 put :update,
3366 3366 :id => 1,
3367 3367 :issue => {:notes => ''}
3368 3368 assert_redirected_to :action => 'show', :id => '1'
3369 3369
3370 3370 issue.reload
3371 3371 assert issue.journals.empty?
3372 3372 # No email should be sent
3373 3373 assert ActionMailer::Base.deliveries.empty?
3374 3374 end
3375 3375
3376 3376 def test_put_update_should_send_a_notification
3377 3377 @request.session[:user_id] = 2
3378 3378 ActionMailer::Base.deliveries.clear
3379 3379 issue = Issue.find(1)
3380 3380 old_subject = issue.subject
3381 3381 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3382 3382
3383 3383 with_settings :notified_events => %w(issue_updated) do
3384 3384 put :update, :id => 1, :issue => {:subject => new_subject,
3385 3385 :priority_id => '6',
3386 3386 :category_id => '1' # no change
3387 3387 }
3388 3388 assert_equal 1, ActionMailer::Base.deliveries.size
3389 3389 end
3390 3390 end
3391 3391
3392 3392 def test_put_update_with_invalid_spent_time_hours_only
3393 3393 @request.session[:user_id] = 2
3394 3394 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3395 3395
3396 3396 assert_no_difference('Journal.count') do
3397 3397 put :update,
3398 3398 :id => 1,
3399 3399 :issue => {:notes => notes},
3400 3400 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3401 3401 end
3402 3402 assert_response :success
3403 3403 assert_template 'edit'
3404 3404
3405 3405 assert_select_error /Activity cannot be blank/
3406 3406 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3407 3407 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3408 3408 end
3409 3409
3410 3410 def test_put_update_with_invalid_spent_time_comments_only
3411 3411 @request.session[:user_id] = 2
3412 3412 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3413 3413
3414 3414 assert_no_difference('Journal.count') do
3415 3415 put :update,
3416 3416 :id => 1,
3417 3417 :issue => {:notes => notes},
3418 3418 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3419 3419 end
3420 3420 assert_response :success
3421 3421 assert_template 'edit'
3422 3422
3423 3423 assert_select_error /Activity cannot be blank/
3424 3424 assert_select_error /Hours cannot be blank/
3425 3425 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3426 3426 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3427 3427 end
3428 3428
3429 3429 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3430 3430 issue = Issue.find(2)
3431 3431 @request.session[:user_id] = 2
3432 3432
3433 3433 put :update,
3434 3434 :id => issue.id,
3435 3435 :issue => {
3436 3436 :fixed_version_id => 4
3437 3437 }
3438 3438
3439 3439 assert_response :redirect
3440 3440 issue.reload
3441 3441 assert_equal 4, issue.fixed_version_id
3442 3442 assert_not_equal issue.project_id, issue.fixed_version.project_id
3443 3443 end
3444 3444
3445 3445 def test_put_update_should_redirect_back_using_the_back_url_parameter
3446 3446 issue = Issue.find(2)
3447 3447 @request.session[:user_id] = 2
3448 3448
3449 3449 put :update,
3450 3450 :id => issue.id,
3451 3451 :issue => {
3452 3452 :fixed_version_id => 4
3453 3453 },
3454 3454 :back_url => '/issues'
3455 3455
3456 3456 assert_response :redirect
3457 3457 assert_redirected_to '/issues'
3458 3458 end
3459 3459
3460 3460 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3461 3461 issue = Issue.find(2)
3462 3462 @request.session[:user_id] = 2
3463 3463
3464 3464 put :update,
3465 3465 :id => issue.id,
3466 3466 :issue => {
3467 3467 :fixed_version_id => 4
3468 3468 },
3469 3469 :back_url => 'http://google.com'
3470 3470
3471 3471 assert_response :redirect
3472 3472 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3473 3473 end
3474 3474
3475 3475 def test_get_bulk_edit
3476 3476 @request.session[:user_id] = 2
3477 3477 get :bulk_edit, :ids => [1, 3]
3478 3478 assert_response :success
3479 3479 assert_template 'bulk_edit'
3480 3480
3481 3481 assert_select 'ul#bulk-selection' do
3482 3482 assert_select 'li', 2
3483 3483 assert_select 'li a', :text => 'Bug #1'
3484 3484 end
3485 3485
3486 3486 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3487 3487 assert_select 'input[name=?]', 'ids[]', 2
3488 3488 assert_select 'input[name=?][value="1"][type=hidden]', 'ids[]'
3489 3489
3490 3490 assert_select 'select[name=?]', 'issue[project_id]'
3491 3491 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3492 3492
3493 3493 # Project specific custom field, date type
3494 3494 field = CustomField.find(9)
3495 3495 assert !field.is_for_all?
3496 3496 assert_equal 'date', field.field_format
3497 3497 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3498 3498
3499 3499 # System wide custom field
3500 3500 assert CustomField.find(1).is_for_all?
3501 3501 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3502 3502
3503 3503 # Be sure we don't display inactive IssuePriorities
3504 3504 assert ! IssuePriority.find(15).active?
3505 3505 assert_select 'select[name=?]', 'issue[priority_id]' do
3506 3506 assert_select 'option[value="15"]', 0
3507 3507 end
3508 3508 end
3509 3509 end
3510 3510
3511 3511 def test_get_bulk_edit_on_different_projects
3512 3512 @request.session[:user_id] = 2
3513 3513 get :bulk_edit, :ids => [1, 2, 6]
3514 3514 assert_response :success
3515 3515 assert_template 'bulk_edit'
3516 3516
3517 3517 # Can not set issues from different projects as children of an issue
3518 3518 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3519 3519
3520 3520 # Project specific custom field, date type
3521 3521 field = CustomField.find(9)
3522 3522 assert !field.is_for_all?
3523 3523 assert !field.project_ids.include?(Issue.find(6).project_id)
3524 3524 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3525 3525 end
3526 3526
3527 3527 def test_get_bulk_edit_with_user_custom_field
3528 3528 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true, :tracker_ids => [1,2,3])
3529 3529
3530 3530 @request.session[:user_id] = 2
3531 3531 get :bulk_edit, :ids => [1, 2]
3532 3532 assert_response :success
3533 3533 assert_template 'bulk_edit'
3534 3534
3535 3535 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3536 3536 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3537 3537 end
3538 3538 end
3539 3539
3540 3540 def test_get_bulk_edit_with_version_custom_field
3541 3541 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true, :tracker_ids => [1,2,3])
3542 3542
3543 3543 @request.session[:user_id] = 2
3544 3544 get :bulk_edit, :ids => [1, 2]
3545 3545 assert_response :success
3546 3546 assert_template 'bulk_edit'
3547 3547
3548 3548 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3549 3549 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3550 3550 end
3551 3551 end
3552 3552
3553 3553 def test_get_bulk_edit_with_multi_custom_field
3554 3554 field = CustomField.find(1)
3555 3555 field.update_attribute :multiple, true
3556 3556
3557 3557 @request.session[:user_id] = 2
3558 3558 get :bulk_edit, :ids => [1, 3]
3559 3559 assert_response :success
3560 3560 assert_template 'bulk_edit'
3561 3561
3562 3562 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3563 3563 assert_select 'option', field.possible_values.size + 1 # "none" options
3564 3564 end
3565 3565 end
3566 3566
3567 3567 def test_bulk_edit_should_propose_to_clear_text_custom_fields
3568 3568 @request.session[:user_id] = 2
3569 3569 get :bulk_edit, :ids => [1, 3]
3570 3570 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', '__none__'
3571 3571 end
3572 3572
3573 3573 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3574 3574 WorkflowTransition.delete_all
3575 3575 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3576 3576 :old_status_id => 1, :new_status_id => 1)
3577 3577 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3578 3578 :old_status_id => 1, :new_status_id => 3)
3579 3579 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3580 3580 :old_status_id => 1, :new_status_id => 4)
3581 3581 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3582 3582 :old_status_id => 2, :new_status_id => 1)
3583 3583 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3584 3584 :old_status_id => 2, :new_status_id => 3)
3585 3585 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3586 3586 :old_status_id => 2, :new_status_id => 5)
3587 3587 @request.session[:user_id] = 2
3588 3588 get :bulk_edit, :ids => [1, 2]
3589 3589
3590 3590 assert_response :success
3591 3591 statuses = assigns(:available_statuses)
3592 3592 assert_not_nil statuses
3593 3593 assert_equal [1, 3], statuses.map(&:id).sort
3594 3594
3595 3595 assert_select 'select[name=?]', 'issue[status_id]' do
3596 3596 assert_select 'option', 3 # 2 statuses + "no change" option
3597 3597 end
3598 3598 end
3599 3599
3600 3600 def test_bulk_edit_should_propose_target_project_open_shared_versions
3601 3601 @request.session[:user_id] = 2
3602 3602 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3603 3603 assert_response :success
3604 3604 assert_template 'bulk_edit'
3605 3605 assert_equal Project.find(1).shared_versions.open.to_a.sort, assigns(:versions).sort
3606 3606
3607 3607 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3608 3608 assert_select 'option', :text => '2.0'
3609 3609 end
3610 3610 end
3611 3611
3612 3612 def test_bulk_edit_should_propose_target_project_categories
3613 3613 @request.session[:user_id] = 2
3614 3614 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3615 3615 assert_response :success
3616 3616 assert_template 'bulk_edit'
3617 3617 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3618 3618
3619 3619 assert_select 'select[name=?]', 'issue[category_id]' do
3620 3620 assert_select 'option', :text => 'Recipes'
3621 3621 end
3622 3622 end
3623 3623
3624 3624 def test_bulk_edit_should_only_propose_issues_trackers_custom_fields
3625 3625 IssueCustomField.delete_all
3626 3626 field = IssueCustomField.generate!(:tracker_ids => [1], :is_for_all => true)
3627 3627 IssueCustomField.generate!(:tracker_ids => [2], :is_for_all => true)
3628 3628 @request.session[:user_id] = 2
3629 3629
3630 3630 issue_ids = Issue.where(:project_id => 1, :tracker_id => 1).limit(2).ids
3631 3631 get :bulk_edit, :ids => issue_ids
3632 3632 assert_equal [field], assigns(:custom_fields)
3633 3633 end
3634 3634
3635 3635 def test_bulk_update
3636 3636 @request.session[:user_id] = 2
3637 3637 # update issues priority
3638 3638 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3639 3639 :issue => {:priority_id => 7,
3640 3640 :assigned_to_id => '',
3641 3641 :custom_field_values => {'2' => ''}}
3642 3642
3643 3643 assert_response 302
3644 3644 # check that the issues were updated
3645 3645 assert_equal [7, 7], Issue.where(:id =>[1, 2]).collect {|i| i.priority.id}
3646 3646
3647 3647 issue = Issue.find(1)
3648 3648 journal = issue.journals.reorder('created_on DESC').first
3649 3649 assert_equal '125', issue.custom_value_for(2).value
3650 3650 assert_equal 'Bulk editing', journal.notes
3651 3651 assert_equal 1, journal.details.size
3652 3652 end
3653 3653
3654 3654 def test_bulk_update_with_group_assignee
3655 3655 group = Group.find(11)
3656 3656 project = Project.find(1)
3657 3657 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3658 3658
3659 3659 @request.session[:user_id] = 2
3660 3660 # update issues assignee
3661 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3662 :issue => {:priority_id => '',
3663 :assigned_to_id => group.id,
3664 :custom_field_values => {'2' => ''}}
3665
3666 assert_response 302
3667 assert_equal [group, group], Issue.where(:id => [1, 2]).collect {|i| i.assigned_to}
3661 with_settings :issue_group_assignment => '1' do
3662 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3663 :issue => {:priority_id => '',
3664 :assigned_to_id => group.id,
3665 :custom_field_values => {'2' => ''}}
3666
3667 assert_response 302
3668 assert_equal [group, group], Issue.where(:id => [1, 2]).collect {|i| i.assigned_to}
3669 end
3668 3670 end
3669 3671
3670 3672 def test_bulk_update_on_different_projects
3671 3673 @request.session[:user_id] = 2
3672 3674 # update issues priority
3673 3675 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3674 3676 :issue => {:priority_id => 7,
3675 3677 :assigned_to_id => '',
3676 3678 :custom_field_values => {'2' => ''}}
3677 3679
3678 3680 assert_response 302
3679 3681 # check that the issues were updated
3680 3682 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3681 3683
3682 3684 issue = Issue.find(1)
3683 3685 journal = issue.journals.reorder('created_on DESC').first
3684 3686 assert_equal '125', issue.custom_value_for(2).value
3685 3687 assert_equal 'Bulk editing', journal.notes
3686 3688 assert_equal 1, journal.details.size
3687 3689 end
3688 3690
3689 3691 def test_bulk_update_on_different_projects_without_rights
3690 3692 @request.session[:user_id] = 3
3691 3693 user = User.find(3)
3692 3694 action = { :controller => "issues", :action => "bulk_update" }
3693 3695 assert user.allowed_to?(action, Issue.find(1).project)
3694 3696 assert ! user.allowed_to?(action, Issue.find(6).project)
3695 3697 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3696 3698 :issue => {:priority_id => 7,
3697 3699 :assigned_to_id => '',
3698 3700 :custom_field_values => {'2' => ''}}
3699 3701 assert_response 403
3700 3702 assert_not_equal "Bulk should fail", Journal.last.notes
3701 3703 end
3702 3704
3703 3705 def test_bullk_update_should_send_a_notification
3704 3706 @request.session[:user_id] = 2
3705 3707 ActionMailer::Base.deliveries.clear
3706 3708 with_settings :notified_events => %w(issue_updated) do
3707 3709 post(:bulk_update,
3708 3710 {
3709 3711 :ids => [1, 2],
3710 3712 :notes => 'Bulk editing',
3711 3713 :issue => {
3712 3714 :priority_id => 7,
3713 3715 :assigned_to_id => '',
3714 3716 :custom_field_values => {'2' => ''}
3715 3717 }
3716 3718 })
3717 3719 assert_response 302
3718 3720 assert_equal 2, ActionMailer::Base.deliveries.size
3719 3721 end
3720 3722 end
3721 3723
3722 3724 def test_bulk_update_project
3723 3725 @request.session[:user_id] = 2
3724 3726 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3725 3727 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3726 3728 # Issues moved to project 2
3727 3729 assert_equal 2, Issue.find(1).project_id
3728 3730 assert_equal 2, Issue.find(2).project_id
3729 3731 # No tracker change
3730 3732 assert_equal 1, Issue.find(1).tracker_id
3731 3733 assert_equal 2, Issue.find(2).tracker_id
3732 3734 end
3733 3735
3734 3736 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3735 3737 @request.session[:user_id] = 2
3736 3738 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3737 3739 assert_redirected_to '/issues/1'
3738 3740 end
3739 3741
3740 3742 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3741 3743 @request.session[:user_id] = 2
3742 3744 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3743 3745 assert_redirected_to '/projects/onlinestore/issues'
3744 3746 end
3745 3747
3746 3748 def test_bulk_update_tracker
3747 3749 @request.session[:user_id] = 2
3748 3750 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3749 3751 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3750 3752 assert_equal 2, Issue.find(1).tracker_id
3751 3753 assert_equal 2, Issue.find(2).tracker_id
3752 3754 end
3753 3755
3754 3756 def test_bulk_update_status
3755 3757 @request.session[:user_id] = 2
3756 3758 # update issues priority
3757 3759 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3758 3760 :issue => {:priority_id => '',
3759 3761 :assigned_to_id => '',
3760 3762 :status_id => '5'}
3761 3763
3762 3764 assert_response 302
3763 3765 issue = Issue.find(1)
3764 3766 assert issue.closed?
3765 3767 end
3766 3768
3767 3769 def test_bulk_update_priority
3768 3770 @request.session[:user_id] = 2
3769 3771 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3770 3772
3771 3773 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3772 3774 assert_equal 6, Issue.find(1).priority_id
3773 3775 assert_equal 6, Issue.find(2).priority_id
3774 3776 end
3775 3777
3776 3778 def test_bulk_update_with_notes
3777 3779 @request.session[:user_id] = 2
3778 3780 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3779 3781
3780 3782 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3781 3783 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3782 3784 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3783 3785 end
3784 3786
3785 3787 def test_bulk_update_parent_id
3786 3788 IssueRelation.delete_all
3787 3789 @request.session[:user_id] = 2
3788 3790 post :bulk_update, :ids => [1, 3],
3789 3791 :notes => 'Bulk editing parent',
3790 3792 :issue => {:priority_id => '', :assigned_to_id => '',
3791 3793 :status_id => '', :parent_issue_id => '2'}
3792 3794 assert_response 302
3793 3795 parent = Issue.find(2)
3794 3796 assert_equal parent.id, Issue.find(1).parent_id
3795 3797 assert_equal parent.id, Issue.find(3).parent_id
3796 3798 assert_equal [1, 3], parent.children.collect(&:id).sort
3797 3799 end
3798 3800
3799 3801 def test_bulk_update_custom_field
3800 3802 @request.session[:user_id] = 2
3801 3803 # update issues priority
3802 3804 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3803 3805 :issue => {:priority_id => '',
3804 3806 :assigned_to_id => '',
3805 3807 :custom_field_values => {'2' => '777'}}
3806 3808
3807 3809 assert_response 302
3808 3810
3809 3811 issue = Issue.find(1)
3810 3812 journal = issue.journals.reorder('created_on DESC').first
3811 3813 assert_equal '777', issue.custom_value_for(2).value
3812 3814 assert_equal 1, journal.details.size
3813 3815 assert_equal '125', journal.details.first.old_value
3814 3816 assert_equal '777', journal.details.first.value
3815 3817 end
3816 3818
3817 3819 def test_bulk_update_custom_field_to_blank
3818 3820 @request.session[:user_id] = 2
3819 3821 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3820 3822 :issue => {:priority_id => '',
3821 3823 :assigned_to_id => '',
3822 3824 :custom_field_values => {'1' => '__none__'}}
3823 3825 assert_response 302
3824 3826 assert_equal '', Issue.find(1).custom_field_value(1)
3825 3827 assert_equal '', Issue.find(3).custom_field_value(1)
3826 3828 end
3827 3829
3828 3830 def test_bulk_update_multi_custom_field
3829 3831 field = CustomField.find(1)
3830 3832 field.update_attribute :multiple, true
3831 3833
3832 3834 @request.session[:user_id] = 2
3833 3835 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3834 3836 :issue => {:priority_id => '',
3835 3837 :assigned_to_id => '',
3836 3838 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3837 3839
3838 3840 assert_response 302
3839 3841
3840 3842 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3841 3843 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3842 3844 # the custom field is not associated with the issue tracker
3843 3845 assert_nil Issue.find(2).custom_field_value(1)
3844 3846 end
3845 3847
3846 3848 def test_bulk_update_multi_custom_field_to_blank
3847 3849 field = CustomField.find(1)
3848 3850 field.update_attribute :multiple, true
3849 3851
3850 3852 @request.session[:user_id] = 2
3851 3853 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3852 3854 :issue => {:priority_id => '',
3853 3855 :assigned_to_id => '',
3854 3856 :custom_field_values => {'1' => ['__none__']}}
3855 3857 assert_response 302
3856 3858 assert_equal [''], Issue.find(1).custom_field_value(1)
3857 3859 assert_equal [''], Issue.find(3).custom_field_value(1)
3858 3860 end
3859 3861
3860 3862 def test_bulk_update_unassign
3861 3863 assert_not_nil Issue.find(2).assigned_to
3862 3864 @request.session[:user_id] = 2
3863 3865 # unassign issues
3864 3866 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3865 3867 assert_response 302
3866 3868 # check that the issues were updated
3867 3869 assert_nil Issue.find(2).assigned_to
3868 3870 end
3869 3871
3870 3872 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3871 3873 @request.session[:user_id] = 2
3872 3874
3873 3875 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3874 3876
3875 3877 assert_response :redirect
3876 3878 issues = Issue.find([1,2])
3877 3879 issues.each do |issue|
3878 3880 assert_equal 4, issue.fixed_version_id
3879 3881 assert_not_equal issue.project_id, issue.fixed_version.project_id
3880 3882 end
3881 3883 end
3882 3884
3883 3885 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3884 3886 @request.session[:user_id] = 2
3885 3887 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3886 3888
3887 3889 assert_response :redirect
3888 3890 assert_redirected_to '/issues'
3889 3891 end
3890 3892
3891 3893 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3892 3894 @request.session[:user_id] = 2
3893 3895 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3894 3896
3895 3897 assert_response :redirect
3896 3898 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3897 3899 end
3898 3900
3899 3901 def test_bulk_update_with_all_failures_should_show_errors
3900 3902 @request.session[:user_id] = 2
3901 3903 post :bulk_update, :ids => [1, 2], :issue => {:start_date => 'foo'}
3902 3904
3903 3905 assert_response :success
3904 3906 assert_template 'bulk_edit'
3905 3907 assert_select '#errorExplanation span', :text => 'Failed to save 2 issue(s) on 2 selected: #1, #2.'
3906 3908 assert_select '#errorExplanation ul li', :text => 'Start date is not a valid date: #1, #2'
3907 3909
3908 3910 assert_equal [1, 2], assigns[:issues].map(&:id)
3909 3911 end
3910 3912
3911 3913 def test_bulk_update_with_some_failures_should_show_errors
3912 3914 issue1 = Issue.generate!(:start_date => '2013-05-12')
3913 3915 issue2 = Issue.generate!(:start_date => '2013-05-15')
3914 3916 issue3 = Issue.generate!
3915 3917 @request.session[:user_id] = 2
3916 3918 post :bulk_update, :ids => [issue1.id, issue2.id, issue3.id],
3917 3919 :issue => {:due_date => '2013-05-01'}
3918 3920 assert_response :success
3919 3921 assert_template 'bulk_edit'
3920 3922 assert_select '#errorExplanation span',
3921 3923 :text => "Failed to save 2 issue(s) on 3 selected: ##{issue1.id}, ##{issue2.id}."
3922 3924 assert_select '#errorExplanation ul li',
3923 3925 :text => "Due date must be greater than start date: ##{issue1.id}, ##{issue2.id}"
3924 3926 assert_equal [issue1.id, issue2.id], assigns[:issues].map(&:id)
3925 3927 end
3926 3928
3927 3929 def test_bulk_update_with_failure_should_preserved_form_values
3928 3930 @request.session[:user_id] = 2
3929 3931 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2', :start_date => 'foo'}
3930 3932
3931 3933 assert_response :success
3932 3934 assert_template 'bulk_edit'
3933 3935 assert_select 'select[name=?]', 'issue[tracker_id]' do
3934 3936 assert_select 'option[value="2"][selected=selected]'
3935 3937 end
3936 3938 assert_select 'input[name=?][value=?]', 'issue[start_date]', 'foo'
3937 3939 end
3938 3940
3939 3941 def test_get_bulk_copy
3940 3942 @request.session[:user_id] = 2
3941 3943 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3942 3944 assert_response :success
3943 3945 assert_template 'bulk_edit'
3944 3946
3945 3947 issues = assigns(:issues)
3946 3948 assert_not_nil issues
3947 3949 assert_equal [1, 2, 3], issues.map(&:id).sort
3948 3950
3949 3951 assert_select 'select[name=?]', 'issue[project_id]' do
3950 3952 assert_select 'option[value=""]'
3951 3953 end
3952 3954 assert_select 'input[name=copy_attachments]'
3953 3955 end
3954 3956
3955 3957 def test_get_bulk_copy_without_add_issues_permission_should_not_propose_current_project_as_target
3956 3958 user = setup_user_with_copy_but_not_add_permission
3957 3959 @request.session[:user_id] = user.id
3958 3960
3959 3961 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3960 3962 assert_response :success
3961 3963 assert_template 'bulk_edit'
3962 3964
3963 3965 assert_select 'select[name=?]', 'issue[project_id]' do
3964 3966 assert_select 'option[value=""]', 0
3965 3967 assert_select 'option[value="2"]'
3966 3968 end
3967 3969 end
3968 3970
3969 3971 def test_bulk_copy_to_another_project
3970 3972 @request.session[:user_id] = 2
3971 3973 assert_difference 'Issue.count', 2 do
3972 3974 assert_no_difference 'Project.find(1).issues.count' do
3973 3975 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3974 3976 end
3975 3977 end
3976 3978 assert_redirected_to '/projects/ecookbook/issues'
3977 3979
3978 3980 copies = Issue.order('id DESC').limit(issues.size)
3979 3981 copies.each do |copy|
3980 3982 assert_equal 2, copy.project_id
3981 3983 end
3982 3984 end
3983 3985
3984 3986 def test_bulk_copy_without_add_issues_permission_should_be_allowed_on_project_with_permission
3985 3987 user = setup_user_with_copy_but_not_add_permission
3986 3988 @request.session[:user_id] = user.id
3987 3989
3988 3990 assert_difference 'Issue.count', 3 do
3989 3991 post :bulk_update, :ids => [1, 2, 3], :issue => {:project_id => '2'}, :copy => '1'
3990 3992 assert_response 302
3991 3993 end
3992 3994 end
3993 3995
3994 3996 def test_bulk_copy_on_same_project_without_add_issues_permission_should_be_denied
3995 3997 user = setup_user_with_copy_but_not_add_permission
3996 3998 @request.session[:user_id] = user.id
3997 3999
3998 4000 post :bulk_update, :ids => [1, 2, 3], :issue => {:project_id => ''}, :copy => '1'
3999 4001 assert_response 403
4000 4002 end
4001 4003
4002 4004 def test_bulk_copy_on_different_project_without_add_issues_permission_should_be_denied
4003 4005 user = setup_user_with_copy_but_not_add_permission
4004 4006 @request.session[:user_id] = user.id
4005 4007
4006 4008 post :bulk_update, :ids => [1, 2, 3], :issue => {:project_id => '1'}, :copy => '1'
4007 4009 assert_response 403
4008 4010 end
4009 4011
4010 4012 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
4011 4013 @request.session[:user_id] = 2
4012 4014 issues = [
4013 4015 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1,
4014 4016 :priority_id => 2, :subject => 'issue 1', :author_id => 1,
4015 4017 :assigned_to_id => nil),
4016 4018 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2,
4017 4019 :priority_id => 1, :subject => 'issue 2', :author_id => 2,
4018 4020 :assigned_to_id => 3)
4019 4021 ]
4020 4022 assert_difference 'Issue.count', issues.size do
4021 4023 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
4022 4024 :issue => {
4023 4025 :project_id => '', :tracker_id => '', :assigned_to_id => '',
4024 4026 :status_id => '', :start_date => '', :due_date => ''
4025 4027 }
4026 4028 end
4027 4029
4028 4030 copies = Issue.order('id DESC').limit(issues.size)
4029 4031 issues.each do |orig|
4030 4032 copy = copies.detect {|c| c.subject == orig.subject}
4031 4033 assert_not_nil copy
4032 4034 assert_equal orig.project_id, copy.project_id
4033 4035 assert_equal orig.tracker_id, copy.tracker_id
4034 4036 assert_equal orig.status_id, copy.status_id
4035 4037 assert_equal orig.assigned_to_id, copy.assigned_to_id
4036 4038 assert_equal orig.priority_id, copy.priority_id
4037 4039 end
4038 4040 end
4039 4041
4040 4042 def test_bulk_copy_should_allow_changing_the_issue_attributes
4041 4043 # Fixes random test failure with Mysql
4042 4044 # where Issue.where(:project_id => 2).limit(2).order('id desc')
4043 4045 # doesn't return the expected results
4044 4046 Issue.delete_all("project_id=2")
4045 4047
4046 4048 @request.session[:user_id] = 2
4047 4049 assert_difference 'Issue.count', 2 do
4048 4050 assert_no_difference 'Project.find(1).issues.count' do
4049 4051 post :bulk_update, :ids => [1, 2], :copy => '1',
4050 4052 :issue => {
4051 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
4053 :project_id => '2', :tracker_id => '', :assigned_to_id => '2',
4052 4054 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
4053 4055 }
4054 4056 end
4055 4057 end
4056 4058
4057 4059 copied_issues = Issue.where(:project_id => 2).limit(2).order('id desc').to_a
4058 4060 assert_equal 2, copied_issues.size
4059 4061 copied_issues.each do |issue|
4060 4062 assert_equal 2, issue.project_id, "Project is incorrect"
4061 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
4063 assert_equal 2, issue.assigned_to_id, "Assigned to is incorrect"
4062 4064 assert_equal 1, issue.status_id, "Status is incorrect"
4063 4065 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
4064 4066 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
4065 4067 end
4066 4068 end
4067 4069
4068 4070 def test_bulk_copy_should_allow_adding_a_note
4069 4071 @request.session[:user_id] = 2
4070 4072 assert_difference 'Issue.count', 1 do
4071 4073 post :bulk_update, :ids => [1], :copy => '1',
4072 4074 :notes => 'Copying one issue',
4073 4075 :issue => {
4074 4076 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
4075 4077 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
4076 4078 }
4077 4079 end
4078 4080 issue = Issue.order('id DESC').first
4079 4081 assert_equal 1, issue.journals.size
4080 4082 journal = issue.journals.first
4081 4083 assert_equal 'Copying one issue', journal.notes
4082 4084 end
4083 4085
4084 4086 def test_bulk_copy_should_allow_not_copying_the_attachments
4085 4087 attachment_count = Issue.find(3).attachments.size
4086 4088 assert attachment_count > 0
4087 4089 @request.session[:user_id] = 2
4088 4090
4089 4091 assert_difference 'Issue.count', 1 do
4090 4092 assert_no_difference 'Attachment.count' do
4091 4093 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '0',
4092 4094 :issue => {
4093 4095 :project_id => ''
4094 4096 }
4095 4097 end
4096 4098 end
4097 4099 end
4098 4100
4099 4101 def test_bulk_copy_should_allow_copying_the_attachments
4100 4102 attachment_count = Issue.find(3).attachments.size
4101 4103 assert attachment_count > 0
4102 4104 @request.session[:user_id] = 2
4103 4105
4104 4106 assert_difference 'Issue.count', 1 do
4105 4107 assert_difference 'Attachment.count', attachment_count do
4106 4108 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
4107 4109 :issue => {
4108 4110 :project_id => ''
4109 4111 }
4110 4112 end
4111 4113 end
4112 4114 end
4113 4115
4114 4116 def test_bulk_copy_should_add_relations_with_copied_issues
4115 4117 @request.session[:user_id] = 2
4116 4118
4117 4119 assert_difference 'Issue.count', 2 do
4118 4120 assert_difference 'IssueRelation.count', 2 do
4119 4121 post :bulk_update, :ids => [1, 3], :copy => '1', :link_copy => '1',
4120 4122 :issue => {
4121 4123 :project_id => '1'
4122 4124 }
4123 4125 end
4124 4126 end
4125 4127 end
4126 4128
4127 4129 def test_bulk_copy_should_allow_not_copying_the_subtasks
4128 4130 issue = Issue.generate_with_descendants!
4129 4131 @request.session[:user_id] = 2
4130 4132
4131 4133 assert_difference 'Issue.count', 1 do
4132 4134 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '0',
4133 4135 :issue => {
4134 4136 :project_id => ''
4135 4137 }
4136 4138 end
4137 4139 end
4138 4140
4139 4141 def test_bulk_copy_should_allow_copying_the_subtasks
4140 4142 issue = Issue.generate_with_descendants!
4141 4143 count = issue.descendants.count
4142 4144 @request.session[:user_id] = 2
4143 4145
4144 4146 assert_difference 'Issue.count', count+1 do
4145 4147 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
4146 4148 :issue => {
4147 4149 :project_id => ''
4148 4150 }
4149 4151 end
4150 4152 copy = Issue.where(:parent_id => nil).order("id DESC").first
4151 4153 assert_equal count, copy.descendants.count
4152 4154 end
4153 4155
4154 4156 def test_bulk_copy_should_not_copy_selected_subtasks_twice
4155 4157 issue = Issue.generate_with_descendants!
4156 4158 count = issue.descendants.count
4157 4159 @request.session[:user_id] = 2
4158 4160
4159 4161 assert_difference 'Issue.count', count+1 do
4160 4162 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
4161 4163 :issue => {
4162 4164 :project_id => ''
4163 4165 }
4164 4166 end
4165 4167 copy = Issue.where(:parent_id => nil).order("id DESC").first
4166 4168 assert_equal count, copy.descendants.count
4167 4169 end
4168 4170
4169 4171 def test_bulk_copy_to_another_project_should_follow_when_needed
4170 4172 @request.session[:user_id] = 2
4171 4173 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
4172 4174 issue = Issue.order('id DESC').first
4173 4175 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
4174 4176 end
4175 4177
4176 4178 def test_bulk_copy_with_all_failures_should_display_errors
4177 4179 @request.session[:user_id] = 2
4178 4180 post :bulk_update, :ids => [1, 2], :copy => '1', :issue => {:start_date => 'foo'}
4179 4181
4180 4182 assert_response :success
4181 4183 end
4182 4184
4183 4185 def test_destroy_issue_with_no_time_entries
4184 4186 assert_nil TimeEntry.find_by_issue_id(2)
4185 4187 @request.session[:user_id] = 2
4186 4188
4187 4189 assert_difference 'Issue.count', -1 do
4188 4190 delete :destroy, :id => 2
4189 4191 end
4190 4192 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
4191 4193 assert_nil Issue.find_by_id(2)
4192 4194 end
4193 4195
4194 4196 def test_destroy_issues_with_time_entries
4195 4197 @request.session[:user_id] = 2
4196 4198
4197 4199 assert_no_difference 'Issue.count' do
4198 4200 delete :destroy, :ids => [1, 3]
4199 4201 end
4200 4202 assert_response :success
4201 4203 assert_template 'destroy'
4202 4204 assert_not_nil assigns(:hours)
4203 4205 assert Issue.find_by_id(1) && Issue.find_by_id(3)
4204 4206
4205 4207 assert_select 'form' do
4206 4208 assert_select 'input[name=_method][value=delete]'
4207 4209 end
4208 4210 end
4209 4211
4210 4212 def test_destroy_issues_and_destroy_time_entries
4211 4213 @request.session[:user_id] = 2
4212 4214
4213 4215 assert_difference 'Issue.count', -2 do
4214 4216 assert_difference 'TimeEntry.count', -3 do
4215 4217 delete :destroy, :ids => [1, 3], :todo => 'destroy'
4216 4218 end
4217 4219 end
4218 4220 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
4219 4221 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
4220 4222 assert_nil TimeEntry.find_by_id([1, 2])
4221 4223 end
4222 4224
4223 4225 def test_destroy_issues_and_assign_time_entries_to_project
4224 4226 @request.session[:user_id] = 2
4225 4227
4226 4228 assert_difference 'Issue.count', -2 do
4227 4229 assert_no_difference 'TimeEntry.count' do
4228 4230 delete :destroy, :ids => [1, 3], :todo => 'nullify'
4229 4231 end
4230 4232 end
4231 4233 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
4232 4234 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
4233 4235 assert_nil TimeEntry.find(1).issue_id
4234 4236 assert_nil TimeEntry.find(2).issue_id
4235 4237 end
4236 4238
4237 4239 def test_destroy_issues_and_reassign_time_entries_to_another_issue
4238 4240 @request.session[:user_id] = 2
4239 4241
4240 4242 assert_difference 'Issue.count', -2 do
4241 4243 assert_no_difference 'TimeEntry.count' do
4242 4244 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
4243 4245 end
4244 4246 end
4245 4247 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
4246 4248 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
4247 4249 assert_equal 2, TimeEntry.find(1).issue_id
4248 4250 assert_equal 2, TimeEntry.find(2).issue_id
4249 4251 end
4250 4252
4251 4253 def test_destroy_issues_and_reassign_time_entries_to_an_invalid_issue_should_fail
4252 4254 @request.session[:user_id] = 2
4253 4255
4254 4256 assert_no_difference 'Issue.count' do
4255 4257 assert_no_difference 'TimeEntry.count' do
4256 4258 # try to reassign time to an issue of another project
4257 4259 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 4
4258 4260 end
4259 4261 end
4260 4262 assert_response :success
4261 4263 assert_template 'destroy'
4262 4264 end
4263 4265
4264 4266 def test_destroy_issues_from_different_projects
4265 4267 @request.session[:user_id] = 2
4266 4268
4267 4269 assert_difference 'Issue.count', -3 do
4268 4270 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
4269 4271 end
4270 4272 assert_redirected_to :controller => 'issues', :action => 'index'
4271 4273 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
4272 4274 end
4273 4275
4274 4276 def test_destroy_parent_and_child_issues
4275 4277 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
4276 4278 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
4277 4279 assert child.is_descendant_of?(parent.reload)
4278 4280
4279 4281 @request.session[:user_id] = 2
4280 4282 assert_difference 'Issue.count', -2 do
4281 4283 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
4282 4284 end
4283 4285 assert_response 302
4284 4286 end
4285 4287
4286 4288 def test_destroy_invalid_should_respond_with_404
4287 4289 @request.session[:user_id] = 2
4288 4290 assert_no_difference 'Issue.count' do
4289 4291 delete :destroy, :id => 999
4290 4292 end
4291 4293 assert_response 404
4292 4294 end
4293 4295
4294 4296 def test_default_search_scope
4295 4297 get :index
4296 4298
4297 4299 assert_select 'div#quick-search form' do
4298 4300 assert_select 'input[name=issues][value="1"][type=hidden]'
4299 4301 end
4300 4302 end
4301 4303
4302 4304 def setup_user_with_copy_but_not_add_permission
4303 4305 Role.all.each {|r| r.remove_permission! :add_issues}
4304 4306 Role.find_by_name('Manager').add_permission! :add_issues
4305 4307 user = User.generate!
4306 4308 User.add_to_project(user, Project.find(1), Role.find_by_name('Developer'))
4307 4309 User.add_to_project(user, Project.find(2), Role.find_by_name('Manager'))
4308 4310 user
4309 4311 end
4310 4312 end
@@ -1,2745 +1,2779
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues, :journals, :journal_details,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def setup
35 35 set_language_if_valid 'en'
36 36 end
37 37
38 38 def teardown
39 39 User.current = nil
40 40 end
41 41
42 42 def test_initialize
43 43 issue = Issue.new
44 44
45 45 assert_nil issue.project_id
46 46 assert_nil issue.tracker_id
47 47 assert_nil issue.status_id
48 48 assert_nil issue.author_id
49 49 assert_nil issue.assigned_to_id
50 50 assert_nil issue.category_id
51 51
52 52 assert_equal IssuePriority.default, issue.priority
53 53 end
54 54
55 55 def test_create
56 56 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
57 57 :status_id => 1, :priority => IssuePriority.all.first,
58 58 :subject => 'test_create',
59 59 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
60 60 assert issue.save
61 61 issue.reload
62 62 assert_equal 1.5, issue.estimated_hours
63 63 end
64 64
65 65 def test_create_minimal
66 66 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
67 67 assert issue.save
68 68 assert_equal issue.tracker.default_status, issue.status
69 69 assert issue.description.nil?
70 70 assert_nil issue.estimated_hours
71 71 end
72 72
73 73 def test_create_with_all_fields_disabled
74 74 tracker = Tracker.find(1)
75 75 tracker.core_fields = []
76 76 tracker.save!
77 77
78 78 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
79 79 assert_save issue
80 80 end
81 81
82 82 def test_start_date_format_should_be_validated
83 83 set_language_if_valid 'en'
84 84 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
85 85 issue = Issue.new(:start_date => invalid_date)
86 86 assert !issue.valid?
87 87 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
88 88 end
89 89 end
90 90
91 91 def test_due_date_format_should_be_validated
92 92 set_language_if_valid 'en'
93 93 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
94 94 issue = Issue.new(:due_date => invalid_date)
95 95 assert !issue.valid?
96 96 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
97 97 end
98 98 end
99 99
100 100 def test_due_date_lesser_than_start_date_should_not_validate
101 101 set_language_if_valid 'en'
102 102 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
103 103 assert !issue.valid?
104 104 assert_include 'Due date must be greater than start date', issue.errors.full_messages
105 105 end
106 106
107 107 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
108 108 issue = Issue.generate(:start_date => '2013-06-04')
109 109 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
110 110 assert !issue.valid?
111 111 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
112 112 end
113 113
114 114 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
115 115 issue = Issue.generate!(:start_date => '2013-06-04')
116 116 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
117 117 issue.start_date = '2013-06-07'
118 118 assert !issue.valid?
119 119 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
120 120 end
121 121
122 122 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
123 123 issue = Issue.generate!(:start_date => '2013-06-04')
124 124 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
125 125 assert issue.valid?
126 126 end
127 127
128 128 def test_estimated_hours_should_be_validated
129 129 set_language_if_valid 'en'
130 130 ['-2'].each do |invalid|
131 131 issue = Issue.new(:estimated_hours => invalid)
132 132 assert !issue.valid?
133 133 assert_include 'Estimated time is invalid', issue.errors.full_messages
134 134 end
135 135 end
136 136
137 137 def test_create_with_required_custom_field
138 138 set_language_if_valid 'en'
139 139 field = IssueCustomField.find_by_name('Database')
140 140 field.update_attribute(:is_required, true)
141 141
142 142 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
143 143 :status_id => 1, :subject => 'test_create',
144 144 :description => 'IssueTest#test_create_with_required_custom_field')
145 145 assert issue.available_custom_fields.include?(field)
146 146 # No value for the custom field
147 147 assert !issue.save
148 148 assert_equal ["Database cannot be blank"], issue.errors.full_messages
149 149 # Blank value
150 150 issue.custom_field_values = { field.id => '' }
151 151 assert !issue.save
152 152 assert_equal ["Database cannot be blank"], issue.errors.full_messages
153 153 # Invalid value
154 154 issue.custom_field_values = { field.id => 'SQLServer' }
155 155 assert !issue.save
156 156 assert_equal ["Database is not included in the list"], issue.errors.full_messages
157 157 # Valid value
158 158 issue.custom_field_values = { field.id => 'PostgreSQL' }
159 159 assert issue.save
160 160 issue.reload
161 161 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
162 162 end
163 163
164 164 def test_create_with_group_assignment
165 165 with_settings :issue_group_assignment => '1' do
166 166 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
167 167 :subject => 'Group assignment',
168 168 :assigned_to_id => 11).save
169 169 issue = Issue.order('id DESC').first
170 170 assert_kind_of Group, issue.assigned_to
171 171 assert_equal Group.find(11), issue.assigned_to
172 172 end
173 173 end
174 174
175 175 def test_create_with_parent_issue_id
176 176 issue = Issue.new(:project_id => 1, :tracker_id => 1,
177 177 :author_id => 1, :subject => 'Group assignment',
178 178 :parent_issue_id => 1)
179 179 assert_save issue
180 180 assert_equal 1, issue.parent_issue_id
181 181 assert_equal Issue.find(1), issue.parent
182 182 end
183 183
184 184 def test_create_with_sharp_parent_issue_id
185 185 issue = Issue.new(:project_id => 1, :tracker_id => 1,
186 186 :author_id => 1, :subject => 'Group assignment',
187 187 :parent_issue_id => "#1")
188 188 assert_save issue
189 189 assert_equal 1, issue.parent_issue_id
190 190 assert_equal Issue.find(1), issue.parent
191 191 end
192 192
193 193 def test_create_with_invalid_parent_issue_id
194 194 set_language_if_valid 'en'
195 195 issue = Issue.new(:project_id => 1, :tracker_id => 1,
196 196 :author_id => 1, :subject => 'Group assignment',
197 197 :parent_issue_id => '01ABC')
198 198 assert !issue.save
199 199 assert_equal '01ABC', issue.parent_issue_id
200 200 assert_include 'Parent task is invalid', issue.errors.full_messages
201 201 end
202 202
203 203 def test_create_with_invalid_sharp_parent_issue_id
204 204 set_language_if_valid 'en'
205 205 issue = Issue.new(:project_id => 1, :tracker_id => 1,
206 206 :author_id => 1, :subject => 'Group assignment',
207 207 :parent_issue_id => '#01ABC')
208 208 assert !issue.save
209 209 assert_equal '#01ABC', issue.parent_issue_id
210 210 assert_include 'Parent task is invalid', issue.errors.full_messages
211 211 end
212 212
213 213 def assert_visibility_match(user, issues)
214 214 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
215 215 end
216 216
217 217 def test_visible_scope_for_anonymous
218 218 # Anonymous user should see issues of public projects only
219 219 issues = Issue.visible(User.anonymous).to_a
220 220 assert issues.any?
221 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 222 assert_nil issues.detect {|issue| issue.is_private?}
223 223 assert_visibility_match User.anonymous, issues
224 224 end
225 225
226 226 def test_visible_scope_for_anonymous_without_view_issues_permissions
227 227 # Anonymous user should not see issues without permission
228 228 Role.anonymous.remove_permission!(:view_issues)
229 229 issues = Issue.visible(User.anonymous).to_a
230 230 assert issues.empty?
231 231 assert_visibility_match User.anonymous, issues
232 232 end
233 233
234 234 def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
235 235 Role.anonymous.remove_permission!(:view_issues)
236 236 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
237 237
238 238 issues = Issue.visible(User.anonymous).all
239 239 assert issues.any?
240 240 assert_equal [1], issues.map(&:project_id).uniq.sort
241 241 assert_visibility_match User.anonymous, issues
242 242 end
243 243
244 244 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
245 245 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
246 246 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
247 247 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
248 248 assert !issue.visible?(User.anonymous)
249 249 end
250 250
251 251 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
252 252 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
253 253 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
254 254 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
255 255 assert !issue.visible?(User.anonymous)
256 256 end
257 257
258 258 def test_visible_scope_for_non_member
259 259 user = User.find(9)
260 260 assert user.projects.empty?
261 261 # Non member user should see issues of public projects only
262 262 issues = Issue.visible(user).to_a
263 263 assert issues.any?
264 264 assert_nil issues.detect {|issue| !issue.project.is_public?}
265 265 assert_nil issues.detect {|issue| issue.is_private?}
266 266 assert_visibility_match user, issues
267 267 end
268 268
269 269 def test_visible_scope_for_non_member_with_own_issues_visibility
270 270 Role.non_member.update_attribute :issues_visibility, 'own'
271 271 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
272 272 user = User.find(9)
273 273
274 274 issues = Issue.visible(user).to_a
275 275 assert issues.any?
276 276 assert_nil issues.detect {|issue| issue.author != user}
277 277 assert_visibility_match user, issues
278 278 end
279 279
280 280 def test_visible_scope_for_non_member_without_view_issues_permissions
281 281 # Non member user should not see issues without permission
282 282 Role.non_member.remove_permission!(:view_issues)
283 283 user = User.find(9)
284 284 assert user.projects.empty?
285 285 issues = Issue.visible(user).to_a
286 286 assert issues.empty?
287 287 assert_visibility_match user, issues
288 288 end
289 289
290 290 def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
291 291 Role.non_member.remove_permission!(:view_issues)
292 292 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
293 293 user = User.find(9)
294 294
295 295 issues = Issue.visible(user).all
296 296 assert issues.any?
297 297 assert_equal [1], issues.map(&:project_id).uniq.sort
298 298 assert_visibility_match user, issues
299 299 end
300 300
301 301 def test_visible_scope_for_member
302 302 user = User.find(9)
303 303 # User should see issues of projects for which user has view_issues permissions only
304 304 Role.non_member.remove_permission!(:view_issues)
305 305 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
306 306 issues = Issue.visible(user).to_a
307 307 assert issues.any?
308 308 assert_nil issues.detect {|issue| issue.project_id != 3}
309 309 assert_nil issues.detect {|issue| issue.is_private?}
310 310 assert_visibility_match user, issues
311 311 end
312 312
313 313 def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
314 314 Role.non_member.add_permission!(:view_issues)
315 315 Role.find(1).remove_permission!(:view_issues)
316 316 user = User.find(2)
317 317
318 318 assert_equal 0, Issue.where(:project_id => 1).visible(user).count
319 319 assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
320 320 end
321 321
322 322 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
323 323 user = User.find(8)
324 324 assert user.groups.any?
325 325 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
326 326 Role.non_member.remove_permission!(:view_issues)
327 327
328 328 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
329 329 :status_id => 1, :priority => IssuePriority.all.first,
330 330 :subject => 'Assignment test',
331 331 :assigned_to => user.groups.first,
332 332 :is_private => true)
333 333
334 334 Role.find(2).update_attribute :issues_visibility, 'default'
335 335 issues = Issue.visible(User.find(8)).to_a
336 336 assert issues.any?
337 337 assert issues.include?(issue)
338 338
339 339 Role.find(2).update_attribute :issues_visibility, 'own'
340 340 issues = Issue.visible(User.find(8)).to_a
341 341 assert issues.any?
342 342 assert_include issue, issues
343 343 end
344 344
345 345 def test_visible_scope_for_admin
346 346 user = User.find(1)
347 347 user.members.each(&:destroy)
348 348 assert user.projects.empty?
349 349 issues = Issue.visible(user).to_a
350 350 assert issues.any?
351 351 # Admin should see issues on private projects that admin does not belong to
352 352 assert issues.detect {|issue| !issue.project.is_public?}
353 353 # Admin should see private issues of other users
354 354 assert issues.detect {|issue| issue.is_private? && issue.author != user}
355 355 assert_visibility_match user, issues
356 356 end
357 357
358 358 def test_visible_scope_with_project
359 359 project = Project.find(1)
360 360 issues = Issue.visible(User.find(2), :project => project).to_a
361 361 projects = issues.collect(&:project).uniq
362 362 assert_equal 1, projects.size
363 363 assert_equal project, projects.first
364 364 end
365 365
366 366 def test_visible_scope_with_project_and_subprojects
367 367 project = Project.find(1)
368 368 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
369 369 projects = issues.collect(&:project).uniq
370 370 assert projects.size > 1
371 371 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
372 372 end
373 373
374 374 def test_visible_and_nested_set_scopes
375 375 user = User.generate!
376 376 parent = Issue.generate!(:assigned_to => user)
377 377 assert parent.visible?(user)
378 378 child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
379 379 child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
380 380 parent.reload
381 381 child1.reload
382 382 child2.reload
383 383 assert child1.visible?(user)
384 384 assert child2.visible?(user)
385 385 assert_equal 2, parent.descendants.count
386 386 assert_equal 2, parent.descendants.visible(user).count
387 387 # awesome_nested_set 2-1-stable branch has regression.
388 388 # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
389 389 # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
390 390 assert_equal 2, parent.descendants.collect{|i| i}.size
391 391 assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
392 392 end
393 393
394 394 def test_visible_scope_with_unsaved_user_should_not_raise_an_error
395 395 user = User.new
396 396 assert_nothing_raised do
397 397 Issue.visible(user).to_a
398 398 end
399 399 end
400 400
401 401 def test_open_scope
402 402 issues = Issue.open.to_a
403 403 assert_nil issues.detect(&:closed?)
404 404 end
405 405
406 406 def test_open_scope_with_arg
407 407 issues = Issue.open(false).to_a
408 408 assert_equal issues, issues.select(&:closed?)
409 409 end
410 410
411 411 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
412 412 version = Version.find(2)
413 413 assert version.fixed_issues.any?
414 414 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
415 415 end
416 416
417 417 def test_fixed_version_scope_with_empty_array_should_return_no_result
418 418 assert_equal 0, Issue.fixed_version([]).count
419 419 end
420 420
421 421 def test_errors_full_messages_should_include_custom_fields_errors
422 422 field = IssueCustomField.find_by_name('Database')
423 423
424 424 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
425 425 :status_id => 1, :subject => 'test_create',
426 426 :description => 'IssueTest#test_create_with_required_custom_field')
427 427 assert issue.available_custom_fields.include?(field)
428 428 # Invalid value
429 429 issue.custom_field_values = { field.id => 'SQLServer' }
430 430
431 431 assert !issue.valid?
432 432 assert_equal 1, issue.errors.full_messages.size
433 433 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
434 434 issue.errors.full_messages.first
435 435 end
436 436
437 437 def test_update_issue_with_required_custom_field
438 438 field = IssueCustomField.find_by_name('Database')
439 439 field.update_attribute(:is_required, true)
440 440
441 441 issue = Issue.find(1)
442 442 assert_nil issue.custom_value_for(field)
443 443 assert issue.available_custom_fields.include?(field)
444 444 # No change to custom values, issue can be saved
445 445 assert issue.save
446 446 # Blank value
447 447 issue.custom_field_values = { field.id => '' }
448 448 assert !issue.save
449 449 # Valid value
450 450 issue.custom_field_values = { field.id => 'PostgreSQL' }
451 451 assert issue.save
452 452 issue.reload
453 453 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
454 454 end
455 455
456 456 def test_should_not_update_attributes_if_custom_fields_validation_fails
457 457 issue = Issue.find(1)
458 458 field = IssueCustomField.find_by_name('Database')
459 459 assert issue.available_custom_fields.include?(field)
460 460
461 461 issue.custom_field_values = { field.id => 'Invalid' }
462 462 issue.subject = 'Should be not be saved'
463 463 assert !issue.save
464 464
465 465 issue.reload
466 466 assert_equal "Cannot print recipes", issue.subject
467 467 end
468 468
469 469 def test_should_not_recreate_custom_values_objects_on_update
470 470 field = IssueCustomField.find_by_name('Database')
471 471
472 472 issue = Issue.find(1)
473 473 issue.custom_field_values = { field.id => 'PostgreSQL' }
474 474 assert issue.save
475 475 custom_value = issue.custom_value_for(field)
476 476 issue.reload
477 477 issue.custom_field_values = { field.id => 'MySQL' }
478 478 assert issue.save
479 479 issue.reload
480 480 assert_equal custom_value.id, issue.custom_value_for(field).id
481 481 end
482 482
483 483 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
484 484 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
485 485 :status_id => 1, :subject => 'Test',
486 486 :custom_field_values => {'2' => 'Test'})
487 487 assert !Tracker.find(2).custom_field_ids.include?(2)
488 488
489 489 issue = Issue.find(issue.id)
490 490 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
491 491
492 492 issue = Issue.find(issue.id)
493 493 custom_value = issue.custom_value_for(2)
494 494 assert_not_nil custom_value
495 495 assert_equal 'Test', custom_value.value
496 496 end
497 497
498 498 def test_assigning_tracker_id_should_reload_custom_fields_values
499 499 issue = Issue.new(:project => Project.find(1))
500 500 assert issue.custom_field_values.empty?
501 501 issue.tracker_id = 1
502 502 assert issue.custom_field_values.any?
503 503 end
504 504
505 505 def test_assigning_attributes_should_assign_project_and_tracker_first
506 506 seq = sequence('seq')
507 507 issue = Issue.new
508 508 issue.expects(:project_id=).in_sequence(seq)
509 509 issue.expects(:tracker_id=).in_sequence(seq)
510 510 issue.expects(:subject=).in_sequence(seq)
511 511 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
512 512 end
513 513
514 514 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
515 515 attributes = ActiveSupport::OrderedHash.new
516 516 attributes['custom_field_values'] = { '1' => 'MySQL' }
517 517 attributes['tracker_id'] = '1'
518 518 issue = Issue.new(:project => Project.find(1))
519 519 issue.attributes = attributes
520 520 assert_equal 'MySQL', issue.custom_field_value(1)
521 521 end
522 522
523 523 def test_changing_tracker_should_clear_disabled_core_fields
524 524 tracker = Tracker.find(2)
525 525 tracker.core_fields = tracker.core_fields - %w(due_date)
526 526 tracker.save!
527 527
528 528 issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
529 529 issue.save!
530 530
531 531 issue.tracker_id = 2
532 532 issue.save!
533 533 assert_not_nil issue.start_date
534 534 assert_nil issue.due_date
535 535 end
536 536
537 537 def test_changing_tracker_should_not_add_cleared_fields_to_journal
538 538 tracker = Tracker.find(2)
539 539 tracker.core_fields = tracker.core_fields - %w(due_date)
540 540 tracker.save!
541 541
542 542 issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
543 543 issue.save!
544 544
545 545 assert_difference 'Journal.count' do
546 546 issue.init_journal User.find(1)
547 547 issue.tracker_id = 2
548 548 issue.save!
549 549 assert_nil issue.due_date
550 550 end
551 551 journal = Journal.order('id DESC').first
552 552 assert_equal 1, journal.details.count
553 553 end
554 554
555 555 def test_reload_should_reload_custom_field_values
556 556 issue = Issue.generate!
557 557 issue.custom_field_values = {'2' => 'Foo'}
558 558 issue.save!
559 559
560 560 issue = Issue.order('id desc').first
561 561 assert_equal 'Foo', issue.custom_field_value(2)
562 562
563 563 issue.custom_field_values = {'2' => 'Bar'}
564 564 assert_equal 'Bar', issue.custom_field_value(2)
565 565
566 566 issue.reload
567 567 assert_equal 'Foo', issue.custom_field_value(2)
568 568 end
569 569
570 570 def test_should_update_issue_with_disabled_tracker
571 571 p = Project.find(1)
572 572 issue = Issue.find(1)
573 573
574 574 p.trackers.delete(issue.tracker)
575 575 assert !p.trackers.include?(issue.tracker)
576 576
577 577 issue.reload
578 578 issue.subject = 'New subject'
579 579 assert issue.save
580 580 end
581 581
582 582 def test_should_not_set_a_disabled_tracker
583 583 p = Project.find(1)
584 584 p.trackers.delete(Tracker.find(2))
585 585
586 586 issue = Issue.find(1)
587 587 issue.tracker_id = 2
588 588 issue.subject = 'New subject'
589 589 assert !issue.save
590 590 assert_not_equal [], issue.errors[:tracker_id]
591 591 end
592 592
593 593 def test_category_based_assignment
594 594 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
595 595 :status_id => 1, :priority => IssuePriority.all.first,
596 596 :subject => 'Assignment test',
597 597 :description => 'Assignment test', :category_id => 1)
598 598 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
599 599 end
600 600
601 601 def test_new_statuses_allowed_to
602 602 WorkflowTransition.delete_all
603 603 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
604 604 :old_status_id => 1, :new_status_id => 2,
605 605 :author => false, :assignee => false)
606 606 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
607 607 :old_status_id => 1, :new_status_id => 3,
608 608 :author => true, :assignee => false)
609 609 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
610 610 :old_status_id => 1, :new_status_id => 4,
611 611 :author => false, :assignee => true)
612 612 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
613 613 :old_status_id => 1, :new_status_id => 5,
614 614 :author => true, :assignee => true)
615 615 status = IssueStatus.find(1)
616 616 role = Role.find(1)
617 617 tracker = Tracker.find(1)
618 618 user = User.find(2)
619 619
620 620 issue = Issue.generate!(:tracker => tracker, :status => status,
621 621 :project_id => 1, :author_id => 1)
622 622 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
623 623
624 624 issue = Issue.generate!(:tracker => tracker, :status => status,
625 625 :project_id => 1, :author => user)
626 626 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
627 627
628 628 issue = Issue.generate!(:tracker => tracker, :status => status,
629 629 :project_id => 1, :author_id => 1,
630 630 :assigned_to => user)
631 631 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
632 632
633 633 issue = Issue.generate!(:tracker => tracker, :status => status,
634 634 :project_id => 1, :author => user,
635 635 :assigned_to => user)
636 636 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
637 637
638 638 group = Group.generate!
639 639 group.users << user
640 640 issue = Issue.generate!(:tracker => tracker, :status => status,
641 641 :project_id => 1, :author => user,
642 642 :assigned_to => group)
643 643 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
644 644 end
645 645
646 646 def test_new_statuses_allowed_to_should_consider_group_assignment
647 647 WorkflowTransition.delete_all
648 648 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
649 649 :old_status_id => 1, :new_status_id => 4,
650 650 :author => false, :assignee => true)
651 651 user = User.find(2)
652 652 group = Group.generate!
653 653 group.users << user
654 654
655 655 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
656 656 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
657 657 end
658 658
659 659 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
660 660 admin = User.find(1)
661 661 issue = Issue.find(1)
662 662 assert !admin.member_of?(issue.project)
663 663 expected_statuses = [issue.status] +
664 664 WorkflowTransition.where(:old_status_id => issue.status_id).
665 665 map(&:new_status).uniq.sort
666 666 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
667 667 end
668 668
669 669 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
670 670 issue = Issue.find(1).copy
671 671 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
672 672
673 673 issue = Issue.find(2).copy
674 674 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
675 675 end
676 676
677 677 def test_safe_attributes_names_should_not_include_disabled_field
678 678 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
679 679
680 680 issue = Issue.new(:tracker => tracker)
681 681 assert_include 'tracker_id', issue.safe_attribute_names
682 682 assert_include 'status_id', issue.safe_attribute_names
683 683 assert_include 'subject', issue.safe_attribute_names
684 684 assert_include 'description', issue.safe_attribute_names
685 685 assert_include 'custom_field_values', issue.safe_attribute_names
686 686 assert_include 'custom_fields', issue.safe_attribute_names
687 687 assert_include 'lock_version', issue.safe_attribute_names
688 688
689 689 tracker.core_fields.each do |field|
690 690 assert_include field, issue.safe_attribute_names
691 691 end
692 692
693 693 tracker.disabled_core_fields.each do |field|
694 694 assert_not_include field, issue.safe_attribute_names
695 695 end
696 696 end
697 697
698 698 def test_safe_attributes_should_ignore_disabled_fields
699 699 tracker = Tracker.find(1)
700 700 tracker.core_fields = %w(assigned_to_id due_date)
701 701 tracker.save!
702 702
703 703 issue = Issue.new(:tracker => tracker)
704 704 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
705 705 assert_nil issue.start_date
706 706 assert_equal Date.parse('2012-07-14'), issue.due_date
707 707 end
708 708
709 709 def test_safe_attributes_should_accept_target_tracker_enabled_fields
710 710 source = Tracker.find(1)
711 711 source.core_fields = []
712 712 source.save!
713 713 target = Tracker.find(2)
714 714 target.core_fields = %w(assigned_to_id due_date)
715 715 target.save!
716 716
717 717 issue = Issue.new(:tracker => source)
718 718 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
719 719 assert_equal target, issue.tracker
720 720 assert_equal Date.parse('2012-07-14'), issue.due_date
721 721 end
722 722
723 723 def test_safe_attributes_should_not_include_readonly_fields
724 724 WorkflowPermission.delete_all
725 725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
726 726 :role_id => 1, :field_name => 'due_date',
727 727 :rule => 'readonly')
728 728 user = User.find(2)
729 729
730 730 issue = Issue.new(:project_id => 1, :tracker_id => 1)
731 731 assert_equal %w(due_date), issue.read_only_attribute_names(user)
732 732 assert_not_include 'due_date', issue.safe_attribute_names(user)
733 733
734 734 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
735 735 assert_equal Date.parse('2012-07-14'), issue.start_date
736 736 assert_nil issue.due_date
737 737 end
738 738
739 739 def test_safe_attributes_should_not_include_readonly_custom_fields
740 740 cf1 = IssueCustomField.create!(:name => 'Writable field',
741 741 :field_format => 'string',
742 742 :is_for_all => true, :tracker_ids => [1])
743 743 cf2 = IssueCustomField.create!(:name => 'Readonly field',
744 744 :field_format => 'string',
745 745 :is_for_all => true, :tracker_ids => [1])
746 746 WorkflowPermission.delete_all
747 747 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
748 748 :role_id => 1, :field_name => cf2.id.to_s,
749 749 :rule => 'readonly')
750 750 user = User.find(2)
751 751 issue = Issue.new(:project_id => 1, :tracker_id => 1)
752 752 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
753 753 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
754 754
755 755 issue.send :safe_attributes=, {'custom_field_values' => {
756 756 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
757 757 }}, user
758 758 assert_equal 'value1', issue.custom_field_value(cf1)
759 759 assert_nil issue.custom_field_value(cf2)
760 760
761 761 issue.send :safe_attributes=, {'custom_fields' => [
762 762 {'id' => cf1.id.to_s, 'value' => 'valuea'},
763 763 {'id' => cf2.id.to_s, 'value' => 'valueb'}
764 764 ]}, user
765 765 assert_equal 'valuea', issue.custom_field_value(cf1)
766 766 assert_nil issue.custom_field_value(cf2)
767 767 end
768 768
769 def test_safe_attributes_should_ignore_unassignable_assignee
770 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
771 :status_id => 1, :priority => IssuePriority.all.first,
772 :subject => 'test_create')
773 assert issue.valid?
774
775 # locked user, not allowed
776 issue.safe_attributes=({'assigned_to_id' => '5'})
777 assert_nil issue.assigned_to_id
778 # no member
779 issue.safe_attributes=({'assigned_to_id' => '1'})
780 assert_nil issue.assigned_to_id
781 # user 2 is ok
782 issue.safe_attributes=({'assigned_to_id' => '2'})
783 assert_equal 2, issue.assigned_to_id
784 assert issue.save
785
786 issue.reload
787 assert_equal 2, issue.assigned_to_id
788 issue.safe_attributes=({'assigned_to_id' => '5'})
789 assert_equal 2, issue.assigned_to_id
790 issue.safe_attributes=({'assigned_to_id' => '1'})
791 assert_equal 2, issue.assigned_to_id
792 # user 3 is also ok
793 issue.safe_attributes=({'assigned_to_id' => '3'})
794 assert_equal 3, issue.assigned_to_id
795 assert issue.save
796
797 # removal of assignee
798 issue.safe_attributes=({'assigned_to_id' => ''})
799 assert_nil issue.assigned_to_id
800 assert issue.save
801 end
802
769 803 def test_editable_custom_field_values_should_return_non_readonly_custom_values
770 804 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
771 805 :is_for_all => true, :tracker_ids => [1, 2])
772 806 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
773 807 :is_for_all => true, :tracker_ids => [1, 2])
774 808 WorkflowPermission.delete_all
775 809 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
776 810 :field_name => cf2.id.to_s, :rule => 'readonly')
777 811 user = User.find(2)
778 812
779 813 issue = Issue.new(:project_id => 1, :tracker_id => 1)
780 814 values = issue.editable_custom_field_values(user)
781 815 assert values.detect {|value| value.custom_field == cf1}
782 816 assert_nil values.detect {|value| value.custom_field == cf2}
783 817
784 818 issue.tracker_id = 2
785 819 values = issue.editable_custom_field_values(user)
786 820 assert values.detect {|value| value.custom_field == cf1}
787 821 assert values.detect {|value| value.custom_field == cf2}
788 822 end
789 823
790 824 def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
791 825 enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
792 826 disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
793 827 user = User.find(2)
794 828 issue = Issue.new(:project_id => 1, :tracker_id => 1)
795 829
796 830 assert_include enabled_cf, issue.editable_custom_fields(user)
797 831 assert_not_include disabled_cf, issue.editable_custom_fields(user)
798 832 end
799 833
800 834 def test_safe_attributes_should_accept_target_tracker_writable_fields
801 835 WorkflowPermission.delete_all
802 836 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
803 837 :role_id => 1, :field_name => 'due_date',
804 838 :rule => 'readonly')
805 839 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
806 840 :role_id => 1, :field_name => 'start_date',
807 841 :rule => 'readonly')
808 842 user = User.find(2)
809 843
810 844 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
811 845
812 846 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
813 847 'due_date' => '2012-07-14'}, user
814 848 assert_equal Date.parse('2012-07-12'), issue.start_date
815 849 assert_nil issue.due_date
816 850
817 851 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
818 852 'due_date' => '2012-07-16',
819 853 'tracker_id' => 2}, user
820 854 assert_equal Date.parse('2012-07-12'), issue.start_date
821 855 assert_equal Date.parse('2012-07-16'), issue.due_date
822 856 end
823 857
824 858 def test_safe_attributes_should_accept_target_status_writable_fields
825 859 WorkflowPermission.delete_all
826 860 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
827 861 :role_id => 1, :field_name => 'due_date',
828 862 :rule => 'readonly')
829 863 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
830 864 :role_id => 1, :field_name => 'start_date',
831 865 :rule => 'readonly')
832 866 user = User.find(2)
833 867
834 868 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
835 869
836 870 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
837 871 'due_date' => '2012-07-14'},
838 872 user
839 873 assert_equal Date.parse('2012-07-12'), issue.start_date
840 874 assert_nil issue.due_date
841 875
842 876 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
843 877 'due_date' => '2012-07-16',
844 878 'status_id' => 2},
845 879 user
846 880 assert_equal Date.parse('2012-07-12'), issue.start_date
847 881 assert_equal Date.parse('2012-07-16'), issue.due_date
848 882 end
849 883
850 884 def test_required_attributes_should_be_validated
851 885 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
852 886 :is_for_all => true, :tracker_ids => [1, 2])
853 887
854 888 WorkflowPermission.delete_all
855 889 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
856 890 :role_id => 1, :field_name => 'due_date',
857 891 :rule => 'required')
858 892 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
859 893 :role_id => 1, :field_name => 'category_id',
860 894 :rule => 'required')
861 895 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
862 896 :role_id => 1, :field_name => cf.id.to_s,
863 897 :rule => 'required')
864 898
865 899 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
866 900 :role_id => 1, :field_name => 'start_date',
867 901 :rule => 'required')
868 902 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
869 903 :role_id => 1, :field_name => cf.id.to_s,
870 904 :rule => 'required')
871 905 user = User.find(2)
872 906
873 907 issue = Issue.new(:project_id => 1, :tracker_id => 1,
874 908 :status_id => 1, :subject => 'Required fields',
875 909 :author => user)
876 910 assert_equal [cf.id.to_s, "category_id", "due_date"],
877 911 issue.required_attribute_names(user).sort
878 912 assert !issue.save, "Issue was saved"
879 913 assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
880 914 issue.errors.full_messages.sort
881 915
882 916 issue.tracker_id = 2
883 917 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
884 918 assert !issue.save, "Issue was saved"
885 919 assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
886 920 issue.errors.full_messages.sort
887 921
888 922 issue.start_date = Date.today
889 923 issue.custom_field_values = {cf.id.to_s => 'bar'}
890 924 assert issue.save
891 925 end
892 926
893 927 def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
894 928 WorkflowPermission.delete_all
895 929 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
896 930 :role_id => 1, :field_name => 'start_date',
897 931 :rule => 'required')
898 932 user = User.find(2)
899 933
900 934 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
901 935 :subject => 'Required fields', :author => user)
902 936 assert !issue.save
903 937 assert_include "Start date cannot be blank", issue.errors.full_messages
904 938
905 939 tracker = Tracker.find(1)
906 940 tracker.core_fields -= %w(start_date)
907 941 tracker.save!
908 942 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
909 943 :subject => 'Required fields', :author => user)
910 944 assert issue.save
911 945 end
912 946
913 947 def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
914 948 CustomField.delete_all
915 949 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
916 950 user = User.generate!
917 951 User.add_to_project(user, Project.find(1), Role.find(2))
918 952
919 953 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
920 954 :subject => 'Required fields', :author => user)
921 955 assert_save issue
922 956 end
923 957
924 958 def test_required_custom_field_that_is_visible_for_the_user_should_be_required
925 959 CustomField.delete_all
926 960 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
927 961 user = User.generate!
928 962 User.add_to_project(user, Project.find(1), Role.find(1))
929 963
930 964 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
931 965 :subject => 'Required fields', :author => user)
932 966 assert !issue.save
933 967 assert_include "#{field.name} cannot be blank", issue.errors.full_messages
934 968 end
935 969
936 970 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
937 971 WorkflowPermission.delete_all
938 972 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
939 973 :role_id => 1, :field_name => 'due_date',
940 974 :rule => 'required')
941 975 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
942 976 :role_id => 1, :field_name => 'start_date',
943 977 :rule => 'required')
944 978 user = User.find(2)
945 979 member = Member.find(1)
946 980 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
947 981
948 982 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
949 983
950 984 member.role_ids = [1, 2]
951 985 member.save!
952 986 assert_equal [], issue.required_attribute_names(user.reload)
953 987
954 988 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
955 989 :role_id => 2, :field_name => 'due_date',
956 990 :rule => 'required')
957 991 assert_equal %w(due_date), issue.required_attribute_names(user)
958 992
959 993 member.role_ids = [1, 2, 3]
960 994 member.save!
961 995 assert_equal [], issue.required_attribute_names(user.reload)
962 996
963 997 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
964 998 :role_id => 3, :field_name => 'due_date',
965 999 :rule => 'readonly')
966 1000 # required + readonly => required
967 1001 assert_equal %w(due_date), issue.required_attribute_names(user)
968 1002 end
969 1003
970 1004 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
971 1005 WorkflowPermission.delete_all
972 1006 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
973 1007 :role_id => 1, :field_name => 'due_date',
974 1008 :rule => 'readonly')
975 1009 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
976 1010 :role_id => 1, :field_name => 'start_date',
977 1011 :rule => 'readonly')
978 1012 user = User.find(2)
979 1013 member = Member.find(1)
980 1014 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
981 1015
982 1016 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
983 1017
984 1018 member.role_ids = [1, 2]
985 1019 member.save!
986 1020 assert_equal [], issue.read_only_attribute_names(user.reload)
987 1021
988 1022 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
989 1023 :role_id => 2, :field_name => 'due_date',
990 1024 :rule => 'readonly')
991 1025 assert_equal %w(due_date), issue.read_only_attribute_names(user)
992 1026 end
993 1027
994 1028 # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
995 1029 def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
996 1030 field = IssueCustomField.generate!(
997 1031 :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
998 1032 )
999 1033 WorkflowPermission.delete_all
1000 1034 WorkflowPermission.create!(
1001 1035 :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
1002 1036 )
1003 1037 user = User.generate!
1004 1038 project = Project.find(1)
1005 1039 User.add_to_project(user, project, Role.where(:id => [1, 2]))
1006 1040
1007 1041 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1008 1042 assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
1009 1043 end
1010 1044
1011 1045 def test_workflow_rules_should_ignore_roles_without_issue_permissions
1012 1046 role = Role.generate! :permissions => [:view_issues, :edit_issues]
1013 1047 ignored_role = Role.generate! :permissions => [:view_issues]
1014 1048
1015 1049 WorkflowPermission.delete_all
1016 1050 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1017 1051 :role => role, :field_name => 'due_date',
1018 1052 :rule => 'required')
1019 1053 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1020 1054 :role => role, :field_name => 'start_date',
1021 1055 :rule => 'readonly')
1022 1056 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1023 1057 :role => role, :field_name => 'done_ratio',
1024 1058 :rule => 'readonly')
1025 1059 user = User.generate!
1026 1060 User.add_to_project user, Project.find(1), [role, ignored_role]
1027 1061
1028 1062 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1029 1063
1030 1064 assert_equal %w(due_date), issue.required_attribute_names(user)
1031 1065 assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
1032 1066 end
1033 1067
1034 1068 def test_workflow_rules_should_work_for_member_with_duplicate_role
1035 1069 WorkflowPermission.delete_all
1036 1070 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1037 1071 :role_id => 1, :field_name => 'due_date',
1038 1072 :rule => 'required')
1039 1073 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1040 1074 :role_id => 1, :field_name => 'start_date',
1041 1075 :rule => 'readonly')
1042 1076
1043 1077 user = User.generate!
1044 1078 m = Member.new(:user_id => user.id, :project_id => 1)
1045 1079 m.member_roles.build(:role_id => 1)
1046 1080 m.member_roles.build(:role_id => 1)
1047 1081 m.save!
1048 1082
1049 1083 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1050 1084
1051 1085 assert_equal %w(due_date), issue.required_attribute_names(user)
1052 1086 assert_equal %w(start_date), issue.read_only_attribute_names(user)
1053 1087 end
1054 1088
1055 1089 def test_copy
1056 1090 issue = Issue.new.copy_from(1)
1057 1091 assert issue.copy?
1058 1092 assert issue.save
1059 1093 issue.reload
1060 1094 orig = Issue.find(1)
1061 1095 assert_equal orig.subject, issue.subject
1062 1096 assert_equal orig.tracker, issue.tracker
1063 1097 assert_equal "125", issue.custom_value_for(2).value
1064 1098 end
1065 1099
1066 1100 def test_copy_should_copy_status
1067 1101 orig = Issue.find(8)
1068 1102 assert orig.status != orig.default_status
1069 1103
1070 1104 issue = Issue.new.copy_from(orig)
1071 1105 assert issue.save
1072 1106 issue.reload
1073 1107 assert_equal orig.status, issue.status
1074 1108 end
1075 1109
1076 1110 def test_copy_should_add_relation_with_copied_issue
1077 1111 copied = Issue.find(1)
1078 1112 issue = Issue.new.copy_from(copied)
1079 1113 assert issue.save
1080 1114 issue.reload
1081 1115
1082 1116 assert_equal 1, issue.relations.size
1083 1117 relation = issue.relations.first
1084 1118 assert_equal 'copied_to', relation.relation_type
1085 1119 assert_equal copied, relation.issue_from
1086 1120 assert_equal issue, relation.issue_to
1087 1121 end
1088 1122
1089 1123 def test_copy_should_copy_subtasks
1090 1124 issue = Issue.generate_with_descendants!
1091 1125
1092 1126 copy = issue.reload.copy
1093 1127 copy.author = User.find(7)
1094 1128 assert_difference 'Issue.count', 1+issue.descendants.count do
1095 1129 assert copy.save
1096 1130 end
1097 1131 copy.reload
1098 1132 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
1099 1133 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
1100 1134 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
1101 1135 assert_equal copy.author, child_copy.author
1102 1136 end
1103 1137
1104 1138 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
1105 1139 parent = Issue.generate!
1106 1140 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1107 1141 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1108 1142
1109 1143 copy = parent.reload.copy
1110 1144 copy.parent_issue_id = parent.id
1111 1145 copy.author = User.find(7)
1112 1146 assert_difference 'Issue.count', 3 do
1113 1147 assert copy.save
1114 1148 end
1115 1149 parent.reload
1116 1150 copy.reload
1117 1151 assert_equal parent, copy.parent
1118 1152 assert_equal 3, parent.children.count
1119 1153 assert_equal 5, parent.descendants.count
1120 1154 assert_equal 2, copy.children.count
1121 1155 assert_equal 2, copy.descendants.count
1122 1156 end
1123 1157
1124 1158 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
1125 1159 parent = Issue.generate!
1126 1160 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1127 1161 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1128 1162
1129 1163 copy = parent.reload.copy
1130 1164 copy.parent_issue_id = child1.id
1131 1165 copy.author = User.find(7)
1132 1166 assert_difference 'Issue.count', 3 do
1133 1167 assert copy.save
1134 1168 end
1135 1169 parent.reload
1136 1170 child1.reload
1137 1171 copy.reload
1138 1172 assert_equal child1, copy.parent
1139 1173 assert_equal 2, parent.children.count
1140 1174 assert_equal 5, parent.descendants.count
1141 1175 assert_equal 1, child1.children.count
1142 1176 assert_equal 3, child1.descendants.count
1143 1177 assert_equal 2, copy.children.count
1144 1178 assert_equal 2, copy.descendants.count
1145 1179 end
1146 1180
1147 1181 def test_copy_should_copy_subtasks_to_target_project
1148 1182 issue = Issue.generate_with_descendants!
1149 1183
1150 1184 copy = issue.copy(:project_id => 3)
1151 1185 assert_difference 'Issue.count', 1+issue.descendants.count do
1152 1186 assert copy.save
1153 1187 end
1154 1188 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
1155 1189 end
1156 1190
1157 1191 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
1158 1192 issue = Issue.generate_with_descendants!
1159 1193
1160 1194 copy = issue.reload.copy
1161 1195 assert_difference 'Issue.count', 1+issue.descendants.count do
1162 1196 assert copy.save
1163 1197 assert copy.save
1164 1198 end
1165 1199 end
1166 1200
1167 1201 def test_should_not_call_after_project_change_on_creation
1168 1202 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1169 1203 :subject => 'Test', :author_id => 1)
1170 1204 issue.expects(:after_project_change).never
1171 1205 issue.save!
1172 1206 end
1173 1207
1174 1208 def test_should_not_call_after_project_change_on_update
1175 1209 issue = Issue.find(1)
1176 1210 issue.project = Project.find(1)
1177 1211 issue.subject = 'No project change'
1178 1212 issue.expects(:after_project_change).never
1179 1213 issue.save!
1180 1214 end
1181 1215
1182 1216 def test_should_call_after_project_change_on_project_change
1183 1217 issue = Issue.find(1)
1184 1218 issue.project = Project.find(2)
1185 1219 issue.expects(:after_project_change).once
1186 1220 issue.save!
1187 1221 end
1188 1222
1189 1223 def test_adding_journal_should_update_timestamp
1190 1224 issue = Issue.find(1)
1191 1225 updated_on_was = issue.updated_on
1192 1226
1193 1227 issue.init_journal(User.first, "Adding notes")
1194 1228 assert_difference 'Journal.count' do
1195 1229 assert issue.save
1196 1230 end
1197 1231 issue.reload
1198 1232
1199 1233 assert_not_equal updated_on_was, issue.updated_on
1200 1234 end
1201 1235
1202 1236 def test_should_close_duplicates
1203 1237 # Create 3 issues
1204 1238 issue1 = Issue.generate!
1205 1239 issue2 = Issue.generate!
1206 1240 issue3 = Issue.generate!
1207 1241
1208 1242 # 2 is a dupe of 1
1209 1243 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
1210 1244 :relation_type => IssueRelation::TYPE_DUPLICATES)
1211 1245 # And 3 is a dupe of 2
1212 1246 # IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1213 1247 # :relation_type => IssueRelation::TYPE_DUPLICATES)
1214 1248 # And 3 is a dupe of 1 (circular duplicates)
1215 1249 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
1216 1250 :relation_type => IssueRelation::TYPE_DUPLICATES)
1217 1251
1218 1252 assert issue1.reload.duplicates.include?(issue2)
1219 1253
1220 1254 # Closing issue 1
1221 1255 issue1.init_journal(User.first, "Closing issue1")
1222 1256 issue1.status = IssueStatus.where(:is_closed => true).first
1223 1257 assert issue1.save
1224 1258 # 2 and 3 should be also closed
1225 1259 assert issue2.reload.closed?
1226 1260 assert issue3.reload.closed?
1227 1261 end
1228 1262
1229 1263 def test_should_close_duplicates_with_private_notes
1230 1264 issue = Issue.generate!
1231 1265 duplicate = Issue.generate!
1232 1266 IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
1233 1267 :relation_type => IssueRelation::TYPE_DUPLICATES)
1234 1268 assert issue.reload.duplicates.include?(duplicate)
1235 1269
1236 1270 # Closing issue with private notes
1237 1271 issue.init_journal(User.first, "Private notes")
1238 1272 issue.private_notes = true
1239 1273 issue.status = IssueStatus.where(:is_closed => true).first
1240 1274 assert_save issue
1241 1275
1242 1276 duplicate.reload
1243 1277 assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
1244 1278 assert_equal true, journal.private_notes
1245 1279 end
1246 1280
1247 1281 def test_should_not_close_duplicated_issue
1248 1282 issue1 = Issue.generate!
1249 1283 issue2 = Issue.generate!
1250 1284
1251 1285 # 2 is a dupe of 1
1252 1286 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
1253 1287 :relation_type => IssueRelation::TYPE_DUPLICATES)
1254 1288 # 2 is a dup of 1 but 1 is not a duplicate of 2
1255 1289 assert !issue2.reload.duplicates.include?(issue1)
1256 1290
1257 1291 # Closing issue 2
1258 1292 issue2.init_journal(User.first, "Closing issue2")
1259 1293 issue2.status = IssueStatus.where(:is_closed => true).first
1260 1294 assert issue2.save
1261 1295 # 1 should not be also closed
1262 1296 assert !issue1.reload.closed?
1263 1297 end
1264 1298
1265 1299 def test_assignable_versions
1266 1300 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1267 1301 :status_id => 1, :fixed_version_id => 1,
1268 1302 :subject => 'New issue')
1269 1303 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
1270 1304 end
1271 1305
1272 1306 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1273 1307 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1274 1308 :status_id => 1, :fixed_version_id => 1,
1275 1309 :subject => 'New issue')
1276 1310 assert !issue.save
1277 1311 assert_not_equal [], issue.errors[:fixed_version_id]
1278 1312 end
1279 1313
1280 1314 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1281 1315 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1282 1316 :status_id => 1, :fixed_version_id => 2,
1283 1317 :subject => 'New issue')
1284 1318 assert !issue.save
1285 1319 assert_not_equal [], issue.errors[:fixed_version_id]
1286 1320 end
1287 1321
1288 1322 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1289 1323 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1290 1324 :status_id => 1, :fixed_version_id => 3,
1291 1325 :subject => 'New issue')
1292 1326 assert issue.save
1293 1327 end
1294 1328
1295 1329 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1296 1330 issue = Issue.find(11)
1297 1331 assert_equal 'closed', issue.fixed_version.status
1298 1332 issue.subject = 'Subject changed'
1299 1333 assert issue.save
1300 1334 end
1301 1335
1302 1336 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1303 1337 issue = Issue.find(11)
1304 1338 issue.status_id = 1
1305 1339 assert !issue.save
1306 1340 assert_not_equal [], issue.errors[:base]
1307 1341 end
1308 1342
1309 1343 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1310 1344 issue = Issue.find(11)
1311 1345 issue.status_id = 1
1312 1346 issue.fixed_version_id = 3
1313 1347 assert issue.save
1314 1348 end
1315 1349
1316 1350 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1317 1351 issue = Issue.find(12)
1318 1352 assert_equal 'locked', issue.fixed_version.status
1319 1353 issue.status_id = 1
1320 1354 assert issue.save
1321 1355 end
1322 1356
1323 1357 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1324 1358 issue = Issue.find(2)
1325 1359 assert_equal 2, issue.fixed_version_id
1326 1360 issue.project_id = 3
1327 1361 assert_nil issue.fixed_version_id
1328 1362 issue.fixed_version_id = 2
1329 1363 assert !issue.save
1330 1364 assert_include 'Target version is not included in the list', issue.errors.full_messages
1331 1365 end
1332 1366
1333 1367 def test_should_keep_shared_version_when_changing_project
1334 1368 Version.find(2).update_attribute :sharing, 'tree'
1335 1369
1336 1370 issue = Issue.find(2)
1337 1371 assert_equal 2, issue.fixed_version_id
1338 1372 issue.project_id = 3
1339 1373 assert_equal 2, issue.fixed_version_id
1340 1374 assert issue.save
1341 1375 end
1342 1376
1343 1377 def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
1344 1378 assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1345 1379 end
1346 1380
1347 1381 def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
1348 1382 Project.find(2).disable_module! :issue_tracking
1349 1383 assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1350 1384 end
1351 1385
1352 1386 def test_move_to_another_project_with_same_category
1353 1387 issue = Issue.find(1)
1354 1388 issue.project = Project.find(2)
1355 1389 assert issue.save
1356 1390 issue.reload
1357 1391 assert_equal 2, issue.project_id
1358 1392 # Category changes
1359 1393 assert_equal 4, issue.category_id
1360 1394 # Make sure time entries were move to the target project
1361 1395 assert_equal 2, issue.time_entries.first.project_id
1362 1396 end
1363 1397
1364 1398 def test_move_to_another_project_without_same_category
1365 1399 issue = Issue.find(2)
1366 1400 issue.project = Project.find(2)
1367 1401 assert issue.save
1368 1402 issue.reload
1369 1403 assert_equal 2, issue.project_id
1370 1404 # Category cleared
1371 1405 assert_nil issue.category_id
1372 1406 end
1373 1407
1374 1408 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1375 1409 issue = Issue.find(1)
1376 1410 issue.update_attribute(:fixed_version_id, 1)
1377 1411 issue.project = Project.find(2)
1378 1412 assert issue.save
1379 1413 issue.reload
1380 1414 assert_equal 2, issue.project_id
1381 1415 # Cleared fixed_version
1382 1416 assert_equal nil, issue.fixed_version
1383 1417 end
1384 1418
1385 1419 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1386 1420 issue = Issue.find(1)
1387 1421 issue.update_attribute(:fixed_version_id, 4)
1388 1422 issue.project = Project.find(5)
1389 1423 assert issue.save
1390 1424 issue.reload
1391 1425 assert_equal 5, issue.project_id
1392 1426 # Keep fixed_version
1393 1427 assert_equal 4, issue.fixed_version_id
1394 1428 end
1395 1429
1396 1430 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1397 1431 issue = Issue.find(1)
1398 1432 issue.update_attribute(:fixed_version_id, 1)
1399 1433 issue.project = Project.find(5)
1400 1434 assert issue.save
1401 1435 issue.reload
1402 1436 assert_equal 5, issue.project_id
1403 1437 # Cleared fixed_version
1404 1438 assert_equal nil, issue.fixed_version
1405 1439 end
1406 1440
1407 1441 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1408 1442 issue = Issue.find(1)
1409 1443 issue.update_attribute(:fixed_version_id, 7)
1410 1444 issue.project = Project.find(2)
1411 1445 assert issue.save
1412 1446 issue.reload
1413 1447 assert_equal 2, issue.project_id
1414 1448 # Keep fixed_version
1415 1449 assert_equal 7, issue.fixed_version_id
1416 1450 end
1417 1451
1418 1452 def test_move_to_another_project_should_keep_parent_if_valid
1419 1453 issue = Issue.find(1)
1420 1454 issue.update_attribute(:parent_issue_id, 2)
1421 1455 issue.project = Project.find(3)
1422 1456 assert issue.save
1423 1457 issue.reload
1424 1458 assert_equal 2, issue.parent_id
1425 1459 end
1426 1460
1427 1461 def test_move_to_another_project_should_clear_parent_if_not_valid
1428 1462 issue = Issue.find(1)
1429 1463 issue.update_attribute(:parent_issue_id, 2)
1430 1464 issue.project = Project.find(2)
1431 1465 assert issue.save
1432 1466 issue.reload
1433 1467 assert_nil issue.parent_id
1434 1468 end
1435 1469
1436 1470 def test_move_to_another_project_with_disabled_tracker
1437 1471 issue = Issue.find(1)
1438 1472 target = Project.find(2)
1439 1473 target.tracker_ids = [3]
1440 1474 target.save
1441 1475 issue.project = target
1442 1476 assert issue.save
1443 1477 issue.reload
1444 1478 assert_equal 2, issue.project_id
1445 1479 assert_equal 3, issue.tracker_id
1446 1480 end
1447 1481
1448 1482 def test_copy_to_the_same_project
1449 1483 issue = Issue.find(1)
1450 1484 copy = issue.copy
1451 1485 assert_difference 'Issue.count' do
1452 1486 copy.save!
1453 1487 end
1454 1488 assert_kind_of Issue, copy
1455 1489 assert_equal issue.project, copy.project
1456 1490 assert_equal "125", copy.custom_value_for(2).value
1457 1491 end
1458 1492
1459 1493 def test_copy_to_another_project_and_tracker
1460 1494 issue = Issue.find(1)
1461 1495 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1462 1496 assert_difference 'Issue.count' do
1463 1497 copy.save!
1464 1498 end
1465 1499 copy.reload
1466 1500 assert_kind_of Issue, copy
1467 1501 assert_equal Project.find(3), copy.project
1468 1502 assert_equal Tracker.find(2), copy.tracker
1469 1503 # Custom field #2 is not associated with target tracker
1470 1504 assert_nil copy.custom_value_for(2)
1471 1505 end
1472 1506
1473 1507 test "#copy should not create a journal" do
1474 1508 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :assigned_to_id => 3}, :link => false)
1475 1509 copy.save!
1476 1510 assert_equal 0, copy.reload.journals.size
1477 1511 end
1478 1512
1479 1513 test "#copy should allow assigned_to changes" do
1480 1514 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1481 1515 assert_equal 3, copy.assigned_to_id
1482 1516 end
1483 1517
1484 1518 test "#copy should allow status changes" do
1485 1519 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1486 1520 assert_equal 2, copy.status_id
1487 1521 end
1488 1522
1489 1523 test "#copy should allow start date changes" do
1490 1524 date = Date.today
1491 1525 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1492 1526 assert_equal date, copy.start_date
1493 1527 end
1494 1528
1495 1529 test "#copy should allow due date changes" do
1496 1530 date = Date.today
1497 1531 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1498 1532 assert_equal date, copy.due_date
1499 1533 end
1500 1534
1501 1535 test "#copy should set current user as author" do
1502 1536 User.current = User.find(9)
1503 1537 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1504 1538 assert_equal User.current, copy.author
1505 1539 end
1506 1540
1507 1541 test "#copy should create a journal with notes" do
1508 1542 date = Date.today
1509 1543 notes = "Notes added when copying"
1510 1544 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
1511 1545 copy.init_journal(User.current, notes)
1512 1546 copy.save!
1513 1547
1514 1548 assert_equal 1, copy.journals.size
1515 1549 journal = copy.journals.first
1516 1550 assert_equal 0, journal.details.size
1517 1551 assert_equal notes, journal.notes
1518 1552 end
1519 1553
1520 1554 def test_valid_parent_project
1521 1555 issue = Issue.find(1)
1522 1556 issue_in_same_project = Issue.find(2)
1523 1557 issue_in_child_project = Issue.find(5)
1524 1558 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1525 1559 issue_in_other_child_project = Issue.find(6)
1526 1560 issue_in_different_tree = Issue.find(4)
1527 1561
1528 1562 with_settings :cross_project_subtasks => '' do
1529 1563 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1530 1564 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1531 1565 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1532 1566 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1533 1567 end
1534 1568
1535 1569 with_settings :cross_project_subtasks => 'system' do
1536 1570 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1537 1571 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1538 1572 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1539 1573 end
1540 1574
1541 1575 with_settings :cross_project_subtasks => 'tree' do
1542 1576 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1543 1577 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1544 1578 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1545 1579 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1546 1580
1547 1581 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1548 1582 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1549 1583 end
1550 1584
1551 1585 with_settings :cross_project_subtasks => 'descendants' do
1552 1586 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1553 1587 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1554 1588 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1555 1589 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1556 1590
1557 1591 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1558 1592 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1559 1593 end
1560 1594 end
1561 1595
1562 1596 def test_recipients_should_include_previous_assignee
1563 1597 user = User.find(3)
1564 1598 user.members.update_all ["mail_notification = ?", false]
1565 1599 user.update_attribute :mail_notification, 'only_assigned'
1566 1600
1567 1601 issue = Issue.find(2)
1568 1602 issue.assigned_to = nil
1569 1603 assert_include user.mail, issue.recipients
1570 1604 issue.save!
1571 1605 assert !issue.recipients.include?(user.mail)
1572 1606 end
1573 1607
1574 1608 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1575 1609 issue = Issue.find(12)
1576 1610 assert issue.recipients.include?(issue.author.mail)
1577 1611 # copy the issue to a private project
1578 1612 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1579 1613 # author is not a member of project anymore
1580 1614 assert !copy.recipients.include?(copy.author.mail)
1581 1615 end
1582 1616
1583 1617 def test_recipients_should_include_the_assigned_group_members
1584 1618 group_member = User.generate!
1585 1619 group = Group.generate!
1586 1620 group.users << group_member
1587 1621
1588 1622 issue = Issue.find(12)
1589 1623 issue.assigned_to = group
1590 1624 assert issue.recipients.include?(group_member.mail)
1591 1625 end
1592 1626
1593 1627 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1594 1628 user = User.find(3)
1595 1629 issue = Issue.find(9)
1596 1630 Watcher.create!(:user => user, :watchable => issue)
1597 1631 assert issue.watched_by?(user)
1598 1632 assert !issue.watcher_recipients.include?(user.mail)
1599 1633 end
1600 1634
1601 1635 def test_issue_destroy
1602 1636 Issue.find(1).destroy
1603 1637 assert_nil Issue.find_by_id(1)
1604 1638 assert_nil TimeEntry.find_by_issue_id(1)
1605 1639 end
1606 1640
1607 1641 def test_destroy_should_delete_time_entries_custom_values
1608 1642 issue = Issue.generate!
1609 1643 time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
1610 1644
1611 1645 assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
1612 1646 assert issue.destroy
1613 1647 end
1614 1648 end
1615 1649
1616 1650 def test_destroying_a_deleted_issue_should_not_raise_an_error
1617 1651 issue = Issue.find(1)
1618 1652 Issue.find(1).destroy
1619 1653
1620 1654 assert_nothing_raised do
1621 1655 assert_no_difference 'Issue.count' do
1622 1656 issue.destroy
1623 1657 end
1624 1658 assert issue.destroyed?
1625 1659 end
1626 1660 end
1627 1661
1628 1662 def test_destroying_a_stale_issue_should_not_raise_an_error
1629 1663 issue = Issue.find(1)
1630 1664 Issue.find(1).update_attribute :subject, "Updated"
1631 1665
1632 1666 assert_nothing_raised do
1633 1667 assert_difference 'Issue.count', -1 do
1634 1668 issue.destroy
1635 1669 end
1636 1670 assert issue.destroyed?
1637 1671 end
1638 1672 end
1639 1673
1640 1674 def test_blocked
1641 1675 blocked_issue = Issue.find(9)
1642 1676 blocking_issue = Issue.find(10)
1643 1677
1644 1678 assert blocked_issue.blocked?
1645 1679 assert !blocking_issue.blocked?
1646 1680 end
1647 1681
1648 1682 def test_blocked_issues_dont_allow_closed_statuses
1649 1683 blocked_issue = Issue.find(9)
1650 1684
1651 1685 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1652 1686 assert !allowed_statuses.empty?
1653 1687 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1654 1688 assert closed_statuses.empty?
1655 1689 end
1656 1690
1657 1691 def test_unblocked_issues_allow_closed_statuses
1658 1692 blocking_issue = Issue.find(10)
1659 1693
1660 1694 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1661 1695 assert !allowed_statuses.empty?
1662 1696 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1663 1697 assert !closed_statuses.empty?
1664 1698 end
1665 1699
1666 1700 def test_reschedule_an_issue_without_dates
1667 1701 with_settings :non_working_week_days => [] do
1668 1702 issue = Issue.new(:start_date => nil, :due_date => nil)
1669 1703 issue.reschedule_on '2012-10-09'.to_date
1670 1704 assert_equal '2012-10-09'.to_date, issue.start_date
1671 1705 assert_equal '2012-10-09'.to_date, issue.due_date
1672 1706 end
1673 1707
1674 1708 with_settings :non_working_week_days => %w(6 7) do
1675 1709 issue = Issue.new(:start_date => nil, :due_date => nil)
1676 1710 issue.reschedule_on '2012-10-09'.to_date
1677 1711 assert_equal '2012-10-09'.to_date, issue.start_date
1678 1712 assert_equal '2012-10-09'.to_date, issue.due_date
1679 1713
1680 1714 issue = Issue.new(:start_date => nil, :due_date => nil)
1681 1715 issue.reschedule_on '2012-10-13'.to_date
1682 1716 assert_equal '2012-10-15'.to_date, issue.start_date
1683 1717 assert_equal '2012-10-15'.to_date, issue.due_date
1684 1718 end
1685 1719 end
1686 1720
1687 1721 def test_reschedule_an_issue_with_start_date
1688 1722 with_settings :non_working_week_days => [] do
1689 1723 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1690 1724 issue.reschedule_on '2012-10-13'.to_date
1691 1725 assert_equal '2012-10-13'.to_date, issue.start_date
1692 1726 assert_equal '2012-10-13'.to_date, issue.due_date
1693 1727 end
1694 1728
1695 1729 with_settings :non_working_week_days => %w(6 7) do
1696 1730 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1697 1731 issue.reschedule_on '2012-10-11'.to_date
1698 1732 assert_equal '2012-10-11'.to_date, issue.start_date
1699 1733 assert_equal '2012-10-11'.to_date, issue.due_date
1700 1734
1701 1735 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1702 1736 issue.reschedule_on '2012-10-13'.to_date
1703 1737 assert_equal '2012-10-15'.to_date, issue.start_date
1704 1738 assert_equal '2012-10-15'.to_date, issue.due_date
1705 1739 end
1706 1740 end
1707 1741
1708 1742 def test_reschedule_an_issue_with_start_and_due_dates
1709 1743 with_settings :non_working_week_days => [] do
1710 1744 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1711 1745 issue.reschedule_on '2012-10-13'.to_date
1712 1746 assert_equal '2012-10-13'.to_date, issue.start_date
1713 1747 assert_equal '2012-10-19'.to_date, issue.due_date
1714 1748 end
1715 1749
1716 1750 with_settings :non_working_week_days => %w(6 7) do
1717 1751 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1718 1752 issue.reschedule_on '2012-10-11'.to_date
1719 1753 assert_equal '2012-10-11'.to_date, issue.start_date
1720 1754 assert_equal '2012-10-23'.to_date, issue.due_date
1721 1755
1722 1756 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1723 1757 issue.reschedule_on '2012-10-13'.to_date
1724 1758 assert_equal '2012-10-15'.to_date, issue.start_date
1725 1759 assert_equal '2012-10-25'.to_date, issue.due_date
1726 1760 end
1727 1761 end
1728 1762
1729 1763 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1730 1764 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1731 1765 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1732 1766 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1733 1767 :relation_type => IssueRelation::TYPE_PRECEDES)
1734 1768 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1735 1769
1736 1770 issue1.reload
1737 1771 issue1.due_date = '2012-10-23'
1738 1772 issue1.save!
1739 1773 issue2.reload
1740 1774 assert_equal Date.parse('2012-10-24'), issue2.start_date
1741 1775 assert_equal Date.parse('2012-10-26'), issue2.due_date
1742 1776 end
1743 1777
1744 1778 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1745 1779 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1746 1780 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1747 1781 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1748 1782 :relation_type => IssueRelation::TYPE_PRECEDES)
1749 1783 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1750 1784
1751 1785 issue1.reload
1752 1786 issue1.start_date = '2012-09-17'
1753 1787 issue1.due_date = '2012-09-18'
1754 1788 issue1.save!
1755 1789 issue2.reload
1756 1790 assert_equal Date.parse('2012-09-19'), issue2.start_date
1757 1791 assert_equal Date.parse('2012-09-21'), issue2.due_date
1758 1792 end
1759 1793
1760 1794 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1761 1795 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1762 1796 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1763 1797 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1764 1798 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1765 1799 :relation_type => IssueRelation::TYPE_PRECEDES)
1766 1800 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1767 1801 :relation_type => IssueRelation::TYPE_PRECEDES)
1768 1802 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1769 1803
1770 1804 issue1.reload
1771 1805 issue1.start_date = '2012-09-17'
1772 1806 issue1.due_date = '2012-09-18'
1773 1807 issue1.save!
1774 1808 issue2.reload
1775 1809 # Issue 2 must start after Issue 3
1776 1810 assert_equal Date.parse('2012-10-03'), issue2.start_date
1777 1811 assert_equal Date.parse('2012-10-05'), issue2.due_date
1778 1812 end
1779 1813
1780 1814 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1781 1815 with_settings :non_working_week_days => [] do
1782 1816 stale = Issue.find(1)
1783 1817 issue = Issue.find(1)
1784 1818 issue.subject = "Updated"
1785 1819 issue.save!
1786 1820 date = 10.days.from_now.to_date
1787 1821 assert_nothing_raised do
1788 1822 stale.reschedule_on!(date)
1789 1823 end
1790 1824 assert_equal date, stale.reload.start_date
1791 1825 end
1792 1826 end
1793 1827
1794 1828 def test_child_issue_should_consider_parent_soonest_start_on_create
1795 1829 set_language_if_valid 'en'
1796 1830 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1797 1831 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
1798 1832 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1799 1833 :relation_type => IssueRelation::TYPE_PRECEDES)
1800 1834 issue1.reload
1801 1835 issue2.reload
1802 1836 assert_equal Date.parse('2012-10-18'), issue2.start_date
1803 1837
1804 1838 with_settings :date_format => '%m/%d/%Y' do
1805 1839 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
1806 1840 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
1807 1841 assert !child.valid?
1808 1842 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
1809 1843 assert_equal Date.parse('2012-10-18'), child.soonest_start
1810 1844 child.start_date = '2012-10-18'
1811 1845 assert child.save
1812 1846 end
1813 1847 end
1814 1848
1815 1849 def test_setting_parent_to_a_dependent_issue_should_not_validate
1816 1850 set_language_if_valid 'en'
1817 1851 issue1 = Issue.generate!
1818 1852 issue2 = Issue.generate!
1819 1853 issue3 = Issue.generate!
1820 1854 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1821 1855 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
1822 1856 issue3.reload
1823 1857 issue3.parent_issue_id = issue2.id
1824 1858 assert !issue3.valid?
1825 1859 assert_include 'Parent task is invalid', issue3.errors.full_messages
1826 1860 end
1827 1861
1828 1862 def test_setting_parent_should_not_allow_circular_dependency
1829 1863 set_language_if_valid 'en'
1830 1864 issue1 = Issue.generate!
1831 1865 issue2 = Issue.generate!
1832 1866 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1833 1867 issue3 = Issue.generate!
1834 1868 issue2.reload
1835 1869 issue2.parent_issue_id = issue3.id
1836 1870 issue2.save!
1837 1871 issue4 = Issue.generate!
1838 1872 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
1839 1873 issue4.reload
1840 1874 issue4.parent_issue_id = issue1.id
1841 1875 assert !issue4.valid?
1842 1876 assert_include 'Parent task is invalid', issue4.errors.full_messages
1843 1877 end
1844 1878
1845 1879 def test_overdue
1846 1880 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1847 1881 assert !Issue.new(:due_date => Date.today).overdue?
1848 1882 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1849 1883 assert !Issue.new(:due_date => nil).overdue?
1850 1884 assert !Issue.new(:due_date => 1.day.ago.to_date,
1851 1885 :status => IssueStatus.where(:is_closed => true).first
1852 1886 ).overdue?
1853 1887 end
1854 1888
1855 1889 test "#behind_schedule? should be false if the issue has no start_date" do
1856 1890 assert !Issue.new(:start_date => nil,
1857 1891 :due_date => 1.day.from_now.to_date,
1858 1892 :done_ratio => 0).behind_schedule?
1859 1893 end
1860 1894
1861 1895 test "#behind_schedule? should be false if the issue has no end_date" do
1862 1896 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1863 1897 :due_date => nil,
1864 1898 :done_ratio => 0).behind_schedule?
1865 1899 end
1866 1900
1867 1901 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
1868 1902 assert !Issue.new(:start_date => 50.days.ago.to_date,
1869 1903 :due_date => 50.days.from_now.to_date,
1870 1904 :done_ratio => 90).behind_schedule?
1871 1905 end
1872 1906
1873 1907 test "#behind_schedule? should be true if the issue hasn't been started at all" do
1874 1908 assert Issue.new(:start_date => 1.day.ago.to_date,
1875 1909 :due_date => 1.day.from_now.to_date,
1876 1910 :done_ratio => 0).behind_schedule?
1877 1911 end
1878 1912
1879 1913 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
1880 1914 assert Issue.new(:start_date => 100.days.ago.to_date,
1881 1915 :due_date => Date.today,
1882 1916 :done_ratio => 90).behind_schedule?
1883 1917 end
1884 1918
1885 1919 test "#assignable_users should be Users" do
1886 1920 assert_kind_of User, Issue.find(1).assignable_users.first
1887 1921 end
1888 1922
1889 1923 test "#assignable_users should include the issue author" do
1890 1924 non_project_member = User.generate!
1891 1925 issue = Issue.generate!(:author => non_project_member)
1892 1926
1893 1927 assert issue.assignable_users.include?(non_project_member)
1894 1928 end
1895 1929
1896 1930 def test_assignable_users_should_not_include_anonymous_user
1897 1931 issue = Issue.generate!(:author => User.anonymous)
1898 1932
1899 1933 assert !issue.assignable_users.include?(User.anonymous)
1900 1934 end
1901 1935
1902 1936 def test_assignable_users_should_not_include_locked_user
1903 1937 user = User.generate!
1904 1938 issue = Issue.generate!(:author => user)
1905 1939 user.lock!
1906 1940
1907 1941 assert !issue.assignable_users.include?(user)
1908 1942 end
1909 1943
1910 1944 test "#assignable_users should include the current assignee" do
1911 1945 user = User.generate!
1912 1946 issue = Issue.generate!(:assigned_to => user)
1913 1947 user.lock!
1914 1948
1915 1949 assert Issue.find(issue.id).assignable_users.include?(user)
1916 1950 end
1917 1951
1918 1952 test "#assignable_users should not show the issue author twice" do
1919 1953 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1920 1954 assert_equal 2, assignable_user_ids.length
1921 1955
1922 1956 assignable_user_ids.each do |user_id|
1923 1957 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1924 1958 "User #{user_id} appears more or less than once"
1925 1959 end
1926 1960 end
1927 1961
1928 1962 test "#assignable_users with issue_group_assignment should include groups" do
1929 1963 issue = Issue.new(:project => Project.find(2))
1930 1964
1931 1965 with_settings :issue_group_assignment => '1' do
1932 1966 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1933 1967 assert issue.assignable_users.include?(Group.find(11))
1934 1968 end
1935 1969 end
1936 1970
1937 1971 test "#assignable_users without issue_group_assignment should not include groups" do
1938 1972 issue = Issue.new(:project => Project.find(2))
1939 1973
1940 1974 with_settings :issue_group_assignment => '0' do
1941 1975 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1942 1976 assert !issue.assignable_users.include?(Group.find(11))
1943 1977 end
1944 1978 end
1945 1979
1946 1980 def test_assignable_users_should_not_include_builtin_groups
1947 1981 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
1948 1982 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
1949 1983 issue = Issue.new(:project => Project.find(1))
1950 1984
1951 1985 with_settings :issue_group_assignment => '1' do
1952 1986 assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
1953 1987 end
1954 1988 end
1955 1989
1956 1990 def test_create_should_send_email_notification
1957 1991 ActionMailer::Base.deliveries.clear
1958 1992 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1959 1993 :author_id => 3, :status_id => 1,
1960 1994 :priority => IssuePriority.all.first,
1961 1995 :subject => 'test_create', :estimated_hours => '1:30')
1962 1996 with_settings :notified_events => %w(issue_added) do
1963 1997 assert issue.save
1964 1998 assert_equal 1, ActionMailer::Base.deliveries.size
1965 1999 end
1966 2000 end
1967 2001
1968 2002 def test_create_should_send_one_email_notification_with_both_settings
1969 2003 ActionMailer::Base.deliveries.clear
1970 2004 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1971 2005 :author_id => 3, :status_id => 1,
1972 2006 :priority => IssuePriority.all.first,
1973 2007 :subject => 'test_create', :estimated_hours => '1:30')
1974 2008 with_settings :notified_events => %w(issue_added issue_updated) do
1975 2009 assert issue.save
1976 2010 assert_equal 1, ActionMailer::Base.deliveries.size
1977 2011 end
1978 2012 end
1979 2013
1980 2014 def test_create_should_not_send_email_notification_with_no_setting
1981 2015 ActionMailer::Base.deliveries.clear
1982 2016 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1983 2017 :author_id => 3, :status_id => 1,
1984 2018 :priority => IssuePriority.all.first,
1985 2019 :subject => 'test_create', :estimated_hours => '1:30')
1986 2020 with_settings :notified_events => [] do
1987 2021 assert issue.save
1988 2022 assert_equal 0, ActionMailer::Base.deliveries.size
1989 2023 end
1990 2024 end
1991 2025
1992 2026 def test_update_should_notify_previous_assignee
1993 2027 ActionMailer::Base.deliveries.clear
1994 2028 user = User.find(3)
1995 2029 user.members.update_all ["mail_notification = ?", false]
1996 2030 user.update_attribute :mail_notification, 'only_assigned'
1997 2031
1998 2032 with_settings :notified_events => %w(issue_updated) do
1999 2033 issue = Issue.find(2)
2000 2034 issue.init_journal User.find(1)
2001 2035 issue.assigned_to = nil
2002 2036 issue.save!
2003 2037 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
2004 2038 end
2005 2039 end
2006 2040
2007 2041 def test_stale_issue_should_not_send_email_notification
2008 2042 ActionMailer::Base.deliveries.clear
2009 2043 issue = Issue.find(1)
2010 2044 stale = Issue.find(1)
2011 2045
2012 2046 issue.init_journal(User.find(1))
2013 2047 issue.subject = 'Subjet update'
2014 2048 with_settings :notified_events => %w(issue_updated) do
2015 2049 assert issue.save
2016 2050 assert_equal 1, ActionMailer::Base.deliveries.size
2017 2051 ActionMailer::Base.deliveries.clear
2018 2052
2019 2053 stale.init_journal(User.find(1))
2020 2054 stale.subject = 'Another subjet update'
2021 2055 assert_raise ActiveRecord::StaleObjectError do
2022 2056 stale.save
2023 2057 end
2024 2058 assert ActionMailer::Base.deliveries.empty?
2025 2059 end
2026 2060 end
2027 2061
2028 2062 def test_journalized_description
2029 2063 IssueCustomField.delete_all
2030 2064
2031 2065 i = Issue.first
2032 2066 old_description = i.description
2033 2067 new_description = "This is the new description"
2034 2068
2035 2069 i.init_journal(User.find(2))
2036 2070 i.description = new_description
2037 2071 assert_difference 'Journal.count', 1 do
2038 2072 assert_difference 'JournalDetail.count', 1 do
2039 2073 i.save!
2040 2074 end
2041 2075 end
2042 2076
2043 2077 detail = JournalDetail.order('id DESC').first
2044 2078 assert_equal i, detail.journal.journalized
2045 2079 assert_equal 'attr', detail.property
2046 2080 assert_equal 'description', detail.prop_key
2047 2081 assert_equal old_description, detail.old_value
2048 2082 assert_equal new_description, detail.value
2049 2083 end
2050 2084
2051 2085 def test_blank_descriptions_should_not_be_journalized
2052 2086 IssueCustomField.delete_all
2053 2087 Issue.where(:id => 1).update_all("description = NULL")
2054 2088
2055 2089 i = Issue.find(1)
2056 2090 i.init_journal(User.find(2))
2057 2091 i.subject = "blank description"
2058 2092 i.description = "\r\n"
2059 2093
2060 2094 assert_difference 'Journal.count', 1 do
2061 2095 assert_difference 'JournalDetail.count', 1 do
2062 2096 i.save!
2063 2097 end
2064 2098 end
2065 2099 end
2066 2100
2067 2101 def test_journalized_multi_custom_field
2068 2102 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
2069 2103 :is_filter => true, :is_for_all => true,
2070 2104 :tracker_ids => [1],
2071 2105 :possible_values => ['value1', 'value2', 'value3'],
2072 2106 :multiple => true)
2073 2107
2074 2108 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
2075 2109 :subject => 'Test', :author_id => 1)
2076 2110
2077 2111 assert_difference 'Journal.count' do
2078 2112 assert_difference 'JournalDetail.count' do
2079 2113 issue.init_journal(User.first)
2080 2114 issue.custom_field_values = {field.id => ['value1']}
2081 2115 issue.save!
2082 2116 end
2083 2117 assert_difference 'JournalDetail.count' do
2084 2118 issue.init_journal(User.first)
2085 2119 issue.custom_field_values = {field.id => ['value1', 'value2']}
2086 2120 issue.save!
2087 2121 end
2088 2122 assert_difference 'JournalDetail.count', 2 do
2089 2123 issue.init_journal(User.first)
2090 2124 issue.custom_field_values = {field.id => ['value3', 'value2']}
2091 2125 issue.save!
2092 2126 end
2093 2127 assert_difference 'JournalDetail.count', 2 do
2094 2128 issue.init_journal(User.first)
2095 2129 issue.custom_field_values = {field.id => nil}
2096 2130 issue.save!
2097 2131 end
2098 2132 end
2099 2133 end
2100 2134
2101 2135 def test_description_eol_should_be_normalized
2102 2136 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
2103 2137 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
2104 2138 end
2105 2139
2106 2140 def test_saving_twice_should_not_duplicate_journal_details
2107 2141 i = Issue.first
2108 2142 i.init_journal(User.find(2), 'Some notes')
2109 2143 # initial changes
2110 2144 i.subject = 'New subject'
2111 2145 i.done_ratio = i.done_ratio + 10
2112 2146 assert_difference 'Journal.count' do
2113 2147 assert i.save
2114 2148 end
2115 2149 # 1 more change
2116 2150 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
2117 2151 assert_no_difference 'Journal.count' do
2118 2152 assert_difference 'JournalDetail.count', 1 do
2119 2153 i.save
2120 2154 end
2121 2155 end
2122 2156 # no more change
2123 2157 assert_no_difference 'Journal.count' do
2124 2158 assert_no_difference 'JournalDetail.count' do
2125 2159 i.save
2126 2160 end
2127 2161 end
2128 2162 end
2129 2163
2130 2164 def test_all_dependent_issues
2131 2165 IssueRelation.delete_all
2132 2166 assert IssueRelation.create!(:issue_from => Issue.find(1),
2133 2167 :issue_to => Issue.find(2),
2134 2168 :relation_type => IssueRelation::TYPE_PRECEDES)
2135 2169 assert IssueRelation.create!(:issue_from => Issue.find(2),
2136 2170 :issue_to => Issue.find(3),
2137 2171 :relation_type => IssueRelation::TYPE_PRECEDES)
2138 2172 assert IssueRelation.create!(:issue_from => Issue.find(3),
2139 2173 :issue_to => Issue.find(8),
2140 2174 :relation_type => IssueRelation::TYPE_PRECEDES)
2141 2175
2142 2176 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
2143 2177 end
2144 2178
2145 2179 def test_all_dependent_issues_with_subtask
2146 2180 IssueRelation.delete_all
2147 2181
2148 2182 project = Project.generate!(:name => "testproject")
2149 2183
2150 2184 parentIssue = Issue.generate!(:project => project)
2151 2185 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2152 2186 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2153 2187
2154 2188 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
2155 2189 end
2156 2190
2157 2191 def test_all_dependent_issues_does_not_include_self
2158 2192 IssueRelation.delete_all
2159 2193
2160 2194 project = Project.generate!(:name => "testproject")
2161 2195
2162 2196 parentIssue = Issue.generate!(:project => project)
2163 2197 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2164 2198
2165 2199 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
2166 2200 end
2167 2201
2168 2202 def test_all_dependent_issues_with_parenttask_and_sibling
2169 2203 IssueRelation.delete_all
2170 2204
2171 2205 project = Project.generate!(:name => "testproject")
2172 2206
2173 2207 parentIssue = Issue.generate!(:project => project)
2174 2208 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2175 2209 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2176 2210
2177 2211 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
2178 2212 end
2179 2213
2180 2214 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
2181 2215 IssueRelation.delete_all
2182 2216
2183 2217 project = Project.generate!(:name => "testproject")
2184 2218
2185 2219 parentIssue1 = Issue.generate!(:project => project)
2186 2220 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2187 2221 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2188 2222
2189 2223 parentIssue2 = Issue.generate!(:project => project)
2190 2224 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2191 2225 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2192 2226
2193 2227
2194 2228 assert IssueRelation.create(:issue_from => parentIssue1,
2195 2229 :issue_to => childIssue2_2,
2196 2230 :relation_type => IssueRelation::TYPE_BLOCKS)
2197 2231
2198 2232 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
2199 2233 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2200 2234 end
2201 2235
2202 2236 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
2203 2237 IssueRelation.delete_all
2204 2238
2205 2239 project = Project.generate!(:name => "testproject")
2206 2240
2207 2241 parentIssue1 = Issue.generate!(:project => project)
2208 2242 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2209 2243 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2210 2244
2211 2245 parentIssue2 = Issue.generate!(:project => project)
2212 2246 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2213 2247 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2214 2248
2215 2249
2216 2250 assert IssueRelation.create(:issue_from => parentIssue1,
2217 2251 :issue_to => parentIssue2,
2218 2252 :relation_type => IssueRelation::TYPE_BLOCKS)
2219 2253
2220 2254 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
2221 2255 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2222 2256 end
2223 2257
2224 2258 def test_all_dependent_issues_with_transitive_relation
2225 2259 IssueRelation.delete_all
2226 2260
2227 2261 project = Project.generate!(:name => "testproject")
2228 2262
2229 2263 parentIssue1 = Issue.generate!(:project => project)
2230 2264 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2231 2265
2232 2266 parentIssue2 = Issue.generate!(:project => project)
2233 2267 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2234 2268
2235 2269 independentIssue = Issue.generate!(:project => project)
2236 2270
2237 2271 assert IssueRelation.create(:issue_from => parentIssue1,
2238 2272 :issue_to => childIssue2_1,
2239 2273 :relation_type => IssueRelation::TYPE_RELATES)
2240 2274
2241 2275 assert IssueRelation.create(:issue_from => childIssue2_1,
2242 2276 :issue_to => independentIssue,
2243 2277 :relation_type => IssueRelation::TYPE_RELATES)
2244 2278
2245 2279 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
2246 2280 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2247 2281 end
2248 2282
2249 2283 def test_all_dependent_issues_with_transitive_relation2
2250 2284 IssueRelation.delete_all
2251 2285
2252 2286 project = Project.generate!(:name => "testproject")
2253 2287
2254 2288 parentIssue1 = Issue.generate!(:project => project)
2255 2289 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2256 2290
2257 2291 parentIssue2 = Issue.generate!(:project => project)
2258 2292 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2259 2293
2260 2294 independentIssue = Issue.generate!(:project => project)
2261 2295
2262 2296 assert IssueRelation.create(:issue_from => parentIssue1,
2263 2297 :issue_to => independentIssue,
2264 2298 :relation_type => IssueRelation::TYPE_RELATES)
2265 2299
2266 2300 assert IssueRelation.create(:issue_from => independentIssue,
2267 2301 :issue_to => childIssue2_1,
2268 2302 :relation_type => IssueRelation::TYPE_RELATES)
2269 2303
2270 2304 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
2271 2305 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2272 2306
2273 2307 end
2274 2308
2275 2309 def test_all_dependent_issues_with_persistent_circular_dependency
2276 2310 IssueRelation.delete_all
2277 2311 assert IssueRelation.create!(:issue_from => Issue.find(1),
2278 2312 :issue_to => Issue.find(2),
2279 2313 :relation_type => IssueRelation::TYPE_PRECEDES)
2280 2314 assert IssueRelation.create!(:issue_from => Issue.find(2),
2281 2315 :issue_to => Issue.find(3),
2282 2316 :relation_type => IssueRelation::TYPE_PRECEDES)
2283 2317
2284 2318 r = IssueRelation.create!(:issue_from => Issue.find(3),
2285 2319 :issue_to => Issue.find(7),
2286 2320 :relation_type => IssueRelation::TYPE_PRECEDES)
2287 2321 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
2288 2322
2289 2323 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
2290 2324 end
2291 2325
2292 2326 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
2293 2327 IssueRelation.delete_all
2294 2328 assert IssueRelation.create!(:issue_from => Issue.find(1),
2295 2329 :issue_to => Issue.find(2),
2296 2330 :relation_type => IssueRelation::TYPE_RELATES)
2297 2331 assert IssueRelation.create!(:issue_from => Issue.find(2),
2298 2332 :issue_to => Issue.find(3),
2299 2333 :relation_type => IssueRelation::TYPE_RELATES)
2300 2334 assert IssueRelation.create!(:issue_from => Issue.find(3),
2301 2335 :issue_to => Issue.find(8),
2302 2336 :relation_type => IssueRelation::TYPE_RELATES)
2303 2337
2304 2338 r = IssueRelation.create!(:issue_from => Issue.find(8),
2305 2339 :issue_to => Issue.find(7),
2306 2340 :relation_type => IssueRelation::TYPE_RELATES)
2307 2341 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 2")
2308 2342
2309 2343 r = IssueRelation.create!(:issue_from => Issue.find(3),
2310 2344 :issue_to => Issue.find(7),
2311 2345 :relation_type => IssueRelation::TYPE_RELATES)
2312 2346 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
2313 2347
2314 2348 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
2315 2349 end
2316 2350
2317 2351 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
2318 2352 @issue = Issue.find(1)
2319 2353 @issue_status = IssueStatus.find(1)
2320 2354 @issue_status.update_attribute(:default_done_ratio, 50)
2321 2355 @issue2 = Issue.find(2)
2322 2356 @issue_status2 = IssueStatus.find(2)
2323 2357 @issue_status2.update_attribute(:default_done_ratio, 0)
2324 2358
2325 2359 with_settings :issue_done_ratio => 'issue_field' do
2326 2360 assert_equal 0, @issue.done_ratio
2327 2361 assert_equal 30, @issue2.done_ratio
2328 2362 end
2329 2363
2330 2364 with_settings :issue_done_ratio => 'issue_status' do
2331 2365 assert_equal 50, @issue.done_ratio
2332 2366 assert_equal 0, @issue2.done_ratio
2333 2367 end
2334 2368 end
2335 2369
2336 2370 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
2337 2371 @issue = Issue.find(1)
2338 2372 @issue_status = IssueStatus.find(1)
2339 2373 @issue_status.update_attribute(:default_done_ratio, 50)
2340 2374 @issue2 = Issue.find(2)
2341 2375 @issue_status2 = IssueStatus.find(2)
2342 2376 @issue_status2.update_attribute(:default_done_ratio, 0)
2343 2377
2344 2378 with_settings :issue_done_ratio => 'issue_field' do
2345 2379 @issue.update_done_ratio_from_issue_status
2346 2380 @issue2.update_done_ratio_from_issue_status
2347 2381
2348 2382 assert_equal 0, @issue.read_attribute(:done_ratio)
2349 2383 assert_equal 30, @issue2.read_attribute(:done_ratio)
2350 2384 end
2351 2385
2352 2386 with_settings :issue_done_ratio => 'issue_status' do
2353 2387 @issue.update_done_ratio_from_issue_status
2354 2388 @issue2.update_done_ratio_from_issue_status
2355 2389
2356 2390 assert_equal 50, @issue.read_attribute(:done_ratio)
2357 2391 assert_equal 0, @issue2.read_attribute(:done_ratio)
2358 2392 end
2359 2393 end
2360 2394
2361 2395 test "#by_tracker" do
2362 2396 User.current = User.anonymous
2363 2397 groups = Issue.by_tracker(Project.find(1))
2364 2398 assert_equal 3, groups.count
2365 2399 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2366 2400 end
2367 2401
2368 2402 test "#by_version" do
2369 2403 User.current = User.anonymous
2370 2404 groups = Issue.by_version(Project.find(1))
2371 2405 assert_equal 3, groups.count
2372 2406 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2373 2407 end
2374 2408
2375 2409 test "#by_priority" do
2376 2410 User.current = User.anonymous
2377 2411 groups = Issue.by_priority(Project.find(1))
2378 2412 assert_equal 4, groups.count
2379 2413 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2380 2414 end
2381 2415
2382 2416 test "#by_category" do
2383 2417 User.current = User.anonymous
2384 2418 groups = Issue.by_category(Project.find(1))
2385 2419 assert_equal 2, groups.count
2386 2420 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2387 2421 end
2388 2422
2389 2423 test "#by_assigned_to" do
2390 2424 User.current = User.anonymous
2391 2425 groups = Issue.by_assigned_to(Project.find(1))
2392 2426 assert_equal 2, groups.count
2393 2427 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2394 2428 end
2395 2429
2396 2430 test "#by_author" do
2397 2431 User.current = User.anonymous
2398 2432 groups = Issue.by_author(Project.find(1))
2399 2433 assert_equal 4, groups.count
2400 2434 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2401 2435 end
2402 2436
2403 2437 test "#by_subproject" do
2404 2438 User.current = User.anonymous
2405 2439 groups = Issue.by_subproject(Project.find(1))
2406 2440 # Private descendant not visible
2407 2441 assert_equal 1, groups.count
2408 2442 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2409 2443 end
2410 2444
2411 2445 def test_recently_updated_scope
2412 2446 #should return the last updated issue
2413 2447 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
2414 2448 end
2415 2449
2416 2450 def test_on_active_projects_scope
2417 2451 assert Project.find(2).archive
2418 2452
2419 2453 before = Issue.on_active_project.length
2420 2454 # test inclusion to results
2421 2455 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
2422 2456 assert_equal before + 1, Issue.on_active_project.length
2423 2457
2424 2458 # Move to an archived project
2425 2459 issue.project = Project.find(2)
2426 2460 assert issue.save
2427 2461 assert_equal before, Issue.on_active_project.length
2428 2462 end
2429 2463
2430 2464 test "Issue#recipients should include project recipients" do
2431 2465 issue = Issue.generate!
2432 2466 assert issue.project.recipients.present?
2433 2467 issue.project.recipients.each do |project_recipient|
2434 2468 assert issue.recipients.include?(project_recipient)
2435 2469 end
2436 2470 end
2437 2471
2438 2472 test "Issue#recipients should include the author if the author is active" do
2439 2473 issue = Issue.generate!(:author => User.generate!)
2440 2474 assert issue.author, "No author set for Issue"
2441 2475 assert issue.recipients.include?(issue.author.mail)
2442 2476 end
2443 2477
2444 2478 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
2445 2479 issue = Issue.generate!(:assigned_to => User.generate!)
2446 2480 assert issue.assigned_to, "No assigned_to set for Issue"
2447 2481 assert issue.recipients.include?(issue.assigned_to.mail)
2448 2482 end
2449 2483
2450 2484 test "Issue#recipients should not include users who opt out of all email" do
2451 2485 issue = Issue.generate!(:author => User.generate!)
2452 2486 issue.author.update_attribute(:mail_notification, :none)
2453 2487 assert !issue.recipients.include?(issue.author.mail)
2454 2488 end
2455 2489
2456 2490 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
2457 2491 issue = Issue.generate!(:author => User.generate!)
2458 2492 issue.author.update_attribute(:mail_notification, :only_assigned)
2459 2493 assert !issue.recipients.include?(issue.author.mail)
2460 2494 end
2461 2495
2462 2496 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
2463 2497 issue = Issue.generate!(:assigned_to => User.generate!)
2464 2498 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
2465 2499 assert !issue.recipients.include?(issue.assigned_to.mail)
2466 2500 end
2467 2501
2468 2502 def test_last_journal_id_with_journals_should_return_the_journal_id
2469 2503 assert_equal 2, Issue.find(1).last_journal_id
2470 2504 end
2471 2505
2472 2506 def test_last_journal_id_without_journals_should_return_nil
2473 2507 assert_nil Issue.find(3).last_journal_id
2474 2508 end
2475 2509
2476 2510 def test_journals_after_should_return_journals_with_greater_id
2477 2511 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
2478 2512 assert_equal [], Issue.find(1).journals_after('2')
2479 2513 end
2480 2514
2481 2515 def test_journals_after_with_blank_arg_should_return_all_journals
2482 2516 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
2483 2517 end
2484 2518
2485 2519 def test_css_classes_should_include_tracker
2486 2520 issue = Issue.new(:tracker => Tracker.find(2))
2487 2521 classes = issue.css_classes.split(' ')
2488 2522 assert_include 'tracker-2', classes
2489 2523 end
2490 2524
2491 2525 def test_css_classes_should_include_priority
2492 2526 issue = Issue.new(:priority => IssuePriority.find(8))
2493 2527 classes = issue.css_classes.split(' ')
2494 2528 assert_include 'priority-8', classes
2495 2529 assert_include 'priority-highest', classes
2496 2530 end
2497 2531
2498 2532 def test_css_classes_should_include_user_and_group_assignment
2499 2533 project = Project.first
2500 2534 user = User.generate!
2501 2535 group = Group.generate!
2502 2536 Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
2503 2537 group.users << user
2504 2538 assert user.member_of?(project)
2505 2539 issue1 = Issue.generate(:assigned_to_id => group.id)
2506 2540 assert_include 'assigned-to-my-group', issue1.css_classes(user)
2507 2541 assert_not_include 'assigned-to-me', issue1.css_classes(user)
2508 2542 issue2 = Issue.generate(:assigned_to_id => user.id)
2509 2543 assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
2510 2544 assert_include 'assigned-to-me', issue2.css_classes(user)
2511 2545 end
2512 2546
2513 2547 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
2514 2548 set_tmp_attachments_directory
2515 2549 issue = Issue.generate!
2516 2550 issue.save_attachments({
2517 2551 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
2518 2552 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
2519 2553 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
2520 2554 })
2521 2555 issue.attach_saved_attachments
2522 2556
2523 2557 assert_equal 3, issue.reload.attachments.count
2524 2558 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
2525 2559 end
2526 2560
2527 2561 def test_closed_on_should_be_nil_when_creating_an_open_issue
2528 2562 issue = Issue.generate!(:status_id => 1).reload
2529 2563 assert !issue.closed?
2530 2564 assert_nil issue.closed_on
2531 2565 end
2532 2566
2533 2567 def test_closed_on_should_be_set_when_creating_a_closed_issue
2534 2568 issue = Issue.generate!(:status_id => 5).reload
2535 2569 assert issue.closed?
2536 2570 assert_not_nil issue.closed_on
2537 2571 assert_equal issue.updated_on, issue.closed_on
2538 2572 assert_equal issue.created_on, issue.closed_on
2539 2573 end
2540 2574
2541 2575 def test_closed_on_should_be_nil_when_updating_an_open_issue
2542 2576 issue = Issue.find(1)
2543 2577 issue.subject = 'Not closed yet'
2544 2578 issue.save!
2545 2579 issue.reload
2546 2580 assert_nil issue.closed_on
2547 2581 end
2548 2582
2549 2583 def test_closed_on_should_be_set_when_closing_an_open_issue
2550 2584 issue = Issue.find(1)
2551 2585 issue.subject = 'Now closed'
2552 2586 issue.status_id = 5
2553 2587 issue.save!
2554 2588 issue.reload
2555 2589 assert_not_nil issue.closed_on
2556 2590 assert_equal issue.updated_on, issue.closed_on
2557 2591 end
2558 2592
2559 2593 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2560 2594 issue = Issue.open(false).first
2561 2595 was_closed_on = issue.closed_on
2562 2596 assert_not_nil was_closed_on
2563 2597 issue.subject = 'Updating a closed issue'
2564 2598 issue.save!
2565 2599 issue.reload
2566 2600 assert_equal was_closed_on, issue.closed_on
2567 2601 end
2568 2602
2569 2603 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2570 2604 issue = Issue.open(false).first
2571 2605 was_closed_on = issue.closed_on
2572 2606 assert_not_nil was_closed_on
2573 2607 issue.subject = 'Reopening a closed issue'
2574 2608 issue.status_id = 1
2575 2609 issue.save!
2576 2610 issue.reload
2577 2611 assert !issue.closed?
2578 2612 assert_equal was_closed_on, issue.closed_on
2579 2613 end
2580 2614
2581 2615 def test_status_was_should_return_nil_for_new_issue
2582 2616 issue = Issue.new
2583 2617 assert_nil issue.status_was
2584 2618 end
2585 2619
2586 2620 def test_status_was_should_return_status_before_change
2587 2621 issue = Issue.find(1)
2588 2622 issue.status = IssueStatus.find(2)
2589 2623 assert_equal IssueStatus.find(1), issue.status_was
2590 2624 end
2591 2625
2592 2626 def test_status_was_should_return_status_before_change_with_status_id
2593 2627 issue = Issue.find(1)
2594 2628 assert_equal IssueStatus.find(1), issue.status
2595 2629 issue.status_id = 2
2596 2630 assert_equal IssueStatus.find(1), issue.status_was
2597 2631 end
2598 2632
2599 2633 def test_status_was_should_be_reset_on_save
2600 2634 issue = Issue.find(1)
2601 2635 issue.status = IssueStatus.find(2)
2602 2636 assert_equal IssueStatus.find(1), issue.status_was
2603 2637 assert issue.save!
2604 2638 assert_equal IssueStatus.find(2), issue.status_was
2605 2639 end
2606 2640
2607 2641 def test_closing_should_return_true_when_closing_an_issue
2608 2642 issue = Issue.find(1)
2609 2643 issue.status = IssueStatus.find(2)
2610 2644 assert_equal false, issue.closing?
2611 2645 issue.status = IssueStatus.find(5)
2612 2646 assert_equal true, issue.closing?
2613 2647 end
2614 2648
2615 2649 def test_closing_should_return_true_when_closing_an_issue_with_status_id
2616 2650 issue = Issue.find(1)
2617 2651 issue.status_id = 2
2618 2652 assert_equal false, issue.closing?
2619 2653 issue.status_id = 5
2620 2654 assert_equal true, issue.closing?
2621 2655 end
2622 2656
2623 2657 def test_closing_should_return_true_for_new_closed_issue
2624 2658 issue = Issue.new
2625 2659 assert_equal false, issue.closing?
2626 2660 issue.status = IssueStatus.find(5)
2627 2661 assert_equal true, issue.closing?
2628 2662 end
2629 2663
2630 2664 def test_closing_should_return_true_for_new_closed_issue_with_status_id
2631 2665 issue = Issue.new
2632 2666 assert_equal false, issue.closing?
2633 2667 issue.status_id = 5
2634 2668 assert_equal true, issue.closing?
2635 2669 end
2636 2670
2637 2671 def test_closing_should_be_reset_after_save
2638 2672 issue = Issue.find(1)
2639 2673 issue.status_id = 5
2640 2674 assert_equal true, issue.closing?
2641 2675 issue.save!
2642 2676 assert_equal false, issue.closing?
2643 2677 end
2644 2678
2645 2679 def test_reopening_should_return_true_when_reopening_an_issue
2646 2680 issue = Issue.find(8)
2647 2681 issue.status = IssueStatus.find(6)
2648 2682 assert_equal false, issue.reopening?
2649 2683 issue.status = IssueStatus.find(2)
2650 2684 assert_equal true, issue.reopening?
2651 2685 end
2652 2686
2653 2687 def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
2654 2688 issue = Issue.find(8)
2655 2689 issue.status_id = 6
2656 2690 assert_equal false, issue.reopening?
2657 2691 issue.status_id = 2
2658 2692 assert_equal true, issue.reopening?
2659 2693 end
2660 2694
2661 2695 def test_reopening_should_return_false_for_new_open_issue
2662 2696 issue = Issue.new
2663 2697 issue.status = IssueStatus.find(1)
2664 2698 assert_equal false, issue.reopening?
2665 2699 end
2666 2700
2667 2701 def test_reopening_should_be_reset_after_save
2668 2702 issue = Issue.find(8)
2669 2703 issue.status_id = 2
2670 2704 assert_equal true, issue.reopening?
2671 2705 issue.save!
2672 2706 assert_equal false, issue.reopening?
2673 2707 end
2674 2708
2675 2709 def test_default_status_without_tracker_should_be_nil
2676 2710 issue = Issue.new
2677 2711 assert_nil issue.tracker
2678 2712 assert_nil issue.default_status
2679 2713 end
2680 2714
2681 2715 def test_default_status_should_be_tracker_default_status
2682 2716 issue = Issue.new(:tracker_id => 1)
2683 2717 assert_not_nil issue.status
2684 2718 assert_equal issue.tracker.default_status, issue.default_status
2685 2719 end
2686 2720
2687 2721 def test_initializing_with_tracker_should_set_default_status
2688 2722 issue = Issue.new(:tracker => Tracker.find(1))
2689 2723 assert_not_nil issue.status
2690 2724 assert_equal issue.default_status, issue.status
2691 2725 end
2692 2726
2693 2727 def test_initializing_with_tracker_id_should_set_default_status
2694 2728 issue = Issue.new(:tracker_id => 1)
2695 2729 assert_not_nil issue.status
2696 2730 assert_equal issue.default_status, issue.status
2697 2731 end
2698 2732
2699 2733 def test_setting_tracker_should_set_default_status
2700 2734 issue = Issue.new
2701 2735 issue.tracker = Tracker.find(1)
2702 2736 assert_not_nil issue.status
2703 2737 assert_equal issue.default_status, issue.status
2704 2738 end
2705 2739
2706 2740 def test_changing_tracker_should_set_default_status_if_status_was_default
2707 2741 WorkflowTransition.delete_all
2708 2742 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
2709 2743 Tracker.find(2).update! :default_status_id => 2
2710 2744
2711 2745 issue = Issue.new(:tracker_id => 1, :status_id => 1)
2712 2746 assert_equal IssueStatus.find(1), issue.status
2713 2747 issue.tracker = Tracker.find(2)
2714 2748 assert_equal IssueStatus.find(2), issue.status
2715 2749 end
2716 2750
2717 2751 def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
2718 2752 WorkflowTransition.delete_all
2719 2753 Tracker.find(2).update! :default_status_id => 2
2720 2754
2721 2755 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2722 2756 assert_equal IssueStatus.find(3), issue.status
2723 2757 issue.tracker = Tracker.find(2)
2724 2758 assert_equal IssueStatus.find(2), issue.status
2725 2759 end
2726 2760
2727 2761 def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
2728 2762 WorkflowTransition.delete_all
2729 2763 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
2730 2764 Tracker.find(2).update! :default_status_id => 2
2731 2765
2732 2766 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2733 2767 assert_equal IssueStatus.find(3), issue.status
2734 2768 issue.tracker = Tracker.find(2)
2735 2769 assert_equal IssueStatus.find(3), issue.status
2736 2770 end
2737 2771
2738 2772 def test_assigned_to_was_with_a_group
2739 2773 group = Group.find(10)
2740 2774
2741 2775 issue = Issue.generate!(:assigned_to => group)
2742 2776 issue.reload.assigned_to = nil
2743 2777 assert_equal group, issue.assigned_to_was
2744 2778 end
2745 2779 end
General Comments 0
You need to be logged in to leave comments. Login now