jro_apps/redmine Commit - r13352:fcf9cf7bb17e

Misc tests....

Jean-Philippe Lang -

r13352:fcf9cf7bb17e

parent child

Context file:

r13352:fcf9cf7bb17e

app/models/mail_handler.rb +1 -1

               # Receives an email and rescues any exception
               def self.safe_receive(*args)
                 receive(*args)
-              rescue => e
+              rescue Exception => e
                 logger.error "An unexpected error occurred when receiving email: #{e.message}" if logger
                 return false
               end

test/unit/mail_handler_test.rb +6 0

                 }, options)
               end
+              def test_safe_receive_should_rescue_exceptions_and_return_false
+                MailHandler.stubs(:receive).raises(Exception.new "Something went wrong")
+                assert_equal false, MailHandler.safe_receive
+              end
               private
               def submit_email(filename, options={})

test/unit/mailer_test.rb +13 0

@@ -758,6 +758,19 class MailerTest < ActiveSupport::TestCase
758	assert_kind_of ::Mail::Message, Mailer.test_email(User.find(1))	758	assert_kind_of ::Mail::Message, Mailer.test_email(User.find(1))
759	end	759	end
760		760
		761	def test_with_synched_deliveries_should_yield_with_synced_deliveries
		762	ActionMailer::Base.delivery_method = :async_smtp
		763	ActionMailer::Base.async_smtp_settings = {:foo => 'bar'}
		764
		765	Mailer.with_synched_deliveries do
		766	assert_equal :smtp, ActionMailer::Base.delivery_method
		767	assert_equal({:foo => 'bar'}, ActionMailer::Base.smtp_settings)
		768	end
		769	assert_equal :async_smtp, ActionMailer::Base.delivery_method
		770	ensure
		771	ActionMailer::Base.delivery_method = :test
		772	end
		773
761	private	774	private
762		775
763	def last_email	776	def last_email

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages