##// END OF EJS Templates
Fixed: Private flag ignored when creating an issue with set_own_issues_private permission only (#8472)....
Jean-Philippe Lang -
r5871:fccf15c2a242
parent child
Show More
@@ -301,6 +301,7 private
301 301 end
302 302
303 303 @issue.project = @project
304 @issue.author = User.current
304 305 # Tracker must be set before custom field values
305 306 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
306 307 if @issue.tracker.nil?
@@ -314,7 +315,6 private
314 315 @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
315 316 end
316 317 end
317 @issue.author = User.current
318 318 @priorities = IssuePriority.all
319 319 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
320 320 end
@@ -22,6 +22,7 roles_001:
22 22 - :delete_issues
23 23 - :view_issue_watchers
24 24 - :add_issue_watchers
25 - :set_issues_private
25 26 - :delete_issue_watchers
26 27 - :manage_public_queries
27 28 - :save_queries
@@ -606,6 +606,36 class IssuesControllerTest < ActionController::TestCase
606 606 assert_not_nil issue
607 607 assert_nil issue.parent
608 608 end
609
610 def test_post_create_private
611 @request.session[:user_id] = 2
612
613 assert_difference 'Issue.count' do
614 post :create, :project_id => 1,
615 :issue => {:tracker_id => 1,
616 :subject => 'This is a private issue',
617 :is_private => '1'}
618 end
619 issue = Issue.first(:order => 'id DESC')
620 assert issue.is_private?
621 end
622
623 def test_post_create_private_with_set_own_issues_private_permission
624 role = Role.find(1)
625 role.remove_permission! :set_issues_private
626 role.add_permission! :set_own_issues_private
627
628 @request.session[:user_id] = 2
629
630 assert_difference 'Issue.count' do
631 post :create, :project_id => 1,
632 :issue => {:tracker_id => 1,
633 :subject => 'This is a private issue',
634 :is_private => '1'}
635 end
636 issue = Issue.first(:order => 'id DESC')
637 assert issue.is_private?
638 end
609 639
610 640 def test_post_create_should_send_a_notification
611 641 ActionMailer::Base.deliveries.clear
General Comments 0
You need to be logged in to leave comments. Login now