##// END OF EJS Templates
jro_apps » redmine
RSS
Adds tests for default custom field value (#21074)....
Jean-Philippe Lang -
r14386:fac0f7f38b1d
parent child
Show More
Side by Side Unified
Context file:
r14386:fac0f7f38b1d Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,704 +1,782
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../../test_helper', __FILE__)
19 19
20 20 class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :issue_relations,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries,
45 45 :attachments
46 46
47 47 test "GET /issues.xml should contain metadata" do
48 48 get '/issues.xml'
49 49 assert_select 'issues[type=array][total_count=?][limit="25"][offset="0"]',
50 50 assigns(:issue_count).to_s
51 51 end
52 52
53 53 test "GET /issues.xml with nometa param should not contain metadata" do
54 54 get '/issues.xml?nometa=1'
55 55 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
56 56 end
57 57
58 58 test "GET /issues.xml with nometa header should not contain metadata" do
59 59 get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
60 60 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
61 61 end
62 62
63 63 test "GET /issues.xml with offset and limit" do
64 64 get '/issues.xml?offset=2&limit=3'
65 65
66 66 assert_equal 3, assigns(:limit)
67 67 assert_equal 2, assigns(:offset)
68 68 assert_select 'issues issue', 3
69 69 end
70 70
71 71 test "GET /issues.xml with relations" do
72 72 get '/issues.xml?include=relations'
73 73
74 74 assert_response :success
75 75 assert_equal 'application/xml', @response.content_type
76 76
77 77 assert_select 'issue id', :text => '3' do
78 78 assert_select '~ relations relation', 1
79 79 assert_select '~ relations relation[id="2"][issue_id="2"][issue_to_id="3"][relation_type=relates]'
80 80 end
81 81
82 82 assert_select 'issue id', :text => '1' do
83 83 assert_select '~ relations'
84 84 assert_select '~ relations relation', 0
85 85 end
86 86 end
87 87
88 88 test "GET /issues.xml with invalid query params" do
89 89 get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
90 90
91 91 assert_response :unprocessable_entity
92 92 assert_equal 'application/xml', @response.content_type
93 93 assert_select 'errors error', :text => "Start date cannot be blank"
94 94 end
95 95
96 96 test "GET /issues.xml with custom field filter" do
97 97 get '/issues.xml',
98 98 {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='}, :v => {:cf_1 => ['MySQL']}}
99 99
100 100 expected_ids = Issue.visible.
101 101 joins(:custom_values).
102 102 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
103 103 assert expected_ids.any?
104 104
105 105 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
106 106 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
107 107 end
108 108 end
109 109
110 110 test "GET /issues.xml with custom field filter (shorthand method)" do
111 111 get '/issues.xml', {:cf_1 => 'MySQL'}
112 112
113 113 expected_ids = Issue.visible.
114 114 joins(:custom_values).
115 115 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
116 116 assert expected_ids.any?
117 117
118 118 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
119 119 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
120 120 end
121 121 end
122 122
123 123 def test_index_should_include_issue_attributes
124 124 get '/issues.xml'
125 125 assert_select 'issues>issue>is_private', :text => 'false'
126 126 end
127 127
128 128 def test_index_should_allow_timestamp_filtering
129 129 Issue.delete_all
130 130 Issue.generate!(:subject => '1').update_column(:updated_on, Time.parse("2014-01-02T10:25:00Z"))
131 131 Issue.generate!(:subject => '2').update_column(:updated_on, Time.parse("2014-01-02T12:13:00Z"))
132 132
133 133 get '/issues.xml',
134 134 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '<='},
135 135 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
136 136 assert_select 'issues>issue', :count => 1
137 137 assert_select 'issues>issue>subject', :text => '1'
138 138
139 139 get '/issues.xml',
140 140 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
141 141 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
142 142 assert_select 'issues>issue', :count => 1
143 143 assert_select 'issues>issue>subject', :text => '2'
144 144
145 145 get '/issues.xml',
146 146 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
147 147 :v => {:updated_on => ['2014-01-02T08:00:00Z']}}
148 148 assert_select 'issues>issue', :count => 2
149 149 end
150 150
151 151 test "GET /issues.xml with filter" do
152 152 get '/issues.xml?status_id=5'
153 153
154 154 expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
155 155 assert expected_ids.any?
156 156
157 157 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
158 158 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
159 159 end
160 160 end
161 161
162 162 test "GET /issues.json with filter" do
163 163 get '/issues.json?status_id=5'
164 164
165 165 json = ActiveSupport::JSON.decode(response.body)
166 166 status_ids_used = json['issues'].collect {|j| j['status']['id'] }
167 167 assert_equal 3, status_ids_used.length
168 168 assert status_ids_used.all? {|id| id == 5 }
169 169 end
170 170
171 171 test "GET /issues/:id.xml with journals" do
172 172 get '/issues/1.xml?include=journals'
173 173
174 174 assert_select 'issue journals[type=array]' do
175 175 assert_select 'journal[id="1"]' do
176 176 assert_select 'details[type=array]' do
177 177 assert_select 'detail[name=status_id]' do
178 178 assert_select 'old_value', :text => '1'
179 179 assert_select 'new_value', :text => '2'
180 180 end
181 181 end
182 182 end
183 183 end
184 184 end
185 185
186 186 test "GET /issues/:id.xml with journals should format timestamps in ISO 8601" do
187 187 get '/issues/1.xml?include=journals'
188 188
189 189 iso_date = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/
190 190 assert_select 'issue>created_on', :text => iso_date
191 191 assert_select 'issue>updated_on', :text => iso_date
192 192 assert_select 'issue journal>created_on', :text => iso_date
193 193 end
194 194
195 195 test "GET /issues/:id.xml with custom fields" do
196 196 get '/issues/3.xml'
197 197
198 198 assert_select 'issue custom_fields[type=array]' do
199 199 assert_select 'custom_field[id="1"]' do
200 200 assert_select 'value', :text => 'MySQL'
201 201 end
202 202 end
203 203 assert_nothing_raised do
204 204 Hash.from_xml(response.body).to_xml
205 205 end
206 206 end
207 207
208 208 test "GET /issues/:id.xml with multi custom fields" do
209 209 field = CustomField.find(1)
210 210 field.update_attribute :multiple, true
211 211 issue = Issue.find(3)
212 212 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
213 213 issue.save!
214 214
215 215 get '/issues/3.xml'
216 216 assert_response :success
217 217
218 218 assert_select 'issue custom_fields[type=array]' do
219 219 assert_select 'custom_field[id="1"]' do
220 220 assert_select 'value[type=array] value', 2
221 221 end
222 222 end
223 223 xml = Hash.from_xml(response.body)
224 224 custom_fields = xml['issue']['custom_fields']
225 225 assert_kind_of Array, custom_fields
226 226 field = custom_fields.detect {|f| f['id'] == '1'}
227 227 assert_kind_of Hash, field
228 228 assert_equal ['MySQL', 'Oracle'], field['value'].sort
229 229 end
230 230
231 231 test "GET /issues/:id.json with multi custom fields" do
232 232 field = CustomField.find(1)
233 233 field.update_attribute :multiple, true
234 234 issue = Issue.find(3)
235 235 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
236 236 issue.save!
237 237
238 238 get '/issues/3.json'
239 239 assert_response :success
240 240
241 241 json = ActiveSupport::JSON.decode(response.body)
242 242 custom_fields = json['issue']['custom_fields']
243 243 assert_kind_of Array, custom_fields
244 244 field = custom_fields.detect {|f| f['id'] == 1}
245 245 assert_kind_of Hash, field
246 246 assert_equal ['MySQL', 'Oracle'], field['value'].sort
247 247 end
248 248
249 249 test "GET /issues/:id.xml with empty value for multi custom field" do
250 250 field = CustomField.find(1)
251 251 field.update_attribute :multiple, true
252 252 issue = Issue.find(3)
253 253 issue.custom_field_values = {1 => ['']}
254 254 issue.save!
255 255
256 256 get '/issues/3.xml'
257 257
258 258 assert_select 'issue custom_fields[type=array]' do
259 259 assert_select 'custom_field[id="1"]' do
260 260 assert_select 'value[type=array]:empty'
261 261 end
262 262 end
263 263 xml = Hash.from_xml(response.body)
264 264 custom_fields = xml['issue']['custom_fields']
265 265 assert_kind_of Array, custom_fields
266 266 field = custom_fields.detect {|f| f['id'] == '1'}
267 267 assert_kind_of Hash, field
268 268 assert_equal [], field['value']
269 269 end
270 270
271 271 test "GET /issues/:id.json with empty value for multi custom field" do
272 272 field = CustomField.find(1)
273 273 field.update_attribute :multiple, true
274 274 issue = Issue.find(3)
275 275 issue.custom_field_values = {1 => ['']}
276 276 issue.save!
277 277
278 278 get '/issues/3.json'
279 279 assert_response :success
280 280 json = ActiveSupport::JSON.decode(response.body)
281 281 custom_fields = json['issue']['custom_fields']
282 282 assert_kind_of Array, custom_fields
283 283 field = custom_fields.detect {|f| f['id'] == 1}
284 284 assert_kind_of Hash, field
285 285 assert_equal [], field['value'].sort
286 286 end
287 287
288 288 test "GET /issues/:id.xml with attachments" do
289 289 get '/issues/3.xml?include=attachments'
290 290
291 291 assert_select 'issue attachments[type=array]' do
292 292 assert_select 'attachment', 4
293 293 assert_select 'attachment id', :text => '1' do
294 294 assert_select '~ filename', :text => 'error281.txt'
295 295 assert_select '~ content_url', :text => 'http://www.example.com/attachments/download/1/error281.txt'
296 296 end
297 297 end
298 298 end
299 299
300 300 test "GET /issues/:id.xml with subtasks" do
301 301 issue = Issue.generate_with_descendants!(:project_id => 1)
302 302 get "/issues/#{issue.id}.xml?include=children"
303 303
304 304 assert_select 'issue id', :text => issue.id.to_s do
305 305 assert_select '~ children[type=array] > issue', 2
306 306 assert_select '~ children[type=array] > issue > children', 1
307 307 end
308 308 end
309 309
310 310 test "GET /issues/:id.json with subtasks" do
311 311 issue = Issue.generate_with_descendants!(:project_id => 1)
312 312 get "/issues/#{issue.id}.json?include=children"
313 313
314 314 json = ActiveSupport::JSON.decode(response.body)
315 315 assert_equal 2, json['issue']['children'].size
316 316 assert_equal 1, json['issue']['children'].select {|child| child.key?('children')}.size
317 317 end
318 318
319 319 def test_show_should_include_issue_attributes
320 320 get '/issues/1.xml'
321 321 assert_select 'issue>is_private', :text => 'false'
322 322 end
323 323
324 324 test "GET /issues/:id.xml?include=watchers should include watchers" do
325 325 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
326 326
327 327 get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
328 328
329 329 assert_response :ok
330 330 assert_equal 'application/xml', response.content_type
331 331 assert_select 'issue' do
332 332 assert_select 'watchers', Issue.find(1).watchers.count
333 333 assert_select 'watchers' do
334 334 assert_select 'user[id="3"]'
335 335 end
336 336 end
337 337 end
338 338
339 339 test "POST /issues.xml should create an issue with the attributes" do
340 340
341 341 payload = <<-XML
342 342 <?xml version="1.0" encoding="UTF-8" ?>
343 343 <issue>
344 344 <project_id>1</project_id>
345 345 <tracker_id>2</tracker_id>
346 346 <status_id>3</status_id>
347 347 <subject>API test</subject>
348 348 </issue>
349 349 XML
350 350
351 351 assert_difference('Issue.count') do
352 352 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
353 353 end
354 354 issue = Issue.order('id DESC').first
355 355 assert_equal 1, issue.project_id
356 356 assert_equal 2, issue.tracker_id
357 357 assert_equal 3, issue.status_id
358 358 assert_equal 'API test', issue.subject
359 359
360 360 assert_response :created
361 361 assert_equal 'application/xml', @response.content_type
362 362 assert_select 'issue > id', :text => issue.id.to_s
363 363 end
364 364
365 365 test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
366 366 assert_difference('Issue.count') do
367 367 post '/issues.xml',
368 368 {:issue => {:project_id => 1, :subject => 'Watchers',
369 369 :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
370 370 assert_response :created
371 371 end
372 372 issue = Issue.order('id desc').first
373 373 assert_equal 2, issue.watchers.size
374 374 assert_equal [1, 3], issue.watcher_user_ids.sort
375 375 end
376 376
377 377 test "POST /issues.xml with failure should return errors" do
378 378 assert_no_difference('Issue.count') do
379 379 post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
380 380 end
381 381
382 382 assert_select 'errors error', :text => "Subject cannot be blank"
383 383 end
384 384
385 385 test "POST /issues.json should create an issue with the attributes" do
386 386
387 387 payload = <<-JSON
388 388 {
389 389 "issue": {
390 390 "project_id": "1",
391 391 "tracker_id": "2",
392 392 "status_id": "3",
393 393 "subject": "API test"
394 394 }
395 395 }
396 396 JSON
397 397
398 398 assert_difference('Issue.count') do
399 399 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
400 400 end
401 401
402 402 issue = Issue.order('id DESC').first
403 403 assert_equal 1, issue.project_id
404 404 assert_equal 2, issue.tracker_id
405 405 assert_equal 3, issue.status_id
406 406 assert_equal 'API test', issue.subject
407 407 end
408 408
409 409 test "POST /issues.json without tracker_id should accept custom fields" do
410 410 field = IssueCustomField.generate!(
411 411 :field_format => 'list',
412 412 :multiple => true,
413 413 :possible_values => ["V1", "V2", "V3"],
414 414 :default_value => "V2",
415 415 :is_for_all => true,
416 416 :trackers => Tracker.all.to_a
417 417 )
418 418
419 419 payload = <<-JSON
420 420 {
421 421 "issue": {
422 422 "project_id": "1",
423 423 "subject": "Multivalued custom field",
424 424 "custom_field_values":{"#{field.id}":["V1","V3"]}
425 425 }
426 426 }
427 427 JSON
428 428
429 429 assert_difference('Issue.count') do
430 430 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
431 431 end
432 432
433 433 assert_response :created
434 434 issue = Issue.order('id DESC').first
435 435 assert_equal ["V1", "V3"], issue.custom_field_value(field).sort
436 436 end
437 437
438 test "POST /issues.json with omitted custom field should set default value" do
439 field = IssueCustomField.generate!(:default_value => "Default")
440
441 issue = new_record(Issue) do
442 post '/issues.json',
443 {:issue => {:project_id => 1, :subject => 'API', :custom_field_values => {}}},
444 credentials('jsmith')
445 end
446 assert_equal "Default", issue.custom_field_value(field)
447 end
448
449 test "POST /issues.json with custom field set to blank should not set default value" do
450 field = IssueCustomField.generate!(:default_value => "Default")
451
452 issue = new_record(Issue) do
453 post '/issues.json',
454 {:issue => {:project_id => 1, :subject => 'API', :custom_field_values => {field.id.to_s => ""}}},
455 credentials('jsmith')
456 end
457 assert_equal "", issue.custom_field_value(field)
458 end
459
438 460 test "POST /issues.json with failure should return errors" do
439 461 assert_no_difference('Issue.count') do
440 462 post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
441 463 end
442 464
443 465 json = ActiveSupport::JSON.decode(response.body)
444 466 assert json['errors'].include?("Subject cannot be blank")
445 467 end
446 468
447 469 test "POST /issues.json with invalid project_id should respond with 422" do
448 470 post '/issues.json', {:issue => {:project_id => 999, :subject => "API"}}, credentials('jsmith')
449 471 assert_response 422
450 472 end
451 473
452 474 test "PUT /issues/:id.xml" do
453 475 assert_difference('Journal.count') do
454 476 put '/issues/6.xml',
455 477 {:issue => {:subject => 'API update', :notes => 'A new note'}},
456 478 credentials('jsmith')
457 479 end
458 480
459 481 issue = Issue.find(6)
460 482 assert_equal "API update", issue.subject
461 483 journal = Journal.last
462 484 assert_equal "A new note", journal.notes
463 485 end
464 486
465 487 test "PUT /issues/:id.xml with custom fields" do
466 488 put '/issues/3.xml',
467 489 {:issue => {:custom_fields => [
468 490 {'id' => '1', 'value' => 'PostgreSQL' },
469 491 {'id' => '2', 'value' => '150'}
470 492 ]}},
471 493 credentials('jsmith')
472 494
473 495 issue = Issue.find(3)
474 496 assert_equal '150', issue.custom_value_for(2).value
475 497 assert_equal 'PostgreSQL', issue.custom_value_for(1).value
476 498 end
477 499
478 500 test "PUT /issues/:id.xml with multi custom fields" do
479 501 field = CustomField.find(1)
480 502 field.update_attribute :multiple, true
481 503
482 504 put '/issues/3.xml',
483 505 {:issue => {:custom_fields => [
484 506 {'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
485 507 {'id' => '2', 'value' => '150'}
486 508 ]}},
487 509 credentials('jsmith')
488 510
489 511 issue = Issue.find(3)
490 512 assert_equal '150', issue.custom_value_for(2).value
491 513 assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
492 514 end
493 515
494 516 test "PUT /issues/:id.xml with project change" do
495 517 put '/issues/3.xml',
496 518 {:issue => {:project_id => 2, :subject => 'Project changed'}},
497 519 credentials('jsmith')
498 520
499 521 issue = Issue.find(3)
500 522 assert_equal 2, issue.project_id
501 523 assert_equal 'Project changed', issue.subject
502 524 end
503 525
504 526 test "PUT /issues/:id.xml with notes only" do
505 527 assert_difference('Journal.count') do
506 528 put '/issues/6.xml',
507 529 {:issue => {:notes => 'Notes only'}},
508 530 credentials('jsmith')
509 531 end
510 532
511 533 journal = Journal.last
512 534 assert_equal "Notes only", journal.notes
513 535 end
514 536
537 test "PUT /issues/:id.json with omitted custom field should not change blank value to default value" do
538 field = IssueCustomField.generate!(:default_value => "Default")
539 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id.to_s => ""})
540 assert_equal "", issue.reload.custom_field_value(field)
541
542 assert_difference('Journal.count') do
543 put "/issues/#{issue.id}.json",
544 {:issue => {:custom_field_values => {}, :notes => 'API'}},
545 credentials('jsmith')
546 end
547
548 assert_equal "", issue.reload.custom_field_value(field)
549 end
550
551 test "PUT /issues/:id.json with custom field set to blank should not change blank value to default value" do
552 field = IssueCustomField.generate!(:default_value => "Default")
553 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id.to_s => ""})
554 assert_equal "", issue.reload.custom_field_value(field)
555
556 assert_difference('Journal.count') do
557 put "/issues/#{issue.id}.json",
558 {:issue => {:custom_field_values => {field.id.to_s => ""}, :notes => 'API'}},
559 credentials('jsmith')
560 end
561
562 assert_equal "", issue.reload.custom_field_value(field)
563 end
564
565 test "PUT /issues/:id.json with tracker change and omitted custom field specific to that tracker does not set default value" do
566 field = IssueCustomField.generate!(:default_value => "Default", :tracker_ids => [2])
567 issue = Issue.generate!(:project_id => 1, :tracker_id => 1)
568
569 assert_difference('Journal.count') do
570 put "/issues/#{issue.id}.json",
571 {:issue => {:tracker_id => 2, :custom_field_values => {}, :notes => 'API'}},
572 credentials('jsmith')
573 end
574
575 assert_equal 2, issue.reload.tracker_id
576 assert_nil issue.reload.custom_field_value(field)
577 end
578
579 test "PUT /issues/:id.json with tracker change and custom field specific to that tracker set to blank should not set default value" do
580 field = IssueCustomField.generate!(:default_value => "Default", :tracker_ids => [2])
581 issue = Issue.generate!(:project_id => 1, :tracker_id => 1)
582
583 assert_difference('Journal.count') do
584 put "/issues/#{issue.id}.json",
585 {:issue => {:tracker_id => 2, :custom_field_values => {field.id.to_s => ""}, :notes => 'API'}},
586 credentials('jsmith')
587 end
588
589 assert_equal 2, issue.reload.tracker_id
590 assert_equal "", issue.reload.custom_field_value(field)
591 end
592
515 593 test "PUT /issues/:id.xml with failed update" do
516 594 put '/issues/6.xml', {:issue => {:subject => ''}}, credentials('jsmith')
517 595
518 596 assert_response :unprocessable_entity
519 597 assert_select 'errors error', :text => "Subject cannot be blank"
520 598 end
521 599
522 600 test "PUT /issues/:id.json" do
523 601 assert_difference('Journal.count') do
524 602 put '/issues/6.json',
525 603 {:issue => {:subject => 'API update', :notes => 'A new note'}},
526 604 credentials('jsmith')
527 605
528 606 assert_response :ok
529 607 assert_equal '', response.body
530 608 end
531 609
532 610 issue = Issue.find(6)
533 611 assert_equal "API update", issue.subject
534 612 journal = Journal.last
535 613 assert_equal "A new note", journal.notes
536 614 end
537 615
538 616 test "PUT /issues/:id.json with failed update" do
539 617 put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
540 618
541 619 assert_response :unprocessable_entity
542 620 json = ActiveSupport::JSON.decode(response.body)
543 621 assert json['errors'].include?("Subject cannot be blank")
544 622 end
545 623
546 624 test "DELETE /issues/:id.xml" do
547 625 assert_difference('Issue.count', -1) do
548 626 delete '/issues/6.xml', {}, credentials('jsmith')
549 627
550 628 assert_response :ok
551 629 assert_equal '', response.body
552 630 end
553 631 assert_nil Issue.find_by_id(6)
554 632 end
555 633
556 634 test "DELETE /issues/:id.json" do
557 635 assert_difference('Issue.count', -1) do
558 636 delete '/issues/6.json', {}, credentials('jsmith')
559 637
560 638 assert_response :ok
561 639 assert_equal '', response.body
562 640 end
563 641 assert_nil Issue.find_by_id(6)
564 642 end
565 643
566 644 test "POST /issues/:id/watchers.xml should add watcher" do
567 645 assert_difference 'Watcher.count' do
568 646 post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
569 647
570 648 assert_response :ok
571 649 assert_equal '', response.body
572 650 end
573 651 watcher = Watcher.order('id desc').first
574 652 assert_equal Issue.find(1), watcher.watchable
575 653 assert_equal User.find(3), watcher.user
576 654 end
577 655
578 656 test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
579 657 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
580 658
581 659 assert_difference 'Watcher.count', -1 do
582 660 delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
583 661
584 662 assert_response :ok
585 663 assert_equal '', response.body
586 664 end
587 665 assert_equal false, Issue.find(1).watched_by?(User.find(3))
588 666 end
589 667
590 668 def test_create_issue_with_uploaded_file
591 669 token = xml_upload('test_create_with_upload', credentials('jsmith'))
592 670 attachment = Attachment.find_by_token(token)
593 671
594 672 # create the issue with the upload's token
595 673 assert_difference 'Issue.count' do
596 674 post '/issues.xml',
597 675 {:issue => {:project_id => 1, :subject => 'Uploaded file',
598 676 :uploads => [{:token => token, :filename => 'test.txt',
599 677 :content_type => 'text/plain'}]}},
600 678 credentials('jsmith')
601 679 assert_response :created
602 680 end
603 681 issue = Issue.order('id DESC').first
604 682 assert_equal 1, issue.attachments.count
605 683 assert_equal attachment, issue.attachments.first
606 684
607 685 attachment.reload
608 686 assert_equal 'test.txt', attachment.filename
609 687 assert_equal 'text/plain', attachment.content_type
610 688 assert_equal 'test_create_with_upload'.size, attachment.filesize
611 689 assert_equal 2, attachment.author_id
612 690
613 691 # get the issue with its attachments
614 692 get "/issues/#{issue.id}.xml", :include => 'attachments'
615 693 assert_response :success
616 694 xml = Hash.from_xml(response.body)
617 695 attachments = xml['issue']['attachments']
618 696 assert_kind_of Array, attachments
619 697 assert_equal 1, attachments.size
620 698 url = attachments.first['content_url']
621 699 assert_not_nil url
622 700
623 701 # download the attachment
624 702 get url
625 703 assert_response :success
626 704 assert_equal 'test_create_with_upload', response.body
627 705 end
628 706
629 707 def test_create_issue_with_multiple_uploaded_files_as_xml
630 708 token1 = xml_upload('File content 1', credentials('jsmith'))
631 709 token2 = xml_upload('File content 2', credentials('jsmith'))
632 710
633 711 payload = <<-XML
634 712 <?xml version="1.0" encoding="UTF-8" ?>
635 713 <issue>
636 714 <project_id>1</project_id>
637 715 <tracker_id>1</tracker_id>
638 716 <subject>Issue with multiple attachments</subject>
639 717 <uploads type="array">
640 718 <upload>
641 719 <token>#{token1}</token>
642 720 <filename>test1.txt</filename>
643 721 </upload>
644 722 <upload>
645 723 <token>#{token2}</token>
646 724 <filename>test1.txt</filename>
647 725 </upload>
648 726 </uploads>
649 727 </issue>
650 728 XML
651 729
652 730 assert_difference 'Issue.count' do
653 731 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
654 732 assert_response :created
655 733 end
656 734 issue = Issue.order('id DESC').first
657 735 assert_equal 2, issue.attachments.count
658 736 end
659 737
660 738 def test_create_issue_with_multiple_uploaded_files_as_json
661 739 token1 = json_upload('File content 1', credentials('jsmith'))
662 740 token2 = json_upload('File content 2', credentials('jsmith'))
663 741
664 742 payload = <<-JSON
665 743 {
666 744 "issue": {
667 745 "project_id": "1",
668 746 "tracker_id": "1",
669 747 "subject": "Issue with multiple attachments",
670 748 "uploads": [
671 749 {"token": "#{token1}", "filename": "test1.txt"},
672 750 {"token": "#{token2}", "filename": "test2.txt"}
673 751 ]
674 752 }
675 753 }
676 754 JSON
677 755
678 756 assert_difference 'Issue.count' do
679 757 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
680 758 assert_response :created
681 759 end
682 760 issue = Issue.order('id DESC').first
683 761 assert_equal 2, issue.attachments.count
684 762 end
685 763
686 764 def test_update_issue_with_uploaded_file
687 765 token = xml_upload('test_upload_with_upload', credentials('jsmith'))
688 766 attachment = Attachment.find_by_token(token)
689 767
690 768 # update the issue with the upload's token
691 769 assert_difference 'Journal.count' do
692 770 put '/issues/1.xml',
693 771 {:issue => {:notes => 'Attachment added',
694 772 :uploads => [{:token => token, :filename => 'test.txt',
695 773 :content_type => 'text/plain'}]}},
696 774 credentials('jsmith')
697 775 assert_response :ok
698 776 assert_equal '', @response.body
699 777 end
700 778
701 779 issue = Issue.find(1)
702 780 assert_include attachment, issue.attachments
703 781 end
704 782 end
Show file before | Show file after | Hide comments
@@ -1,264 +1,271
1 1 module ObjectHelpers
2 2 def User.generate!(attributes={})
3 3 @generated_user_login ||= 'user0'
4 4 @generated_user_login.succ!
5 5 user = User.new(attributes)
6 6 user.login = @generated_user_login.dup if user.login.blank?
7 7 user.mail = "#{@generated_user_login}@example.com" if user.mail.blank?
8 8 user.firstname = "Bob" if user.firstname.blank?
9 9 user.lastname = "Doe" if user.lastname.blank?
10 10 yield user if block_given?
11 11 user.save!
12 12 user
13 13 end
14 14
15 15 def User.add_to_project(user, project, roles=nil)
16 16 roles = Role.find(1) if roles.nil?
17 17 roles = [roles] if roles.is_a?(Role)
18 18 Member.create!(:principal => user, :project => project, :roles => roles)
19 19 end
20 20
21 21 def Group.generate!(attributes={})
22 22 @generated_group_name ||= 'Group 0'
23 23 @generated_group_name.succ!
24 24 group = Group.new(attributes)
25 25 group.name = @generated_group_name.dup if group.name.blank?
26 26 yield group if block_given?
27 27 group.save!
28 28 group
29 29 end
30 30
31 31 def Project.generate!(attributes={})
32 32 @generated_project_identifier ||= 'project-0000'
33 33 @generated_project_identifier.succ!
34 34 project = Project.new(attributes)
35 35 project.name = @generated_project_identifier.dup if project.name.blank?
36 36 project.identifier = @generated_project_identifier.dup if project.identifier.blank?
37 37 yield project if block_given?
38 38 project.save!
39 39 project
40 40 end
41 41
42 42 def Project.generate_with_parent!(*args)
43 43 attributes = args.last.is_a?(Hash) ? args.pop : {}
44 44 parent = args.size > 0 ? args.first : Project.generate!
45 45
46 46 project = Project.generate!(attributes) do |p|
47 47 p.parent = parent
48 48 end
49 49 parent.reload if parent
50 50 project
51 51 end
52 52
53 53 def IssueStatus.generate!(attributes={})
54 54 @generated_status_name ||= 'Status 0'
55 55 @generated_status_name.succ!
56 56 status = IssueStatus.new(attributes)
57 57 status.name = @generated_status_name.dup if status.name.blank?
58 58 yield status if block_given?
59 59 status.save!
60 60 status
61 61 end
62 62
63 63 def Tracker.generate!(attributes={})
64 64 @generated_tracker_name ||= 'Tracker 0'
65 65 @generated_tracker_name.succ!
66 66 tracker = Tracker.new(attributes)
67 67 tracker.name = @generated_tracker_name.dup if tracker.name.blank?
68 68 tracker.default_status ||= IssueStatus.order('position').first || IssueStatus.generate!
69 69 yield tracker if block_given?
70 70 tracker.save!
71 71 tracker
72 72 end
73 73
74 74 def Role.generate!(attributes={})
75 75 @generated_role_name ||= 'Role 0'
76 76 @generated_role_name.succ!
77 77 role = Role.new(attributes)
78 78 role.name = @generated_role_name.dup if role.name.blank?
79 79 yield role if block_given?
80 80 role.save!
81 81 role
82 82 end
83 83
84 84 # Generates an unsaved Issue
85 85 def Issue.generate(attributes={})
86 86 issue = Issue.new(attributes)
87 87 issue.project ||= Project.find(1)
88 88 issue.tracker ||= issue.project.trackers.first
89 89 issue.subject = 'Generated' if issue.subject.blank?
90 90 issue.author ||= User.find(2)
91 91 yield issue if block_given?
92 92 issue
93 93 end
94 94
95 95 # Generates a saved Issue
96 96 def Issue.generate!(attributes={}, &block)
97 97 issue = Issue.generate(attributes, &block)
98 98 issue.save!
99 99 issue
100 100 end
101 101
102 102 # Generates an issue with 2 children and a grandchild
103 103 def Issue.generate_with_descendants!(attributes={})
104 104 issue = Issue.generate!(attributes)
105 105 child = Issue.generate!(:project => issue.project, :subject => 'Child1', :parent_issue_id => issue.id)
106 106 Issue.generate!(:project => issue.project, :subject => 'Child2', :parent_issue_id => issue.id)
107 107 Issue.generate!(:project => issue.project, :subject => 'Child11', :parent_issue_id => child.id)
108 108 issue.reload
109 109 end
110 110
111 111 def Issue.generate_with_child!(attributes={})
112 112 issue = Issue.generate!(attributes)
113 113 Issue.generate!(:parent_issue_id => issue.id)
114 114 issue.reload
115 115 end
116 116
117 117 def Journal.generate!(attributes={})
118 118 journal = Journal.new(attributes)
119 119 journal.user ||= User.first
120 120 journal.journalized ||= Issue.first
121 121 yield journal if block_given?
122 122 journal.save!
123 123 journal
124 124 end
125 125
126 126 def Version.generate!(attributes={})
127 127 @generated_version_name ||= 'Version 0'
128 128 @generated_version_name.succ!
129 129 version = Version.new(attributes)
130 130 version.name = @generated_version_name.dup if version.name.blank?
131 131 version.project ||= Project.find(1)
132 132 yield version if block_given?
133 133 version.save!
134 134 version
135 135 end
136 136
137 137 def TimeEntry.generate!(attributes={})
138 138 entry = TimeEntry.new(attributes)
139 139 entry.user ||= User.find(2)
140 140 entry.issue ||= Issue.find(1) unless entry.project
141 141 entry.project ||= entry.issue.project
142 142 entry.activity ||= TimeEntryActivity.first
143 143 entry.spent_on ||= Date.today
144 144 entry.hours ||= 1.0
145 145 entry.save!
146 146 entry
147 147 end
148 148
149 149 def AuthSource.generate!(attributes={})
150 150 @generated_auth_source_name ||= 'Auth 0'
151 151 @generated_auth_source_name.succ!
152 152 source = AuthSource.new(attributes)
153 153 source.name = @generated_auth_source_name.dup if source.name.blank?
154 154 yield source if block_given?
155 155 source.save!
156 156 source
157 157 end
158 158
159 159 def Board.generate!(attributes={})
160 160 @generated_board_name ||= 'Forum 0'
161 161 @generated_board_name.succ!
162 162 board = Board.new(attributes)
163 163 board.name = @generated_board_name.dup if board.name.blank?
164 164 board.description = @generated_board_name.dup if board.description.blank?
165 165 yield board if block_given?
166 166 board.save!
167 167 board
168 168 end
169 169
170 170 def Attachment.generate!(attributes={})
171 171 @generated_filename ||= 'testfile0'
172 172 @generated_filename.succ!
173 173 attributes = attributes.dup
174 174 attachment = Attachment.new(attributes)
175 175 attachment.container ||= Issue.find(1)
176 176 attachment.author ||= User.find(2)
177 177 attachment.filename = @generated_filename.dup if attachment.filename.blank?
178 178 attachment.save!
179 179 attachment
180 180 end
181 181
182 182 def CustomField.generate!(attributes={})
183 183 @generated_custom_field_name ||= 'Custom field 0'
184 184 @generated_custom_field_name.succ!
185 185 field = new(attributes)
186 186 field.name = @generated_custom_field_name.dup if field.name.blank?
187 187 field.field_format = 'string' if field.field_format.blank?
188 188 yield field if block_given?
189 189 field.save!
190 190 field
191 191 end
192 192
193 def IssueCustomField.generate!(attributes={})
194 super do |field|
195 field.is_for_all = true unless attributes.key?(:is_for_all)
196 field.tracker_ids = Tracker.all.ids unless attributes.key?(:tracker_ids) || attributes.key?(:trackers)
197 end
198 end
199
193 200 def Changeset.generate!(attributes={})
194 201 @generated_changeset_rev ||= '123456'
195 202 @generated_changeset_rev.succ!
196 203 changeset = new(attributes)
197 204 changeset.repository ||= Project.find(1).repository
198 205 changeset.revision ||= @generated_changeset_rev
199 206 changeset.committed_on ||= Time.now
200 207 yield changeset if block_given?
201 208 changeset.save!
202 209 changeset
203 210 end
204 211
205 212 def Query.generate!(attributes={})
206 213 query = new(attributes)
207 214 query.name = "Generated query" if query.name.blank?
208 215 query.user ||= User.find(1)
209 216 query.save!
210 217 query
211 218 end
212 219
213 220 def generate_import(fixture_name='import_issues.csv')
214 221 import = IssueImport.new
215 222 import.user_id = 2
216 223 import.file = uploaded_test_file(fixture_name, 'text/csv')
217 224 import.save!
218 225 import
219 226 end
220 227
221 228 def generate_import_with_mapping(fixture_name='import_issues.csv')
222 229 import = generate_import(fixture_name)
223 230
224 231 import.settings = {
225 232 'separator' => ";", 'wrapper' => '"', 'encoding' => "UTF-8",
226 233 'mapping' => {'project_id' => '1', 'tracker_id' => '2', 'subject' => '1'}
227 234 }
228 235 import.save!
229 236 import
230 237 end
231 238 end
232 239
233 240 module TrackerObjectHelpers
234 241 def generate_transitions!(*args)
235 242 options = args.last.is_a?(Hash) ? args.pop : {}
236 243 if args.size == 1
237 244 args << args.first
238 245 end
239 246 if options[:clear]
240 247 WorkflowTransition.where(:tracker_id => id).delete_all
241 248 end
242 249 args.each_cons(2) do |old_status_id, new_status_id|
243 250 WorkflowTransition.create!(
244 251 :tracker => self,
245 252 :role_id => (options[:role_id] || 1),
246 253 :old_status_id => old_status_id,
247 254 :new_status_id => new_status_id
248 255 )
249 256 end
250 257 end
251 258 end
252 259 Tracker.send :include, TrackerObjectHelpers
253 260
254 261 module IssueObjectHelpers
255 262 def close!
256 263 self.status = IssueStatus.where(:is_closed => true).first
257 264 save!
258 265 end
259 266
260 267 def generate_child!(attributes={})
261 268 Issue.generate!(attributes.merge(:parent_issue_id => self.id))
262 269 end
263 270 end
264 271 Issue.send :include, IssueObjectHelpers
General Comments 0
You need to be logged in to leave comments. Login now