##// END OF EJS Templates
jro_apps » redmine
RSS
Fixed: Link is escaped in wiki added/updated notification email (#11262)....
Jean-Philippe Lang -
r9713:f9f5e9e7c6c6
parent child
Show More
Side by Side Unified
Context file:
r9713:f9f5e9e7c6c6 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,3 +1,3
1 1 <p><%= l(:mail_body_wiki_content_added, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url),
2 :author => h(@wiki_content.author)) %><br />
2 :author => h(@wiki_content.author)).html_safe %><br />
3 3 <em><%=h @wiki_content.comments %></em></p>
Show file before | Show file after | Hide comments
@@ -1,6 +1,6
1 1 <p><%= l(:mail_body_wiki_content_updated, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url),
2 :author => h(@wiki_content.author)) %><br />
2 :author => h(@wiki_content.author)).html_safe %><br />
3 3 <em><%=h @wiki_content.comments %></em></p>
4 4
5 5 <p><%= l(:label_view_diff) %>:<br />
6 6 <%= link_to h(@wiki_diff_url), @wiki_diff_url %></p>
Show file before | Show file after | Hide comments
@@ -1,541 +1,551
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class MailerTest < ActiveSupport::TestCase
21 21 include Redmine::I18n
22 22 include ActionDispatch::Assertions::SelectorAssertions
23 23 fixtures :projects, :enabled_modules, :issues, :users, :members,
24 24 :member_roles, :roles, :documents, :attachments, :news,
25 25 :tokens, :journals, :journal_details, :changesets,
26 26 :trackers, :projects_trackers,
27 27 :issue_statuses, :enumerations, :messages, :boards, :repositories,
28 28 :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions,
29 29 :versions,
30 30 :comments
31 31
32 32 def setup
33 33 ActionMailer::Base.deliveries.clear
34 34 Setting.host_name = 'mydomain.foo'
35 35 Setting.protocol = 'http'
36 36 Setting.plain_text_mail = '0'
37 37 end
38 38
39 39 def test_generated_links_in_emails
40 40 Setting.default_language = 'en'
41 41 Setting.host_name = 'mydomain.foo'
42 42 Setting.protocol = 'https'
43 43
44 44 journal = Journal.find(3)
45 45 assert Mailer.issue_edit(journal).deliver
46 46
47 47 mail = last_email
48 48 assert_not_nil mail
49 49
50 50 assert_select_email do
51 51 # link to the main ticket
52 52 assert_select 'a[href=?]',
53 53 'https://mydomain.foo/issues/2#change-3',
54 54 :text => 'Feature request #2: Add ingredients categories'
55 55 # link to a referenced ticket
56 56 assert_select 'a[href=?][title=?]',
57 57 'https://mydomain.foo/issues/1',
58 58 'Can\'t print recipes (New)',
59 59 :text => '#1'
60 60 # link to a changeset
61 61 assert_select 'a[href=?][title=?]',
62 62 'https://mydomain.foo/projects/ecookbook/repository/revisions/2',
63 63 'This commit fixes #1, #2 and references #1 &amp; #3',
64 64 :text => 'r2'
65 65 # link to a description diff
66 66 assert_select 'a[href=?][title=?]',
67 67 'https://mydomain.foo/journals/diff/3?detail_id=4',
68 68 'View differences',
69 69 :text => 'diff'
70 70 # link to an attachment
71 71 assert_select 'a[href=?]',
72 72 'https://mydomain.foo/attachments/download/4/source.rb',
73 73 :text => 'source.rb'
74 74 end
75 75 end
76 76
77 77 def test_generated_links_with_prefix
78 78 Setting.default_language = 'en'
79 79 relative_url_root = Redmine::Utils.relative_url_root
80 80 Setting.host_name = 'mydomain.foo/rdm'
81 81 Setting.protocol = 'http'
82 82
83 83 journal = Journal.find(3)
84 84 assert Mailer.issue_edit(journal).deliver
85 85
86 86 mail = last_email
87 87 assert_not_nil mail
88 88
89 89 assert_select_email do
90 90 # link to the main ticket
91 91 assert_select 'a[href=?]',
92 92 'http://mydomain.foo/rdm/issues/2#change-3',
93 93 :text => 'Feature request #2: Add ingredients categories'
94 94 # link to a referenced ticket
95 95 assert_select 'a[href=?][title=?]',
96 96 'http://mydomain.foo/rdm/issues/1',
97 97 'Can\'t print recipes (New)',
98 98 :text => '#1'
99 99 # link to a changeset
100 100 assert_select 'a[href=?][title=?]',
101 101 'http://mydomain.foo/rdm/projects/ecookbook/repository/revisions/2',
102 102 'This commit fixes #1, #2 and references #1 &amp; #3',
103 103 :text => 'r2'
104 104 # link to a description diff
105 105 assert_select 'a[href=?][title=?]',
106 106 'http://mydomain.foo/rdm/journals/diff/3?detail_id=4',
107 107 'View differences',
108 108 :text => 'diff'
109 109 # link to an attachment
110 110 assert_select 'a[href=?]',
111 111 'http://mydomain.foo/rdm/attachments/download/4/source.rb',
112 112 :text => 'source.rb'
113 113 end
114 114 end
115 115
116 116 def test_generated_links_with_prefix_and_no_relative_url_root
117 117 Setting.default_language = 'en'
118 118 relative_url_root = Redmine::Utils.relative_url_root
119 119 Setting.host_name = 'mydomain.foo/rdm'
120 120 Setting.protocol = 'http'
121 121 Redmine::Utils.relative_url_root = nil
122 122
123 123 journal = Journal.find(3)
124 124 assert Mailer.issue_edit(journal).deliver
125 125
126 126 mail = last_email
127 127 assert_not_nil mail
128 128
129 129 assert_select_email do
130 130 # link to the main ticket
131 131 assert_select 'a[href=?]',
132 132 'http://mydomain.foo/rdm/issues/2#change-3',
133 133 :text => 'Feature request #2: Add ingredients categories'
134 134 # link to a referenced ticket
135 135 assert_select 'a[href=?][title=?]',
136 136 'http://mydomain.foo/rdm/issues/1',
137 137 'Can\'t print recipes (New)',
138 138 :text => '#1'
139 139 # link to a changeset
140 140 assert_select 'a[href=?][title=?]',
141 141 'http://mydomain.foo/rdm/projects/ecookbook/repository/revisions/2',
142 142 'This commit fixes #1, #2 and references #1 &amp; #3',
143 143 :text => 'r2'
144 144 # link to a description diff
145 145 assert_select 'a[href=?][title=?]',
146 146 'http://mydomain.foo/rdm/journals/diff/3?detail_id=4',
147 147 'View differences',
148 148 :text => 'diff'
149 149 # link to an attachment
150 150 assert_select 'a[href=?]',
151 151 'http://mydomain.foo/rdm/attachments/download/4/source.rb',
152 152 :text => 'source.rb'
153 153 end
154 154 ensure
155 155 # restore it
156 156 Redmine::Utils.relative_url_root = relative_url_root
157 157 end
158 158
159 159 def test_email_headers
160 160 issue = Issue.find(1)
161 161 Mailer.issue_add(issue).deliver
162 162 mail = last_email
163 163 assert_not_nil mail
164 164 assert_equal 'OOF', mail.header['X-Auto-Response-Suppress'].to_s
165 165 assert_equal 'auto-generated', mail.header['Auto-Submitted'].to_s
166 166 assert_equal '<redmine.example.net>', mail.header['List-Id'].to_s
167 167 end
168 168
169 169 def test_email_headers_should_include_sender
170 170 issue = Issue.find(1)
171 171 Mailer.issue_add(issue).deliver
172 172 mail = last_email
173 173 assert_equal issue.author.login, mail.header['X-Redmine-Sender'].to_s
174 174 end
175 175
176 176 def test_plain_text_mail
177 177 Setting.plain_text_mail = 1
178 178 journal = Journal.find(2)
179 179 Mailer.issue_edit(journal).deliver
180 180 mail = last_email
181 181 assert_equal "text/plain; charset=UTF-8", mail.content_type
182 182 assert_equal 0, mail.parts.size
183 183 assert !mail.encoded.include?('href')
184 184 end
185 185
186 186 def test_html_mail
187 187 Setting.plain_text_mail = 0
188 188 journal = Journal.find(2)
189 189 Mailer.issue_edit(journal).deliver
190 190 mail = last_email
191 191 assert_equal 2, mail.parts.size
192 192 assert mail.encoded.include?('href')
193 193 end
194 194
195 195 def test_from_header
196 196 with_settings :mail_from => 'redmine@example.net' do
197 197 Mailer.test_email(User.find(1)).deliver
198 198 end
199 199 mail = last_email
200 200 assert_equal 'redmine@example.net', mail.from_addrs.first
201 201 end
202 202
203 203 def test_from_header_with_phrase
204 204 with_settings :mail_from => 'Redmine app <redmine@example.net>' do
205 205 Mailer.test_email(User.find(1)).deliver
206 206 end
207 207 mail = last_email
208 208 assert_equal 'redmine@example.net', mail.from_addrs.first
209 209 assert_equal 'Redmine app <redmine@example.net>', mail.header['From'].to_s
210 210 end
211 211
212 212 def test_should_not_send_email_without_recipient
213 213 news = News.find(:first)
214 214 user = news.author
215 215 # Remove members except news author
216 216 news.project.memberships.each {|m| m.destroy unless m.user == user}
217 217
218 218 user.pref[:no_self_notified] = false
219 219 user.pref.save
220 220 User.current = user
221 221 Mailer.news_added(news.reload).deliver
222 222 assert_equal 1, last_email.bcc.size
223 223
224 224 # nobody to notify
225 225 user.pref[:no_self_notified] = true
226 226 user.pref.save
227 227 User.current = user
228 228 ActionMailer::Base.deliveries.clear
229 229 Mailer.news_added(news.reload).deliver
230 230 assert ActionMailer::Base.deliveries.empty?
231 231 end
232 232
233 233 def test_issue_add_message_id
234 234 issue = Issue.find(1)
235 235 Mailer.issue_add(issue).deliver
236 236 mail = last_email
237 237 assert_equal Mailer.message_id_for(issue), mail.message_id
238 238 assert_nil mail.references
239 239 end
240 240
241 241 def test_issue_edit_message_id
242 242 journal = Journal.find(1)
243 243 Mailer.issue_edit(journal).deliver
244 244 mail = last_email
245 245 assert_equal Mailer.message_id_for(journal), mail.message_id
246 246 assert_include Mailer.message_id_for(journal.issue), mail.references
247 247 assert_select_email do
248 248 # link to the update
249 249 assert_select "a[href=?]",
250 250 "http://mydomain.foo/issues/#{journal.journalized_id}#change-#{journal.id}"
251 251 end
252 252 end
253 253
254 254 def test_message_posted_message_id
255 255 message = Message.find(1)
256 256 Mailer.message_posted(message).deliver
257 257 mail = last_email
258 258 assert_equal Mailer.message_id_for(message), mail.message_id
259 259 assert_nil mail.references
260 260 assert_select_email do
261 261 # link to the message
262 262 assert_select "a[href=?]",
263 263 "http://mydomain.foo/boards/#{message.board.id}/topics/#{message.id}",
264 264 :text => message.subject
265 265 end
266 266 end
267 267
268 268 def test_reply_posted_message_id
269 269 message = Message.find(3)
270 270 Mailer.message_posted(message).deliver
271 271 mail = last_email
272 272 assert_equal Mailer.message_id_for(message), mail.message_id
273 273 assert_include Mailer.message_id_for(message.parent), mail.references
274 274 assert_select_email do
275 275 # link to the reply
276 276 assert_select "a[href=?]",
277 277 "http://mydomain.foo/boards/#{message.board.id}/topics/#{message.root.id}?r=#{message.id}#message-#{message.id}",
278 278 :text => message.subject
279 279 end
280 280 end
281 281
282 282 context("#issue_add") do
283 283 setup do
284 284 ActionMailer::Base.deliveries.clear
285 285 Setting.bcc_recipients = '1'
286 286 @issue = Issue.find(1)
287 287 end
288 288
289 289 should "notify project members" do
290 290 assert Mailer.issue_add(@issue).deliver
291 291 assert last_email.bcc.include?('dlopper@somenet.foo')
292 292 end
293 293
294 294 should "not notify project members that are not allow to view the issue" do
295 295 Role.find(2).remove_permission!(:view_issues)
296 296 assert Mailer.issue_add(@issue).deliver
297 297 assert !last_email.bcc.include?('dlopper@somenet.foo')
298 298 end
299 299
300 300 should "notify issue watchers" do
301 301 user = User.find(9)
302 302 # minimal email notification options
303 303 user.pref[:no_self_notified] = '1'
304 304 user.pref.save
305 305 user.mail_notification = false
306 306 user.save
307 307
308 308 Watcher.create!(:watchable => @issue, :user => user)
309 309 assert Mailer.issue_add(@issue).deliver
310 310 assert last_email.bcc.include?(user.mail)
311 311 end
312 312
313 313 should "not notify watchers not allowed to view the issue" do
314 314 user = User.find(9)
315 315 Watcher.create!(:watchable => @issue, :user => user)
316 316 Role.non_member.remove_permission!(:view_issues)
317 317 assert Mailer.issue_add(@issue).deliver
318 318 assert !last_email.bcc.include?(user.mail)
319 319 end
320 320 end
321 321
322 322 # test mailer methods for each language
323 323 def test_issue_add
324 324 issue = Issue.find(1)
325 325 valid_languages.each do |lang|
326 326 Setting.default_language = lang.to_s
327 327 assert Mailer.issue_add(issue).deliver
328 328 end
329 329 end
330 330
331 331 def test_issue_edit
332 332 journal = Journal.find(1)
333 333 valid_languages.each do |lang|
334 334 Setting.default_language = lang.to_s
335 335 assert Mailer.issue_edit(journal).deliver
336 336 end
337 337 end
338 338
339 339 def test_document_added
340 340 document = Document.find(1)
341 341 valid_languages.each do |lang|
342 342 Setting.default_language = lang.to_s
343 343 assert Mailer.document_added(document).deliver
344 344 end
345 345 end
346 346
347 347 def test_attachments_added
348 348 attachements = [ Attachment.find_by_container_type('Document') ]
349 349 valid_languages.each do |lang|
350 350 Setting.default_language = lang.to_s
351 351 assert Mailer.attachments_added(attachements).deliver
352 352 end
353 353 end
354 354
355 355 def test_version_file_added
356 356 attachements = [ Attachment.find_by_container_type('Version') ]
357 357 assert Mailer.attachments_added(attachements).deliver
358 358 assert_not_nil last_email.bcc
359 359 assert last_email.bcc.any?
360 360 assert_select_email do
361 361 assert_select "a[href=?]", "http://mydomain.foo/projects/ecookbook/files"
362 362 end
363 363 end
364 364
365 365 def test_project_file_added
366 366 attachements = [ Attachment.find_by_container_type('Project') ]
367 367 assert Mailer.attachments_added(attachements).deliver
368 368 assert_not_nil last_email.bcc
369 369 assert last_email.bcc.any?
370 370 assert_select_email do
371 371 assert_select "a[href=?]", "http://mydomain.foo/projects/ecookbook/files"
372 372 end
373 373 end
374 374
375 375 def test_news_added
376 376 news = News.find(:first)
377 377 valid_languages.each do |lang|
378 378 Setting.default_language = lang.to_s
379 379 assert Mailer.news_added(news).deliver
380 380 end
381 381 end
382 382
383 383 def test_news_comment_added
384 384 comment = Comment.find(2)
385 385 valid_languages.each do |lang|
386 386 Setting.default_language = lang.to_s
387 387 assert Mailer.news_comment_added(comment).deliver
388 388 end
389 389 end
390 390
391 391 def test_message_posted
392 392 message = Message.find(:first)
393 393 recipients = ([message.root] + message.root.children).collect {|m| m.author.mail if m.author}
394 394 recipients = recipients.compact.uniq
395 395 valid_languages.each do |lang|
396 396 Setting.default_language = lang.to_s
397 397 assert Mailer.message_posted(message).deliver
398 398 end
399 399 end
400 400
401 401 def test_wiki_content_added
402 402 content = WikiContent.find(1)
403 403 valid_languages.each do |lang|
404 404 Setting.default_language = lang.to_s
405 405 assert_difference 'ActionMailer::Base.deliveries.size' do
406 406 assert Mailer.wiki_content_added(content).deliver
407 assert_select_email do
408 assert_select 'a[href=?]',
409 'http://mydomain.foo/projects/ecookbook/wiki/CookBook_documentation',
410 :text => 'CookBook documentation'
411 end
407 412 end
408 413 end
409 414 end
410 415
411 416 def test_wiki_content_updated
412 417 content = WikiContent.find(1)
413 418 valid_languages.each do |lang|
414 419 Setting.default_language = lang.to_s
415 420 assert_difference 'ActionMailer::Base.deliveries.size' do
416 421 assert Mailer.wiki_content_updated(content).deliver
422 assert_select_email do
423 assert_select 'a[href=?]',
424 'http://mydomain.foo/projects/ecookbook/wiki/CookBook_documentation',
425 :text => 'CookBook documentation'
426 end
417 427 end
418 428 end
419 429 end
420 430
421 431 def test_account_information
422 432 user = User.find(2)
423 433 valid_languages.each do |lang|
424 434 user.update_attribute :language, lang.to_s
425 435 user.reload
426 436 assert Mailer.account_information(user, 'pAsswORd').deliver
427 437 end
428 438 end
429 439
430 440 def test_lost_password
431 441 token = Token.find(2)
432 442 valid_languages.each do |lang|
433 443 token.user.update_attribute :language, lang.to_s
434 444 token.reload
435 445 assert Mailer.lost_password(token).deliver
436 446 end
437 447 end
438 448
439 449 def test_register
440 450 token = Token.find(1)
441 451 Setting.host_name = 'redmine.foo'
442 452 Setting.protocol = 'https'
443 453
444 454 valid_languages.each do |lang|
445 455 token.user.update_attribute :language, lang.to_s
446 456 token.reload
447 457 ActionMailer::Base.deliveries.clear
448 458 assert Mailer.register(token).deliver
449 459 mail = last_email
450 460 assert_select_email do
451 461 assert_select "a[href=?]",
452 462 "https://redmine.foo/account/activate?token=#{token.value}",
453 463 :text => "https://redmine.foo/account/activate?token=#{token.value}"
454 464 end
455 465 end
456 466 end
457 467
458 468 def test_test
459 469 user = User.find(1)
460 470 valid_languages.each do |lang|
461 471 user.update_attribute :language, lang.to_s
462 472 assert Mailer.test_email(user).deliver
463 473 end
464 474 end
465 475
466 476 def test_reminders
467 477 Mailer.reminders(:days => 42)
468 478 assert_equal 1, ActionMailer::Base.deliveries.size
469 479 mail = last_email
470 480 assert mail.bcc.include?('dlopper@somenet.foo')
471 481 assert_mail_body_match 'Bug #3: Error 281 when updating a recipe', mail
472 482 assert_equal '1 issue(s) due in the next 42 days', mail.subject
473 483 end
474 484
475 485 def test_reminders_should_not_include_closed_issues
476 486 with_settings :default_language => 'en' do
477 487 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 5,
478 488 :subject => 'Closed issue', :assigned_to_id => 3,
479 489 :due_date => 5.days.from_now,
480 490 :author_id => 2)
481 491 ActionMailer::Base.deliveries.clear
482 492
483 493 Mailer.reminders(:days => 42)
484 494 assert_equal 1, ActionMailer::Base.deliveries.size
485 495 mail = last_email
486 496 assert mail.bcc.include?('dlopper@somenet.foo')
487 497 assert_mail_body_no_match 'Closed issue', mail
488 498 end
489 499 end
490 500
491 501 def test_reminders_for_users
492 502 Mailer.reminders(:days => 42, :users => ['5'])
493 503 assert_equal 0, ActionMailer::Base.deliveries.size # No mail for dlopper
494 504 Mailer.reminders(:days => 42, :users => ['3'])
495 505 assert_equal 1, ActionMailer::Base.deliveries.size # No mail for dlopper
496 506 mail = last_email
497 507 assert mail.bcc.include?('dlopper@somenet.foo')
498 508 assert_mail_body_match 'Bug #3: Error 281 when updating a recipe', mail
499 509 end
500 510
501 511 def test_mailer_should_not_change_locale
502 512 Setting.default_language = 'en'
503 513 # Set current language to italian
504 514 set_language_if_valid 'it'
505 515 # Send an email to a french user
506 516 user = User.find(1)
507 517 user.language = 'fr'
508 518 Mailer.account_activated(user).deliver
509 519 mail = last_email
510 520 assert_mail_body_match 'Votre compte', mail
511 521
512 522 assert_equal :it, current_language
513 523 end
514 524
515 525 def test_with_deliveries_off
516 526 Mailer.with_deliveries false do
517 527 Mailer.test_email(User.find(1)).deliver
518 528 end
519 529 assert ActionMailer::Base.deliveries.empty?
520 530 # should restore perform_deliveries
521 531 assert ActionMailer::Base.perform_deliveries
522 532 end
523 533
524 534 def test_layout_should_include_the_emails_header
525 535 with_settings :emails_header => "*Header content*" do
526 536 assert Mailer.test_email(User.find(1)).deliver
527 537 assert_select_email do
528 538 assert_select ".header" do
529 539 assert_select "strong", :text => "Header content"
530 540 end
531 541 end
532 542 end
533 543 end
534 544
535 545 private
536 546 def last_email
537 547 mail = ActionMailer::Base.deliveries.last
538 548 assert_not_nil mail
539 549 mail
540 550 end
541 551 end
General Comments 0
You need to be logged in to leave comments. Login now