jro_apps/redmine Commit - r13879:f8a9a78ecfa5

Raises 60-character limit for document titles to 255 (#12312)....

Jean-Philippe Lang -

r13879:f8a9a78ecfa5

parent child

Context file:

r13879:f8a9a78ecfa5

db/migrate/20150510083747_change_documents_title_limit.rb created 644 +9 0

@@ -0,0 +1,9
	1	class ChangeDocumentsTitleLimit < ActiveRecord::Migration
	2	def self.up
	3	change_column :documents, :title, :string, :limit => nil, :default => '', :null => false
	4	end
	5
	6	def self.down
	7	change_column :documents, :title, :string, :limit => 60, :default => '', :null => false
	8	end
	9	end

app/models/document.rb +1 -1

               acts_as_activity_provider :scope => preload(:project)
               validates_presence_of :project, :title, :category
-              validates_length_of :title, :maximum => 60
+              validates_length_of :title, :maximum => 255
               attr_protected :id
               after_create :send_notification

public/stylesheets/application.css +1 -1

             div.wiki-page .contextual a:hover {opacity: 1}
             form .attributes select { width: 60%; }
-            input#issue_subject { width: 99%; }
+            input#issue_subject, input#document_title { width: 99%; }
             select#issue_done_ratio { width: 95px; }
             ul.projects {margin:0; padding-left:1em;}

test/unit/document_test.rb +7 0

                 assert doc.save
               end
+              def test_create_with_long_title
+                title = 'x'*255
+                doc = Document.new(:project => Project.find(1), :title => title, :category => DocumentCategory.first)
+                assert_save doc
+                assert_equal title, doc.reload.title
+              end
               def test_create_should_send_email_notification
                 ActionMailer::Base.deliveries.clear

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages