jro_apps/redmine Commit - r15152:f694839c8242

Code cleanup (#23054)....

Jean-Philippe Lang -

r15152:f694839c8242

parent child

Context file:

r15152:f694839c8242

Collapse all files

app/controllers/application_controller.rb +16 0

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require 'uri'
              require 'cgi'
              class Unauthorized < Exception; end
              class ApplicationController < ActionController::Base
                include Redmine::I18n
                include Redmine::Pagination
                include Redmine::Hook::Helper
                include RoutesHelper
                helper :routes
                class_attribute :accept_api_auth_actions
                class_attribute :accept_rss_auth_actions
                class_attribute :model_object
                layout 'base'
                protect_from_forgery
                def verify_authenticity_token
                  unless api_request?
                    super
                  end
                end
                def handle_unverified_request
                  unless api_request?
                    super
                    cookies.delete(autologin_cookie_name)
                    self.logged_user = nil
                    set_localization
                    render_error :status => 422, :message => "Invalid form authenticity token."
                  end
                end
                before_filter :session_expiration, :user_setup, :check_if_login_required, :check_password_change, :set_localization
                rescue_from ::Unauthorized, :with => :deny_access
                rescue_from ::ActionView::MissingTemplate, :with => :missing_template
                include Redmine::Search::Controller
                include Redmine::MenuManager::MenuController
                helper Redmine::MenuManager::MenuHelper
                include Redmine::SudoMode::Controller
                def session_expiration
                  if session[:user_id] && Rails.application.config.redmine_verify_sessions != false
                    if session_expired? && !try_to_autologin
                      set_localization(User.active.find_by_id(session[:user_id]))
                      self.logged_user = nil
                      flash[:error] = l(:error_session_expired)
                      require_login
                    end
                  end
                end
                def session_expired?
                  ! User.verify_session_token(session[:user_id], session[:tk])
                end
                def start_user_session(user)
                  session[:user_id] = user.id
                  session[:tk] = user.generate_session_token
                  if user.must_change_password?
                    session[:pwd] = '1'
                  end
                end
                def user_setup
                  # Check the settings cache for each request
                  Setting.check_cache
                  # Find the current user
                  User.current = find_current_user
                  logger.info("  Current user: " + (User.current.logged? ? "#{User.current.login} (id=#{User.current.id})" : "anonymous")) if logger
                end
                # Returns the current user or nil if no user is logged in
                # and starts a session if needed
                def find_current_user
                  user = nil
                  unless api_request?
                    if session[:user_id]
                      # existing session
                      user = (User.active.find(session[:user_id]) rescue nil)
                    elsif autologin_user = try_to_autologin
                      user = autologin_user
                    elsif params[:format] == 'atom' && params[:key] && request.get? && accept_rss_auth?
                      # RSS key authentication does not start a session
                      user = User.find_by_rss_key(params[:key])
                    end
                  end
                  if user.nil? && Setting.rest_api_enabled? && accept_api_auth?
                    if (key = api_key_from_request)
                      # Use API key
                      user = User.find_by_api_key(key)
                    elsif request.authorization.to_s =~ /\ABasic /i
                      # HTTP Basic, either username/password or API key/random
                      authenticate_with_http_basic do |username, password|
                        user = User.try_to_login(username, password) || User.find_by_api_key(username)
                      end
                      if user && user.must_change_password?
                        render_error :message => 'You must change your password', :status => 403
                        return
                      end
                    end
                    # Switch user if requested by an admin user
                    if user && user.admin? && (username = api_switch_user_from_request)
                      su = User.find_by_login(username)
                      if su && su.active?
                        logger.info("  User switched by: #{user.login} (id=#{user.id})") if logger
                        user = su
                      else
                        render_error :message => 'Invalid X-Redmine-Switch-User header', :status => 412
                      end
                    end
                  end
                  # store current ip address in user object ephemerally
                  user.remote_ip = request.remote_ip if user
                  user
                end
                def autologin_cookie_name
                  Redmine::Configuration['autologin_cookie_name'].presence || 'autologin'
                end
                def try_to_autologin
                  if cookies[autologin_cookie_name] && Setting.autologin?
                    # auto-login feature starts a new session
                    user = User.try_to_autologin(cookies[autologin_cookie_name])
                    if user
                      reset_session
                      start_user_session(user)
                    end
                    user
                  end
                end
                # Sets the logged in user
                def logged_user=(user)
                  reset_session
                  if user && user.is_a?(User)
                    User.current = user
                    start_user_session(user)
                  else
                    User.current = User.anonymous
                  end
                end
                # Logs out current user
                def logout_user
                  if User.current.logged?
                    cookies.delete(autologin_cookie_name)
                    Token.delete_all(["user_id = ? AND action = ?", User.current.id, 'autologin'])
                    Token.delete_all(["user_id = ? AND action = ? AND value = ?", User.current.id, 'session', session[:tk]])
                    self.logged_user = nil
                  end
                end
                # check if login is globally required to access the application
                def check_if_login_required
                  # no check needed if user is already logged in
                  return true if User.current.logged?
                  require_login if Setting.login_required?
                end
                def check_password_change
                  if session[:pwd]
                    if User.current.must_change_password?
                      flash[:error] = l(:error_password_expired)
                      redirect_to my_password_path
                    else
                      session.delete(:pwd)
                    end
                  end
                end
                def set_localization(user=User.current)
                  lang = nil
                  if user && user.logged?
                    lang = find_language(user.language)
                  end
                  if lang.nil? && !Setting.force_default_language_for_anonymous? && request.env['HTTP_ACCEPT_LANGUAGE']
                    accept_lang = parse_qvalues(request.env['HTTP_ACCEPT_LANGUAGE']).first
                    if !accept_lang.blank?
                      accept_lang = accept_lang.downcase
                      lang = find_language(accept_lang) || find_language(accept_lang.split('-').first)
                    end
                  end
                  lang ||= Setting.default_language
                  set_language_if_valid(lang)
                end
                def require_login
                  if !User.current.logged?
                    # Extract only the basic url parameters on non-GET requests
                    if request.get?
                      url = url_for(params)
                    else
                      url = url_for(:controller => params[:controller], :action => params[:action], :id => params[:id], :project_id => params[:project_id])
                    end
                    respond_to do |format|
                      format.html {
                        if request.xhr?
                          head :unauthorized
                        else
                          redirect_to signin_path(:back_url => url)
                        end
                      }
                      format.any(:atom, :pdf, :csv) {
                        redirect_to signin_path(:back_url => url)
                      }
                      format.xml  { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                      format.js   { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                      format.json { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                      format.any  { head :unauthorized }
                    end
                    return false
                  end
                  true
                end
                def require_admin
                  return unless require_login
                  if !User.current.admin?
                    render_403
                    return false
                  end
                  true
                end
                def deny_access
                  User.current.logged? ? render_403 : require_login
                end
                # Authorize the user for the requested action
                def authorize(ctrl = params[:controller], action = params[:action], global = false)
                  allowed = User.current.allowed_to?({:controller => ctrl, :action => action}, @project || @projects, :global => global)
                  if allowed
                    true
                  else
                    if @project && @project.archived?
                      render_403 :message => :notice_not_authorized_archived_project
                    else
                      deny_access
                    end
                  end
                end
                # Authorize the user for the requested action outside a project
                def authorize_global(ctrl = params[:controller], action = params[:action], global = true)
                  authorize(ctrl, action, global)
                end
                # Find project of id params[:id]
                def find_project
                  @project = Project.find(params[:id])
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find project of id params[:project_id]
                def find_project_by_project_id
                  @project = Project.find(params[:project_id])
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find a project based on params[:project_id]
                # TODO: some subclasses override this, see about merging their logic
                def find_optional_project
                  @project = Project.find(params[:project_id]) unless params[:project_id].blank?
                  allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true)
                  allowed ? true : deny_access
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Finds and sets @project based on @object.project
                def find_project_from_association
                  render_404 unless @object.present?
                  @project = @object.project
                end
                def find_model_object
                  model = self.class.model_object
                  if model
                    @object = model.find(params[:id])
                    self.instance_variable_set('@' + controller_name.singularize, @object) if @object
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def self.model_object(model)
                  self.model_object = model
                end
                # Find the issue whose id is the :id parameter
                # Raises a Unauthorized exception if the issue is not visible
                def find_issue
                  # Issue.visible.find(...) can not be used to redirect user to the login form
                  # if the issue actually exists but requires authentication
                  @issue = Issue.find(params[:id])
                  raise Unauthorized unless @issue.visible?
                  @project = @issue.project
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find issues with a single :id param or :ids array param
                # Raises a Unauthorized exception if one of the issues is not visible
                def find_issues
                  @issues = Issue.
                    where(:id => (params[:id] || params[:ids])).
                    preload(:project, :status, :tracker, :priority, :author, :assigned_to, :relations_to, {:custom_values => :custom_field}).
                    to_a
                  raise ActiveRecord::RecordNotFound if @issues.empty?
                  raise Unauthorized unless @issues.all?(&:visible?)
                  @projects = @issues.collect(&:project).compact.uniq
                  @project = @projects.first if @projects.size == 1
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def find_attachments
                  if (attachments = params[:attachments]).present?
                    att = attachments.values.collect do |attachment|
                      Attachment.find_by_token( attachment[:token] ) if attachment[:token].present?
                    end
                    att.compact!
                  end
                  @attachments = att || []
                end
+               def parse_params_for_bulk_update(params)
+                 attributes = (params || {}).reject {|k,v| v.blank?}
+                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
+                 if custom = attributes[:custom_field_values]
+                   custom.reject! {|k,v| v.blank?}
+                   custom.keys.each do |k|
+                     if custom[k].is_a?(Array)
+                       custom[k] << '' if custom[k].delete('__none__')
+                     else
+                       custom[k] = '' if custom[k] == '__none__'
+                     end
+                   end
+                 end
+                 attributes
+               end
                # make sure that the user is a member of the project (or admin) if project is private
                # used as a before_filter for actions that do not require any particular permission on the project
                def check_project_privacy
                  if @project && !@project.archived?
                    if @project.visible?
                      true
                    else
                      deny_access
                    end
                  else
                    @project = nil
                    render_404
                    false
                  end
                end
                def back_url
                  url = params[:back_url]
                  if url.nil? && referer = request.env['HTTP_REFERER']
                    url = CGI.unescape(referer.to_s)
                  end
                  url
                end
                def redirect_back_or_default(default, options={})
                  back_url = params[:back_url].to_s
                  if back_url.present? && valid_url = validate_back_url(back_url)
                    redirect_to(valid_url)
                    return
                  elsif options[:referer]
                    redirect_to_referer_or default
                    return
                  end
                  redirect_to default
                  false
                end
                # Returns a validated URL string if back_url is a valid url for redirection,
                # otherwise false
                def validate_back_url(back_url)
                  if CGI.unescape(back_url).include?('..')
                    return false
                  end
                  begin
                    uri = URI.parse(back_url)
                  rescue URI::InvalidURIError
                    return false
                  end
                  [:scheme, :host, :port].each do |component|
                    if uri.send(component).present? && uri.send(component) != request.send(component)
                      return false
                    end
                    uri.send(:"#{component}=", nil)
                  end
                  # Always ignore basic user:password in the URL
                  uri.userinfo = nil
                  path = uri.to_s
                  # Ensure that the remaining URL starts with a slash, followed by a
                  # non-slash character or the end
                  if path !~ %r{\A/([^/]|\z)}
                    return false
                  end
                  if path.match(%r{/(login|account/register)})
                    return false
                  end
                  if relative_url_root.present? && !path.starts_with?(relative_url_root)
                    return false
                  end
                  return path
                end
                private :validate_back_url
                def valid_back_url?(back_url)
                  !!validate_back_url(back_url)
                end
                private :valid_back_url?
                # Redirects to the request referer if present, redirects to args or call block otherwise.
                def redirect_to_referer_or(*args, &block)
                  redirect_to :back
                rescue ::ActionController::RedirectBackError
                  if args.any?
                    redirect_to *args
                  elsif block_given?
                    block.call
                  else
                    raise "#redirect_to_referer_or takes arguments or a block"
                  end
                end
                def render_403(options={})
                  @project = nil
                  render_error({:message => :notice_not_authorized, :status => 403}.merge(options))
                  return false
                end
                def render_404(options={})
                  render_error({:message => :notice_file_not_found, :status => 404}.merge(options))
                  return false
                end
                # Renders an error response
                def render_error(arg)
                  arg = {:message => arg} unless arg.is_a?(Hash)
                  @message = arg[:message]
                  @message = l(@message) if @message.is_a?(Symbol)
                  @status = arg[:status] || 500
                  respond_to do |format|
                    format.html {
                      render :template => 'common/error', :layout => use_layout, :status => @status
                    }
                    format.any { head @status }
                  end
                end
                # Handler for ActionView::MissingTemplate exception
                def missing_template
                  logger.warn "Missing template, responding with 404"
                  @project = nil
                  render_404
                end
                # Filter for actions that provide an API response
                # but have no HTML representation for non admin users
                def require_admin_or_api_request
                  return true if api_request?
                  if User.current.admin?
                    true
                  elsif User.current.logged?
                    render_error(:status => 406)
                  else
                    deny_access
                  end
                end
                # Picks which layout to use based on the request
                #
                # @return [boolean, string] name of the layout to use or false for no layout
                def use_layout
                  request.xhr? ? false : 'base'
                end
                def render_feed(items, options={})
                  @items = (items || []).to_a
                  @items.sort! {|x,y| y.event_datetime <=> x.event_datetime }
                  @items = @items.slice(0, Setting.feeds_limit.to_i)
                  @title = options[:title] || Setting.app_title
                  render :template => "common/feed", :formats => [:atom], :layout => false,
                         :content_type => 'application/atom+xml'
                end
                def self.accept_rss_auth(*actions)
                  if actions.any?
                    self.accept_rss_auth_actions = actions
                  else
                    self.accept_rss_auth_actions || []
                  end
                end
                def accept_rss_auth?(action=action_name)
                  self.class.accept_rss_auth.include?(action.to_sym)
                end
                def self.accept_api_auth(*actions)
                  if actions.any?
                    self.accept_api_auth_actions = actions
                  else
                    self.accept_api_auth_actions || []
                  end
                end
                def accept_api_auth?(action=action_name)
                  self.class.accept_api_auth.include?(action.to_sym)
                end
                # Returns the number of objects that should be displayed
                # on the paginated list
                def per_page_option
                  per_page = nil
                  if params[:per_page] && Setting.per_page_options_array.include?(params[:per_page].to_s.to_i)
                    per_page = params[:per_page].to_s.to_i
                    session[:per_page] = per_page
                  elsif session[:per_page]
                    per_page = session[:per_page]
                  else
                    per_page = Setting.per_page_options_array.first || 25
                  end
                  per_page
                end
                # Returns offset and limit used to retrieve objects
                # for an API response based on offset, limit and page parameters
                def api_offset_and_limit(options=params)
                  if options[:offset].present?
                    offset = options[:offset].to_i
                    if offset < 0
                      offset = 0
                    end
                  end
                  limit = options[:limit].to_i
                  if limit < 1
                    limit = 25
                  elsif limit > 100
                    limit = 100
                  end
                  if offset.nil? && options[:page].present?
                    offset = (options[:page].to_i - 1) * limit
                    offset = 0 if offset < 0
                  end
                  offset ||= 0
                  [offset, limit]
                end
                # qvalues http header parser
                # code taken from webrick
                def parse_qvalues(value)
                  tmp = []
                  if value
                    parts = value.split(/,\s*/)
                    parts.each {|part|
                      if m = %r{^([^\s,]+?)(?:;\s*q=(\d+(?:\.\d+)?))?$}.match(part)
                        val = m[1]
                        q = (m[2] or 1).to_f
                        tmp.push([val, q])
                      end
                    }
                    tmp = tmp.sort_by{|val, q| -q}
                    tmp.collect!{|val, q| val}
                  end
                  return tmp
                rescue
                  nil
                end
                # Returns a string that can be used as filename value in Content-Disposition header
                def filename_for_content_disposition(name)
                  request.env['HTTP_USER_AGENT'] =~ %r{(MSIE|Trident|Edge)} ? ERB::Util.url_encode(name) : name
                end
                def api_request?
                  %w(xml json).include? params[:format]
                end
                # Returns the API key present in the request
                def api_key_from_request
                  if params[:key].present?
                    params[:key].to_s
                  elsif request.headers["X-Redmine-API-Key"].present?
                    request.headers["X-Redmine-API-Key"].to_s
                  end
                end
                # Returns the API 'switch user' value if present
                def api_switch_user_from_request
                  request.headers["X-Redmine-Switch-User"].to_s.presence
                end
                # Renders a warning flash if obj has unsaved attachments
                def render_attachment_warning_if_needed(obj)
                  flash[:warning] = l(:warning_attachments_not_saved, obj.unsaved_attachments.size) if obj.unsaved_attachments.present?
                end
                # Rescues an invalid query statement. Just in case...
                def query_statement_invalid(exception)
                  logger.error "Query::StatementInvalid: #{exception.message}" if logger
                  session.delete(:query)
                  sort_clear if respond_to?(:sort_clear)
                  render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator."
                end
                # Renders a 200 response for successfull updates or deletions via the API
                def render_api_ok
                  render_api_head :ok
                end
                # Renders a head API response
                def render_api_head(status)
                  # #head would return a response body with one space
                  render :text => '', :status => status, :layout => nil
                end
                # Renders API response on validation failure
                # for an object or an array of objects
                def render_validation_errors(objects)
                  messages = Array.wrap(objects).map {|object| object.errors.full_messages}.flatten
                  render_api_errors(messages)
                end
                def render_api_errors(*messages)
                  @error_messages = messages.flatten
                  render :template => 'common/error_messages.api', :status => :unprocessable_entity, :layout => nil
                end
                # Overrides #_include_layout? so that #render with no arguments
                # doesn't use the layout for api requests
                def _include_layout?(*args)
                  api_request? ? false : super
                end
              end

app/controllers/issues_controller.rb +1 -17

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class IssuesController < ApplicationController
                default_search_scope :issues
                before_filter :find_issue, :only => [:show, :edit, :update]
                before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
                before_filter :authorize, :except => [:index, :new, :create]
                before_filter :find_optional_project, :only => [:index, :new, :create]
                before_filter :build_new_issue_from_params, :only => [:new, :create]
                accept_rss_auth :index, :show
                accept_api_auth :index, :show, :create, :update, :destroy
                rescue_from Query::StatementInvalid, :with => :query_statement_invalid
                helper :journals
                helper :projects
                helper :custom_fields
                helper :issue_relations
                helper :watchers
                helper :attachments
                helper :queries
                include QueriesHelper
                helper :repositories
                helper :sort
                include SortHelper
                helper :timelog
                def index
                  retrieve_query
                  sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                  sort_update(@query.sortable_columns)
                  @query.sort_criteria = sort_criteria.to_a
                  if @query.valid?
                    case params[:format]
                    when 'csv', 'pdf'
                      @limit = Setting.issues_export_limit.to_i
                      if params[:columns] == 'all'
                        @query.column_names = @query.available_inline_columns.map(&:name)
                      end
                    when 'atom'
                      @limit = Setting.feeds_limit.to_i
                    when 'xml', 'json'
                      @offset, @limit = api_offset_and_limit
                      @query.column_names = %w(author)
                    else
                      @limit = per_page_option
                    end
                    @issue_count = @query.issue_count
                    @issue_pages = Paginator.new @issue_count, @limit, params['page']
                    @offset ||= @issue_pages.offset
                    @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                            :order => sort_clause,
                                            :offset => @offset,
                                            :limit => @limit)
                    @issue_count_by_group = @query.issue_count_by_group
                    respond_to do |format|
                      format.html { render :template => 'issues/index', :layout => !request.xhr? }
                      format.api  {
                        Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
                      }
                      format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                      format.csv  { send_data(query_to_csv(@issues, @query, params[:csv]), :type => 'text/csv; header=present', :filename => 'issues.csv') }
                      format.pdf  { send_file_headers! :type => 'application/pdf', :filename => 'issues.pdf' }
                    end
                  else
                    respond_to do |format|
                      format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
                      format.any(:atom, :csv, :pdf) { render(:nothing => true) }
                      format.api { render_validation_errors(@query) }
                    end
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def show
                  @journals = @issue.journals.includes(:user, :details).
                                  references(:user, :details).
                                  reorder(:created_on, :id).to_a
                  @journals.each_with_index {|j,i| j.indice = i+1}
                  @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                  Journal.preload_journals_details_custom_fields(@journals)
                  @journals.select! {|journal| journal.notes? || journal.visible_details.any?}
                  @journals.reverse! if User.current.wants_comments_in_reverse_order?
                  @changesets = @issue.changesets.visible.preload(:repository, :user).to_a
                  @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                  @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  @priorities = IssuePriority.active
                  @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                  @relation = IssueRelation.new
                  respond_to do |format|
                    format.html {
                      retrieve_previous_and_next_issue_ids
                      render :template => 'issues/show'
                    }
                    format.api
                    format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                    format.pdf  {
                      send_file_headers! :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf"
                    }
                  end
                end
                def new
                  respond_to do |format|
                    format.html { render :action => 'new', :layout => !request.xhr? }
                    format.js
                  end
                end
                def create
                  unless User.current.allowed_to?(:add_issues, @issue.project, :global => true)
                    raise ::Unauthorized
                  end
                  call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                  @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                  if @issue.save
                    call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                    respond_to do |format|
                      format.html {
                        render_attachment_warning_if_needed(@issue)
                        flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
                        redirect_after_create
                      }
                      format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
                    end
                    return
                  else
                    respond_to do |format|
                      format.html {
                        if @issue.project.nil?
                          render_error :status => 422
                        else
                          render :action => 'new'
                        end
                      }
                      format.api  { render_validation_errors(@issue) }
                    end
                  end
                end
                def edit
                  return unless update_issue_from_params
                  respond_to do |format|
                    format.html { }
                    format.js
                  end
                end
                def update
                  return unless update_issue_from_params
                  @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                  saved = false
                  begin
                    saved = save_issue_with_child_records
                  rescue ActiveRecord::StaleObjectError
                    @conflict = true
                    if params[:last_journal_id]
                      @conflict_journals = @issue.journals_after(params[:last_journal_id]).to_a
                      @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                    end
                  end
                  if saved
                    render_attachment_warning_if_needed(@issue)
                    flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                    respond_to do |format|
                      format.html { redirect_back_or_default issue_path(@issue, previous_and_next_issue_ids_params) }
                      format.api  { render_api_ok }
                    end
                  else
                    respond_to do |format|
                      format.html { render :action => 'edit' }
                      format.api  { render_validation_errors(@issue) }
                    end
                  end
                end
                # Bulk edit/copy a set of issues
                def bulk_edit
                  @issues.sort!
                  @copy = params[:copy].present?
                  @notes = params[:notes]
                  if @copy
                    unless User.current.allowed_to?(:copy_issues, @projects)
                      raise ::Unauthorized
                    end
                  else
                    unless @issues.all?(&:attributes_editable?)
                      raise ::Unauthorized
                    end
                  end
                  @allowed_projects = Issue.allowed_target_projects
                  if params[:issue]
                    @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
                    if @target_project
                      target_projects = [@target_project]
                    end
                  end
                  target_projects ||= @projects
                  if @copy
                    # Copied issues will get their default statuses
                    @available_statuses = []
                  else
                    @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
                  end
                  @custom_fields = @issues.map{|i|i.editable_custom_fields}.reduce(:&)
                  @assignables = target_projects.map(&:assignable_users).reduce(:&)
                  @trackers = target_projects.map {|p| Issue.allowed_target_trackers(p) }.reduce(:&)
                  @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
                  @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
                  if @copy
                    @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
                    @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
                  end
                  @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
                  @issue_params = params[:issue] || {}
                  @issue_params[:custom_field_values] ||= {}
                end
                def bulk_update
                  @issues.sort!
                  @copy = params[:copy].present?
-                 attributes = parse_params_for_bulk_issue_attributes(params)
+                 attributes = parse_params_for_bulk_update(params[:issue])
                  copy_subtasks = (params[:copy_subtasks] == '1')
                  copy_attachments = (params[:copy_attachments] == '1')
                  if @copy
                    unless User.current.allowed_to?(:copy_issues, @projects)
                      raise ::Unauthorized
                    end
                    target_projects = @projects
                    if attributes['project_id'].present?
                      target_projects = Project.where(:id => attributes['project_id']).to_a
                    end
                    unless User.current.allowed_to?(:add_issues, target_projects)
                      raise ::Unauthorized
                    end
                  else
                    unless @issues.all?(&:attributes_editable?)
                      raise ::Unauthorized
                    end
                  end
                  unsaved_issues = []
                  saved_issues = []
                  if @copy && copy_subtasks
                    # Descendant issues will be copied with the parent task
                    # Don't copy them twice
                    @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
                  end
                  @issues.each do |orig_issue|
                    orig_issue.reload
                    if @copy
                      issue = orig_issue.copy({},
                        :attachments => copy_attachments,
                        :subtasks => copy_subtasks,
                        :link => link_copy?(params[:link_copy])
                      )
                    else
                      issue = orig_issue
                    end
                    journal = issue.init_journal(User.current, params[:notes])
                    issue.safe_attributes = attributes
                    call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                    if issue.save
                      saved_issues << issue
                    else
                      unsaved_issues << orig_issue
                    end
                  end
                  if unsaved_issues.empty?
                    flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
                    if params[:follow]
                      if @issues.size == 1 && saved_issues.size == 1
                        redirect_to issue_path(saved_issues.first)
                      elsif saved_issues.map(&:project).uniq.size == 1
                        redirect_to project_issues_path(saved_issues.map(&:project).first)
                      end
                    else
                      redirect_back_or_default _project_issues_path(@project)
                    end
                  else
                    @saved_issues = @issues
                    @unsaved_issues = unsaved_issues
                    @issues = Issue.visible.where(:id => @unsaved_issues.map(&:id)).to_a
                    bulk_edit
                    render :action => 'bulk_edit'
                  end
                end
                def destroy
                  raise Unauthorized unless @issues.all?(&:deletable?)
                  @hours = TimeEntry.where(:issue_id => @issues.map(&:id)).sum(:hours).to_f
                  if @hours > 0
                    case params[:todo]
                    when 'destroy'
                      # nothing to do
                    when 'nullify'
                      TimeEntry.where(['issue_id IN (?)', @issues]).update_all('issue_id = NULL')
                    when 'reassign'
                      reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                      if reassign_to.nil?
                        flash.now[:error] = l(:error_issue_not_found_in_project)
                        return
                      else
                        TimeEntry.where(['issue_id IN (?)', @issues]).
                          update_all("issue_id = #{reassign_to.id}")
                      end
                    else
                      # display the destroy form if it's a user request
                      return unless api_request?
                    end
                  end
                  @issues.each do |issue|
                    begin
                      issue.reload.destroy
                    rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
                      # nothing to do, issue was already deleted (eg. by a parent)
                    end
                  end
                  respond_to do |format|
                    format.html { redirect_back_or_default _project_issues_path(@project) }
                    format.api  { render_api_ok }
                  end
                end
                # Overrides Redmine::MenuManager::MenuController::ClassMethods for
                # when the "New issue" tab is enabled
                def current_menu_item
                  if Setting.new_item_menu_tab == '1' && [:new, :create].include?(action_name.to_sym)
                    :new_issue
                  else
                    super
                  end
                end
                private
                def retrieve_previous_and_next_issue_ids
                  if params[:prev_issue_id].present? || params[:next_issue_id].present?
                    @prev_issue_id = params[:prev_issue_id].presence.try(:to_i)
                    @next_issue_id = params[:next_issue_id].presence.try(:to_i)
                    @issue_position = params[:issue_position].presence.try(:to_i)
                    @issue_count = params[:issue_count].presence.try(:to_i)
                  else
                    retrieve_query_from_session
                    if @query
                      sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                      sort_update(@query.sortable_columns, 'issues_index_sort')
                      limit = 500
                      issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
                      if (idx = issue_ids.index(@issue.id)) && idx < limit
                        if issue_ids.size < 500
                          @issue_position = idx + 1
                          @issue_count = issue_ids.size
                        end
                        @prev_issue_id = issue_ids[idx - 1] if idx > 0
                        @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
                      end
                    end
                  end
                end
                def previous_and_next_issue_ids_params
                  {
                    :prev_issue_id => params[:prev_issue_id],
                    :next_issue_id => params[:next_issue_id],
                    :issue_position => params[:issue_position],
                    :issue_count => params[:issue_count]
                  }.reject {|k,v| k.blank?}
                end
                # Used by #edit and #update to set some common instance variables
                # from the params
                def update_issue_from_params
                  @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                  if params[:time_entry]
                    @time_entry.safe_attributes = params[:time_entry]
                  end
                  @issue.init_journal(User.current)
                  issue_attributes = params[:issue]
                  if issue_attributes && params[:conflict_resolution]
                    case params[:conflict_resolution]
                    when 'overwrite'
                      issue_attributes = issue_attributes.dup
                      issue_attributes.delete(:lock_version)
                    when 'add_notes'
                      issue_attributes = issue_attributes.slice(:notes, :private_notes)
                    when 'cancel'
                      redirect_to issue_path(@issue)
                      return false
                    end
                  end
                  @issue.safe_attributes = issue_attributes
                  @priorities = IssuePriority.active
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  true
                end
                # Used by #new and #create to build a new issue from the params
                # The new issue will be copied from an existing one if copy_from parameter is given
                def build_new_issue_from_params
                  @issue = Issue.new
                  if params[:copy_from]
                    begin
                      @issue.init_journal(User.current)
                      @copy_from = Issue.visible.find(params[:copy_from])
                      unless User.current.allowed_to?(:copy_issues, @copy_from.project)
                        raise ::Unauthorized
                      end
                      @link_copy = link_copy?(params[:link_copy]) || request.get?
                      @copy_attachments = params[:copy_attachments].present? || request.get?
                      @copy_subtasks = params[:copy_subtasks].present? || request.get?
                      @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks, :link => @link_copy)
                      @issue.parent_issue_id = @copy_from.parent_id
                    rescue ActiveRecord::RecordNotFound
                      render_404
                      return
                    end
                  end
                  @issue.project = @project
                  if request.get?
                    @issue.project ||= @issue.allowed_target_projects.first
                  end
                  @issue.author ||= User.current
                  @issue.start_date ||= User.current.today if Setting.default_issue_start_date_to_creation_date?
                  attrs = (params[:issue] || {}).deep_dup
                  if action_name == 'new' && params[:was_default_status] == attrs[:status_id]
                    attrs.delete(:status_id)
                  end
                  if action_name == 'new' && params[:form_update_triggered_by] == 'issue_project_id'
                    # Discard submitted version when changing the project on the issue form
                    # so we can use the default version for the new project
                    attrs.delete(:fixed_version_id)
                  end
                  @issue.safe_attributes = attrs
                  if @issue.project
                    @issue.tracker ||= @issue.allowed_target_trackers.first
                    if @issue.tracker.nil?
                      if @issue.project.trackers.any?
                        # None of the project trackers is allowed to the user
                        render_error :message => l(:error_no_tracker_allowed_for_new_issue_in_project), :status => 403
                      else
                        # Project has no trackers
                        render_error l(:error_no_tracker_in_project)
                      end
                      return false
                    end
                    if @issue.status.nil?
                      render_error l(:error_no_default_issue_status)
                      return false
                    end
                  end
                  @priorities = IssuePriority.active
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                end
-               def parse_params_for_bulk_issue_attributes(params)
-                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
-                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
-                 if custom = attributes[:custom_field_values]
-                   custom.reject! {|k,v| v.blank?}
-                   custom.keys.each do |k|
-                     if custom[k].is_a?(Array)
-                       custom[k] << '' if custom[k].delete('__none__')
-                     else
-                       custom[k] = '' if custom[k] == '__none__'
-                     end
-                   end
-                 end
-                 attributes
-               end
                # Saves @issue and a time_entry from the parameters
                def save_issue_with_child_records
                  Issue.transaction do
                    if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, @issue.project)
                      time_entry = @time_entry || TimeEntry.new
                      time_entry.project = @issue.project
                      time_entry.issue = @issue
                      time_entry.user = User.current
                      time_entry.spent_on = User.current.today
                      time_entry.attributes = params[:time_entry]
                      @issue.time_entries << time_entry
                    end
                    call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
                    if @issue.save
                      call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
                    else
                      raise ActiveRecord::Rollback
                    end
                  end
                end
                # Returns true if the issue copy should be linked
                # to the original issue
                def link_copy?(param)
                  case Setting.link_copied_issue
                  when 'yes'
                    true
                  when 'no'
                    false
                  when 'ask'
                    param == '1'
                  end
                end
                # Redirects user after a successful issue creation
                def redirect_after_create
                  if params[:continue]
                    attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
                    if params[:project_id]
                      redirect_to new_project_issue_path(@issue.project, :issue => attrs)
                    else
                      attrs.merge! :project_id => @issue.project_id
                      redirect_to new_issue_path(:issue => attrs)
                    end
                  else
                    redirect_to issue_path(@issue)
                  end
                end
              end

app/controllers/timelog_controller.rb +1 -17

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class TimelogController < ApplicationController
                menu_item :issues
                before_filter :find_time_entry, :only => [:show, :edit, :update]
                before_filter :find_time_entries, :only => [:bulk_edit, :bulk_update, :destroy]
                before_filter :authorize, :only => [:show, :edit, :update, :bulk_edit, :bulk_update, :destroy]
                before_filter :find_optional_project, :only => [:new, :create, :index, :report]
                before_filter :authorize_global, :only => [:new, :create, :index, :report]
                accept_rss_auth :index
                accept_api_auth :index, :show, :create, :update, :destroy
                rescue_from Query::StatementInvalid, :with => :query_statement_invalid
                helper :sort
                include SortHelper
                helper :issues
                include TimelogHelper
                helper :custom_fields
                include CustomFieldsHelper
                helper :queries
                include QueriesHelper
                def index
                  @query = TimeEntryQuery.build_from_params(params, :project => @project, :name => '_')
                  sort_init(@query.sort_criteria.empty? ? [['spent_on', 'desc']] : @query.sort_criteria)
                  sort_update(@query.sortable_columns)
                  scope = time_entry_scope(:order => sort_clause).
                    includes(:project, :user, :issue).
                    preload(:issue => [:project, :tracker, :status, :assigned_to, :priority])
                  respond_to do |format|
                    format.html {
                      @entry_count = scope.count
                      @entry_pages = Paginator.new @entry_count, per_page_option, params['page']
                      @entries = scope.offset(@entry_pages.offset).limit(@entry_pages.per_page).to_a
                      @total_hours = scope.sum(:hours).to_f
                      render :layout => !request.xhr?
                    }
                    format.api  {
                      @entry_count = scope.count
                      @offset, @limit = api_offset_and_limit
                      @entries = scope.offset(@offset).limit(@limit).preload(:custom_values => :custom_field).to_a
                    }
                    format.atom {
                      entries = scope.limit(Setting.feeds_limit.to_i).reorder("#{TimeEntry.table_name}.created_on DESC").to_a
                      render_feed(entries, :title => l(:label_spent_time))
                    }
                    format.csv {
                      # Export all entries
                      @entries = scope.to_a
                      send_data(query_to_csv(@entries, @query, params), :type => 'text/csv; header=present', :filename => 'timelog.csv')
                    }
                  end
                end
                def report
                  @query = TimeEntryQuery.build_from_params(params, :project => @project, :name => '_')
                  scope = time_entry_scope
                  @report = Redmine::Helpers::TimeReport.new(@project, @issue, params[:criteria], params[:columns], scope)
                  respond_to do |format|
                    format.html { render :layout => !request.xhr? }
                    format.csv  { send_data(report_to_csv(@report), :type => 'text/csv; header=present', :filename => 'timelog.csv') }
                  end
                end
                def show
                  respond_to do |format|
                    # TODO: Implement html response
                    format.html { render :nothing => true, :status => 406 }
                    format.api
                  end
                end
                def new
                  @time_entry ||= TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => User.current.today)
                  @time_entry.safe_attributes = params[:time_entry]
                end
                def create
                  @time_entry ||= TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => User.current.today)
                  @time_entry.safe_attributes = params[:time_entry]
                  if @time_entry.project && !User.current.allowed_to?(:log_time, @time_entry.project)
                    render_403
                    return
                  end
                  call_hook(:controller_timelog_edit_before_save, { :params => params, :time_entry => @time_entry })
                  if @time_entry.save
                    respond_to do |format|
                      format.html {
                        flash[:notice] = l(:notice_successful_create)
                        if params[:continue]
                          options = {
                            :time_entry => {
                              :project_id => params[:time_entry][:project_id],
                              :issue_id => @time_entry.issue_id,
                              :activity_id => @time_entry.activity_id
                            },
                            :back_url => params[:back_url]
                          }
                          if params[:project_id] && @time_entry.project
                            redirect_to new_project_time_entry_path(@time_entry.project, options)
                          elsif params[:issue_id] && @time_entry.issue
                            redirect_to new_issue_time_entry_path(@time_entry.issue, options)
                          else
                            redirect_to new_time_entry_path(options)
                          end
                        else
                          redirect_back_or_default project_time_entries_path(@time_entry.project)
                        end
                      }
                      format.api  { render :action => 'show', :status => :created, :location => time_entry_url(@time_entry) }
                    end
                  else
                    respond_to do |format|
                      format.html { render :action => 'new' }
                      format.api  { render_validation_errors(@time_entry) }
                    end
                  end
                end
                def edit
                  @time_entry.safe_attributes = params[:time_entry]
                end
                def update
                  @time_entry.safe_attributes = params[:time_entry]
                  call_hook(:controller_timelog_edit_before_save, { :params => params, :time_entry => @time_entry })
                  if @time_entry.save
                    respond_to do |format|
                      format.html {
                        flash[:notice] = l(:notice_successful_update)
                        redirect_back_or_default project_time_entries_path(@time_entry.project)
                      }
                      format.api  { render_api_ok }
                    end
                  else
                    respond_to do |format|
                      format.html { render :action => 'edit' }
                      format.api  { render_validation_errors(@time_entry) }
                    end
                  end
                end
                def bulk_edit
                  @available_activities = TimeEntryActivity.shared.active
                  @custom_fields = TimeEntry.first.available_custom_fields
                end
                def bulk_update
-                 attributes = parse_params_for_bulk_time_entry_attributes(params)
+                 attributes = parse_params_for_bulk_update(params[:time_entry])
                  unsaved_time_entry_ids = []
                  @time_entries.each do |time_entry|
                    time_entry.reload
                    time_entry.safe_attributes = attributes
                    call_hook(:controller_time_entries_bulk_edit_before_save, { :params => params, :time_entry => time_entry })
                    unless time_entry.save
                      logger.info "time entry could not be updated: #{time_entry.errors.full_messages}" if logger && logger.info?
                      # Keep unsaved time_entry ids to display them in flash error
                      unsaved_time_entry_ids << time_entry.id
                    end
                  end
                  set_flash_from_bulk_time_entry_save(@time_entries, unsaved_time_entry_ids)
                  redirect_back_or_default project_time_entries_path(@projects.first)
                end
                def destroy
                  destroyed = TimeEntry.transaction do
                    @time_entries.each do |t|
                      unless t.destroy && t.destroyed?
                        raise ActiveRecord::Rollback
                      end
                    end
                  end
                  respond_to do |format|
                    format.html {
                      if destroyed
                        flash[:notice] = l(:notice_successful_delete)
                      else
                        flash[:error] = l(:notice_unable_delete_time_entry)
                      end
                      redirect_back_or_default project_time_entries_path(@projects.first)
                    }
                    format.api  {
                      if destroyed
                        render_api_ok
                      else
                        render_validation_errors(@time_entries)
                      end
                    }
                  end
                end
              private
                def find_time_entry
                  @time_entry = TimeEntry.find(params[:id])
                  unless @time_entry.editable_by?(User.current)
                    render_403
                    return false
                  end
                  @project = @time_entry.project
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def find_time_entries
                  @time_entries = TimeEntry.where(:id => params[:id] || params[:ids]).to_a
                  raise ActiveRecord::RecordNotFound if @time_entries.empty?
                  raise Unauthorized unless @time_entries.all? {|t| t.editable_by?(User.current)}
                  @projects = @time_entries.collect(&:project).compact.uniq
                  @project = @projects.first if @projects.size == 1
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def set_flash_from_bulk_time_entry_save(time_entries, unsaved_time_entry_ids)
                  if unsaved_time_entry_ids.empty?
                    flash[:notice] = l(:notice_successful_update) unless time_entries.empty?
                  else
                    flash[:error] = l(:notice_failed_to_save_time_entries,
                                      :count => unsaved_time_entry_ids.size,
                                      :total => time_entries.size,
                                      :ids => '#' + unsaved_time_entry_ids.join(', #'))
                  end
                end
                def find_optional_project
                  if params[:issue_id].present?
                    @issue = Issue.find(params[:issue_id])
                    @project = @issue.project
                  elsif params[:project_id].present?
                    @project = Project.find(params[:project_id])
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Returns the TimeEntry scope for index and report actions
                def time_entry_scope(options={})
                  scope = @query.results_scope(options)
                  if @issue
                    scope = scope.on_issue(@issue)
                  end
                  scope
                end
-               def parse_params_for_bulk_time_entry_attributes(params)
-                 attributes = (params[:time_entry] || {}).reject {|k,v| v.blank?}
-                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
-                 if custom = attributes[:custom_field_values]
-                   custom.reject! {|k,v| v.blank?}
-                   custom.keys.each do |k|
-                     if custom[k].is_a?(Array)
-                       custom[k] << '' if custom[k].delete('__none__')
-                     else
-                       custom[k] = '' if custom[k] == '__none__'
-                     end
-                   end
-                 end
-                 attributes
-               end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages