jro_apps/redmine Commit - r3406:f5f5a5f64f29

Verify issues are updated by HTTP PUT only. Regression from r3486....

Eric Davis -

r3406:f5f5a5f64f29

parent child

Context file:

r3406:f5f5a5f64f29

Collapse all files

app/controllers/issues_controller.rb +3 -1

              # Redmine - project management software
              # Copyright (C) 2006-2008  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class IssuesController < ApplicationController
                menu_item :new_issue, :only => :new
                default_search_scope :issues
                before_filter :find_issue, :only => [:show, :edit, :update, :reply]
                before_filter :find_issues, :only => [:bulk_edit, :move, :destroy]
                before_filter :find_project, :only => [:new, :update_form, :preview]
                before_filter :authorize, :except => [:index, :changes, :gantt, :calendar, :preview, :context_menu]
                before_filter :find_optional_project, :only => [:index, :changes, :gantt, :calendar]
                accept_key_auth :index, :show, :changes
                rescue_from Query::StatementInvalid, :with => :query_statement_invalid
                helper :journals
                helper :projects
                include ProjectsHelper
                helper :custom_fields
                include CustomFieldsHelper
                helper :issue_relations
                include IssueRelationsHelper
                helper :watchers
                include WatchersHelper
                helper :attachments
                include AttachmentsHelper
                helper :queries
                include QueriesHelper
                helper :sort
                include SortHelper
                include IssuesHelper
                helper :timelog
                include Redmine::Export::PDF
                verify :method => [:post, :delete],
                       :only => :destroy,
                       :render => { :nothing => true, :status => :method_not_allowed }
+               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
                def index
                  retrieve_query
                  sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                  sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h}))
                  if @query.valid?
                    limit = case params[:format]
                    when 'csv', 'pdf'
                      Setting.issues_export_limit.to_i
                    when 'atom'
                      Setting.feeds_limit.to_i
                    else
                      per_page_option
                    end
                    @issue_count = @query.issue_count
                    @issue_pages = Paginator.new self, @issue_count, limit, params['page']
                    @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                            :order => sort_clause,
                                            :offset => @issue_pages.current.offset,
                                            :limit => limit)
                    @issue_count_by_group = @query.issue_count_by_group
                    respond_to do |format|
                      format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
                      format.xml  { render :layout => false }
                      format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                      format.csv  { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
                      format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                    end
                  else
                    # Send html if the query is not valid
                    render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def changes
                  retrieve_query
                  sort_init 'id', 'desc'
                  sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h}))
                  if @query.valid?
                    @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",
                                                :limit => 25)
                  end
                  @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)
                  render :layout => false, :content_type => 'application/atom+xml'
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def show
                  @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                  @journals.each_with_index {|j,i| j.indice = i+1}
                  @journals.reverse! if User.current.wants_comments_in_reverse_order?
                  @changesets = @issue.changesets.visible.all
                  @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                  @priorities = IssuePriority.all
                  @time_entry = TimeEntry.new
                  respond_to do |format|
                    format.html { render :template => 'issues/show.rhtml' }
                    format.xml  { render :layout => false }
                    format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }
                    format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                  end
                end
                # Add a new issue
                # The new issue will be created from an existing one if copy_from parameter is given
                def new
                  @issue = Issue.new
                  @issue.copy_from(params[:copy_from]) if params[:copy_from]
                  @issue.project = @project
                  # Tracker must be set before custom field values
                  @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                  if @issue.tracker.nil?
                    render_error l(:error_no_tracker_in_project)
                    return
                  end
                  if params[:issue].is_a?(Hash)
                    @issue.safe_attributes = params[:issue]
                    @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
                  end
                  @issue.author = User.current
                  default_status = IssueStatus.default
                  unless default_status
                    render_error l(:error_no_default_issue_status)
                    return
                  end
                  @issue.status = default_status
                  @allowed_statuses = ([default_status] + default_status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
                  if request.get? || request.xhr?
                    @issue.start_date ||= Date.today
                  else
                    requested_status = IssueStatus.find_by_id(params[:issue][:status_id])
                    # Check that the user is allowed to apply the requested status
                    @issue.status = (@allowed_statuses.include? requested_status) ? requested_status : default_status
                    call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                    if @issue.save
                      attach_files(@issue, params[:attachments])
                      flash[:notice] = l(:notice_successful_create)
                      call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                      respond_to do |format|
                        format.html {
                          redirect_to(params[:continue] ? { :action => 'new', :tracker_id => @issue.tracker } :
                                                          { :action => 'show', :id => @issue })
                        }
                        format.xml  { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
                      end
                      return
                    else
                      respond_to do |format|
                        format.html { }
                        format.xml  { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
                      end
                    end
                  end
                  @priorities = IssuePriority.all
                  render :layout => !request.xhr?
                end
                # Attributes that can be updated on workflow transition (without :edit permission)
                # TODO: make it configurable (at least per role)
                UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
                def edit
                  update_issue_from_params
                  respond_to do |format|
                    format.html { }
                    format.xml  { }
                  end
                end
                def update
                  update_issue_from_params
                  if issue_update
                    respond_to do |format|
                      format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                      format.xml  { head :ok }
                    end
                  else
                    respond_to do |format|
                      format.html { render :action => 'edit' }
                      format.xml  { render :xml => @issue.errors, :status => :unprocessable_entity }
                    end
                  end
                rescue ActiveRecord::StaleObjectError
                  # Optimistic locking exception
                  flash.now[:error] = l(:notice_locking_conflict)
                  # Remove the previously added attachments if issue was not updated
                  attachments.each(&:destroy)
                end
                def reply
                  journal = Journal.find(params[:journal_id]) if params[:journal_id]
                  if journal
                    user = journal.user
                    text = journal.notes
                  else
                    user = @issue.author
                    text = @issue.description
                  end
                  content = "#{ll(Setting.default_language, :text_user_wrote, user)}\\n> "
                  content << text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]').gsub('"', '\"').gsub(/(\r?\n|\r\n?)/, "\\n> ") + "\\n\\n"
                  render(:update) { |page|
                    page.<< "$('notes').value = \"#{content}\";"
                    page.show 'update'
                    page << "Form.Element.focus('notes');"
                    page << "Element.scrollTo('update');"
                    page << "$('notes').scrollTop = $('notes').scrollHeight - $('notes').clientHeight;"
                  }
                end
                # Bulk edit a set of issues
                def bulk_edit
                  if request.post?
                    attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                    attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                    attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                    unsaved_issue_ids = []
                    @issues.each do |issue|
                      journal = issue.init_journal(User.current, params[:notes])
                      issue.safe_attributes = attributes
                      call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                      unless issue.save
                        # Keep unsaved issue ids to display them in flash error
                        unsaved_issue_ids << issue.id
                      end
                    end
                    if unsaved_issue_ids.empty?
                      flash[:notice] = l(:notice_successful_update) unless @issues.empty?
                    else
                      flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size,
                                                                       :total => @issues.size,
                                                                       :ids => '#' + unsaved_issue_ids.join(', #'))
                    end
                    redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
                    return
                  end
                  @available_statuses = Workflow.available_statuses(@project)
                  @custom_fields = @project.all_issue_custom_fields
                end
                def move
                  @copy = params[:copy_options] && params[:copy_options][:copy]
                  @allowed_projects = []
                  # find projects to which the user is allowed to move the issue
                  if User.current.admin?
                    # admin is allowed to move issues to any active (visible) project
                    @allowed_projects = Project.find(:all, :conditions => Project.visible_by(User.current))
                  else
                    User.current.memberships.each {|m| @allowed_projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
                  end
                  @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:new_project_id]} if params[:new_project_id]
                  @target_project ||= @project
                  @trackers = @target_project.trackers
                  @available_statuses = Workflow.available_statuses(@project)
                  if request.post?
                    new_tracker = params[:new_tracker_id].blank? ? nil : @target_project.trackers.find_by_id(params[:new_tracker_id])
                    unsaved_issue_ids = []
                    moved_issues = []
                    @issues.each do |issue|
                      changed_attributes = {}
                      [:assigned_to_id, :status_id, :start_date, :due_date].each do |valid_attribute|
                        unless params[valid_attribute].blank?
                          changed_attributes[valid_attribute] = (params[valid_attribute] == 'none' ? nil : params[valid_attribute])
                        end
                      end
                      issue.init_journal(User.current)
                      call_hook(:controller_issues_move_before_save, { :params => params, :issue => issue, :target_project => @target_project, :copy => !!@copy })
                      if r = issue.move_to(@target_project, new_tracker, {:copy => @copy, :attributes => changed_attributes})
                        moved_issues << r
                      else
                        unsaved_issue_ids << issue.id
                      end
                    end
                    if unsaved_issue_ids.empty?
                      flash[:notice] = l(:notice_successful_update) unless @issues.empty?
                    else
                      flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size,
                                                                       :total => @issues.size,
                                                                       :ids => '#' + unsaved_issue_ids.join(', #'))
                    end
                    if params[:follow]
                      if @issues.size == 1 && moved_issues.size == 1
                        redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
                      else
                        redirect_to :controller => 'issues', :action => 'index', :project_id => (@target_project || @project)
                      end
                    else
                      redirect_to :controller => 'issues', :action => 'index', :project_id => @project
                    end
                    return
                  end
                  render :layout => false if request.xhr?
                end
                def destroy
                  @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                  if @hours > 0
                    case params[:todo]
                    when 'destroy'
                      # nothing to do
                    when 'nullify'
                      TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                    when 'reassign'
                      reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                      if reassign_to.nil?
                        flash.now[:error] = l(:error_issue_not_found_in_project)
                        return
                      else
                        TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                      end
                    else
                      unless params[:format] == 'xml'
                        # display the destroy form if it's a user request
                        return
                      end
                    end
                  end
                  @issues.each(&:destroy)
                  respond_to do |format|
                    format.html { redirect_to :action => 'index', :project_id => @project }
                    format.xml  { head :ok }
                  end
                end
                def gantt
                  @gantt = Redmine::Helpers::Gantt.new(params)
                  retrieve_query
                  @query.group_by = nil
                  if @query.valid?
                    events = []
                    # Issues that have start and due dates
                    events += @query.issues(:include => [:tracker, :assigned_to, :priority],
                                            :order => "start_date, due_date",
                                            :conditions => ["(((start_date>=? and start_date<=?) or (due_date>=? and due_date<=?) or (start_date<? and due_date>?)) and start_date is not null and due_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to]
                                            )
                    # Issues that don't have a due date but that are assigned to a version with a date
                    events += @query.issues(:include => [:tracker, :assigned_to, :priority, :fixed_version],
                                            :order => "start_date, effective_date",
                                            :conditions => ["(((start_date>=? and start_date<=?) or (effective_date>=? and effective_date<=?) or (start_date<? and effective_date>?)) and start_date is not null and due_date is null and effective_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to]
                                            )
                    # Versions
                    events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @gantt.date_from, @gantt.date_to])
                    @gantt.events = events
                  end
                  basename = (@project ? "#{@project.identifier}-" : '') + 'gantt'
                  respond_to do |format|
                    format.html { render :template => "issues/gantt.rhtml", :layout => !request.xhr? }
                    format.png  { send_data(@gantt.to_image, :disposition => 'inline', :type => 'image/png', :filename => "#{basename}.png") } if @gantt.respond_to?('to_image')
                    format.pdf  { send_data(gantt_to_pdf(@gantt, @project), :type => 'application/pdf', :filename => "#{basename}.pdf") }
                  end
                end
                def calendar
                  if params[:year] and params[:year].to_i > 1900
                    @year = params[:year].to_i
                    if params[:month] and params[:month].to_i > 0 and params[:month].to_i < 13
                      @month = params[:month].to_i
                    end
                  end
                  @year ||= Date.today.year
                  @month ||= Date.today.month
                  @calendar = Redmine::Helpers::Calendar.new(Date.civil(@year, @month, 1), current_language, :month)
                  retrieve_query
                  @query.group_by = nil
                  if @query.valid?
                    events = []
                    events += @query.issues(:include => [:tracker, :assigned_to, :priority],
                                            :conditions => ["((start_date BETWEEN ? AND ?) OR (due_date BETWEEN ? AND ?))", @calendar.startdt, @calendar.enddt, @calendar.startdt, @calendar.enddt]
                                            )
                    events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @calendar.startdt, @calendar.enddt])
                    @calendar.events = events
                  end
                  render :layout => false if request.xhr?
                end
                def context_menu
                  @issues = Issue.find_all_by_id(params[:ids], :include => :project)
                  if (@issues.size == 1)
                    @issue = @issues.first
                    @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  end
                  projects = @issues.collect(&:project).compact.uniq
                  @project = projects.first if projects.size == 1
                  @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),
                          :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
                          :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),
                          :move => (@project && User.current.allowed_to?(:move_issues, @project)),
                          :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
                          :delete => (@project && User.current.allowed_to?(:delete_issues, @project))
                          }
                  if @project
                    @assignables = @project.assignable_users
                    @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)
                    @trackers = @project.trackers
                  end
                  @priorities = IssuePriority.all.reverse
                  @statuses = IssueStatus.find(:all, :order => 'position')
                  @back = params[:back_url] || request.env['HTTP_REFERER']
                  render :layout => false
                end
                def update_form
                  if params[:id].blank?
                    @issue = Issue.new
                    @issue.project = @project
                  else
                    @issue = @project.issues.visible.find(params[:id])
                  end
                  @issue.attributes = params[:issue]
                  @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
                  @priorities = IssuePriority.all
                  render :partial => 'attributes'
                end
                def preview
                  @issue = @project.issues.find_by_id(params[:id]) unless params[:id].blank?
                  @attachements = @issue.attachments if @issue
                  @text = params[:notes] || (params[:issue] ? params[:issue][:description] : nil)
                  render :partial => 'common/preview'
                end
              private
                def find_issue
                  @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                  @project = @issue.project
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Filter for bulk operations
                def find_issues
                  @issues = Issue.find_all_by_id(params[:id] || params[:ids])
                  raise ActiveRecord::RecordNotFound if @issues.empty?
                  projects = @issues.collect(&:project).compact.uniq
                  if projects.size == 1
                    @project = projects.first
                  else
                    # TODO: let users bulk edit/move/destroy issues from different projects
                    render_error 'Can not bulk edit/move/destroy issues from different projects'
                    return false
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def find_project
                  project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
                  @project = Project.find(project_id)
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def find_optional_project
                  @project = Project.find(params[:project_id]) unless params[:project_id].blank?
                  allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true)
                  allowed ? true : deny_access
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Retrieve query from session or build a new query
                def retrieve_query
                  if !params[:query_id].blank?
                    cond = "project_id IS NULL"
                    cond << " OR project_id = #{@project.id}" if @project
                    @query = Query.find(params[:query_id], :conditions => cond)
                    @query.project = @project
                    session[:query] = {:id => @query.id, :project_id => @query.project_id}
                    sort_clear
                  else
                    if api_request? || params[:set_filter] || session[:query].nil? || session[:query][:project_id] != (@project ? @project.id : nil)
                      # Give it a name, required to be valid
                      @query = Query.new(:name => "_")
                      @query.project = @project
                      if params[:fields] and params[:fields].is_a? Array
                        params[:fields].each do |field|
                          @query.add_filter(field, params[:operators][field], params[:values][field])
                        end
                      else
                        @query.available_filters.keys.each do |field|
                          @query.add_short_filter(field, params[field]) if params[field]
                        end
                      end
                      @query.group_by = params[:group_by]
                      @query.column_names = params[:query] && params[:query][:column_names]
                      session[:query] = {:project_id => @query.project_id, :filters => @query.filters, :group_by => @query.group_by, :column_names => @query.column_names}
                    else
                      @query = Query.find_by_id(session[:query][:id]) if session[:query][:id]
                      @query ||= Query.new(:name => "_", :project => @project, :filters => session[:query][:filters], :group_by => session[:query][:group_by], :column_names => session[:query][:column_names])
                      @query.project = @project
                    end
                  end
                end
                # Rescues an invalid query statement. Just in case...
                def query_statement_invalid(exception)
                  logger.error "Query::StatementInvalid: #{exception.message}" if logger
                  session.delete(:query)
                  sort_clear
                  render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator."
                end
                # Used by #edit and #update to set some common instance variables
                # from the params
                # TODO: Refactor, not everything in here is needed by #edit
                def update_issue_from_params
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  @priorities = IssuePriority.all
                  @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                  @time_entry = TimeEntry.new
                  @notes = params[:notes]
                  @journal = @issue.init_journal(User.current, @notes)
                  # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                  if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
                    attrs = params[:issue].dup
                    attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
                    attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
                    @issue.safe_attributes = attrs
                  end
                end
                # TODO: Temporary utility method for #update.  Should be split off
                # and moved to the Issue model (accepts_nested_attributes_for maybe?)
                # TODO: move attach_files to the model so this can be moved to the
                # model also
                def issue_update
                  if params[:time_entry] && params[:time_entry][:hours].present? && User.current.allowed_to?(:log_time, @project)
                    @time_entry = TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today)
                    @time_entry.attributes = params[:time_entry]
                    @issue.time_entries << @time_entry
                  end
                  if @issue.valid?
                    attachments = attach_files(@issue, params[:attachments])
                    attachments.each {|a| @journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
                    call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => @journal})
                    if @issue.save
                      if !@journal.new_record?
                        # Only send notification if something was actually changed
                        flash[:notice] = l(:notice_successful_update)
                      end
                      call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => @journal})
                      return true
                    end
                  end
                  # failure, returns false
                end
              end

test/functional/issues_controller_test.rb +14 0

              # Redmine - project management software
              # Copyright (C) 2006-2008  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.dirname(__FILE__) + '/../test_helper'
              require 'issues_controller'
              # Re-raise errors caught by the controller.
              class IssuesController; def rescue_action(e) raise e end; end
              class IssuesControllerTest < ActionController::TestCase
                fixtures :projects,
                         :users,
                         :roles,
                         :members,
                         :member_roles,
                         :issues,
                         :issue_statuses,
                         :versions,
                         :trackers,
                         :projects_trackers,
                         :issue_categories,
                         :enabled_modules,
                         :enumerations,
                         :attachments,
                         :workflows,
                         :custom_fields,
                         :custom_values,
                         :custom_fields_projects,
                         :custom_fields_trackers,
                         :time_entries,
                         :journals,
                         :journal_details,
                         :queries
                def setup
                  @controller = IssuesController.new
                  @request    = ActionController::TestRequest.new
                  @response   = ActionController::TestResponse.new
                  User.current = nil
                end
                def test_index
                  Setting.default_language = 'en'
                  get :index
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:project)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  # private projects hidden
                  assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                  assert_no_tag :tag => 'a', :content => /Issue on project 2/
                  # project column
                  assert_tag :tag => 'th', :content => /Project/
                end
                def test_index_should_not_list_issues_when_module_disabled
                  EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
                  get :index
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:project)
                  assert_no_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                end
                def test_index_should_not_list_issues_when_module_disabled
                  EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
                  get :index
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:project)
                  assert_no_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                end
                def test_index_with_project
                  Setting.display_subprojects_issues = 0
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_no_tag :tag => 'a', :content => /Subproject issue/
                end
                def test_index_with_project_and_subprojects
                  Setting.display_subprojects_issues = 1
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                end
                def test_index_with_project_and_subprojects_should_show_private_subprojects
                  @request.session[:user_id] = 2
                  Setting.display_subprojects_issues = 1
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  assert_tag :tag => 'a', :content => /Issue of a private subproject/
                end
                def test_index_with_project_and_filter
                  get :index, :project_id => 1, :set_filter => 1
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                end
                def test_index_with_query
                  get :index, :project_id => 1, :query_id => 5
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:issue_count_by_group)
                end
                def test_index_with_query_grouped_by_tracker
                  get :index, :project_id => 1, :query_id => 6
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                end
                def test_index_with_query_grouped_by_list_custom_field
                  get :index, :project_id => 1, :query_id => 9
                  assert_response :success
                  assert_template 'index.rhtml'
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                end
                def test_index_sort_by_field_not_included_in_columns
                  Setting.issue_list_default_columns = %w(subject author)
                  get :index, :sort => 'tracker'
                end
                def test_index_csv_with_project
                  Setting.default_language = 'en'
                  get :index, :format => 'csv'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                  assert @response.body.starts_with?("#,")
                  get :index, :project_id => 1, :format => 'csv'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                end
                def test_index_pdf
                  get :index, :format => 'pdf'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'application/pdf', @response.content_type
                  get :index, :project_id => 1, :format => 'pdf'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'application/pdf', @response.content_type
                  get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'application/pdf', @response.content_type
                end
                def test_index_pdf_with_query_grouped_by_list_custom_field
                  get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                  assert_equal 'application/pdf', @response.content_type
                end
                def test_index_sort
                  get :index, :sort => 'tracker,id:desc'
                  assert_response :success
                  sort_params = @request.session['issues_index_sort']
                  assert sort_params.is_a?(String)
                  assert_equal 'tracker,id:desc', sort_params
                  issues = assigns(:issues)
                  assert_not_nil issues
                  assert !issues.empty?
                  assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
                end
                def test_index_with_columns
                  columns = ['tracker', 'subject', 'assigned_to']
                  get :index, :set_filter => 1, :query => { 'column_names' => columns}
                  assert_response :success
                  # query should use specified columns
                  query = assigns(:query)
                  assert_kind_of Query, query
                  assert_equal columns, query.column_names.map(&:to_s)
                  # columns should be stored in session
                  assert_kind_of Hash, session[:query]
                  assert_kind_of Array, session[:query][:column_names]
                  assert_equal columns, session[:query][:column_names].map(&:to_s)
                end
                def test_gantt
                  get :gantt, :project_id => 1
                  assert_response :success
                  assert_template 'gantt.rhtml'
                  assert_not_nil assigns(:gantt)
                  events = assigns(:gantt).events
                  assert_not_nil events
                  # Issue with start and due dates
                  i = Issue.find(1)
                  assert_not_nil i.due_date
                  assert events.include?(Issue.find(1))
                  # Issue with without due date but targeted to a version with date
                  i = Issue.find(2)
                  assert_nil i.due_date
                  assert events.include?(i)
                end
                def test_cross_project_gantt
                  get :gantt
                  assert_response :success
                  assert_template 'gantt.rhtml'
                  assert_not_nil assigns(:gantt)
                  events = assigns(:gantt).events
                  assert_not_nil events
                end
                def test_gantt_export_to_pdf
                  get :gantt, :project_id => 1, :format => 'pdf'
                  assert_response :success
                  assert_equal 'application/pdf', @response.content_type
                  assert @response.body.starts_with?('%PDF')
                  assert_not_nil assigns(:gantt)
                end
                def test_cross_project_gantt_export_to_pdf
                  get :gantt, :format => 'pdf'
                  assert_response :success
                  assert_equal 'application/pdf', @response.content_type
                  assert @response.body.starts_with?('%PDF')
                  assert_not_nil assigns(:gantt)
                end
                if Object.const_defined?(:Magick)
                  def test_gantt_image
                    get :gantt, :project_id => 1, :format => 'png'
                    assert_response :success
                    assert_equal 'image/png', @response.content_type
                  end
                else
                  puts "RMagick not installed. Skipping tests !!!"
                end
                def test_calendar
                  get :calendar, :project_id => 1
                  assert_response :success
                  assert_template 'calendar'
                  assert_not_nil assigns(:calendar)
                end
                def test_cross_project_calendar
                  get :calendar
                  assert_response :success
                  assert_template 'calendar'
                  assert_not_nil assigns(:calendar)
                end
                def test_changes
                  get :changes, :project_id => 1
                  assert_response :success
                  assert_not_nil assigns(:journals)
                  assert_equal 'application/atom+xml', @response.content_type
                end
                def test_show_by_anonymous
                  get :show, :id => 1
                  assert_response :success
                  assert_template 'show.rhtml'
                  assert_not_nil assigns(:issue)
                  assert_equal Issue.find(1), assigns(:issue)
                  # anonymous role is allowed to add a note
                  assert_tag :tag => 'form',
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Notes/ } }
                end
                def test_show_by_manager
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_response :success
                  assert_tag :tag => 'form',
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Change properties/ } },
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Log time/ } },
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Notes/ } }
                end
                def test_show_should_deny_anonymous_access_without_permission
                  Role.anonymous.remove_permission!(:view_issues)
                  get :show, :id => 1
                  assert_response :redirect
                end
                def test_show_should_deny_non_member_access_without_permission
                  Role.non_member.remove_permission!(:view_issues)
                  @request.session[:user_id] = 9
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_deny_member_access_without_permission
                  Role.find(1).remove_permission!(:view_issues)
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_not_disclose_relations_to_invisible_issues
                  Setting.cross_project_issue_relations = '1'
                  IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
                  # Relation to a private project issue
                  IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
                  get :show, :id => 1
                  assert_response :success
                  assert_tag :div, :attributes => { :id => 'relations' },
                                   :descendant => { :tag => 'a', :content => /#2$/ }
                  assert_no_tag :div, :attributes => { :id => 'relations' },
                                      :descendant => { :tag => 'a', :content => /#4$/ }
                end
                def test_show_atom
                  get :show, :id => 2, :format => 'atom'
                  assert_response :success
                  assert_template 'changes.rxml'
                  # Inline image
                  assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;"), "Body did not match. Body: #{@response.body}"
                end
                def test_show_export_to_pdf
                  get :show, :id => 3, :format => 'pdf'
                  assert_response :success
                  assert_equal 'application/pdf', @response.content_type
                  assert @response.body.starts_with?('%PDF')
                  assert_not_nil assigns(:issue)
                end
                def test_get_new
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :tracker_id => 1
                  assert_response :success
                  assert_template 'new'
                  assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
                                                               :value => 'Default string' }
                end
                def test_get_new_without_tracker_id
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1
                  assert_response :success
                  assert_template 'new'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal Project.find(1).trackers.first, issue.tracker
                end
                def test_get_new_with_no_default_status_should_display_an_error
                  @request.session[:user_id] = 2
                  IssueStatus.delete_all
                  get :new, :project_id => 1
                  assert_response 500
                  assert_not_nil flash[:error]
                  assert_tag :tag => 'div', :attributes => { :class => /error/ },
                                            :content => /No default issue/
                end
                def test_get_new_with_no_tracker_should_display_an_error
                  @request.session[:user_id] = 2
                  Tracker.delete_all
                  get :new, :project_id => 1
                  assert_response 500
                  assert_not_nil flash[:error]
                  assert_tag :tag => 'div', :attributes => { :class => /error/ },
                                            :content => /No tracker/
                end
                def test_update_new_form
                  @request.session[:user_id] = 2
                  xhr :post, :update_form, :project_id => 1,
                                   :issue => {:tracker_id => 2,
                                              :subject => 'This is the test_new issue',
                                              :description => 'This is the description',
                                              :priority_id => 5}
                  assert_response :success
                  assert_template 'attributes'
                  issue = assigns(:issue)
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.project_id
                  assert_equal 2, issue.tracker_id
                  assert_equal 'This is the test_new issue', issue.subject
                end
                def test_post_new
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :new, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  issue = Issue.find_by_subject('This is the test_new issue')
                  assert_not_nil issue
                  assert_equal 2, issue.author_id
                  assert_equal 3, issue.tracker_id
                  assert_nil issue.estimated_hours
                  v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
                  assert_not_nil v
                  assert_equal 'Value for field 2', v.value
                end
                def test_post_new_and_continue
                  @request.session[:user_id] = 2
                  post :new, :project_id => 1,
                             :issue => {:tracker_id => 3,
                                        :subject => 'This is first issue',
                                        :priority_id => 5},
                             :continue => ''
                  assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3
                end
                def test_post_new_without_custom_fields_param
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :new, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                end
                def test_post_new_with_required_custom_field_and_without_custom_fields_param
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  @request.session[:user_id] = 2
                  post :new, :project_id => 1,
                             :issue => {:tracker_id => 1,
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
                  assert_response :success
                  assert_template 'new'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
                end
                def test_post_new_with_watchers
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  assert_difference 'Watcher.count', 2 do
                    post :new, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a new issue with watchers',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :watcher_user_ids => ['2', '3']}
                  end
                  issue = Issue.find_by_subject('This is a new issue with watchers')
                  assert_not_nil issue
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
                  # Watchers added
                  assert_equal [2, 3], issue.watcher_user_ids.sort
                  assert issue.watched_by?(User.find(3))
                  # Watchers notified
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
                end
                def test_post_new_should_send_a_notification
                  ActionMailer::Base.deliveries.clear
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :new, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_post_should_preserve_fields_values_on_validation_failure
                  @request.session[:user_id] = 2
                  post :new, :project_id => 1,
                             :issue => {:tracker_id => 1,
                                        # empty subject
                                        :subject => '',
                                        :description => 'This is a description',
                                        :priority_id => 6,
                                        :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
                  assert_response :success
                  assert_template 'new'
                  assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                                        :content => 'This is a description'
                  assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                      :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                     :value => '6' },
                                                                    :content => 'High' }
                  # Custom fields
                  assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                                      :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                     :value => 'Oracle' },
                                                                    :content => 'Oracle' }
                  assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                                      :value => 'Value for field 2'}
                end
                def test_post_new_should_ignore_non_safe_attributes
                  @request.session[:user_id] = 2
                  assert_nothing_raised do
                    post :new, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
                  end
                end
                def test_copy_issue
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :copy_from => 1
                  assert_template 'new'
                  assert_not_nil assigns(:issue)
                  orig = Issue.find(1)
                  assert_equal orig.subject, assigns(:issue).subject
                end
                def test_get_edit
                  @request.session[:user_id] = 2
                  get :edit, :id => 1
                  assert_response :success
                  assert_template 'edit'
                  assert_not_nil assigns(:issue)
                  assert_equal Issue.find(1), assigns(:issue)
                end
                def test_get_edit_with_params
                  @request.session[:user_id] = 2
                  get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
                  assert_response :success
                  assert_template 'edit'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal 5, issue.status_id
                  assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                                      :child => { :tag => 'option',
                                                  :content => 'Closed',
                                                  :attributes => { :selected => 'selected' } }
                  assert_equal 7, issue.priority_id
                  assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                      :child => { :tag => 'option',
                                                  :content => 'Urgent',
                                                  :attributes => { :selected => 'selected' } }
                end
                def test_update_edit_form
                  @request.session[:user_id] = 2
                  xhr :post, :update_form, :project_id => 1,
                                           :id => 1,
                                           :issue => {:tracker_id => 2,
                                                      :subject => 'This is the test_new issue',
                                                      :description => 'This is the description',
                                                      :priority_id => 5}
                  assert_response :success
                  assert_template 'attributes'
                  issue = assigns(:issue)
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.id
                  assert_equal 1, issue.project_id
                  assert_equal 2, issue.tracker_id
                  assert_equal 'This is the test_new issue', issue.subject
                end
                def test_reply_to_issue
                  @request.session[:user_id] = 2
                  get :reply, :id => 1
                  assert_response :success
                  assert_select_rjs :show, "update"
                end
                def test_reply_to_note
                  @request.session[:user_id] = 2
                  get :reply, :id => 1, :journal_id => 2
                  assert_response :success
                  assert_select_rjs :show, "update"
                end
+               def test_update_using_invalid_http_verbs
+                 @request.session[:user_id] = 2
+                 subject = 'Updated by an invalid http verb'
+                 get :update, :id => 1, :issue => {:subject => subject}
+                 assert_not_equal subject, Issue.find(1).subject
+                 post :update, :id => 1, :issue => {:subject => subject}
+                 assert_not_equal subject, Issue.find(1).subject
+                 delete :update, :id => 1, :issue => {:subject => subject}
+                 assert_not_equal subject, Issue.find(1).subject
+               end
                def test_put_update_without_custom_fields_param
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  assert_equal '125', issue.custom_value_for(2).value
                  old_subject = issue.subject
                  new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                  assert_difference('Journal.count') do
                    assert_difference('JournalDetail.count', 2) do
                      put :update, :id => 1, :issue => {:subject => new_subject,
                                                       :priority_id => '6',
                                                       :category_id => '1' # no change
                                                      }
                    end
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal new_subject, issue.subject
                  # Make sure custom fields were not cleared
                  assert_equal '125', issue.custom_value_for(2).value
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                  assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
                end
                def test_put_update_with_custom_field_change
                  @request.session[:user_id] = 2
                  issue = Issue.find(1)
                  assert_equal '125', issue.custom_value_for(2).value
                  assert_difference('Journal.count') do
                    assert_difference('JournalDetail.count', 3) do
                      put :update, :id => 1, :issue => {:subject => 'Custom field change',
                                                       :priority_id => '6',
                                                       :category_id => '1', # no change
                                                       :custom_field_values => { '2' => 'New custom value' }
                                                      }
                    end
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal 'New custom value', issue.custom_value_for(2).value
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert mail.body.include?("Searchable field changed from 125 to New custom value")
                end
                def test_put_update_with_status_and_assignee_change
                  issue = Issue.find(1)
                  assert_equal 1, issue.status_id
                  @request.session[:user_id] = 2
                  assert_difference('TimeEntry.count', 0) do
                    put :update,
                         :id => 1,
                         :issue => { :status_id => 2, :assigned_to_id => 3 },
                         :notes => 'Assigned to dlopper',
                         :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal 2, issue.status_id
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal 'Assigned to dlopper', j.notes
                  assert_equal 2, j.details.size
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?("Status changed from New to Assigned")
                  # subject should contain the new status
                  assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
                end
                def test_put_update_with_note_only
                  notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
                  # anonymous user
                  put :update,
                       :id => 1,
                       :notes => notes
                  assert_redirected_to :action => 'show', :id => '1'
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal notes, j.notes
                  assert_equal 0, j.details.size
                  assert_equal User.anonymous, j.user
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?(notes)
                end
                def test_put_update_with_note_and_spent_time
                  @request.session[:user_id] = 2
                  spent_hours_before = Issue.find(1).spent_hours
                  assert_difference('TimeEntry.count') do
                    put :update,
                         :id => 1,
                         :notes => '2.5 hours added',
                         :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first }
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue = Issue.find(1)
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal '2.5 hours added', j.notes
                  assert_equal 0, j.details.size
                  t = issue.time_entries.find(:first, :order => 'id DESC')
                  assert_not_nil t
                  assert_equal 2.5, t.hours
                  assert_equal spent_hours_before + 2.5, issue.spent_hours
                end
                def test_put_update_with_attachment_only
                  set_tmp_attachments_directory
                  # Delete all fixtured journals, a race condition can occur causing the wrong
                  # journal to get fetched in the next find.
                  Journal.delete_all
                  # anonymous user
                  put :update,
                       :id => 1,
                       :notes => '',
                       :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
                  assert_redirected_to :action => 'show', :id => '1'
                  j = Issue.find(1).journals.find(:first, :order => 'id DESC')
                  assert j.notes.blank?
                  assert_equal 1, j.details.size
                  assert_equal 'testfile.txt', j.details.first.value
                  assert_equal User.anonymous, j.user
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?('testfile.txt')
                end
                def test_put_update_with_no_change
                  issue = Issue.find(1)
                  issue.journals.clear
                  ActionMailer::Base.deliveries.clear
                  put :update,
                       :id => 1,
                       :notes => ''
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert issue.journals.empty?
                  # No email should be sent
                  assert ActionMailer::Base.deliveries.empty?
                end
                def test_put_update_should_send_a_notification
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  old_subject = issue.subject
                  new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                  put :update, :id => 1, :issue => {:subject => new_subject,
                                                   :priority_id => '6',
                                                   :category_id => '1' # no change
                                                  }
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_put_update_with_invalid_spent_time
                  @request.session[:user_id] = 2
                  notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                  assert_no_difference('Journal.count') do
                    put :update,
                         :id => 1,
                         :notes => notes,
                         :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
                  end
                  assert_response :success
                  assert_template 'edit'
                  assert_tag :textarea, :attributes => { :name => 'notes' },
                                        :content => notes
                  assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
                end
                def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       }
                  assert_response :redirect
                  issue.reload
                  assert_equal 4, issue.fixed_version_id
                  assert_not_equal issue.project_id, issue.fixed_version.project_id
                end
                def test_put_update_should_redirect_back_using_the_back_url_parameter
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       },
                       :back_url => '/issues'
                  assert_response :redirect
                  assert_redirected_to '/issues'
                end
                def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       },
                       :back_url => 'http://google.com'
                  assert_response :redirect
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
                end
                def test_get_bulk_edit
                  @request.session[:user_id] = 2
                  get :bulk_edit, :ids => [1, 2]
                  assert_response :success
                  assert_template 'bulk_edit'
                  # Project specific custom field, date type
                  field = CustomField.find(9)
                  assert !field.is_for_all?
                  assert_equal 'date', field.field_format
                  assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
                  # System wide custom field
                  assert CustomField.find(1).is_for_all?
                  assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
                end
                def test_bulk_edit
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing',
                                                   :issue => {:priority_id => 7,
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => ''}}
                  assert_response 302
                  # check that the issues were updated
                  assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
                  issue = Issue.find(1)
                  journal = issue.journals.find(:first, :order => 'created_on DESC')
                  assert_equal '125', issue.custom_value_for(2).value
                  assert_equal 'Bulk editing', journal.notes
                  assert_equal 1, journal.details.size
                end
                def test_bullk_edit_should_send_a_notification
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  post(:bulk_edit,
                       {
                         :ids => [1, 2],
                         :notes => 'Bulk editing',
                         :issue => {
                           :priority_id => 7,
                           :assigned_to_id => '',
                           :custom_field_values => {'2' => ''}
                         }
                       })
                  assert_response 302
                  assert_equal 2, ActionMailer::Base.deliveries.size
                end
                def test_bulk_edit_status
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing status',
                                                   :issue => {:priority_id => '',
                                                              :assigned_to_id => '',
                                                              :status_id => '5'}
                  assert_response 302
                  issue = Issue.find(1)
                  assert issue.closed?
                end
                def test_bulk_edit_custom_field
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing custom field',
                                                   :issue => {:priority_id => '',
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => '777'}}
                  assert_response 302
                  issue = Issue.find(1)
                  journal = issue.journals.find(:first, :order => 'created_on DESC')
                  assert_equal '777', issue.custom_value_for(2).value
                  assert_equal 1, journal.details.size
                  assert_equal '125', journal.details.first.old_value
                  assert_equal '777', journal.details.first.value
                end
                def test_bulk_unassign
                  assert_not_nil Issue.find(2).assigned_to
                  @request.session[:user_id] = 2
                  # unassign issues
                post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
                  assert_response 302
                  # check that the issues were updated
                  assert_nil Issue.find(2).assigned_to
                end
                def test_post_bulk_edit_should_allow_fixed_version_to_be_set_to_a_subproject
                  @request.session[:user_id] = 2
                  post :bulk_edit, :ids => [1,2], :issue => {:fixed_version_id => 4}
                  assert_response :redirect
                  issues = Issue.find([1,2])
                  issues.each do |issue|
                    assert_equal 4, issue.fixed_version_id
                    assert_not_equal issue.project_id, issue.fixed_version.project_id
                  end
                end
                def test_post_bulk_edit_should_redirect_back_using_the_back_url_parameter
                  @request.session[:user_id] = 2
                  post :bulk_edit, :ids => [1,2], :back_url => '/issues'
                  assert_response :redirect
                  assert_redirected_to '/issues'
                end
                def test_post_bulk_edit_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                  @request.session[:user_id] = 2
                  post :bulk_edit, :ids => [1,2], :back_url => 'http://google.com'
                  assert_response :redirect
                  assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
                end
                def test_move_one_issue_to_another_project
                  @request.session[:user_id] = 2
                  post :move, :id => 1, :new_project_id => 2, :tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert_equal 2, Issue.find(1).project_id
                end
                def test_move_one_issue_to_another_project_should_follow_when_needed
                  @request.session[:user_id] = 2
                  post :move, :id => 1, :new_project_id => 2, :follow => '1'
                  assert_redirected_to '/issues/1'
                end
                def test_bulk_move_to_another_project
                  @request.session[:user_id] = 2
                  post :move, :ids => [1, 2], :new_project_id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  # Issues moved to project 2
                  assert_equal 2, Issue.find(1).project_id
                  assert_equal 2, Issue.find(2).project_id
                  # No tracker change
                  assert_equal 1, Issue.find(1).tracker_id
                  assert_equal 2, Issue.find(2).tracker_id
                end
                def test_bulk_move_to_another_tracker
                  @request.session[:user_id] = 2
                  post :move, :ids => [1, 2], :new_tracker_id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert_equal 2, Issue.find(1).tracker_id
                  assert_equal 2, Issue.find(2).tracker_id
                end
                def test_bulk_copy_to_another_project
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count', 2 do
                    assert_no_difference 'Project.find(1).issues.count' do
                      post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}
                    end
                  end
                  assert_redirected_to 'projects/ecookbook/issues'
                end
                context "#move via bulk copy" do
                  should "allow not changing the issue's attributes" do
                    @request.session[:user_id] = 2
                    issue_before_move = Issue.find(1)
                    assert_difference 'Issue.count', 1 do
                      assert_no_difference 'Project.find(1).issues.count' do
                        post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
                      end
                    end
                    issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2})
                    assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id
                    assert_equal issue_before_move.status_id, issue_after_move.status_id
                    assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id
                  end
                  should "allow changing the issue's attributes" do
                    @request.session[:user_id] = 2
                    assert_difference 'Issue.count', 2 do
                      assert_no_difference 'Project.find(1).issues.count' do
                        post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => 4, :status_id => 3, :start_date => '2009-12-01', :due_date => '2009-12-31'
                      end
                    end
                    copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
                    assert_equal 2, copied_issues.size
                    copied_issues.each do |issue|
                      assert_equal 2, issue.project_id, "Project is incorrect"
                      assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
                      assert_equal 3, issue.status_id, "Status is incorrect"
                      assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
                      assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
                    end
                  end
                end
                def test_copy_to_another_project_should_follow_when_needed
                  @request.session[:user_id] = 2
                  post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1'
                  issue = Issue.first(:order => 'id DESC')
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
                end
                def test_context_menu_one_issue
                  @request.session[:user_id] = 2
                  get :context_menu, :ids => [1]
                  assert_response :success
                  assert_template 'context_menu'
                  assert_tag :tag => 'a', :content => 'Edit',
                                          :attributes => { :href => '/issues/1/edit',
                                                           :class => 'icon-edit' }
                  assert_tag :tag => 'a', :content => 'Closed',
                                          :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'Immediate',
                                          :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;priority_id=8',
                                                           :class => '' }
                  # Versions
                  assert_tag :tag => 'a', :content => '2.0',
                                          :attributes => { :href => '/issues/bulk_edit?fixed_version_id=3&amp;ids%5B%5D=1',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'eCookbook Subproject 1 - 2.0',
                                          :attributes => { :href => '/issues/bulk_edit?fixed_version_id=4&amp;ids%5B%5D=1',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'Dave Lopper',
                                          :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'Duplicate',
                                          :attributes => { :href => '/projects/ecookbook/issues/1/copy',
                                                           :class => 'icon-duplicate' }
                  assert_tag :tag => 'a', :content => 'Copy',
                                          :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&amp;ids%5B%5D=1',
                                                           :class => 'icon-copy' }
                  assert_tag :tag => 'a', :content => 'Move',
                                          :attributes => { :href => '/issues/move?ids%5B%5D=1',
                                                           :class => 'icon-move' }
                  assert_tag :tag => 'a', :content => 'Delete',
                                          :attributes => { :href => '/issues/destroy?ids%5B%5D=1',
                                                           :class => 'icon-del' }
                end
                def test_context_menu_one_issue_by_anonymous
                  get :context_menu, :ids => [1]
                  assert_response :success
                  assert_template 'context_menu'
                  assert_tag :tag => 'a', :content => 'Delete',
                                          :attributes => { :href => '#',
                                                           :class => 'icon-del disabled' }
                end
                def test_context_menu_multiple_issues_of_same_project
                  @request.session[:user_id] = 2
                  get :context_menu, :ids => [1, 2]
                  assert_response :success
                  assert_template 'context_menu'
                  assert_tag :tag => 'a', :content => 'Edit',
                                          :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                           :class => 'icon-edit' }
                  assert_tag :tag => 'a', :content => 'Immediate',
                                          :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2&amp;priority_id=8',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'Dave Lopper',
                                          :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                                           :class => '' }
                  assert_tag :tag => 'a', :content => 'Copy',
                                          :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                                           :class => 'icon-copy' }
                  assert_tag :tag => 'a', :content => 'Move',
                                          :attributes => { :href => '/issues/move?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                           :class => 'icon-move' }
                  assert_tag :tag => 'a', :content => 'Delete',
                                          :attributes => { :href => '/issues/destroy?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                           :class => 'icon-del' }
                end
                def test_context_menu_multiple_issues_of_different_project
                  @request.session[:user_id] = 2
                  get :context_menu, :ids => [1, 2, 4]
                  assert_response :success
                  assert_template 'context_menu'
                  assert_tag :tag => 'a', :content => 'Delete',
                                          :attributes => { :href => '#',
                                                           :class => 'icon-del disabled' }
                end
                def test_destroy_issue_with_no_time_entries
                  assert_nil TimeEntry.find_by_issue_id(2)
                  @request.session[:user_id] = 2
                  post :destroy, :id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert_nil Issue.find_by_id(2)
                end
                def test_destroy_issues_with_time_entries
                  @request.session[:user_id] = 2
                  post :destroy, :ids => [1, 3]
                  assert_response :success
                  assert_template 'destroy'
                  assert_not_nil assigns(:hours)
                  assert Issue.find_by_id(1) && Issue.find_by_id(3)
                end
                def test_destroy_issues_and_destroy_time_entries
                  @request.session[:user_id] = 2
                  post :destroy, :ids => [1, 3], :todo => 'destroy'
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_nil TimeEntry.find_by_id([1, 2])
                end
                def test_destroy_issues_and_assign_time_entries_to_project
                  @request.session[:user_id] = 2
                  post :destroy, :ids => [1, 3], :todo => 'nullify'
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_nil TimeEntry.find(1).issue_id
                  assert_nil TimeEntry.find(2).issue_id
                end
                def test_destroy_issues_and_reassign_time_entries_to_another_issue
                  @request.session[:user_id] = 2
                  post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_equal 2, TimeEntry.find(1).issue_id
                  assert_equal 2, TimeEntry.find(2).issue_id
                end
                def test_default_search_scope
                  get :index
                  assert_tag :div, :attributes => {:id => 'quick-search'},
                                   :child => {:tag => 'form',
                                              :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages