##// END OF EJS Templates
jro_apps » redmine
RSS
Code cleanup....
Jean-Philippe Lang -
r11266:f544dd682b7d
parent child
Show More
Side by Side Unified
Context file:
r11266:f544dd682b7d Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1423 +1,1423
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21
22 22 belongs_to :project
23 23 belongs_to :tracker
24 24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30 30
31 31 has_many :journals, :as => :journalized, :dependent => :destroy
32 32 has_many :visible_journals,
33 33 :class_name => 'Journal',
34 34 :as => :journalized,
35 35 :conditions => Proc.new {
36 36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 37 },
38 38 :readonly => true
39 39
40 40 has_many :time_entries, :dependent => :delete_all
41 41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 48 acts_as_customizable
49 49 acts_as_watchable
50 50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 51 :include => [:project, :visible_journals],
52 52 # sort by id so that limited eager loading doesn't break with postgresql
53 53 :order_column => "#{table_name}.id"
54 54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57 57
58 58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 59 :author_key => :author_id
60 60
61 61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62 62
63 63 attr_reader :current_journal
64 64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65 65
66 66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67 67
68 68 validates_length_of :subject, :maximum => 255
69 69 validates_inclusion_of :done_ratio, :in => 0..100
70 70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 71 validates :start_date, :date => true
72 72 validates :due_date, :date => true
73 73 validate :validate_issue, :validate_required_fields
74 74
75 75 scope :visible, lambda {|*args|
76 76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 77 }
78 78
79 79 scope :open, lambda {|*args|
80 80 is_closed = args.size > 0 ? !args.first : false
81 81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 82 }
83 83
84 84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 85 scope :on_active_project, lambda {
86 86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 87 }
88 88 scope :fixed_version, lambda {|versions|
89 89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 91 }
92 92
93 93 before_create :default_assign
94 94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 97 # Should be after_create but would be called before previous after_save callbacks
98 98 after_save :after_create_from_copy
99 99 after_destroy :update_parent_attributes
100 100
101 101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 102 def self.visible_condition(user, options={})
103 103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 104 if user.logged?
105 105 case role.issues_visibility
106 106 when 'all'
107 107 nil
108 108 when 'default'
109 109 user_ids = [user.id] + user.groups.map(&:id)
110 110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 111 when 'own'
112 112 user_ids = [user.id] + user.groups.map(&:id)
113 113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 114 else
115 115 '1=0'
116 116 end
117 117 else
118 118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 119 end
120 120 end
121 121 end
122 122
123 123 # Returns true if usr or current user is allowed to view the issue
124 124 def visible?(usr=nil)
125 125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 126 if user.logged?
127 127 case role.issues_visibility
128 128 when 'all'
129 129 true
130 130 when 'default'
131 131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 132 when 'own'
133 133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 134 else
135 135 false
136 136 end
137 137 else
138 138 !self.is_private?
139 139 end
140 140 end
141 141 end
142 142
143 143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 144 def editable?(user=User.current)
145 145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 146 end
147 147
148 148 def initialize(attributes=nil, *args)
149 149 super
150 150 if new_record?
151 151 # set default values for new records only
152 152 self.status ||= IssueStatus.default
153 153 self.priority ||= IssuePriority.default
154 154 self.watcher_user_ids = []
155 155 end
156 156 end
157 157
158 158 def create_or_update
159 159 super
160 160 ensure
161 161 @status_was = nil
162 162 end
163 163 private :create_or_update
164 164
165 165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 166 # if the issue was already deleted or updated (non matching lock_version).
167 167 # This is a problem when bulk deleting issues or deleting a project
168 168 # (because an issue may already be deleted if its parent was deleted
169 169 # first).
170 170 # The issue is reloaded by the nested_set before being deleted so
171 171 # the lock_version condition should not be an issue but we handle it.
172 172 def destroy
173 173 super
174 174 rescue ActiveRecord::RecordNotFound
175 175 # Stale or already deleted
176 176 begin
177 177 reload
178 178 rescue ActiveRecord::RecordNotFound
179 179 # The issue was actually already deleted
180 180 @destroyed = true
181 181 return freeze
182 182 end
183 183 # The issue was stale, retry to destroy
184 184 super
185 185 end
186 186
187 187 def reload(*args)
188 188 @workflow_rule_by_attribute = nil
189 189 @assignable_versions = nil
190 190 @relations = nil
191 191 super
192 192 end
193 193
194 194 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
195 195 def available_custom_fields
196 196 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
197 197 end
198 198
199 199 # Copies attributes from another issue, arg can be an id or an Issue
200 200 def copy_from(arg, options={})
201 201 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
202 202 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
203 203 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
204 204 self.status = issue.status
205 205 self.author = User.current
206 206 unless options[:attachments] == false
207 207 self.attachments = issue.attachments.map do |attachement|
208 208 attachement.copy(:container => self)
209 209 end
210 210 end
211 211 @copied_from = issue
212 212 @copy_options = options
213 213 self
214 214 end
215 215
216 216 # Returns an unsaved copy of the issue
217 217 def copy(attributes=nil, copy_options={})
218 218 copy = self.class.new.copy_from(self, copy_options)
219 219 copy.attributes = attributes if attributes
220 220 copy
221 221 end
222 222
223 223 # Returns true if the issue is a copy
224 224 def copy?
225 225 @copied_from.present?
226 226 end
227 227
228 228 # Moves/copies an issue to a new project and tracker
229 229 # Returns the moved/copied issue on success, false on failure
230 230 def move_to_project(new_project, new_tracker=nil, options={})
231 231 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
232 232
233 233 if options[:copy]
234 234 issue = self.copy
235 235 else
236 236 issue = self
237 237 end
238 238
239 239 issue.init_journal(User.current, options[:notes])
240 240
241 241 # Preserve previous behaviour
242 242 # #move_to_project doesn't change tracker automatically
243 243 issue.send :project=, new_project, true
244 244 if new_tracker
245 245 issue.tracker = new_tracker
246 246 end
247 247 # Allow bulk setting of attributes on the issue
248 248 if options[:attributes]
249 249 issue.attributes = options[:attributes]
250 250 end
251 251
252 252 issue.save ? issue : false
253 253 end
254 254
255 255 def status_id=(sid)
256 256 self.status = nil
257 257 result = write_attribute(:status_id, sid)
258 258 @workflow_rule_by_attribute = nil
259 259 result
260 260 end
261 261
262 262 def priority_id=(pid)
263 263 self.priority = nil
264 264 write_attribute(:priority_id, pid)
265 265 end
266 266
267 267 def category_id=(cid)
268 268 self.category = nil
269 269 write_attribute(:category_id, cid)
270 270 end
271 271
272 272 def fixed_version_id=(vid)
273 273 self.fixed_version = nil
274 274 write_attribute(:fixed_version_id, vid)
275 275 end
276 276
277 277 def tracker_id=(tid)
278 278 self.tracker = nil
279 279 result = write_attribute(:tracker_id, tid)
280 280 @custom_field_values = nil
281 281 @workflow_rule_by_attribute = nil
282 282 result
283 283 end
284 284
285 285 def project_id=(project_id)
286 286 if project_id.to_s != self.project_id.to_s
287 287 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
288 288 end
289 289 end
290 290
291 291 def project=(project, keep_tracker=false)
292 292 project_was = self.project
293 293 write_attribute(:project_id, project ? project.id : nil)
294 294 association_instance_set('project', project)
295 295 if project_was && project && project_was != project
296 296 @assignable_versions = nil
297 297
298 298 unless keep_tracker || project.trackers.include?(tracker)
299 299 self.tracker = project.trackers.first
300 300 end
301 301 # Reassign to the category with same name if any
302 302 if category
303 303 self.category = project.issue_categories.find_by_name(category.name)
304 304 end
305 305 # Keep the fixed_version if it's still valid in the new_project
306 306 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
307 307 self.fixed_version = nil
308 308 end
309 309 # Clear the parent task if it's no longer valid
310 310 unless valid_parent_project?
311 311 self.parent_issue_id = nil
312 312 end
313 313 @custom_field_values = nil
314 314 end
315 315 end
316 316
317 317 def description=(arg)
318 318 if arg.is_a?(String)
319 319 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
320 320 end
321 321 write_attribute(:description, arg)
322 322 end
323 323
324 324 # Overrides assign_attributes so that project and tracker get assigned first
325 325 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
326 326 return if new_attributes.nil?
327 327 attrs = new_attributes.dup
328 328 attrs.stringify_keys!
329 329
330 330 %w(project project_id tracker tracker_id).each do |attr|
331 331 if attrs.has_key?(attr)
332 332 send "#{attr}=", attrs.delete(attr)
333 333 end
334 334 end
335 335 send :assign_attributes_without_project_and_tracker_first, attrs, *args
336 336 end
337 337 # Do not redefine alias chain on reload (see #4838)
338 338 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
339 339
340 340 def estimated_hours=(h)
341 341 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
342 342 end
343 343
344 344 safe_attributes 'project_id',
345 345 :if => lambda {|issue, user|
346 346 if issue.new_record?
347 347 issue.copy?
348 348 elsif user.allowed_to?(:move_issues, issue.project)
349 349 projects = Issue.allowed_target_projects_on_move(user)
350 350 projects.include?(issue.project) && projects.size > 1
351 351 end
352 352 }
353 353
354 354 safe_attributes 'tracker_id',
355 355 'status_id',
356 356 'category_id',
357 357 'assigned_to_id',
358 358 'priority_id',
359 359 'fixed_version_id',
360 360 'subject',
361 361 'description',
362 362 'start_date',
363 363 'due_date',
364 364 'done_ratio',
365 365 'estimated_hours',
366 366 'custom_field_values',
367 367 'custom_fields',
368 368 'lock_version',
369 369 'notes',
370 370 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
371 371
372 372 safe_attributes 'status_id',
373 373 'assigned_to_id',
374 374 'fixed_version_id',
375 375 'done_ratio',
376 376 'lock_version',
377 377 'notes',
378 378 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
379 379
380 380 safe_attributes 'notes',
381 381 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
382 382
383 383 safe_attributes 'private_notes',
384 384 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
385 385
386 386 safe_attributes 'watcher_user_ids',
387 387 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
388 388
389 389 safe_attributes 'is_private',
390 390 :if => lambda {|issue, user|
391 391 user.allowed_to?(:set_issues_private, issue.project) ||
392 392 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
393 393 }
394 394
395 395 safe_attributes 'parent_issue_id',
396 396 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
397 397 user.allowed_to?(:manage_subtasks, issue.project)}
398 398
399 399 def safe_attribute_names(user=nil)
400 400 names = super
401 401 names -= disabled_core_fields
402 402 names -= read_only_attribute_names(user)
403 403 names
404 404 end
405 405
406 406 # Safely sets attributes
407 407 # Should be called from controllers instead of #attributes=
408 408 # attr_accessible is too rough because we still want things like
409 409 # Issue.new(:project => foo) to work
410 410 def safe_attributes=(attrs, user=User.current)
411 411 return unless attrs.is_a?(Hash)
412 412
413 413 attrs = attrs.dup
414 414
415 415 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
416 416 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
417 417 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
418 418 self.project_id = p
419 419 end
420 420 end
421 421
422 422 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
423 423 self.tracker_id = t
424 424 end
425 425
426 426 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
427 427 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
428 428 self.status_id = s
429 429 end
430 430 end
431 431
432 432 attrs = delete_unsafe_attributes(attrs, user)
433 433 return if attrs.empty?
434 434
435 435 unless leaf?
436 436 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
437 437 end
438 438
439 439 if attrs['parent_issue_id'].present?
440 440 s = attrs['parent_issue_id'].to_s
441 441 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
442 442 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
443 443 end
444 444 end
445 445
446 446 if attrs['custom_field_values'].present?
447 447 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
448 448 end
449 449
450 450 if attrs['custom_fields'].present?
451 451 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
452 452 end
453 453
454 454 # mass-assignment security bypass
455 455 assign_attributes attrs, :without_protection => true
456 456 end
457 457
458 458 def disabled_core_fields
459 459 tracker ? tracker.disabled_core_fields : []
460 460 end
461 461
462 462 # Returns the custom_field_values that can be edited by the given user
463 463 def editable_custom_field_values(user=nil)
464 464 custom_field_values.reject do |value|
465 465 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
466 466 end
467 467 end
468 468
469 469 # Returns the names of attributes that are read-only for user or the current user
470 470 # For users with multiple roles, the read-only fields are the intersection of
471 471 # read-only fields of each role
472 472 # The result is an array of strings where sustom fields are represented with their ids
473 473 #
474 474 # Examples:
475 475 # issue.read_only_attribute_names # => ['due_date', '2']
476 476 # issue.read_only_attribute_names(user) # => []
477 477 def read_only_attribute_names(user=nil)
478 478 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
479 479 end
480 480
481 481 # Returns the names of required attributes for user or the current user
482 482 # For users with multiple roles, the required fields are the intersection of
483 483 # required fields of each role
484 484 # The result is an array of strings where sustom fields are represented with their ids
485 485 #
486 486 # Examples:
487 487 # issue.required_attribute_names # => ['due_date', '2']
488 488 # issue.required_attribute_names(user) # => []
489 489 def required_attribute_names(user=nil)
490 490 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
491 491 end
492 492
493 493 # Returns true if the attribute is required for user
494 494 def required_attribute?(name, user=nil)
495 495 required_attribute_names(user).include?(name.to_s)
496 496 end
497 497
498 498 # Returns a hash of the workflow rule by attribute for the given user
499 499 #
500 500 # Examples:
501 501 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
502 502 def workflow_rule_by_attribute(user=nil)
503 503 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
504 504
505 505 user_real = user || User.current
506 506 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
507 507 return {} if roles.empty?
508 508
509 509 result = {}
510 510 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
511 511 if workflow_permissions.any?
512 512 workflow_rules = workflow_permissions.inject({}) do |h, wp|
513 513 h[wp.field_name] ||= []
514 514 h[wp.field_name] << wp.rule
515 515 h
516 516 end
517 517 workflow_rules.each do |attr, rules|
518 518 next if rules.size < roles.size
519 519 uniq_rules = rules.uniq
520 520 if uniq_rules.size == 1
521 521 result[attr] = uniq_rules.first
522 522 else
523 523 result[attr] = 'required'
524 524 end
525 525 end
526 526 end
527 527 @workflow_rule_by_attribute = result if user.nil?
528 528 result
529 529 end
530 530 private :workflow_rule_by_attribute
531 531
532 532 def done_ratio
533 533 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
534 534 status.default_done_ratio
535 535 else
536 536 read_attribute(:done_ratio)
537 537 end
538 538 end
539 539
540 540 def self.use_status_for_done_ratio?
541 541 Setting.issue_done_ratio == 'issue_status'
542 542 end
543 543
544 544 def self.use_field_for_done_ratio?
545 545 Setting.issue_done_ratio == 'issue_field'
546 546 end
547 547
548 548 def validate_issue
549 549 if due_date && start_date && due_date < start_date
550 550 errors.add :due_date, :greater_than_start_date
551 551 end
552 552
553 553 if start_date && soonest_start && start_date < soonest_start
554 554 errors.add :start_date, :invalid
555 555 end
556 556
557 557 if fixed_version
558 558 if !assignable_versions.include?(fixed_version)
559 559 errors.add :fixed_version_id, :inclusion
560 560 elsif reopened? && fixed_version.closed?
561 561 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
562 562 end
563 563 end
564 564
565 565 # Checks that the issue can not be added/moved to a disabled tracker
566 566 if project && (tracker_id_changed? || project_id_changed?)
567 567 unless project.trackers.include?(tracker)
568 568 errors.add :tracker_id, :inclusion
569 569 end
570 570 end
571 571
572 572 # Checks parent issue assignment
573 573 if @invalid_parent_issue_id.present?
574 574 errors.add :parent_issue_id, :invalid
575 575 elsif @parent_issue
576 576 if !valid_parent_project?(@parent_issue)
577 577 errors.add :parent_issue_id, :invalid
578 578 elsif !new_record?
579 579 # moving an existing issue
580 580 if @parent_issue.root_id != root_id
581 581 # we can always move to another tree
582 582 elsif move_possible?(@parent_issue)
583 583 # move accepted inside tree
584 584 else
585 585 errors.add :parent_issue_id, :invalid
586 586 end
587 587 end
588 588 end
589 589 end
590 590
591 591 # Validates the issue against additional workflow requirements
592 592 def validate_required_fields
593 593 user = new_record? ? author : current_journal.try(:user)
594 594
595 595 required_attribute_names(user).each do |attribute|
596 596 if attribute =~ /^\d+$/
597 597 attribute = attribute.to_i
598 598 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
599 599 if v && v.value.blank?
600 600 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
601 601 end
602 602 else
603 603 if respond_to?(attribute) && send(attribute).blank?
604 604 errors.add attribute, :blank
605 605 end
606 606 end
607 607 end
608 608 end
609 609
610 610 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
611 611 # even if the user turns off the setting later
612 612 def update_done_ratio_from_issue_status
613 613 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
614 614 self.done_ratio = status.default_done_ratio
615 615 end
616 616 end
617 617
618 618 def init_journal(user, notes = "")
619 619 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
620 620 if new_record?
621 621 @current_journal.notify = false
622 622 else
623 623 @attributes_before_change = attributes.dup
624 624 @custom_values_before_change = {}
625 625 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
626 626 end
627 627 @current_journal
628 628 end
629 629
630 630 # Returns the id of the last journal or nil
631 631 def last_journal_id
632 632 if new_record?
633 633 nil
634 634 else
635 635 journals.maximum(:id)
636 636 end
637 637 end
638 638
639 639 # Returns a scope for journals that have an id greater than journal_id
640 640 def journals_after(journal_id)
641 641 scope = journals.reorder("#{Journal.table_name}.id ASC")
642 642 if journal_id.present?
643 643 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
644 644 end
645 645 scope
646 646 end
647 647
648 648 # Returns the initial status of the issue
649 649 # Returns nil for a new issue
650 650 def status_was
651 651 if status_id_was && status_id_was.to_i > 0
652 652 @status_was ||= IssueStatus.find_by_id(status_id_was)
653 653 end
654 654 end
655 655
656 656 # Return true if the issue is closed, otherwise false
657 657 def closed?
658 658 self.status.is_closed?
659 659 end
660 660
661 661 # Return true if the issue is being reopened
662 662 def reopened?
663 663 if !new_record? && status_id_changed?
664 664 status_was = IssueStatus.find_by_id(status_id_was)
665 665 status_new = IssueStatus.find_by_id(status_id)
666 666 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
667 667 return true
668 668 end
669 669 end
670 670 false
671 671 end
672 672
673 673 # Return true if the issue is being closed
674 674 def closing?
675 675 if !new_record? && status_id_changed?
676 676 if status_was && status && !status_was.is_closed? && status.is_closed?
677 677 return true
678 678 end
679 679 end
680 680 false
681 681 end
682 682
683 683 # Returns true if the issue is overdue
684 684 def overdue?
685 685 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
686 686 end
687 687
688 688 # Is the amount of work done less than it should for the due date
689 689 def behind_schedule?
690 690 return false if start_date.nil? || due_date.nil?
691 691 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
692 692 return done_date <= Date.today
693 693 end
694 694
695 695 # Does this issue have children?
696 696 def children?
697 697 !leaf?
698 698 end
699 699
700 700 # Users the issue can be assigned to
701 701 def assignable_users
702 702 users = project.assignable_users
703 703 users << author if author
704 704 users << assigned_to if assigned_to
705 705 users.uniq.sort
706 706 end
707 707
708 708 # Versions that the issue can be assigned to
709 709 def assignable_versions
710 710 return @assignable_versions if @assignable_versions
711 711
712 712 versions = project.shared_versions.open.all
713 713 if fixed_version
714 714 if fixed_version_id_changed?
715 715 # nothing to do
716 716 elsif project_id_changed?
717 717 if project.shared_versions.include?(fixed_version)
718 718 versions << fixed_version
719 719 end
720 720 else
721 721 versions << fixed_version
722 722 end
723 723 end
724 724 @assignable_versions = versions.uniq.sort
725 725 end
726 726
727 727 # Returns true if this issue is blocked by another issue that is still open
728 728 def blocked?
729 729 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
730 730 end
731 731
732 732 # Returns an array of statuses that user is able to apply
733 733 def new_statuses_allowed_to(user=User.current, include_default=false)
734 734 if new_record? && @copied_from
735 735 [IssueStatus.default, @copied_from.status].compact.uniq.sort
736 736 else
737 737 initial_status = nil
738 738 if new_record?
739 739 initial_status = IssueStatus.default
740 740 elsif status_id_was
741 741 initial_status = IssueStatus.find_by_id(status_id_was)
742 742 end
743 743 initial_status ||= status
744 744
745 745 statuses = initial_status.find_new_statuses_allowed_to(
746 746 user.admin ? Role.all : user.roles_for_project(project),
747 747 tracker,
748 748 author == user,
749 749 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
750 750 )
751 751 statuses << initial_status unless statuses.empty?
752 752 statuses << IssueStatus.default if include_default
753 753 statuses = statuses.compact.uniq.sort
754 754 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
755 755 end
756 756 end
757 757
758 758 def assigned_to_was
759 759 if assigned_to_id_changed? && assigned_to_id_was.present?
760 760 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
761 761 end
762 762 end
763 763
764 764 # Returns the users that should be notified
765 765 def notified_users
766 766 notified = []
767 767 # Author and assignee are always notified unless they have been
768 768 # locked or don't want to be notified
769 769 notified << author if author
770 770 if assigned_to
771 771 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
772 772 end
773 773 if assigned_to_was
774 774 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
775 775 end
776 776 notified = notified.select {|u| u.active? && u.notify_about?(self)}
777 777
778 778 notified += project.notified_users
779 779 notified.uniq!
780 780 # Remove users that can not view the issue
781 781 notified.reject! {|user| !visible?(user)}
782 782 notified
783 783 end
784 784
785 785 # Returns the email addresses that should be notified
786 786 def recipients
787 787 notified_users.collect(&:mail)
788 788 end
789 789
790 790 # Returns the number of hours spent on this issue
791 791 def spent_hours
792 792 @spent_hours ||= time_entries.sum(:hours) || 0
793 793 end
794 794
795 795 # Returns the total number of hours spent on this issue and its descendants
796 796 #
797 797 # Example:
798 798 # spent_hours => 0.0
799 799 # spent_hours => 50.2
800 800 def total_spent_hours
801 801 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
802 802 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
803 803 end
804 804
805 805 def relations
806 806 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
807 807 end
808 808
809 809 # Preloads relations for a collection of issues
810 810 def self.load_relations(issues)
811 811 if issues.any?
812 812 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
813 813 issues.each do |issue|
814 814 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
815 815 end
816 816 end
817 817 end
818 818
819 819 # Preloads visible spent time for a collection of issues
820 820 def self.load_visible_spent_hours(issues, user=User.current)
821 821 if issues.any?
822 822 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
823 823 issues.each do |issue|
824 824 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
825 825 end
826 826 end
827 827 end
828 828
829 829 # Preloads visible relations for a collection of issues
830 830 def self.load_visible_relations(issues, user=User.current)
831 831 if issues.any?
832 832 issue_ids = issues.map(&:id)
833 833 # Relations with issue_from in given issues and visible issue_to
834 834 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
835 835 # Relations with issue_to in given issues and visible issue_from
836 836 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
837 837
838 838 issues.each do |issue|
839 839 relations =
840 840 relations_from.select {|relation| relation.issue_from_id == issue.id} +
841 841 relations_to.select {|relation| relation.issue_to_id == issue.id}
842 842
843 843 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
844 844 end
845 845 end
846 846 end
847 847
848 848 # Finds an issue relation given its id.
849 849 def find_relation(relation_id)
850 850 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
851 851 end
852 852
853 853 def all_dependent_issues(except=[])
854 854 except << self
855 855 dependencies = []
856 856 relations_from.each do |relation|
857 857 if relation.issue_to && !except.include?(relation.issue_to)
858 858 dependencies << relation.issue_to
859 859 dependencies += relation.issue_to.all_dependent_issues(except)
860 860 end
861 861 end
862 862 dependencies
863 863 end
864 864
865 865 # Returns an array of issues that duplicate this one
866 866 def duplicates
867 867 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
868 868 end
869 869
870 870 # Returns the due date or the target due date if any
871 871 # Used on gantt chart
872 872 def due_before
873 873 due_date || (fixed_version ? fixed_version.effective_date : nil)
874 874 end
875 875
876 876 # Returns the time scheduled for this issue.
877 877 #
878 878 # Example:
879 879 # Start Date: 2/26/09, End Date: 3/04/09
880 880 # duration => 6
881 881 def duration
882 882 (start_date && due_date) ? due_date - start_date : 0
883 883 end
884 884
885 885 # Returns the duration in working days
886 886 def working_duration
887 887 (start_date && due_date) ? working_days(start_date, due_date) : 0
888 888 end
889 889
890 890 def soonest_start(reload=false)
891 891 @soonest_start = nil if reload
892 892 @soonest_start ||= (
893 893 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
894 894 ancestors.collect(&:soonest_start)
895 895 ).compact.max
896 896 end
897 897
898 898 # Sets start_date on the given date or the next working day
899 899 # and changes due_date to keep the same working duration.
900 900 def reschedule_on(date)
901 901 wd = working_duration
902 902 date = next_working_date(date)
903 903 self.start_date = date
904 904 self.due_date = add_working_days(date, wd)
905 905 end
906 906
907 907 # Reschedules the issue on the given date or the next working day and saves the record.
908 908 # If the issue is a parent task, this is done by rescheduling its subtasks.
909 909 def reschedule_on!(date)
910 910 return if date.nil?
911 911 if leaf?
912 912 if start_date.nil? || start_date != date
913 913 if start_date && start_date > date
914 914 # Issue can not be moved earlier than its soonest start date
915 915 date = [soonest_start(true), date].compact.max
916 916 end
917 917 reschedule_on(date)
918 918 begin
919 919 save
920 920 rescue ActiveRecord::StaleObjectError
921 921 reload
922 922 reschedule_on(date)
923 923 save
924 924 end
925 925 end
926 926 else
927 927 leaves.each do |leaf|
928 928 if leaf.start_date
929 929 # Only move subtask if it starts at the same date as the parent
930 930 # or if it starts before the given date
931 931 if start_date == leaf.start_date || date > leaf.start_date
932 932 leaf.reschedule_on!(date)
933 933 end
934 934 else
935 935 leaf.reschedule_on!(date)
936 936 end
937 937 end
938 938 end
939 939 end
940 940
941 941 def <=>(issue)
942 942 if issue.nil?
943 943 -1
944 944 elsif root_id != issue.root_id
945 945 (root_id || 0) <=> (issue.root_id || 0)
946 946 else
947 947 (lft || 0) <=> (issue.lft || 0)
948 948 end
949 949 end
950 950
951 951 def to_s
952 952 "#{tracker} ##{id}: #{subject}"
953 953 end
954 954
955 955 # Returns a string of css classes that apply to the issue
956 956 def css_classes
957 957 s = "issue status-#{status_id} #{priority.try(:css_classes)}"
958 958 s << ' closed' if closed?
959 959 s << ' overdue' if overdue?
960 960 s << ' child' if child?
961 961 s << ' parent' unless leaf?
962 962 s << ' private' if is_private?
963 963 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
964 964 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
965 965 s
966 966 end
967 967
968 968 # Saves an issue and a time_entry from the parameters
969 969 def save_issue_with_child_records(params, existing_time_entry=nil)
970 970 Issue.transaction do
971 971 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
972 972 @time_entry = existing_time_entry || TimeEntry.new
973 973 @time_entry.project = project
974 974 @time_entry.issue = self
975 975 @time_entry.user = User.current
976 976 @time_entry.spent_on = User.current.today
977 977 @time_entry.attributes = params[:time_entry]
978 978 self.time_entries << @time_entry
979 979 end
980 980
981 981 # TODO: Rename hook
982 982 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
983 983 if save
984 984 # TODO: Rename hook
985 985 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
986 986 else
987 987 raise ActiveRecord::Rollback
988 988 end
989 989 end
990 990 end
991 991
992 992 # Unassigns issues from +version+ if it's no longer shared with issue's project
993 993 def self.update_versions_from_sharing_change(version)
994 994 # Update issues assigned to the version
995 995 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
996 996 end
997 997
998 998 # Unassigns issues from versions that are no longer shared
999 999 # after +project+ was moved
1000 1000 def self.update_versions_from_hierarchy_change(project)
1001 1001 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1002 1002 # Update issues of the moved projects and issues assigned to a version of a moved project
1003 1003 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1004 1004 end
1005 1005
1006 1006 def parent_issue_id=(arg)
1007 1007 s = arg.to_s.strip.presence
1008 1008 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1009 1009 @parent_issue.id
1010 1010 else
1011 1011 @parent_issue = nil
1012 1012 @invalid_parent_issue_id = arg
1013 1013 end
1014 1014 end
1015 1015
1016 1016 def parent_issue_id
1017 1017 if @invalid_parent_issue_id
1018 1018 @invalid_parent_issue_id
1019 1019 elsif instance_variable_defined? :@parent_issue
1020 1020 @parent_issue.nil? ? nil : @parent_issue.id
1021 1021 else
1022 1022 parent_id
1023 1023 end
1024 1024 end
1025 1025
1026 1026 # Returns true if issue's project is a valid
1027 1027 # parent issue project
1028 1028 def valid_parent_project?(issue=parent)
1029 1029 return true if issue.nil? || issue.project_id == project_id
1030 1030
1031 1031 case Setting.cross_project_subtasks
1032 1032 when 'system'
1033 1033 true
1034 1034 when 'tree'
1035 1035 issue.project.root == project.root
1036 1036 when 'hierarchy'
1037 1037 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1038 1038 when 'descendants'
1039 1039 issue.project.is_or_is_ancestor_of?(project)
1040 1040 else
1041 1041 false
1042 1042 end
1043 1043 end
1044 1044
1045 1045 # Extracted from the ReportsController.
1046 1046 def self.by_tracker(project)
1047 1047 count_and_group_by(:project => project,
1048 1048 :field => 'tracker_id',
1049 1049 :joins => Tracker.table_name)
1050 1050 end
1051 1051
1052 1052 def self.by_version(project)
1053 1053 count_and_group_by(:project => project,
1054 1054 :field => 'fixed_version_id',
1055 1055 :joins => Version.table_name)
1056 1056 end
1057 1057
1058 1058 def self.by_priority(project)
1059 1059 count_and_group_by(:project => project,
1060 1060 :field => 'priority_id',
1061 1061 :joins => IssuePriority.table_name)
1062 1062 end
1063 1063
1064 1064 def self.by_category(project)
1065 1065 count_and_group_by(:project => project,
1066 1066 :field => 'category_id',
1067 1067 :joins => IssueCategory.table_name)
1068 1068 end
1069 1069
1070 1070 def self.by_assigned_to(project)
1071 1071 count_and_group_by(:project => project,
1072 1072 :field => 'assigned_to_id',
1073 1073 :joins => User.table_name)
1074 1074 end
1075 1075
1076 1076 def self.by_author(project)
1077 1077 count_and_group_by(:project => project,
1078 1078 :field => 'author_id',
1079 1079 :joins => User.table_name)
1080 1080 end
1081 1081
1082 1082 def self.by_subproject(project)
1083 1083 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1084 1084 s.is_closed as closed,
1085 1085 #{Issue.table_name}.project_id as project_id,
1086 1086 count(#{Issue.table_name}.id) as total
1087 1087 from
1088 1088 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1089 1089 where
1090 1090 #{Issue.table_name}.status_id=s.id
1091 1091 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1092 1092 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1093 1093 and #{Issue.table_name}.project_id <> #{project.id}
1094 1094 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1095 1095 end
1096 1096 # End ReportsController extraction
1097 1097
1098 1098 # Returns an array of projects that user can assign the issue to
1099 1099 def allowed_target_projects(user=User.current)
1100 1100 if new_record?
1101 1101 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1102 1102 else
1103 1103 self.class.allowed_target_projects_on_move(user)
1104 1104 end
1105 1105 end
1106 1106
1107 1107 # Returns an array of projects that user can move issues to
1108 1108 def self.allowed_target_projects_on_move(user=User.current)
1109 1109 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1110 1110 end
1111 1111
1112 1112 private
1113 1113
1114 1114 def after_project_change
1115 1115 # Update project_id on related time entries
1116 1116 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1117 1117
1118 1118 # Delete issue relations
1119 1119 unless Setting.cross_project_issue_relations?
1120 1120 relations_from.clear
1121 1121 relations_to.clear
1122 1122 end
1123 1123
1124 1124 # Move subtasks that were in the same project
1125 1125 children.each do |child|
1126 1126 next unless child.project_id == project_id_was
1127 1127 # Change project and keep project
1128 1128 child.send :project=, project, true
1129 1129 unless child.save
1130 1130 raise ActiveRecord::Rollback
1131 1131 end
1132 1132 end
1133 1133 end
1134 1134
1135 1135 # Callback for after the creation of an issue by copy
1136 1136 # * adds a "copied to" relation with the copied issue
1137 1137 # * copies subtasks from the copied issue
1138 1138 def after_create_from_copy
1139 1139 return unless copy? && !@after_create_from_copy_handled
1140 1140
1141 1141 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1142 1142 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1143 1143 unless relation.save
1144 1144 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1145 1145 end
1146 1146 end
1147 1147
1148 1148 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1149 1149 @copied_from.children.each do |child|
1150 1150 unless child.visible?
1151 1151 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1152 1152 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1153 1153 next
1154 1154 end
1155 1155 copy = Issue.new.copy_from(child, @copy_options)
1156 1156 copy.author = author
1157 1157 copy.project = project
1158 1158 copy.parent_issue_id = id
1159 1159 # Children subtasks are copied recursively
1160 1160 unless copy.save
1161 1161 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1162 1162 end
1163 1163 end
1164 1164 end
1165 1165 @after_create_from_copy_handled = true
1166 1166 end
1167 1167
1168 1168 def update_nested_set_attributes
1169 1169 if root_id.nil?
1170 1170 # issue was just created
1171 1171 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1172 1172 set_default_left_and_right
1173 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
1173 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1174 1174 if @parent_issue
1175 1175 move_to_child_of(@parent_issue)
1176 1176 end
1177 1177 elsif parent_issue_id != parent_id
1178 1178 former_parent_id = parent_id
1179 1179 # moving an existing issue
1180 1180 if @parent_issue && @parent_issue.root_id == root_id
1181 1181 # inside the same tree
1182 1182 move_to_child_of(@parent_issue)
1183 1183 else
1184 1184 # to another tree
1185 1185 unless root?
1186 1186 move_to_right_of(root)
1187 1187 end
1188 1188 old_root_id = root_id
1189 1189 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1190 1190 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1191 1191 offset = target_maxright + 1 - lft
1192 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
1192 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1193 1193 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1194 1194 self[left_column_name] = lft + offset
1195 1195 self[right_column_name] = rgt + offset
1196 1196 if @parent_issue
1197 1197 move_to_child_of(@parent_issue)
1198 1198 end
1199 1199 end
1200 1200 # delete invalid relations of all descendants
1201 1201 self_and_descendants.each do |issue|
1202 1202 issue.relations.each do |relation|
1203 1203 relation.destroy unless relation.valid?
1204 1204 end
1205 1205 end
1206 1206 # update former parent
1207 1207 recalculate_attributes_for(former_parent_id) if former_parent_id
1208 1208 end
1209 1209 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1210 1210 end
1211 1211
1212 1212 def update_parent_attributes
1213 1213 recalculate_attributes_for(parent_id) if parent_id
1214 1214 end
1215 1215
1216 1216 def recalculate_attributes_for(issue_id)
1217 1217 if issue_id && p = Issue.find_by_id(issue_id)
1218 1218 # priority = highest priority of children
1219 1219 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1220 1220 p.priority = IssuePriority.find_by_position(priority_position)
1221 1221 end
1222 1222
1223 1223 # start/due dates = lowest/highest dates of children
1224 1224 p.start_date = p.children.minimum(:start_date)
1225 1225 p.due_date = p.children.maximum(:due_date)
1226 1226 if p.start_date && p.due_date && p.due_date < p.start_date
1227 1227 p.start_date, p.due_date = p.due_date, p.start_date
1228 1228 end
1229 1229
1230 1230 # done ratio = weighted average ratio of leaves
1231 1231 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1232 1232 leaves_count = p.leaves.count
1233 1233 if leaves_count > 0
1234 1234 average = p.leaves.average(:estimated_hours).to_f
1235 1235 if average == 0
1236 1236 average = 1
1237 1237 end
1238 1238 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1239 1239 progress = done / (average * leaves_count)
1240 1240 p.done_ratio = progress.round
1241 1241 end
1242 1242 end
1243 1243
1244 1244 # estimate = sum of leaves estimates
1245 1245 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1246 1246 p.estimated_hours = nil if p.estimated_hours == 0.0
1247 1247
1248 1248 # ancestors will be recursively updated
1249 1249 p.save(:validate => false)
1250 1250 end
1251 1251 end
1252 1252
1253 1253 # Update issues so their versions are not pointing to a
1254 1254 # fixed_version that is not shared with the issue's project
1255 1255 def self.update_versions(conditions=nil)
1256 1256 # Only need to update issues with a fixed_version from
1257 1257 # a different project and that is not systemwide shared
1258 1258 Issue.scoped(:conditions => conditions).all(
1259 1259 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1260 1260 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1261 1261 " AND #{Version.table_name}.sharing <> 'system'",
1262 1262 :include => [:project, :fixed_version]
1263 1263 ).each do |issue|
1264 1264 next if issue.project.nil? || issue.fixed_version.nil?
1265 1265 unless issue.project.shared_versions.include?(issue.fixed_version)
1266 1266 issue.init_journal(User.current)
1267 1267 issue.fixed_version = nil
1268 1268 issue.save
1269 1269 end
1270 1270 end
1271 1271 end
1272 1272
1273 1273 # Callback on file attachment
1274 1274 def attachment_added(obj)
1275 1275 if @current_journal && !obj.new_record?
1276 1276 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1277 1277 end
1278 1278 end
1279 1279
1280 1280 # Callback on attachment deletion
1281 1281 def attachment_removed(obj)
1282 1282 if @current_journal && !obj.new_record?
1283 1283 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1284 1284 @current_journal.save
1285 1285 end
1286 1286 end
1287 1287
1288 1288 # Default assignment based on category
1289 1289 def default_assign
1290 1290 if assigned_to.nil? && category && category.assigned_to
1291 1291 self.assigned_to = category.assigned_to
1292 1292 end
1293 1293 end
1294 1294
1295 1295 # Updates start/due dates of following issues
1296 1296 def reschedule_following_issues
1297 1297 if start_date_changed? || due_date_changed?
1298 1298 relations_from.each do |relation|
1299 1299 relation.set_issue_to_dates
1300 1300 end
1301 1301 end
1302 1302 end
1303 1303
1304 1304 # Closes duplicates if the issue is being closed
1305 1305 def close_duplicates
1306 1306 if closing?
1307 1307 duplicates.each do |duplicate|
1308 1308 # Reload is need in case the duplicate was updated by a previous duplicate
1309 1309 duplicate.reload
1310 1310 # Don't re-close it if it's already closed
1311 1311 next if duplicate.closed?
1312 1312 # Same user and notes
1313 1313 if @current_journal
1314 1314 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1315 1315 end
1316 1316 duplicate.update_attribute :status, self.status
1317 1317 end
1318 1318 end
1319 1319 end
1320 1320
1321 1321 # Make sure updated_on is updated when adding a note and set updated_on now
1322 1322 # so we can set closed_on with the same value on closing
1323 1323 def force_updated_on_change
1324 1324 if @current_journal || changed?
1325 1325 self.updated_on = current_time_from_proper_timezone
1326 1326 if new_record?
1327 1327 self.created_on = updated_on
1328 1328 end
1329 1329 end
1330 1330 end
1331 1331
1332 1332 # Callback for setting closed_on when the issue is closed.
1333 1333 # The closed_on attribute stores the time of the last closing
1334 1334 # and is preserved when the issue is reopened.
1335 1335 def update_closed_on
1336 1336 if closing? || (new_record? && closed?)
1337 1337 self.closed_on = updated_on
1338 1338 end
1339 1339 end
1340 1340
1341 1341 # Saves the changes in a Journal
1342 1342 # Called after_save
1343 1343 def create_journal
1344 1344 if @current_journal
1345 1345 # attributes changes
1346 1346 if @attributes_before_change
1347 1347 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1348 1348 before = @attributes_before_change[c]
1349 1349 after = send(c)
1350 1350 next if before == after || (before.blank? && after.blank?)
1351 1351 @current_journal.details << JournalDetail.new(:property => 'attr',
1352 1352 :prop_key => c,
1353 1353 :old_value => before,
1354 1354 :value => after)
1355 1355 }
1356 1356 end
1357 1357 if @custom_values_before_change
1358 1358 # custom fields changes
1359 1359 custom_field_values.each {|c|
1360 1360 before = @custom_values_before_change[c.custom_field_id]
1361 1361 after = c.value
1362 1362 next if before == after || (before.blank? && after.blank?)
1363 1363
1364 1364 if before.is_a?(Array) || after.is_a?(Array)
1365 1365 before = [before] unless before.is_a?(Array)
1366 1366 after = [after] unless after.is_a?(Array)
1367 1367
1368 1368 # values removed
1369 1369 (before - after).reject(&:blank?).each do |value|
1370 1370 @current_journal.details << JournalDetail.new(:property => 'cf',
1371 1371 :prop_key => c.custom_field_id,
1372 1372 :old_value => value,
1373 1373 :value => nil)
1374 1374 end
1375 1375 # values added
1376 1376 (after - before).reject(&:blank?).each do |value|
1377 1377 @current_journal.details << JournalDetail.new(:property => 'cf',
1378 1378 :prop_key => c.custom_field_id,
1379 1379 :old_value => nil,
1380 1380 :value => value)
1381 1381 end
1382 1382 else
1383 1383 @current_journal.details << JournalDetail.new(:property => 'cf',
1384 1384 :prop_key => c.custom_field_id,
1385 1385 :old_value => before,
1386 1386 :value => after)
1387 1387 end
1388 1388 }
1389 1389 end
1390 1390 @current_journal.save
1391 1391 # reset current journal
1392 1392 init_journal @current_journal.user, @current_journal.notes
1393 1393 end
1394 1394 end
1395 1395
1396 1396 # Query generator for selecting groups of issue counts for a project
1397 1397 # based on specific criteria
1398 1398 #
1399 1399 # Options
1400 1400 # * project - Project to search in.
1401 1401 # * field - String. Issue field to key off of in the grouping.
1402 1402 # * joins - String. The table name to join against.
1403 1403 def self.count_and_group_by(options)
1404 1404 project = options.delete(:project)
1405 1405 select_field = options.delete(:field)
1406 1406 joins = options.delete(:joins)
1407 1407
1408 1408 where = "#{Issue.table_name}.#{select_field}=j.id"
1409 1409
1410 1410 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1411 1411 s.is_closed as closed,
1412 1412 j.id as #{select_field},
1413 1413 count(#{Issue.table_name}.id) as total
1414 1414 from
1415 1415 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1416 1416 where
1417 1417 #{Issue.table_name}.status_id=s.id
1418 1418 and #{where}
1419 1419 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1420 1420 and #{visible_condition(User.current, :project => project)}
1421 1421 group by s.id, s.is_closed, j.id")
1422 1422 end
1423 1423 end
General Comments 0
You need to be logged in to leave comments. Login now