jro_apps/redmine Commit - r15227:f416657d5635

When creating issues by receiving an email, watchers created via CC in the mail don't get an email notification (#23278)....

Jean-Philippe Lang -

r15227:f416657d5635

parent child

Context file:

r15227:f416657d5635

Collapse all files

lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb +4 0

              # ActsAsWatchable
              module Redmine
                module Acts
                  module Watchable
                    def self.included(base)
                      base.extend ClassMethods
                    end
                    module ClassMethods
                      def acts_as_watchable(options = {})
                        return if self.included_modules.include?(Redmine::Acts::Watchable::InstanceMethods)
                        class_eval do
                          has_many :watchers, :as => :watchable, :dependent => :delete_all
                          has_many :watcher_users, :through => :watchers, :source => :user, :validate => false
                          scope :watched_by, lambda { |user_id|
                            joins(:watchers).
                            where("#{Watcher.table_name}.user_id = ?", user_id)
                          }
                          attr_protected :watcher_ids, :watcher_user_ids
                        end
                        send :include, Redmine::Acts::Watchable::InstanceMethods
                        alias_method_chain :watcher_user_ids=, :uniq_ids
                      end
                    end
                    module InstanceMethods
                      def self.included(base)
                        base.extend ClassMethods
                      end
                      # Returns an array of users that are proposed as watchers
                      def addable_watcher_users
                        users = self.project.users.sort - self.watcher_users
                        if respond_to?(:visible?)
                          users.reject! {|user| !visible?(user)}
                        end
                        users
                      end
                      # Adds user as a watcher
                      def add_watcher(user)
+                       # Rails does not reset the has_many :through association
+                       watcher_users.reset
                        self.watchers << Watcher.new(:user => user)
                      end
                      # Removes user from the watchers list
                      def remove_watcher(user)
                        return nil unless user && user.is_a?(User)
+                       # Rails does not reset the has_many :through association
+                       watcher_users.reset
                        watchers.where(:user_id => user.id).delete_all
                      end
                      # Adds/removes watcher
                      def set_watcher(user, watching=true)
                        watching ? add_watcher(user) : remove_watcher(user)
                      end
                      # Overrides watcher_user_ids= to make user_ids uniq
                      def watcher_user_ids_with_uniq_ids=(user_ids)
                        if user_ids.is_a?(Array)
                          user_ids = user_ids.uniq
                        end
                        send :watcher_user_ids_without_uniq_ids=, user_ids
                      end
                      # Returns true if object is watched by +user+
                      def watched_by?(user)
                        !!(user && self.watcher_user_ids.detect {|uid| uid == user.id })
                      end
                      def notified_watchers
                        notified = watcher_users.active.to_a
                        notified.reject! {|user| user.mail.blank? || user.mail_notification == 'none'}
                        if respond_to?(:visible?)
                          notified.reject! {|user| !visible?(user)}
                        end
                        notified
                      end
                      # Returns an array of watchers' email addresses
                      def watcher_recipients
                        notified_watchers.collect(&:mail)
                      end
                      module ClassMethods; end
                    end
                  end
                end
              end

test/unit/mail_handler_test.rb +3 -2

              # encoding: utf-8
              #
              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class MailHandlerTest < ActiveSupport::TestCase
                fixtures :users, :projects, :enabled_modules, :roles,
                         :members, :member_roles, :users,
                         :email_addresses, :user_preferences,
                         :issues, :issue_statuses,
                         :workflows, :trackers, :projects_trackers,
                         :versions, :enumerations, :issue_categories,
                         :custom_fields, :custom_fields_trackers, :custom_fields_projects,
                         :boards, :messages
                FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
                def setup
                  ActionMailer::Base.deliveries.clear
                  Setting.notified_events = Redmine::Notifiable.all.collect(&:name)
                end
                def teardown
                  Setting.clear_cache
                end
                def test_add_issue_with_specific_overrides
                  issue = submit_email('ticket_on_given_project.eml',
                    :allow_override => ['status', 'start_date', 'due_date', 'assigned_to', 'fixed_version', 'estimated_hours', 'done_ratio']
                  )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal Project.find(2), issue.project
                  assert_equal issue.project.trackers.first, issue.tracker
                  assert_equal 'New ticket on a given project', issue.subject
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal IssueStatus.find_by_name('Resolved'), issue.status
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                  assert_equal '2010-01-01', issue.start_date.to_s
                  assert_equal '2010-12-31', issue.due_date.to_s
                  assert_equal User.find_by_login('jsmith'), issue.assigned_to
                  assert_equal Version.find_by_name('Alpha'), issue.fixed_version
                  assert_equal 2.5, issue.estimated_hours
                  assert_equal 30, issue.done_ratio
                  # keywords should be removed from the email body
                  assert !issue.description.match(/^Project:/i)
                  assert !issue.description.match(/^Status:/i)
                  assert !issue.description.match(/^Start Date:/i)
                end
                def test_add_issue_with_all_overrides
                  issue = submit_email('ticket_on_given_project.eml', :allow_override => 'all')
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal Project.find(2), issue.project
                  assert_equal issue.project.trackers.first, issue.tracker
                  assert_equal IssueStatus.find_by_name('Resolved'), issue.status
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                  assert_equal '2010-01-01', issue.start_date.to_s
                  assert_equal '2010-12-31', issue.due_date.to_s
                  assert_equal User.find_by_login('jsmith'), issue.assigned_to
                  assert_equal Version.find_by_name('Alpha'), issue.fixed_version
                  assert_equal 2.5, issue.estimated_hours
                  assert_equal 30, issue.done_ratio
                end
                def test_add_issue_without_overrides_should_ignore_attributes
                  WorkflowRule.delete_all
                  issue = submit_email('ticket_on_given_project.eml')
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal Project.find(2), issue.project
                  assert_equal 'New ticket on a given project', issue.subject
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal issue.project.trackers.first, issue.tracker
                  assert_equal 'New', issue.status.name
                  assert_not_equal '2010-01-01', issue.start_date.to_s
                  assert_nil issue.due_date
                  assert_nil issue.assigned_to
                  assert_nil issue.fixed_version
                  assert_nil issue.estimated_hours
                  assert_equal 0, issue.done_ratio
                end
                def test_add_issue_to_project_specified_by_subaddress
                  # This email has redmine+onlinestore@somenet.foo as 'To' header
                  issue = submit_email(
                            'ticket_on_project_given_by_to_header.eml',
                            :issue => {:tracker => 'Support request'},
                            :project_from_subaddress => 'redmine@somenet.foo'
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'onlinestore', issue.project.identifier
                  assert_equal 'Support request', issue.tracker.name
                end
                def test_add_issue_with_default_tracker
                  # This email contains: 'Project: onlinestore'
                  issue = submit_email(
                            'ticket_on_given_project.eml',
                            :issue => {:tracker => 'Support request'}
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'Support request', issue.tracker.name
                end
                def test_add_issue_with_default_version
                  # This email contains: 'Project: onlinestore'
                  issue = submit_email(
                            'ticket_on_given_project.eml',
                            :issue => {:fixed_version => 'Alpha'}
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  assert_equal 'Alpha', issue.reload.fixed_version.name
                end
                def test_add_issue_with_default_assigned_to
                  # This email contains: 'Project: onlinestore'
                  issue = submit_email(
                            'ticket_on_given_project.eml',
                            :issue => {:assigned_to => 'jsmith'}
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  assert_equal 'jsmith', issue.reload.assigned_to.login
                end
                def test_add_issue_with_status_override
                  # This email contains: 'Project: onlinestore' and 'Status: Resolved'
                  issue = submit_email('ticket_on_given_project.eml', :allow_override => ['status'])
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal Project.find(2), issue.project
                  assert_equal IssueStatus.find_by_name("Resolved"), issue.status
                end
                def test_add_issue_should_accept_is_private_attribute
                  issue = submit_email('ticket_on_given_project.eml', :issue => {:is_private => '1'})
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  assert_equal true, issue.reload.is_private
                end
                def test_add_issue_with_group_assignment
                  with_settings :issue_group_assignment => '1' do
                    issue = submit_email('ticket_on_given_project.eml', :allow_override => ['assigned_to']) do |email|
                      email.gsub!('Assigned to: John Smith', 'Assigned to: B Team')
                    end
                    assert issue.is_a?(Issue)
                    assert !issue.new_record?
                    issue.reload
                    assert_equal Group.find(11), issue.assigned_to
                  end
                end
                def test_add_issue_with_partial_attributes_override
                  issue = submit_email(
                            'ticket_with_attributes.eml',
                            :issue => {:priority => 'High'},
                            :allow_override => ['tracker']
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'New ticket on a given project', issue.subject
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal Project.find(2), issue.project
                  assert_equal 'Feature request', issue.tracker.to_s
                  assert_nil issue.category
                  assert_equal 'High', issue.priority.to_s
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                end
                def test_add_issue_with_spaces_between_attribute_and_separator
                  issue = submit_email(
                            'ticket_with_spaces_between_attribute_and_separator.eml',
                            :allow_override => 'tracker,category,priority'
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'New ticket on a given project', issue.subject
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal Project.find(2), issue.project
                  assert_equal 'Feature request', issue.tracker.to_s
                  assert_equal 'Stock management', issue.category.to_s
                  assert_equal 'Urgent', issue.priority.to_s
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                end
                def test_add_issue_with_attachment_to_specific_project
                  issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'Ticket created by email with attachment', issue.subject
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal Project.find(2), issue.project
                  assert_equal 'This is  a new ticket with attachments', issue.description
                  # Attachment properties
                  assert_equal 1, issue.attachments.size
                  assert_equal 'Paella.jpg', issue.attachments.first.filename
                  assert_equal 'image/jpeg', issue.attachments.first.content_type
                  assert_equal 10790, issue.attachments.first.filesize
                end
                def test_add_issue_with_custom_fields
                  issue = submit_email('ticket_with_custom_fields.eml',
                    :issue => {:project => 'onlinestore'}, :allow_override => ['database', 'Searchable_field']
                  )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'New ticket with custom field values', issue.subject
                  assert_equal 'PostgreSQL', issue.custom_field_value(1)
                  assert_equal 'Value for a custom field', issue.custom_field_value(2)
                  assert !issue.description.match(/^searchable field:/i)
                end
                def test_add_issue_with_version_custom_fields
                  field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true, :tracker_ids => [1,2,3])
                  issue = submit_email('ticket_with_custom_fields.eml',
                    :issue => {:project => 'ecookbook'}, :allow_override => ['affected version']
                  ) do |email|
                    email << "Affected version: 1.0\n"
                  end
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal '2', issue.custom_field_value(field)
                end
                def test_add_issue_should_match_assignee_on_display_name
                  user = User.generate!(:firstname => 'Foo Bar', :lastname => 'Foo Baz')
                  User.add_to_project(user, Project.find(2))
                  issue = submit_email('ticket_on_given_project.eml', :allow_override => ['assigned_to']) do |email|
                    email.sub!(/^Assigned to.*$/, 'Assigned to: Foo Bar Foo baz')
                  end
                  assert issue.is_a?(Issue)
                  assert_equal user, issue.assigned_to
                end
                def test_add_issue_should_set_default_start_date
                  with_settings :default_issue_start_date_to_creation_date => '1' do
                    issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
                    assert issue.is_a?(Issue)
                    assert_equal Date.today, issue.start_date
                  end
                end
                def test_add_issue_should_add_cc_as_watchers
+                 user = User.find_by_mail('dlopper@somenet.foo')
                  issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
-                 issue.reload
-                 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
+                 assert issue.watched_by?(user)
                  assert_equal 1, issue.watcher_user_ids.size
+                 assert_include user, issue.watcher_users.to_a
                end
                def test_add_issue_from_additional_email_address
                  user = User.find(2)
                  user.mail = 'mainaddress@somenet.foo'
                  user.save!
                  EmailAddress.create!(:user => user, :address => 'jsmith@somenet.foo')
                  issue = submit_email('ticket_on_given_project.eml')
                  assert issue
                  assert_equal user, issue.author
                end
                def test_add_issue_by_unknown_user
                  assert_no_difference 'User.count' do
                    assert_equal false,
                                 submit_email(
                                   'ticket_by_unknown_user.eml',
                                   :issue => {:project => 'ecookbook'}
                                 )
                  end
                end
                def test_add_issue_by_anonymous_user
                  Role.anonymous.add_permission!(:add_issues)
                  assert_no_difference 'User.count' do
                    issue = submit_email(
                              'ticket_by_unknown_user.eml',
                              :issue => {:project => 'ecookbook'},
                              :unknown_user => 'accept'
                            )
                    assert issue.is_a?(Issue)
                    assert issue.author.anonymous?
                  end
                end
                def test_add_issue_by_anonymous_user_with_no_from_address
                  Role.anonymous.add_permission!(:add_issues)
                  assert_no_difference 'User.count' do
                    issue = submit_email(
                              'ticket_by_empty_user.eml',
                              :issue => {:project => 'ecookbook'},
                              :unknown_user => 'accept'
                            )
                    assert issue.is_a?(Issue)
                    assert issue.author.anonymous?
                  end
                end
                def test_add_issue_by_anonymous_user_on_private_project
                  Role.anonymous.add_permission!(:add_issues)
                  assert_no_difference 'User.count' do
                    assert_no_difference 'Issue.count' do
                      assert_equal false,
                                   submit_email(
                                     'ticket_by_unknown_user.eml',
                                     :issue => {:project => 'onlinestore'},
                                     :unknown_user => 'accept'
                                   )
                    end
                  end
                end
                def test_add_issue_by_anonymous_user_on_private_project_without_permission_check
                  assert_no_difference 'User.count' do
                    assert_difference 'Issue.count' do
                      issue = submit_email(
                                'ticket_by_unknown_user.eml',
                                :issue => {:project => 'onlinestore'},
                                :no_permission_check => '1',
                                :unknown_user => 'accept'
                              )
                      assert issue.is_a?(Issue)
                      assert issue.author.anonymous?
                      assert !issue.project.is_public?
                    end
                  end
                end
                def test_add_issue_by_created_user
                  Setting.default_language = 'en'
                  assert_difference 'User.count' do
                    issue = submit_email(
                              'ticket_by_unknown_user.eml',
                              :issue => {:project => 'ecookbook'},
                              :unknown_user => 'create'
                            )
                    assert issue.is_a?(Issue)
                    assert issue.author.active?
                    assert_equal 'john.doe@somenet.foo', issue.author.mail
                    assert_equal 'John', issue.author.firstname
                    assert_equal 'Doe', issue.author.lastname
                    # account information
                    email = ActionMailer::Base.deliveries.first
                    assert_not_nil email
                    assert email.subject.include?('account activation')
                    login = mail_body(email).match(/\* Login: (.*)$/)[1].strip
                    password = mail_body(email).match(/\* Password: (.*)$/)[1].strip
                    assert_equal issue.author, User.try_to_login(login, password)
                  end
                end
                def test_add_issue_should_send_notification
                  issue = submit_email('ticket_on_given_project.eml', :allow_override => 'all')
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  mail = ActionMailer::Base.deliveries.last
                  assert_not_nil mail
                  assert mail.subject.include?("##{issue.id}")
                  assert mail.subject.include?('New ticket on a given project')
                end
                def test_created_user_should_be_added_to_groups
                  group1 = Group.generate!
                  group2 = Group.generate!
                  assert_difference 'User.count' do
                    submit_email(
                      'ticket_by_unknown_user.eml',
                      :issue => {:project => 'ecookbook'},
                      :unknown_user => 'create',
                      :default_group => "#{group1.name},#{group2.name}"
                    )
                  end
                  user = User.order('id DESC').first
                  assert_equal [group1, group2].sort, user.groups.sort
                end
                def test_created_user_should_not_receive_account_information_with_no_account_info_option
                  assert_difference 'User.count' do
                    submit_email(
                      'ticket_by_unknown_user.eml',
                      :issue => {:project => 'ecookbook'},
                      :unknown_user => 'create',
                      :no_account_notice => '1'
                    )
                  end
                  # only 1 email for the new issue notification
                  assert_equal 1, ActionMailer::Base.deliveries.size
                  email = ActionMailer::Base.deliveries.first
                  assert_include 'Ticket by unknown user', email.subject
                end
                def test_created_user_should_have_mail_notification_to_none_with_no_notification_option
                  assert_difference 'User.count' do
                    submit_email(
                      'ticket_by_unknown_user.eml',
                      :issue => {:project => 'ecookbook'},
                      :unknown_user => 'create',
                      :no_notification => '1'
                    )
                  end
                  user = User.order('id DESC').first
                  assert_equal 'none', user.mail_notification
                end
                def test_add_issue_without_from_header
                  Role.anonymous.add_permission!(:add_issues)
                  assert_equal false, submit_email('ticket_without_from_header.eml')
                end
                def test_add_issue_with_invalid_attributes
                  with_settings :default_issue_start_date_to_creation_date => '0' do
                    issue = submit_email(
                              'ticket_with_invalid_attributes.eml',
                              :allow_override => 'tracker,category,priority'
                            )
                    assert issue.is_a?(Issue)
                    assert !issue.new_record?
                    issue.reload
                    assert_nil issue.assigned_to
                    assert_nil issue.start_date
                    assert_nil issue.due_date
                    assert_equal 0, issue.done_ratio
                    assert_equal 'Normal', issue.priority.to_s
                    assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                  end
                end
                def test_add_issue_with_invalid_project_should_be_assigned_to_default_project
                  issue = submit_email('ticket_on_given_project.eml', :issue => {:project => 'ecookbook'}, :allow_override => 'project') do |email|
                    email.gsub!(/^Project:.+$/, 'Project: invalid')
                  end
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  assert_equal 'ecookbook', issue.project.identifier
                end
                def test_add_issue_with_localized_attributes
                  User.find_by_mail('jsmith@somenet.foo').update_attribute 'language', 'fr'
                  issue = submit_email(
                            'ticket_with_localized_attributes.eml',
                            :allow_override => 'tracker,category,priority'
                          )
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                  assert_equal 'New ticket on a given project', issue.subject
                  assert_equal User.find_by_login('jsmith'), issue.author
                  assert_equal Project.find(2), issue.project
                  assert_equal 'Feature request', issue.tracker.to_s
                  assert_equal 'Stock management', issue.category.to_s
                  assert_equal 'Urgent', issue.priority.to_s
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                end
                def test_add_issue_with_japanese_keywords
                  ja_dev = "\xe9\x96\x8b\xe7\x99\xba".force_encoding('UTF-8')
                  tracker = Tracker.generate!(:name => ja_dev)
                  Project.find(1).trackers << tracker
                  issue = submit_email(
                            'japanese_keywords_iso_2022_jp.eml',
                            :issue => {:project => 'ecookbook'},
                            :allow_override => 'tracker'
                          )
                  assert_kind_of Issue, issue
                  assert_equal tracker, issue.tracker
                end
                def test_add_issue_from_apple_mail
                  issue = submit_email(
                            'apple_mail_with_attachment.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  attachment = issue.attachments.first
                  assert_equal 'paella.jpg', attachment.filename
                  assert_equal 10790, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 10790, File.size(attachment.diskfile)
                  assert_equal 'caaf384198bcbc9563ab5c058acd73cd', attachment.digest
                end
                def test_thunderbird_with_attachment_ja
                  issue = submit_email(
                            'thunderbird_with_attachment_ja.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt".force_encoding('UTF-8')
                  attachment = issue.attachments.first
                  assert_equal ja, attachment.filename
                  assert_equal 5, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 5, File.size(attachment.diskfile)
                  assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
                end
                def test_gmail_with_attachment_ja
                  issue = submit_email(
                            'gmail_with_attachment_ja.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt".force_encoding('UTF-8')
                  attachment = issue.attachments.first
                  assert_equal ja, attachment.filename
                  assert_equal 5, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 5, File.size(attachment.diskfile)
                  assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
                end
                def test_thunderbird_with_attachment_latin1
                  issue = submit_email(
                            'thunderbird_with_attachment_iso-8859-1.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  u = "".force_encoding('UTF-8')
                  u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc".force_encoding('UTF-8')
 .times { u << u1 }
                  attachment = issue.attachments.first
                  assert_equal "#{u}.png", attachment.filename
                  assert_equal 130, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 130, File.size(attachment.diskfile)
                  assert_equal '4d80e667ac37dddfe05502530f152abb', attachment.digest
                end
                def test_gmail_with_attachment_latin1
                  issue = submit_email(
                            'gmail_with_attachment_iso-8859-1.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  u = "".force_encoding('UTF-8')
                  u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc".force_encoding('UTF-8')
 .times { u << u1 }
                  attachment = issue.attachments.first
                  assert_equal "#{u}.txt", attachment.filename
                  assert_equal 5, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 5, File.size(attachment.diskfile)
                  assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
                end
                def test_mail_with_attachment_latin2
                  issue = submit_email(
                            'ticket_with_text_attachment_iso-8859-2.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.attachments.size
                  attachment = issue.attachments.first
                  assert_equal 'latin2.txt', attachment.filename
                  assert_equal 19, attachment.filesize
                  assert File.exist?(attachment.diskfile)
                  assert_equal 19, File.size(attachment.diskfile)
                  content = "p\xF8\xEDli\xB9 \xBEluou\xE8k\xFD k\xF9n".force_encoding('CP852')
                  assert_equal content, File.read(attachment.diskfile).force_encoding('CP852')
                end
                def test_multiple_inline_text_parts_should_be_appended_to_issue_description
                  issue = submit_email('multiple_text_parts.eml', :issue => {:project => 'ecookbook'})
                  assert_include 'first', issue.description
                  assert_include 'second', issue.description
                  assert_include 'third', issue.description
                end
                def test_attachment_text_part_should_be_added_as_issue_attachment
                  issue = submit_email('multiple_text_parts.eml', :issue => {:project => 'ecookbook'})
                  assert_not_include 'Plain text attachment', issue.description
                  attachment = issue.attachments.detect {|a| a.filename == 'textfile.txt'}
                  assert_not_nil attachment
                  assert_include 'Plain text attachment', File.read(attachment.diskfile)
                end
                def test_add_issue_with_iso_8859_1_subject
                  issue = submit_email(
                            'subject_as_iso-8859-1.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  str = "Testmail from Webmail: \xc3\xa4 \xc3\xb6 \xc3\xbc...".force_encoding('UTF-8')
                  assert_kind_of Issue, issue
                  assert_equal str, issue.subject
                end
                def test_quoted_printable_utf8
                  issue = submit_email(
                            'quoted_printable_utf8.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  str = "Freundliche Gr\xc3\xbcsse".force_encoding('UTF-8')
                  assert_equal str, issue.description
                end
                def test_gmail_iso8859_2
                  issue = submit_email(
                            'gmail-iso8859-2.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  str = "Na \xc5\xa1triku se su\xc5\xa1i \xc5\xa1osi\xc4\x87.".force_encoding('UTF-8')
                  assert issue.description.include?(str)
                end
                def test_add_issue_with_japanese_subject
                  issue = submit_email(
                            'subject_japanese_1.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88".force_encoding('UTF-8')
                  assert_equal ja, issue.subject
                end
                def test_add_issue_with_korean_body
                  # Make sure mail bodies with a charset unknown to Ruby
                  # but known to the Mail gem 2.5.4 are handled correctly
                  kr = "\xEA\xB3\xA0\xEB\xA7\x99\xEC\x8A\xB5\xEB\x8B\x88\xEB\x8B\xA4.".force_encoding('UTF-8')
                  issue = submit_email(
                          'body_ks_c_5601-1987.eml',
                          :issue => {:project => 'ecookbook'}
                        )
                  assert_kind_of Issue, issue
                  assert_equal kr, issue.description
                end
                def test_add_issue_with_no_subject_header
                  issue = submit_email(
                            'no_subject_header.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  assert_equal '(no subject)', issue.subject
                end
                def test_add_issue_with_mixed_japanese_subject
                  issue = submit_email(
                            'subject_japanese_2.eml',
                            :issue => {:project => 'ecookbook'}
                          )
                  assert_kind_of Issue, issue
                  ja = "Re: \xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88".force_encoding('UTF-8')
                  assert_equal ja, issue.subject
                end
                def test_should_ignore_emails_from_locked_users
                  User.find(2).lock!
                  MailHandler.any_instance.expects(:dispatch).never
                  assert_no_difference 'Issue.count' do
                    assert_equal false, submit_email('ticket_on_given_project.eml')
                  end
                end
                def test_should_ignore_emails_from_emission_address
                  Role.anonymous.add_permission!(:add_issues)
                  assert_no_difference 'User.count' do
                    assert_equal false,
                                 submit_email(
                                   'ticket_from_emission_address.eml',
                                   :issue => {:project => 'ecookbook'},
                                   :unknown_user => 'create'
                                 )
                  end
                end
                def test_should_ignore_auto_replied_emails
                  MailHandler.any_instance.expects(:dispatch).never
                  [
                    "Auto-Submitted: auto-replied",
                    "Auto-Submitted: Auto-Replied",
                    "Auto-Submitted: auto-generated",
                    'X-Autoreply: yes'
                  ].each do |header|
                    raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
                    raw = header + "\n" + raw
                    assert_no_difference 'Issue.count' do
                      assert_equal false, MailHandler.receive(raw), "email with #{header} header was not ignored"
                    end
                  end
                end
                test "should not ignore Auto-Submitted headers not defined in RFC3834" do
                  [
                    "Auto-Submitted: auto-forwarded"
                  ].each do |header|
                    raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
                    raw = header + "\n" + raw
                    assert_difference 'Issue.count', 1 do
                      assert_not_nil MailHandler.receive(raw), "email with #{header} header was ignored"
                    end
                  end
                end
                def test_add_issue_should_send_email_notification
                  Setting.notified_events = ['issue_added']
                  # This email contains: 'Project: onlinestore'
                  issue = submit_email('ticket_on_given_project.eml')
                  assert issue.is_a?(Issue)
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_update_issue
                  journal = submit_email('ticket_reply.eml')
                  assert journal.is_a?(Journal)
                  assert_equal User.find_by_login('jsmith'), journal.user
                  assert_equal Issue.find(2), journal.journalized
                  assert_match /This is reply/, journal.notes
                  assert_equal false, journal.private_notes
                  assert_equal 'Feature request', journal.issue.tracker.name
                end
                def test_update_issue_should_accept_issue_id_after_space_inside_brackets
                  journal = submit_email('ticket_reply_with_status.eml') do |email|
                    assert email.sub!(/^Subject:.*$/, "Subject: Re: [Feature request #2] Add ingredients categories")
                  end
                  assert journal.is_a?(Journal)
                  assert_equal Issue.find(2), journal.journalized
                end
                def test_update_issue_should_accept_issue_id_inside_brackets
                  journal = submit_email('ticket_reply_with_status.eml') do |email|
                    assert email.sub!(/^Subject:.*$/, "Subject: Re: [#2] Add ingredients categories")
                  end
                  assert journal.is_a?(Journal)
                  assert_equal Issue.find(2), journal.journalized
                end
                def test_update_issue_should_ignore_bogus_issue_ids_in_subject
                  journal = submit_email('ticket_reply_with_status.eml') do |email|
                    assert email.sub!(/^Subject:.*$/, "Subject: Re: [12345#1][bogus#1][Feature request #2] Add ingredients categories")
                  end
                  assert journal.is_a?(Journal)
                  assert_equal Issue.find(2), journal.journalized
                end
                def test_update_issue_with_attribute_changes
                  journal = submit_email('ticket_reply_with_status.eml', :allow_override => ['status','assigned_to','start_date','due_date', 'float field'])
                  assert journal.is_a?(Journal)
                  issue = Issue.find(journal.issue.id)
                  assert_equal User.find_by_login('jsmith'), journal.user
                  assert_equal Issue.find(2), journal.journalized
                  assert_match /This is reply/, journal.notes
                  assert_equal 'Feature request', journal.issue.tracker.name
                  assert_equal IssueStatus.find_by_name("Resolved"), issue.status
                  assert_equal '2010-01-01', issue.start_date.to_s
                  assert_equal '2010-12-31', issue.due_date.to_s
                  assert_equal User.find_by_login('jsmith'), issue.assigned_to
                  assert_equal "52.6", issue.custom_value_for(CustomField.find_by_name('Float field')).value
                  # keywords should be removed from the email body
                  assert !journal.notes.match(/^Status:/i)
                  assert !journal.notes.match(/^Start Date:/i)
                end
                def test_update_issue_with_attachment
                  assert_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count' do
                      assert_difference 'Attachment.count' do
                        assert_no_difference 'Issue.count' do
                          journal = submit_email('ticket_with_attachment.eml') do |raw|
                            raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
                          end
                        end
                      end
                    end
                  end
                  journal = Journal.order('id DESC').first
                  assert_equal Issue.find(2), journal.journalized
                  assert_equal 1, journal.details.size
                  detail = journal.details.first
                  assert_equal 'attachment', detail.property
                  assert_equal 'Paella.jpg', detail.value
                end
                def test_update_issue_should_send_email_notification
                  journal = submit_email('ticket_reply.eml')
                  assert journal.is_a?(Journal)
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_update_issue_should_not_set_defaults
                  journal = submit_email(
                              'ticket_reply.eml',
                              :issue => {:tracker => 'Support request', :priority => 'High'}
                            )
                  assert journal.is_a?(Journal)
                  assert_match /This is reply/, journal.notes
                  assert_equal 'Feature request', journal.issue.tracker.name
                  assert_equal 'Normal', journal.issue.priority.name
                end
                def test_update_issue_should_add_cc_as_watchers
                  Watcher.delete_all
                  issue = Issue.find(2)
                  assert_difference 'Watcher.count' do
                    assert submit_email('issue_update_with_cc.eml')
                  end
                  issue.reload
                  assert_equal 1, issue.watcher_user_ids.size
                  assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
                end
                def test_update_issue_should_not_add_cc_as_watchers_if_already_watching
                  Watcher.delete_all
                  issue = Issue.find(2)
                  Watcher.create!(:watchable => issue, :user => User.find_by_mail('dlopper@somenet.foo'))
                  assert_no_difference 'Watcher.count' do
                    assert submit_email('issue_update_with_cc.eml')
                  end
                end
                def test_replying_to_a_private_note_should_add_reply_as_private
                  private_journal = Journal.create!(:notes => 'Private notes', :journalized => Issue.find(1), :private_notes => true, :user_id => 2)
                  assert_difference 'Journal.count' do
                    journal = submit_email('ticket_reply.eml') do |email|
                      email.sub! %r{^In-Reply-To:.*$}, "In-Reply-To: <redmine.journal-#{private_journal.id}.20060719210421@osiris>"
                    end
                    assert_kind_of Journal, journal
                    assert_match /This is reply/, journal.notes
                    assert_equal true, journal.private_notes
                  end
                end
                def test_reply_to_a_message
                  m = submit_email('message_reply.eml')
                  assert m.is_a?(Message)
                  assert !m.new_record?
                  m.reload
                  assert_equal 'Reply via email', m.subject
                  # The email replies to message #2 which is part of the thread of message #1
                  assert_equal Message.find(1), m.parent
                end
                def test_reply_to_a_message_by_subject
                  m = submit_email('message_reply_by_subject.eml')
                  assert m.is_a?(Message)
                  assert !m.new_record?
                  m.reload
                  assert_equal 'Reply to the first post', m.subject
                  assert_equal Message.find(1), m.parent
                end
                def test_should_convert_tags_of_html_only_emails
                  with_settings :text_formatting => 'textile' do
                    issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
                    assert issue.is_a?(Issue)
                    assert !issue.new_record?
                    issue.reload
                    assert_equal 'HTML email', issue.subject
                    assert_equal "This is a *html-only* email.\r\n\r\nh1. With a title\r\n\r\nand a paragraph.", issue.description
                  end
                end
                def test_should_handle_outlook_web_access_2010_html_only
                  issue = submit_email('outlook_web_access_2010_html_only.eml', :issue => {:project => 'ecookbook'})
                  assert issue.is_a?(Issue)
                  issue.reload
                  assert_equal 'Upgrade Redmine to 3.0.x', issue.subject
                  assert_equal "A mess.\r\n\r\n--Geoff Maciolek\r\nMYCOMPANYNAME, LLC", issue.description
                end
                def test_should_handle_outlook_2010_html_only
                  issue = submit_email('outlook_2010_html_only.eml', :issue => {:project => 'ecookbook'})
                  assert issue.is_a?(Issue)
                  issue.reload
                  assert_equal 'Test email', issue.subject
                  assert_equal "Simple, unadorned test email generated by Outlook 2010. It is in HTML format, but" +
                    " no special formatting has been chosen. I’m going to save this as a draft and then manually" +
                    " drop it into the Inbox for scraping by Redmine 3.0.2.", issue.description
                end
                test "truncate emails with no setting should add the entire email into the issue" do
                  with_settings :mail_handler_body_delimiters => '' do
                    issue = submit_email('ticket_on_given_project.eml')
                    assert_issue_created(issue)
                    assert issue.description.include?('---')
                    assert issue.description.include?('This paragraph is after the delimiter')
                  end
                end
                test "truncate emails with a single string should truncate the email at the delimiter for the issue" do
                  with_settings :mail_handler_body_delimiters => '---' do
                    issue = submit_email('ticket_on_given_project.eml')
                    assert_issue_created(issue)
                    assert issue.description.include?('This paragraph is before delimiters')
                    assert issue.description.include?('--- This line starts with a delimiter')
                    assert !issue.description.match(/^---$/)
                    assert !issue.description.include?('This paragraph is after the delimiter')
                  end
                end
                test "truncate emails with a single quoted reply should truncate the email at the delimiter with the quoted reply symbols (>)" do
                  with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
                    journal = submit_email('issue_update_with_quoted_reply_above.eml')
                    assert journal.is_a?(Journal)
                    assert journal.notes.include?('An update to the issue by the sender.')
                    assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
                    assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
                  end
                end
                test "truncate emails with multiple quoted replies should truncate the email at the delimiter with the quoted reply symbols (>)" do
                  with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
                    journal = submit_email('issue_update_with_multiple_quoted_reply_above.eml')
                    assert journal.is_a?(Journal)
                    assert journal.notes.include?('An update to the issue by the sender.')
                    assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
                    assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
                  end
                end
                test "truncate emails with multiple strings should truncate the email at the first delimiter found (BREAK)" do
                  with_settings :mail_handler_body_delimiters => "---\nBREAK" do
                    issue = submit_email('ticket_on_given_project.eml')
                    assert_issue_created(issue)
                    assert issue.description.include?('This paragraph is before delimiters')
                    assert !issue.description.include?('BREAK')
                    assert !issue.description.include?('This paragraph is between delimiters')
                    assert !issue.description.match(/^---$/)
                    assert !issue.description.include?('This paragraph is after the delimiter')
                  end
                end
                def test_attachments_that_match_mail_handler_excluded_filenames_should_be_ignored
                  with_settings :mail_handler_excluded_filenames => '*.vcf, *.jpg' do
                    issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
                    assert issue.is_a?(Issue)
                    assert !issue.new_record?
                    assert_equal 0, issue.reload.attachments.size
                  end
                end
                def test_attachments_that_do_not_match_mail_handler_excluded_filenames_should_be_attached
                  with_settings :mail_handler_excluded_filenames => '*.vcf, *.gif' do
                    issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
                    assert issue.is_a?(Issue)
                    assert !issue.new_record?
                    assert_equal 1, issue.reload.attachments.size
                  end
                end
                def test_email_with_long_subject_line
                  issue = submit_email('ticket_with_long_subject.eml')
                  assert issue.is_a?(Issue)
                  assert_equal issue.subject, 'New ticket on a given project with a very long subject line which exceeds 255 chars and should not be ignored but chopped off. And if the subject line is still not long enough, we just add more text. And more text. Wow, this is really annoying. Especially, if you have nothing to say...'[0,255]
                end
                def test_first_keyword_should_be_matched
                  issue = submit_email('ticket_with_duplicate_keyword.eml', :allow_override => 'priority')
                  assert issue.is_a?(Issue)
                  assert_equal 'High', issue.priority.name
                end
                def test_keyword_after_delimiter_should_be_ignored
                  with_settings :mail_handler_body_delimiters => "== DELIMITER ==" do
                    issue = submit_email('ticket_with_keyword_after_delimiter.eml', :allow_override => 'priority')
                    assert issue.is_a?(Issue)
                    assert_equal 'Normal', issue.priority.name
                  end
                end
                def test_new_user_from_attributes_should_return_valid_user
                  to_test = {
                    # [address, name] => [login, firstname, lastname]
                    ['jsmith@example.net', nil] => ['jsmith@example.net', 'jsmith', '-'],
                    ['jsmith@example.net', 'John'] => ['jsmith@example.net', 'John', '-'],
                    ['jsmith@example.net', 'John Smith'] => ['jsmith@example.net', 'John', 'Smith'],
                    ['jsmith@example.net', 'John Paul Smith'] => ['jsmith@example.net', 'John', 'Paul Smith'],
                    ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsTheMaximumLength Smith'] => ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsT', 'Smith'],
                    ['jsmith@example.net', 'John AVeryLongLastnameThatExceedsTheMaximumLength'] => ['jsmith@example.net', 'John', 'AVeryLongLastnameThatExceedsTh']
                  }
                  to_test.each do |attrs, expected|
                    user = MailHandler.new_user_from_attributes(attrs.first, attrs.last)
                    assert user.valid?, user.errors.full_messages.to_s
                    assert_equal attrs.first, user.mail
                    assert_equal expected[0], user.login
                    assert_equal expected[1], user.firstname
                    assert_equal expected[2], user.lastname
                    assert_equal 'only_my_events', user.mail_notification
                  end
                end
                def test_new_user_from_attributes_should_use_default_login_if_invalid
                  user = MailHandler.new_user_from_attributes('foo+bar@example.net')
                  assert user.valid?
                  assert user.login =~ /^user[a-f0-9]+$/
                  assert_equal 'foo+bar@example.net', user.mail
                end
                def test_new_user_with_utf8_encoded_fullname_should_be_decoded
                  assert_difference 'User.count' do
                    issue = submit_email(
                              'fullname_of_sender_as_utf8_encoded.eml',
                              :issue => {:project => 'ecookbook'},
                              :unknown_user => 'create'
                            )
                  end
                  user = User.order('id DESC').first
                  assert_equal "foo@example.org", user.mail
                  str1 = "\xc3\x84\xc3\xa4".force_encoding('UTF-8')
                  str2 = "\xc3\x96\xc3\xb6".force_encoding('UTF-8')
                  assert_equal str1, user.firstname
                  assert_equal str2, user.lastname
                end
                def test_extract_options_from_env_should_return_options
                  options = MailHandler.extract_options_from_env({
                    'tracker' => 'defect',
                    'project' => 'foo',
                    'unknown_user' => 'create'
                  })
                  assert_equal({
                    :issue => {:tracker => 'defect', :project => 'foo'},
                    :unknown_user => 'create'
                  }, options)
                end
                def test_safe_receive_should_rescue_exceptions_and_return_false
                  MailHandler.stubs(:receive).raises(Exception.new "Something went wrong")
                  assert_equal false, MailHandler.safe_receive
                end
                private
                def submit_email(filename, options={})
                  raw = IO.read(File.join(FIXTURES_PATH, filename))
                  yield raw if block_given?
                  MailHandler.receive(raw, options)
                end
                def assert_issue_created(issue)
                  assert issue.is_a?(Issue)
                  assert !issue.new_record?
                  issue.reload
                end
              end

test/unit/watcher_test.rb +9 0

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class WatcherTest < ActiveSupport::TestCase
                fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles, :enabled_modules,
                         :issues, :issue_statuses, :enumerations, :trackers, :projects_trackers,
                         :boards, :messages,
                         :wikis, :wiki_pages,
                         :watchers
                def setup
                  @user = User.find(1)
                  @issue = Issue.find(1)
                end
                def test_validate
                  user = User.find(5)
                  assert !user.active?
                  watcher = Watcher.new(:user_id => user.id)
                  assert !watcher.save
                end
                def test_watch
                  assert @issue.add_watcher(@user)
                  @issue.reload
                  assert @issue.watchers.detect { |w| w.user == @user }
                end
                def test_cant_watch_twice
                  assert @issue.add_watcher(@user)
                  assert !@issue.add_watcher(@user)
                end
                def test_watched_by
                  assert @issue.add_watcher(@user)
                  @issue.reload
                  assert @issue.watched_by?(@user)
                  assert Issue.watched_by(@user).include?(@issue)
                end
                def test_watcher_users
                  watcher_users = Issue.find(2).watcher_users
                  assert_kind_of Array, watcher_users.collect{|w| w}
                  assert_kind_of User, watcher_users.first
                end
+               def test_watcher_users_should_be_reloaded_after_adding_a_watcher
+                 issue = Issue.find(2)
+                 user = User.generate!
+                 assert_difference 'issue.watcher_users.to_a.size' do
+                   issue.add_watcher user
+                 end
+               end
                def test_watcher_users_should_not_validate_user
                  User.where(:id => 1).update_all("firstname = ''")
                  @user.reload
                  assert !@user.valid?
                  issue = Issue.new(:project => Project.find(1), :tracker_id => 1, :subject => "test", :author => User.find(2))
                  issue.watcher_users << @user
                  issue.save!
                  assert issue.watched_by?(@user)
                end
                def test_watcher_user_ids
                  assert_equal [1, 3], Issue.find(2).watcher_user_ids.sort
                end
                def test_watcher_user_ids=
                  issue = Issue.new
                  issue.watcher_user_ids = ['1', '3']
                  assert issue.watched_by?(User.find(1))
                end
                def test_watcher_user_ids_should_make_ids_uniq
                  issue = Issue.new(:project => Project.find(1), :tracker_id => 1, :subject => "test", :author => User.find(2))
                  issue.watcher_user_ids = ['1', '3', '1']
                  issue.save!
                  assert_equal 2, issue.watchers.count
                end
                def test_addable_watcher_users
                  addable_watcher_users = @issue.addable_watcher_users
                  assert_kind_of Array, addable_watcher_users
                  assert_kind_of User, addable_watcher_users.first
                end
                def test_addable_watcher_users_should_not_include_user_that_cannot_view_the_object
                  issue = Issue.new(:project => Project.find(1), :is_private => true)
                  assert_nil issue.addable_watcher_users.detect {|user| !issue.visible?(user)}
                end
                def test_any_watched_should_return_false_if_no_object_is_watched
                  objects = (0..2).map {Issue.generate!}
                  assert_equal false, Watcher.any_watched?(objects, @user)
                end
                def test_any_watched_should_return_true_if_one_object_is_watched
                  objects = (0..2).map {Issue.generate!}
                  objects.last.add_watcher(@user)
                  assert_equal true, Watcher.any_watched?(objects, @user)
                end
                def test_any_watched_should_return_false_with_no_object
                  assert_equal false, Watcher.any_watched?([], @user)
                end
                def test_recipients
                  @issue.watchers.delete_all
                  @issue.reload
                  assert @issue.watcher_recipients.empty?
                  assert @issue.add_watcher(@user)
                  @user.mail_notification = 'all'
                  @user.save!
                  @issue.reload
                  assert @issue.watcher_recipients.include?(@user.mail)
                  @user.mail_notification = 'none'
                  @user.save!
                  @issue.reload
                  assert !@issue.watcher_recipients.include?(@user.mail)
                end
                def test_unwatch
                  assert @issue.add_watcher(@user)
                  @issue.reload
                  assert_equal 1, @issue.remove_watcher(@user)
                end
                def test_prune_with_user
                  Watcher.delete_all("user_id = 9")
                  user = User.find(9)
                  # public
                  Watcher.create!(:watchable => Issue.find(1), :user => user)
                  Watcher.create!(:watchable => Issue.find(2), :user => user)
                  Watcher.create!(:watchable => Message.find(1), :user => user)
                  Watcher.create!(:watchable => Wiki.find(1), :user => user)
                  Watcher.create!(:watchable => WikiPage.find(2), :user => user)
                  # private project (id: 2)
                  Member.create!(:project => Project.find(2), :principal => user, :role_ids => [1])
                  Watcher.create!(:watchable => Issue.find(4), :user => user)
                  Watcher.create!(:watchable => Message.find(7), :user => user)
                  Watcher.create!(:watchable => Wiki.find(2), :user => user)
                  Watcher.create!(:watchable => WikiPage.find(3), :user => user)
                  assert_no_difference 'Watcher.count' do
                    Watcher.prune(:user => User.find(9))
                  end
                  Member.delete_all
                  assert_difference 'Watcher.count', -4 do
                    Watcher.prune(:user => User.find(9))
                  end
                  assert Issue.find(1).watched_by?(user)
                  assert !Issue.find(4).watched_by?(user)
                end
                def test_prune_with_project
                  user = User.find(9)
                  Watcher.new(:watchable => Issue.find(4), :user => User.find(9)).save(:validate => false) # project 2
                  Watcher.new(:watchable => Issue.find(6), :user => User.find(9)).save(:validate => false) # project 5
                  assert Watcher.prune(:project => Project.find(5)) > 0
                  assert Issue.find(4).watched_by?(user)
                  assert !Issue.find(6).watched_by?(user)
                end
                def test_prune_all
                  user = User.find(9)
                  Watcher.new(:watchable => Issue.find(4), :user => User.find(9)).save(:validate => false)
                  assert Watcher.prune > 0
                  assert !Issue.find(4).watched_by?(user)
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages