##// END OF EJS Templates
jro_apps » redmine
RSS
Refactor: Pull up method to ApplicationController....
Eric Davis -
r3824:f18b126fba30
parent child
Show More
Side by Side Unified
Context file:
r3824:f18b126fba30 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,367 +1,383
1 1 # redMine - project management software
2 2 # Copyright (C) 2006-2007 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require 'uri'
19 19 require 'cgi'
20 20
21 21 class ApplicationController < ActionController::Base
22 22 include Redmine::I18n
23 23
24 24 layout 'base'
25 25 exempt_from_layout 'builder'
26 26
27 27 # Remove broken cookie after upgrade from 0.8.x (#4292)
28 28 # See https://rails.lighthouseapp.com/projects/8994/tickets/3360
29 29 # TODO: remove it when Rails is fixed
30 30 before_filter :delete_broken_cookies
31 31 def delete_broken_cookies
32 32 if cookies['_redmine_session'] && cookies['_redmine_session'] !~ /--/
33 33 cookies.delete '_redmine_session'
34 34 redirect_to home_path
35 35 return false
36 36 end
37 37 end
38 38
39 39 before_filter :user_setup, :check_if_login_required, :set_localization
40 40 filter_parameter_logging :password
41 41 protect_from_forgery
42 42
43 43 rescue_from ActionController::InvalidAuthenticityToken, :with => :invalid_authenticity_token
44 44
45 45 include Redmine::Search::Controller
46 46 include Redmine::MenuManager::MenuController
47 47 helper Redmine::MenuManager::MenuHelper
48 48
49 49 Redmine::Scm::Base.all.each do |scm|
50 50 require_dependency "repository/#{scm.underscore}"
51 51 end
52 52
53 53 def user_setup
54 54 # Check the settings cache for each request
55 55 Setting.check_cache
56 56 # Find the current user
57 57 User.current = find_current_user
58 58 end
59 59
60 60 # Returns the current user or nil if no user is logged in
61 61 # and starts a session if needed
62 62 def find_current_user
63 63 if session[:user_id]
64 64 # existing session
65 65 (User.active.find(session[:user_id]) rescue nil)
66 66 elsif cookies[:autologin] && Setting.autologin?
67 67 # auto-login feature starts a new session
68 68 user = User.try_to_autologin(cookies[:autologin])
69 69 session[:user_id] = user.id if user
70 70 user
71 71 elsif params[:format] == 'atom' && params[:key] && accept_key_auth_actions.include?(params[:action])
72 72 # RSS key authentication does not start a session
73 73 User.find_by_rss_key(params[:key])
74 74 elsif Setting.rest_api_enabled? && ['xml', 'json'].include?(params[:format])
75 75 if params[:key].present? && accept_key_auth_actions.include?(params[:action])
76 76 # Use API key
77 77 User.find_by_api_key(params[:key])
78 78 else
79 79 # HTTP Basic, either username/password or API key/random
80 80 authenticate_with_http_basic do |username, password|
81 81 User.try_to_login(username, password) || User.find_by_api_key(username)
82 82 end
83 83 end
84 84 end
85 85 end
86 86
87 87 # Sets the logged in user
88 88 def logged_user=(user)
89 89 reset_session
90 90 if user && user.is_a?(User)
91 91 User.current = user
92 92 session[:user_id] = user.id
93 93 else
94 94 User.current = User.anonymous
95 95 end
96 96 end
97 97
98 98 # check if login is globally required to access the application
99 99 def check_if_login_required
100 100 # no check needed if user is already logged in
101 101 return true if User.current.logged?
102 102 require_login if Setting.login_required?
103 103 end
104 104
105 105 def set_localization
106 106 lang = nil
107 107 if User.current.logged?
108 108 lang = find_language(User.current.language)
109 109 end
110 110 if lang.nil? && request.env['HTTP_ACCEPT_LANGUAGE']
111 111 accept_lang = parse_qvalues(request.env['HTTP_ACCEPT_LANGUAGE']).first
112 112 if !accept_lang.blank?
113 113 accept_lang = accept_lang.downcase
114 114 lang = find_language(accept_lang) || find_language(accept_lang.split('-').first)
115 115 end
116 116 end
117 117 lang ||= Setting.default_language
118 118 set_language_if_valid(lang)
119 119 end
120 120
121 121 def require_login
122 122 if !User.current.logged?
123 123 # Extract only the basic url parameters on non-GET requests
124 124 if request.get?
125 125 url = url_for(params)
126 126 else
127 127 url = url_for(:controller => params[:controller], :action => params[:action], :id => params[:id], :project_id => params[:project_id])
128 128 end
129 129 respond_to do |format|
130 130 format.html { redirect_to :controller => "account", :action => "login", :back_url => url }
131 131 format.atom { redirect_to :controller => "account", :action => "login", :back_url => url }
132 132 format.xml { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
133 133 format.js { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
134 134 format.json { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
135 135 end
136 136 return false
137 137 end
138 138 true
139 139 end
140 140
141 141 def require_admin
142 142 return unless require_login
143 143 if !User.current.admin?
144 144 render_403
145 145 return false
146 146 end
147 147 true
148 148 end
149 149
150 150 def deny_access
151 151 User.current.logged? ? render_403 : require_login
152 152 end
153 153
154 154 # Authorize the user for the requested action
155 155 def authorize(ctrl = params[:controller], action = params[:action], global = false)
156 156 allowed = User.current.allowed_to?({:controller => ctrl, :action => action}, @project, :global => global)
157 157 allowed ? true : deny_access
158 158 end
159 159
160 160 # Authorize the user for the requested action outside a project
161 161 def authorize_global(ctrl = params[:controller], action = params[:action], global = true)
162 162 authorize(ctrl, action, global)
163 163 end
164 164
165 165 # Find project of id params[:id]
166 166 def find_project
167 167 @project = Project.find(params[:id])
168 168 rescue ActiveRecord::RecordNotFound
169 169 render_404
170 170 end
171 171
172 172 # Find a project based on params[:project_id]
173 173 # TODO: some subclasses override this, see about merging their logic
174 174 def find_optional_project
175 175 @project = Project.find(params[:project_id]) unless params[:project_id].blank?
176 176 allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true)
177 177 allowed ? true : deny_access
178 178 rescue ActiveRecord::RecordNotFound
179 179 render_404
180 180 end
181 181
182 182 # Finds and sets @project based on @object.project
183 183 def find_project_from_association
184 184 render_404 unless @object.present?
185 185
186 186 @project = @object.project
187 187 rescue ActiveRecord::RecordNotFound
188 188 render_404
189 189 end
190 190
191 191 def find_model_object
192 192 model = self.class.read_inheritable_attribute('model_object')
193 193 if model
194 194 @object = model.find(params[:id])
195 195 self.instance_variable_set('@' + controller_name.singularize, @object) if @object
196 196 end
197 197 rescue ActiveRecord::RecordNotFound
198 198 render_404
199 199 end
200 200
201 201 def self.model_object(model)
202 202 write_inheritable_attribute('model_object', model)
203 203 end
204
204
205 # Filter for bulk issue operations
206 def find_issues
207 @issues = Issue.find_all_by_id(params[:id] || params[:ids])
208 raise ActiveRecord::RecordNotFound if @issues.empty?
209 projects = @issues.collect(&:project).compact.uniq
210 if projects.size == 1
211 @project = projects.first
212 else
213 # TODO: let users bulk edit/move/destroy issues from different projects
214 render_error 'Can not bulk edit/move/destroy issues from different projects'
215 return false
216 end
217 rescue ActiveRecord::RecordNotFound
218 render_404
219 end
220
205 221 # make sure that the user is a member of the project (or admin) if project is private
206 222 # used as a before_filter for actions that do not require any particular permission on the project
207 223 def check_project_privacy
208 224 if @project && @project.active?
209 225 if @project.is_public? || User.current.member_of?(@project) || User.current.admin?
210 226 true
211 227 else
212 228 User.current.logged? ? render_403 : require_login
213 229 end
214 230 else
215 231 @project = nil
216 232 render_404
217 233 false
218 234 end
219 235 end
220 236
221 237 def back_url
222 238 params[:back_url] || request.env['HTTP_REFERER']
223 239 end
224 240
225 241 def redirect_back_or_default(default)
226 242 back_url = CGI.unescape(params[:back_url].to_s)
227 243 if !back_url.blank?
228 244 begin
229 245 uri = URI.parse(back_url)
230 246 # do not redirect user to another host or to the login or register page
231 247 if (uri.relative? || (uri.host == request.host)) && !uri.path.match(%r{/(login|account/register)})
232 248 redirect_to(back_url)
233 249 return
234 250 end
235 251 rescue URI::InvalidURIError
236 252 # redirect to default
237 253 end
238 254 end
239 255 redirect_to default
240 256 end
241 257
242 258 def render_403
243 259 @project = nil
244 260 respond_to do |format|
245 261 format.html { render :template => "common/403", :layout => (request.xhr? ? false : 'base'), :status => 403 }
246 262 format.atom { head 403 }
247 263 format.xml { head 403 }
248 264 format.js { head 403 }
249 265 format.json { head 403 }
250 266 end
251 267 return false
252 268 end
253 269
254 270 def render_404
255 271 respond_to do |format|
256 272 format.html { render :template => "common/404", :layout => !request.xhr?, :status => 404 }
257 273 format.atom { head 404 }
258 274 format.xml { head 404 }
259 275 format.js { head 404 }
260 276 format.json { head 404 }
261 277 end
262 278 return false
263 279 end
264 280
265 281 def render_error(msg)
266 282 respond_to do |format|
267 283 format.html {
268 284 flash.now[:error] = msg
269 285 render :text => '', :layout => !request.xhr?, :status => 500
270 286 }
271 287 format.atom { head 500 }
272 288 format.xml { head 500 }
273 289 format.js { head 500 }
274 290 format.json { head 500 }
275 291 end
276 292 end
277 293
278 294 def invalid_authenticity_token
279 295 if api_request?
280 296 logger.error "Form authenticity token is missing or is invalid. API calls must include a proper Content-type header (text/xml or text/json)."
281 297 end
282 298 render_error "Invalid form authenticity token."
283 299 end
284 300
285 301 def render_feed(items, options={})
286 302 @items = items || []
287 303 @items.sort! {|x,y| y.event_datetime <=> x.event_datetime }
288 304 @items = @items.slice(0, Setting.feeds_limit.to_i)
289 305 @title = options[:title] || Setting.app_title
290 306 render :template => "common/feed.atom.rxml", :layout => false, :content_type => 'application/atom+xml'
291 307 end
292 308
293 309 def self.accept_key_auth(*actions)
294 310 actions = actions.flatten.map(&:to_s)
295 311 write_inheritable_attribute('accept_key_auth_actions', actions)
296 312 end
297 313
298 314 def accept_key_auth_actions
299 315 self.class.read_inheritable_attribute('accept_key_auth_actions') || []
300 316 end
301 317
302 318 # Returns the number of objects that should be displayed
303 319 # on the paginated list
304 320 def per_page_option
305 321 per_page = nil
306 322 if params[:per_page] && Setting.per_page_options_array.include?(params[:per_page].to_s.to_i)
307 323 per_page = params[:per_page].to_s.to_i
308 324 session[:per_page] = per_page
309 325 elsif session[:per_page]
310 326 per_page = session[:per_page]
311 327 else
312 328 per_page = Setting.per_page_options_array.first || 25
313 329 end
314 330 per_page
315 331 end
316 332
317 333 # qvalues http header parser
318 334 # code taken from webrick
319 335 def parse_qvalues(value)
320 336 tmp = []
321 337 if value
322 338 parts = value.split(/,\s*/)
323 339 parts.each {|part|
324 340 if m = %r{^([^\s,]+?)(?:;\s*q=(\d+(?:\.\d+)?))?$}.match(part)
325 341 val = m[1]
326 342 q = (m[2] or 1).to_f
327 343 tmp.push([val, q])
328 344 end
329 345 }
330 346 tmp = tmp.sort_by{|val, q| -q}
331 347 tmp.collect!{|val, q| val}
332 348 end
333 349 return tmp
334 350 rescue
335 351 nil
336 352 end
337 353
338 354 # Returns a string that can be used as filename value in Content-Disposition header
339 355 def filename_for_content_disposition(name)
340 356 request.env['HTTP_USER_AGENT'] =~ %r{MSIE} ? ERB::Util.url_encode(name) : name
341 357 end
342 358
343 359 def api_request?
344 360 %w(xml json).include? params[:format]
345 361 end
346 362
347 363 # Renders a warning flash if obj has unsaved attachments
348 364 def render_attachment_warning_if_needed(obj)
349 365 flash[:warning] = l(:warning_attachments_not_saved, obj.unsaved_attachments.size) if obj.unsaved_attachments.present?
350 366 end
351 367
352 368 # Rescues an invalid query statement. Just in case...
353 369 def query_statement_invalid(exception)
354 370 logger.error "Query::StatementInvalid: #{exception.message}" if logger
355 371 session.delete(:query)
356 372 sort_clear if respond_to?(:sort_clear)
357 373 render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator."
358 374 end
359 375
360 376 # Converts the errors on an ActiveRecord object into a common JSON format
361 377 def object_errors_to_json(object)
362 378 object.errors.collect do |attribute, error|
363 379 { attribute => error }
364 380 end.to_json
365 381 end
366 382
367 383 end
Show file before | Show file after | Hide comments
@@ -1,94 +1,77
1 1 class IssueMovesController < ApplicationController
2 2 default_search_scope :issues
3 3 before_filter :find_issues
4 4 before_filter :authorize
5 5
6 6 def new
7 7 prepare_for_issue_move
8 8 render :layout => false if request.xhr?
9 9 end
10 10
11 11 def create
12 12 prepare_for_issue_move
13 13
14 14 if request.post?
15 15 new_tracker = params[:new_tracker_id].blank? ? nil : @target_project.trackers.find_by_id(params[:new_tracker_id])
16 16 unsaved_issue_ids = []
17 17 moved_issues = []
18 18 @issues.each do |issue|
19 19 issue.reload
20 20 issue.init_journal(User.current)
21 21 call_hook(:controller_issues_move_before_save, { :params => params, :issue => issue, :target_project => @target_project, :copy => !!@copy })
22 22 if r = issue.move_to_project(@target_project, new_tracker, {:copy => @copy, :attributes => extract_changed_attributes_for_move(params)})
23 23 moved_issues << r
24 24 else
25 25 unsaved_issue_ids << issue.id
26 26 end
27 27 end
28 28 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
29 29
30 30 if params[:follow]
31 31 if @issues.size == 1 && moved_issues.size == 1
32 32 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
33 33 else
34 34 redirect_to :controller => 'issues', :action => 'index', :project_id => (@target_project || @project)
35 35 end
36 36 else
37 37 redirect_to :controller => 'issues', :action => 'index', :project_id => @project
38 38 end
39 39 return
40 40 end
41 41 end
42 42
43 43 private
44 44
45 45 def prepare_for_issue_move
46 46 @issues.sort!
47 47 @copy = params[:copy_options] && params[:copy_options][:copy]
48 48 @allowed_projects = Issue.allowed_target_projects_on_move
49 49 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:new_project_id]} if params[:new_project_id]
50 50 @target_project ||= @project
51 51 @trackers = @target_project.trackers
52 52 @available_statuses = Workflow.available_statuses(@project)
53 53 end
54 54
55 # Filter for bulk operations
56 # TODO: duplicated in IssuesController
57 def find_issues
58 @issues = Issue.find_all_by_id(params[:id] || params[:ids])
59 raise ActiveRecord::RecordNotFound if @issues.empty?
60 projects = @issues.collect(&:project).compact.uniq
61 if projects.size == 1
62 @project = projects.first
63 else
64 # TODO: let users bulk edit/move/destroy issues from different projects
65 render_error 'Can not bulk edit/move/destroy issues from different projects'
66 return false
67 end
68 rescue ActiveRecord::RecordNotFound
69 render_404
70 end
71
72 55 # TODO: duplicated in IssuesController
73 56 def set_flash_from_bulk_issue_save(issues, unsaved_issue_ids)
74 57 if unsaved_issue_ids.empty?
75 58 flash[:notice] = l(:notice_successful_update) unless issues.empty?
76 59 else
77 60 flash[:error] = l(:notice_failed_to_save_issues,
78 61 :count => unsaved_issue_ids.size,
79 62 :total => issues.size,
80 63 :ids => '#' + unsaved_issue_ids.join(', #'))
81 64 end
82 65 end
83 66
84 67 def extract_changed_attributes_for_move(params)
85 68 changed_attributes = {}
86 69 [:assigned_to_id, :status_id, :start_date, :due_date].each do |valid_attribute|
87 70 unless params[valid_attribute].blank?
88 71 changed_attributes[valid_attribute] = (params[valid_attribute] == 'none' ? nil : params[valid_attribute])
89 72 end
90 73 end
91 74 changed_attributes
92 75 end
93 76
94 77 end
Show file before | Show file after | Hide comments
@@ -1,444 +1,428
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update, :reply]
23 23 before_filter :find_issues, :only => [:bulk_edit, :move, :perform_move, :destroy]
24 24 before_filter :find_project, :only => [:new, :create, :update_form, :preview, :auto_complete]
25 25 before_filter :authorize, :except => [:index, :changes, :preview, :context_menu]
26 26 before_filter :find_optional_project, :only => [:index, :changes]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
29 29 accept_key_auth :index, :show, :changes
30 30
31 31 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
32 32
33 33 helper :journals
34 34 helper :projects
35 35 include ProjectsHelper
36 36 helper :custom_fields
37 37 include CustomFieldsHelper
38 38 helper :issue_relations
39 39 include IssueRelationsHelper
40 40 helper :watchers
41 41 include WatchersHelper
42 42 helper :attachments
43 43 include AttachmentsHelper
44 44 helper :queries
45 45 include QueriesHelper
46 46 helper :sort
47 47 include SortHelper
48 48 include IssuesHelper
49 49 helper :timelog
50 50 include Redmine::Export::PDF
51 51
52 52 verify :method => [:post, :delete],
53 53 :only => :destroy,
54 54 :render => { :nothing => true, :status => :method_not_allowed }
55 55
56 56 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
57 57 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
58 58
59 59 def index
60 60 retrieve_query
61 61 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
62 62 sort_update(@query.sortable_columns)
63 63
64 64 if @query.valid?
65 65 limit = case params[:format]
66 66 when 'csv', 'pdf'
67 67 Setting.issues_export_limit.to_i
68 68 when 'atom'
69 69 Setting.feeds_limit.to_i
70 70 else
71 71 per_page_option
72 72 end
73 73
74 74 @issue_count = @query.issue_count
75 75 @issue_pages = Paginator.new self, @issue_count, limit, params['page']
76 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
77 77 :order => sort_clause,
78 78 :offset => @issue_pages.current.offset,
79 79 :limit => limit)
80 80 @issue_count_by_group = @query.issue_count_by_group
81 81
82 82 respond_to do |format|
83 83 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
84 84 format.xml { render :layout => false }
85 85 format.json { render :text => @issues.to_json, :layout => false }
86 86 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
87 87 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
88 88 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
89 89 end
90 90 else
91 91 # Send html if the query is not valid
92 92 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
93 93 end
94 94 rescue ActiveRecord::RecordNotFound
95 95 render_404
96 96 end
97 97
98 98 def changes
99 99 retrieve_query
100 100 sort_init 'id', 'desc'
101 101 sort_update(@query.sortable_columns)
102 102
103 103 if @query.valid?
104 104 @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",
105 105 :limit => 25)
106 106 end
107 107 @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)
108 108 render :layout => false, :content_type => 'application/atom+xml'
109 109 rescue ActiveRecord::RecordNotFound
110 110 render_404
111 111 end
112 112
113 113 def show
114 114 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
115 115 @journals.each_with_index {|j,i| j.indice = i+1}
116 116 @journals.reverse! if User.current.wants_comments_in_reverse_order?
117 117 @changesets = @issue.changesets.visible.all
118 118 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
119 119 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
120 120 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
121 121 @priorities = IssuePriority.all
122 122 @time_entry = TimeEntry.new
123 123 respond_to do |format|
124 124 format.html { render :template => 'issues/show.rhtml' }
125 125 format.xml { render :layout => false }
126 126 format.json { render :text => @issue.to_json, :layout => false }
127 127 format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }
128 128 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
129 129 end
130 130 end
131 131
132 132 # Add a new issue
133 133 # The new issue will be created from an existing one if copy_from parameter is given
134 134 def new
135 135 render :action => 'new', :layout => !request.xhr?
136 136 end
137 137
138 138 def create
139 139 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
140 140 if @issue.save
141 141 attachments = Attachment.attach_files(@issue, params[:attachments])
142 142 render_attachment_warning_if_needed(@issue)
143 143 flash[:notice] = l(:notice_successful_create)
144 144 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
145 145 respond_to do |format|
146 146 format.html {
147 147 redirect_to(params[:continue] ? { :action => 'new', :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
148 148 { :action => 'show', :id => @issue })
149 149 }
150 150 format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
151 151 format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
152 152 end
153 153 return
154 154 else
155 155 respond_to do |format|
156 156 format.html { render :action => 'new' }
157 157 format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
158 158 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
159 159 end
160 160 end
161 161 end
162 162
163 163 # Attributes that can be updated on workflow transition (without :edit permission)
164 164 # TODO: make it configurable (at least per role)
165 165 UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
166 166
167 167 def edit
168 168 update_issue_from_params
169 169
170 170 @journal = @issue.current_journal
171 171
172 172 respond_to do |format|
173 173 format.html { }
174 174 format.xml { }
175 175 end
176 176 end
177 177
178 178 def update
179 179 update_issue_from_params
180 180
181 181 if @issue.save_issue_with_child_records(params, @time_entry)
182 182 render_attachment_warning_if_needed(@issue)
183 183 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
184 184
185 185 respond_to do |format|
186 186 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
187 187 format.xml { head :ok }
188 188 format.json { head :ok }
189 189 end
190 190 else
191 191 render_attachment_warning_if_needed(@issue)
192 192 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
193 193 @journal = @issue.current_journal
194 194
195 195 respond_to do |format|
196 196 format.html { render :action => 'edit' }
197 197 format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }
198 198 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
199 199 end
200 200 end
201 201 end
202 202
203 203 def reply
204 204 journal = Journal.find(params[:journal_id]) if params[:journal_id]
205 205 if journal
206 206 user = journal.user
207 207 text = journal.notes
208 208 else
209 209 user = @issue.author
210 210 text = @issue.description
211 211 end
212 212 # Replaces pre blocks with [...]
213 213 text = text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]')
214 214 content = "#{ll(Setting.default_language, :text_user_wrote, user)}\n> "
215 215 content << text.gsub(/(\r?\n|\r\n?)/, "\n> ") + "\n\n"
216 216
217 217 render(:update) { |page|
218 218 page.<< "$('notes').value = \"#{escape_javascript content}\";"
219 219 page.show 'update'
220 220 page << "Form.Element.focus('notes');"
221 221 page << "Element.scrollTo('update');"
222 222 page << "$('notes').scrollTop = $('notes').scrollHeight - $('notes').clientHeight;"
223 223 }
224 224 end
225 225
226 226 # Bulk edit a set of issues
227 227 def bulk_edit
228 228 @issues.sort!
229 229 if request.post?
230 230 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
231 231 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
232 232 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
233 233
234 234 unsaved_issue_ids = []
235 235 @issues.each do |issue|
236 236 issue.reload
237 237 journal = issue.init_journal(User.current, params[:notes])
238 238 issue.safe_attributes = attributes
239 239 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
240 240 unless issue.save
241 241 # Keep unsaved issue ids to display them in flash error
242 242 unsaved_issue_ids << issue.id
243 243 end
244 244 end
245 245 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
246 246 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
247 247 return
248 248 end
249 249 @available_statuses = Workflow.available_statuses(@project)
250 250 @custom_fields = @project.all_issue_custom_fields
251 251 end
252 252
253 253 def destroy
254 254 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
255 255 if @hours > 0
256 256 case params[:todo]
257 257 when 'destroy'
258 258 # nothing to do
259 259 when 'nullify'
260 260 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
261 261 when 'reassign'
262 262 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
263 263 if reassign_to.nil?
264 264 flash.now[:error] = l(:error_issue_not_found_in_project)
265 265 return
266 266 else
267 267 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
268 268 end
269 269 else
270 270 unless params[:format] == 'xml' || params[:format] == 'json'
271 271 # display the destroy form if it's a user request
272 272 return
273 273 end
274 274 end
275 275 end
276 276 @issues.each(&:destroy)
277 277 respond_to do |format|
278 278 format.html { redirect_to :action => 'index', :project_id => @project }
279 279 format.xml { head :ok }
280 280 format.json { head :ok }
281 281 end
282 282 end
283 283
284 284 def context_menu
285 285 @issues = Issue.find_all_by_id(params[:ids], :include => :project)
286 286 if (@issues.size == 1)
287 287 @issue = @issues.first
288 288 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
289 289 end
290 290 projects = @issues.collect(&:project).compact.uniq
291 291 @project = projects.first if projects.size == 1
292 292
293 293 @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),
294 294 :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
295 295 :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),
296 296 :move => (@project && User.current.allowed_to?(:move_issues, @project)),
297 297 :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
298 298 :delete => (@project && User.current.allowed_to?(:delete_issues, @project))
299 299 }
300 300 if @project
301 301 @assignables = @project.assignable_users
302 302 @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)
303 303 @trackers = @project.trackers
304 304 end
305 305
306 306 @priorities = IssuePriority.all.reverse
307 307 @statuses = IssueStatus.find(:all, :order => 'position')
308 308 @back = back_url
309 309
310 310 render :layout => false
311 311 end
312 312
313 313 def update_form
314 314 if params[:id].blank?
315 315 @issue = Issue.new
316 316 @issue.project = @project
317 317 else
318 318 @issue = @project.issues.visible.find(params[:id])
319 319 end
320 320 @issue.attributes = params[:issue]
321 321 @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
322 322 @priorities = IssuePriority.all
323 323
324 324 render :partial => 'attributes'
325 325 end
326 326
327 327 def preview
328 328 @issue = @project.issues.find_by_id(params[:id]) unless params[:id].blank?
329 329 if @issue
330 330 @attachements = @issue.attachments
331 331 @description = params[:issue] && params[:issue][:description]
332 332 if @description && @description.gsub(/(\r?\n|\n\r?)/, "\n") == @issue.description.to_s.gsub(/(\r?\n|\n\r?)/, "\n")
333 333 @description = nil
334 334 end
335 335 @notes = params[:notes]
336 336 else
337 337 @description = (params[:issue] ? params[:issue][:description] : nil)
338 338 end
339 339 render :layout => false
340 340 end
341 341
342 342 def auto_complete
343 343 @issues = []
344 344 q = params[:q].to_s
345 345 if q.match(/^\d+$/)
346 346 @issues << @project.issues.visible.find_by_id(q.to_i)
347 347 end
348 348 unless q.blank?
349 349 @issues += @project.issues.visible.find(:all, :conditions => ["LOWER(#{Issue.table_name}.subject) LIKE ?", "%#{q.downcase}%"], :limit => 10)
350 350 end
351 351 render :layout => false
352 352 end
353 353
354 354 private
355 355 def find_issue
356 356 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
357 357 @project = @issue.project
358 358 rescue ActiveRecord::RecordNotFound
359 359 render_404
360 360 end
361 361
362 # Filter for bulk operations
363 def find_issues
364 @issues = Issue.find_all_by_id(params[:id] || params[:ids])
365 raise ActiveRecord::RecordNotFound if @issues.empty?
366 projects = @issues.collect(&:project).compact.uniq
367 if projects.size == 1
368 @project = projects.first
369 else
370 # TODO: let users bulk edit/move/destroy issues from different projects
371 render_error 'Can not bulk edit/move/destroy issues from different projects'
372 return false
373 end
374 rescue ActiveRecord::RecordNotFound
375 render_404
376 end
377
378 362 def find_project
379 363 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
380 364 @project = Project.find(project_id)
381 365 rescue ActiveRecord::RecordNotFound
382 366 render_404
383 367 end
384 368
385 369 # Used by #edit and #update to set some common instance variables
386 370 # from the params
387 371 # TODO: Refactor, not everything in here is needed by #edit
388 372 def update_issue_from_params
389 373 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
390 374 @priorities = IssuePriority.all
391 375 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
392 376 @time_entry = TimeEntry.new
393 377
394 378 @notes = params[:notes]
395 379 @issue.init_journal(User.current, @notes)
396 380 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
397 381 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
398 382 attrs = params[:issue].dup
399 383 attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
400 384 attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
401 385 @issue.safe_attributes = attrs
402 386 end
403 387
404 388 end
405 389
406 390 # TODO: Refactor, lots of extra code in here
407 391 def build_new_issue_from_params
408 392 @issue = Issue.new
409 393 @issue.copy_from(params[:copy_from]) if params[:copy_from]
410 394 @issue.project = @project
411 395 # Tracker must be set before custom field values
412 396 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
413 397 if @issue.tracker.nil?
414 398 render_error l(:error_no_tracker_in_project)
415 399 return false
416 400 end
417 401 if params[:issue].is_a?(Hash)
418 402 @issue.safe_attributes = params[:issue]
419 403 @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
420 404 end
421 405 @issue.author = User.current
422 406 @issue.start_date ||= Date.today
423 407 @priorities = IssuePriority.all
424 408 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
425 409 end
426 410
427 411 def set_flash_from_bulk_issue_save(issues, unsaved_issue_ids)
428 412 if unsaved_issue_ids.empty?
429 413 flash[:notice] = l(:notice_successful_update) unless issues.empty?
430 414 else
431 415 flash[:error] = l(:notice_failed_to_save_issues,
432 416 :count => unsaved_issue_ids.size,
433 417 :total => issues.size,
434 418 :ids => '#' + unsaved_issue_ids.join(', #'))
435 419 end
436 420 end
437 421
438 422 def check_for_default_issue_status
439 423 if IssueStatus.default.nil?
440 424 render_error l(:error_no_default_issue_status)
441 425 return false
442 426 end
443 427 end
444 428 end
General Comments 0
You need to be logged in to leave comments. Login now