jro_apps/redmine Commit - r4965:eea06ab7702f

scm: cvs: use scm_cmd() in adapter revisions()....

Toshi MARUYAMA -

r4965:eea06ab7702f

parent child

Context file:

r4965:eea06ab7702f

lib/redmine/scm/adapters/cvs_adapter.rb +6 -4

                        logger.debug "<cvs> revisions path:'#{path}',identifier_from #{identifier_from}, identifier_to #{identifier_to}"
                        path_with_project="#{url}#{with_leading_slash(path)}"
-                       cmd = "#{self.class.sq_bin} -d #{shell_quote root_url} rlog"
-                       cmd << " -d\">#{time_to_cvstime_rlog(identifier_from)}\"" if identifier_from
-                       cmd << " #{shell_quote path_with_project}"
-                       shellout(cmd) do |io|
+                       cmd_args = %w|rlog|
+                       cmd_args << "-d" << ">#{time_to_cvstime_rlog(identifier_from)}" if identifier_from
+                       cmd_args << path_with_project
+                       scm_cmd(*cmd_args) do |io|
                          state="entry_start"
                          commit_log=String.new
                            end
                          end
                        end
+                     rescue ScmCommandAborted
+                       Revisions.new
                      end
                      def diff(path, identifier_from, identifier_to=nil)

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages