jro_apps/redmine Commit - r8075:ed5f487cf507

Fixed broken issue form update when changing tracker....

Jean-Philippe Lang -

r8075:ed5f487cf507

parent child

Context file:

r8075:ed5f487cf507

app/views/issues/_form.html.erb +1 -1

             </p>
             <% end %>
             <p><%= f.select :tracker_id, @project.trackers.collect {|t| [t.name, t.id]}, :required => true %></p>
-            <%= observe_field :issue_tracker_id, :url => { :action => :new, :project_id => @project, :id => @issue },
+            <%= observe_field :issue_tracker_id, :url => project_issue_form_path(@project, :id => @issue),
                                                  :update => :attributes,
                                                  :with => "Form.serialize('issue-form')" %>

config/routes.rb +3 0

                 project.resources :issues, :only => [:index, :new, :create] do |issues|
                   issues.resources :time_entries, :controller => 'timelog', :collection => {:report => :get}
                 end
+                # issue form update
+                project.issue_form 'issues/new', :controller => 'issues', :action => 'new', :conditions => {:method => :post}
                 project.resources :files, :only => [:index, :new, :create]
                 project.resources :versions, :shallow => true, :collection => {:close_completed => :put}, :member => {:status_by => :post}
                 project.resources :news, :shallow => true

test/integration/issues_test.rb +9 0

@@ -64,6 +64,15 class IssuesTest < ActionController::IntegrationTest
64	assert_equal 1, issue.status.id	64	assert_equal 1, issue.status.id
65	end	65	end
66		66
		67	def test_update_issue_form
		68	log_user('jsmith', 'jsmith')
		69	post 'projects/ecookbook/issues/new', :issue => { :tracker_id => "2"}
		70	assert_response :success
		71	assert_tag 'select',
		72	:attributes => {:name => 'issue[tracker_id]'},
		73	:child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}}
		74	end
		75
67	# add then remove 2 attachments to an issue	76	# add then remove 2 attachments to an issue
68	def test_issue_attachments	77	def test_issue_attachments
69	log_user('jsmith', 'jsmith')	78	log_user('jsmith', 'jsmith')

test/integration/routing_test.rb +2 0

                 should_route :get, "/issues/64.xml", :controller => 'issues', :action => 'show', :id => '64', :format => 'xml'
                 should_route :get, "/projects/23/issues/new", :controller => 'issues', :action => 'new', :project_id => '23'
+                # issue form update
+                should_route :post, "/projects/23/issues/new", :controller => 'issues', :action => 'new', :project_id => '23'
                 should_route :post, "/projects/23/issues", :controller => 'issues', :action => 'create', :project_id => '23'
                 should_route :post, "/issues.xml", :controller => 'issues', :action => 'create', :format => 'xml'

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages