##// END OF EJS Templates
jro_apps » redmine
RSS
Fixes assertions (#8836)....
Jean-Philippe Lang -
r6182:ed23149a6c18
parent child
Show More
Side by Side Unified
Context file:
r6182:ed23149a6c18 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1015 +1,1015
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
33 33 assert issue.save
34 34 issue.reload
35 35 assert_equal 1.5, issue.estimated_hours
36 36 end
37 37
38 38 def test_create_minimal
39 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
40 40 assert issue.save
41 41 assert issue.description.nil?
42 42 end
43 43
44 44 def test_create_with_required_custom_field
45 45 field = IssueCustomField.find_by_name('Database')
46 46 field.update_attribute(:is_required, true)
47 47
48 48 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
49 49 assert issue.available_custom_fields.include?(field)
50 50 # No value for the custom field
51 51 assert !issue.save
52 52 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
53 53 # Blank value
54 54 issue.custom_field_values = { field.id => '' }
55 55 assert !issue.save
56 56 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
57 57 # Invalid value
58 58 issue.custom_field_values = { field.id => 'SQLServer' }
59 59 assert !issue.save
60 60 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
61 61 # Valid value
62 62 issue.custom_field_values = { field.id => 'PostgreSQL' }
63 63 assert issue.save
64 64 issue.reload
65 65 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
66 66 end
67 67
68 68 def assert_visibility_match(user, issues)
69 69 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
70 70 end
71 71
72 72 def test_visible_scope_for_anonymous
73 73 # Anonymous user should see issues of public projects only
74 74 issues = Issue.visible(User.anonymous).all
75 75 assert issues.any?
76 76 assert_nil issues.detect {|issue| !issue.project.is_public?}
77 77 assert_nil issues.detect {|issue| issue.is_private?}
78 78 assert_visibility_match User.anonymous, issues
79 79 end
80 80
81 81 def test_visible_scope_for_anonymous_with_own_issues_visibility
82 82 Role.anonymous.update_attribute :issues_visibility, 'own'
83 83 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
84 84
85 85 issues = Issue.visible(User.anonymous).all
86 86 assert issues.any?
87 87 assert_nil issues.detect {|issue| issue.author != User.anonymous}
88 88 assert_visibility_match User.anonymous, issues
89 89 end
90 90
91 91 def test_visible_scope_for_anonymous_without_view_issues_permissions
92 92 # Anonymous user should not see issues without permission
93 93 Role.anonymous.remove_permission!(:view_issues)
94 94 issues = Issue.visible(User.anonymous).all
95 95 assert issues.empty?
96 96 assert_visibility_match User.anonymous, issues
97 97 end
98 98
99 99 def test_visible_scope_for_non_member
100 100 user = User.find(9)
101 101 assert user.projects.empty?
102 102 # Non member user should see issues of public projects only
103 103 issues = Issue.visible(user).all
104 104 assert issues.any?
105 105 assert_nil issues.detect {|issue| !issue.project.is_public?}
106 106 assert_nil issues.detect {|issue| issue.is_private?}
107 107 assert_visibility_match user, issues
108 108 end
109 109
110 110 def test_visible_scope_for_non_member_with_own_issues_visibility
111 111 Role.non_member.update_attribute :issues_visibility, 'own'
112 112 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
113 113 user = User.find(9)
114 114
115 115 issues = Issue.visible(user).all
116 116 assert issues.any?
117 117 assert_nil issues.detect {|issue| issue.author != user}
118 118 assert_visibility_match user, issues
119 119 end
120 120
121 121 def test_visible_scope_for_non_member_without_view_issues_permissions
122 122 # Non member user should not see issues without permission
123 123 Role.non_member.remove_permission!(:view_issues)
124 124 user = User.find(9)
125 125 assert user.projects.empty?
126 126 issues = Issue.visible(user).all
127 127 assert issues.empty?
128 128 assert_visibility_match user, issues
129 129 end
130 130
131 131 def test_visible_scope_for_member
132 132 user = User.find(9)
133 133 # User should see issues of projects for which he has view_issues permissions only
134 134 Role.non_member.remove_permission!(:view_issues)
135 135 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
136 136 issues = Issue.visible(user).all
137 137 assert issues.any?
138 138 assert_nil issues.detect {|issue| issue.project_id != 3}
139 139 assert_nil issues.detect {|issue| issue.is_private?}
140 140 assert_visibility_match user, issues
141 141 end
142 142
143 143 def test_visible_scope_for_admin
144 144 user = User.find(1)
145 145 user.members.each(&:destroy)
146 146 assert user.projects.empty?
147 147 issues = Issue.visible(user).all
148 148 assert issues.any?
149 149 # Admin should see issues on private projects that he does not belong to
150 150 assert issues.detect {|issue| !issue.project.is_public?}
151 151 # Admin should see private issues of other users
152 152 assert issues.detect {|issue| issue.is_private? && issue.author != user}
153 153 assert_visibility_match user, issues
154 154 end
155 155
156 156 def test_visible_scope_with_project
157 157 project = Project.find(1)
158 158 issues = Issue.visible(User.find(2), :project => project).all
159 159 projects = issues.collect(&:project).uniq
160 160 assert_equal 1, projects.size
161 161 assert_equal project, projects.first
162 162 end
163 163
164 164 def test_visible_scope_with_project_and_subprojects
165 165 project = Project.find(1)
166 166 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
167 167 projects = issues.collect(&:project).uniq
168 168 assert projects.size > 1
169 169 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
170 170 end
171 171
172 172 def test_visible_and_nested_set_scopes
173 173 assert_equal 0, Issue.find(1).descendants.visible.all.size
174 174 end
175 175
176 176 def test_errors_full_messages_should_include_custom_fields_errors
177 177 field = IssueCustomField.find_by_name('Database')
178 178
179 179 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
180 180 assert issue.available_custom_fields.include?(field)
181 181 # Invalid value
182 182 issue.custom_field_values = { field.id => 'SQLServer' }
183 183
184 184 assert !issue.valid?
185 185 assert_equal 1, issue.errors.full_messages.size
186 186 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
187 187 end
188 188
189 189 def test_update_issue_with_required_custom_field
190 190 field = IssueCustomField.find_by_name('Database')
191 191 field.update_attribute(:is_required, true)
192 192
193 193 issue = Issue.find(1)
194 194 assert_nil issue.custom_value_for(field)
195 195 assert issue.available_custom_fields.include?(field)
196 196 # No change to custom values, issue can be saved
197 197 assert issue.save
198 198 # Blank value
199 199 issue.custom_field_values = { field.id => '' }
200 200 assert !issue.save
201 201 # Valid value
202 202 issue.custom_field_values = { field.id => 'PostgreSQL' }
203 203 assert issue.save
204 204 issue.reload
205 205 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
206 206 end
207 207
208 208 def test_should_not_update_attributes_if_custom_fields_validation_fails
209 209 issue = Issue.find(1)
210 210 field = IssueCustomField.find_by_name('Database')
211 211 assert issue.available_custom_fields.include?(field)
212 212
213 213 issue.custom_field_values = { field.id => 'Invalid' }
214 214 issue.subject = 'Should be not be saved'
215 215 assert !issue.save
216 216
217 217 issue.reload
218 218 assert_equal "Can't print recipes", issue.subject
219 219 end
220 220
221 221 def test_should_not_recreate_custom_values_objects_on_update
222 222 field = IssueCustomField.find_by_name('Database')
223 223
224 224 issue = Issue.find(1)
225 225 issue.custom_field_values = { field.id => 'PostgreSQL' }
226 226 assert issue.save
227 227 custom_value = issue.custom_value_for(field)
228 228 issue.reload
229 229 issue.custom_field_values = { field.id => 'MySQL' }
230 230 assert issue.save
231 231 issue.reload
232 232 assert_equal custom_value.id, issue.custom_value_for(field).id
233 233 end
234 234
235 235 def test_assigning_tracker_id_should_reload_custom_fields_values
236 236 issue = Issue.new(:project => Project.find(1))
237 237 assert issue.custom_field_values.empty?
238 238 issue.tracker_id = 1
239 239 assert issue.custom_field_values.any?
240 240 end
241 241
242 242 def test_assigning_attributes_should_assign_tracker_id_first
243 243 attributes = ActiveSupport::OrderedHash.new
244 244 attributes['custom_field_values'] = { '1' => 'MySQL' }
245 245 attributes['tracker_id'] = '1'
246 246 issue = Issue.new(:project => Project.find(1))
247 247 issue.attributes = attributes
248 248 assert_not_nil issue.custom_value_for(1)
249 249 assert_equal 'MySQL', issue.custom_value_for(1).value
250 250 end
251 251
252 252 def test_should_update_issue_with_disabled_tracker
253 253 p = Project.find(1)
254 254 issue = Issue.find(1)
255 255
256 256 p.trackers.delete(issue.tracker)
257 257 assert !p.trackers.include?(issue.tracker)
258 258
259 259 issue.reload
260 260 issue.subject = 'New subject'
261 261 assert issue.save
262 262 end
263 263
264 264 def test_should_not_set_a_disabled_tracker
265 265 p = Project.find(1)
266 266 p.trackers.delete(Tracker.find(2))
267 267
268 268 issue = Issue.find(1)
269 269 issue.tracker_id = 2
270 270 issue.subject = 'New subject'
271 271 assert !issue.save
272 272 assert_not_nil issue.errors.on(:tracker_id)
273 273 end
274 274
275 275 def test_category_based_assignment
276 276 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1)
277 277 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
278 278 end
279 279
280 280 def test_new_statuses_allowed_to
281 281 Workflow.delete_all
282 282
283 283 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
284 284 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
285 285 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
286 286 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
287 287 status = IssueStatus.find(1)
288 288 role = Role.find(1)
289 289 tracker = Tracker.find(1)
290 290 user = User.find(2)
291 291
292 292 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
293 293 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
294 294
295 295 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
296 assert_equal [1, 2, 3], issue.new_statuses_allowed_to(user).map(&:id)
296 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
297 297
298 298 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
299 assert_equal [1, 2, 4], issue.new_statuses_allowed_to(user).map(&:id)
299 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
300 300
301 301 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
302 302 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
303 303 end
304 304
305 305 def test_copy
306 306 issue = Issue.new.copy_from(1)
307 307 assert issue.save
308 308 issue.reload
309 309 orig = Issue.find(1)
310 310 assert_equal orig.subject, issue.subject
311 311 assert_equal orig.tracker, issue.tracker
312 312 assert_equal "125", issue.custom_value_for(2).value
313 313 end
314 314
315 315 def test_copy_should_copy_status
316 316 orig = Issue.find(8)
317 317 assert orig.status != IssueStatus.default
318 318
319 319 issue = Issue.new.copy_from(orig)
320 320 assert issue.save
321 321 issue.reload
322 322 assert_equal orig.status, issue.status
323 323 end
324 324
325 325 def test_should_close_duplicates
326 326 # Create 3 issues
327 327 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
328 328 assert issue1.save
329 329 issue2 = issue1.clone
330 330 assert issue2.save
331 331 issue3 = issue1.clone
332 332 assert issue3.save
333 333
334 334 # 2 is a dupe of 1
335 335 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
336 336 # And 3 is a dupe of 2
337 337 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
338 338 # And 3 is a dupe of 1 (circular duplicates)
339 339 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
340 340
341 341 assert issue1.reload.duplicates.include?(issue2)
342 342
343 343 # Closing issue 1
344 344 issue1.init_journal(User.find(:first), "Closing issue1")
345 345 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
346 346 assert issue1.save
347 347 # 2 and 3 should be also closed
348 348 assert issue2.reload.closed?
349 349 assert issue3.reload.closed?
350 350 end
351 351
352 352 def test_should_not_close_duplicated_issue
353 353 # Create 3 issues
354 354 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
355 355 assert issue1.save
356 356 issue2 = issue1.clone
357 357 assert issue2.save
358 358
359 359 # 2 is a dupe of 1
360 360 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
361 361 # 2 is a dup of 1 but 1 is not a duplicate of 2
362 362 assert !issue2.reload.duplicates.include?(issue1)
363 363
364 364 # Closing issue 2
365 365 issue2.init_journal(User.find(:first), "Closing issue2")
366 366 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
367 367 assert issue2.save
368 368 # 1 should not be also closed
369 369 assert !issue1.reload.closed?
370 370 end
371 371
372 372 def test_assignable_versions
373 373 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
374 374 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
375 375 end
376 376
377 377 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
378 378 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
379 379 assert !issue.save
380 380 assert_not_nil issue.errors.on(:fixed_version_id)
381 381 end
382 382
383 383 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
384 384 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
385 385 assert !issue.save
386 386 assert_not_nil issue.errors.on(:fixed_version_id)
387 387 end
388 388
389 389 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
390 390 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
391 391 assert issue.save
392 392 end
393 393
394 394 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
395 395 issue = Issue.find(11)
396 396 assert_equal 'closed', issue.fixed_version.status
397 397 issue.subject = 'Subject changed'
398 398 assert issue.save
399 399 end
400 400
401 401 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
402 402 issue = Issue.find(11)
403 403 issue.status_id = 1
404 404 assert !issue.save
405 405 assert_not_nil issue.errors.on_base
406 406 end
407 407
408 408 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
409 409 issue = Issue.find(11)
410 410 issue.status_id = 1
411 411 issue.fixed_version_id = 3
412 412 assert issue.save
413 413 end
414 414
415 415 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
416 416 issue = Issue.find(12)
417 417 assert_equal 'locked', issue.fixed_version.status
418 418 issue.status_id = 1
419 419 assert issue.save
420 420 end
421 421
422 422 def test_move_to_another_project_with_same_category
423 423 issue = Issue.find(1)
424 424 assert issue.move_to_project(Project.find(2))
425 425 issue.reload
426 426 assert_equal 2, issue.project_id
427 427 # Category changes
428 428 assert_equal 4, issue.category_id
429 429 # Make sure time entries were move to the target project
430 430 assert_equal 2, issue.time_entries.first.project_id
431 431 end
432 432
433 433 def test_move_to_another_project_without_same_category
434 434 issue = Issue.find(2)
435 435 assert issue.move_to_project(Project.find(2))
436 436 issue.reload
437 437 assert_equal 2, issue.project_id
438 438 # Category cleared
439 439 assert_nil issue.category_id
440 440 end
441 441
442 442 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
443 443 issue = Issue.find(1)
444 444 issue.update_attribute(:fixed_version_id, 1)
445 445 assert issue.move_to_project(Project.find(2))
446 446 issue.reload
447 447 assert_equal 2, issue.project_id
448 448 # Cleared fixed_version
449 449 assert_equal nil, issue.fixed_version
450 450 end
451 451
452 452 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
453 453 issue = Issue.find(1)
454 454 issue.update_attribute(:fixed_version_id, 4)
455 455 assert issue.move_to_project(Project.find(5))
456 456 issue.reload
457 457 assert_equal 5, issue.project_id
458 458 # Keep fixed_version
459 459 assert_equal 4, issue.fixed_version_id
460 460 end
461 461
462 462 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
463 463 issue = Issue.find(1)
464 464 issue.update_attribute(:fixed_version_id, 1)
465 465 assert issue.move_to_project(Project.find(5))
466 466 issue.reload
467 467 assert_equal 5, issue.project_id
468 468 # Cleared fixed_version
469 469 assert_equal nil, issue.fixed_version
470 470 end
471 471
472 472 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
473 473 issue = Issue.find(1)
474 474 issue.update_attribute(:fixed_version_id, 7)
475 475 assert issue.move_to_project(Project.find(2))
476 476 issue.reload
477 477 assert_equal 2, issue.project_id
478 478 # Keep fixed_version
479 479 assert_equal 7, issue.fixed_version_id
480 480 end
481 481
482 482 def test_move_to_another_project_with_disabled_tracker
483 483 issue = Issue.find(1)
484 484 target = Project.find(2)
485 485 target.tracker_ids = [3]
486 486 target.save
487 487 assert_equal false, issue.move_to_project(target)
488 488 issue.reload
489 489 assert_equal 1, issue.project_id
490 490 end
491 491
492 492 def test_copy_to_the_same_project
493 493 issue = Issue.find(1)
494 494 copy = nil
495 495 assert_difference 'Issue.count' do
496 496 copy = issue.move_to_project(issue.project, nil, :copy => true)
497 497 end
498 498 assert_kind_of Issue, copy
499 499 assert_equal issue.project, copy.project
500 500 assert_equal "125", copy.custom_value_for(2).value
501 501 end
502 502
503 503 def test_copy_to_another_project_and_tracker
504 504 issue = Issue.find(1)
505 505 copy = nil
506 506 assert_difference 'Issue.count' do
507 507 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
508 508 end
509 509 copy.reload
510 510 assert_kind_of Issue, copy
511 511 assert_equal Project.find(3), copy.project
512 512 assert_equal Tracker.find(2), copy.tracker
513 513 # Custom field #2 is not associated with target tracker
514 514 assert_nil copy.custom_value_for(2)
515 515 end
516 516
517 517 context "#move_to_project" do
518 518 context "as a copy" do
519 519 setup do
520 520 @issue = Issue.find(1)
521 521 @copy = nil
522 522 end
523 523
524 524 should "not create a journal" do
525 525 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
526 526 assert_equal 0, @copy.reload.journals.size
527 527 end
528 528
529 529 should "allow assigned_to changes" do
530 530 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
531 531 assert_equal 3, @copy.assigned_to_id
532 532 end
533 533
534 534 should "allow status changes" do
535 535 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
536 536 assert_equal 2, @copy.status_id
537 537 end
538 538
539 539 should "allow start date changes" do
540 540 date = Date.today
541 541 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
542 542 assert_equal date, @copy.start_date
543 543 end
544 544
545 545 should "allow due date changes" do
546 546 date = Date.today
547 547 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
548 548
549 549 assert_equal date, @copy.due_date
550 550 end
551 551
552 552 should "set current user as author" do
553 553 User.current = User.find(9)
554 554 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
555 555
556 556 assert_equal User.current, @copy.author
557 557 end
558 558
559 559 should "keep journal notes" do
560 560 date = Date.today
561 561 notes = "Notes added when copying"
562 562 User.current = User.find(9)
563 563 @issue.init_journal(User.current, notes)
564 564 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
565 565
566 566 assert_equal 1, @copy.journals.size
567 567 journal = @copy.journals.first
568 568 assert_equal 0, journal.details.size
569 569 assert_equal notes, journal.notes
570 570 end
571 571 end
572 572 end
573 573
574 574 def test_recipients_should_not_include_users_that_cannot_view_the_issue
575 575 issue = Issue.find(12)
576 576 assert issue.recipients.include?(issue.author.mail)
577 577 # move the issue to a private project
578 578 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
579 579 # author is not a member of project anymore
580 580 assert !copy.recipients.include?(copy.author.mail)
581 581 end
582 582
583 583 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
584 584 user = User.find(3)
585 585 issue = Issue.find(9)
586 586 Watcher.create!(:user => user, :watchable => issue)
587 587 assert issue.watched_by?(user)
588 588 assert !issue.watcher_recipients.include?(user.mail)
589 589 end
590 590
591 591 def test_issue_destroy
592 592 Issue.find(1).destroy
593 593 assert_nil Issue.find_by_id(1)
594 594 assert_nil TimeEntry.find_by_issue_id(1)
595 595 end
596 596
597 597 def test_blocked
598 598 blocked_issue = Issue.find(9)
599 599 blocking_issue = Issue.find(10)
600 600
601 601 assert blocked_issue.blocked?
602 602 assert !blocking_issue.blocked?
603 603 end
604 604
605 605 def test_blocked_issues_dont_allow_closed_statuses
606 606 blocked_issue = Issue.find(9)
607 607
608 608 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
609 609 assert !allowed_statuses.empty?
610 610 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
611 611 assert closed_statuses.empty?
612 612 end
613 613
614 614 def test_unblocked_issues_allow_closed_statuses
615 615 blocking_issue = Issue.find(10)
616 616
617 617 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
618 618 assert !allowed_statuses.empty?
619 619 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
620 620 assert !closed_statuses.empty?
621 621 end
622 622
623 623 def test_rescheduling_an_issue_should_reschedule_following_issue
624 624 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
625 625 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
626 626 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
627 627 assert_equal issue1.due_date + 1, issue2.reload.start_date
628 628
629 629 issue1.due_date = Date.today + 5
630 630 issue1.save!
631 631 assert_equal issue1.due_date + 1, issue2.reload.start_date
632 632 end
633 633
634 634 def test_overdue
635 635 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
636 636 assert !Issue.new(:due_date => Date.today).overdue?
637 637 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
638 638 assert !Issue.new(:due_date => nil).overdue?
639 639 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
640 640 end
641 641
642 642 context "#behind_schedule?" do
643 643 should "be false if the issue has no start_date" do
644 644 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
645 645 end
646 646
647 647 should "be false if the issue has no end_date" do
648 648 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
649 649 end
650 650
651 651 should "be false if the issue has more done than it's calendar time" do
652 652 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
653 653 end
654 654
655 655 should "be true if the issue hasn't been started at all" do
656 656 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
657 657 end
658 658
659 659 should "be true if the issue has used more calendar time than it's done ratio" do
660 660 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
661 661 end
662 662 end
663 663
664 664 context "#assignable_users" do
665 665 should "be Users" do
666 666 assert_kind_of User, Issue.find(1).assignable_users.first
667 667 end
668 668
669 669 should "include the issue author" do
670 670 project = Project.find(1)
671 671 non_project_member = User.generate!
672 672 issue = Issue.generate_for_project!(project, :author => non_project_member)
673 673
674 674 assert issue.assignable_users.include?(non_project_member)
675 675 end
676 676
677 677 should "not show the issue author twice" do
678 678 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
679 679 assert_equal 2, assignable_user_ids.length
680 680
681 681 assignable_user_ids.each do |user_id|
682 682 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
683 683 end
684 684 end
685 685 end
686 686
687 687 def test_create_should_send_email_notification
688 688 ActionMailer::Base.deliveries.clear
689 689 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
690 690
691 691 assert issue.save
692 692 assert_equal 1, ActionMailer::Base.deliveries.size
693 693 end
694 694
695 695 def test_stale_issue_should_not_send_email_notification
696 696 ActionMailer::Base.deliveries.clear
697 697 issue = Issue.find(1)
698 698 stale = Issue.find(1)
699 699
700 700 issue.init_journal(User.find(1))
701 701 issue.subject = 'Subjet update'
702 702 assert issue.save
703 703 assert_equal 1, ActionMailer::Base.deliveries.size
704 704 ActionMailer::Base.deliveries.clear
705 705
706 706 stale.init_journal(User.find(1))
707 707 stale.subject = 'Another subjet update'
708 708 assert_raise ActiveRecord::StaleObjectError do
709 709 stale.save
710 710 end
711 711 assert ActionMailer::Base.deliveries.empty?
712 712 end
713 713
714 714 def test_journalized_description
715 715 IssueCustomField.delete_all
716 716
717 717 i = Issue.first
718 718 old_description = i.description
719 719 new_description = "This is the new description"
720 720
721 721 i.init_journal(User.find(2))
722 722 i.description = new_description
723 723 assert_difference 'Journal.count', 1 do
724 724 assert_difference 'JournalDetail.count', 1 do
725 725 i.save!
726 726 end
727 727 end
728 728
729 729 detail = JournalDetail.first(:order => 'id DESC')
730 730 assert_equal i, detail.journal.journalized
731 731 assert_equal 'attr', detail.property
732 732 assert_equal 'description', detail.prop_key
733 733 assert_equal old_description, detail.old_value
734 734 assert_equal new_description, detail.value
735 735 end
736 736
737 737 def test_blank_descriptions_should_not_be_journalized
738 738 IssueCustomField.delete_all
739 739 Issue.update_all("description = NULL", "id=1")
740 740
741 741 i = Issue.find(1)
742 742 i.init_journal(User.find(2))
743 743 i.subject = "blank description"
744 744 i.description = "\r\n"
745 745
746 746 assert_difference 'Journal.count', 1 do
747 747 assert_difference 'JournalDetail.count', 1 do
748 748 i.save!
749 749 end
750 750 end
751 751 end
752 752
753 753 def test_description_eol_should_be_normalized
754 754 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
755 755 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
756 756 end
757 757
758 758 def test_saving_twice_should_not_duplicate_journal_details
759 759 i = Issue.find(:first)
760 760 i.init_journal(User.find(2), 'Some notes')
761 761 # initial changes
762 762 i.subject = 'New subject'
763 763 i.done_ratio = i.done_ratio + 10
764 764 assert_difference 'Journal.count' do
765 765 assert i.save
766 766 end
767 767 # 1 more change
768 768 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
769 769 assert_no_difference 'Journal.count' do
770 770 assert_difference 'JournalDetail.count', 1 do
771 771 i.save
772 772 end
773 773 end
774 774 # no more change
775 775 assert_no_difference 'Journal.count' do
776 776 assert_no_difference 'JournalDetail.count' do
777 777 i.save
778 778 end
779 779 end
780 780 end
781 781
782 782 def test_all_dependent_issues
783 783 IssueRelation.delete_all
784 784 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
785 785 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
786 786 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
787 787
788 788 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
789 789 end
790 790
791 791 def test_all_dependent_issues_with_persistent_circular_dependency
792 792 IssueRelation.delete_all
793 793 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
794 794 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
795 795 # Validation skipping
796 796 assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
797 797
798 798 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
799 799 end
800 800
801 801 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
802 802 IssueRelation.delete_all
803 803 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES)
804 804 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_RELATES)
805 805 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_RELATES)
806 806 # Validation skipping
807 807 assert IssueRelation.new(:issue_from => Issue.find(8), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES).save(false)
808 808 assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_RELATES).save(false)
809 809
810 810 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
811 811 end
812 812
813 813 context "#done_ratio" do
814 814 setup do
815 815 @issue = Issue.find(1)
816 816 @issue_status = IssueStatus.find(1)
817 817 @issue_status.update_attribute(:default_done_ratio, 50)
818 818 @issue2 = Issue.find(2)
819 819 @issue_status2 = IssueStatus.find(2)
820 820 @issue_status2.update_attribute(:default_done_ratio, 0)
821 821 end
822 822
823 823 context "with Setting.issue_done_ratio using the issue_field" do
824 824 setup do
825 825 Setting.issue_done_ratio = 'issue_field'
826 826 end
827 827
828 828 should "read the issue's field" do
829 829 assert_equal 0, @issue.done_ratio
830 830 assert_equal 30, @issue2.done_ratio
831 831 end
832 832 end
833 833
834 834 context "with Setting.issue_done_ratio using the issue_status" do
835 835 setup do
836 836 Setting.issue_done_ratio = 'issue_status'
837 837 end
838 838
839 839 should "read the Issue Status's default done ratio" do
840 840 assert_equal 50, @issue.done_ratio
841 841 assert_equal 0, @issue2.done_ratio
842 842 end
843 843 end
844 844 end
845 845
846 846 context "#update_done_ratio_from_issue_status" do
847 847 setup do
848 848 @issue = Issue.find(1)
849 849 @issue_status = IssueStatus.find(1)
850 850 @issue_status.update_attribute(:default_done_ratio, 50)
851 851 @issue2 = Issue.find(2)
852 852 @issue_status2 = IssueStatus.find(2)
853 853 @issue_status2.update_attribute(:default_done_ratio, 0)
854 854 end
855 855
856 856 context "with Setting.issue_done_ratio using the issue_field" do
857 857 setup do
858 858 Setting.issue_done_ratio = 'issue_field'
859 859 end
860 860
861 861 should "not change the issue" do
862 862 @issue.update_done_ratio_from_issue_status
863 863 @issue2.update_done_ratio_from_issue_status
864 864
865 865 assert_equal 0, @issue.read_attribute(:done_ratio)
866 866 assert_equal 30, @issue2.read_attribute(:done_ratio)
867 867 end
868 868 end
869 869
870 870 context "with Setting.issue_done_ratio using the issue_status" do
871 871 setup do
872 872 Setting.issue_done_ratio = 'issue_status'
873 873 end
874 874
875 875 should "change the issue's done ratio" do
876 876 @issue.update_done_ratio_from_issue_status
877 877 @issue2.update_done_ratio_from_issue_status
878 878
879 879 assert_equal 50, @issue.read_attribute(:done_ratio)
880 880 assert_equal 0, @issue2.read_attribute(:done_ratio)
881 881 end
882 882 end
883 883 end
884 884
885 885 test "#by_tracker" do
886 886 User.current = User.anonymous
887 887 groups = Issue.by_tracker(Project.find(1))
888 888 assert_equal 3, groups.size
889 889 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
890 890 end
891 891
892 892 test "#by_version" do
893 893 User.current = User.anonymous
894 894 groups = Issue.by_version(Project.find(1))
895 895 assert_equal 3, groups.size
896 896 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
897 897 end
898 898
899 899 test "#by_priority" do
900 900 User.current = User.anonymous
901 901 groups = Issue.by_priority(Project.find(1))
902 902 assert_equal 4, groups.size
903 903 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
904 904 end
905 905
906 906 test "#by_category" do
907 907 User.current = User.anonymous
908 908 groups = Issue.by_category(Project.find(1))
909 909 assert_equal 2, groups.size
910 910 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
911 911 end
912 912
913 913 test "#by_assigned_to" do
914 914 User.current = User.anonymous
915 915 groups = Issue.by_assigned_to(Project.find(1))
916 916 assert_equal 2, groups.size
917 917 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
918 918 end
919 919
920 920 test "#by_author" do
921 921 User.current = User.anonymous
922 922 groups = Issue.by_author(Project.find(1))
923 923 assert_equal 4, groups.size
924 924 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
925 925 end
926 926
927 927 test "#by_subproject" do
928 928 User.current = User.anonymous
929 929 groups = Issue.by_subproject(Project.find(1))
930 930 # Private descendant not visible
931 931 assert_equal 1, groups.size
932 932 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
933 933 end
934 934
935 935 context ".allowed_target_projects_on_move" do
936 936 should "return all active projects for admin users" do
937 937 User.current = User.find(1)
938 938 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
939 939 end
940 940
941 941 should "return allowed projects for non admin users" do
942 942 User.current = User.find(2)
943 943 Role.non_member.remove_permission! :move_issues
944 944 assert_equal 3, Issue.allowed_target_projects_on_move.size
945 945
946 946 Role.non_member.add_permission! :move_issues
947 947 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
948 948 end
949 949 end
950 950
951 951 def test_recently_updated_with_limit_scopes
952 952 #should return the last updated issue
953 953 assert_equal 1, Issue.recently_updated.with_limit(1).length
954 954 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
955 955 end
956 956
957 957 def test_on_active_projects_scope
958 958 assert Project.find(2).archive
959 959
960 960 before = Issue.on_active_project.length
961 961 # test inclusion to results
962 962 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
963 963 assert_equal before + 1, Issue.on_active_project.length
964 964
965 965 # Move to an archived project
966 966 issue.project = Project.find(2)
967 967 assert issue.save
968 968 assert_equal before, Issue.on_active_project.length
969 969 end
970 970
971 971 context "Issue#recipients" do
972 972 setup do
973 973 @project = Project.find(1)
974 974 @author = User.generate_with_protected!
975 975 @assignee = User.generate_with_protected!
976 976 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
977 977 end
978 978
979 979 should "include project recipients" do
980 980 assert @project.recipients.present?
981 981 @project.recipients.each do |project_recipient|
982 982 assert @issue.recipients.include?(project_recipient)
983 983 end
984 984 end
985 985
986 986 should "include the author if the author is active" do
987 987 assert @issue.author, "No author set for Issue"
988 988 assert @issue.recipients.include?(@issue.author.mail)
989 989 end
990 990
991 991 should "include the assigned to user if the assigned to user is active" do
992 992 assert @issue.assigned_to, "No assigned_to set for Issue"
993 993 assert @issue.recipients.include?(@issue.assigned_to.mail)
994 994 end
995 995
996 996 should "not include users who opt out of all email" do
997 997 @author.update_attribute(:mail_notification, :none)
998 998
999 999 assert !@issue.recipients.include?(@issue.author.mail)
1000 1000 end
1001 1001
1002 1002 should "not include the issue author if they are only notified of assigned issues" do
1003 1003 @author.update_attribute(:mail_notification, :only_assigned)
1004 1004
1005 1005 assert !@issue.recipients.include?(@issue.author.mail)
1006 1006 end
1007 1007
1008 1008 should "not include the assigned user if they are only notified of owned issues" do
1009 1009 @assignee.update_attribute(:mail_notification, :only_owner)
1010 1010
1011 1011 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1012 1012 end
1013 1013
1014 1014 end
1015 1015 end
General Comments 0
You need to be logged in to leave comments. Login now