##// END OF EJS Templates
Rails4: replace deprecated Relation#first with finder options at TimelogControllerTest...
Toshi MARUYAMA -
r12367:eab8f307f9ba
parent child
Show More
@@ -1,663 +1,663
1 # -*- coding: utf-8 -*-
1 # -*- coding: utf-8 -*-
2 # Redmine - project management software
2 # Redmine - project management software
3 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 # Copyright (C) 2006-2013 Jean-Philippe Lang
4 #
4 #
5 # This program is free software; you can redistribute it and/or
5 # This program is free software; you can redistribute it and/or
6 # modify it under the terms of the GNU General Public License
6 # modify it under the terms of the GNU General Public License
7 # as published by the Free Software Foundation; either version 2
7 # as published by the Free Software Foundation; either version 2
8 # of the License, or (at your option) any later version.
8 # of the License, or (at your option) any later version.
9 #
9 #
10 # This program is distributed in the hope that it will be useful,
10 # This program is distributed in the hope that it will be useful,
11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
13 # GNU General Public License for more details.
14 #
14 #
15 # You should have received a copy of the GNU General Public License
15 # You should have received a copy of the GNU General Public License
16 # along with this program; if not, write to the Free Software
16 # along with this program; if not, write to the Free Software
17 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
18
19 require File.expand_path('../../test_helper', __FILE__)
19 require File.expand_path('../../test_helper', __FILE__)
20
20
21 class TimelogControllerTest < ActionController::TestCase
21 class TimelogControllerTest < ActionController::TestCase
22 fixtures :projects, :enabled_modules, :roles, :members,
22 fixtures :projects, :enabled_modules, :roles, :members,
23 :member_roles, :issues, :time_entries, :users,
23 :member_roles, :issues, :time_entries, :users,
24 :trackers, :enumerations, :issue_statuses,
24 :trackers, :enumerations, :issue_statuses,
25 :custom_fields, :custom_values,
25 :custom_fields, :custom_values,
26 :projects_trackers, :custom_fields_trackers,
26 :projects_trackers, :custom_fields_trackers,
27 :custom_fields_projects
27 :custom_fields_projects
28
28
29 include Redmine::I18n
29 include Redmine::I18n
30
30
31 def test_new_with_project_id
31 def test_new_with_project_id
32 @request.session[:user_id] = 3
32 @request.session[:user_id] = 3
33 get :new, :project_id => 1
33 get :new, :project_id => 1
34 assert_response :success
34 assert_response :success
35 assert_template 'new'
35 assert_template 'new'
36 assert_select 'select[name=?]', 'time_entry[project_id]', 0
36 assert_select 'select[name=?]', 'time_entry[project_id]', 0
37 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
37 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
38 end
38 end
39
39
40 def test_new_with_issue_id
40 def test_new_with_issue_id
41 @request.session[:user_id] = 3
41 @request.session[:user_id] = 3
42 get :new, :issue_id => 2
42 get :new, :issue_id => 2
43 assert_response :success
43 assert_response :success
44 assert_template 'new'
44 assert_template 'new'
45 assert_select 'select[name=?]', 'time_entry[project_id]', 0
45 assert_select 'select[name=?]', 'time_entry[project_id]', 0
46 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
46 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
47 end
47 end
48
48
49 def test_new_without_project
49 def test_new_without_project
50 @request.session[:user_id] = 3
50 @request.session[:user_id] = 3
51 get :new
51 get :new
52 assert_response :success
52 assert_response :success
53 assert_template 'new'
53 assert_template 'new'
54 assert_select 'select[name=?]', 'time_entry[project_id]'
54 assert_select 'select[name=?]', 'time_entry[project_id]'
55 assert_select 'input[name=?]', 'time_entry[project_id]', 0
55 assert_select 'input[name=?]', 'time_entry[project_id]', 0
56 end
56 end
57
57
58 def test_new_without_project_should_prefill_the_form
58 def test_new_without_project_should_prefill_the_form
59 @request.session[:user_id] = 3
59 @request.session[:user_id] = 3
60 get :new, :time_entry => {:project_id => '1'}
60 get :new, :time_entry => {:project_id => '1'}
61 assert_response :success
61 assert_response :success
62 assert_template 'new'
62 assert_template 'new'
63 assert_select 'select[name=?]', 'time_entry[project_id]' do
63 assert_select 'select[name=?]', 'time_entry[project_id]' do
64 assert_select 'option[value=1][selected=selected]'
64 assert_select 'option[value=1][selected=selected]'
65 end
65 end
66 assert_select 'input[name=?]', 'time_entry[project_id]', 0
66 assert_select 'input[name=?]', 'time_entry[project_id]', 0
67 end
67 end
68
68
69 def test_new_without_project_should_deny_without_permission
69 def test_new_without_project_should_deny_without_permission
70 Role.all.each {|role| role.remove_permission! :log_time}
70 Role.all.each {|role| role.remove_permission! :log_time}
71 @request.session[:user_id] = 3
71 @request.session[:user_id] = 3
72
72
73 get :new
73 get :new
74 assert_response 403
74 assert_response 403
75 end
75 end
76
76
77 def test_new_should_select_default_activity
77 def test_new_should_select_default_activity
78 @request.session[:user_id] = 3
78 @request.session[:user_id] = 3
79 get :new, :project_id => 1
79 get :new, :project_id => 1
80 assert_response :success
80 assert_response :success
81 assert_select 'select[name=?]', 'time_entry[activity_id]' do
81 assert_select 'select[name=?]', 'time_entry[activity_id]' do
82 assert_select 'option[selected=selected]', :text => 'Development'
82 assert_select 'option[selected=selected]', :text => 'Development'
83 end
83 end
84 end
84 end
85
85
86 def test_new_should_only_show_active_time_entry_activities
86 def test_new_should_only_show_active_time_entry_activities
87 @request.session[:user_id] = 3
87 @request.session[:user_id] = 3
88 get :new, :project_id => 1
88 get :new, :project_id => 1
89 assert_response :success
89 assert_response :success
90 assert_no_tag 'option', :content => 'Inactive Activity'
90 assert_no_tag 'option', :content => 'Inactive Activity'
91 end
91 end
92
92
93 def test_get_edit_existing_time
93 def test_get_edit_existing_time
94 @request.session[:user_id] = 2
94 @request.session[:user_id] = 2
95 get :edit, :id => 2, :project_id => nil
95 get :edit, :id => 2, :project_id => nil
96 assert_response :success
96 assert_response :success
97 assert_template 'edit'
97 assert_template 'edit'
98 # Default activity selected
98 # Default activity selected
99 assert_tag :tag => 'form', :attributes => { :action => '/projects/ecookbook/time_entries/2' }
99 assert_tag :tag => 'form', :attributes => { :action => '/projects/ecookbook/time_entries/2' }
100 end
100 end
101
101
102 def test_get_edit_with_an_existing_time_entry_with_inactive_activity
102 def test_get_edit_with_an_existing_time_entry_with_inactive_activity
103 te = TimeEntry.find(1)
103 te = TimeEntry.find(1)
104 te.activity = TimeEntryActivity.find_by_name("Inactive Activity")
104 te.activity = TimeEntryActivity.find_by_name("Inactive Activity")
105 te.save!
105 te.save!
106
106
107 @request.session[:user_id] = 1
107 @request.session[:user_id] = 1
108 get :edit, :project_id => 1, :id => 1
108 get :edit, :project_id => 1, :id => 1
109 assert_response :success
109 assert_response :success
110 assert_template 'edit'
110 assert_template 'edit'
111 # Blank option since nothing is pre-selected
111 # Blank option since nothing is pre-selected
112 assert_tag :tag => 'option', :content => '--- Please select ---'
112 assert_tag :tag => 'option', :content => '--- Please select ---'
113 end
113 end
114
114
115 def test_post_create
115 def test_post_create
116 # TODO: should POST to issues’ time log instead of project. change form
116 # TODO: should POST to issues’ time log instead of project. change form
117 # and routing
117 # and routing
118 @request.session[:user_id] = 3
118 @request.session[:user_id] = 3
119 post :create, :project_id => 1,
119 post :create, :project_id => 1,
120 :time_entry => {:comments => 'Some work on TimelogControllerTest',
120 :time_entry => {:comments => 'Some work on TimelogControllerTest',
121 # Not the default activity
121 # Not the default activity
122 :activity_id => '11',
122 :activity_id => '11',
123 :spent_on => '2008-03-14',
123 :spent_on => '2008-03-14',
124 :issue_id => '1',
124 :issue_id => '1',
125 :hours => '7.3'}
125 :hours => '7.3'}
126 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
126 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
127
127
128 i = Issue.find(1)
128 i = Issue.find(1)
129 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
129 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
130 assert_not_nil t
130 assert_not_nil t
131 assert_equal 11, t.activity_id
131 assert_equal 11, t.activity_id
132 assert_equal 7.3, t.hours
132 assert_equal 7.3, t.hours
133 assert_equal 3, t.user_id
133 assert_equal 3, t.user_id
134 assert_equal i, t.issue
134 assert_equal i, t.issue
135 assert_equal i.project, t.project
135 assert_equal i.project, t.project
136 end
136 end
137
137
138 def test_post_create_with_blank_issue
138 def test_post_create_with_blank_issue
139 # TODO: should POST to issues’ time log instead of project. change form
139 # TODO: should POST to issues’ time log instead of project. change form
140 # and routing
140 # and routing
141 @request.session[:user_id] = 3
141 @request.session[:user_id] = 3
142 post :create, :project_id => 1,
142 post :create, :project_id => 1,
143 :time_entry => {:comments => 'Some work on TimelogControllerTest',
143 :time_entry => {:comments => 'Some work on TimelogControllerTest',
144 # Not the default activity
144 # Not the default activity
145 :activity_id => '11',
145 :activity_id => '11',
146 :issue_id => '',
146 :issue_id => '',
147 :spent_on => '2008-03-14',
147 :spent_on => '2008-03-14',
148 :hours => '7.3'}
148 :hours => '7.3'}
149 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
149 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
150
150
151 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
151 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
152 assert_not_nil t
152 assert_not_nil t
153 assert_equal 11, t.activity_id
153 assert_equal 11, t.activity_id
154 assert_equal 7.3, t.hours
154 assert_equal 7.3, t.hours
155 assert_equal 3, t.user_id
155 assert_equal 3, t.user_id
156 end
156 end
157
157
158 def test_create_and_continue
158 def test_create_and_continue
159 @request.session[:user_id] = 2
159 @request.session[:user_id] = 2
160 post :create, :project_id => 1,
160 post :create, :project_id => 1,
161 :time_entry => {:activity_id => '11',
161 :time_entry => {:activity_id => '11',
162 :issue_id => '',
162 :issue_id => '',
163 :spent_on => '2008-03-14',
163 :spent_on => '2008-03-14',
164 :hours => '7.3'},
164 :hours => '7.3'},
165 :continue => '1'
165 :continue => '1'
166 assert_redirected_to '/projects/ecookbook/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D='
166 assert_redirected_to '/projects/ecookbook/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D='
167 end
167 end
168
168
169 def test_create_and_continue_with_issue_id
169 def test_create_and_continue_with_issue_id
170 @request.session[:user_id] = 2
170 @request.session[:user_id] = 2
171 post :create, :project_id => 1,
171 post :create, :project_id => 1,
172 :time_entry => {:activity_id => '11',
172 :time_entry => {:activity_id => '11',
173 :issue_id => '1',
173 :issue_id => '1',
174 :spent_on => '2008-03-14',
174 :spent_on => '2008-03-14',
175 :hours => '7.3'},
175 :hours => '7.3'},
176 :continue => '1'
176 :continue => '1'
177 assert_redirected_to '/projects/ecookbook/issues/1/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=1'
177 assert_redirected_to '/projects/ecookbook/issues/1/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=1'
178 end
178 end
179
179
180 def test_create_and_continue_without_project
180 def test_create_and_continue_without_project
181 @request.session[:user_id] = 2
181 @request.session[:user_id] = 2
182 post :create, :time_entry => {:project_id => '1',
182 post :create, :time_entry => {:project_id => '1',
183 :activity_id => '11',
183 :activity_id => '11',
184 :issue_id => '',
184 :issue_id => '',
185 :spent_on => '2008-03-14',
185 :spent_on => '2008-03-14',
186 :hours => '7.3'},
186 :hours => '7.3'},
187 :continue => '1'
187 :continue => '1'
188
188
189 assert_redirected_to '/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=&time_entry%5Bproject_id%5D=1'
189 assert_redirected_to '/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=&time_entry%5Bproject_id%5D=1'
190 end
190 end
191
191
192 def test_create_without_log_time_permission_should_be_denied
192 def test_create_without_log_time_permission_should_be_denied
193 @request.session[:user_id] = 2
193 @request.session[:user_id] = 2
194 Role.find_by_name('Manager').remove_permission! :log_time
194 Role.find_by_name('Manager').remove_permission! :log_time
195 post :create, :project_id => 1,
195 post :create, :project_id => 1,
196 :time_entry => {:activity_id => '11',
196 :time_entry => {:activity_id => '11',
197 :issue_id => '',
197 :issue_id => '',
198 :spent_on => '2008-03-14',
198 :spent_on => '2008-03-14',
199 :hours => '7.3'}
199 :hours => '7.3'}
200
200
201 assert_response 403
201 assert_response 403
202 end
202 end
203
203
204 def test_create_with_failure
204 def test_create_with_failure
205 @request.session[:user_id] = 2
205 @request.session[:user_id] = 2
206 post :create, :project_id => 1,
206 post :create, :project_id => 1,
207 :time_entry => {:activity_id => '',
207 :time_entry => {:activity_id => '',
208 :issue_id => '',
208 :issue_id => '',
209 :spent_on => '2008-03-14',
209 :spent_on => '2008-03-14',
210 :hours => '7.3'}
210 :hours => '7.3'}
211
211
212 assert_response :success
212 assert_response :success
213 assert_template 'new'
213 assert_template 'new'
214 end
214 end
215
215
216 def test_create_without_project
216 def test_create_without_project
217 @request.session[:user_id] = 2
217 @request.session[:user_id] = 2
218 assert_difference 'TimeEntry.count' do
218 assert_difference 'TimeEntry.count' do
219 post :create, :time_entry => {:project_id => '1',
219 post :create, :time_entry => {:project_id => '1',
220 :activity_id => '11',
220 :activity_id => '11',
221 :issue_id => '',
221 :issue_id => '',
222 :spent_on => '2008-03-14',
222 :spent_on => '2008-03-14',
223 :hours => '7.3'}
223 :hours => '7.3'}
224 end
224 end
225
225
226 assert_redirected_to '/projects/ecookbook/time_entries'
226 assert_redirected_to '/projects/ecookbook/time_entries'
227 time_entry = TimeEntry.first(:order => 'id DESC')
227 time_entry = TimeEntry.order('id DESC').first
228 assert_equal 1, time_entry.project_id
228 assert_equal 1, time_entry.project_id
229 end
229 end
230
230
231 def test_create_without_project_should_fail_with_issue_not_inside_project
231 def test_create_without_project_should_fail_with_issue_not_inside_project
232 @request.session[:user_id] = 2
232 @request.session[:user_id] = 2
233 assert_no_difference 'TimeEntry.count' do
233 assert_no_difference 'TimeEntry.count' do
234 post :create, :time_entry => {:project_id => '1',
234 post :create, :time_entry => {:project_id => '1',
235 :activity_id => '11',
235 :activity_id => '11',
236 :issue_id => '5',
236 :issue_id => '5',
237 :spent_on => '2008-03-14',
237 :spent_on => '2008-03-14',
238 :hours => '7.3'}
238 :hours => '7.3'}
239 end
239 end
240
240
241 assert_response :success
241 assert_response :success
242 assert assigns(:time_entry).errors[:issue_id].present?
242 assert assigns(:time_entry).errors[:issue_id].present?
243 end
243 end
244
244
245 def test_create_without_project_should_deny_without_permission
245 def test_create_without_project_should_deny_without_permission
246 @request.session[:user_id] = 2
246 @request.session[:user_id] = 2
247 Project.find(3).disable_module!(:time_tracking)
247 Project.find(3).disable_module!(:time_tracking)
248
248
249 assert_no_difference 'TimeEntry.count' do
249 assert_no_difference 'TimeEntry.count' do
250 post :create, :time_entry => {:project_id => '3',
250 post :create, :time_entry => {:project_id => '3',
251 :activity_id => '11',
251 :activity_id => '11',
252 :issue_id => '',
252 :issue_id => '',
253 :spent_on => '2008-03-14',
253 :spent_on => '2008-03-14',
254 :hours => '7.3'}
254 :hours => '7.3'}
255 end
255 end
256
256
257 assert_response 403
257 assert_response 403
258 end
258 end
259
259
260 def test_create_without_project_with_failure
260 def test_create_without_project_with_failure
261 @request.session[:user_id] = 2
261 @request.session[:user_id] = 2
262 assert_no_difference 'TimeEntry.count' do
262 assert_no_difference 'TimeEntry.count' do
263 post :create, :time_entry => {:project_id => '1',
263 post :create, :time_entry => {:project_id => '1',
264 :activity_id => '11',
264 :activity_id => '11',
265 :issue_id => '',
265 :issue_id => '',
266 :spent_on => '2008-03-14',
266 :spent_on => '2008-03-14',
267 :hours => ''}
267 :hours => ''}
268 end
268 end
269
269
270 assert_response :success
270 assert_response :success
271 assert_tag 'select', :attributes => {:name => 'time_entry[project_id]'},
271 assert_tag 'select', :attributes => {:name => 'time_entry[project_id]'},
272 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}}
272 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}}
273 end
273 end
274
274
275 def test_update
275 def test_update
276 entry = TimeEntry.find(1)
276 entry = TimeEntry.find(1)
277 assert_equal 1, entry.issue_id
277 assert_equal 1, entry.issue_id
278 assert_equal 2, entry.user_id
278 assert_equal 2, entry.user_id
279
279
280 @request.session[:user_id] = 1
280 @request.session[:user_id] = 1
281 put :update, :id => 1,
281 put :update, :id => 1,
282 :time_entry => {:issue_id => '2',
282 :time_entry => {:issue_id => '2',
283 :hours => '8'}
283 :hours => '8'}
284 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
284 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
285 entry.reload
285 entry.reload
286
286
287 assert_equal 8, entry.hours
287 assert_equal 8, entry.hours
288 assert_equal 2, entry.issue_id
288 assert_equal 2, entry.issue_id
289 assert_equal 2, entry.user_id
289 assert_equal 2, entry.user_id
290 end
290 end
291
291
292 def test_get_bulk_edit
292 def test_get_bulk_edit
293 @request.session[:user_id] = 2
293 @request.session[:user_id] = 2
294 get :bulk_edit, :ids => [1, 2]
294 get :bulk_edit, :ids => [1, 2]
295 assert_response :success
295 assert_response :success
296 assert_template 'bulk_edit'
296 assert_template 'bulk_edit'
297
297
298 assert_select 'ul#bulk-selection' do
298 assert_select 'ul#bulk-selection' do
299 assert_select 'li', 2
299 assert_select 'li', 2
300 assert_select 'li a', :text => '03/23/2007 - eCookbook: 4.25 hours'
300 assert_select 'li a', :text => '03/23/2007 - eCookbook: 4.25 hours'
301 end
301 end
302
302
303 assert_select 'form#bulk_edit_form[action=?]', '/time_entries/bulk_update' do
303 assert_select 'form#bulk_edit_form[action=?]', '/time_entries/bulk_update' do
304 # System wide custom field
304 # System wide custom field
305 assert_select 'select[name=?]', 'time_entry[custom_field_values][10]'
305 assert_select 'select[name=?]', 'time_entry[custom_field_values][10]'
306
306
307 # Activities
307 # Activities
308 assert_select 'select[name=?]', 'time_entry[activity_id]' do
308 assert_select 'select[name=?]', 'time_entry[activity_id]' do
309 assert_select 'option[value=]', :text => '(No change)'
309 assert_select 'option[value=]', :text => '(No change)'
310 assert_select 'option[value=9]', :text => 'Design'
310 assert_select 'option[value=9]', :text => 'Design'
311 end
311 end
312 end
312 end
313 end
313 end
314
314
315 def test_get_bulk_edit_on_different_projects
315 def test_get_bulk_edit_on_different_projects
316 @request.session[:user_id] = 2
316 @request.session[:user_id] = 2
317 get :bulk_edit, :ids => [1, 2, 6]
317 get :bulk_edit, :ids => [1, 2, 6]
318 assert_response :success
318 assert_response :success
319 assert_template 'bulk_edit'
319 assert_template 'bulk_edit'
320 end
320 end
321
321
322 def test_bulk_update
322 def test_bulk_update
323 @request.session[:user_id] = 2
323 @request.session[:user_id] = 2
324 # update time entry activity
324 # update time entry activity
325 post :bulk_update, :ids => [1, 2], :time_entry => { :activity_id => 9}
325 post :bulk_update, :ids => [1, 2], :time_entry => { :activity_id => 9}
326
326
327 assert_response 302
327 assert_response 302
328 # check that the issues were updated
328 # check that the issues were updated
329 assert_equal [9, 9], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.activity_id}
329 assert_equal [9, 9], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.activity_id}
330 end
330 end
331
331
332 def test_bulk_update_with_failure
332 def test_bulk_update_with_failure
333 @request.session[:user_id] = 2
333 @request.session[:user_id] = 2
334 post :bulk_update, :ids => [1, 2], :time_entry => { :hours => 'A'}
334 post :bulk_update, :ids => [1, 2], :time_entry => { :hours => 'A'}
335
335
336 assert_response 302
336 assert_response 302
337 assert_match /Failed to save 2 time entrie/, flash[:error]
337 assert_match /Failed to save 2 time entrie/, flash[:error]
338 end
338 end
339
339
340 def test_bulk_update_on_different_projects
340 def test_bulk_update_on_different_projects
341 @request.session[:user_id] = 2
341 @request.session[:user_id] = 2
342 # makes user a manager on the other project
342 # makes user a manager on the other project
343 Member.create!(:user_id => 2, :project_id => 3, :role_ids => [1])
343 Member.create!(:user_id => 2, :project_id => 3, :role_ids => [1])
344
344
345 # update time entry activity
345 # update time entry activity
346 post :bulk_update, :ids => [1, 2, 4], :time_entry => { :activity_id => 9 }
346 post :bulk_update, :ids => [1, 2, 4], :time_entry => { :activity_id => 9 }
347
347
348 assert_response 302
348 assert_response 302
349 # check that the issues were updated
349 # check that the issues were updated
350 assert_equal [9, 9, 9], TimeEntry.find_all_by_id([1, 2, 4]).collect {|i| i.activity_id}
350 assert_equal [9, 9, 9], TimeEntry.find_all_by_id([1, 2, 4]).collect {|i| i.activity_id}
351 end
351 end
352
352
353 def test_bulk_update_on_different_projects_without_rights
353 def test_bulk_update_on_different_projects_without_rights
354 @request.session[:user_id] = 3
354 @request.session[:user_id] = 3
355 user = User.find(3)
355 user = User.find(3)
356 action = { :controller => "timelog", :action => "bulk_update" }
356 action = { :controller => "timelog", :action => "bulk_update" }
357 assert user.allowed_to?(action, TimeEntry.find(1).project)
357 assert user.allowed_to?(action, TimeEntry.find(1).project)
358 assert ! user.allowed_to?(action, TimeEntry.find(5).project)
358 assert ! user.allowed_to?(action, TimeEntry.find(5).project)
359 post :bulk_update, :ids => [1, 5], :time_entry => { :activity_id => 9 }
359 post :bulk_update, :ids => [1, 5], :time_entry => { :activity_id => 9 }
360 assert_response 403
360 assert_response 403
361 end
361 end
362
362
363 def test_bulk_update_custom_field
363 def test_bulk_update_custom_field
364 @request.session[:user_id] = 2
364 @request.session[:user_id] = 2
365 post :bulk_update, :ids => [1, 2], :time_entry => { :custom_field_values => {'10' => '0'} }
365 post :bulk_update, :ids => [1, 2], :time_entry => { :custom_field_values => {'10' => '0'} }
366
366
367 assert_response 302
367 assert_response 302
368 assert_equal ["0", "0"], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.custom_value_for(10).value}
368 assert_equal ["0", "0"], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.custom_value_for(10).value}
369 end
369 end
370
370
371 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
371 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
372 @request.session[:user_id] = 2
372 @request.session[:user_id] = 2
373 post :bulk_update, :ids => [1,2], :back_url => '/time_entries'
373 post :bulk_update, :ids => [1,2], :back_url => '/time_entries'
374
374
375 assert_response :redirect
375 assert_response :redirect
376 assert_redirected_to '/time_entries'
376 assert_redirected_to '/time_entries'
377 end
377 end
378
378
379 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
379 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
380 @request.session[:user_id] = 2
380 @request.session[:user_id] = 2
381 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
381 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
382
382
383 assert_response :redirect
383 assert_response :redirect
384 assert_redirected_to :controller => 'timelog', :action => 'index', :project_id => Project.find(1).identifier
384 assert_redirected_to :controller => 'timelog', :action => 'index', :project_id => Project.find(1).identifier
385 end
385 end
386
386
387 def test_post_bulk_update_without_edit_permission_should_be_denied
387 def test_post_bulk_update_without_edit_permission_should_be_denied
388 @request.session[:user_id] = 2
388 @request.session[:user_id] = 2
389 Role.find_by_name('Manager').remove_permission! :edit_time_entries
389 Role.find_by_name('Manager').remove_permission! :edit_time_entries
390 post :bulk_update, :ids => [1,2]
390 post :bulk_update, :ids => [1,2]
391
391
392 assert_response 403
392 assert_response 403
393 end
393 end
394
394
395 def test_destroy
395 def test_destroy
396 @request.session[:user_id] = 2
396 @request.session[:user_id] = 2
397 delete :destroy, :id => 1
397 delete :destroy, :id => 1
398 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
398 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
399 assert_equal I18n.t(:notice_successful_delete), flash[:notice]
399 assert_equal I18n.t(:notice_successful_delete), flash[:notice]
400 assert_nil TimeEntry.find_by_id(1)
400 assert_nil TimeEntry.find_by_id(1)
401 end
401 end
402
402
403 def test_destroy_should_fail
403 def test_destroy_should_fail
404 # simulate that this fails (e.g. due to a plugin), see #5700
404 # simulate that this fails (e.g. due to a plugin), see #5700
405 TimeEntry.any_instance.expects(:destroy).returns(false)
405 TimeEntry.any_instance.expects(:destroy).returns(false)
406
406
407 @request.session[:user_id] = 2
407 @request.session[:user_id] = 2
408 delete :destroy, :id => 1
408 delete :destroy, :id => 1
409 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
409 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
410 assert_equal I18n.t(:notice_unable_delete_time_entry), flash[:error]
410 assert_equal I18n.t(:notice_unable_delete_time_entry), flash[:error]
411 assert_not_nil TimeEntry.find_by_id(1)
411 assert_not_nil TimeEntry.find_by_id(1)
412 end
412 end
413
413
414 def test_index_all_projects
414 def test_index_all_projects
415 get :index
415 get :index
416 assert_response :success
416 assert_response :success
417 assert_template 'index'
417 assert_template 'index'
418 assert_not_nil assigns(:total_hours)
418 assert_not_nil assigns(:total_hours)
419 assert_equal "162.90", "%.2f" % assigns(:total_hours)
419 assert_equal "162.90", "%.2f" % assigns(:total_hours)
420 assert_tag :form,
420 assert_tag :form,
421 :attributes => {:action => "/time_entries", :id => 'query_form'}
421 :attributes => {:action => "/time_entries", :id => 'query_form'}
422 end
422 end
423
423
424 def test_index_all_projects_should_show_log_time_link
424 def test_index_all_projects_should_show_log_time_link
425 @request.session[:user_id] = 2
425 @request.session[:user_id] = 2
426 get :index
426 get :index
427 assert_response :success
427 assert_response :success
428 assert_template 'index'
428 assert_template 'index'
429 assert_tag 'a', :attributes => {:href => '/time_entries/new'}, :content => /Log time/
429 assert_tag 'a', :attributes => {:href => '/time_entries/new'}, :content => /Log time/
430 end
430 end
431
431
432 def test_index_my_spent_time
432 def test_index_my_spent_time
433 @request.session[:user_id] = 2
433 @request.session[:user_id] = 2
434 get :index, :user_id => 'me'
434 get :index, :user_id => 'me'
435 assert_response :success
435 assert_response :success
436 assert_template 'index'
436 assert_template 'index'
437 assert assigns(:entries).all? {|entry| entry.user_id == 2}
437 assert assigns(:entries).all? {|entry| entry.user_id == 2}
438 end
438 end
439
439
440 def test_index_at_project_level
440 def test_index_at_project_level
441 get :index, :project_id => 'ecookbook'
441 get :index, :project_id => 'ecookbook'
442 assert_response :success
442 assert_response :success
443 assert_template 'index'
443 assert_template 'index'
444 assert_not_nil assigns(:entries)
444 assert_not_nil assigns(:entries)
445 assert_equal 4, assigns(:entries).size
445 assert_equal 4, assigns(:entries).size
446 # project and subproject
446 # project and subproject
447 assert_equal [1, 3], assigns(:entries).collect(&:project_id).uniq.sort
447 assert_equal [1, 3], assigns(:entries).collect(&:project_id).uniq.sort
448 assert_not_nil assigns(:total_hours)
448 assert_not_nil assigns(:total_hours)
449 assert_equal "162.90", "%.2f" % assigns(:total_hours)
449 assert_equal "162.90", "%.2f" % assigns(:total_hours)
450 assert_tag :form,
450 assert_tag :form,
451 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
451 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
452 end
452 end
453
453
454 def test_index_with_display_subprojects_issues_to_false_should_not_include_subproject_entries
454 def test_index_with_display_subprojects_issues_to_false_should_not_include_subproject_entries
455 entry = TimeEntry.generate!(:project => Project.find(3))
455 entry = TimeEntry.generate!(:project => Project.find(3))
456
456
457 with_settings :display_subprojects_issues => '0' do
457 with_settings :display_subprojects_issues => '0' do
458 get :index, :project_id => 'ecookbook'
458 get :index, :project_id => 'ecookbook'
459 assert_response :success
459 assert_response :success
460 assert_template 'index'
460 assert_template 'index'
461 assert_not_include entry, assigns(:entries)
461 assert_not_include entry, assigns(:entries)
462 end
462 end
463 end
463 end
464
464
465 def test_index_with_display_subprojects_issues_to_false_and_subproject_filter_should_include_subproject_entries
465 def test_index_with_display_subprojects_issues_to_false_and_subproject_filter_should_include_subproject_entries
466 entry = TimeEntry.generate!(:project => Project.find(3))
466 entry = TimeEntry.generate!(:project => Project.find(3))
467
467
468 with_settings :display_subprojects_issues => '0' do
468 with_settings :display_subprojects_issues => '0' do
469 get :index, :project_id => 'ecookbook', :subproject_id => 3
469 get :index, :project_id => 'ecookbook', :subproject_id => 3
470 assert_response :success
470 assert_response :success
471 assert_template 'index'
471 assert_template 'index'
472 assert_include entry, assigns(:entries)
472 assert_include entry, assigns(:entries)
473 end
473 end
474 end
474 end
475
475
476 def test_index_at_project_level_with_date_range
476 def test_index_at_project_level_with_date_range
477 get :index, :project_id => 'ecookbook',
477 get :index, :project_id => 'ecookbook',
478 :f => ['spent_on'],
478 :f => ['spent_on'],
479 :op => {'spent_on' => '><'},
479 :op => {'spent_on' => '><'},
480 :v => {'spent_on' => ['2007-03-20', '2007-04-30']}
480 :v => {'spent_on' => ['2007-03-20', '2007-04-30']}
481 assert_response :success
481 assert_response :success
482 assert_template 'index'
482 assert_template 'index'
483 assert_not_nil assigns(:entries)
483 assert_not_nil assigns(:entries)
484 assert_equal 3, assigns(:entries).size
484 assert_equal 3, assigns(:entries).size
485 assert_not_nil assigns(:total_hours)
485 assert_not_nil assigns(:total_hours)
486 assert_equal "12.90", "%.2f" % assigns(:total_hours)
486 assert_equal "12.90", "%.2f" % assigns(:total_hours)
487 assert_tag :form,
487 assert_tag :form,
488 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
488 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
489 end
489 end
490
490
491 def test_index_at_project_level_with_date_range_using_from_and_to_params
491 def test_index_at_project_level_with_date_range_using_from_and_to_params
492 get :index, :project_id => 'ecookbook', :from => '2007-03-20', :to => '2007-04-30'
492 get :index, :project_id => 'ecookbook', :from => '2007-03-20', :to => '2007-04-30'
493 assert_response :success
493 assert_response :success
494 assert_template 'index'
494 assert_template 'index'
495 assert_not_nil assigns(:entries)
495 assert_not_nil assigns(:entries)
496 assert_equal 3, assigns(:entries).size
496 assert_equal 3, assigns(:entries).size
497 assert_not_nil assigns(:total_hours)
497 assert_not_nil assigns(:total_hours)
498 assert_equal "12.90", "%.2f" % assigns(:total_hours)
498 assert_equal "12.90", "%.2f" % assigns(:total_hours)
499 assert_tag :form,
499 assert_tag :form,
500 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
500 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
501 end
501 end
502
502
503 def test_index_at_project_level_with_period
503 def test_index_at_project_level_with_period
504 get :index, :project_id => 'ecookbook',
504 get :index, :project_id => 'ecookbook',
505 :f => ['spent_on'],
505 :f => ['spent_on'],
506 :op => {'spent_on' => '>t-'},
506 :op => {'spent_on' => '>t-'},
507 :v => {'spent_on' => ['7']}
507 :v => {'spent_on' => ['7']}
508 assert_response :success
508 assert_response :success
509 assert_template 'index'
509 assert_template 'index'
510 assert_not_nil assigns(:entries)
510 assert_not_nil assigns(:entries)
511 assert_not_nil assigns(:total_hours)
511 assert_not_nil assigns(:total_hours)
512 assert_tag :form,
512 assert_tag :form,
513 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
513 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
514 end
514 end
515
515
516 def test_index_at_issue_level
516 def test_index_at_issue_level
517 get :index, :issue_id => 1
517 get :index, :issue_id => 1
518 assert_response :success
518 assert_response :success
519 assert_template 'index'
519 assert_template 'index'
520 assert_not_nil assigns(:entries)
520 assert_not_nil assigns(:entries)
521 assert_equal 2, assigns(:entries).size
521 assert_equal 2, assigns(:entries).size
522 assert_not_nil assigns(:total_hours)
522 assert_not_nil assigns(:total_hours)
523 assert_equal 154.25, assigns(:total_hours)
523 assert_equal 154.25, assigns(:total_hours)
524 # display all time
524 # display all time
525 assert_nil assigns(:from)
525 assert_nil assigns(:from)
526 assert_nil assigns(:to)
526 assert_nil assigns(:to)
527 # TODO: remove /projects/:project_id/issues/:issue_id/time_entries routes
527 # TODO: remove /projects/:project_id/issues/:issue_id/time_entries routes
528 # to use /issues/:issue_id/time_entries
528 # to use /issues/:issue_id/time_entries
529 assert_tag :form,
529 assert_tag :form,
530 :attributes => {:action => "/projects/ecookbook/issues/1/time_entries", :id => 'query_form'}
530 :attributes => {:action => "/projects/ecookbook/issues/1/time_entries", :id => 'query_form'}
531 end
531 end
532
532
533 def test_index_should_sort_by_spent_on_and_created_on
533 def test_index_should_sort_by_spent_on_and_created_on
534 t1 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:00:00', :activity_id => 10)
534 t1 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:00:00', :activity_id => 10)
535 t2 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:05:00', :activity_id => 10)
535 t2 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:05:00', :activity_id => 10)
536 t3 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-15', :created_on => '2012-06-16 20:10:00', :activity_id => 10)
536 t3 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-15', :created_on => '2012-06-16 20:10:00', :activity_id => 10)
537
537
538 get :index, :project_id => 1,
538 get :index, :project_id => 1,
539 :f => ['spent_on'],
539 :f => ['spent_on'],
540 :op => {'spent_on' => '><'},
540 :op => {'spent_on' => '><'},
541 :v => {'spent_on' => ['2012-06-15', '2012-06-16']}
541 :v => {'spent_on' => ['2012-06-15', '2012-06-16']}
542 assert_response :success
542 assert_response :success
543 assert_equal [t2, t1, t3], assigns(:entries)
543 assert_equal [t2, t1, t3], assigns(:entries)
544
544
545 get :index, :project_id => 1,
545 get :index, :project_id => 1,
546 :f => ['spent_on'],
546 :f => ['spent_on'],
547 :op => {'spent_on' => '><'},
547 :op => {'spent_on' => '><'},
548 :v => {'spent_on' => ['2012-06-15', '2012-06-16']},
548 :v => {'spent_on' => ['2012-06-15', '2012-06-16']},
549 :sort => 'spent_on'
549 :sort => 'spent_on'
550 assert_response :success
550 assert_response :success
551 assert_equal [t3, t1, t2], assigns(:entries)
551 assert_equal [t3, t1, t2], assigns(:entries)
552 end
552 end
553
553
554 def test_index_with_filter_on_issue_custom_field
554 def test_index_with_filter_on_issue_custom_field
555 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {2 => 'filter_on_issue_custom_field'})
555 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {2 => 'filter_on_issue_custom_field'})
556 entry = TimeEntry.generate!(:issue => issue, :hours => 2.5)
556 entry = TimeEntry.generate!(:issue => issue, :hours => 2.5)
557
557
558 get :index, :f => ['issue.cf_2'], :op => {'issue.cf_2' => '='}, :v => {'issue.cf_2' => ['filter_on_issue_custom_field']}
558 get :index, :f => ['issue.cf_2'], :op => {'issue.cf_2' => '='}, :v => {'issue.cf_2' => ['filter_on_issue_custom_field']}
559 assert_response :success
559 assert_response :success
560 assert_equal [entry], assigns(:entries)
560 assert_equal [entry], assigns(:entries)
561 end
561 end
562
562
563 def test_index_with_issue_custom_field_column
563 def test_index_with_issue_custom_field_column
564 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {2 => 'filter_on_issue_custom_field'})
564 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {2 => 'filter_on_issue_custom_field'})
565 entry = TimeEntry.generate!(:issue => issue, :hours => 2.5)
565 entry = TimeEntry.generate!(:issue => issue, :hours => 2.5)
566
566
567 get :index, :c => %w(project spent_on issue comments hours issue.cf_2)
567 get :index, :c => %w(project spent_on issue comments hours issue.cf_2)
568 assert_response :success
568 assert_response :success
569 assert_include :'issue.cf_2', assigns(:query).column_names
569 assert_include :'issue.cf_2', assigns(:query).column_names
570 assert_select 'td.issue_cf_2', :text => 'filter_on_issue_custom_field'
570 assert_select 'td.issue_cf_2', :text => 'filter_on_issue_custom_field'
571 end
571 end
572
572
573 def test_index_with_time_entry_custom_field_column
573 def test_index_with_time_entry_custom_field_column
574 field = TimeEntryCustomField.generate!(:field_format => 'string')
574 field = TimeEntryCustomField.generate!(:field_format => 'string')
575 entry = TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value'})
575 entry = TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value'})
576 field_name = "cf_#{field.id}"
576 field_name = "cf_#{field.id}"
577
577
578 get :index, :c => ["hours", field_name]
578 get :index, :c => ["hours", field_name]
579 assert_response :success
579 assert_response :success
580 assert_include field_name.to_sym, assigns(:query).column_names
580 assert_include field_name.to_sym, assigns(:query).column_names
581 assert_select "td.#{field_name}", :text => 'CF Value'
581 assert_select "td.#{field_name}", :text => 'CF Value'
582 end
582 end
583
583
584 def test_index_with_time_entry_custom_field_sorting
584 def test_index_with_time_entry_custom_field_sorting
585 field = TimeEntryCustomField.generate!(:field_format => 'string', :name => 'String Field')
585 field = TimeEntryCustomField.generate!(:field_format => 'string', :name => 'String Field')
586 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 1'})
586 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 1'})
587 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 3'})
587 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 3'})
588 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 2'})
588 TimeEntry.generate!(:hours => 2.5, :custom_field_values => {field.id => 'CF Value 2'})
589 field_name = "cf_#{field.id}"
589 field_name = "cf_#{field.id}"
590
590
591 get :index, :c => ["hours", field_name], :sort => field_name
591 get :index, :c => ["hours", field_name], :sort => field_name
592 assert_response :success
592 assert_response :success
593 assert_include field_name.to_sym, assigns(:query).column_names
593 assert_include field_name.to_sym, assigns(:query).column_names
594 assert_select "th a.sort", :text => 'String Field'
594 assert_select "th a.sort", :text => 'String Field'
595
595
596 # Make sure that values are properly sorted
596 # Make sure that values are properly sorted
597 values = assigns(:entries).map {|e| e.custom_field_value(field)}.compact
597 values = assigns(:entries).map {|e| e.custom_field_value(field)}.compact
598 assert_equal 3, values.size
598 assert_equal 3, values.size
599 assert_equal values.sort, values
599 assert_equal values.sort, values
600 end
600 end
601
601
602 def test_index_atom_feed
602 def test_index_atom_feed
603 get :index, :project_id => 1, :format => 'atom'
603 get :index, :project_id => 1, :format => 'atom'
604 assert_response :success
604 assert_response :success
605 assert_equal 'application/atom+xml', @response.content_type
605 assert_equal 'application/atom+xml', @response.content_type
606 assert_not_nil assigns(:items)
606 assert_not_nil assigns(:items)
607 assert assigns(:items).first.is_a?(TimeEntry)
607 assert assigns(:items).first.is_a?(TimeEntry)
608 end
608 end
609
609
610 def test_index_at_project_level_should_include_csv_export_dialog
610 def test_index_at_project_level_should_include_csv_export_dialog
611 get :index, :project_id => 'ecookbook',
611 get :index, :project_id => 'ecookbook',
612 :f => ['spent_on'],
612 :f => ['spent_on'],
613 :op => {'spent_on' => '>='},
613 :op => {'spent_on' => '>='},
614 :v => {'spent_on' => ['2007-04-01']},
614 :v => {'spent_on' => ['2007-04-01']},
615 :c => ['spent_on', 'user']
615 :c => ['spent_on', 'user']
616 assert_response :success
616 assert_response :success
617
617
618 assert_select '#csv-export-options' do
618 assert_select '#csv-export-options' do
619 assert_select 'form[action=?][method=get]', '/projects/ecookbook/time_entries.csv' do
619 assert_select 'form[action=?][method=get]', '/projects/ecookbook/time_entries.csv' do
620 # filter
620 # filter
621 assert_select 'input[name=?][value=?]', 'f[]', 'spent_on'
621 assert_select 'input[name=?][value=?]', 'f[]', 'spent_on'
622 assert_select 'input[name=?][value=?]', 'op[spent_on]', '&gt;='
622 assert_select 'input[name=?][value=?]', 'op[spent_on]', '&gt;='
623 assert_select 'input[name=?][value=?]', 'v[spent_on][]', '2007-04-01'
623 assert_select 'input[name=?][value=?]', 'v[spent_on][]', '2007-04-01'
624 # columns
624 # columns
625 assert_select 'input[name=?][value=?]', 'c[]', 'spent_on'
625 assert_select 'input[name=?][value=?]', 'c[]', 'spent_on'
626 assert_select 'input[name=?][value=?]', 'c[]', 'user'
626 assert_select 'input[name=?][value=?]', 'c[]', 'user'
627 assert_select 'input[name=?]', 'c[]', 2
627 assert_select 'input[name=?]', 'c[]', 2
628 end
628 end
629 end
629 end
630 end
630 end
631
631
632 def test_index_cross_project_should_include_csv_export_dialog
632 def test_index_cross_project_should_include_csv_export_dialog
633 get :index
633 get :index
634 assert_response :success
634 assert_response :success
635
635
636 assert_select '#csv-export-options' do
636 assert_select '#csv-export-options' do
637 assert_select 'form[action=?][method=get]', '/time_entries.csv'
637 assert_select 'form[action=?][method=get]', '/time_entries.csv'
638 end
638 end
639 end
639 end
640
640
641 def test_index_at_issue_level_should_include_csv_export_dialog
641 def test_index_at_issue_level_should_include_csv_export_dialog
642 get :index, :project_id => 'ecookbook', :issue_id => 3
642 get :index, :project_id => 'ecookbook', :issue_id => 3
643 assert_response :success
643 assert_response :success
644
644
645 assert_select '#csv-export-options' do
645 assert_select '#csv-export-options' do
646 assert_select 'form[action=?][method=get]', '/projects/ecookbook/issues/3/time_entries.csv'
646 assert_select 'form[action=?][method=get]', '/projects/ecookbook/issues/3/time_entries.csv'
647 end
647 end
648 end
648 end
649
649
650 def test_index_csv_all_projects
650 def test_index_csv_all_projects
651 Setting.date_format = '%m/%d/%Y'
651 Setting.date_format = '%m/%d/%Y'
652 get :index, :format => 'csv'
652 get :index, :format => 'csv'
653 assert_response :success
653 assert_response :success
654 assert_equal 'text/csv; header=present', response.content_type
654 assert_equal 'text/csv; header=present', response.content_type
655 end
655 end
656
656
657 def test_index_csv
657 def test_index_csv
658 Setting.date_format = '%m/%d/%Y'
658 Setting.date_format = '%m/%d/%Y'
659 get :index, :project_id => 1, :format => 'csv'
659 get :index, :project_id => 1, :format => 'csv'
660 assert_response :success
660 assert_response :success
661 assert_equal 'text/csv; header=present', response.content_type
661 assert_equal 'text/csv; header=present', response.content_type
662 end
662 end
663 end
663 end
General Comments 0
You need to be logged in to leave comments. Login now