##// END OF EJS Templates
Don't render the issue form if issue.project is nil (#19276)....
Jean-Philippe Lang -
r13764:ea099fb771a8
parent child
Show More

The requested changes are too big and content was truncated. Show full diff

@@ -1,508 +1,514
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 24 before_filter :authorize, :except => [:index, :new, :create]
25 25 before_filter :find_optional_project, :only => [:index, :new, :create]
26 26 before_filter :build_new_issue_from_params, :only => [:new, :create]
27 27 accept_rss_auth :index, :show
28 28 accept_api_auth :index, :show, :create, :update, :destroy
29 29
30 30 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
31 31
32 32 helper :journals
33 33 helper :projects
34 34 helper :custom_fields
35 35 helper :issue_relations
36 36 helper :watchers
37 37 helper :attachments
38 38 helper :queries
39 39 include QueriesHelper
40 40 helper :repositories
41 41 helper :sort
42 42 include SortHelper
43 43 helper :timelog
44 44
45 45 def index
46 46 retrieve_query
47 47 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
48 48 sort_update(@query.sortable_columns)
49 49 @query.sort_criteria = sort_criteria.to_a
50 50
51 51 if @query.valid?
52 52 case params[:format]
53 53 when 'csv', 'pdf'
54 54 @limit = Setting.issues_export_limit.to_i
55 55 if params[:columns] == 'all'
56 56 @query.column_names = @query.available_inline_columns.map(&:name)
57 57 end
58 58 when 'atom'
59 59 @limit = Setting.feeds_limit.to_i
60 60 when 'xml', 'json'
61 61 @offset, @limit = api_offset_and_limit
62 62 @query.column_names = %w(author)
63 63 else
64 64 @limit = per_page_option
65 65 end
66 66
67 67 @issue_count = @query.issue_count
68 68 @issue_pages = Paginator.new @issue_count, @limit, params['page']
69 69 @offset ||= @issue_pages.offset
70 70 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
71 71 :order => sort_clause,
72 72 :offset => @offset,
73 73 :limit => @limit)
74 74 @issue_count_by_group = @query.issue_count_by_group
75 75
76 76 respond_to do |format|
77 77 format.html { render :template => 'issues/index', :layout => !request.xhr? }
78 78 format.api {
79 79 Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
80 80 }
81 81 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
82 82 format.csv { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') }
83 83 format.pdf { send_file_headers! :type => 'application/pdf', :filename => 'issues.pdf' }
84 84 end
85 85 else
86 86 respond_to do |format|
87 87 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
88 88 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
89 89 format.api { render_validation_errors(@query) }
90 90 end
91 91 end
92 92 rescue ActiveRecord::RecordNotFound
93 93 render_404
94 94 end
95 95
96 96 def show
97 97 @journals = @issue.journals.includes(:user, :details).
98 98 references(:user, :details).
99 99 reorder("#{Journal.table_name}.id ASC").to_a
100 100 @journals.each_with_index {|j,i| j.indice = i+1}
101 101 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
102 102 Journal.preload_journals_details_custom_fields(@journals)
103 103 @journals.select! {|journal| journal.notes? || journal.visible_details.any?}
104 104 @journals.reverse! if User.current.wants_comments_in_reverse_order?
105 105
106 106 @changesets = @issue.changesets.visible.to_a
107 107 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
108 108
109 109 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
110 110 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
111 111 @priorities = IssuePriority.active
112 112 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
113 113 @relation = IssueRelation.new
114 114
115 115 respond_to do |format|
116 116 format.html {
117 117 retrieve_previous_and_next_issue_ids
118 118 render :template => 'issues/show'
119 119 }
120 120 format.api
121 121 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
122 122 format.pdf {
123 123 send_file_headers! :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf"
124 124 }
125 125 end
126 126 end
127 127
128 128 def new
129 129 respond_to do |format|
130 130 format.html { render :action => 'new', :layout => !request.xhr? }
131 131 format.js
132 132 end
133 133 end
134 134
135 135 def create
136 136 unless User.current.allowed_to?(:add_issues, @issue.project, :global => true)
137 137 raise ::Unauthorized
138 138 end
139 139 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
140 140 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
141 141 if @issue.save
142 142 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
143 143 respond_to do |format|
144 144 format.html {
145 145 render_attachment_warning_if_needed(@issue)
146 146 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
147 147 redirect_after_create
148 148 }
149 149 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
150 150 end
151 151 return
152 152 else
153 153 respond_to do |format|
154 format.html { render :action => 'new' }
154 format.html {
155 if @issue.project.nil?
156 render_error :status => 422
157 else
158 render :action => 'new'
159 end
160 }
155 161 format.api { render_validation_errors(@issue) }
156 162 end
157 163 end
158 164 end
159 165
160 166 def edit
161 167 return unless update_issue_from_params
162 168
163 169 respond_to do |format|
164 170 format.html { }
165 171 format.js
166 172 end
167 173 end
168 174
169 175 def update
170 176 return unless update_issue_from_params
171 177 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
172 178 saved = false
173 179 begin
174 180 saved = save_issue_with_child_records
175 181 rescue ActiveRecord::StaleObjectError
176 182 @conflict = true
177 183 if params[:last_journal_id]
178 184 @conflict_journals = @issue.journals_after(params[:last_journal_id]).to_a
179 185 @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
180 186 end
181 187 end
182 188
183 189 if saved
184 190 render_attachment_warning_if_needed(@issue)
185 191 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
186 192
187 193 respond_to do |format|
188 194 format.html { redirect_back_or_default issue_path(@issue) }
189 195 format.api { render_api_ok }
190 196 end
191 197 else
192 198 respond_to do |format|
193 199 format.html { render :action => 'edit' }
194 200 format.api { render_validation_errors(@issue) }
195 201 end
196 202 end
197 203 end
198 204
199 205 # Bulk edit/copy a set of issues
200 206 def bulk_edit
201 207 @issues.sort!
202 208 @copy = params[:copy].present?
203 209 @notes = params[:notes]
204 210
205 211 if @copy
206 212 unless User.current.allowed_to?(:copy_issues, @projects)
207 213 raise ::Unauthorized
208 214 end
209 215 end
210 216
211 217 @allowed_projects = Issue.allowed_target_projects
212 218 if params[:issue]
213 219 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
214 220 if @target_project
215 221 target_projects = [@target_project]
216 222 end
217 223 end
218 224 target_projects ||= @projects
219 225
220 226 if @copy
221 227 # Copied issues will get their default statuses
222 228 @available_statuses = []
223 229 else
224 230 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
225 231 end
226 232 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields.visible}.reduce(:&)
227 233 @assignables = target_projects.map(&:assignable_users).reduce(:&)
228 234 @trackers = target_projects.map(&:trackers).reduce(:&)
229 235 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
230 236 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
231 237 if @copy
232 238 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
233 239 @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
234 240 end
235 241
236 242 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
237 243
238 244 @issue_params = params[:issue] || {}
239 245 @issue_params[:custom_field_values] ||= {}
240 246 end
241 247
242 248 def bulk_update
243 249 @issues.sort!
244 250 @copy = params[:copy].present?
245 251 attributes = parse_params_for_bulk_issue_attributes(params)
246 252
247 253 if @copy
248 254 unless User.current.allowed_to?(:copy_issues, @projects)
249 255 raise ::Unauthorized
250 256 end
251 257 target_projects = @projects
252 258 if attributes['project_id'].present?
253 259 target_projects = Project.where(:id => attributes['project_id']).to_a
254 260 end
255 261 unless User.current.allowed_to?(:add_issues, target_projects)
256 262 raise ::Unauthorized
257 263 end
258 264 end
259 265
260 266 unsaved_issues = []
261 267 saved_issues = []
262 268
263 269 if @copy && params[:copy_subtasks].present?
264 270 # Descendant issues will be copied with the parent task
265 271 # Don't copy them twice
266 272 @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
267 273 end
268 274
269 275 @issues.each do |orig_issue|
270 276 orig_issue.reload
271 277 if @copy
272 278 issue = orig_issue.copy({},
273 279 :attachments => params[:copy_attachments].present?,
274 280 :subtasks => params[:copy_subtasks].present?,
275 281 :link => link_copy?(params[:link_copy])
276 282 )
277 283 else
278 284 issue = orig_issue
279 285 end
280 286 journal = issue.init_journal(User.current, params[:notes])
281 287 issue.safe_attributes = attributes
282 288 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
283 289 if issue.save
284 290 saved_issues << issue
285 291 else
286 292 unsaved_issues << orig_issue
287 293 end
288 294 end
289 295
290 296 if unsaved_issues.empty?
291 297 flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
292 298 if params[:follow]
293 299 if @issues.size == 1 && saved_issues.size == 1
294 300 redirect_to issue_path(saved_issues.first)
295 301 elsif saved_issues.map(&:project).uniq.size == 1
296 302 redirect_to project_issues_path(saved_issues.map(&:project).first)
297 303 end
298 304 else
299 305 redirect_back_or_default _project_issues_path(@project)
300 306 end
301 307 else
302 308 @saved_issues = @issues
303 309 @unsaved_issues = unsaved_issues
304 310 @issues = Issue.visible.where(:id => @unsaved_issues.map(&:id)).to_a
305 311 bulk_edit
306 312 render :action => 'bulk_edit'
307 313 end
308 314 end
309 315
310 316 def destroy
311 317 @hours = TimeEntry.where(:issue_id => @issues.map(&:id)).sum(:hours).to_f
312 318 if @hours > 0
313 319 case params[:todo]
314 320 when 'destroy'
315 321 # nothing to do
316 322 when 'nullify'
317 323 TimeEntry.where(['issue_id IN (?)', @issues]).update_all('issue_id = NULL')
318 324 when 'reassign'
319 325 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
320 326 if reassign_to.nil?
321 327 flash.now[:error] = l(:error_issue_not_found_in_project)
322 328 return
323 329 else
324 330 TimeEntry.where(['issue_id IN (?)', @issues]).
325 331 update_all("issue_id = #{reassign_to.id}")
326 332 end
327 333 else
328 334 # display the destroy form if it's a user request
329 335 return unless api_request?
330 336 end
331 337 end
332 338 @issues.each do |issue|
333 339 begin
334 340 issue.reload.destroy
335 341 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
336 342 # nothing to do, issue was already deleted (eg. by a parent)
337 343 end
338 344 end
339 345 respond_to do |format|
340 346 format.html { redirect_back_or_default _project_issues_path(@project) }
341 347 format.api { render_api_ok }
342 348 end
343 349 end
344 350
345 351 private
346 352
347 353 def retrieve_previous_and_next_issue_ids
348 354 retrieve_query_from_session
349 355 if @query
350 356 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
351 357 sort_update(@query.sortable_columns, 'issues_index_sort')
352 358 limit = 500
353 359 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
354 360 if (idx = issue_ids.index(@issue.id)) && idx < limit
355 361 if issue_ids.size < 500
356 362 @issue_position = idx + 1
357 363 @issue_count = issue_ids.size
358 364 end
359 365 @prev_issue_id = issue_ids[idx - 1] if idx > 0
360 366 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
361 367 end
362 368 end
363 369 end
364 370
365 371 # Used by #edit and #update to set some common instance variables
366 372 # from the params
367 373 def update_issue_from_params
368 374 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
369 375 if params[:time_entry]
370 376 @time_entry.attributes = params[:time_entry]
371 377 end
372 378
373 379 @issue.init_journal(User.current)
374 380
375 381 issue_attributes = params[:issue]
376 382 if issue_attributes && params[:conflict_resolution]
377 383 case params[:conflict_resolution]
378 384 when 'overwrite'
379 385 issue_attributes = issue_attributes.dup
380 386 issue_attributes.delete(:lock_version)
381 387 when 'add_notes'
382 388 issue_attributes = issue_attributes.slice(:notes)
383 389 when 'cancel'
384 390 redirect_to issue_path(@issue)
385 391 return false
386 392 end
387 393 end
388 394 @issue.safe_attributes = issue_attributes
389 395 @priorities = IssuePriority.active
390 396 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
391 397 true
392 398 end
393 399
394 400 # Used by #new and #create to build a new issue from the params
395 401 # The new issue will be copied from an existing one if copy_from parameter is given
396 402 def build_new_issue_from_params
397 403 @issue = Issue.new
398 404 if params[:copy_from]
399 405 begin
400 406 @issue.init_journal(User.current)
401 407 @copy_from = Issue.visible.find(params[:copy_from])
402 408 unless User.current.allowed_to?(:copy_issues, @copy_from.project)
403 409 raise ::Unauthorized
404 410 end
405 411 @link_copy = link_copy?(params[:link_copy]) || request.get?
406 412 @copy_attachments = params[:copy_attachments].present? || request.get?
407 413 @copy_subtasks = params[:copy_subtasks].present? || request.get?
408 414 @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks, :link => @link_copy)
409 415 rescue ActiveRecord::RecordNotFound
410 416 render_404
411 417 return
412 418 end
413 419 end
414 420 @issue.project = @project
415 421 if request.get?
416 422 @issue.project ||= @issue.allowed_target_projects.first
417 423 end
418 424 @issue.author ||= User.current
419 425 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
420 426
421 427 if attrs = params[:issue].deep_dup
422 428 if params[:was_default_status] == attrs[:status_id]
423 429 attrs.delete(:status_id)
424 430 end
425 431 @issue.safe_attributes = attrs
426 432 end
427 433 if @issue.project
428 434 @issue.tracker ||= @issue.project.trackers.first
429 435 if @issue.tracker.nil?
430 436 render_error l(:error_no_tracker_in_project)
431 437 return false
432 438 end
433 439 if @issue.status.nil?
434 440 render_error l(:error_no_default_issue_status)
435 441 return false
436 442 end
437 443 end
438 444
439 445 @priorities = IssuePriority.active
440 446 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, @issue.new_record?)
441 447 end
442 448
443 449 def parse_params_for_bulk_issue_attributes(params)
444 450 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
445 451 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
446 452 if custom = attributes[:custom_field_values]
447 453 custom.reject! {|k,v| v.blank?}
448 454 custom.keys.each do |k|
449 455 if custom[k].is_a?(Array)
450 456 custom[k] << '' if custom[k].delete('__none__')
451 457 else
452 458 custom[k] = '' if custom[k] == '__none__'
453 459 end
454 460 end
455 461 end
456 462 attributes
457 463 end
458 464
459 465 # Saves @issue and a time_entry from the parameters
460 466 def save_issue_with_child_records
461 467 Issue.transaction do
462 468 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, @issue.project)
463 469 time_entry = @time_entry || TimeEntry.new
464 470 time_entry.project = @issue.project
465 471 time_entry.issue = @issue
466 472 time_entry.user = User.current
467 473 time_entry.spent_on = User.current.today
468 474 time_entry.attributes = params[:time_entry]
469 475 @issue.time_entries << time_entry
470 476 end
471 477
472 478 call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
473 479 if @issue.save
474 480 call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
475 481 else
476 482 raise ActiveRecord::Rollback
477 483 end
478 484 end
479 485 end
480 486
481 487 # Returns true if the issue copy should be linked
482 488 # to the original issue
483 489 def link_copy?(param)
484 490 case Setting.link_copied_issue
485 491 when 'yes'
486 492 true
487 493 when 'no'
488 494 false
489 495 when 'ask'
490 496 param == '1'
491 497 end
492 498 end
493 499
494 500 # Redirects user after a successful issue creation
495 501 def redirect_after_create
496 502 if params[:continue]
497 503 attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
498 504 if params[:project_id]
499 505 redirect_to new_project_issue_path(@issue.project, :issue => attrs)
500 506 else
501 507 attrs.merge! :project_id => @issue.project_id
502 508 redirect_to new_issue_path(:issue => attrs)
503 509 end
504 510 else
505 511 redirect_to issue_path(@issue)
506 512 end
507 513 end
508 514 end
1 NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff
General Comments 0
You need to be logged in to leave comments. Login now