jro_apps/redmine Commit - r12382:e9689f5fe326

Removes duplicate ids (#15485)....

Jean-Philippe Lang -

r12382:e9689f5fe326

parent child

Context file:

r12382:e9689f5fe326

app/views/groups/_memberships.html.erb +2 -2

                              :url => { :action => 'edit_membership', :id => @group, :membership_id => membership },
                              :html => { :id => "member-#{membership.id}-roles-form", :style => 'display:none;'}) do %>
                     <p><% roles.each do |role| %>
-                    <label><%= check_box_tag 'membership[role_ids][]', role.id, membership.roles.include?(role) %> <%=h role %></label><br />
+                    <label><%= check_box_tag 'membership[role_ids][]', role.id, membership.roles.include?(role), :id => nil %> <%=h role %></label><br />
                     <% end %></p>
                     <p><%= submit_tag l(:button_change) %>
                     <%= link_to_function(
             <%= select_tag 'membership[project_id]', options_for_membership_project_select(@group, projects) %>
             <p><%= l(:label_role_plural) %>:
             <% roles.each do |role| %>
-              <label><%= check_box_tag 'membership[role_ids][]', role.id %> <%=h role %></label>
+              <label><%= check_box_tag 'membership[role_ids][]', role.id, false, :id => nil %> <%=h role %></label>
             <% end %></p>
             <p><%= submit_tag l(:button_add) %></p>
             <% end %>

app/views/projects/_form.html.erb +4 -2

             <fieldset class="box tabular" id="project_trackers"><legend><%=l(:label_tracker_plural)%></legend>
             <% @trackers.each do |tracker| %>
                 <label class="floating">
-                <%= check_box_tag 'project[tracker_ids][]', tracker.id, @project.trackers.include?(tracker) %>
+                <%= check_box_tag 'project[tracker_ids][]', tracker.id, @project.trackers.include?(tracker), :id => nil %>
                 <%=h tracker %>
                 </label>
             <% end %>
             <fieldset class="box tabular" id="project_issue_custom_fields"><legend><%=l(:label_custom_field_plural)%></legend>
             <% @issue_custom_fields.each do |custom_field| %>
                 <label class="floating">
-              <%= check_box_tag 'project[issue_custom_field_ids][]', custom_field.id, (@project.all_issue_custom_fields.include? custom_field), (custom_field.is_for_all? ? {:disabled => "disabled"} : {}) %>
+              <%= check_box_tag 'project[issue_custom_field_ids][]', custom_field.id, (@project.all_issue_custom_fields.include? custom_field),
+                    :disabled => (custom_field.is_for_all? ? "disabled" : nil),
+                    :id => nil %>
               <%=h custom_field.name %>
               </label>
             <% end %>

app/views/projects/settings/_members.html.erb +2 -1

                       <label>
                         <%= check_box_tag('membership[role_ids][]',
                                           role.id, member.roles.include?(role),
+                                          :id => nil,
                                           :disabled => member.member_roles.detect {
                                              |mr| mr.role_id == role.id && !mr.inherited_from.nil?
                                              } ) %> <%= role %>
                   <p>
                     <%= l(:label_role_plural) %>:
                     <% roles.each do |role| %>
-                      <label><%= check_box_tag 'membership[role_ids][]', role.id %> <%= role %></label>
+                      <label><%= check_box_tag 'membership[role_ids][]', role.id, false, :id => nil %> <%= role %></label>
                     <% end %>
                   </p>
                   <p><%= submit_tag l(:button_add), :id => 'member-add-submit' %></p>

app/views/projects/settings/_modules.html.erb +1 -1

             <legend><%= l(:text_select_project_modules) %></legend>
             <% Redmine::AccessControl.available_project_modules.each do |m| %>
-            <p><label><%= check_box_tag 'enabled_module_names[]', m, @project.module_enabled?(m) -%>
+            <p><label><%= check_box_tag 'enabled_module_names[]', m, @project.module_enabled?(m), :id => nil -%>
              <%= l_or_humanize(m, :prefix => "project_module_") %></label></p>
             <% end %>
             </fieldset>

app/views/roles/_form.html.erb +1 -1

                 <fieldset><legend><%= mod.blank? ? l(:label_project) : l_or_humanize(mod, :prefix => 'project_module_') %></legend>
                 <% perms_by_module[mod].each do |permission| %>
                     <label class="floating">
-                    <%= check_box_tag 'role[permissions][]', permission.name, (@role.permissions.include? permission.name) %>
+                    <%= check_box_tag 'role[permissions][]', permission.name, (@role.permissions.include? permission.name), :id => nil %>
                     <%= l_or_humanize(permission.name, :prefix => 'permission_') %>
                     </label>
                 <% end %>

app/views/trackers/_form.html.erb +2 -2

               <label><%= l(:field_core_fields) %></label>
               <% Tracker::CORE_FIELDS.each do |field| %>
               <label class="block">
-                <%= check_box_tag 'tracker[core_fields][]', field, @tracker.core_fields.include?(field) %>
+                <%= check_box_tag 'tracker[core_fields][]', field, @tracker.core_fields.include?(field), :id => nil %>
                 <%= l("field_#{field}".sub(/_id$/, '')) %>
               </label>
               <% end %>
               <label><%= l(:label_custom_field_plural) %></label>
               <% IssueCustomField.all.each do |field| %>
                 <label class="block">
-                  <%= check_box_tag 'tracker[custom_field_ids][]',field.id, @tracker.custom_fields.to_a.include?(field) %>
+                  <%= check_box_tag 'tracker[custom_field_ids][]',field.id, @tracker.custom_fields.to_a.include?(field), :id => nil %>
                   <%=h field.name %>
                 </label>
               <% end %>

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages