jro_apps/redmine Commit - r3650:e94c45d54841

Add an "Assigned To" keyword to receiving email. #5594...

Eric Davis -

r3650:e94c45d54841

parent child

Context file:

r3650:e94c45d54841

Collapse all files

app/models/mail_handler.rb +14 -1

                 category = (get_keyword(:category) && project.issue_categories.find_by_name(get_keyword(:category)))
                 priority = (get_keyword(:priority) && IssuePriority.find_by_name(get_keyword(:priority)))
                 status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
+                assigned_to = (get_keyword(:assigned_to, :override => true) && find_user_from_keyword(get_keyword(:assigned_to, :override => true)))
                 due_date = get_keyword(:due_date, :override => true)
                 start_date = get_keyword(:start_date, :override => true)
                   raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
                 end
-                issue = Issue.new(:author => user, :project => project, :tracker => tracker, :category => category, :priority => priority, :due_date => due_date, :start_date => start_date)
+                issue = Issue.new(:author => user, :project => project, :tracker => tracker, :category => category, :priority => priority, :due_date => due_date, :start_date => start_date, :assigned_to => assigned_to)
                 # check workflow
                 if status && issue.new_statuses_allowed_to(user).include?(status)
                   issue.status = status
                 status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
                 due_date = get_keyword(:due_date, :override => true)
                 start_date = get_keyword(:start_date, :override => true)
+                assigned_to = (get_keyword(:assigned_to, :override => true) && find_user_from_keyword(get_keyword(:assigned_to, :override => true)))
                 issue = Issue.find_by_id(issue_id)
                 return unless issue
                 end
                 issue.start_date = start_date if start_date
                 issue.due_date = due_date if due_date
+                issue.assigned_to = assigned_to if assigned_to
                 issue.save!
                 logger.info "MailHandler: issue ##{issue.id} updated by #{user}" if logger && logger.info
                 end
                 body.strip
               end
+              def find_user_from_keyword(keyword)
+                user ||= User.find_by_mail(keyword)
+                user ||= User.find_by_login(keyword)
+                if user.nil? && keyword.match(/ /)
+                  firstname, lastname = *(keyword.split) # "First Last Throwaway"
+                  user ||= User.find_by_firstname_and_lastname(firstname, lastname)
+                end
+                user
+              end
             end

test/fixtures/mail_handler/ticket_on_given_project.eml +2 0

             Status: Resolved
             due date: 2010-12-31
             Start Date:2010-01-01
+            Assigned to: John Smith

test/fixtures/mail_handler/ticket_reply_with_status.eml +1 0

             Status: Resolved
             due date: 2010-12-31
             Start Date:2010-01-01
+            Assigned to: jsmith@somenet.foo
             ------=_NextPart_000_0067_01C8D3CE.711F9CC0
             Content-Type: text/html;

test/unit/mail_handler_test.rb +2 0

                 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                 assert_equal '2010-01-01', issue.start_date.to_s
                 assert_equal '2010-12-31', issue.due_date.to_s
+                assert_equal User.find_by_login('jsmith'), issue.assigned_to
                 # keywords should be removed from the email body
                 assert !issue.description.match(/^Project:/i)
                 assert !issue.description.match(/^Status:/i)
                 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
                 assert_equal '2010-01-01', issue.start_date.to_s
                 assert_equal '2010-12-31', issue.due_date.to_s
+                assert_equal User.find_by_login('jsmith'), issue.assigned_to
               end
               def test_add_issue_note_should_send_email_notification

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages