jro_apps/redmine Commit - r13582:e94920a5ff5a

Allow filtering of Redmine Reminders by Version (#18983)....

Jean-Philippe Lang -

r13582:e94920a5ff5a

parent child

Context file:

r13582:e94920a5ff5a

app/models/mailer.rb +3 0

               # * :tracker  => id of tracker for filtering issues (defaults to all trackers)
               # * :project  => id or identifier of project to process (defaults to all projects)
               # * :users    => array of user/group ids who should be reminded
+              # * :version  => name of target version for filtering issues (defaults to none)
               def self.reminders(options={})
                 days = options[:days] || 7
                 project = options[:project] ? Project.find(options[:project]) : nil
                 tracker = options[:tracker] ? Tracker.find(options[:tracker]) : nil
+                target_versions = options[:version] ? Version.where(name: options[:version]).select(:id).map(&:id) : nil
                 user_ids = options[:users]
                 scope = Issue.open.where("#{Issue.table_name}.assigned_to_id IS NOT NULL" +
                 )
                 scope = scope.where(:assigned_to_id => user_ids) if user_ids.present?
                 scope = scope.where(:project_id => project.id) if project
+                scope = scope.where(:fixed_version_id => target_versions) unless target_versions.blank?
                 scope = scope.where(:tracker_id => tracker.id) if tracker
                 issues_by_assignee = scope.includes(:status, :assigned_to, :project, :tracker).
                                           group_by(&:assigned_to)

lib/tasks/reminder.rake +2 0

               * tracker  => id of tracker (defaults to all trackers)
               * project  => id or identifier of project (defaults to all projects)
               * users    => comma separated list of user/group ids who should be reminded
+              * version  => name of target version for filtering issues (defaults to none)
             Example:
               rake redmine:send_reminders days=7 users="1,23, 56" RAILS_ENV="production"
                 options[:project] = ENV['project'] if ENV['project']
                 options[:tracker] = ENV['tracker'].to_i if ENV['tracker']
                 options[:users] = (ENV['users'] || '').split(',').each(&:strip!)
+                options[:version] = ENV['version'] if ENV['version']
                 Mailer.with_synched_deliveries do
                   Mailer.reminders(options)

test/unit/mailer_test.rb +21 0

@@ -633,6 +633,27 class MailerTest < ActiveSupport::TestCase
633	end	633	end
634	end	634	end
635		635
		636	def test_reminders_for_versions
		637	with_settings :default_language => 'en' do
		638	Mailer.reminders(:days => 42, :users => ['3'])
		639	assert_equal 1, ActionMailer::Base.deliveries.size
		640
		641	ActionMailer::Base.deliveries.clear
		642	Version.create!(name: 'Acme', project_id: 1, sharing: 'none')
		643	Mailer.reminders(:days => 42, :users => ['3'], :version => 'Acme')
		644	assert_equal 0, ActionMailer::Base.deliveries.size
		645	Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1,
		646	:subject => 'Assigned to user', :assigned_to => User.find(3),
		647	:due_date => 5.days.from_now,
		648	:author_id => 2)
		649	Mailer.reminders(:days => 42, :users => ['3'], :version => 'Acme')
		650	assert_equal 1, ActionMailer::Base.deliveries.size
		651
		652	mail = last_email
		653	assert mail.bcc.include?('dlopper@somenet.foo')
		654	end
		655	end
		656
636	def test_mailer_should_not_change_locale	657	def test_mailer_should_not_change_locale
637	# Set current language to italian	658	# Set current language to italian
638	set_language_if_valid 'it'	659	set_language_if_valid 'it'

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages