jro_apps/redmine Commit - r15573:e9184adafc2c

Show action not allowed for time entries in closed projects (#24297)....

Jean-Philippe Lang -

r15573:e9184adafc2c

parent child

Context file:

r15573:e9184adafc2c

app/controllers/timelog_controller.rb +7 -3

               menu_item :time_entries
               before_action :find_time_entry, :only => [:show, :edit, :update]
+              before_action :check_editability, :only => [:edit, :update]
               before_action :find_time_entries, :only => [:bulk_edit, :bulk_update, :destroy]
               before_action :authorize, :only => [:show, :edit, :update, :bulk_edit, :bulk_update, :destroy]
             private
               def find_time_entry
                 @time_entry = TimeEntry.find(params[:id])
+                @project = @time_entry.project
+              rescue ActiveRecord::RecordNotFound
+                render_404
+              end
+              def check_editability
                 unless @time_entry.editable_by?(User.current)
                   render_403
                   return false
                 end
-                @project = @time_entry.project
-              rescue ActiveRecord::RecordNotFound
-                render_404
               end
               def find_time_entries

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages