jro_apps/redmine Commit - r1437:e8d092e46ad8

Fixed: using '*' as keyword for repository referencing keywords doesn't work when issue id is at the beginning of a line (#1253)....

Jean-Philippe Lang -

r1437:e8d092e46ad8

parent child

Context file:

r1437:e8d092e46ad8

app/models/changeset.rb +1 -1

                  if ref_keywords.delete('*')
                    # find any issue ID in the comments
                    target_issue_ids = []
-                   comments.scan(%r{([\s\(,-^])#(\d+)(?=[[:punct:]]|\s|<|$)}).each { |m| target_issue_ids << m[1] }
+                   comments.scan(%r{([\s\(,-]|^)#(\d+)(?=[[:punct:]]|\s|<|$)}).each { |m| target_issue_ids << m[1] }
                    referenced_issues += repository.project.issues.find_all_by_id(target_issue_ids)
                  end

test/unit/changeset_test.rb +11 0

                  assert_equal 90, fixed.done_ratio
                end
+               def test_ref_keywords_any_line_start
+                 Setting.commit_ref_keywords = '*'
+                 c = Changeset.new(:repository => Project.find(1).repository,
+                                   :committed_on => Time.now,
+                                   :comments => '#1 is the reason of this commit')
+                 c.scan_comment_for_issue_ids
+                 assert_equal [1], c.issue_ids.sort
+               end
                def test_previous
                  changeset = Changeset.find_by_revision('3')
                  assert_equal Changeset.find_by_revision('2'), changeset.previous

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages