##// END OF EJS Templates
Merged r12056 from trunk (#14447)....
Jean-Philippe Lang -
r11834:e8757fec2b61
parent child
Show More
@@ -1,1521 +1,1525
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21
22 22 belongs_to :project
23 23 belongs_to :tracker
24 24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30 30
31 31 has_many :journals, :as => :journalized, :dependent => :destroy
32 32 has_many :visible_journals,
33 33 :class_name => 'Journal',
34 34 :as => :journalized,
35 35 :conditions => Proc.new {
36 36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 37 },
38 38 :readonly => true
39 39
40 40 has_many :time_entries, :dependent => :delete_all
41 41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 48 acts_as_customizable
49 49 acts_as_watchable
50 50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 51 :include => [:project, :visible_journals],
52 52 # sort by id so that limited eager loading doesn't break with postgresql
53 53 :order_column => "#{table_name}.id"
54 54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57 57
58 58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 59 :author_key => :author_id
60 60
61 61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62 62
63 63 attr_reader :current_journal
64 64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65 65
66 66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67 67
68 68 validates_length_of :subject, :maximum => 255
69 69 validates_inclusion_of :done_ratio, :in => 0..100
70 70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 71 validates :start_date, :date => true
72 72 validates :due_date, :date => true
73 73 validate :validate_issue, :validate_required_fields
74 74
75 75 scope :visible, lambda {|*args|
76 76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 77 }
78 78
79 79 scope :open, lambda {|*args|
80 80 is_closed = args.size > 0 ? !args.first : false
81 81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 82 }
83 83
84 84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 85 scope :on_active_project, lambda {
86 86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 87 }
88 88 scope :fixed_version, lambda {|versions|
89 89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 91 }
92 92
93 93 before_create :default_assign
94 94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 97 # Should be after_create but would be called before previous after_save callbacks
98 98 after_save :after_create_from_copy
99 99 after_destroy :update_parent_attributes
100 100
101 101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 102 def self.visible_condition(user, options={})
103 103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 104 if user.logged?
105 105 case role.issues_visibility
106 106 when 'all'
107 107 nil
108 108 when 'default'
109 109 user_ids = [user.id] + user.groups.map(&:id)
110 110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 111 when 'own'
112 112 user_ids = [user.id] + user.groups.map(&:id)
113 113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 114 else
115 115 '1=0'
116 116 end
117 117 else
118 118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 119 end
120 120 end
121 121 end
122 122
123 123 # Returns true if usr or current user is allowed to view the issue
124 124 def visible?(usr=nil)
125 125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 126 if user.logged?
127 127 case role.issues_visibility
128 128 when 'all'
129 129 true
130 130 when 'default'
131 131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 132 when 'own'
133 133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 134 else
135 135 false
136 136 end
137 137 else
138 138 !self.is_private?
139 139 end
140 140 end
141 141 end
142 142
143 143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 144 def editable?(user=User.current)
145 145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 146 end
147 147
148 148 def initialize(attributes=nil, *args)
149 149 super
150 150 if new_record?
151 151 # set default values for new records only
152 152 self.status ||= IssueStatus.default
153 153 self.priority ||= IssuePriority.default
154 154 self.watcher_user_ids = []
155 155 end
156 156 end
157 157
158 158 def create_or_update
159 159 super
160 160 ensure
161 161 @status_was = nil
162 162 end
163 163 private :create_or_update
164 164
165 165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 166 # if the issue was already deleted or updated (non matching lock_version).
167 167 # This is a problem when bulk deleting issues or deleting a project
168 168 # (because an issue may already be deleted if its parent was deleted
169 169 # first).
170 170 # The issue is reloaded by the nested_set before being deleted so
171 171 # the lock_version condition should not be an issue but we handle it.
172 172 def destroy
173 173 super
174 174 rescue ActiveRecord::RecordNotFound
175 175 # Stale or already deleted
176 176 begin
177 177 reload
178 178 rescue ActiveRecord::RecordNotFound
179 179 # The issue was actually already deleted
180 180 @destroyed = true
181 181 return freeze
182 182 end
183 183 # The issue was stale, retry to destroy
184 184 super
185 185 end
186 186
187 187 alias :base_reload :reload
188 188 def reload(*args)
189 189 @workflow_rule_by_attribute = nil
190 190 @assignable_versions = nil
191 191 @relations = nil
192 192 base_reload(*args)
193 193 end
194 194
195 195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
196 196 def available_custom_fields
197 197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
198 198 end
199 199
200 200 # Copies attributes from another issue, arg can be an id or an Issue
201 201 def copy_from(arg, options={})
202 202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
203 203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
204 204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
205 205 self.status = issue.status
206 206 self.author = User.current
207 207 unless options[:attachments] == false
208 208 self.attachments = issue.attachments.map do |attachement|
209 209 attachement.copy(:container => self)
210 210 end
211 211 end
212 212 @copied_from = issue
213 213 @copy_options = options
214 214 self
215 215 end
216 216
217 217 # Returns an unsaved copy of the issue
218 218 def copy(attributes=nil, copy_options={})
219 219 copy = self.class.new.copy_from(self, copy_options)
220 220 copy.attributes = attributes if attributes
221 221 copy
222 222 end
223 223
224 224 # Returns true if the issue is a copy
225 225 def copy?
226 226 @copied_from.present?
227 227 end
228 228
229 229 # Moves/copies an issue to a new project and tracker
230 230 # Returns the moved/copied issue on success, false on failure
231 231 def move_to_project(new_project, new_tracker=nil, options={})
232 232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
233 233
234 234 if options[:copy]
235 235 issue = self.copy
236 236 else
237 237 issue = self
238 238 end
239 239
240 240 issue.init_journal(User.current, options[:notes])
241 241
242 242 # Preserve previous behaviour
243 243 # #move_to_project doesn't change tracker automatically
244 244 issue.send :project=, new_project, true
245 245 if new_tracker
246 246 issue.tracker = new_tracker
247 247 end
248 248 # Allow bulk setting of attributes on the issue
249 249 if options[:attributes]
250 250 issue.attributes = options[:attributes]
251 251 end
252 252
253 253 issue.save ? issue : false
254 254 end
255 255
256 256 def status_id=(sid)
257 257 self.status = nil
258 258 result = write_attribute(:status_id, sid)
259 259 @workflow_rule_by_attribute = nil
260 260 result
261 261 end
262 262
263 263 def priority_id=(pid)
264 264 self.priority = nil
265 265 write_attribute(:priority_id, pid)
266 266 end
267 267
268 268 def category_id=(cid)
269 269 self.category = nil
270 270 write_attribute(:category_id, cid)
271 271 end
272 272
273 273 def fixed_version_id=(vid)
274 274 self.fixed_version = nil
275 275 write_attribute(:fixed_version_id, vid)
276 276 end
277 277
278 278 def tracker_id=(tid)
279 279 self.tracker = nil
280 280 result = write_attribute(:tracker_id, tid)
281 281 @custom_field_values = nil
282 282 @workflow_rule_by_attribute = nil
283 283 result
284 284 end
285 285
286 286 def project_id=(project_id)
287 287 if project_id.to_s != self.project_id.to_s
288 288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
289 289 end
290 290 end
291 291
292 292 def project=(project, keep_tracker=false)
293 293 project_was = self.project
294 294 write_attribute(:project_id, project ? project.id : nil)
295 295 association_instance_set('project', project)
296 296 if project_was && project && project_was != project
297 297 @assignable_versions = nil
298 298
299 299 unless keep_tracker || project.trackers.include?(tracker)
300 300 self.tracker = project.trackers.first
301 301 end
302 302 # Reassign to the category with same name if any
303 303 if category
304 304 self.category = project.issue_categories.find_by_name(category.name)
305 305 end
306 306 # Keep the fixed_version if it's still valid in the new_project
307 307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
308 308 self.fixed_version = nil
309 309 end
310 310 # Clear the parent task if it's no longer valid
311 311 unless valid_parent_project?
312 312 self.parent_issue_id = nil
313 313 end
314 314 @custom_field_values = nil
315 315 end
316 316 end
317 317
318 318 def description=(arg)
319 319 if arg.is_a?(String)
320 320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
321 321 end
322 322 write_attribute(:description, arg)
323 323 end
324 324
325 325 # Overrides assign_attributes so that project and tracker get assigned first
326 326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
327 327 return if new_attributes.nil?
328 328 attrs = new_attributes.dup
329 329 attrs.stringify_keys!
330 330
331 331 %w(project project_id tracker tracker_id).each do |attr|
332 332 if attrs.has_key?(attr)
333 333 send "#{attr}=", attrs.delete(attr)
334 334 end
335 335 end
336 336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
337 337 end
338 338 # Do not redefine alias chain on reload (see #4838)
339 339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
340 340
341 341 def estimated_hours=(h)
342 342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
343 343 end
344 344
345 345 safe_attributes 'project_id',
346 346 :if => lambda {|issue, user|
347 347 if issue.new_record?
348 348 issue.copy?
349 349 elsif user.allowed_to?(:move_issues, issue.project)
350 350 projects = Issue.allowed_target_projects_on_move(user)
351 351 projects.include?(issue.project) && projects.size > 1
352 352 end
353 353 }
354 354
355 355 safe_attributes 'tracker_id',
356 356 'status_id',
357 357 'category_id',
358 358 'assigned_to_id',
359 359 'priority_id',
360 360 'fixed_version_id',
361 361 'subject',
362 362 'description',
363 363 'start_date',
364 364 'due_date',
365 365 'done_ratio',
366 366 'estimated_hours',
367 367 'custom_field_values',
368 368 'custom_fields',
369 369 'lock_version',
370 370 'notes',
371 371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
372 372
373 373 safe_attributes 'status_id',
374 374 'assigned_to_id',
375 375 'fixed_version_id',
376 376 'done_ratio',
377 377 'lock_version',
378 378 'notes',
379 379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
380 380
381 381 safe_attributes 'notes',
382 382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
383 383
384 384 safe_attributes 'private_notes',
385 385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
386 386
387 387 safe_attributes 'watcher_user_ids',
388 388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
389 389
390 390 safe_attributes 'is_private',
391 391 :if => lambda {|issue, user|
392 392 user.allowed_to?(:set_issues_private, issue.project) ||
393 393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
394 394 }
395 395
396 396 safe_attributes 'parent_issue_id',
397 397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
398 398 user.allowed_to?(:manage_subtasks, issue.project)}
399 399
400 400 def safe_attribute_names(user=nil)
401 401 names = super
402 402 names -= disabled_core_fields
403 403 names -= read_only_attribute_names(user)
404 404 names
405 405 end
406 406
407 407 # Safely sets attributes
408 408 # Should be called from controllers instead of #attributes=
409 409 # attr_accessible is too rough because we still want things like
410 410 # Issue.new(:project => foo) to work
411 411 def safe_attributes=(attrs, user=User.current)
412 412 return unless attrs.is_a?(Hash)
413 413
414 414 attrs = attrs.dup
415 415
416 416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
417 417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
418 418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
419 419 self.project_id = p
420 420 end
421 421 end
422 422
423 423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
424 424 self.tracker_id = t
425 425 end
426 426
427 427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
428 428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
429 429 self.status_id = s
430 430 end
431 431 end
432 432
433 433 attrs = delete_unsafe_attributes(attrs, user)
434 434 return if attrs.empty?
435 435
436 436 unless leaf?
437 437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
438 438 end
439 439
440 440 if attrs['parent_issue_id'].present?
441 441 s = attrs['parent_issue_id'].to_s
442 442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
443 443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
444 444 end
445 445 end
446 446
447 447 if attrs['custom_field_values'].present?
448 448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
449 449 end
450 450
451 451 if attrs['custom_fields'].present?
452 452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
453 453 end
454 454
455 455 # mass-assignment security bypass
456 456 assign_attributes attrs, :without_protection => true
457 457 end
458 458
459 459 def disabled_core_fields
460 460 tracker ? tracker.disabled_core_fields : []
461 461 end
462 462
463 463 # Returns the custom_field_values that can be edited by the given user
464 464 def editable_custom_field_values(user=nil)
465 465 custom_field_values.reject do |value|
466 466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
467 467 end
468 468 end
469 469
470 470 # Returns the names of attributes that are read-only for user or the current user
471 471 # For users with multiple roles, the read-only fields are the intersection of
472 472 # read-only fields of each role
473 473 # The result is an array of strings where sustom fields are represented with their ids
474 474 #
475 475 # Examples:
476 476 # issue.read_only_attribute_names # => ['due_date', '2']
477 477 # issue.read_only_attribute_names(user) # => []
478 478 def read_only_attribute_names(user=nil)
479 479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
480 480 end
481 481
482 482 # Returns the names of required attributes for user or the current user
483 483 # For users with multiple roles, the required fields are the intersection of
484 484 # required fields of each role
485 485 # The result is an array of strings where sustom fields are represented with their ids
486 486 #
487 487 # Examples:
488 488 # issue.required_attribute_names # => ['due_date', '2']
489 489 # issue.required_attribute_names(user) # => []
490 490 def required_attribute_names(user=nil)
491 491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
492 492 end
493 493
494 494 # Returns true if the attribute is required for user
495 495 def required_attribute?(name, user=nil)
496 496 required_attribute_names(user).include?(name.to_s)
497 497 end
498 498
499 499 # Returns a hash of the workflow rule by attribute for the given user
500 500 #
501 501 # Examples:
502 502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
503 503 def workflow_rule_by_attribute(user=nil)
504 504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
505 505
506 506 user_real = user || User.current
507 507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
508 508 return {} if roles.empty?
509 509
510 510 result = {}
511 511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
512 512 if workflow_permissions.any?
513 513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
514 514 h[wp.field_name] ||= []
515 515 h[wp.field_name] << wp.rule
516 516 h
517 517 end
518 518 workflow_rules.each do |attr, rules|
519 519 next if rules.size < roles.size
520 520 uniq_rules = rules.uniq
521 521 if uniq_rules.size == 1
522 522 result[attr] = uniq_rules.first
523 523 else
524 524 result[attr] = 'required'
525 525 end
526 526 end
527 527 end
528 528 @workflow_rule_by_attribute = result if user.nil?
529 529 result
530 530 end
531 531 private :workflow_rule_by_attribute
532 532
533 533 def done_ratio
534 534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
535 535 status.default_done_ratio
536 536 else
537 537 read_attribute(:done_ratio)
538 538 end
539 539 end
540 540
541 541 def self.use_status_for_done_ratio?
542 542 Setting.issue_done_ratio == 'issue_status'
543 543 end
544 544
545 545 def self.use_field_for_done_ratio?
546 546 Setting.issue_done_ratio == 'issue_field'
547 547 end
548 548
549 549 def validate_issue
550 550 if due_date && start_date && due_date < start_date
551 551 errors.add :due_date, :greater_than_start_date
552 552 end
553 553
554 554 if start_date && soonest_start && start_date < soonest_start
555 555 errors.add :start_date, :invalid
556 556 end
557 557
558 558 if fixed_version
559 559 if !assignable_versions.include?(fixed_version)
560 560 errors.add :fixed_version_id, :inclusion
561 561 elsif reopened? && fixed_version.closed?
562 562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
563 563 end
564 564 end
565 565
566 566 # Checks that the issue can not be added/moved to a disabled tracker
567 567 if project && (tracker_id_changed? || project_id_changed?)
568 568 unless project.trackers.include?(tracker)
569 569 errors.add :tracker_id, :inclusion
570 570 end
571 571 end
572 572
573 573 # Checks parent issue assignment
574 574 if @invalid_parent_issue_id.present?
575 575 errors.add :parent_issue_id, :invalid
576 576 elsif @parent_issue
577 577 if !valid_parent_project?(@parent_issue)
578 578 errors.add :parent_issue_id, :invalid
579 579 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
580 580 errors.add :parent_issue_id, :invalid
581 581 elsif !new_record?
582 582 # moving an existing issue
583 583 if @parent_issue.root_id != root_id
584 584 # we can always move to another tree
585 585 elsif move_possible?(@parent_issue)
586 586 # move accepted inside tree
587 587 else
588 588 errors.add :parent_issue_id, :invalid
589 589 end
590 590 end
591 591 end
592 592 end
593 593
594 594 # Validates the issue against additional workflow requirements
595 595 def validate_required_fields
596 596 user = new_record? ? author : current_journal.try(:user)
597 597
598 598 required_attribute_names(user).each do |attribute|
599 599 if attribute =~ /^\d+$/
600 600 attribute = attribute.to_i
601 601 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
602 602 if v && v.value.blank?
603 603 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
604 604 end
605 605 else
606 606 if respond_to?(attribute) && send(attribute).blank?
607 607 errors.add attribute, :blank
608 608 end
609 609 end
610 610 end
611 611 end
612 612
613 613 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
614 614 # even if the user turns off the setting later
615 615 def update_done_ratio_from_issue_status
616 616 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
617 617 self.done_ratio = status.default_done_ratio
618 618 end
619 619 end
620 620
621 621 def init_journal(user, notes = "")
622 622 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
623 623 if new_record?
624 624 @current_journal.notify = false
625 625 else
626 626 @attributes_before_change = attributes.dup
627 627 @custom_values_before_change = {}
628 628 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
629 629 end
630 630 @current_journal
631 631 end
632 632
633 633 # Returns the id of the last journal or nil
634 634 def last_journal_id
635 635 if new_record?
636 636 nil
637 637 else
638 638 journals.maximum(:id)
639 639 end
640 640 end
641 641
642 642 # Returns a scope for journals that have an id greater than journal_id
643 643 def journals_after(journal_id)
644 644 scope = journals.reorder("#{Journal.table_name}.id ASC")
645 645 if journal_id.present?
646 646 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
647 647 end
648 648 scope
649 649 end
650 650
651 651 # Returns the initial status of the issue
652 652 # Returns nil for a new issue
653 653 def status_was
654 654 if status_id_was && status_id_was.to_i > 0
655 655 @status_was ||= IssueStatus.find_by_id(status_id_was)
656 656 end
657 657 end
658 658
659 659 # Return true if the issue is closed, otherwise false
660 660 def closed?
661 661 self.status.is_closed?
662 662 end
663 663
664 664 # Return true if the issue is being reopened
665 665 def reopened?
666 666 if !new_record? && status_id_changed?
667 667 status_was = IssueStatus.find_by_id(status_id_was)
668 668 status_new = IssueStatus.find_by_id(status_id)
669 669 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
670 670 return true
671 671 end
672 672 end
673 673 false
674 674 end
675 675
676 676 # Return true if the issue is being closed
677 677 def closing?
678 678 if !new_record? && status_id_changed?
679 679 if status_was && status && !status_was.is_closed? && status.is_closed?
680 680 return true
681 681 end
682 682 end
683 683 false
684 684 end
685 685
686 686 # Returns true if the issue is overdue
687 687 def overdue?
688 688 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
689 689 end
690 690
691 691 # Is the amount of work done less than it should for the due date
692 692 def behind_schedule?
693 693 return false if start_date.nil? || due_date.nil?
694 694 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
695 695 return done_date <= Date.today
696 696 end
697 697
698 698 # Does this issue have children?
699 699 def children?
700 700 !leaf?
701 701 end
702 702
703 703 # Users the issue can be assigned to
704 704 def assignable_users
705 705 users = project.assignable_users
706 706 users << author if author
707 707 users << assigned_to if assigned_to
708 708 users.uniq.sort
709 709 end
710 710
711 711 # Versions that the issue can be assigned to
712 712 def assignable_versions
713 713 return @assignable_versions if @assignable_versions
714 714
715 715 versions = project.shared_versions.open.all
716 716 if fixed_version
717 717 if fixed_version_id_changed?
718 718 # nothing to do
719 719 elsif project_id_changed?
720 720 if project.shared_versions.include?(fixed_version)
721 721 versions << fixed_version
722 722 end
723 723 else
724 724 versions << fixed_version
725 725 end
726 726 end
727 727 @assignable_versions = versions.uniq.sort
728 728 end
729 729
730 730 # Returns true if this issue is blocked by another issue that is still open
731 731 def blocked?
732 732 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
733 733 end
734 734
735 735 # Returns an array of statuses that user is able to apply
736 736 def new_statuses_allowed_to(user=User.current, include_default=false)
737 737 if new_record? && @copied_from
738 738 [IssueStatus.default, @copied_from.status].compact.uniq.sort
739 739 else
740 740 initial_status = nil
741 741 if new_record?
742 742 initial_status = IssueStatus.default
743 743 elsif status_id_was
744 744 initial_status = IssueStatus.find_by_id(status_id_was)
745 745 end
746 746 initial_status ||= status
747
747
748 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
749 assignee_transitions_allowed = initial_assigned_to_id.present? &&
750 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
751
748 752 statuses = initial_status.find_new_statuses_allowed_to(
749 753 user.admin ? Role.all : user.roles_for_project(project),
750 754 tracker,
751 755 author == user,
752 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
756 assignee_transitions_allowed
753 757 )
754 758 statuses << initial_status unless statuses.empty?
755 759 statuses << IssueStatus.default if include_default
756 760 statuses = statuses.compact.uniq.sort
757 761 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
758 762 end
759 763 end
760 764
761 765 def assigned_to_was
762 766 if assigned_to_id_changed? && assigned_to_id_was.present?
763 767 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
764 768 end
765 769 end
766 770
767 771 # Returns the users that should be notified
768 772 def notified_users
769 773 notified = []
770 774 # Author and assignee are always notified unless they have been
771 775 # locked or don't want to be notified
772 776 notified << author if author
773 777 if assigned_to
774 778 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
775 779 end
776 780 if assigned_to_was
777 781 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
778 782 end
779 783 notified = notified.select {|u| u.active? && u.notify_about?(self)}
780 784
781 785 notified += project.notified_users
782 786 notified.uniq!
783 787 # Remove users that can not view the issue
784 788 notified.reject! {|user| !visible?(user)}
785 789 notified
786 790 end
787 791
788 792 # Returns the email addresses that should be notified
789 793 def recipients
790 794 notified_users.collect(&:mail)
791 795 end
792 796
793 797 # Returns the number of hours spent on this issue
794 798 def spent_hours
795 799 @spent_hours ||= time_entries.sum(:hours) || 0
796 800 end
797 801
798 802 # Returns the total number of hours spent on this issue and its descendants
799 803 #
800 804 # Example:
801 805 # spent_hours => 0.0
802 806 # spent_hours => 50.2
803 807 def total_spent_hours
804 808 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
805 809 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
806 810 end
807 811
808 812 def relations
809 813 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
810 814 end
811 815
812 816 # Preloads relations for a collection of issues
813 817 def self.load_relations(issues)
814 818 if issues.any?
815 819 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
816 820 issues.each do |issue|
817 821 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
818 822 end
819 823 end
820 824 end
821 825
822 826 # Preloads visible spent time for a collection of issues
823 827 def self.load_visible_spent_hours(issues, user=User.current)
824 828 if issues.any?
825 829 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
826 830 issues.each do |issue|
827 831 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
828 832 end
829 833 end
830 834 end
831 835
832 836 # Preloads visible relations for a collection of issues
833 837 def self.load_visible_relations(issues, user=User.current)
834 838 if issues.any?
835 839 issue_ids = issues.map(&:id)
836 840 # Relations with issue_from in given issues and visible issue_to
837 841 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
838 842 # Relations with issue_to in given issues and visible issue_from
839 843 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
840 844
841 845 issues.each do |issue|
842 846 relations =
843 847 relations_from.select {|relation| relation.issue_from_id == issue.id} +
844 848 relations_to.select {|relation| relation.issue_to_id == issue.id}
845 849
846 850 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
847 851 end
848 852 end
849 853 end
850 854
851 855 # Finds an issue relation given its id.
852 856 def find_relation(relation_id)
853 857 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
854 858 end
855 859
856 860 # Returns all the other issues that depend on the issue
857 861 # The algorithm is a modified breadth first search (bfs)
858 862 def all_dependent_issues(except=[])
859 863 # The found dependencies
860 864 dependencies = []
861 865
862 866 # The visited flag for every node (issue) used by the breadth first search
863 867 eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
864 868
865 869 ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
866 870 # the issue when it is processed.
867 871
868 872 ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
869 873 # but its children will not be added to the queue when it is processed.
870 874
871 875 eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
872 876 # the queue, but its children have not been added.
873 877
874 878 ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
875 879 # the children still need to be processed.
876 880
877 881 eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
878 882 # added as dependent issues. It needs no further processing.
879 883
880 884 issue_status = Hash.new(eNOT_DISCOVERED)
881 885
882 886 # The queue
883 887 queue = []
884 888
885 889 # Initialize the bfs, add start node (self) to the queue
886 890 queue << self
887 891 issue_status[self] = ePROCESS_ALL
888 892
889 893 while (!queue.empty?) do
890 894 current_issue = queue.shift
891 895 current_issue_status = issue_status[current_issue]
892 896 dependencies << current_issue
893 897
894 898 # Add parent to queue, if not already in it.
895 899 parent = current_issue.parent
896 900 parent_status = issue_status[parent]
897 901
898 902 if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
899 903 queue << parent
900 904 issue_status[parent] = ePROCESS_RELATIONS_ONLY
901 905 end
902 906
903 907 # Add children to queue, but only if they are not already in it and
904 908 # the children of the current node need to be processed.
905 909 if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
906 910 current_issue.children.each do |child|
907 911 next if except.include?(child)
908 912
909 913 if (issue_status[child] == eNOT_DISCOVERED)
910 914 queue << child
911 915 issue_status[child] = ePROCESS_ALL
912 916 elsif (issue_status[child] == eRELATIONS_PROCESSED)
913 917 queue << child
914 918 issue_status[child] = ePROCESS_CHILDREN_ONLY
915 919 elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
916 920 queue << child
917 921 issue_status[child] = ePROCESS_ALL
918 922 end
919 923 end
920 924 end
921 925
922 926 # Add related issues to the queue, if they are not already in it.
923 927 current_issue.relations_from.map(&:issue_to).each do |related_issue|
924 928 next if except.include?(related_issue)
925 929
926 930 if (issue_status[related_issue] == eNOT_DISCOVERED)
927 931 queue << related_issue
928 932 issue_status[related_issue] = ePROCESS_ALL
929 933 elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
930 934 queue << related_issue
931 935 issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
932 936 elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
933 937 queue << related_issue
934 938 issue_status[related_issue] = ePROCESS_ALL
935 939 end
936 940 end
937 941
938 942 # Set new status for current issue
939 943 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
940 944 issue_status[current_issue] = eALL_PROCESSED
941 945 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
942 946 issue_status[current_issue] = eRELATIONS_PROCESSED
943 947 end
944 948 end # while
945 949
946 950 # Remove the issues from the "except" parameter from the result array
947 951 dependencies -= except
948 952 dependencies.delete(self)
949 953
950 954 dependencies
951 955 end
952 956
953 957 # Returns an array of issues that duplicate this one
954 958 def duplicates
955 959 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
956 960 end
957 961
958 962 # Returns the due date or the target due date if any
959 963 # Used on gantt chart
960 964 def due_before
961 965 due_date || (fixed_version ? fixed_version.effective_date : nil)
962 966 end
963 967
964 968 # Returns the time scheduled for this issue.
965 969 #
966 970 # Example:
967 971 # Start Date: 2/26/09, End Date: 3/04/09
968 972 # duration => 6
969 973 def duration
970 974 (start_date && due_date) ? due_date - start_date : 0
971 975 end
972 976
973 977 # Returns the duration in working days
974 978 def working_duration
975 979 (start_date && due_date) ? working_days(start_date, due_date) : 0
976 980 end
977 981
978 982 def soonest_start(reload=false)
979 983 @soonest_start = nil if reload
980 984 @soonest_start ||= (
981 985 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
982 986 [(@parent_issue || parent).try(:soonest_start)]
983 987 ).compact.max
984 988 end
985 989
986 990 # Sets start_date on the given date or the next working day
987 991 # and changes due_date to keep the same working duration.
988 992 def reschedule_on(date)
989 993 wd = working_duration
990 994 date = next_working_date(date)
991 995 self.start_date = date
992 996 self.due_date = add_working_days(date, wd)
993 997 end
994 998
995 999 # Reschedules the issue on the given date or the next working day and saves the record.
996 1000 # If the issue is a parent task, this is done by rescheduling its subtasks.
997 1001 def reschedule_on!(date)
998 1002 return if date.nil?
999 1003 if leaf?
1000 1004 if start_date.nil? || start_date != date
1001 1005 if start_date && start_date > date
1002 1006 # Issue can not be moved earlier than its soonest start date
1003 1007 date = [soonest_start(true), date].compact.max
1004 1008 end
1005 1009 reschedule_on(date)
1006 1010 begin
1007 1011 save
1008 1012 rescue ActiveRecord::StaleObjectError
1009 1013 reload
1010 1014 reschedule_on(date)
1011 1015 save
1012 1016 end
1013 1017 end
1014 1018 else
1015 1019 leaves.each do |leaf|
1016 1020 if leaf.start_date
1017 1021 # Only move subtask if it starts at the same date as the parent
1018 1022 # or if it starts before the given date
1019 1023 if start_date == leaf.start_date || date > leaf.start_date
1020 1024 leaf.reschedule_on!(date)
1021 1025 end
1022 1026 else
1023 1027 leaf.reschedule_on!(date)
1024 1028 end
1025 1029 end
1026 1030 end
1027 1031 end
1028 1032
1029 1033 def <=>(issue)
1030 1034 if issue.nil?
1031 1035 -1
1032 1036 elsif root_id != issue.root_id
1033 1037 (root_id || 0) <=> (issue.root_id || 0)
1034 1038 else
1035 1039 (lft || 0) <=> (issue.lft || 0)
1036 1040 end
1037 1041 end
1038 1042
1039 1043 def to_s
1040 1044 "#{tracker} ##{id}: #{subject}"
1041 1045 end
1042 1046
1043 1047 # Returns a string of css classes that apply to the issue
1044 1048 def css_classes
1045 1049 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
1046 1050 s << ' closed' if closed?
1047 1051 s << ' overdue' if overdue?
1048 1052 s << ' child' if child?
1049 1053 s << ' parent' unless leaf?
1050 1054 s << ' private' if is_private?
1051 1055 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
1052 1056 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
1053 1057 s
1054 1058 end
1055 1059
1056 1060 # Saves an issue and a time_entry from the parameters
1057 1061 def save_issue_with_child_records(params, existing_time_entry=nil)
1058 1062 Issue.transaction do
1059 1063 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
1060 1064 @time_entry = existing_time_entry || TimeEntry.new
1061 1065 @time_entry.project = project
1062 1066 @time_entry.issue = self
1063 1067 @time_entry.user = User.current
1064 1068 @time_entry.spent_on = User.current.today
1065 1069 @time_entry.attributes = params[:time_entry]
1066 1070 self.time_entries << @time_entry
1067 1071 end
1068 1072
1069 1073 # TODO: Rename hook
1070 1074 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
1071 1075 if save
1072 1076 # TODO: Rename hook
1073 1077 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
1074 1078 else
1075 1079 raise ActiveRecord::Rollback
1076 1080 end
1077 1081 end
1078 1082 end
1079 1083
1080 1084 # Unassigns issues from +version+ if it's no longer shared with issue's project
1081 1085 def self.update_versions_from_sharing_change(version)
1082 1086 # Update issues assigned to the version
1083 1087 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1084 1088 end
1085 1089
1086 1090 # Unassigns issues from versions that are no longer shared
1087 1091 # after +project+ was moved
1088 1092 def self.update_versions_from_hierarchy_change(project)
1089 1093 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1090 1094 # Update issues of the moved projects and issues assigned to a version of a moved project
1091 1095 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1092 1096 end
1093 1097
1094 1098 def parent_issue_id=(arg)
1095 1099 s = arg.to_s.strip.presence
1096 1100 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1097 1101 @parent_issue.id
1098 1102 else
1099 1103 @parent_issue = nil
1100 1104 @invalid_parent_issue_id = arg
1101 1105 end
1102 1106 end
1103 1107
1104 1108 def parent_issue_id
1105 1109 if @invalid_parent_issue_id
1106 1110 @invalid_parent_issue_id
1107 1111 elsif instance_variable_defined? :@parent_issue
1108 1112 @parent_issue.nil? ? nil : @parent_issue.id
1109 1113 else
1110 1114 parent_id
1111 1115 end
1112 1116 end
1113 1117
1114 1118 # Returns true if issue's project is a valid
1115 1119 # parent issue project
1116 1120 def valid_parent_project?(issue=parent)
1117 1121 return true if issue.nil? || issue.project_id == project_id
1118 1122
1119 1123 case Setting.cross_project_subtasks
1120 1124 when 'system'
1121 1125 true
1122 1126 when 'tree'
1123 1127 issue.project.root == project.root
1124 1128 when 'hierarchy'
1125 1129 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1126 1130 when 'descendants'
1127 1131 issue.project.is_or_is_ancestor_of?(project)
1128 1132 else
1129 1133 false
1130 1134 end
1131 1135 end
1132 1136
1133 1137 # Extracted from the ReportsController.
1134 1138 def self.by_tracker(project)
1135 1139 count_and_group_by(:project => project,
1136 1140 :field => 'tracker_id',
1137 1141 :joins => Tracker.table_name)
1138 1142 end
1139 1143
1140 1144 def self.by_version(project)
1141 1145 count_and_group_by(:project => project,
1142 1146 :field => 'fixed_version_id',
1143 1147 :joins => Version.table_name)
1144 1148 end
1145 1149
1146 1150 def self.by_priority(project)
1147 1151 count_and_group_by(:project => project,
1148 1152 :field => 'priority_id',
1149 1153 :joins => IssuePriority.table_name)
1150 1154 end
1151 1155
1152 1156 def self.by_category(project)
1153 1157 count_and_group_by(:project => project,
1154 1158 :field => 'category_id',
1155 1159 :joins => IssueCategory.table_name)
1156 1160 end
1157 1161
1158 1162 def self.by_assigned_to(project)
1159 1163 count_and_group_by(:project => project,
1160 1164 :field => 'assigned_to_id',
1161 1165 :joins => User.table_name)
1162 1166 end
1163 1167
1164 1168 def self.by_author(project)
1165 1169 count_and_group_by(:project => project,
1166 1170 :field => 'author_id',
1167 1171 :joins => User.table_name)
1168 1172 end
1169 1173
1170 1174 def self.by_subproject(project)
1171 1175 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1172 1176 s.is_closed as closed,
1173 1177 #{Issue.table_name}.project_id as project_id,
1174 1178 count(#{Issue.table_name}.id) as total
1175 1179 from
1176 1180 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1177 1181 where
1178 1182 #{Issue.table_name}.status_id=s.id
1179 1183 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1180 1184 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1181 1185 and #{Issue.table_name}.project_id <> #{project.id}
1182 1186 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1183 1187 end
1184 1188 # End ReportsController extraction
1185 1189
1186 1190 # Returns an array of projects that user can assign the issue to
1187 1191 def allowed_target_projects(user=User.current)
1188 1192 if new_record?
1189 1193 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1190 1194 else
1191 1195 self.class.allowed_target_projects_on_move(user)
1192 1196 end
1193 1197 end
1194 1198
1195 1199 # Returns an array of projects that user can move issues to
1196 1200 def self.allowed_target_projects_on_move(user=User.current)
1197 1201 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1198 1202 end
1199 1203
1200 1204 private
1201 1205
1202 1206 def after_project_change
1203 1207 # Update project_id on related time entries
1204 1208 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1205 1209
1206 1210 # Delete issue relations
1207 1211 unless Setting.cross_project_issue_relations?
1208 1212 relations_from.clear
1209 1213 relations_to.clear
1210 1214 end
1211 1215
1212 1216 # Move subtasks that were in the same project
1213 1217 children.each do |child|
1214 1218 next unless child.project_id == project_id_was
1215 1219 # Change project and keep project
1216 1220 child.send :project=, project, true
1217 1221 unless child.save
1218 1222 raise ActiveRecord::Rollback
1219 1223 end
1220 1224 end
1221 1225 end
1222 1226
1223 1227 # Callback for after the creation of an issue by copy
1224 1228 # * adds a "copied to" relation with the copied issue
1225 1229 # * copies subtasks from the copied issue
1226 1230 def after_create_from_copy
1227 1231 return unless copy? && !@after_create_from_copy_handled
1228 1232
1229 1233 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1230 1234 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1231 1235 unless relation.save
1232 1236 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1233 1237 end
1234 1238 end
1235 1239
1236 1240 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1237 1241 copy_options = (@copy_options || {}).merge(:subtasks => false)
1238 1242 copied_issue_ids = {@copied_from.id => self.id}
1239 1243 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1240 1244 # Do not copy self when copying an issue as a descendant of the copied issue
1241 1245 next if child == self
1242 1246 # Do not copy subtasks of issues that were not copied
1243 1247 next unless copied_issue_ids[child.parent_id]
1244 1248 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1245 1249 unless child.visible?
1246 1250 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1247 1251 next
1248 1252 end
1249 1253 copy = Issue.new.copy_from(child, copy_options)
1250 1254 copy.author = author
1251 1255 copy.project = project
1252 1256 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1253 1257 unless copy.save
1254 1258 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1255 1259 next
1256 1260 end
1257 1261 copied_issue_ids[child.id] = copy.id
1258 1262 end
1259 1263 end
1260 1264 @after_create_from_copy_handled = true
1261 1265 end
1262 1266
1263 1267 def update_nested_set_attributes
1264 1268 if root_id.nil?
1265 1269 # issue was just created
1266 1270 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1267 1271 set_default_left_and_right
1268 1272 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
1269 1273 if @parent_issue
1270 1274 move_to_child_of(@parent_issue)
1271 1275 end
1272 1276 reload
1273 1277 elsif parent_issue_id != parent_id
1274 1278 former_parent_id = parent_id
1275 1279 # moving an existing issue
1276 1280 if @parent_issue && @parent_issue.root_id == root_id
1277 1281 # inside the same tree
1278 1282 move_to_child_of(@parent_issue)
1279 1283 else
1280 1284 # to another tree
1281 1285 unless root?
1282 1286 move_to_right_of(root)
1283 1287 reload
1284 1288 end
1285 1289 old_root_id = root_id
1286 1290 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1287 1291 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1288 1292 offset = target_maxright + 1 - lft
1289 1293 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
1290 1294 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1291 1295 self[left_column_name] = lft + offset
1292 1296 self[right_column_name] = rgt + offset
1293 1297 if @parent_issue
1294 1298 move_to_child_of(@parent_issue)
1295 1299 end
1296 1300 end
1297 1301 reload
1298 1302 # delete invalid relations of all descendants
1299 1303 self_and_descendants.each do |issue|
1300 1304 issue.relations.each do |relation|
1301 1305 relation.destroy unless relation.valid?
1302 1306 end
1303 1307 end
1304 1308 # update former parent
1305 1309 recalculate_attributes_for(former_parent_id) if former_parent_id
1306 1310 end
1307 1311 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1308 1312 end
1309 1313
1310 1314 def update_parent_attributes
1311 1315 recalculate_attributes_for(parent_id) if parent_id
1312 1316 end
1313 1317
1314 1318 def recalculate_attributes_for(issue_id)
1315 1319 if issue_id && p = Issue.find_by_id(issue_id)
1316 1320 # priority = highest priority of children
1317 1321 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1318 1322 p.priority = IssuePriority.find_by_position(priority_position)
1319 1323 end
1320 1324
1321 1325 # start/due dates = lowest/highest dates of children
1322 1326 p.start_date = p.children.minimum(:start_date)
1323 1327 p.due_date = p.children.maximum(:due_date)
1324 1328 if p.start_date && p.due_date && p.due_date < p.start_date
1325 1329 p.start_date, p.due_date = p.due_date, p.start_date
1326 1330 end
1327 1331
1328 1332 # done ratio = weighted average ratio of leaves
1329 1333 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1330 1334 leaves_count = p.leaves.count
1331 1335 if leaves_count > 0
1332 1336 average = p.leaves.average(:estimated_hours).to_f
1333 1337 if average == 0
1334 1338 average = 1
1335 1339 end
1336 1340 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1337 1341 progress = done / (average * leaves_count)
1338 1342 p.done_ratio = progress.round
1339 1343 end
1340 1344 end
1341 1345
1342 1346 # estimate = sum of leaves estimates
1343 1347 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1344 1348 p.estimated_hours = nil if p.estimated_hours == 0.0
1345 1349
1346 1350 # ancestors will be recursively updated
1347 1351 p.save(:validate => false)
1348 1352 end
1349 1353 end
1350 1354
1351 1355 # Update issues so their versions are not pointing to a
1352 1356 # fixed_version that is not shared with the issue's project
1353 1357 def self.update_versions(conditions=nil)
1354 1358 # Only need to update issues with a fixed_version from
1355 1359 # a different project and that is not systemwide shared
1356 1360 Issue.scoped(:conditions => conditions).all(
1357 1361 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1358 1362 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1359 1363 " AND #{Version.table_name}.sharing <> 'system'",
1360 1364 :include => [:project, :fixed_version]
1361 1365 ).each do |issue|
1362 1366 next if issue.project.nil? || issue.fixed_version.nil?
1363 1367 unless issue.project.shared_versions.include?(issue.fixed_version)
1364 1368 issue.init_journal(User.current)
1365 1369 issue.fixed_version = nil
1366 1370 issue.save
1367 1371 end
1368 1372 end
1369 1373 end
1370 1374
1371 1375 # Callback on file attachment
1372 1376 def attachment_added(obj)
1373 1377 if @current_journal && !obj.new_record?
1374 1378 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1375 1379 end
1376 1380 end
1377 1381
1378 1382 # Callback on attachment deletion
1379 1383 def attachment_removed(obj)
1380 1384 if @current_journal && !obj.new_record?
1381 1385 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1382 1386 @current_journal.save
1383 1387 end
1384 1388 end
1385 1389
1386 1390 # Default assignment based on category
1387 1391 def default_assign
1388 1392 if assigned_to.nil? && category && category.assigned_to
1389 1393 self.assigned_to = category.assigned_to
1390 1394 end
1391 1395 end
1392 1396
1393 1397 # Updates start/due dates of following issues
1394 1398 def reschedule_following_issues
1395 1399 if start_date_changed? || due_date_changed?
1396 1400 relations_from.each do |relation|
1397 1401 relation.set_issue_to_dates
1398 1402 end
1399 1403 end
1400 1404 end
1401 1405
1402 1406 # Closes duplicates if the issue is being closed
1403 1407 def close_duplicates
1404 1408 if closing?
1405 1409 duplicates.each do |duplicate|
1406 1410 # Reload is need in case the duplicate was updated by a previous duplicate
1407 1411 duplicate.reload
1408 1412 # Don't re-close it if it's already closed
1409 1413 next if duplicate.closed?
1410 1414 # Same user and notes
1411 1415 if @current_journal
1412 1416 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1413 1417 end
1414 1418 duplicate.update_attribute :status, self.status
1415 1419 end
1416 1420 end
1417 1421 end
1418 1422
1419 1423 # Make sure updated_on is updated when adding a note and set updated_on now
1420 1424 # so we can set closed_on with the same value on closing
1421 1425 def force_updated_on_change
1422 1426 if @current_journal || changed?
1423 1427 self.updated_on = current_time_from_proper_timezone
1424 1428 if new_record?
1425 1429 self.created_on = updated_on
1426 1430 end
1427 1431 end
1428 1432 end
1429 1433
1430 1434 # Callback for setting closed_on when the issue is closed.
1431 1435 # The closed_on attribute stores the time of the last closing
1432 1436 # and is preserved when the issue is reopened.
1433 1437 def update_closed_on
1434 1438 if closing? || (new_record? && closed?)
1435 1439 self.closed_on = updated_on
1436 1440 end
1437 1441 end
1438 1442
1439 1443 # Saves the changes in a Journal
1440 1444 # Called after_save
1441 1445 def create_journal
1442 1446 if @current_journal
1443 1447 # attributes changes
1444 1448 if @attributes_before_change
1445 1449 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1446 1450 before = @attributes_before_change[c]
1447 1451 after = send(c)
1448 1452 next if before == after || (before.blank? && after.blank?)
1449 1453 @current_journal.details << JournalDetail.new(:property => 'attr',
1450 1454 :prop_key => c,
1451 1455 :old_value => before,
1452 1456 :value => after)
1453 1457 }
1454 1458 end
1455 1459 if @custom_values_before_change
1456 1460 # custom fields changes
1457 1461 custom_field_values.each {|c|
1458 1462 before = @custom_values_before_change[c.custom_field_id]
1459 1463 after = c.value
1460 1464 next if before == after || (before.blank? && after.blank?)
1461 1465
1462 1466 if before.is_a?(Array) || after.is_a?(Array)
1463 1467 before = [before] unless before.is_a?(Array)
1464 1468 after = [after] unless after.is_a?(Array)
1465 1469
1466 1470 # values removed
1467 1471 (before - after).reject(&:blank?).each do |value|
1468 1472 @current_journal.details << JournalDetail.new(:property => 'cf',
1469 1473 :prop_key => c.custom_field_id,
1470 1474 :old_value => value,
1471 1475 :value => nil)
1472 1476 end
1473 1477 # values added
1474 1478 (after - before).reject(&:blank?).each do |value|
1475 1479 @current_journal.details << JournalDetail.new(:property => 'cf',
1476 1480 :prop_key => c.custom_field_id,
1477 1481 :old_value => nil,
1478 1482 :value => value)
1479 1483 end
1480 1484 else
1481 1485 @current_journal.details << JournalDetail.new(:property => 'cf',
1482 1486 :prop_key => c.custom_field_id,
1483 1487 :old_value => before,
1484 1488 :value => after)
1485 1489 end
1486 1490 }
1487 1491 end
1488 1492 @current_journal.save
1489 1493 # reset current journal
1490 1494 init_journal @current_journal.user, @current_journal.notes
1491 1495 end
1492 1496 end
1493 1497
1494 1498 # Query generator for selecting groups of issue counts for a project
1495 1499 # based on specific criteria
1496 1500 #
1497 1501 # Options
1498 1502 # * project - Project to search in.
1499 1503 # * field - String. Issue field to key off of in the grouping.
1500 1504 # * joins - String. The table name to join against.
1501 1505 def self.count_and_group_by(options)
1502 1506 project = options.delete(:project)
1503 1507 select_field = options.delete(:field)
1504 1508 joins = options.delete(:joins)
1505 1509
1506 1510 where = "#{Issue.table_name}.#{select_field}=j.id"
1507 1511
1508 1512 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1509 1513 s.is_closed as closed,
1510 1514 j.id as #{select_field},
1511 1515 count(#{Issue.table_name}.id) as total
1512 1516 from
1513 1517 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1514 1518 where
1515 1519 #{Issue.table_name}.status_id=s.id
1516 1520 and #{where}
1517 1521 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1518 1522 and #{visible_condition(User.current, :project => project)}
1519 1523 group by s.id, s.is_closed, j.id")
1520 1524 end
1521 1525 end
@@ -1,2234 +1,2254
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues, :journals, :journal_details,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def teardown
35 35 User.current = nil
36 36 end
37 37
38 38 def test_initialize
39 39 issue = Issue.new
40 40
41 41 assert_nil issue.project_id
42 42 assert_nil issue.tracker_id
43 43 assert_nil issue.author_id
44 44 assert_nil issue.assigned_to_id
45 45 assert_nil issue.category_id
46 46
47 47 assert_equal IssueStatus.default, issue.status
48 48 assert_equal IssuePriority.default, issue.priority
49 49 end
50 50
51 51 def test_create
52 52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
53 53 :status_id => 1, :priority => IssuePriority.all.first,
54 54 :subject => 'test_create',
55 55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
56 56 assert issue.save
57 57 issue.reload
58 58 assert_equal 1.5, issue.estimated_hours
59 59 end
60 60
61 61 def test_create_minimal
62 62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
63 63 :status_id => 1, :priority => IssuePriority.all.first,
64 64 :subject => 'test_create')
65 65 assert issue.save
66 66 assert issue.description.nil?
67 67 assert_nil issue.estimated_hours
68 68 end
69 69
70 70 def test_start_date_format_should_be_validated
71 71 set_language_if_valid 'en'
72 72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
73 73 issue = Issue.new(:start_date => invalid_date)
74 74 assert !issue.valid?
75 75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
76 76 end
77 77 end
78 78
79 79 def test_due_date_format_should_be_validated
80 80 set_language_if_valid 'en'
81 81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
82 82 issue = Issue.new(:due_date => invalid_date)
83 83 assert !issue.valid?
84 84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
85 85 end
86 86 end
87 87
88 88 def test_due_date_lesser_than_start_date_should_not_validate
89 89 set_language_if_valid 'en'
90 90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
91 91 assert !issue.valid?
92 92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
93 93 end
94 94
95 95 def test_estimated_hours_should_be_validated
96 96 set_language_if_valid 'en'
97 97 ['-2'].each do |invalid|
98 98 issue = Issue.new(:estimated_hours => invalid)
99 99 assert !issue.valid?
100 100 assert_include 'Estimated time is invalid', issue.errors.full_messages
101 101 end
102 102 end
103 103
104 104 def test_create_with_required_custom_field
105 105 set_language_if_valid 'en'
106 106 field = IssueCustomField.find_by_name('Database')
107 107 field.update_attribute(:is_required, true)
108 108
109 109 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
110 110 :status_id => 1, :subject => 'test_create',
111 111 :description => 'IssueTest#test_create_with_required_custom_field')
112 112 assert issue.available_custom_fields.include?(field)
113 113 # No value for the custom field
114 114 assert !issue.save
115 115 assert_equal ["Database can't be blank"], issue.errors.full_messages
116 116 # Blank value
117 117 issue.custom_field_values = { field.id => '' }
118 118 assert !issue.save
119 119 assert_equal ["Database can't be blank"], issue.errors.full_messages
120 120 # Invalid value
121 121 issue.custom_field_values = { field.id => 'SQLServer' }
122 122 assert !issue.save
123 123 assert_equal ["Database is not included in the list"], issue.errors.full_messages
124 124 # Valid value
125 125 issue.custom_field_values = { field.id => 'PostgreSQL' }
126 126 assert issue.save
127 127 issue.reload
128 128 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
129 129 end
130 130
131 131 def test_create_with_group_assignment
132 132 with_settings :issue_group_assignment => '1' do
133 133 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
134 134 :subject => 'Group assignment',
135 135 :assigned_to_id => 11).save
136 136 issue = Issue.first(:order => 'id DESC')
137 137 assert_kind_of Group, issue.assigned_to
138 138 assert_equal Group.find(11), issue.assigned_to
139 139 end
140 140 end
141 141
142 142 def test_create_with_parent_issue_id
143 143 issue = Issue.new(:project_id => 1, :tracker_id => 1,
144 144 :author_id => 1, :subject => 'Group assignment',
145 145 :parent_issue_id => 1)
146 146 assert_save issue
147 147 assert_equal 1, issue.parent_issue_id
148 148 assert_equal Issue.find(1), issue.parent
149 149 end
150 150
151 151 def test_create_with_sharp_parent_issue_id
152 152 issue = Issue.new(:project_id => 1, :tracker_id => 1,
153 153 :author_id => 1, :subject => 'Group assignment',
154 154 :parent_issue_id => "#1")
155 155 assert_save issue
156 156 assert_equal 1, issue.parent_issue_id
157 157 assert_equal Issue.find(1), issue.parent
158 158 end
159 159
160 160 def test_create_with_invalid_parent_issue_id
161 161 set_language_if_valid 'en'
162 162 issue = Issue.new(:project_id => 1, :tracker_id => 1,
163 163 :author_id => 1, :subject => 'Group assignment',
164 164 :parent_issue_id => '01ABC')
165 165 assert !issue.save
166 166 assert_equal '01ABC', issue.parent_issue_id
167 167 assert_include 'Parent task is invalid', issue.errors.full_messages
168 168 end
169 169
170 170 def test_create_with_invalid_sharp_parent_issue_id
171 171 set_language_if_valid 'en'
172 172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
173 173 :author_id => 1, :subject => 'Group assignment',
174 174 :parent_issue_id => '#01ABC')
175 175 assert !issue.save
176 176 assert_equal '#01ABC', issue.parent_issue_id
177 177 assert_include 'Parent task is invalid', issue.errors.full_messages
178 178 end
179 179
180 180 def assert_visibility_match(user, issues)
181 181 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
182 182 end
183 183
184 184 def test_visible_scope_for_anonymous
185 185 # Anonymous user should see issues of public projects only
186 186 issues = Issue.visible(User.anonymous).all
187 187 assert issues.any?
188 188 assert_nil issues.detect {|issue| !issue.project.is_public?}
189 189 assert_nil issues.detect {|issue| issue.is_private?}
190 190 assert_visibility_match User.anonymous, issues
191 191 end
192 192
193 193 def test_visible_scope_for_anonymous_without_view_issues_permissions
194 194 # Anonymous user should not see issues without permission
195 195 Role.anonymous.remove_permission!(:view_issues)
196 196 issues = Issue.visible(User.anonymous).all
197 197 assert issues.empty?
198 198 assert_visibility_match User.anonymous, issues
199 199 end
200 200
201 201 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
202 202 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
203 203 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
204 204 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
205 205 assert !issue.visible?(User.anonymous)
206 206 end
207 207
208 208 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
209 209 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
210 210 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
211 211 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
212 212 assert !issue.visible?(User.anonymous)
213 213 end
214 214
215 215 def test_visible_scope_for_non_member
216 216 user = User.find(9)
217 217 assert user.projects.empty?
218 218 # Non member user should see issues of public projects only
219 219 issues = Issue.visible(user).all
220 220 assert issues.any?
221 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 222 assert_nil issues.detect {|issue| issue.is_private?}
223 223 assert_visibility_match user, issues
224 224 end
225 225
226 226 def test_visible_scope_for_non_member_with_own_issues_visibility
227 227 Role.non_member.update_attribute :issues_visibility, 'own'
228 228 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
229 229 user = User.find(9)
230 230
231 231 issues = Issue.visible(user).all
232 232 assert issues.any?
233 233 assert_nil issues.detect {|issue| issue.author != user}
234 234 assert_visibility_match user, issues
235 235 end
236 236
237 237 def test_visible_scope_for_non_member_without_view_issues_permissions
238 238 # Non member user should not see issues without permission
239 239 Role.non_member.remove_permission!(:view_issues)
240 240 user = User.find(9)
241 241 assert user.projects.empty?
242 242 issues = Issue.visible(user).all
243 243 assert issues.empty?
244 244 assert_visibility_match user, issues
245 245 end
246 246
247 247 def test_visible_scope_for_member
248 248 user = User.find(9)
249 249 # User should see issues of projects for which he has view_issues permissions only
250 250 Role.non_member.remove_permission!(:view_issues)
251 251 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
252 252 issues = Issue.visible(user).all
253 253 assert issues.any?
254 254 assert_nil issues.detect {|issue| issue.project_id != 3}
255 255 assert_nil issues.detect {|issue| issue.is_private?}
256 256 assert_visibility_match user, issues
257 257 end
258 258
259 259 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
260 260 user = User.find(8)
261 261 assert user.groups.any?
262 262 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
263 263 Role.non_member.remove_permission!(:view_issues)
264 264
265 265 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
266 266 :status_id => 1, :priority => IssuePriority.all.first,
267 267 :subject => 'Assignment test',
268 268 :assigned_to => user.groups.first,
269 269 :is_private => true)
270 270
271 271 Role.find(2).update_attribute :issues_visibility, 'default'
272 272 issues = Issue.visible(User.find(8)).all
273 273 assert issues.any?
274 274 assert issues.include?(issue)
275 275
276 276 Role.find(2).update_attribute :issues_visibility, 'own'
277 277 issues = Issue.visible(User.find(8)).all
278 278 assert issues.any?
279 279 assert issues.include?(issue)
280 280 end
281 281
282 282 def test_visible_scope_for_admin
283 283 user = User.find(1)
284 284 user.members.each(&:destroy)
285 285 assert user.projects.empty?
286 286 issues = Issue.visible(user).all
287 287 assert issues.any?
288 288 # Admin should see issues on private projects that he does not belong to
289 289 assert issues.detect {|issue| !issue.project.is_public?}
290 290 # Admin should see private issues of other users
291 291 assert issues.detect {|issue| issue.is_private? && issue.author != user}
292 292 assert_visibility_match user, issues
293 293 end
294 294
295 295 def test_visible_scope_with_project
296 296 project = Project.find(1)
297 297 issues = Issue.visible(User.find(2), :project => project).all
298 298 projects = issues.collect(&:project).uniq
299 299 assert_equal 1, projects.size
300 300 assert_equal project, projects.first
301 301 end
302 302
303 303 def test_visible_scope_with_project_and_subprojects
304 304 project = Project.find(1)
305 305 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
306 306 projects = issues.collect(&:project).uniq
307 307 assert projects.size > 1
308 308 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
309 309 end
310 310
311 311 def test_visible_and_nested_set_scopes
312 312 assert_equal 0, Issue.find(1).descendants.visible.all.size
313 313 end
314 314
315 315 def test_open_scope
316 316 issues = Issue.open.all
317 317 assert_nil issues.detect(&:closed?)
318 318 end
319 319
320 320 def test_open_scope_with_arg
321 321 issues = Issue.open(false).all
322 322 assert_equal issues, issues.select(&:closed?)
323 323 end
324 324
325 325 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
326 326 version = Version.find(2)
327 327 assert version.fixed_issues.any?
328 328 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
329 329 end
330 330
331 331 def test_fixed_version_scope_with_empty_array_should_return_no_result
332 332 assert_equal 0, Issue.fixed_version([]).count
333 333 end
334 334
335 335 def test_errors_full_messages_should_include_custom_fields_errors
336 336 field = IssueCustomField.find_by_name('Database')
337 337
338 338 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
339 339 :status_id => 1, :subject => 'test_create',
340 340 :description => 'IssueTest#test_create_with_required_custom_field')
341 341 assert issue.available_custom_fields.include?(field)
342 342 # Invalid value
343 343 issue.custom_field_values = { field.id => 'SQLServer' }
344 344
345 345 assert !issue.valid?
346 346 assert_equal 1, issue.errors.full_messages.size
347 347 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
348 348 issue.errors.full_messages.first
349 349 end
350 350
351 351 def test_update_issue_with_required_custom_field
352 352 field = IssueCustomField.find_by_name('Database')
353 353 field.update_attribute(:is_required, true)
354 354
355 355 issue = Issue.find(1)
356 356 assert_nil issue.custom_value_for(field)
357 357 assert issue.available_custom_fields.include?(field)
358 358 # No change to custom values, issue can be saved
359 359 assert issue.save
360 360 # Blank value
361 361 issue.custom_field_values = { field.id => '' }
362 362 assert !issue.save
363 363 # Valid value
364 364 issue.custom_field_values = { field.id => 'PostgreSQL' }
365 365 assert issue.save
366 366 issue.reload
367 367 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
368 368 end
369 369
370 370 def test_should_not_update_attributes_if_custom_fields_validation_fails
371 371 issue = Issue.find(1)
372 372 field = IssueCustomField.find_by_name('Database')
373 373 assert issue.available_custom_fields.include?(field)
374 374
375 375 issue.custom_field_values = { field.id => 'Invalid' }
376 376 issue.subject = 'Should be not be saved'
377 377 assert !issue.save
378 378
379 379 issue.reload
380 380 assert_equal "Can't print recipes", issue.subject
381 381 end
382 382
383 383 def test_should_not_recreate_custom_values_objects_on_update
384 384 field = IssueCustomField.find_by_name('Database')
385 385
386 386 issue = Issue.find(1)
387 387 issue.custom_field_values = { field.id => 'PostgreSQL' }
388 388 assert issue.save
389 389 custom_value = issue.custom_value_for(field)
390 390 issue.reload
391 391 issue.custom_field_values = { field.id => 'MySQL' }
392 392 assert issue.save
393 393 issue.reload
394 394 assert_equal custom_value.id, issue.custom_value_for(field).id
395 395 end
396 396
397 397 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
398 398 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
399 399 :status_id => 1, :subject => 'Test',
400 400 :custom_field_values => {'2' => 'Test'})
401 401 assert !Tracker.find(2).custom_field_ids.include?(2)
402 402
403 403 issue = Issue.find(issue.id)
404 404 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
405 405
406 406 issue = Issue.find(issue.id)
407 407 custom_value = issue.custom_value_for(2)
408 408 assert_not_nil custom_value
409 409 assert_equal 'Test', custom_value.value
410 410 end
411 411
412 412 def test_assigning_tracker_id_should_reload_custom_fields_values
413 413 issue = Issue.new(:project => Project.find(1))
414 414 assert issue.custom_field_values.empty?
415 415 issue.tracker_id = 1
416 416 assert issue.custom_field_values.any?
417 417 end
418 418
419 419 def test_assigning_attributes_should_assign_project_and_tracker_first
420 420 seq = sequence('seq')
421 421 issue = Issue.new
422 422 issue.expects(:project_id=).in_sequence(seq)
423 423 issue.expects(:tracker_id=).in_sequence(seq)
424 424 issue.expects(:subject=).in_sequence(seq)
425 425 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
426 426 end
427 427
428 428 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
429 429 attributes = ActiveSupport::OrderedHash.new
430 430 attributes['custom_field_values'] = { '1' => 'MySQL' }
431 431 attributes['tracker_id'] = '1'
432 432 issue = Issue.new(:project => Project.find(1))
433 433 issue.attributes = attributes
434 434 assert_equal 'MySQL', issue.custom_field_value(1)
435 435 end
436 436
437 437 def test_reload_should_reload_custom_field_values
438 438 issue = Issue.generate!
439 439 issue.custom_field_values = {'2' => 'Foo'}
440 440 issue.save!
441 441
442 442 issue = Issue.order('id desc').first
443 443 assert_equal 'Foo', issue.custom_field_value(2)
444 444
445 445 issue.custom_field_values = {'2' => 'Bar'}
446 446 assert_equal 'Bar', issue.custom_field_value(2)
447 447
448 448 issue.reload
449 449 assert_equal 'Foo', issue.custom_field_value(2)
450 450 end
451 451
452 452 def test_should_update_issue_with_disabled_tracker
453 453 p = Project.find(1)
454 454 issue = Issue.find(1)
455 455
456 456 p.trackers.delete(issue.tracker)
457 457 assert !p.trackers.include?(issue.tracker)
458 458
459 459 issue.reload
460 460 issue.subject = 'New subject'
461 461 assert issue.save
462 462 end
463 463
464 464 def test_should_not_set_a_disabled_tracker
465 465 p = Project.find(1)
466 466 p.trackers.delete(Tracker.find(2))
467 467
468 468 issue = Issue.find(1)
469 469 issue.tracker_id = 2
470 470 issue.subject = 'New subject'
471 471 assert !issue.save
472 472 assert_not_nil issue.errors[:tracker_id]
473 473 end
474 474
475 475 def test_category_based_assignment
476 476 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
477 477 :status_id => 1, :priority => IssuePriority.all.first,
478 478 :subject => 'Assignment test',
479 479 :description => 'Assignment test', :category_id => 1)
480 480 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
481 481 end
482 482
483 483 def test_new_statuses_allowed_to
484 484 WorkflowTransition.delete_all
485 485 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
486 486 :old_status_id => 1, :new_status_id => 2,
487 487 :author => false, :assignee => false)
488 488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
489 489 :old_status_id => 1, :new_status_id => 3,
490 490 :author => true, :assignee => false)
491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
492 :new_status_id => 4, :author => false,
493 :assignee => true)
491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
492 :old_status_id => 1, :new_status_id => 4,
493 :author => false, :assignee => true)
494 494 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
495 495 :old_status_id => 1, :new_status_id => 5,
496 496 :author => true, :assignee => true)
497 497 status = IssueStatus.find(1)
498 498 role = Role.find(1)
499 499 tracker = Tracker.find(1)
500 500 user = User.find(2)
501 501
502 502 issue = Issue.generate!(:tracker => tracker, :status => status,
503 503 :project_id => 1, :author_id => 1)
504 504 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
505 505
506 506 issue = Issue.generate!(:tracker => tracker, :status => status,
507 507 :project_id => 1, :author => user)
508 508 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
509 509
510 510 issue = Issue.generate!(:tracker => tracker, :status => status,
511 511 :project_id => 1, :author_id => 1,
512 512 :assigned_to => user)
513 513 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
514 514
515 515 issue = Issue.generate!(:tracker => tracker, :status => status,
516 516 :project_id => 1, :author => user,
517 517 :assigned_to => user)
518 518 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
519
520 group = Group.generate!
521 group.users << user
522 issue = Issue.generate!(:tracker => tracker, :status => status,
523 :project_id => 1, :author => user,
524 :assigned_to => group)
525 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
526 end
527
528 def test_new_statuses_allowed_to_should_consider_group_assignment
529 WorkflowTransition.delete_all
530 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
531 :old_status_id => 1, :new_status_id => 4,
532 :author => false, :assignee => true)
533 user = User.find(2)
534 group = Group.generate!
535 group.users << user
536
537 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
538 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
519 539 end
520 540
521 541 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
522 542 admin = User.find(1)
523 543 issue = Issue.find(1)
524 544 assert !admin.member_of?(issue.project)
525 545 expected_statuses = [issue.status] +
526 546 WorkflowTransition.find_all_by_old_status_id(
527 547 issue.status_id).map(&:new_status).uniq.sort
528 548 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
529 549 end
530 550
531 551 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
532 552 issue = Issue.find(1).copy
533 553 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
534 554
535 555 issue = Issue.find(2).copy
536 556 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
537 557 end
538 558
539 559 def test_safe_attributes_names_should_not_include_disabled_field
540 560 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
541 561
542 562 issue = Issue.new(:tracker => tracker)
543 563 assert_include 'tracker_id', issue.safe_attribute_names
544 564 assert_include 'status_id', issue.safe_attribute_names
545 565 assert_include 'subject', issue.safe_attribute_names
546 566 assert_include 'description', issue.safe_attribute_names
547 567 assert_include 'custom_field_values', issue.safe_attribute_names
548 568 assert_include 'custom_fields', issue.safe_attribute_names
549 569 assert_include 'lock_version', issue.safe_attribute_names
550 570
551 571 tracker.core_fields.each do |field|
552 572 assert_include field, issue.safe_attribute_names
553 573 end
554 574
555 575 tracker.disabled_core_fields.each do |field|
556 576 assert_not_include field, issue.safe_attribute_names
557 577 end
558 578 end
559 579
560 580 def test_safe_attributes_should_ignore_disabled_fields
561 581 tracker = Tracker.find(1)
562 582 tracker.core_fields = %w(assigned_to_id due_date)
563 583 tracker.save!
564 584
565 585 issue = Issue.new(:tracker => tracker)
566 586 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
567 587 assert_nil issue.start_date
568 588 assert_equal Date.parse('2012-07-14'), issue.due_date
569 589 end
570 590
571 591 def test_safe_attributes_should_accept_target_tracker_enabled_fields
572 592 source = Tracker.find(1)
573 593 source.core_fields = []
574 594 source.save!
575 595 target = Tracker.find(2)
576 596 target.core_fields = %w(assigned_to_id due_date)
577 597 target.save!
578 598
579 599 issue = Issue.new(:tracker => source)
580 600 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
581 601 assert_equal target, issue.tracker
582 602 assert_equal Date.parse('2012-07-14'), issue.due_date
583 603 end
584 604
585 605 def test_safe_attributes_should_not_include_readonly_fields
586 606 WorkflowPermission.delete_all
587 607 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
588 608 :role_id => 1, :field_name => 'due_date',
589 609 :rule => 'readonly')
590 610 user = User.find(2)
591 611
592 612 issue = Issue.new(:project_id => 1, :tracker_id => 1)
593 613 assert_equal %w(due_date), issue.read_only_attribute_names(user)
594 614 assert_not_include 'due_date', issue.safe_attribute_names(user)
595 615
596 616 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
597 617 assert_equal Date.parse('2012-07-14'), issue.start_date
598 618 assert_nil issue.due_date
599 619 end
600 620
601 621 def test_safe_attributes_should_not_include_readonly_custom_fields
602 622 cf1 = IssueCustomField.create!(:name => 'Writable field',
603 623 :field_format => 'string',
604 624 :is_for_all => true, :tracker_ids => [1])
605 625 cf2 = IssueCustomField.create!(:name => 'Readonly field',
606 626 :field_format => 'string',
607 627 :is_for_all => true, :tracker_ids => [1])
608 628 WorkflowPermission.delete_all
609 629 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
610 630 :role_id => 1, :field_name => cf2.id.to_s,
611 631 :rule => 'readonly')
612 632 user = User.find(2)
613 633 issue = Issue.new(:project_id => 1, :tracker_id => 1)
614 634 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
615 635 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
616 636
617 637 issue.send :safe_attributes=, {'custom_field_values' => {
618 638 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
619 639 }}, user
620 640 assert_equal 'value1', issue.custom_field_value(cf1)
621 641 assert_nil issue.custom_field_value(cf2)
622 642
623 643 issue.send :safe_attributes=, {'custom_fields' => [
624 644 {'id' => cf1.id.to_s, 'value' => 'valuea'},
625 645 {'id' => cf2.id.to_s, 'value' => 'valueb'}
626 646 ]}, user
627 647 assert_equal 'valuea', issue.custom_field_value(cf1)
628 648 assert_nil issue.custom_field_value(cf2)
629 649 end
630 650
631 651 def test_editable_custom_field_values_should_return_non_readonly_custom_values
632 652 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
633 653 :is_for_all => true, :tracker_ids => [1, 2])
634 654 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
635 655 :is_for_all => true, :tracker_ids => [1, 2])
636 656 WorkflowPermission.delete_all
637 657 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
638 658 :field_name => cf2.id.to_s, :rule => 'readonly')
639 659 user = User.find(2)
640 660
641 661 issue = Issue.new(:project_id => 1, :tracker_id => 1)
642 662 values = issue.editable_custom_field_values(user)
643 663 assert values.detect {|value| value.custom_field == cf1}
644 664 assert_nil values.detect {|value| value.custom_field == cf2}
645 665
646 666 issue.tracker_id = 2
647 667 values = issue.editable_custom_field_values(user)
648 668 assert values.detect {|value| value.custom_field == cf1}
649 669 assert values.detect {|value| value.custom_field == cf2}
650 670 end
651 671
652 672 def test_safe_attributes_should_accept_target_tracker_writable_fields
653 673 WorkflowPermission.delete_all
654 674 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
655 675 :role_id => 1, :field_name => 'due_date',
656 676 :rule => 'readonly')
657 677 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
658 678 :role_id => 1, :field_name => 'start_date',
659 679 :rule => 'readonly')
660 680 user = User.find(2)
661 681
662 682 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
663 683
664 684 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
665 685 'due_date' => '2012-07-14'}, user
666 686 assert_equal Date.parse('2012-07-12'), issue.start_date
667 687 assert_nil issue.due_date
668 688
669 689 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
670 690 'due_date' => '2012-07-16',
671 691 'tracker_id' => 2}, user
672 692 assert_equal Date.parse('2012-07-12'), issue.start_date
673 693 assert_equal Date.parse('2012-07-16'), issue.due_date
674 694 end
675 695
676 696 def test_safe_attributes_should_accept_target_status_writable_fields
677 697 WorkflowPermission.delete_all
678 698 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
679 699 :role_id => 1, :field_name => 'due_date',
680 700 :rule => 'readonly')
681 701 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
682 702 :role_id => 1, :field_name => 'start_date',
683 703 :rule => 'readonly')
684 704 user = User.find(2)
685 705
686 706 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
687 707
688 708 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
689 709 'due_date' => '2012-07-14'},
690 710 user
691 711 assert_equal Date.parse('2012-07-12'), issue.start_date
692 712 assert_nil issue.due_date
693 713
694 714 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
695 715 'due_date' => '2012-07-16',
696 716 'status_id' => 2},
697 717 user
698 718 assert_equal Date.parse('2012-07-12'), issue.start_date
699 719 assert_equal Date.parse('2012-07-16'), issue.due_date
700 720 end
701 721
702 722 def test_required_attributes_should_be_validated
703 723 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
704 724 :is_for_all => true, :tracker_ids => [1, 2])
705 725
706 726 WorkflowPermission.delete_all
707 727 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
708 728 :role_id => 1, :field_name => 'due_date',
709 729 :rule => 'required')
710 730 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
711 731 :role_id => 1, :field_name => 'category_id',
712 732 :rule => 'required')
713 733 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
714 734 :role_id => 1, :field_name => cf.id.to_s,
715 735 :rule => 'required')
716 736
717 737 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
718 738 :role_id => 1, :field_name => 'start_date',
719 739 :rule => 'required')
720 740 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
721 741 :role_id => 1, :field_name => cf.id.to_s,
722 742 :rule => 'required')
723 743 user = User.find(2)
724 744
725 745 issue = Issue.new(:project_id => 1, :tracker_id => 1,
726 746 :status_id => 1, :subject => 'Required fields',
727 747 :author => user)
728 748 assert_equal [cf.id.to_s, "category_id", "due_date"],
729 749 issue.required_attribute_names(user).sort
730 750 assert !issue.save, "Issue was saved"
731 751 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
732 752 issue.errors.full_messages.sort
733 753
734 754 issue.tracker_id = 2
735 755 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
736 756 assert !issue.save, "Issue was saved"
737 757 assert_equal ["Foo can't be blank", "Start date can't be blank"],
738 758 issue.errors.full_messages.sort
739 759
740 760 issue.start_date = Date.today
741 761 issue.custom_field_values = {cf.id.to_s => 'bar'}
742 762 assert issue.save
743 763 end
744 764
745 765 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
746 766 WorkflowPermission.delete_all
747 767 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
748 768 :role_id => 1, :field_name => 'due_date',
749 769 :rule => 'required')
750 770 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
751 771 :role_id => 1, :field_name => 'start_date',
752 772 :rule => 'required')
753 773 user = User.find(2)
754 774 member = Member.find(1)
755 775 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
756 776
757 777 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
758 778
759 779 member.role_ids = [1, 2]
760 780 member.save!
761 781 assert_equal [], issue.required_attribute_names(user.reload)
762 782
763 783 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
764 784 :role_id => 2, :field_name => 'due_date',
765 785 :rule => 'required')
766 786 assert_equal %w(due_date), issue.required_attribute_names(user)
767 787
768 788 member.role_ids = [1, 2, 3]
769 789 member.save!
770 790 assert_equal [], issue.required_attribute_names(user.reload)
771 791
772 792 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
773 793 :role_id => 2, :field_name => 'due_date',
774 794 :rule => 'readonly')
775 795 # required + readonly => required
776 796 assert_equal %w(due_date), issue.required_attribute_names(user)
777 797 end
778 798
779 799 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
780 800 WorkflowPermission.delete_all
781 801 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
782 802 :role_id => 1, :field_name => 'due_date',
783 803 :rule => 'readonly')
784 804 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
785 805 :role_id => 1, :field_name => 'start_date',
786 806 :rule => 'readonly')
787 807 user = User.find(2)
788 808 member = Member.find(1)
789 809 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
790 810
791 811 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
792 812
793 813 member.role_ids = [1, 2]
794 814 member.save!
795 815 assert_equal [], issue.read_only_attribute_names(user.reload)
796 816
797 817 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
798 818 :role_id => 2, :field_name => 'due_date',
799 819 :rule => 'readonly')
800 820 assert_equal %w(due_date), issue.read_only_attribute_names(user)
801 821 end
802 822
803 823 def test_copy
804 824 issue = Issue.new.copy_from(1)
805 825 assert issue.copy?
806 826 assert issue.save
807 827 issue.reload
808 828 orig = Issue.find(1)
809 829 assert_equal orig.subject, issue.subject
810 830 assert_equal orig.tracker, issue.tracker
811 831 assert_equal "125", issue.custom_value_for(2).value
812 832 end
813 833
814 834 def test_copy_should_copy_status
815 835 orig = Issue.find(8)
816 836 assert orig.status != IssueStatus.default
817 837
818 838 issue = Issue.new.copy_from(orig)
819 839 assert issue.save
820 840 issue.reload
821 841 assert_equal orig.status, issue.status
822 842 end
823 843
824 844 def test_copy_should_add_relation_with_copied_issue
825 845 copied = Issue.find(1)
826 846 issue = Issue.new.copy_from(copied)
827 847 assert issue.save
828 848 issue.reload
829 849
830 850 assert_equal 1, issue.relations.size
831 851 relation = issue.relations.first
832 852 assert_equal 'copied_to', relation.relation_type
833 853 assert_equal copied, relation.issue_from
834 854 assert_equal issue, relation.issue_to
835 855 end
836 856
837 857 def test_copy_should_copy_subtasks
838 858 issue = Issue.generate_with_descendants!
839 859
840 860 copy = issue.reload.copy
841 861 copy.author = User.find(7)
842 862 assert_difference 'Issue.count', 1+issue.descendants.count do
843 863 assert copy.save
844 864 end
845 865 copy.reload
846 866 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
847 867 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
848 868 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
849 869 assert_equal copy.author, child_copy.author
850 870 end
851 871
852 872 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
853 873 parent = Issue.generate!
854 874 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
855 875 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
856 876
857 877 copy = parent.reload.copy
858 878 copy.parent_issue_id = parent.id
859 879 copy.author = User.find(7)
860 880 assert_difference 'Issue.count', 3 do
861 881 assert copy.save
862 882 end
863 883 parent.reload
864 884 copy.reload
865 885 assert_equal parent, copy.parent
866 886 assert_equal 3, parent.children.count
867 887 assert_equal 5, parent.descendants.count
868 888 assert_equal 2, copy.children.count
869 889 assert_equal 2, copy.descendants.count
870 890 end
871 891
872 892 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
873 893 parent = Issue.generate!
874 894 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
875 895 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
876 896
877 897 copy = parent.reload.copy
878 898 copy.parent_issue_id = child1.id
879 899 copy.author = User.find(7)
880 900 assert_difference 'Issue.count', 3 do
881 901 assert copy.save
882 902 end
883 903 parent.reload
884 904 child1.reload
885 905 copy.reload
886 906 assert_equal child1, copy.parent
887 907 assert_equal 2, parent.children.count
888 908 assert_equal 5, parent.descendants.count
889 909 assert_equal 1, child1.children.count
890 910 assert_equal 3, child1.descendants.count
891 911 assert_equal 2, copy.children.count
892 912 assert_equal 2, copy.descendants.count
893 913 end
894 914
895 915 def test_copy_should_copy_subtasks_to_target_project
896 916 issue = Issue.generate_with_descendants!
897 917
898 918 copy = issue.copy(:project_id => 3)
899 919 assert_difference 'Issue.count', 1+issue.descendants.count do
900 920 assert copy.save
901 921 end
902 922 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
903 923 end
904 924
905 925 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
906 926 issue = Issue.generate_with_descendants!
907 927
908 928 copy = issue.reload.copy
909 929 assert_difference 'Issue.count', 1+issue.descendants.count do
910 930 assert copy.save
911 931 assert copy.save
912 932 end
913 933 end
914 934
915 935 def test_should_not_call_after_project_change_on_creation
916 936 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
917 937 :subject => 'Test', :author_id => 1)
918 938 issue.expects(:after_project_change).never
919 939 issue.save!
920 940 end
921 941
922 942 def test_should_not_call_after_project_change_on_update
923 943 issue = Issue.find(1)
924 944 issue.project = Project.find(1)
925 945 issue.subject = 'No project change'
926 946 issue.expects(:after_project_change).never
927 947 issue.save!
928 948 end
929 949
930 950 def test_should_call_after_project_change_on_project_change
931 951 issue = Issue.find(1)
932 952 issue.project = Project.find(2)
933 953 issue.expects(:after_project_change).once
934 954 issue.save!
935 955 end
936 956
937 957 def test_adding_journal_should_update_timestamp
938 958 issue = Issue.find(1)
939 959 updated_on_was = issue.updated_on
940 960
941 961 issue.init_journal(User.first, "Adding notes")
942 962 assert_difference 'Journal.count' do
943 963 assert issue.save
944 964 end
945 965 issue.reload
946 966
947 967 assert_not_equal updated_on_was, issue.updated_on
948 968 end
949 969
950 970 def test_should_close_duplicates
951 971 # Create 3 issues
952 972 issue1 = Issue.generate!
953 973 issue2 = Issue.generate!
954 974 issue3 = Issue.generate!
955 975
956 976 # 2 is a dupe of 1
957 977 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
958 978 :relation_type => IssueRelation::TYPE_DUPLICATES)
959 979 # And 3 is a dupe of 2
960 980 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
961 981 :relation_type => IssueRelation::TYPE_DUPLICATES)
962 982 # And 3 is a dupe of 1 (circular duplicates)
963 983 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
964 984 :relation_type => IssueRelation::TYPE_DUPLICATES)
965 985
966 986 assert issue1.reload.duplicates.include?(issue2)
967 987
968 988 # Closing issue 1
969 989 issue1.init_journal(User.first, "Closing issue1")
970 990 issue1.status = IssueStatus.where(:is_closed => true).first
971 991 assert issue1.save
972 992 # 2 and 3 should be also closed
973 993 assert issue2.reload.closed?
974 994 assert issue3.reload.closed?
975 995 end
976 996
977 997 def test_should_not_close_duplicated_issue
978 998 issue1 = Issue.generate!
979 999 issue2 = Issue.generate!
980 1000
981 1001 # 2 is a dupe of 1
982 1002 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
983 1003 :relation_type => IssueRelation::TYPE_DUPLICATES)
984 1004 # 2 is a dup of 1 but 1 is not a duplicate of 2
985 1005 assert !issue2.reload.duplicates.include?(issue1)
986 1006
987 1007 # Closing issue 2
988 1008 issue2.init_journal(User.first, "Closing issue2")
989 1009 issue2.status = IssueStatus.where(:is_closed => true).first
990 1010 assert issue2.save
991 1011 # 1 should not be also closed
992 1012 assert !issue1.reload.closed?
993 1013 end
994 1014
995 1015 def test_assignable_versions
996 1016 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
997 1017 :status_id => 1, :fixed_version_id => 1,
998 1018 :subject => 'New issue')
999 1019 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
1000 1020 end
1001 1021
1002 1022 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1003 1023 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1004 1024 :status_id => 1, :fixed_version_id => 1,
1005 1025 :subject => 'New issue')
1006 1026 assert !issue.save
1007 1027 assert_not_nil issue.errors[:fixed_version_id]
1008 1028 end
1009 1029
1010 1030 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1011 1031 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1012 1032 :status_id => 1, :fixed_version_id => 2,
1013 1033 :subject => 'New issue')
1014 1034 assert !issue.save
1015 1035 assert_not_nil issue.errors[:fixed_version_id]
1016 1036 end
1017 1037
1018 1038 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1019 1039 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1020 1040 :status_id => 1, :fixed_version_id => 3,
1021 1041 :subject => 'New issue')
1022 1042 assert issue.save
1023 1043 end
1024 1044
1025 1045 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1026 1046 issue = Issue.find(11)
1027 1047 assert_equal 'closed', issue.fixed_version.status
1028 1048 issue.subject = 'Subject changed'
1029 1049 assert issue.save
1030 1050 end
1031 1051
1032 1052 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1033 1053 issue = Issue.find(11)
1034 1054 issue.status_id = 1
1035 1055 assert !issue.save
1036 1056 assert_not_nil issue.errors[:base]
1037 1057 end
1038 1058
1039 1059 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1040 1060 issue = Issue.find(11)
1041 1061 issue.status_id = 1
1042 1062 issue.fixed_version_id = 3
1043 1063 assert issue.save
1044 1064 end
1045 1065
1046 1066 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1047 1067 issue = Issue.find(12)
1048 1068 assert_equal 'locked', issue.fixed_version.status
1049 1069 issue.status_id = 1
1050 1070 assert issue.save
1051 1071 end
1052 1072
1053 1073 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1054 1074 issue = Issue.find(2)
1055 1075 assert_equal 2, issue.fixed_version_id
1056 1076 issue.project_id = 3
1057 1077 assert_nil issue.fixed_version_id
1058 1078 issue.fixed_version_id = 2
1059 1079 assert !issue.save
1060 1080 assert_include 'Target version is not included in the list', issue.errors.full_messages
1061 1081 end
1062 1082
1063 1083 def test_should_keep_shared_version_when_changing_project
1064 1084 Version.find(2).update_attribute :sharing, 'tree'
1065 1085
1066 1086 issue = Issue.find(2)
1067 1087 assert_equal 2, issue.fixed_version_id
1068 1088 issue.project_id = 3
1069 1089 assert_equal 2, issue.fixed_version_id
1070 1090 assert issue.save
1071 1091 end
1072 1092
1073 1093 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
1074 1094 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1075 1095 end
1076 1096
1077 1097 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
1078 1098 Project.find(2).disable_module! :issue_tracking
1079 1099 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1080 1100 end
1081 1101
1082 1102 def test_move_to_another_project_with_same_category
1083 1103 issue = Issue.find(1)
1084 1104 issue.project = Project.find(2)
1085 1105 assert issue.save
1086 1106 issue.reload
1087 1107 assert_equal 2, issue.project_id
1088 1108 # Category changes
1089 1109 assert_equal 4, issue.category_id
1090 1110 # Make sure time entries were move to the target project
1091 1111 assert_equal 2, issue.time_entries.first.project_id
1092 1112 end
1093 1113
1094 1114 def test_move_to_another_project_without_same_category
1095 1115 issue = Issue.find(2)
1096 1116 issue.project = Project.find(2)
1097 1117 assert issue.save
1098 1118 issue.reload
1099 1119 assert_equal 2, issue.project_id
1100 1120 # Category cleared
1101 1121 assert_nil issue.category_id
1102 1122 end
1103 1123
1104 1124 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1105 1125 issue = Issue.find(1)
1106 1126 issue.update_attribute(:fixed_version_id, 1)
1107 1127 issue.project = Project.find(2)
1108 1128 assert issue.save
1109 1129 issue.reload
1110 1130 assert_equal 2, issue.project_id
1111 1131 # Cleared fixed_version
1112 1132 assert_equal nil, issue.fixed_version
1113 1133 end
1114 1134
1115 1135 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1116 1136 issue = Issue.find(1)
1117 1137 issue.update_attribute(:fixed_version_id, 4)
1118 1138 issue.project = Project.find(5)
1119 1139 assert issue.save
1120 1140 issue.reload
1121 1141 assert_equal 5, issue.project_id
1122 1142 # Keep fixed_version
1123 1143 assert_equal 4, issue.fixed_version_id
1124 1144 end
1125 1145
1126 1146 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1127 1147 issue = Issue.find(1)
1128 1148 issue.update_attribute(:fixed_version_id, 1)
1129 1149 issue.project = Project.find(5)
1130 1150 assert issue.save
1131 1151 issue.reload
1132 1152 assert_equal 5, issue.project_id
1133 1153 # Cleared fixed_version
1134 1154 assert_equal nil, issue.fixed_version
1135 1155 end
1136 1156
1137 1157 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1138 1158 issue = Issue.find(1)
1139 1159 issue.update_attribute(:fixed_version_id, 7)
1140 1160 issue.project = Project.find(2)
1141 1161 assert issue.save
1142 1162 issue.reload
1143 1163 assert_equal 2, issue.project_id
1144 1164 # Keep fixed_version
1145 1165 assert_equal 7, issue.fixed_version_id
1146 1166 end
1147 1167
1148 1168 def test_move_to_another_project_should_keep_parent_if_valid
1149 1169 issue = Issue.find(1)
1150 1170 issue.update_attribute(:parent_issue_id, 2)
1151 1171 issue.project = Project.find(3)
1152 1172 assert issue.save
1153 1173 issue.reload
1154 1174 assert_equal 2, issue.parent_id
1155 1175 end
1156 1176
1157 1177 def test_move_to_another_project_should_clear_parent_if_not_valid
1158 1178 issue = Issue.find(1)
1159 1179 issue.update_attribute(:parent_issue_id, 2)
1160 1180 issue.project = Project.find(2)
1161 1181 assert issue.save
1162 1182 issue.reload
1163 1183 assert_nil issue.parent_id
1164 1184 end
1165 1185
1166 1186 def test_move_to_another_project_with_disabled_tracker
1167 1187 issue = Issue.find(1)
1168 1188 target = Project.find(2)
1169 1189 target.tracker_ids = [3]
1170 1190 target.save
1171 1191 issue.project = target
1172 1192 assert issue.save
1173 1193 issue.reload
1174 1194 assert_equal 2, issue.project_id
1175 1195 assert_equal 3, issue.tracker_id
1176 1196 end
1177 1197
1178 1198 def test_copy_to_the_same_project
1179 1199 issue = Issue.find(1)
1180 1200 copy = issue.copy
1181 1201 assert_difference 'Issue.count' do
1182 1202 copy.save!
1183 1203 end
1184 1204 assert_kind_of Issue, copy
1185 1205 assert_equal issue.project, copy.project
1186 1206 assert_equal "125", copy.custom_value_for(2).value
1187 1207 end
1188 1208
1189 1209 def test_copy_to_another_project_and_tracker
1190 1210 issue = Issue.find(1)
1191 1211 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1192 1212 assert_difference 'Issue.count' do
1193 1213 copy.save!
1194 1214 end
1195 1215 copy.reload
1196 1216 assert_kind_of Issue, copy
1197 1217 assert_equal Project.find(3), copy.project
1198 1218 assert_equal Tracker.find(2), copy.tracker
1199 1219 # Custom field #2 is not associated with target tracker
1200 1220 assert_nil copy.custom_value_for(2)
1201 1221 end
1202 1222
1203 1223 test "#copy should not create a journal" do
1204 1224 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1205 1225 copy.save!
1206 1226 assert_equal 0, copy.reload.journals.size
1207 1227 end
1208 1228
1209 1229 test "#copy should allow assigned_to changes" do
1210 1230 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1211 1231 assert_equal 3, copy.assigned_to_id
1212 1232 end
1213 1233
1214 1234 test "#copy should allow status changes" do
1215 1235 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1216 1236 assert_equal 2, copy.status_id
1217 1237 end
1218 1238
1219 1239 test "#copy should allow start date changes" do
1220 1240 date = Date.today
1221 1241 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1222 1242 assert_equal date, copy.start_date
1223 1243 end
1224 1244
1225 1245 test "#copy should allow due date changes" do
1226 1246 date = Date.today
1227 1247 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1228 1248 assert_equal date, copy.due_date
1229 1249 end
1230 1250
1231 1251 test "#copy should set current user as author" do
1232 1252 User.current = User.find(9)
1233 1253 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1234 1254 assert_equal User.current, copy.author
1235 1255 end
1236 1256
1237 1257 test "#copy should create a journal with notes" do
1238 1258 date = Date.today
1239 1259 notes = "Notes added when copying"
1240 1260 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1241 1261 copy.init_journal(User.current, notes)
1242 1262 copy.save!
1243 1263
1244 1264 assert_equal 1, copy.journals.size
1245 1265 journal = copy.journals.first
1246 1266 assert_equal 0, journal.details.size
1247 1267 assert_equal notes, journal.notes
1248 1268 end
1249 1269
1250 1270 def test_valid_parent_project
1251 1271 issue = Issue.find(1)
1252 1272 issue_in_same_project = Issue.find(2)
1253 1273 issue_in_child_project = Issue.find(5)
1254 1274 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1255 1275 issue_in_other_child_project = Issue.find(6)
1256 1276 issue_in_different_tree = Issue.find(4)
1257 1277
1258 1278 with_settings :cross_project_subtasks => '' do
1259 1279 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1260 1280 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1261 1281 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1262 1282 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1263 1283 end
1264 1284
1265 1285 with_settings :cross_project_subtasks => 'system' do
1266 1286 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1267 1287 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1268 1288 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1269 1289 end
1270 1290
1271 1291 with_settings :cross_project_subtasks => 'tree' do
1272 1292 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1273 1293 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1274 1294 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1275 1295 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1276 1296
1277 1297 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1278 1298 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1279 1299 end
1280 1300
1281 1301 with_settings :cross_project_subtasks => 'descendants' do
1282 1302 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1283 1303 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1284 1304 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1285 1305 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1286 1306
1287 1307 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1288 1308 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1289 1309 end
1290 1310 end
1291 1311
1292 1312 def test_recipients_should_include_previous_assignee
1293 1313 user = User.find(3)
1294 1314 user.members.update_all ["mail_notification = ?", false]
1295 1315 user.update_attribute :mail_notification, 'only_assigned'
1296 1316
1297 1317 issue = Issue.find(2)
1298 1318 issue.assigned_to = nil
1299 1319 assert_include user.mail, issue.recipients
1300 1320 issue.save!
1301 1321 assert !issue.recipients.include?(user.mail)
1302 1322 end
1303 1323
1304 1324 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1305 1325 issue = Issue.find(12)
1306 1326 assert issue.recipients.include?(issue.author.mail)
1307 1327 # copy the issue to a private project
1308 1328 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1309 1329 # author is not a member of project anymore
1310 1330 assert !copy.recipients.include?(copy.author.mail)
1311 1331 end
1312 1332
1313 1333 def test_recipients_should_include_the_assigned_group_members
1314 1334 group_member = User.generate!
1315 1335 group = Group.generate!
1316 1336 group.users << group_member
1317 1337
1318 1338 issue = Issue.find(12)
1319 1339 issue.assigned_to = group
1320 1340 assert issue.recipients.include?(group_member.mail)
1321 1341 end
1322 1342
1323 1343 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1324 1344 user = User.find(3)
1325 1345 issue = Issue.find(9)
1326 1346 Watcher.create!(:user => user, :watchable => issue)
1327 1347 assert issue.watched_by?(user)
1328 1348 assert !issue.watcher_recipients.include?(user.mail)
1329 1349 end
1330 1350
1331 1351 def test_issue_destroy
1332 1352 Issue.find(1).destroy
1333 1353 assert_nil Issue.find_by_id(1)
1334 1354 assert_nil TimeEntry.find_by_issue_id(1)
1335 1355 end
1336 1356
1337 1357 def test_destroying_a_deleted_issue_should_not_raise_an_error
1338 1358 issue = Issue.find(1)
1339 1359 Issue.find(1).destroy
1340 1360
1341 1361 assert_nothing_raised do
1342 1362 assert_no_difference 'Issue.count' do
1343 1363 issue.destroy
1344 1364 end
1345 1365 assert issue.destroyed?
1346 1366 end
1347 1367 end
1348 1368
1349 1369 def test_destroying_a_stale_issue_should_not_raise_an_error
1350 1370 issue = Issue.find(1)
1351 1371 Issue.find(1).update_attribute :subject, "Updated"
1352 1372
1353 1373 assert_nothing_raised do
1354 1374 assert_difference 'Issue.count', -1 do
1355 1375 issue.destroy
1356 1376 end
1357 1377 assert issue.destroyed?
1358 1378 end
1359 1379 end
1360 1380
1361 1381 def test_blocked
1362 1382 blocked_issue = Issue.find(9)
1363 1383 blocking_issue = Issue.find(10)
1364 1384
1365 1385 assert blocked_issue.blocked?
1366 1386 assert !blocking_issue.blocked?
1367 1387 end
1368 1388
1369 1389 def test_blocked_issues_dont_allow_closed_statuses
1370 1390 blocked_issue = Issue.find(9)
1371 1391
1372 1392 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1373 1393 assert !allowed_statuses.empty?
1374 1394 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1375 1395 assert closed_statuses.empty?
1376 1396 end
1377 1397
1378 1398 def test_unblocked_issues_allow_closed_statuses
1379 1399 blocking_issue = Issue.find(10)
1380 1400
1381 1401 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1382 1402 assert !allowed_statuses.empty?
1383 1403 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1384 1404 assert !closed_statuses.empty?
1385 1405 end
1386 1406
1387 1407 def test_reschedule_an_issue_without_dates
1388 1408 with_settings :non_working_week_days => [] do
1389 1409 issue = Issue.new(:start_date => nil, :due_date => nil)
1390 1410 issue.reschedule_on '2012-10-09'.to_date
1391 1411 assert_equal '2012-10-09'.to_date, issue.start_date
1392 1412 assert_equal '2012-10-09'.to_date, issue.due_date
1393 1413 end
1394 1414
1395 1415 with_settings :non_working_week_days => %w(6 7) do
1396 1416 issue = Issue.new(:start_date => nil, :due_date => nil)
1397 1417 issue.reschedule_on '2012-10-09'.to_date
1398 1418 assert_equal '2012-10-09'.to_date, issue.start_date
1399 1419 assert_equal '2012-10-09'.to_date, issue.due_date
1400 1420
1401 1421 issue = Issue.new(:start_date => nil, :due_date => nil)
1402 1422 issue.reschedule_on '2012-10-13'.to_date
1403 1423 assert_equal '2012-10-15'.to_date, issue.start_date
1404 1424 assert_equal '2012-10-15'.to_date, issue.due_date
1405 1425 end
1406 1426 end
1407 1427
1408 1428 def test_reschedule_an_issue_with_start_date
1409 1429 with_settings :non_working_week_days => [] do
1410 1430 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1411 1431 issue.reschedule_on '2012-10-13'.to_date
1412 1432 assert_equal '2012-10-13'.to_date, issue.start_date
1413 1433 assert_equal '2012-10-13'.to_date, issue.due_date
1414 1434 end
1415 1435
1416 1436 with_settings :non_working_week_days => %w(6 7) do
1417 1437 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1418 1438 issue.reschedule_on '2012-10-11'.to_date
1419 1439 assert_equal '2012-10-11'.to_date, issue.start_date
1420 1440 assert_equal '2012-10-11'.to_date, issue.due_date
1421 1441
1422 1442 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1423 1443 issue.reschedule_on '2012-10-13'.to_date
1424 1444 assert_equal '2012-10-15'.to_date, issue.start_date
1425 1445 assert_equal '2012-10-15'.to_date, issue.due_date
1426 1446 end
1427 1447 end
1428 1448
1429 1449 def test_reschedule_an_issue_with_start_and_due_dates
1430 1450 with_settings :non_working_week_days => [] do
1431 1451 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1432 1452 issue.reschedule_on '2012-10-13'.to_date
1433 1453 assert_equal '2012-10-13'.to_date, issue.start_date
1434 1454 assert_equal '2012-10-19'.to_date, issue.due_date
1435 1455 end
1436 1456
1437 1457 with_settings :non_working_week_days => %w(6 7) do
1438 1458 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1439 1459 issue.reschedule_on '2012-10-11'.to_date
1440 1460 assert_equal '2012-10-11'.to_date, issue.start_date
1441 1461 assert_equal '2012-10-23'.to_date, issue.due_date
1442 1462
1443 1463 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1444 1464 issue.reschedule_on '2012-10-13'.to_date
1445 1465 assert_equal '2012-10-15'.to_date, issue.start_date
1446 1466 assert_equal '2012-10-25'.to_date, issue.due_date
1447 1467 end
1448 1468 end
1449 1469
1450 1470 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1451 1471 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1452 1472 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1453 1473 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1454 1474 :relation_type => IssueRelation::TYPE_PRECEDES)
1455 1475 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1456 1476
1457 1477 issue1.due_date = '2012-10-23'
1458 1478 issue1.save!
1459 1479 issue2.reload
1460 1480 assert_equal Date.parse('2012-10-24'), issue2.start_date
1461 1481 assert_equal Date.parse('2012-10-26'), issue2.due_date
1462 1482 end
1463 1483
1464 1484 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1465 1485 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1466 1486 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1467 1487 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1468 1488 :relation_type => IssueRelation::TYPE_PRECEDES)
1469 1489 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1470 1490
1471 1491 issue1.start_date = '2012-09-17'
1472 1492 issue1.due_date = '2012-09-18'
1473 1493 issue1.save!
1474 1494 issue2.reload
1475 1495 assert_equal Date.parse('2012-09-19'), issue2.start_date
1476 1496 assert_equal Date.parse('2012-09-21'), issue2.due_date
1477 1497 end
1478 1498
1479 1499 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1480 1500 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1481 1501 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1482 1502 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1483 1503 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1484 1504 :relation_type => IssueRelation::TYPE_PRECEDES)
1485 1505 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1486 1506 :relation_type => IssueRelation::TYPE_PRECEDES)
1487 1507 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1488 1508
1489 1509 issue1.start_date = '2012-09-17'
1490 1510 issue1.due_date = '2012-09-18'
1491 1511 issue1.save!
1492 1512 issue2.reload
1493 1513 # Issue 2 must start after Issue 3
1494 1514 assert_equal Date.parse('2012-10-03'), issue2.start_date
1495 1515 assert_equal Date.parse('2012-10-05'), issue2.due_date
1496 1516 end
1497 1517
1498 1518 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1499 1519 with_settings :non_working_week_days => [] do
1500 1520 stale = Issue.find(1)
1501 1521 issue = Issue.find(1)
1502 1522 issue.subject = "Updated"
1503 1523 issue.save!
1504 1524 date = 10.days.from_now.to_date
1505 1525 assert_nothing_raised do
1506 1526 stale.reschedule_on!(date)
1507 1527 end
1508 1528 assert_equal date, stale.reload.start_date
1509 1529 end
1510 1530 end
1511 1531
1512 1532 def test_child_issue_should_consider_parent_soonest_start_on_create
1513 1533 set_language_if_valid 'en'
1514 1534 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1515 1535 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
1516 1536 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1517 1537 :relation_type => IssueRelation::TYPE_PRECEDES)
1518 1538 issue1.reload
1519 1539 issue2.reload
1520 1540 assert_equal Date.parse('2012-10-18'), issue2.start_date
1521 1541
1522 1542 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
1523 1543 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
1524 1544 assert !child.valid?
1525 1545 assert_include 'Start date is invalid', child.errors.full_messages
1526 1546 assert_equal Date.parse('2012-10-18'), child.soonest_start
1527 1547 child.start_date = '2012-10-18'
1528 1548 assert child.save
1529 1549 end
1530 1550
1531 1551 def test_setting_parent_to_a_dependent_issue_should_not_validate
1532 1552 set_language_if_valid 'en'
1533 1553 issue1 = Issue.generate!
1534 1554 issue2 = Issue.generate!
1535 1555 issue3 = Issue.generate!
1536 1556 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1537 1557 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
1538 1558 issue3.reload
1539 1559 issue3.parent_issue_id = issue2.id
1540 1560 assert !issue3.valid?
1541 1561 assert_include 'Parent task is invalid', issue3.errors.full_messages
1542 1562 end
1543 1563
1544 1564 def test_setting_parent_should_not_allow_circular_dependency
1545 1565 set_language_if_valid 'en'
1546 1566 issue1 = Issue.generate!
1547 1567 issue2 = Issue.generate!
1548 1568 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1549 1569 issue3 = Issue.generate!
1550 1570 issue2.reload
1551 1571 issue2.parent_issue_id = issue3.id
1552 1572 issue2.save!
1553 1573 issue4 = Issue.generate!
1554 1574 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
1555 1575 issue4.reload
1556 1576 issue4.parent_issue_id = issue1.id
1557 1577 assert !issue4.valid?
1558 1578 assert_include 'Parent task is invalid', issue4.errors.full_messages
1559 1579 end
1560 1580
1561 1581 def test_overdue
1562 1582 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1563 1583 assert !Issue.new(:due_date => Date.today).overdue?
1564 1584 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1565 1585 assert !Issue.new(:due_date => nil).overdue?
1566 1586 assert !Issue.new(:due_date => 1.day.ago.to_date,
1567 1587 :status => IssueStatus.where(:is_closed => true).first
1568 1588 ).overdue?
1569 1589 end
1570 1590
1571 1591 test "#behind_schedule? should be false if the issue has no start_date" do
1572 1592 assert !Issue.new(:start_date => nil,
1573 1593 :due_date => 1.day.from_now.to_date,
1574 1594 :done_ratio => 0).behind_schedule?
1575 1595 end
1576 1596
1577 1597 test "#behind_schedule? should be false if the issue has no end_date" do
1578 1598 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1579 1599 :due_date => nil,
1580 1600 :done_ratio => 0).behind_schedule?
1581 1601 end
1582 1602
1583 1603 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
1584 1604 assert !Issue.new(:start_date => 50.days.ago.to_date,
1585 1605 :due_date => 50.days.from_now.to_date,
1586 1606 :done_ratio => 90).behind_schedule?
1587 1607 end
1588 1608
1589 1609 test "#behind_schedule? should be true if the issue hasn't been started at all" do
1590 1610 assert Issue.new(:start_date => 1.day.ago.to_date,
1591 1611 :due_date => 1.day.from_now.to_date,
1592 1612 :done_ratio => 0).behind_schedule?
1593 1613 end
1594 1614
1595 1615 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
1596 1616 assert Issue.new(:start_date => 100.days.ago.to_date,
1597 1617 :due_date => Date.today,
1598 1618 :done_ratio => 90).behind_schedule?
1599 1619 end
1600 1620
1601 1621 test "#assignable_users should be Users" do
1602 1622 assert_kind_of User, Issue.find(1).assignable_users.first
1603 1623 end
1604 1624
1605 1625 test "#assignable_users should include the issue author" do
1606 1626 non_project_member = User.generate!
1607 1627 issue = Issue.generate!(:author => non_project_member)
1608 1628
1609 1629 assert issue.assignable_users.include?(non_project_member)
1610 1630 end
1611 1631
1612 1632 test "#assignable_users should include the current assignee" do
1613 1633 user = User.generate!
1614 1634 issue = Issue.generate!(:assigned_to => user)
1615 1635 user.lock!
1616 1636
1617 1637 assert Issue.find(issue.id).assignable_users.include?(user)
1618 1638 end
1619 1639
1620 1640 test "#assignable_users should not show the issue author twice" do
1621 1641 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1622 1642 assert_equal 2, assignable_user_ids.length
1623 1643
1624 1644 assignable_user_ids.each do |user_id|
1625 1645 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1626 1646 "User #{user_id} appears more or less than once"
1627 1647 end
1628 1648 end
1629 1649
1630 1650 test "#assignable_users with issue_group_assignment should include groups" do
1631 1651 issue = Issue.new(:project => Project.find(2))
1632 1652
1633 1653 with_settings :issue_group_assignment => '1' do
1634 1654 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1635 1655 assert issue.assignable_users.include?(Group.find(11))
1636 1656 end
1637 1657 end
1638 1658
1639 1659 test "#assignable_users without issue_group_assignment should not include groups" do
1640 1660 issue = Issue.new(:project => Project.find(2))
1641 1661
1642 1662 with_settings :issue_group_assignment => '0' do
1643 1663 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1644 1664 assert !issue.assignable_users.include?(Group.find(11))
1645 1665 end
1646 1666 end
1647 1667
1648 1668 def test_create_should_send_email_notification
1649 1669 ActionMailer::Base.deliveries.clear
1650 1670 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1651 1671 :author_id => 3, :status_id => 1,
1652 1672 :priority => IssuePriority.all.first,
1653 1673 :subject => 'test_create', :estimated_hours => '1:30')
1654 1674
1655 1675 assert issue.save
1656 1676 assert_equal 1, ActionMailer::Base.deliveries.size
1657 1677 end
1658 1678
1659 1679 def test_stale_issue_should_not_send_email_notification
1660 1680 ActionMailer::Base.deliveries.clear
1661 1681 issue = Issue.find(1)
1662 1682 stale = Issue.find(1)
1663 1683
1664 1684 issue.init_journal(User.find(1))
1665 1685 issue.subject = 'Subjet update'
1666 1686 assert issue.save
1667 1687 assert_equal 1, ActionMailer::Base.deliveries.size
1668 1688 ActionMailer::Base.deliveries.clear
1669 1689
1670 1690 stale.init_journal(User.find(1))
1671 1691 stale.subject = 'Another subjet update'
1672 1692 assert_raise ActiveRecord::StaleObjectError do
1673 1693 stale.save
1674 1694 end
1675 1695 assert ActionMailer::Base.deliveries.empty?
1676 1696 end
1677 1697
1678 1698 def test_journalized_description
1679 1699 IssueCustomField.delete_all
1680 1700
1681 1701 i = Issue.first
1682 1702 old_description = i.description
1683 1703 new_description = "This is the new description"
1684 1704
1685 1705 i.init_journal(User.find(2))
1686 1706 i.description = new_description
1687 1707 assert_difference 'Journal.count', 1 do
1688 1708 assert_difference 'JournalDetail.count', 1 do
1689 1709 i.save!
1690 1710 end
1691 1711 end
1692 1712
1693 1713 detail = JournalDetail.first(:order => 'id DESC')
1694 1714 assert_equal i, detail.journal.journalized
1695 1715 assert_equal 'attr', detail.property
1696 1716 assert_equal 'description', detail.prop_key
1697 1717 assert_equal old_description, detail.old_value
1698 1718 assert_equal new_description, detail.value
1699 1719 end
1700 1720
1701 1721 def test_blank_descriptions_should_not_be_journalized
1702 1722 IssueCustomField.delete_all
1703 1723 Issue.update_all("description = NULL", "id=1")
1704 1724
1705 1725 i = Issue.find(1)
1706 1726 i.init_journal(User.find(2))
1707 1727 i.subject = "blank description"
1708 1728 i.description = "\r\n"
1709 1729
1710 1730 assert_difference 'Journal.count', 1 do
1711 1731 assert_difference 'JournalDetail.count', 1 do
1712 1732 i.save!
1713 1733 end
1714 1734 end
1715 1735 end
1716 1736
1717 1737 def test_journalized_multi_custom_field
1718 1738 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1719 1739 :is_filter => true, :is_for_all => true,
1720 1740 :tracker_ids => [1],
1721 1741 :possible_values => ['value1', 'value2', 'value3'],
1722 1742 :multiple => true)
1723 1743
1724 1744 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1725 1745 :subject => 'Test', :author_id => 1)
1726 1746
1727 1747 assert_difference 'Journal.count' do
1728 1748 assert_difference 'JournalDetail.count' do
1729 1749 issue.init_journal(User.first)
1730 1750 issue.custom_field_values = {field.id => ['value1']}
1731 1751 issue.save!
1732 1752 end
1733 1753 assert_difference 'JournalDetail.count' do
1734 1754 issue.init_journal(User.first)
1735 1755 issue.custom_field_values = {field.id => ['value1', 'value2']}
1736 1756 issue.save!
1737 1757 end
1738 1758 assert_difference 'JournalDetail.count', 2 do
1739 1759 issue.init_journal(User.first)
1740 1760 issue.custom_field_values = {field.id => ['value3', 'value2']}
1741 1761 issue.save!
1742 1762 end
1743 1763 assert_difference 'JournalDetail.count', 2 do
1744 1764 issue.init_journal(User.first)
1745 1765 issue.custom_field_values = {field.id => nil}
1746 1766 issue.save!
1747 1767 end
1748 1768 end
1749 1769 end
1750 1770
1751 1771 def test_description_eol_should_be_normalized
1752 1772 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1753 1773 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1754 1774 end
1755 1775
1756 1776 def test_saving_twice_should_not_duplicate_journal_details
1757 1777 i = Issue.first
1758 1778 i.init_journal(User.find(2), 'Some notes')
1759 1779 # initial changes
1760 1780 i.subject = 'New subject'
1761 1781 i.done_ratio = i.done_ratio + 10
1762 1782 assert_difference 'Journal.count' do
1763 1783 assert i.save
1764 1784 end
1765 1785 # 1 more change
1766 1786 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
1767 1787 assert_no_difference 'Journal.count' do
1768 1788 assert_difference 'JournalDetail.count', 1 do
1769 1789 i.save
1770 1790 end
1771 1791 end
1772 1792 # no more change
1773 1793 assert_no_difference 'Journal.count' do
1774 1794 assert_no_difference 'JournalDetail.count' do
1775 1795 i.save
1776 1796 end
1777 1797 end
1778 1798 end
1779 1799
1780 1800 def test_all_dependent_issues
1781 1801 IssueRelation.delete_all
1782 1802 assert IssueRelation.create!(:issue_from => Issue.find(1),
1783 1803 :issue_to => Issue.find(2),
1784 1804 :relation_type => IssueRelation::TYPE_PRECEDES)
1785 1805 assert IssueRelation.create!(:issue_from => Issue.find(2),
1786 1806 :issue_to => Issue.find(3),
1787 1807 :relation_type => IssueRelation::TYPE_PRECEDES)
1788 1808 assert IssueRelation.create!(:issue_from => Issue.find(3),
1789 1809 :issue_to => Issue.find(8),
1790 1810 :relation_type => IssueRelation::TYPE_PRECEDES)
1791 1811
1792 1812 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1793 1813 end
1794 1814
1795 1815 def test_all_dependent_issues_with_subtask
1796 1816 IssueRelation.delete_all
1797 1817
1798 1818 project = Project.generate!(:name => "testproject")
1799 1819
1800 1820 parentIssue = Issue.generate!(:project => project)
1801 1821 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
1802 1822 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
1803 1823
1804 1824 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
1805 1825 end
1806 1826
1807 1827 def test_all_dependent_issues_does_not_include_self
1808 1828 IssueRelation.delete_all
1809 1829
1810 1830 project = Project.generate!(:name => "testproject")
1811 1831
1812 1832 parentIssue = Issue.generate!(:project => project)
1813 1833 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
1814 1834
1815 1835 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
1816 1836 end
1817 1837
1818 1838 def test_all_dependent_issues_with_parenttask_and_sibling
1819 1839 IssueRelation.delete_all
1820 1840
1821 1841 project = Project.generate!(:name => "testproject")
1822 1842
1823 1843 parentIssue = Issue.generate!(:project => project)
1824 1844 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
1825 1845 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
1826 1846
1827 1847 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
1828 1848 end
1829 1849
1830 1850 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
1831 1851 IssueRelation.delete_all
1832 1852
1833 1853 project = Project.generate!(:name => "testproject")
1834 1854
1835 1855 parentIssue1 = Issue.generate!(:project => project)
1836 1856 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1837 1857 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1838 1858
1839 1859 parentIssue2 = Issue.generate!(:project => project)
1840 1860 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1841 1861 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1842 1862
1843 1863
1844 1864 assert IssueRelation.create(:issue_from => parentIssue1,
1845 1865 :issue_to => childIssue2_2,
1846 1866 :relation_type => IssueRelation::TYPE_BLOCKS)
1847 1867
1848 1868 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
1849 1869 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
1850 1870 end
1851 1871
1852 1872 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
1853 1873 IssueRelation.delete_all
1854 1874
1855 1875 project = Project.generate!(:name => "testproject")
1856 1876
1857 1877 parentIssue1 = Issue.generate!(:project => project)
1858 1878 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1859 1879 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1860 1880
1861 1881 parentIssue2 = Issue.generate!(:project => project)
1862 1882 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1863 1883 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1864 1884
1865 1885
1866 1886 assert IssueRelation.create(:issue_from => parentIssue1,
1867 1887 :issue_to => parentIssue2,
1868 1888 :relation_type => IssueRelation::TYPE_BLOCKS)
1869 1889
1870 1890 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
1871 1891 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
1872 1892 end
1873 1893
1874 1894 def test_all_dependent_issues_with_transitive_relation
1875 1895 IssueRelation.delete_all
1876 1896
1877 1897 project = Project.generate!(:name => "testproject")
1878 1898
1879 1899 parentIssue1 = Issue.generate!(:project => project)
1880 1900 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1881 1901
1882 1902 parentIssue2 = Issue.generate!(:project => project)
1883 1903 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1884 1904
1885 1905 independentIssue = Issue.generate!(:project => project)
1886 1906
1887 1907 assert IssueRelation.create(:issue_from => parentIssue1,
1888 1908 :issue_to => childIssue2_1,
1889 1909 :relation_type => IssueRelation::TYPE_RELATES)
1890 1910
1891 1911 assert IssueRelation.create(:issue_from => childIssue2_1,
1892 1912 :issue_to => independentIssue,
1893 1913 :relation_type => IssueRelation::TYPE_RELATES)
1894 1914
1895 1915 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
1896 1916 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
1897 1917 end
1898 1918
1899 1919 def test_all_dependent_issues_with_transitive_relation2
1900 1920 IssueRelation.delete_all
1901 1921
1902 1922 project = Project.generate!(:name => "testproject")
1903 1923
1904 1924 parentIssue1 = Issue.generate!(:project => project)
1905 1925 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
1906 1926
1907 1927 parentIssue2 = Issue.generate!(:project => project)
1908 1928 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
1909 1929
1910 1930 independentIssue = Issue.generate!(:project => project)
1911 1931
1912 1932 assert IssueRelation.create(:issue_from => parentIssue1,
1913 1933 :issue_to => independentIssue,
1914 1934 :relation_type => IssueRelation::TYPE_RELATES)
1915 1935
1916 1936 assert IssueRelation.create(:issue_from => independentIssue,
1917 1937 :issue_to => childIssue2_1,
1918 1938 :relation_type => IssueRelation::TYPE_RELATES)
1919 1939
1920 1940 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
1921 1941 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
1922 1942
1923 1943 end
1924 1944
1925 1945 def test_all_dependent_issues_with_persistent_circular_dependency
1926 1946 IssueRelation.delete_all
1927 1947 assert IssueRelation.create!(:issue_from => Issue.find(1),
1928 1948 :issue_to => Issue.find(2),
1929 1949 :relation_type => IssueRelation::TYPE_PRECEDES)
1930 1950 assert IssueRelation.create!(:issue_from => Issue.find(2),
1931 1951 :issue_to => Issue.find(3),
1932 1952 :relation_type => IssueRelation::TYPE_PRECEDES)
1933 1953
1934 1954 r = IssueRelation.create!(:issue_from => Issue.find(3),
1935 1955 :issue_to => Issue.find(7),
1936 1956 :relation_type => IssueRelation::TYPE_PRECEDES)
1937 1957 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1938 1958
1939 1959 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1940 1960 end
1941 1961
1942 1962 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1943 1963 IssueRelation.delete_all
1944 1964 assert IssueRelation.create!(:issue_from => Issue.find(1),
1945 1965 :issue_to => Issue.find(2),
1946 1966 :relation_type => IssueRelation::TYPE_RELATES)
1947 1967 assert IssueRelation.create!(:issue_from => Issue.find(2),
1948 1968 :issue_to => Issue.find(3),
1949 1969 :relation_type => IssueRelation::TYPE_RELATES)
1950 1970 assert IssueRelation.create!(:issue_from => Issue.find(3),
1951 1971 :issue_to => Issue.find(8),
1952 1972 :relation_type => IssueRelation::TYPE_RELATES)
1953 1973
1954 1974 r = IssueRelation.create!(:issue_from => Issue.find(8),
1955 1975 :issue_to => Issue.find(7),
1956 1976 :relation_type => IssueRelation::TYPE_RELATES)
1957 1977 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1958 1978
1959 1979 r = IssueRelation.create!(:issue_from => Issue.find(3),
1960 1980 :issue_to => Issue.find(7),
1961 1981 :relation_type => IssueRelation::TYPE_RELATES)
1962 1982 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1963 1983
1964 1984 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1965 1985 end
1966 1986
1967 1987 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
1968 1988 @issue = Issue.find(1)
1969 1989 @issue_status = IssueStatus.find(1)
1970 1990 @issue_status.update_attribute(:default_done_ratio, 50)
1971 1991 @issue2 = Issue.find(2)
1972 1992 @issue_status2 = IssueStatus.find(2)
1973 1993 @issue_status2.update_attribute(:default_done_ratio, 0)
1974 1994
1975 1995 with_settings :issue_done_ratio => 'issue_field' do
1976 1996 assert_equal 0, @issue.done_ratio
1977 1997 assert_equal 30, @issue2.done_ratio
1978 1998 end
1979 1999
1980 2000 with_settings :issue_done_ratio => 'issue_status' do
1981 2001 assert_equal 50, @issue.done_ratio
1982 2002 assert_equal 0, @issue2.done_ratio
1983 2003 end
1984 2004 end
1985 2005
1986 2006 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
1987 2007 @issue = Issue.find(1)
1988 2008 @issue_status = IssueStatus.find(1)
1989 2009 @issue_status.update_attribute(:default_done_ratio, 50)
1990 2010 @issue2 = Issue.find(2)
1991 2011 @issue_status2 = IssueStatus.find(2)
1992 2012 @issue_status2.update_attribute(:default_done_ratio, 0)
1993 2013
1994 2014 with_settings :issue_done_ratio => 'issue_field' do
1995 2015 @issue.update_done_ratio_from_issue_status
1996 2016 @issue2.update_done_ratio_from_issue_status
1997 2017
1998 2018 assert_equal 0, @issue.read_attribute(:done_ratio)
1999 2019 assert_equal 30, @issue2.read_attribute(:done_ratio)
2000 2020 end
2001 2021
2002 2022 with_settings :issue_done_ratio => 'issue_status' do
2003 2023 @issue.update_done_ratio_from_issue_status
2004 2024 @issue2.update_done_ratio_from_issue_status
2005 2025
2006 2026 assert_equal 50, @issue.read_attribute(:done_ratio)
2007 2027 assert_equal 0, @issue2.read_attribute(:done_ratio)
2008 2028 end
2009 2029 end
2010 2030
2011 2031 test "#by_tracker" do
2012 2032 User.current = User.anonymous
2013 2033 groups = Issue.by_tracker(Project.find(1))
2014 2034 assert_equal 3, groups.size
2015 2035 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2016 2036 end
2017 2037
2018 2038 test "#by_version" do
2019 2039 User.current = User.anonymous
2020 2040 groups = Issue.by_version(Project.find(1))
2021 2041 assert_equal 3, groups.size
2022 2042 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2023 2043 end
2024 2044
2025 2045 test "#by_priority" do
2026 2046 User.current = User.anonymous
2027 2047 groups = Issue.by_priority(Project.find(1))
2028 2048 assert_equal 4, groups.size
2029 2049 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2030 2050 end
2031 2051
2032 2052 test "#by_category" do
2033 2053 User.current = User.anonymous
2034 2054 groups = Issue.by_category(Project.find(1))
2035 2055 assert_equal 2, groups.size
2036 2056 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2037 2057 end
2038 2058
2039 2059 test "#by_assigned_to" do
2040 2060 User.current = User.anonymous
2041 2061 groups = Issue.by_assigned_to(Project.find(1))
2042 2062 assert_equal 2, groups.size
2043 2063 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2044 2064 end
2045 2065
2046 2066 test "#by_author" do
2047 2067 User.current = User.anonymous
2048 2068 groups = Issue.by_author(Project.find(1))
2049 2069 assert_equal 4, groups.size
2050 2070 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2051 2071 end
2052 2072
2053 2073 test "#by_subproject" do
2054 2074 User.current = User.anonymous
2055 2075 groups = Issue.by_subproject(Project.find(1))
2056 2076 # Private descendant not visible
2057 2077 assert_equal 1, groups.size
2058 2078 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2059 2079 end
2060 2080
2061 2081 def test_recently_updated_scope
2062 2082 #should return the last updated issue
2063 2083 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
2064 2084 end
2065 2085
2066 2086 def test_on_active_projects_scope
2067 2087 assert Project.find(2).archive
2068 2088
2069 2089 before = Issue.on_active_project.length
2070 2090 # test inclusion to results
2071 2091 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
2072 2092 assert_equal before + 1, Issue.on_active_project.length
2073 2093
2074 2094 # Move to an archived project
2075 2095 issue.project = Project.find(2)
2076 2096 assert issue.save
2077 2097 assert_equal before, Issue.on_active_project.length
2078 2098 end
2079 2099
2080 2100 test "Issue#recipients should include project recipients" do
2081 2101 issue = Issue.generate!
2082 2102 assert issue.project.recipients.present?
2083 2103 issue.project.recipients.each do |project_recipient|
2084 2104 assert issue.recipients.include?(project_recipient)
2085 2105 end
2086 2106 end
2087 2107
2088 2108 test "Issue#recipients should include the author if the author is active" do
2089 2109 issue = Issue.generate!(:author => User.generate!)
2090 2110 assert issue.author, "No author set for Issue"
2091 2111 assert issue.recipients.include?(issue.author.mail)
2092 2112 end
2093 2113
2094 2114 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
2095 2115 issue = Issue.generate!(:assigned_to => User.generate!)
2096 2116 assert issue.assigned_to, "No assigned_to set for Issue"
2097 2117 assert issue.recipients.include?(issue.assigned_to.mail)
2098 2118 end
2099 2119
2100 2120 test "Issue#recipients should not include users who opt out of all email" do
2101 2121 issue = Issue.generate!(:author => User.generate!)
2102 2122 issue.author.update_attribute(:mail_notification, :none)
2103 2123 assert !issue.recipients.include?(issue.author.mail)
2104 2124 end
2105 2125
2106 2126 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
2107 2127 issue = Issue.generate!(:author => User.generate!)
2108 2128 issue.author.update_attribute(:mail_notification, :only_assigned)
2109 2129 assert !issue.recipients.include?(issue.author.mail)
2110 2130 end
2111 2131
2112 2132 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
2113 2133 issue = Issue.generate!(:assigned_to => User.generate!)
2114 2134 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
2115 2135 assert !issue.recipients.include?(issue.assigned_to.mail)
2116 2136 end
2117 2137
2118 2138 def test_last_journal_id_with_journals_should_return_the_journal_id
2119 2139 assert_equal 2, Issue.find(1).last_journal_id
2120 2140 end
2121 2141
2122 2142 def test_last_journal_id_without_journals_should_return_nil
2123 2143 assert_nil Issue.find(3).last_journal_id
2124 2144 end
2125 2145
2126 2146 def test_journals_after_should_return_journals_with_greater_id
2127 2147 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
2128 2148 assert_equal [], Issue.find(1).journals_after('2')
2129 2149 end
2130 2150
2131 2151 def test_journals_after_with_blank_arg_should_return_all_journals
2132 2152 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
2133 2153 end
2134 2154
2135 2155 def test_css_classes_should_include_tracker
2136 2156 issue = Issue.new(:tracker => Tracker.find(2))
2137 2157 classes = issue.css_classes.split(' ')
2138 2158 assert_include 'tracker-2', classes
2139 2159 end
2140 2160
2141 2161 def test_css_classes_should_include_priority
2142 2162 issue = Issue.new(:priority => IssuePriority.find(8))
2143 2163 classes = issue.css_classes.split(' ')
2144 2164 assert_include 'priority-8', classes
2145 2165 assert_include 'priority-highest', classes
2146 2166 end
2147 2167
2148 2168 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
2149 2169 set_tmp_attachments_directory
2150 2170 issue = Issue.generate!
2151 2171 issue.save_attachments({
2152 2172 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
2153 2173 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
2154 2174 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
2155 2175 })
2156 2176 issue.attach_saved_attachments
2157 2177
2158 2178 assert_equal 3, issue.reload.attachments.count
2159 2179 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
2160 2180 end
2161 2181
2162 2182 def test_closed_on_should_be_nil_when_creating_an_open_issue
2163 2183 issue = Issue.generate!(:status_id => 1).reload
2164 2184 assert !issue.closed?
2165 2185 assert_nil issue.closed_on
2166 2186 end
2167 2187
2168 2188 def test_closed_on_should_be_set_when_creating_a_closed_issue
2169 2189 issue = Issue.generate!(:status_id => 5).reload
2170 2190 assert issue.closed?
2171 2191 assert_not_nil issue.closed_on
2172 2192 assert_equal issue.updated_on, issue.closed_on
2173 2193 assert_equal issue.created_on, issue.closed_on
2174 2194 end
2175 2195
2176 2196 def test_closed_on_should_be_nil_when_updating_an_open_issue
2177 2197 issue = Issue.find(1)
2178 2198 issue.subject = 'Not closed yet'
2179 2199 issue.save!
2180 2200 issue.reload
2181 2201 assert_nil issue.closed_on
2182 2202 end
2183 2203
2184 2204 def test_closed_on_should_be_set_when_closing_an_open_issue
2185 2205 issue = Issue.find(1)
2186 2206 issue.subject = 'Now closed'
2187 2207 issue.status_id = 5
2188 2208 issue.save!
2189 2209 issue.reload
2190 2210 assert_not_nil issue.closed_on
2191 2211 assert_equal issue.updated_on, issue.closed_on
2192 2212 end
2193 2213
2194 2214 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2195 2215 issue = Issue.open(false).first
2196 2216 was_closed_on = issue.closed_on
2197 2217 assert_not_nil was_closed_on
2198 2218 issue.subject = 'Updating a closed issue'
2199 2219 issue.save!
2200 2220 issue.reload
2201 2221 assert_equal was_closed_on, issue.closed_on
2202 2222 end
2203 2223
2204 2224 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2205 2225 issue = Issue.open(false).first
2206 2226 was_closed_on = issue.closed_on
2207 2227 assert_not_nil was_closed_on
2208 2228 issue.subject = 'Reopening a closed issue'
2209 2229 issue.status_id = 1
2210 2230 issue.save!
2211 2231 issue.reload
2212 2232 assert !issue.closed?
2213 2233 assert_equal was_closed_on, issue.closed_on
2214 2234 end
2215 2235
2216 2236 def test_status_was_should_return_nil_for_new_issue
2217 2237 issue = Issue.new
2218 2238 assert_nil issue.status_was
2219 2239 end
2220 2240
2221 2241 def test_status_was_should_return_status_before_change
2222 2242 issue = Issue.find(1)
2223 2243 issue.status = IssueStatus.find(2)
2224 2244 assert_equal IssueStatus.find(1), issue.status_was
2225 2245 end
2226 2246
2227 2247 def test_status_was_should_be_reset_on_save
2228 2248 issue = Issue.find(1)
2229 2249 issue.status = IssueStatus.find(2)
2230 2250 assert_equal IssueStatus.find(1), issue.status_was
2231 2251 assert issue.save!
2232 2252 assert_equal IssueStatus.find(2), issue.status_was
2233 2253 end
2234 2254 end
General Comments 0
You need to be logged in to leave comments. Login now