##// END OF EJS Templates
Adds functional tests on issue list content formatting....
Jean-Philippe Lang -
r7871:e7d48427d6ff
parent child
Show More
@@ -1,1974 +1,1999
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'issues_controller'
20 20
21 21 class IssuesControllerTest < ActionController::TestCase
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issues,
28 28 :issue_statuses,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries
45 45
46 46 include Redmine::I18n
47 47
48 48 def setup
49 49 @controller = IssuesController.new
50 50 @request = ActionController::TestRequest.new
51 51 @response = ActionController::TestResponse.new
52 52 User.current = nil
53 53 end
54 54
55 55 def test_index
56 56 Setting.default_language = 'en'
57 57
58 58 get :index
59 59 assert_response :success
60 60 assert_template 'index'
61 61 assert_not_nil assigns(:issues)
62 62 assert_nil assigns(:project)
63 63 assert_tag :tag => 'a', :content => /Can't print recipes/
64 64 assert_tag :tag => 'a', :content => /Subproject issue/
65 65 # private projects hidden
66 66 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
67 67 assert_no_tag :tag => 'a', :content => /Issue on project 2/
68 68 # project column
69 69 assert_tag :tag => 'th', :content => /Project/
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79 assert_no_tag :tag => 'a', :content => /Can't print recipes/
80 80 assert_tag :tag => 'a', :content => /Subproject issue/
81 81 end
82 82
83 83 def test_index_should_list_visible_issues_only
84 84 get :index, :per_page => 100
85 85 assert_response :success
86 86 assert_not_nil assigns(:issues)
87 87 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
88 88 end
89 89
90 90 def test_index_with_project
91 91 Setting.display_subprojects_issues = 0
92 92 get :index, :project_id => 1
93 93 assert_response :success
94 94 assert_template 'index'
95 95 assert_not_nil assigns(:issues)
96 96 assert_tag :tag => 'a', :content => /Can't print recipes/
97 97 assert_no_tag :tag => 'a', :content => /Subproject issue/
98 98 end
99 99
100 100 def test_index_with_project_and_subprojects
101 101 Setting.display_subprojects_issues = 1
102 102 get :index, :project_id => 1
103 103 assert_response :success
104 104 assert_template 'index'
105 105 assert_not_nil assigns(:issues)
106 106 assert_tag :tag => 'a', :content => /Can't print recipes/
107 107 assert_tag :tag => 'a', :content => /Subproject issue/
108 108 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
109 109 end
110 110
111 111 def test_index_with_project_and_subprojects_should_show_private_subprojects
112 112 @request.session[:user_id] = 2
113 113 Setting.display_subprojects_issues = 1
114 114 get :index, :project_id => 1
115 115 assert_response :success
116 116 assert_template 'index'
117 117 assert_not_nil assigns(:issues)
118 118 assert_tag :tag => 'a', :content => /Can't print recipes/
119 119 assert_tag :tag => 'a', :content => /Subproject issue/
120 120 assert_tag :tag => 'a', :content => /Issue of a private subproject/
121 121 end
122 122
123 123 def test_index_with_project_and_default_filter
124 124 get :index, :project_id => 1, :set_filter => 1
125 125 assert_response :success
126 126 assert_template 'index'
127 127 assert_not_nil assigns(:issues)
128 128
129 129 query = assigns(:query)
130 130 assert_not_nil query
131 131 # default filter
132 132 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
133 133 end
134 134
135 135 def test_index_with_project_and_filter
136 136 get :index, :project_id => 1, :set_filter => 1,
137 137 :f => ['tracker_id'],
138 138 :op => {'tracker_id' => '='},
139 139 :v => {'tracker_id' => ['1']}
140 140 assert_response :success
141 141 assert_template 'index'
142 142 assert_not_nil assigns(:issues)
143 143
144 144 query = assigns(:query)
145 145 assert_not_nil query
146 146 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
147 147 end
148 148
149 149 def test_index_with_short_filters
150 150
151 151 to_test = {
152 152 'status_id' => {
153 153 'o' => { :op => 'o', :values => [''] },
154 154 'c' => { :op => 'c', :values => [''] },
155 155 '7' => { :op => '=', :values => ['7'] },
156 156 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
157 157 '=7' => { :op => '=', :values => ['7'] },
158 158 '!3' => { :op => '!', :values => ['3'] },
159 159 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
160 160 'subject' => {
161 161 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
162 162 'o' => { :op => '=', :values => ['o'] },
163 163 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
164 164 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
165 165 'tracker_id' => {
166 166 '3' => { :op => '=', :values => ['3'] },
167 167 '=3' => { :op => '=', :values => ['3'] }},
168 168 'start_date' => {
169 169 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
170 170 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
171 171 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
172 172 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
173 173 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
174 174 '<t+2' => { :op => '<t+', :values => ['2'] },
175 175 '>t+2' => { :op => '>t+', :values => ['2'] },
176 176 't+2' => { :op => 't+', :values => ['2'] },
177 177 't' => { :op => 't', :values => [''] },
178 178 'w' => { :op => 'w', :values => [''] },
179 179 '>t-2' => { :op => '>t-', :values => ['2'] },
180 180 '<t-2' => { :op => '<t-', :values => ['2'] },
181 181 't-2' => { :op => 't-', :values => ['2'] }},
182 182 'created_on' => {
183 183 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
184 184 '<t+2' => { :op => '=', :values => ['<t+2'] },
185 185 '>t+2' => { :op => '=', :values => ['>t+2'] },
186 186 't+2' => { :op => 't', :values => ['+2'] }},
187 187 'cf_1' => {
188 188 'c' => { :op => '=', :values => ['c'] },
189 189 '!c' => { :op => '!', :values => ['c'] },
190 190 '!*' => { :op => '!*', :values => [''] },
191 191 '*' => { :op => '*', :values => [''] }},
192 192 'estimated_hours' => {
193 193 '=13.4' => { :op => '=', :values => ['13.4'] },
194 194 '>=45' => { :op => '>=', :values => ['45'] },
195 195 '<=125' => { :op => '<=', :values => ['125'] },
196 196 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
197 197 '!*' => { :op => '!*', :values => [''] },
198 198 '*' => { :op => '*', :values => [''] }}
199 199 }
200 200
201 201 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
202 202
203 203 to_test.each do |field, expression_and_expected|
204 204 expression_and_expected.each do |filter_expression, expected|
205 205
206 206 get :index, :set_filter => 1, field => filter_expression
207 207
208 208 assert_response :success
209 209 assert_template 'index'
210 210 assert_not_nil assigns(:issues)
211 211
212 212 query = assigns(:query)
213 213 assert_not_nil query
214 214 assert query.has_filter?(field)
215 215 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
216 216 end
217 217 end
218 218
219 219 end
220 220
221 221 def test_index_with_project_and_empty_filters
222 222 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
223 223 assert_response :success
224 224 assert_template 'index'
225 225 assert_not_nil assigns(:issues)
226 226
227 227 query = assigns(:query)
228 228 assert_not_nil query
229 229 # no filter
230 230 assert_equal({}, query.filters)
231 231 end
232 232
233 233 def test_index_with_query
234 234 get :index, :project_id => 1, :query_id => 5
235 235 assert_response :success
236 236 assert_template 'index'
237 237 assert_not_nil assigns(:issues)
238 238 assert_nil assigns(:issue_count_by_group)
239 239 end
240 240
241 241 def test_index_with_query_grouped_by_tracker
242 242 get :index, :project_id => 1, :query_id => 6
243 243 assert_response :success
244 244 assert_template 'index'
245 245 assert_not_nil assigns(:issues)
246 246 assert_not_nil assigns(:issue_count_by_group)
247 247 end
248 248
249 249 def test_index_with_query_grouped_by_list_custom_field
250 250 get :index, :project_id => 1, :query_id => 9
251 251 assert_response :success
252 252 assert_template 'index'
253 253 assert_not_nil assigns(:issues)
254 254 assert_not_nil assigns(:issue_count_by_group)
255 255 end
256 256
257 257 def test_private_query_should_not_be_available_to_other_users
258 258 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
259 259 @request.session[:user_id] = 3
260 260
261 261 get :index, :query_id => q.id
262 262 assert_response 403
263 263 end
264 264
265 265 def test_private_query_should_be_available_to_its_user
266 266 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
267 267 @request.session[:user_id] = 2
268 268
269 269 get :index, :query_id => q.id
270 270 assert_response :success
271 271 end
272 272
273 273 def test_public_query_should_be_available_to_other_users
274 274 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
275 275 @request.session[:user_id] = 3
276 276
277 277 get :index, :query_id => q.id
278 278 assert_response :success
279 279 end
280 280
281 281 def test_index_csv
282 282 get :index, :format => 'csv'
283 283 assert_response :success
284 284 assert_not_nil assigns(:issues)
285 285 assert_equal 'text/csv', @response.content_type
286 286 assert @response.body.starts_with?("#,")
287 287 lines = @response.body.chomp.split("\n")
288 288 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
289 289 end
290 290
291 291 def test_index_csv_with_project
292 292 get :index, :project_id => 1, :format => 'csv'
293 293 assert_response :success
294 294 assert_not_nil assigns(:issues)
295 295 assert_equal 'text/csv', @response.content_type
296 296 end
297 297
298 298 def test_index_csv_with_description
299 299 get :index, :format => 'csv', :description => '1'
300 300 assert_response :success
301 301 assert_not_nil assigns(:issues)
302 302 assert_equal 'text/csv', @response.content_type
303 303 assert @response.body.starts_with?("#,")
304 304 lines = @response.body.chomp.split("\n")
305 305 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
306 306 end
307 307
308 308 def test_index_csv_with_all_columns
309 309 get :index, :format => 'csv', :columns => 'all'
310 310 assert_response :success
311 311 assert_not_nil assigns(:issues)
312 312 assert_equal 'text/csv', @response.content_type
313 313 assert @response.body.starts_with?("#,")
314 314 lines = @response.body.chomp.split("\n")
315 315 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
316 316 end
317 317
318 318 def test_index_csv_big_5
319 319 with_settings :default_language => "zh-TW" do
320 320 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
321 321 str_big5 = "\xa4@\xa4\xeb"
322 322 if str_utf8.respond_to?(:force_encoding)
323 323 str_utf8.force_encoding('UTF-8')
324 324 str_big5.force_encoding('Big5')
325 325 end
326 326 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
327 327 :status_id => 1, :priority => IssuePriority.all.first,
328 328 :subject => str_utf8)
329 329 assert issue.save
330 330
331 331 get :index, :project_id => 1,
332 332 :f => ['subject'],
333 333 :op => '=', :values => [str_utf8],
334 334 :format => 'csv'
335 335 assert_equal 'text/csv', @response.content_type
336 336 lines = @response.body.chomp.split("\n")
337 337 s1 = "\xaa\xac\xbaA"
338 338 if str_utf8.respond_to?(:force_encoding)
339 339 s1.force_encoding('Big5')
340 340 end
341 341 assert lines[0].include?(s1)
342 342 assert lines[1].include?(str_big5)
343 343 end
344 344 end
345 345
346 346 def test_index_csv_cannot_convert_should_be_replaced_big_5
347 347 with_settings :default_language => "zh-TW" do
348 348 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
349 349 if str_utf8.respond_to?(:force_encoding)
350 350 str_utf8.force_encoding('UTF-8')
351 351 end
352 352 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
353 353 :status_id => 1, :priority => IssuePriority.all.first,
354 354 :subject => str_utf8)
355 355 assert issue.save
356 356
357 357 get :index, :project_id => 1,
358 358 :f => ['subject'],
359 359 :op => '=', :values => [str_utf8],
360 360 :c => ['status', 'subject'],
361 361 :format => 'csv',
362 362 :set_filter => 1
363 363 assert_equal 'text/csv', @response.content_type
364 364 lines = @response.body.chomp.split("\n")
365 365 s1 = "\xaa\xac\xbaA" # status
366 366 if str_utf8.respond_to?(:force_encoding)
367 367 s1.force_encoding('Big5')
368 368 end
369 369 assert lines[0].include?(s1)
370 370 s2 = lines[1].split(",")[2]
371 371 if s1.respond_to?(:force_encoding)
372 372 s3 = "\xa5H?" # subject
373 373 s3.force_encoding('Big5')
374 374 assert_equal s3, s2
375 375 elsif RUBY_PLATFORM == 'java'
376 376 assert_equal "??", s2
377 377 else
378 378 assert_equal "\xa5H???", s2
379 379 end
380 380 end
381 381 end
382 382
383 383 def test_index_csv_tw
384 384 with_settings :default_language => "zh-TW" do
385 385 str1 = "test_index_csv_tw"
386 386 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
387 387 :status_id => 1, :priority => IssuePriority.all.first,
388 388 :subject => str1, :estimated_hours => '1234.5')
389 389 assert issue.save
390 390 assert_equal 1234.5, issue.estimated_hours
391 391
392 392 get :index, :project_id => 1,
393 393 :f => ['subject'],
394 394 :op => '=', :values => [str1],
395 395 :c => ['estimated_hours', 'subject'],
396 396 :format => 'csv',
397 397 :set_filter => 1
398 398 assert_equal 'text/csv', @response.content_type
399 399 lines = @response.body.chomp.split("\n")
400 400 assert_equal "#{issue.id},1234.5,#{str1}", lines[1]
401 401
402 402 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
403 403 if str_tw.respond_to?(:force_encoding)
404 404 str_tw.force_encoding('UTF-8')
405 405 end
406 406 assert_equal str_tw, l(:general_lang_name)
407 407 assert_equal ',', l(:general_csv_separator)
408 408 assert_equal '.', l(:general_csv_decimal_separator)
409 409 end
410 410 end
411 411
412 412 def test_index_csv_fr
413 413 with_settings :default_language => "fr" do
414 414 str1 = "test_index_csv_fr"
415 415 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
416 416 :status_id => 1, :priority => IssuePriority.all.first,
417 417 :subject => str1, :estimated_hours => '1234.5')
418 418 assert issue.save
419 419 assert_equal 1234.5, issue.estimated_hours
420 420
421 421 get :index, :project_id => 1,
422 422 :f => ['subject'],
423 423 :op => '=', :values => [str1],
424 424 :c => ['estimated_hours', 'subject'],
425 425 :format => 'csv',
426 426 :set_filter => 1
427 427 assert_equal 'text/csv', @response.content_type
428 428 lines = @response.body.chomp.split("\n")
429 429 assert_equal "#{issue.id};1234,5;#{str1}", lines[1]
430 430
431 431 str_fr = "Fran\xc3\xa7ais"
432 432 if str_fr.respond_to?(:force_encoding)
433 433 str_fr.force_encoding('UTF-8')
434 434 end
435 435 assert_equal str_fr, l(:general_lang_name)
436 436 assert_equal ';', l(:general_csv_separator)
437 437 assert_equal ',', l(:general_csv_decimal_separator)
438 438 end
439 439 end
440 440
441 441 def test_index_pdf
442 442 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
443 443 with_settings :default_language => lang do
444 444
445 445 get :index
446 446 assert_response :success
447 447 assert_template 'index'
448 448
449 449 if lang == "ja"
450 450 if RUBY_PLATFORM != 'java'
451 451 assert_equal "CP932", l(:general_pdf_encoding)
452 452 end
453 453 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
454 454 next
455 455 end
456 456 end
457 457
458 458 get :index, :format => 'pdf'
459 459 assert_response :success
460 460 assert_not_nil assigns(:issues)
461 461 assert_equal 'application/pdf', @response.content_type
462 462
463 463 get :index, :project_id => 1, :format => 'pdf'
464 464 assert_response :success
465 465 assert_not_nil assigns(:issues)
466 466 assert_equal 'application/pdf', @response.content_type
467 467
468 468 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
469 469 assert_response :success
470 470 assert_not_nil assigns(:issues)
471 471 assert_equal 'application/pdf', @response.content_type
472 472 end
473 473 end
474 474 end
475 475
476 476 def test_index_pdf_with_query_grouped_by_list_custom_field
477 477 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
478 478 assert_response :success
479 479 assert_not_nil assigns(:issues)
480 480 assert_not_nil assigns(:issue_count_by_group)
481 481 assert_equal 'application/pdf', @response.content_type
482 482 end
483 483
484 484 def test_index_sort
485 485 get :index, :sort => 'tracker,id:desc'
486 486 assert_response :success
487 487
488 488 sort_params = @request.session['issues_index_sort']
489 489 assert sort_params.is_a?(String)
490 490 assert_equal 'tracker,id:desc', sort_params
491 491
492 492 issues = assigns(:issues)
493 493 assert_not_nil issues
494 494 assert !issues.empty?
495 495 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
496 496 end
497 497
498 498 def test_index_sort_by_field_not_included_in_columns
499 499 Setting.issue_list_default_columns = %w(subject author)
500 500 get :index, :sort => 'tracker'
501 501 end
502 502
503 503 def test_index_sort_by_assigned_to
504 504 get :index, :sort => 'assigned_to'
505 505 assert_response :success
506 506 assignees = assigns(:issues).collect(&:assigned_to).compact
507 507 assert_equal assignees.sort, assignees
508 508 end
509 509
510 510 def test_index_sort_by_assigned_to_desc
511 511 get :index, :sort => 'assigned_to:desc'
512 512 assert_response :success
513 513 assignees = assigns(:issues).collect(&:assigned_to).compact
514 514 assert_equal assignees.sort.reverse, assignees
515 515 end
516 516
517 517 def test_index_group_by_assigned_to
518 518 get :index, :group_by => 'assigned_to', :sort => 'priority'
519 519 assert_response :success
520 520 end
521 521
522 522 def test_index_sort_by_author
523 523 get :index, :sort => 'author'
524 524 assert_response :success
525 525 authors = assigns(:issues).collect(&:author)
526 526 assert_equal authors.sort, authors
527 527 end
528 528
529 529 def test_index_sort_by_author_desc
530 530 get :index, :sort => 'author:desc'
531 531 assert_response :success
532 532 authors = assigns(:issues).collect(&:author)
533 533 assert_equal authors.sort.reverse, authors
534 534 end
535 535
536 536 def test_index_group_by_author
537 537 get :index, :group_by => 'author', :sort => 'priority'
538 538 assert_response :success
539 539 end
540 540
541 541 def test_index_with_columns
542 542 columns = ['tracker', 'subject', 'assigned_to']
543 543 get :index, :set_filter => 1, :c => columns
544 544 assert_response :success
545 545
546 546 # query should use specified columns
547 547 query = assigns(:query)
548 548 assert_kind_of Query, query
549 549 assert_equal columns, query.column_names.map(&:to_s)
550 550
551 551 # columns should be stored in session
552 552 assert_kind_of Hash, session[:query]
553 553 assert_kind_of Array, session[:query][:column_names]
554 554 assert_equal columns, session[:query][:column_names].map(&:to_s)
555 555
556 556 # ensure only these columns are kept in the selected columns list
557 557 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
558 558 :children => { :count => 3 }
559 559 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
560 560 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
561 561 end
562 562
563 563 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
564 564 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
565 565 get :index, :set_filter => 1
566 566
567 567 # query should use specified columns
568 568 query = assigns(:query)
569 569 assert_kind_of Query, query
570 570 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
571 571 end
572 572
573 573 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
574 574 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
575 575 columns = ['tracker', 'subject', 'assigned_to']
576 576 get :index, :set_filter => 1, :c => columns
577 577
578 578 # query should use specified columns
579 579 query = assigns(:query)
580 580 assert_kind_of Query, query
581 581 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
582 582 end
583 583
584 584 def test_index_with_custom_field_column
585 585 columns = %w(tracker subject cf_2)
586 586 get :index, :set_filter => 1, :c => columns
587 587 assert_response :success
588 588
589 589 # query should use specified columns
590 590 query = assigns(:query)
591 591 assert_kind_of Query, query
592 592 assert_equal columns, query.column_names.map(&:to_s)
593 593
594 594 assert_tag :td,
595 595 :attributes => {:class => 'cf_2 string'},
596 596 :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
597 597 end
598 598
599 def test_index_with_date_column
600 Issue.find(1).update_attribute :start_date, '1987-08-24'
601
602 with_settings :date_format => '%d/%m/%Y' do
603 get :index, :set_filter => 1, :c => %w(start_date)
604 assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
605 end
606 end
607
608 def test_index_with_done_ratio
609 Issue.find(1).update_attribute :done_ratio, 40
610
611 get :index, :set_filter => 1, :c => %w(done_ratio)
612 assert_tag 'td', :attributes => {:class => /done_ratio/},
613 :child => {:tag => 'table', :attributes => {:class => 'progress'},
614 :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
615 }
616 end
617
618 def test_index_with_fixed_version
619 get :index, :set_filter => 1, :c => %w(fixed_version)
620 assert_tag 'td', :attributes => {:class => /fixed_version/},
621 :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
622 end
623
599 624 def test_index_send_html_if_query_is_invalid
600 625 get :index, :f => ['start_date'], :op => {:start_date => '='}
601 626 assert_equal 'text/html', @response.content_type
602 627 assert_template 'index'
603 628 end
604 629
605 630 def test_index_send_nothing_if_query_is_invalid
606 631 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
607 632 assert_equal 'text/csv', @response.content_type
608 633 assert @response.body.blank?
609 634 end
610 635
611 636 def test_show_by_anonymous
612 637 get :show, :id => 1
613 638 assert_response :success
614 639 assert_template 'show'
615 640 assert_not_nil assigns(:issue)
616 641 assert_equal Issue.find(1), assigns(:issue)
617 642
618 643 # anonymous role is allowed to add a note
619 644 assert_tag :tag => 'form',
620 645 :descendant => { :tag => 'fieldset',
621 646 :child => { :tag => 'legend',
622 647 :content => /Notes/ } }
623 648 assert_tag :tag => 'title',
624 649 :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
625 650 end
626 651
627 652 def test_show_by_manager
628 653 @request.session[:user_id] = 2
629 654 get :show, :id => 1
630 655 assert_response :success
631 656
632 657 assert_tag :tag => 'a',
633 658 :content => /Quote/
634 659
635 660 assert_tag :tag => 'form',
636 661 :descendant => { :tag => 'fieldset',
637 662 :child => { :tag => 'legend',
638 663 :content => /Change properties/ } },
639 664 :descendant => { :tag => 'fieldset',
640 665 :child => { :tag => 'legend',
641 666 :content => /Log time/ } },
642 667 :descendant => { :tag => 'fieldset',
643 668 :child => { :tag => 'legend',
644 669 :content => /Notes/ } }
645 670 end
646 671
647 672 def test_update_form_should_not_display_inactive_enumerations
648 673 @request.session[:user_id] = 2
649 674 get :show, :id => 1
650 675 assert_response :success
651 676
652 677 assert ! IssuePriority.find(15).active?
653 678 assert_no_tag :option, :attributes => {:value => '15'},
654 679 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
655 680 end
656 681
657 682 def test_update_form_should_allow_attachment_upload
658 683 @request.session[:user_id] = 2
659 684 get :show, :id => 1
660 685
661 686 assert_tag :tag => 'form',
662 687 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
663 688 :descendant => {
664 689 :tag => 'input',
665 690 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
666 691 }
667 692 end
668 693
669 694 def test_show_should_deny_anonymous_access_without_permission
670 695 Role.anonymous.remove_permission!(:view_issues)
671 696 get :show, :id => 1
672 697 assert_response :redirect
673 698 end
674 699
675 700 def test_show_should_deny_anonymous_access_to_private_issue
676 701 Issue.update_all(["is_private = ?", true], "id = 1")
677 702 get :show, :id => 1
678 703 assert_response :redirect
679 704 end
680 705
681 706 def test_show_should_deny_non_member_access_without_permission
682 707 Role.non_member.remove_permission!(:view_issues)
683 708 @request.session[:user_id] = 9
684 709 get :show, :id => 1
685 710 assert_response 403
686 711 end
687 712
688 713 def test_show_should_deny_non_member_access_to_private_issue
689 714 Issue.update_all(["is_private = ?", true], "id = 1")
690 715 @request.session[:user_id] = 9
691 716 get :show, :id => 1
692 717 assert_response 403
693 718 end
694 719
695 720 def test_show_should_deny_member_access_without_permission
696 721 Role.find(1).remove_permission!(:view_issues)
697 722 @request.session[:user_id] = 2
698 723 get :show, :id => 1
699 724 assert_response 403
700 725 end
701 726
702 727 def test_show_should_deny_member_access_to_private_issue_without_permission
703 728 Issue.update_all(["is_private = ?", true], "id = 1")
704 729 @request.session[:user_id] = 3
705 730 get :show, :id => 1
706 731 assert_response 403
707 732 end
708 733
709 734 def test_show_should_allow_author_access_to_private_issue
710 735 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
711 736 @request.session[:user_id] = 3
712 737 get :show, :id => 1
713 738 assert_response :success
714 739 end
715 740
716 741 def test_show_should_allow_assignee_access_to_private_issue
717 742 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
718 743 @request.session[:user_id] = 3
719 744 get :show, :id => 1
720 745 assert_response :success
721 746 end
722 747
723 748 def test_show_should_allow_member_access_to_private_issue_with_permission
724 749 Issue.update_all(["is_private = ?", true], "id = 1")
725 750 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
726 751 @request.session[:user_id] = 3
727 752 get :show, :id => 1
728 753 assert_response :success
729 754 end
730 755
731 756 def test_show_should_not_disclose_relations_to_invisible_issues
732 757 Setting.cross_project_issue_relations = '1'
733 758 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
734 759 # Relation to a private project issue
735 760 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
736 761
737 762 get :show, :id => 1
738 763 assert_response :success
739 764
740 765 assert_tag :div, :attributes => { :id => 'relations' },
741 766 :descendant => { :tag => 'a', :content => /#2$/ }
742 767 assert_no_tag :div, :attributes => { :id => 'relations' },
743 768 :descendant => { :tag => 'a', :content => /#4$/ }
744 769 end
745 770
746 771 def test_show_atom
747 772 get :show, :id => 2, :format => 'atom'
748 773 assert_response :success
749 774 assert_template 'journals/index'
750 775 # Inline image
751 776 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
752 777 end
753 778
754 779 def test_show_export_to_pdf
755 780 get :show, :id => 3, :format => 'pdf'
756 781 assert_response :success
757 782 assert_equal 'application/pdf', @response.content_type
758 783 assert @response.body.starts_with?('%PDF')
759 784 assert_not_nil assigns(:issue)
760 785 end
761 786
762 787 def test_get_new
763 788 @request.session[:user_id] = 2
764 789 get :new, :project_id => 1, :tracker_id => 1
765 790 assert_response :success
766 791 assert_template 'new'
767 792
768 793 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
769 794 :value => 'Default string' }
770 795
771 796 # Be sure we don't display inactive IssuePriorities
772 797 assert ! IssuePriority.find(15).active?
773 798 assert_no_tag :option, :attributes => {:value => '15'},
774 799 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
775 800 end
776 801
777 802 def test_get_new_without_default_start_date_is_creation_date
778 803 Setting.default_issue_start_date_to_creation_date = 0
779 804
780 805 @request.session[:user_id] = 2
781 806 get :new, :project_id => 1, :tracker_id => 1
782 807 assert_response :success
783 808 assert_template 'new'
784 809
785 810 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
786 811 :value => nil }
787 812 end
788 813
789 814 def test_get_new_with_default_start_date_is_creation_date
790 815 Setting.default_issue_start_date_to_creation_date = 1
791 816
792 817 @request.session[:user_id] = 2
793 818 get :new, :project_id => 1, :tracker_id => 1
794 819 assert_response :success
795 820 assert_template 'new'
796 821
797 822 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
798 823 :value => Date.today.to_s }
799 824 end
800 825
801 826 def test_get_new_form_should_allow_attachment_upload
802 827 @request.session[:user_id] = 2
803 828 get :new, :project_id => 1, :tracker_id => 1
804 829
805 830 assert_tag :tag => 'form',
806 831 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
807 832 :descendant => {
808 833 :tag => 'input',
809 834 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
810 835 }
811 836 end
812 837
813 838 def test_get_new_without_tracker_id
814 839 @request.session[:user_id] = 2
815 840 get :new, :project_id => 1
816 841 assert_response :success
817 842 assert_template 'new'
818 843
819 844 issue = assigns(:issue)
820 845 assert_not_nil issue
821 846 assert_equal Project.find(1).trackers.first, issue.tracker
822 847 end
823 848
824 849 def test_get_new_with_no_default_status_should_display_an_error
825 850 @request.session[:user_id] = 2
826 851 IssueStatus.delete_all
827 852
828 853 get :new, :project_id => 1
829 854 assert_response 500
830 855 assert_error_tag :content => /No default issue/
831 856 end
832 857
833 858 def test_get_new_with_no_tracker_should_display_an_error
834 859 @request.session[:user_id] = 2
835 860 Tracker.delete_all
836 861
837 862 get :new, :project_id => 1
838 863 assert_response 500
839 864 assert_error_tag :content => /No tracker/
840 865 end
841 866
842 867 def test_update_new_form
843 868 @request.session[:user_id] = 2
844 869 xhr :post, :new, :project_id => 1,
845 870 :issue => {:tracker_id => 2,
846 871 :subject => 'This is the test_new issue',
847 872 :description => 'This is the description',
848 873 :priority_id => 5}
849 874 assert_response :success
850 875 assert_template 'attributes'
851 876
852 877 issue = assigns(:issue)
853 878 assert_kind_of Issue, issue
854 879 assert_equal 1, issue.project_id
855 880 assert_equal 2, issue.tracker_id
856 881 assert_equal 'This is the test_new issue', issue.subject
857 882 end
858 883
859 884 def test_post_create
860 885 @request.session[:user_id] = 2
861 886 assert_difference 'Issue.count' do
862 887 post :create, :project_id => 1,
863 888 :issue => {:tracker_id => 3,
864 889 :status_id => 2,
865 890 :subject => 'This is the test_new issue',
866 891 :description => 'This is the description',
867 892 :priority_id => 5,
868 893 :start_date => '2010-11-07',
869 894 :estimated_hours => '',
870 895 :custom_field_values => {'2' => 'Value for field 2'}}
871 896 end
872 897 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
873 898
874 899 issue = Issue.find_by_subject('This is the test_new issue')
875 900 assert_not_nil issue
876 901 assert_equal 2, issue.author_id
877 902 assert_equal 3, issue.tracker_id
878 903 assert_equal 2, issue.status_id
879 904 assert_equal Date.parse('2010-11-07'), issue.start_date
880 905 assert_nil issue.estimated_hours
881 906 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
882 907 assert_not_nil v
883 908 assert_equal 'Value for field 2', v.value
884 909 end
885 910
886 911 def test_post_new_with_group_assignment
887 912 group = Group.find(11)
888 913 project = Project.find(1)
889 914 project.members << Member.new(:principal => group, :roles => [Role.first])
890 915
891 916 with_settings :issue_group_assignment => '1' do
892 917 @request.session[:user_id] = 2
893 918 assert_difference 'Issue.count' do
894 919 post :create, :project_id => project.id,
895 920 :issue => {:tracker_id => 3,
896 921 :status_id => 1,
897 922 :subject => 'This is the test_new_with_group_assignment issue',
898 923 :assigned_to_id => group.id}
899 924 end
900 925 end
901 926 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
902 927
903 928 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
904 929 assert_not_nil issue
905 930 assert_equal group, issue.assigned_to
906 931 end
907 932
908 933 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
909 934 Setting.default_issue_start_date_to_creation_date = 0
910 935
911 936 @request.session[:user_id] = 2
912 937 assert_difference 'Issue.count' do
913 938 post :create, :project_id => 1,
914 939 :issue => {:tracker_id => 3,
915 940 :status_id => 2,
916 941 :subject => 'This is the test_new issue',
917 942 :description => 'This is the description',
918 943 :priority_id => 5,
919 944 :estimated_hours => '',
920 945 :custom_field_values => {'2' => 'Value for field 2'}}
921 946 end
922 947 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
923 948
924 949 issue = Issue.find_by_subject('This is the test_new issue')
925 950 assert_not_nil issue
926 951 assert_nil issue.start_date
927 952 end
928 953
929 954 def test_post_create_without_start_date_and_default_start_date_is_creation_date
930 955 Setting.default_issue_start_date_to_creation_date = 1
931 956
932 957 @request.session[:user_id] = 2
933 958 assert_difference 'Issue.count' do
934 959 post :create, :project_id => 1,
935 960 :issue => {:tracker_id => 3,
936 961 :status_id => 2,
937 962 :subject => 'This is the test_new issue',
938 963 :description => 'This is the description',
939 964 :priority_id => 5,
940 965 :estimated_hours => '',
941 966 :custom_field_values => {'2' => 'Value for field 2'}}
942 967 end
943 968 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
944 969
945 970 issue = Issue.find_by_subject('This is the test_new issue')
946 971 assert_not_nil issue
947 972 assert_equal Date.today, issue.start_date
948 973 end
949 974
950 975 def test_post_create_and_continue
951 976 @request.session[:user_id] = 2
952 977 assert_difference 'Issue.count' do
953 978 post :create, :project_id => 1,
954 979 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
955 980 :continue => ''
956 981 end
957 982
958 983 issue = Issue.first(:order => 'id DESC')
959 984 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
960 985 assert_not_nil flash[:notice], "flash was not set"
961 986 assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
962 987 end
963 988
964 989 def test_post_create_without_custom_fields_param
965 990 @request.session[:user_id] = 2
966 991 assert_difference 'Issue.count' do
967 992 post :create, :project_id => 1,
968 993 :issue => {:tracker_id => 1,
969 994 :subject => 'This is the test_new issue',
970 995 :description => 'This is the description',
971 996 :priority_id => 5}
972 997 end
973 998 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
974 999 end
975 1000
976 1001 def test_post_create_with_required_custom_field_and_without_custom_fields_param
977 1002 field = IssueCustomField.find_by_name('Database')
978 1003 field.update_attribute(:is_required, true)
979 1004
980 1005 @request.session[:user_id] = 2
981 1006 post :create, :project_id => 1,
982 1007 :issue => {:tracker_id => 1,
983 1008 :subject => 'This is the test_new issue',
984 1009 :description => 'This is the description',
985 1010 :priority_id => 5}
986 1011 assert_response :success
987 1012 assert_template 'new'
988 1013 issue = assigns(:issue)
989 1014 assert_not_nil issue
990 1015 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
991 1016 end
992 1017
993 1018 def test_post_create_with_watchers
994 1019 @request.session[:user_id] = 2
995 1020 ActionMailer::Base.deliveries.clear
996 1021
997 1022 assert_difference 'Watcher.count', 2 do
998 1023 post :create, :project_id => 1,
999 1024 :issue => {:tracker_id => 1,
1000 1025 :subject => 'This is a new issue with watchers',
1001 1026 :description => 'This is the description',
1002 1027 :priority_id => 5,
1003 1028 :watcher_user_ids => ['2', '3']}
1004 1029 end
1005 1030 issue = Issue.find_by_subject('This is a new issue with watchers')
1006 1031 assert_not_nil issue
1007 1032 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1008 1033
1009 1034 # Watchers added
1010 1035 assert_equal [2, 3], issue.watcher_user_ids.sort
1011 1036 assert issue.watched_by?(User.find(3))
1012 1037 # Watchers notified
1013 1038 mail = ActionMailer::Base.deliveries.last
1014 1039 assert_kind_of TMail::Mail, mail
1015 1040 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1016 1041 end
1017 1042
1018 1043 def test_post_create_subissue
1019 1044 @request.session[:user_id] = 2
1020 1045
1021 1046 assert_difference 'Issue.count' do
1022 1047 post :create, :project_id => 1,
1023 1048 :issue => {:tracker_id => 1,
1024 1049 :subject => 'This is a child issue',
1025 1050 :parent_issue_id => 2}
1026 1051 end
1027 1052 issue = Issue.find_by_subject('This is a child issue')
1028 1053 assert_not_nil issue
1029 1054 assert_equal Issue.find(2), issue.parent
1030 1055 end
1031 1056
1032 1057 def test_post_create_subissue_with_non_numeric_parent_id
1033 1058 @request.session[:user_id] = 2
1034 1059
1035 1060 assert_difference 'Issue.count' do
1036 1061 post :create, :project_id => 1,
1037 1062 :issue => {:tracker_id => 1,
1038 1063 :subject => 'This is a child issue',
1039 1064 :parent_issue_id => 'ABC'}
1040 1065 end
1041 1066 issue = Issue.find_by_subject('This is a child issue')
1042 1067 assert_not_nil issue
1043 1068 assert_nil issue.parent
1044 1069 end
1045 1070
1046 1071 def test_post_create_private
1047 1072 @request.session[:user_id] = 2
1048 1073
1049 1074 assert_difference 'Issue.count' do
1050 1075 post :create, :project_id => 1,
1051 1076 :issue => {:tracker_id => 1,
1052 1077 :subject => 'This is a private issue',
1053 1078 :is_private => '1'}
1054 1079 end
1055 1080 issue = Issue.first(:order => 'id DESC')
1056 1081 assert issue.is_private?
1057 1082 end
1058 1083
1059 1084 def test_post_create_private_with_set_own_issues_private_permission
1060 1085 role = Role.find(1)
1061 1086 role.remove_permission! :set_issues_private
1062 1087 role.add_permission! :set_own_issues_private
1063 1088
1064 1089 @request.session[:user_id] = 2
1065 1090
1066 1091 assert_difference 'Issue.count' do
1067 1092 post :create, :project_id => 1,
1068 1093 :issue => {:tracker_id => 1,
1069 1094 :subject => 'This is a private issue',
1070 1095 :is_private => '1'}
1071 1096 end
1072 1097 issue = Issue.first(:order => 'id DESC')
1073 1098 assert issue.is_private?
1074 1099 end
1075 1100
1076 1101 def test_post_create_should_send_a_notification
1077 1102 ActionMailer::Base.deliveries.clear
1078 1103 @request.session[:user_id] = 2
1079 1104 assert_difference 'Issue.count' do
1080 1105 post :create, :project_id => 1,
1081 1106 :issue => {:tracker_id => 3,
1082 1107 :subject => 'This is the test_new issue',
1083 1108 :description => 'This is the description',
1084 1109 :priority_id => 5,
1085 1110 :estimated_hours => '',
1086 1111 :custom_field_values => {'2' => 'Value for field 2'}}
1087 1112 end
1088 1113 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1089 1114
1090 1115 assert_equal 1, ActionMailer::Base.deliveries.size
1091 1116 end
1092 1117
1093 1118 def test_post_create_should_preserve_fields_values_on_validation_failure
1094 1119 @request.session[:user_id] = 2
1095 1120 post :create, :project_id => 1,
1096 1121 :issue => {:tracker_id => 1,
1097 1122 # empty subject
1098 1123 :subject => '',
1099 1124 :description => 'This is a description',
1100 1125 :priority_id => 6,
1101 1126 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
1102 1127 assert_response :success
1103 1128 assert_template 'new'
1104 1129
1105 1130 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
1106 1131 :content => 'This is a description'
1107 1132 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1108 1133 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1109 1134 :value => '6' },
1110 1135 :content => 'High' }
1111 1136 # Custom fields
1112 1137 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
1113 1138 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1114 1139 :value => 'Oracle' },
1115 1140 :content => 'Oracle' }
1116 1141 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
1117 1142 :value => 'Value for field 2'}
1118 1143 end
1119 1144
1120 1145 def test_post_create_should_ignore_non_safe_attributes
1121 1146 @request.session[:user_id] = 2
1122 1147 assert_nothing_raised do
1123 1148 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
1124 1149 end
1125 1150 end
1126 1151
1127 1152 def test_post_create_with_attachment
1128 1153 set_tmp_attachments_directory
1129 1154 @request.session[:user_id] = 2
1130 1155
1131 1156 assert_difference 'Issue.count' do
1132 1157 assert_difference 'Attachment.count' do
1133 1158 post :create, :project_id => 1,
1134 1159 :issue => { :tracker_id => '1', :subject => 'With attachment' },
1135 1160 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1136 1161 end
1137 1162 end
1138 1163
1139 1164 issue = Issue.first(:order => 'id DESC')
1140 1165 attachment = Attachment.first(:order => 'id DESC')
1141 1166
1142 1167 assert_equal issue, attachment.container
1143 1168 assert_equal 2, attachment.author_id
1144 1169 assert_equal 'testfile.txt', attachment.filename
1145 1170 assert_equal 'text/plain', attachment.content_type
1146 1171 assert_equal 'test file', attachment.description
1147 1172 assert_equal 59, attachment.filesize
1148 1173 assert File.exists?(attachment.diskfile)
1149 1174 assert_equal 59, File.size(attachment.diskfile)
1150 1175 end
1151 1176
1152 1177 context "without workflow privilege" do
1153 1178 setup do
1154 1179 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1155 1180 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1156 1181 end
1157 1182
1158 1183 context "#new" do
1159 1184 should "propose default status only" do
1160 1185 get :new, :project_id => 1
1161 1186 assert_response :success
1162 1187 assert_template 'new'
1163 1188 assert_tag :tag => 'select',
1164 1189 :attributes => {:name => 'issue[status_id]'},
1165 1190 :children => {:count => 1},
1166 1191 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
1167 1192 end
1168 1193
1169 1194 should "accept default status" do
1170 1195 assert_difference 'Issue.count' do
1171 1196 post :create, :project_id => 1,
1172 1197 :issue => {:tracker_id => 1,
1173 1198 :subject => 'This is an issue',
1174 1199 :status_id => 1}
1175 1200 end
1176 1201 issue = Issue.last(:order => 'id')
1177 1202 assert_equal IssueStatus.default, issue.status
1178 1203 end
1179 1204
1180 1205 should "ignore unauthorized status" do
1181 1206 assert_difference 'Issue.count' do
1182 1207 post :create, :project_id => 1,
1183 1208 :issue => {:tracker_id => 1,
1184 1209 :subject => 'This is an issue',
1185 1210 :status_id => 3}
1186 1211 end
1187 1212 issue = Issue.last(:order => 'id')
1188 1213 assert_equal IssueStatus.default, issue.status
1189 1214 end
1190 1215 end
1191 1216
1192 1217 context "#update" do
1193 1218 should "ignore status change" do
1194 1219 assert_difference 'Journal.count' do
1195 1220 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1196 1221 end
1197 1222 assert_equal 1, Issue.find(1).status_id
1198 1223 end
1199 1224
1200 1225 should "ignore attributes changes" do
1201 1226 assert_difference 'Journal.count' do
1202 1227 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1203 1228 end
1204 1229 issue = Issue.find(1)
1205 1230 assert_equal "Can't print recipes", issue.subject
1206 1231 assert_nil issue.assigned_to
1207 1232 end
1208 1233 end
1209 1234 end
1210 1235
1211 1236 context "with workflow privilege" do
1212 1237 setup do
1213 1238 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1214 1239 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
1215 1240 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
1216 1241 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1217 1242 end
1218 1243
1219 1244 context "#update" do
1220 1245 should "accept authorized status" do
1221 1246 assert_difference 'Journal.count' do
1222 1247 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1223 1248 end
1224 1249 assert_equal 3, Issue.find(1).status_id
1225 1250 end
1226 1251
1227 1252 should "ignore unauthorized status" do
1228 1253 assert_difference 'Journal.count' do
1229 1254 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1230 1255 end
1231 1256 assert_equal 1, Issue.find(1).status_id
1232 1257 end
1233 1258
1234 1259 should "accept authorized attributes changes" do
1235 1260 assert_difference 'Journal.count' do
1236 1261 put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
1237 1262 end
1238 1263 issue = Issue.find(1)
1239 1264 assert_equal 2, issue.assigned_to_id
1240 1265 end
1241 1266
1242 1267 should "ignore unauthorized attributes changes" do
1243 1268 assert_difference 'Journal.count' do
1244 1269 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
1245 1270 end
1246 1271 issue = Issue.find(1)
1247 1272 assert_equal "Can't print recipes", issue.subject
1248 1273 end
1249 1274 end
1250 1275
1251 1276 context "and :edit_issues permission" do
1252 1277 setup do
1253 1278 Role.anonymous.add_permission! :add_issues, :edit_issues
1254 1279 end
1255 1280
1256 1281 should "accept authorized status" do
1257 1282 assert_difference 'Journal.count' do
1258 1283 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1259 1284 end
1260 1285 assert_equal 3, Issue.find(1).status_id
1261 1286 end
1262 1287
1263 1288 should "ignore unauthorized status" do
1264 1289 assert_difference 'Journal.count' do
1265 1290 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1266 1291 end
1267 1292 assert_equal 1, Issue.find(1).status_id
1268 1293 end
1269 1294
1270 1295 should "accept authorized attributes changes" do
1271 1296 assert_difference 'Journal.count' do
1272 1297 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1273 1298 end
1274 1299 issue = Issue.find(1)
1275 1300 assert_equal "changed", issue.subject
1276 1301 assert_equal 2, issue.assigned_to_id
1277 1302 end
1278 1303 end
1279 1304 end
1280 1305
1281 1306 def test_copy_issue
1282 1307 @request.session[:user_id] = 2
1283 1308 get :new, :project_id => 1, :copy_from => 1
1284 1309 assert_template 'new'
1285 1310 assert_not_nil assigns(:issue)
1286 1311 orig = Issue.find(1)
1287 1312 assert_equal orig.subject, assigns(:issue).subject
1288 1313 end
1289 1314
1290 1315 def test_get_edit
1291 1316 @request.session[:user_id] = 2
1292 1317 get :edit, :id => 1
1293 1318 assert_response :success
1294 1319 assert_template 'edit'
1295 1320 assert_not_nil assigns(:issue)
1296 1321 assert_equal Issue.find(1), assigns(:issue)
1297 1322
1298 1323 # Be sure we don't display inactive IssuePriorities
1299 1324 assert ! IssuePriority.find(15).active?
1300 1325 assert_no_tag :option, :attributes => {:value => '15'},
1301 1326 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1302 1327 end
1303 1328
1304 1329 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
1305 1330 @request.session[:user_id] = 2
1306 1331 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
1307 1332
1308 1333 get :edit, :id => 1
1309 1334 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1310 1335 end
1311 1336
1312 1337 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
1313 1338 @request.session[:user_id] = 2
1314 1339 Role.find_by_name('Manager').remove_permission! :log_time
1315 1340
1316 1341 get :edit, :id => 1
1317 1342 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1318 1343 end
1319 1344
1320 1345 def test_get_edit_with_params
1321 1346 @request.session[:user_id] = 2
1322 1347 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
1323 1348 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
1324 1349 assert_response :success
1325 1350 assert_template 'edit'
1326 1351
1327 1352 issue = assigns(:issue)
1328 1353 assert_not_nil issue
1329 1354
1330 1355 assert_equal 5, issue.status_id
1331 1356 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
1332 1357 :child => { :tag => 'option',
1333 1358 :content => 'Closed',
1334 1359 :attributes => { :selected => 'selected' } }
1335 1360
1336 1361 assert_equal 7, issue.priority_id
1337 1362 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1338 1363 :child => { :tag => 'option',
1339 1364 :content => 'Urgent',
1340 1365 :attributes => { :selected => 'selected' } }
1341 1366
1342 1367 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
1343 1368 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
1344 1369 :child => { :tag => 'option',
1345 1370 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
1346 1371 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
1347 1372 end
1348 1373
1349 1374 def test_update_edit_form
1350 1375 @request.session[:user_id] = 2
1351 1376 xhr :post, :new, :project_id => 1,
1352 1377 :id => 1,
1353 1378 :issue => {:tracker_id => 2,
1354 1379 :subject => 'This is the test_new issue',
1355 1380 :description => 'This is the description',
1356 1381 :priority_id => 5}
1357 1382 assert_response :success
1358 1383 assert_template 'attributes'
1359 1384
1360 1385 issue = assigns(:issue)
1361 1386 assert_kind_of Issue, issue
1362 1387 assert_equal 1, issue.id
1363 1388 assert_equal 1, issue.project_id
1364 1389 assert_equal 2, issue.tracker_id
1365 1390 assert_equal 'This is the test_new issue', issue.subject
1366 1391 end
1367 1392
1368 1393 def test_update_using_invalid_http_verbs
1369 1394 @request.session[:user_id] = 2
1370 1395 subject = 'Updated by an invalid http verb'
1371 1396
1372 1397 get :update, :id => 1, :issue => {:subject => subject}
1373 1398 assert_not_equal subject, Issue.find(1).subject
1374 1399
1375 1400 post :update, :id => 1, :issue => {:subject => subject}
1376 1401 assert_not_equal subject, Issue.find(1).subject
1377 1402
1378 1403 delete :update, :id => 1, :issue => {:subject => subject}
1379 1404 assert_not_equal subject, Issue.find(1).subject
1380 1405 end
1381 1406
1382 1407 def test_put_update_without_custom_fields_param
1383 1408 @request.session[:user_id] = 2
1384 1409 ActionMailer::Base.deliveries.clear
1385 1410
1386 1411 issue = Issue.find(1)
1387 1412 assert_equal '125', issue.custom_value_for(2).value
1388 1413 old_subject = issue.subject
1389 1414 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1390 1415
1391 1416 assert_difference('Journal.count') do
1392 1417 assert_difference('JournalDetail.count', 2) do
1393 1418 put :update, :id => 1, :issue => {:subject => new_subject,
1394 1419 :priority_id => '6',
1395 1420 :category_id => '1' # no change
1396 1421 }
1397 1422 end
1398 1423 end
1399 1424 assert_redirected_to :action => 'show', :id => '1'
1400 1425 issue.reload
1401 1426 assert_equal new_subject, issue.subject
1402 1427 # Make sure custom fields were not cleared
1403 1428 assert_equal '125', issue.custom_value_for(2).value
1404 1429
1405 1430 mail = ActionMailer::Base.deliveries.last
1406 1431 assert_kind_of TMail::Mail, mail
1407 1432 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
1408 1433 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
1409 1434 end
1410 1435
1411 1436 def test_put_update_with_custom_field_change
1412 1437 @request.session[:user_id] = 2
1413 1438 issue = Issue.find(1)
1414 1439 assert_equal '125', issue.custom_value_for(2).value
1415 1440
1416 1441 assert_difference('Journal.count') do
1417 1442 assert_difference('JournalDetail.count', 3) do
1418 1443 put :update, :id => 1, :issue => {:subject => 'Custom field change',
1419 1444 :priority_id => '6',
1420 1445 :category_id => '1', # no change
1421 1446 :custom_field_values => { '2' => 'New custom value' }
1422 1447 }
1423 1448 end
1424 1449 end
1425 1450 assert_redirected_to :action => 'show', :id => '1'
1426 1451 issue.reload
1427 1452 assert_equal 'New custom value', issue.custom_value_for(2).value
1428 1453
1429 1454 mail = ActionMailer::Base.deliveries.last
1430 1455 assert_kind_of TMail::Mail, mail
1431 1456 assert mail.body.include?("Searchable field changed from 125 to New custom value")
1432 1457 end
1433 1458
1434 1459 def test_put_update_with_status_and_assignee_change
1435 1460 issue = Issue.find(1)
1436 1461 assert_equal 1, issue.status_id
1437 1462 @request.session[:user_id] = 2
1438 1463 assert_difference('TimeEntry.count', 0) do
1439 1464 put :update,
1440 1465 :id => 1,
1441 1466 :issue => { :status_id => 2, :assigned_to_id => 3 },
1442 1467 :notes => 'Assigned to dlopper',
1443 1468 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
1444 1469 end
1445 1470 assert_redirected_to :action => 'show', :id => '1'
1446 1471 issue.reload
1447 1472 assert_equal 2, issue.status_id
1448 1473 j = Journal.find(:first, :order => 'id DESC')
1449 1474 assert_equal 'Assigned to dlopper', j.notes
1450 1475 assert_equal 2, j.details.size
1451 1476
1452 1477 mail = ActionMailer::Base.deliveries.last
1453 1478 assert mail.body.include?("Status changed from New to Assigned")
1454 1479 # subject should contain the new status
1455 1480 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
1456 1481 end
1457 1482
1458 1483 def test_put_update_with_note_only
1459 1484 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
1460 1485 # anonymous user
1461 1486 put :update,
1462 1487 :id => 1,
1463 1488 :notes => notes
1464 1489 assert_redirected_to :action => 'show', :id => '1'
1465 1490 j = Journal.find(:first, :order => 'id DESC')
1466 1491 assert_equal notes, j.notes
1467 1492 assert_equal 0, j.details.size
1468 1493 assert_equal User.anonymous, j.user
1469 1494
1470 1495 mail = ActionMailer::Base.deliveries.last
1471 1496 assert mail.body.include?(notes)
1472 1497 end
1473 1498
1474 1499 def test_put_update_with_note_and_spent_time
1475 1500 @request.session[:user_id] = 2
1476 1501 spent_hours_before = Issue.find(1).spent_hours
1477 1502 assert_difference('TimeEntry.count') do
1478 1503 put :update,
1479 1504 :id => 1,
1480 1505 :notes => '2.5 hours added',
1481 1506 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
1482 1507 end
1483 1508 assert_redirected_to :action => 'show', :id => '1'
1484 1509
1485 1510 issue = Issue.find(1)
1486 1511
1487 1512 j = Journal.find(:first, :order => 'id DESC')
1488 1513 assert_equal '2.5 hours added', j.notes
1489 1514 assert_equal 0, j.details.size
1490 1515
1491 1516 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
1492 1517 assert_not_nil t
1493 1518 assert_equal 2.5, t.hours
1494 1519 assert_equal spent_hours_before + 2.5, issue.spent_hours
1495 1520 end
1496 1521
1497 1522 def test_put_update_with_attachment_only
1498 1523 set_tmp_attachments_directory
1499 1524
1500 1525 # Delete all fixtured journals, a race condition can occur causing the wrong
1501 1526 # journal to get fetched in the next find.
1502 1527 Journal.delete_all
1503 1528
1504 1529 # anonymous user
1505 1530 assert_difference 'Attachment.count' do
1506 1531 put :update, :id => 1,
1507 1532 :notes => '',
1508 1533 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1509 1534 end
1510 1535
1511 1536 assert_redirected_to :action => 'show', :id => '1'
1512 1537 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
1513 1538 assert j.notes.blank?
1514 1539 assert_equal 1, j.details.size
1515 1540 assert_equal 'testfile.txt', j.details.first.value
1516 1541 assert_equal User.anonymous, j.user
1517 1542
1518 1543 attachment = Attachment.first(:order => 'id DESC')
1519 1544 assert_equal Issue.find(1), attachment.container
1520 1545 assert_equal User.anonymous, attachment.author
1521 1546 assert_equal 'testfile.txt', attachment.filename
1522 1547 assert_equal 'text/plain', attachment.content_type
1523 1548 assert_equal 'test file', attachment.description
1524 1549 assert_equal 59, attachment.filesize
1525 1550 assert File.exists?(attachment.diskfile)
1526 1551 assert_equal 59, File.size(attachment.diskfile)
1527 1552
1528 1553 mail = ActionMailer::Base.deliveries.last
1529 1554 assert mail.body.include?('testfile.txt')
1530 1555 end
1531 1556
1532 1557 def test_put_update_with_attachment_that_fails_to_save
1533 1558 set_tmp_attachments_directory
1534 1559
1535 1560 # Delete all fixtured journals, a race condition can occur causing the wrong
1536 1561 # journal to get fetched in the next find.
1537 1562 Journal.delete_all
1538 1563
1539 1564 # Mock out the unsaved attachment
1540 1565 Attachment.any_instance.stubs(:create).returns(Attachment.new)
1541 1566
1542 1567 # anonymous user
1543 1568 put :update,
1544 1569 :id => 1,
1545 1570 :notes => '',
1546 1571 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
1547 1572 assert_redirected_to :action => 'show', :id => '1'
1548 1573 assert_equal '1 file(s) could not be saved.', flash[:warning]
1549 1574
1550 1575 end if Object.const_defined?(:Mocha)
1551 1576
1552 1577 def test_put_update_with_no_change
1553 1578 issue = Issue.find(1)
1554 1579 issue.journals.clear
1555 1580 ActionMailer::Base.deliveries.clear
1556 1581
1557 1582 put :update,
1558 1583 :id => 1,
1559 1584 :notes => ''
1560 1585 assert_redirected_to :action => 'show', :id => '1'
1561 1586
1562 1587 issue.reload
1563 1588 assert issue.journals.empty?
1564 1589 # No email should be sent
1565 1590 assert ActionMailer::Base.deliveries.empty?
1566 1591 end
1567 1592
1568 1593 def test_put_update_should_send_a_notification
1569 1594 @request.session[:user_id] = 2
1570 1595 ActionMailer::Base.deliveries.clear
1571 1596 issue = Issue.find(1)
1572 1597 old_subject = issue.subject
1573 1598 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1574 1599
1575 1600 put :update, :id => 1, :issue => {:subject => new_subject,
1576 1601 :priority_id => '6',
1577 1602 :category_id => '1' # no change
1578 1603 }
1579 1604 assert_equal 1, ActionMailer::Base.deliveries.size
1580 1605 end
1581 1606
1582 1607 def test_put_update_with_invalid_spent_time_hours_only
1583 1608 @request.session[:user_id] = 2
1584 1609 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1585 1610
1586 1611 assert_no_difference('Journal.count') do
1587 1612 put :update,
1588 1613 :id => 1,
1589 1614 :notes => notes,
1590 1615 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
1591 1616 end
1592 1617 assert_response :success
1593 1618 assert_template 'edit'
1594 1619
1595 1620 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1596 1621 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1597 1622 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
1598 1623 end
1599 1624
1600 1625 def test_put_update_with_invalid_spent_time_comments_only
1601 1626 @request.session[:user_id] = 2
1602 1627 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1603 1628
1604 1629 assert_no_difference('Journal.count') do
1605 1630 put :update,
1606 1631 :id => 1,
1607 1632 :notes => notes,
1608 1633 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
1609 1634 end
1610 1635 assert_response :success
1611 1636 assert_template 'edit'
1612 1637
1613 1638 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1614 1639 assert_error_tag :descendant => {:content => /Hours can't be blank/}
1615 1640 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1616 1641 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
1617 1642 end
1618 1643
1619 1644 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1620 1645 issue = Issue.find(2)
1621 1646 @request.session[:user_id] = 2
1622 1647
1623 1648 put :update,
1624 1649 :id => issue.id,
1625 1650 :issue => {
1626 1651 :fixed_version_id => 4
1627 1652 }
1628 1653
1629 1654 assert_response :redirect
1630 1655 issue.reload
1631 1656 assert_equal 4, issue.fixed_version_id
1632 1657 assert_not_equal issue.project_id, issue.fixed_version.project_id
1633 1658 end
1634 1659
1635 1660 def test_put_update_should_redirect_back_using_the_back_url_parameter
1636 1661 issue = Issue.find(2)
1637 1662 @request.session[:user_id] = 2
1638 1663
1639 1664 put :update,
1640 1665 :id => issue.id,
1641 1666 :issue => {
1642 1667 :fixed_version_id => 4
1643 1668 },
1644 1669 :back_url => '/issues'
1645 1670
1646 1671 assert_response :redirect
1647 1672 assert_redirected_to '/issues'
1648 1673 end
1649 1674
1650 1675 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1651 1676 issue = Issue.find(2)
1652 1677 @request.session[:user_id] = 2
1653 1678
1654 1679 put :update,
1655 1680 :id => issue.id,
1656 1681 :issue => {
1657 1682 :fixed_version_id => 4
1658 1683 },
1659 1684 :back_url => 'http://google.com'
1660 1685
1661 1686 assert_response :redirect
1662 1687 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
1663 1688 end
1664 1689
1665 1690 def test_get_bulk_edit
1666 1691 @request.session[:user_id] = 2
1667 1692 get :bulk_edit, :ids => [1, 2]
1668 1693 assert_response :success
1669 1694 assert_template 'bulk_edit'
1670 1695
1671 1696 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
1672 1697
1673 1698 # Project specific custom field, date type
1674 1699 field = CustomField.find(9)
1675 1700 assert !field.is_for_all?
1676 1701 assert_equal 'date', field.field_format
1677 1702 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1678 1703
1679 1704 # System wide custom field
1680 1705 assert CustomField.find(1).is_for_all?
1681 1706 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
1682 1707
1683 1708 # Be sure we don't display inactive IssuePriorities
1684 1709 assert ! IssuePriority.find(15).active?
1685 1710 assert_no_tag :option, :attributes => {:value => '15'},
1686 1711 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1687 1712 end
1688 1713
1689 1714 def test_get_bulk_edit_on_different_projects
1690 1715 @request.session[:user_id] = 2
1691 1716 get :bulk_edit, :ids => [1, 2, 6]
1692 1717 assert_response :success
1693 1718 assert_template 'bulk_edit'
1694 1719
1695 1720 # Can not set issues from different projects as children of an issue
1696 1721 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
1697 1722
1698 1723 # Project specific custom field, date type
1699 1724 field = CustomField.find(9)
1700 1725 assert !field.is_for_all?
1701 1726 assert !field.project_ids.include?(Issue.find(6).project_id)
1702 1727 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1703 1728 end
1704 1729
1705 1730 def test_get_bulk_edit_with_user_custom_field
1706 1731 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
1707 1732
1708 1733 @request.session[:user_id] = 2
1709 1734 get :bulk_edit, :ids => [1, 2]
1710 1735 assert_response :success
1711 1736 assert_template 'bulk_edit'
1712 1737
1713 1738 assert_tag :select,
1714 1739 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
1715 1740 :children => {
1716 1741 :only => {:tag => 'option'},
1717 1742 :count => Project.find(1).users.count + 1
1718 1743 }
1719 1744 end
1720 1745
1721 1746 def test_get_bulk_edit_with_version_custom_field
1722 1747 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
1723 1748
1724 1749 @request.session[:user_id] = 2
1725 1750 get :bulk_edit, :ids => [1, 2]
1726 1751 assert_response :success
1727 1752 assert_template 'bulk_edit'
1728 1753
1729 1754 assert_tag :select,
1730 1755 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
1731 1756 :children => {
1732 1757 :only => {:tag => 'option'},
1733 1758 :count => Project.find(1).shared_versions.count + 1
1734 1759 }
1735 1760 end
1736 1761
1737 1762 def test_bulk_update
1738 1763 @request.session[:user_id] = 2
1739 1764 # update issues priority
1740 1765 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
1741 1766 :issue => {:priority_id => 7,
1742 1767 :assigned_to_id => '',
1743 1768 :custom_field_values => {'2' => ''}}
1744 1769
1745 1770 assert_response 302
1746 1771 # check that the issues were updated
1747 1772 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
1748 1773
1749 1774 issue = Issue.find(1)
1750 1775 journal = issue.journals.find(:first, :order => 'created_on DESC')
1751 1776 assert_equal '125', issue.custom_value_for(2).value
1752 1777 assert_equal 'Bulk editing', journal.notes
1753 1778 assert_equal 1, journal.details.size
1754 1779 end
1755 1780
1756 1781 def test_bulk_update_with_group_assignee
1757 1782 group = Group.find(11)
1758 1783 project = Project.find(1)
1759 1784 project.members << Member.new(:principal => group, :roles => [Role.first])
1760 1785
1761 1786 @request.session[:user_id] = 2
1762 1787 # update issues assignee
1763 1788 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
1764 1789 :issue => {:priority_id => '',
1765 1790 :assigned_to_id => group.id,
1766 1791 :custom_field_values => {'2' => ''}}
1767 1792
1768 1793 assert_response 302
1769 1794 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
1770 1795 end
1771 1796
1772 1797 def test_bulk_update_on_different_projects
1773 1798 @request.session[:user_id] = 2
1774 1799 # update issues priority
1775 1800 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
1776 1801 :issue => {:priority_id => 7,
1777 1802 :assigned_to_id => '',
1778 1803 :custom_field_values => {'2' => ''}}
1779 1804
1780 1805 assert_response 302
1781 1806 # check that the issues were updated
1782 1807 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
1783 1808
1784 1809 issue = Issue.find(1)
1785 1810 journal = issue.journals.find(:first, :order => 'created_on DESC')
1786 1811 assert_equal '125', issue.custom_value_for(2).value
1787 1812 assert_equal 'Bulk editing', journal.notes
1788 1813 assert_equal 1, journal.details.size
1789 1814 end
1790 1815
1791 1816 def test_bulk_update_on_different_projects_without_rights
1792 1817 @request.session[:user_id] = 3
1793 1818 user = User.find(3)
1794 1819 action = { :controller => "issues", :action => "bulk_update" }
1795 1820 assert user.allowed_to?(action, Issue.find(1).project)
1796 1821 assert ! user.allowed_to?(action, Issue.find(6).project)
1797 1822 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
1798 1823 :issue => {:priority_id => 7,
1799 1824 :assigned_to_id => '',
1800 1825 :custom_field_values => {'2' => ''}}
1801 1826 assert_response 403
1802 1827 assert_not_equal "Bulk should fail", Journal.last.notes
1803 1828 end
1804 1829
1805 1830 def test_bullk_update_should_send_a_notification
1806 1831 @request.session[:user_id] = 2
1807 1832 ActionMailer::Base.deliveries.clear
1808 1833 post(:bulk_update,
1809 1834 {
1810 1835 :ids => [1, 2],
1811 1836 :notes => 'Bulk editing',
1812 1837 :issue => {
1813 1838 :priority_id => 7,
1814 1839 :assigned_to_id => '',
1815 1840 :custom_field_values => {'2' => ''}
1816 1841 }
1817 1842 })
1818 1843
1819 1844 assert_response 302
1820 1845 assert_equal 2, ActionMailer::Base.deliveries.size
1821 1846 end
1822 1847
1823 1848 def test_bulk_update_status
1824 1849 @request.session[:user_id] = 2
1825 1850 # update issues priority
1826 1851 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
1827 1852 :issue => {:priority_id => '',
1828 1853 :assigned_to_id => '',
1829 1854 :status_id => '5'}
1830 1855
1831 1856 assert_response 302
1832 1857 issue = Issue.find(1)
1833 1858 assert issue.closed?
1834 1859 end
1835 1860
1836 1861 def test_bulk_update_parent_id
1837 1862 @request.session[:user_id] = 2
1838 1863 post :bulk_update, :ids => [1, 3],
1839 1864 :notes => 'Bulk editing parent',
1840 1865 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
1841 1866
1842 1867 assert_response 302
1843 1868 parent = Issue.find(2)
1844 1869 assert_equal parent.id, Issue.find(1).parent_id
1845 1870 assert_equal parent.id, Issue.find(3).parent_id
1846 1871 assert_equal [1, 3], parent.children.collect(&:id).sort
1847 1872 end
1848 1873
1849 1874 def test_bulk_update_custom_field
1850 1875 @request.session[:user_id] = 2
1851 1876 # update issues priority
1852 1877 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
1853 1878 :issue => {:priority_id => '',
1854 1879 :assigned_to_id => '',
1855 1880 :custom_field_values => {'2' => '777'}}
1856 1881
1857 1882 assert_response 302
1858 1883
1859 1884 issue = Issue.find(1)
1860 1885 journal = issue.journals.find(:first, :order => 'created_on DESC')
1861 1886 assert_equal '777', issue.custom_value_for(2).value
1862 1887 assert_equal 1, journal.details.size
1863 1888 assert_equal '125', journal.details.first.old_value
1864 1889 assert_equal '777', journal.details.first.value
1865 1890 end
1866 1891
1867 1892 def test_bulk_update_unassign
1868 1893 assert_not_nil Issue.find(2).assigned_to
1869 1894 @request.session[:user_id] = 2
1870 1895 # unassign issues
1871 1896 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
1872 1897 assert_response 302
1873 1898 # check that the issues were updated
1874 1899 assert_nil Issue.find(2).assigned_to
1875 1900 end
1876 1901
1877 1902 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
1878 1903 @request.session[:user_id] = 2
1879 1904
1880 1905 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
1881 1906
1882 1907 assert_response :redirect
1883 1908 issues = Issue.find([1,2])
1884 1909 issues.each do |issue|
1885 1910 assert_equal 4, issue.fixed_version_id
1886 1911 assert_not_equal issue.project_id, issue.fixed_version.project_id
1887 1912 end
1888 1913 end
1889 1914
1890 1915 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1891 1916 @request.session[:user_id] = 2
1892 1917 post :bulk_update, :ids => [1,2], :back_url => '/issues'
1893 1918
1894 1919 assert_response :redirect
1895 1920 assert_redirected_to '/issues'
1896 1921 end
1897 1922
1898 1923 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1899 1924 @request.session[:user_id] = 2
1900 1925 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1901 1926
1902 1927 assert_response :redirect
1903 1928 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
1904 1929 end
1905 1930
1906 1931 def test_destroy_issue_with_no_time_entries
1907 1932 assert_nil TimeEntry.find_by_issue_id(2)
1908 1933 @request.session[:user_id] = 2
1909 1934 post :destroy, :id => 2
1910 1935 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1911 1936 assert_nil Issue.find_by_id(2)
1912 1937 end
1913 1938
1914 1939 def test_destroy_issues_with_time_entries
1915 1940 @request.session[:user_id] = 2
1916 1941 post :destroy, :ids => [1, 3]
1917 1942 assert_response :success
1918 1943 assert_template 'destroy'
1919 1944 assert_not_nil assigns(:hours)
1920 1945 assert Issue.find_by_id(1) && Issue.find_by_id(3)
1921 1946 end
1922 1947
1923 1948 def test_destroy_issues_and_destroy_time_entries
1924 1949 @request.session[:user_id] = 2
1925 1950 post :destroy, :ids => [1, 3], :todo => 'destroy'
1926 1951 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1927 1952 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1928 1953 assert_nil TimeEntry.find_by_id([1, 2])
1929 1954 end
1930 1955
1931 1956 def test_destroy_issues_and_assign_time_entries_to_project
1932 1957 @request.session[:user_id] = 2
1933 1958 post :destroy, :ids => [1, 3], :todo => 'nullify'
1934 1959 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1935 1960 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1936 1961 assert_nil TimeEntry.find(1).issue_id
1937 1962 assert_nil TimeEntry.find(2).issue_id
1938 1963 end
1939 1964
1940 1965 def test_destroy_issues_and_reassign_time_entries_to_another_issue
1941 1966 @request.session[:user_id] = 2
1942 1967 post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
1943 1968 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1944 1969 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1945 1970 assert_equal 2, TimeEntry.find(1).issue_id
1946 1971 assert_equal 2, TimeEntry.find(2).issue_id
1947 1972 end
1948 1973
1949 1974 def test_destroy_issues_from_different_projects
1950 1975 @request.session[:user_id] = 2
1951 1976 post :destroy, :ids => [1, 2, 6], :todo => 'destroy'
1952 1977 assert_redirected_to :controller => 'issues', :action => 'index'
1953 1978 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
1954 1979 end
1955 1980
1956 1981 def test_destroy_parent_and_child_issues
1957 1982 parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
1958 1983 child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
1959 1984 assert child.is_descendant_of?(parent.reload)
1960 1985
1961 1986 @request.session[:user_id] = 2
1962 1987 assert_difference 'Issue.count', -2 do
1963 1988 post :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
1964 1989 end
1965 1990 assert_response 302
1966 1991 end
1967 1992
1968 1993 def test_default_search_scope
1969 1994 get :index
1970 1995 assert_tag :div, :attributes => {:id => 'quick-search'},
1971 1996 :child => {:tag => 'form',
1972 1997 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
1973 1998 end
1974 1999 end
General Comments 0
You need to be logged in to leave comments. Login now