##// END OF EJS Templates
replace tabs to spaces at app/models/issue.rb...
Toshi MARUYAMA -
r11192:e79b232a0258
parent child
Show More
@@ -1,1425 +1,1425
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21
22 22 belongs_to :project
23 23 belongs_to :tracker
24 24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30 30
31 31 has_many :journals, :as => :journalized, :dependent => :destroy
32 32 has_many :visible_journals,
33 33 :class_name => 'Journal',
34 34 :as => :journalized,
35 35 :conditions => Proc.new {
36 36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 37 },
38 38 :readonly => true
39 39
40 40 has_many :time_entries, :dependent => :delete_all
41 41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 48 acts_as_customizable
49 49 acts_as_watchable
50 50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 51 :include => [:project, :visible_journals],
52 52 # sort by id so that limited eager loading doesn't break with postgresql
53 53 :order_column => "#{table_name}.id"
54 54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57 57
58 58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 59 :author_key => :author_id
60 60
61 61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62 62
63 63 attr_reader :current_journal
64 64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65 65
66 66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67 67
68 68 validates_length_of :subject, :maximum => 255
69 69 validates_inclusion_of :done_ratio, :in => 0..100
70 70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 71 validates :start_date, :date => true
72 72 validates :due_date, :date => true
73 73 validate :validate_issue, :validate_required_fields
74 74
75 75 scope :visible, lambda {|*args|
76 76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 77 }
78 78
79 79 scope :open, lambda {|*args|
80 80 is_closed = args.size > 0 ? !args.first : false
81 81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 82 }
83 83
84 84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 85 scope :on_active_project, lambda {
86 86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 87 }
88 88 scope :fixed_version, lambda {|versions|
89 89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 91 }
92 92
93 93 before_create :default_assign
94 94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 97 # Should be after_create but would be called before previous after_save callbacks
98 98 after_save :after_create_from_copy
99 99 after_destroy :update_parent_attributes
100 100
101 101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 102 def self.visible_condition(user, options={})
103 103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 104 if user.logged?
105 105 case role.issues_visibility
106 106 when 'all'
107 107 nil
108 108 when 'default'
109 109 user_ids = [user.id] + user.groups.map(&:id)
110 110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 111 when 'own'
112 112 user_ids = [user.id] + user.groups.map(&:id)
113 113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 114 else
115 115 '1=0'
116 116 end
117 117 else
118 118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 119 end
120 120 end
121 121 end
122 122
123 123 # Returns true if usr or current user is allowed to view the issue
124 124 def visible?(usr=nil)
125 125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 126 if user.logged?
127 127 case role.issues_visibility
128 128 when 'all'
129 129 true
130 130 when 'default'
131 131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 132 when 'own'
133 133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 134 else
135 135 false
136 136 end
137 137 else
138 138 !self.is_private?
139 139 end
140 140 end
141 141 end
142 142
143 143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 144 def editable?(user=User.current)
145 145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 146 end
147 147
148 148 def initialize(attributes=nil, *args)
149 149 super
150 150 if new_record?
151 151 # set default values for new records only
152 152 self.status ||= IssueStatus.default
153 153 self.priority ||= IssuePriority.default
154 154 self.watcher_user_ids = []
155 155 end
156 156 end
157 157
158 158 def create_or_update
159 159 super
160 160 ensure
161 161 @status_was = nil
162 162 end
163 163 private :create_or_update
164 164
165 165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 166 # if the issue was already deleted or updated (non matching lock_version).
167 167 # This is a problem when bulk deleting issues or deleting a project
168 168 # (because an issue may already be deleted if its parent was deleted
169 169 # first).
170 170 # The issue is reloaded by the nested_set before being deleted so
171 171 # the lock_version condition should not be an issue but we handle it.
172 172 def destroy
173 173 super
174 174 rescue ActiveRecord::RecordNotFound
175 175 # Stale or already deleted
176 176 begin
177 177 reload
178 178 rescue ActiveRecord::RecordNotFound
179 179 # The issue was actually already deleted
180 180 @destroyed = true
181 181 return freeze
182 182 end
183 183 # The issue was stale, retry to destroy
184 184 super
185 185 end
186 186
187 187 def reload(*args)
188 188 @workflow_rule_by_attribute = nil
189 189 @assignable_versions = nil
190 190 super
191 191 end
192 192
193 193 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
194 194 def available_custom_fields
195 195 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
196 196 end
197 197
198 198 # Copies attributes from another issue, arg can be an id or an Issue
199 199 def copy_from(arg, options={})
200 200 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
201 201 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
202 202 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
203 203 self.status = issue.status
204 204 self.author = User.current
205 205 unless options[:attachments] == false
206 206 self.attachments = issue.attachments.map do |attachement|
207 207 attachement.copy(:container => self)
208 208 end
209 209 end
210 210 @copied_from = issue
211 211 @copy_options = options
212 212 self
213 213 end
214 214
215 215 # Returns an unsaved copy of the issue
216 216 def copy(attributes=nil, copy_options={})
217 217 copy = self.class.new.copy_from(self, copy_options)
218 218 copy.attributes = attributes if attributes
219 219 copy
220 220 end
221 221
222 222 # Returns true if the issue is a copy
223 223 def copy?
224 224 @copied_from.present?
225 225 end
226 226
227 227 # Moves/copies an issue to a new project and tracker
228 228 # Returns the moved/copied issue on success, false on failure
229 229 def move_to_project(new_project, new_tracker=nil, options={})
230 230 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
231 231
232 232 if options[:copy]
233 233 issue = self.copy
234 234 else
235 235 issue = self
236 236 end
237 237
238 238 issue.init_journal(User.current, options[:notes])
239 239
240 240 # Preserve previous behaviour
241 241 # #move_to_project doesn't change tracker automatically
242 242 issue.send :project=, new_project, true
243 243 if new_tracker
244 244 issue.tracker = new_tracker
245 245 end
246 246 # Allow bulk setting of attributes on the issue
247 247 if options[:attributes]
248 248 issue.attributes = options[:attributes]
249 249 end
250 250
251 251 issue.save ? issue : false
252 252 end
253 253
254 254 def status_id=(sid)
255 255 self.status = nil
256 256 result = write_attribute(:status_id, sid)
257 257 @workflow_rule_by_attribute = nil
258 258 result
259 259 end
260 260
261 261 def priority_id=(pid)
262 262 self.priority = nil
263 263 write_attribute(:priority_id, pid)
264 264 end
265 265
266 266 def category_id=(cid)
267 267 self.category = nil
268 268 write_attribute(:category_id, cid)
269 269 end
270 270
271 271 def fixed_version_id=(vid)
272 272 self.fixed_version = nil
273 273 write_attribute(:fixed_version_id, vid)
274 274 end
275 275
276 276 def tracker_id=(tid)
277 277 self.tracker = nil
278 278 result = write_attribute(:tracker_id, tid)
279 279 @custom_field_values = nil
280 280 @workflow_rule_by_attribute = nil
281 281 result
282 282 end
283 283
284 284 def project_id=(project_id)
285 285 if project_id.to_s != self.project_id.to_s
286 286 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
287 287 end
288 288 end
289 289
290 290 def project=(project, keep_tracker=false)
291 291 project_was = self.project
292 292 write_attribute(:project_id, project ? project.id : nil)
293 293 association_instance_set('project', project)
294 294 if project_was && project && project_was != project
295 295 @assignable_versions = nil
296 296
297 297 unless keep_tracker || project.trackers.include?(tracker)
298 298 self.tracker = project.trackers.first
299 299 end
300 300 # Reassign to the category with same name if any
301 301 if category
302 302 self.category = project.issue_categories.find_by_name(category.name)
303 303 end
304 304 # Keep the fixed_version if it's still valid in the new_project
305 305 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
306 306 self.fixed_version = nil
307 307 end
308 308 # Clear the parent task if it's no longer valid
309 309 unless valid_parent_project?
310 310 self.parent_issue_id = nil
311 311 end
312 312 @custom_field_values = nil
313 313 end
314 314 end
315 315
316 316 def description=(arg)
317 317 if arg.is_a?(String)
318 318 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
319 319 end
320 320 write_attribute(:description, arg)
321 321 end
322 322
323 323 # Overrides assign_attributes so that project and tracker get assigned first
324 324 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
325 325 return if new_attributes.nil?
326 326 attrs = new_attributes.dup
327 327 attrs.stringify_keys!
328 328
329 329 %w(project project_id tracker tracker_id).each do |attr|
330 330 if attrs.has_key?(attr)
331 331 send "#{attr}=", attrs.delete(attr)
332 332 end
333 333 end
334 334 send :assign_attributes_without_project_and_tracker_first, attrs, *args
335 335 end
336 336 # Do not redefine alias chain on reload (see #4838)
337 337 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
338 338
339 339 def estimated_hours=(h)
340 340 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
341 341 end
342 342
343 343 safe_attributes 'project_id',
344 344 :if => lambda {|issue, user|
345 345 if issue.new_record?
346 346 issue.copy?
347 347 elsif user.allowed_to?(:move_issues, issue.project)
348 348 projects = Issue.allowed_target_projects_on_move(user)
349 349 projects.include?(issue.project) && projects.size > 1
350 350 end
351 351 }
352 352
353 353 safe_attributes 'tracker_id',
354 354 'status_id',
355 355 'category_id',
356 356 'assigned_to_id',
357 357 'priority_id',
358 358 'fixed_version_id',
359 359 'subject',
360 360 'description',
361 361 'start_date',
362 362 'due_date',
363 363 'done_ratio',
364 364 'estimated_hours',
365 365 'custom_field_values',
366 366 'custom_fields',
367 367 'lock_version',
368 368 'notes',
369 369 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
370 370
371 371 safe_attributes 'status_id',
372 372 'assigned_to_id',
373 373 'fixed_version_id',
374 374 'done_ratio',
375 375 'lock_version',
376 376 'notes',
377 377 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
378 378
379 379 safe_attributes 'notes',
380 380 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
381 381
382 382 safe_attributes 'private_notes',
383 383 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
384 384
385 385 safe_attributes 'watcher_user_ids',
386 386 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
387 387
388 388 safe_attributes 'is_private',
389 389 :if => lambda {|issue, user|
390 390 user.allowed_to?(:set_issues_private, issue.project) ||
391 391 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
392 392 }
393 393
394 394 safe_attributes 'parent_issue_id',
395 395 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
396 396 user.allowed_to?(:manage_subtasks, issue.project)}
397 397
398 398 def safe_attribute_names(user=nil)
399 399 names = super
400 400 names -= disabled_core_fields
401 401 names -= read_only_attribute_names(user)
402 402 names
403 403 end
404 404
405 405 # Safely sets attributes
406 406 # Should be called from controllers instead of #attributes=
407 407 # attr_accessible is too rough because we still want things like
408 408 # Issue.new(:project => foo) to work
409 409 def safe_attributes=(attrs, user=User.current)
410 410 return unless attrs.is_a?(Hash)
411 411
412 412 attrs = attrs.dup
413 413
414 414 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
415 415 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
416 416 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
417 417 self.project_id = p
418 418 end
419 419 end
420 420
421 421 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
422 422 self.tracker_id = t
423 423 end
424 424
425 425 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
426 426 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
427 427 self.status_id = s
428 428 end
429 429 end
430 430
431 431 attrs = delete_unsafe_attributes(attrs, user)
432 432 return if attrs.empty?
433 433
434 434 unless leaf?
435 435 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
436 436 end
437 437
438 438 if attrs['parent_issue_id'].present?
439 439 s = attrs['parent_issue_id'].to_s
440 440 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
441 441 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
442 442 end
443 443 end
444 444
445 445 if attrs['custom_field_values'].present?
446 446 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
447 447 end
448 448
449 449 if attrs['custom_fields'].present?
450 450 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
451 451 end
452 452
453 453 # mass-assignment security bypass
454 454 assign_attributes attrs, :without_protection => true
455 455 end
456 456
457 457 def disabled_core_fields
458 458 tracker ? tracker.disabled_core_fields : []
459 459 end
460 460
461 461 # Returns the custom_field_values that can be edited by the given user
462 462 def editable_custom_field_values(user=nil)
463 463 custom_field_values.reject do |value|
464 464 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
465 465 end
466 466 end
467 467
468 468 # Returns the names of attributes that are read-only for user or the current user
469 469 # For users with multiple roles, the read-only fields are the intersection of
470 470 # read-only fields of each role
471 471 # The result is an array of strings where sustom fields are represented with their ids
472 472 #
473 473 # Examples:
474 474 # issue.read_only_attribute_names # => ['due_date', '2']
475 475 # issue.read_only_attribute_names(user) # => []
476 476 def read_only_attribute_names(user=nil)
477 477 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
478 478 end
479 479
480 480 # Returns the names of required attributes for user or the current user
481 481 # For users with multiple roles, the required fields are the intersection of
482 482 # required fields of each role
483 483 # The result is an array of strings where sustom fields are represented with their ids
484 484 #
485 485 # Examples:
486 486 # issue.required_attribute_names # => ['due_date', '2']
487 487 # issue.required_attribute_names(user) # => []
488 488 def required_attribute_names(user=nil)
489 489 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
490 490 end
491 491
492 492 # Returns true if the attribute is required for user
493 493 def required_attribute?(name, user=nil)
494 494 required_attribute_names(user).include?(name.to_s)
495 495 end
496 496
497 497 # Returns a hash of the workflow rule by attribute for the given user
498 498 #
499 499 # Examples:
500 500 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
501 501 def workflow_rule_by_attribute(user=nil)
502 502 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
503 503
504 504 user_real = user || User.current
505 505 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
506 506 return {} if roles.empty?
507 507
508 508 result = {}
509 509 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
510 510 if workflow_permissions.any?
511 511 workflow_rules = workflow_permissions.inject({}) do |h, wp|
512 512 h[wp.field_name] ||= []
513 513 h[wp.field_name] << wp.rule
514 514 h
515 515 end
516 516 workflow_rules.each do |attr, rules|
517 517 next if rules.size < roles.size
518 518 uniq_rules = rules.uniq
519 519 if uniq_rules.size == 1
520 520 result[attr] = uniq_rules.first
521 521 else
522 522 result[attr] = 'required'
523 523 end
524 524 end
525 525 end
526 526 @workflow_rule_by_attribute = result if user.nil?
527 527 result
528 528 end
529 529 private :workflow_rule_by_attribute
530 530
531 531 def done_ratio
532 532 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
533 533 status.default_done_ratio
534 534 else
535 535 read_attribute(:done_ratio)
536 536 end
537 537 end
538 538
539 539 def self.use_status_for_done_ratio?
540 540 Setting.issue_done_ratio == 'issue_status'
541 541 end
542 542
543 543 def self.use_field_for_done_ratio?
544 544 Setting.issue_done_ratio == 'issue_field'
545 545 end
546 546
547 547 def validate_issue
548 548 if due_date && start_date && due_date < start_date
549 549 errors.add :due_date, :greater_than_start_date
550 550 end
551 551
552 552 if start_date && soonest_start && start_date < soonest_start
553 553 errors.add :start_date, :invalid
554 554 end
555 555
556 556 if fixed_version
557 557 if !assignable_versions.include?(fixed_version)
558 558 errors.add :fixed_version_id, :inclusion
559 559 elsif reopened? && fixed_version.closed?
560 560 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
561 561 end
562 562 end
563 563
564 564 # Checks that the issue can not be added/moved to a disabled tracker
565 565 if project && (tracker_id_changed? || project_id_changed?)
566 566 unless project.trackers.include?(tracker)
567 567 errors.add :tracker_id, :inclusion
568 568 end
569 569 end
570 570
571 571 # Checks parent issue assignment
572 572 if @invalid_parent_issue_id.present?
573 573 errors.add :parent_issue_id, :invalid
574 574 elsif @parent_issue
575 575 if !valid_parent_project?(@parent_issue)
576 576 errors.add :parent_issue_id, :invalid
577 577 elsif !new_record?
578 578 # moving an existing issue
579 579 if @parent_issue.root_id != root_id
580 580 # we can always move to another tree
581 581 elsif move_possible?(@parent_issue)
582 582 # move accepted inside tree
583 583 else
584 584 errors.add :parent_issue_id, :invalid
585 585 end
586 586 end
587 587 end
588 588 end
589 589
590 590 # Validates the issue against additional workflow requirements
591 591 def validate_required_fields
592 592 user = new_record? ? author : current_journal.try(:user)
593 593
594 594 required_attribute_names(user).each do |attribute|
595 595 if attribute =~ /^\d+$/
596 596 attribute = attribute.to_i
597 597 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
598 598 if v && v.value.blank?
599 599 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
600 600 end
601 601 else
602 602 if respond_to?(attribute) && send(attribute).blank?
603 603 errors.add attribute, :blank
604 604 end
605 605 end
606 606 end
607 607 end
608 608
609 609 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
610 610 # even if the user turns off the setting later
611 611 def update_done_ratio_from_issue_status
612 612 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
613 613 self.done_ratio = status.default_done_ratio
614 614 end
615 615 end
616 616
617 617 def init_journal(user, notes = "")
618 618 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
619 619 if new_record?
620 620 @current_journal.notify = false
621 621 else
622 622 @attributes_before_change = attributes.dup
623 623 @custom_values_before_change = {}
624 624 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
625 625 end
626 626 @current_journal
627 627 end
628 628
629 629 # Returns the id of the last journal or nil
630 630 def last_journal_id
631 631 if new_record?
632 632 nil
633 633 else
634 634 journals.maximum(:id)
635 635 end
636 636 end
637 637
638 638 # Returns a scope for journals that have an id greater than journal_id
639 639 def journals_after(journal_id)
640 640 scope = journals.reorder("#{Journal.table_name}.id ASC")
641 641 if journal_id.present?
642 642 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
643 643 end
644 644 scope
645 645 end
646 646
647 647 # Returns the initial status of the issue
648 648 # Returns nil for a new issue
649 649 def status_was
650 650 if status_id_was && status_id_was.to_i > 0
651 651 @status_was ||= IssueStatus.find_by_id(status_id_was)
652 652 end
653 653 end
654 654
655 655 # Return true if the issue is closed, otherwise false
656 656 def closed?
657 657 self.status.is_closed?
658 658 end
659 659
660 660 # Return true if the issue is being reopened
661 661 def reopened?
662 662 if !new_record? && status_id_changed?
663 663 status_was = IssueStatus.find_by_id(status_id_was)
664 664 status_new = IssueStatus.find_by_id(status_id)
665 665 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
666 666 return true
667 667 end
668 668 end
669 669 false
670 670 end
671 671
672 672 # Return true if the issue is being closed
673 673 def closing?
674 674 if !new_record? && status_id_changed?
675 675 if status_was && status && !status_was.is_closed? && status.is_closed?
676 676 return true
677 677 end
678 678 end
679 679 false
680 680 end
681 681
682 682 # Returns true if the issue is overdue
683 683 def overdue?
684 684 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
685 685 end
686 686
687 687 # Is the amount of work done less than it should for the due date
688 688 def behind_schedule?
689 689 return false if start_date.nil? || due_date.nil?
690 690 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
691 691 return done_date <= Date.today
692 692 end
693 693
694 694 # Does this issue have children?
695 695 def children?
696 696 !leaf?
697 697 end
698 698
699 699 # Users the issue can be assigned to
700 700 def assignable_users
701 701 users = project.assignable_users
702 702 users << author if author
703 703 users << assigned_to if assigned_to
704 704 users.uniq.sort
705 705 end
706 706
707 707 # Versions that the issue can be assigned to
708 708 def assignable_versions
709 709 return @assignable_versions if @assignable_versions
710 710
711 711 versions = project.shared_versions.open.all
712 712 if fixed_version
713 713 if fixed_version_id_changed?
714 714 # nothing to do
715 715 elsif project_id_changed?
716 716 if project.shared_versions.include?(fixed_version)
717 717 versions << fixed_version
718 718 end
719 719 else
720 720 versions << fixed_version
721 721 end
722 722 end
723 723 @assignable_versions = versions.uniq.sort
724 724 end
725 725
726 726 # Returns true if this issue is blocked by another issue that is still open
727 727 def blocked?
728 728 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
729 729 end
730 730
731 731 # Returns an array of statuses that user is able to apply
732 732 def new_statuses_allowed_to(user=User.current, include_default=false)
733 733 if new_record? && @copied_from
734 734 [IssueStatus.default, @copied_from.status].compact.uniq.sort
735 735 else
736 736 initial_status = nil
737 737 if new_record?
738 738 initial_status = IssueStatus.default
739 739 elsif status_id_was
740 740 initial_status = IssueStatus.find_by_id(status_id_was)
741 741 end
742 742 initial_status ||= status
743 743
744 744 statuses = initial_status.find_new_statuses_allowed_to(
745 745 user.admin ? Role.all : user.roles_for_project(project),
746 746 tracker,
747 747 author == user,
748 748 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
749 749 )
750 750 statuses << initial_status unless statuses.empty?
751 751 statuses << IssueStatus.default if include_default
752 752 statuses = statuses.compact.uniq.sort
753 753 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
754 754 end
755 755 end
756 756
757 757 def assigned_to_was
758 758 if assigned_to_id_changed? && assigned_to_id_was.present?
759 759 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
760 760 end
761 761 end
762 762
763 763 # Returns the users that should be notified
764 764 def notified_users
765 765 notified = []
766 766 # Author and assignee are always notified unless they have been
767 767 # locked or don't want to be notified
768 768 notified << author if author
769 769 if assigned_to
770 770 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
771 771 end
772 772 if assigned_to_was
773 773 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
774 774 end
775 775 notified = notified.select {|u| u.active? && u.notify_about?(self)}
776 776
777 777 notified += project.notified_users
778 778 notified.uniq!
779 779 # Remove users that can not view the issue
780 780 notified.reject! {|user| !visible?(user)}
781 781 notified
782 782 end
783 783
784 784 # Returns the email addresses that should be notified
785 785 def recipients
786 786 notified_users.collect(&:mail)
787 787 end
788 788
789 789 # Returns the number of hours spent on this issue
790 790 def spent_hours
791 791 @spent_hours ||= time_entries.sum(:hours) || 0
792 792 end
793 793
794 794 # Returns the total number of hours spent on this issue and its descendants
795 795 #
796 796 # Example:
797 797 # spent_hours => 0.0
798 798 # spent_hours => 50.2
799 799 def total_spent_hours
800 800 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
801 801 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
802 802 end
803 803
804 804 def relations
805 805 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
806 806 end
807 807
808 808 # Preloads relations for a collection of issues
809 809 def self.load_relations(issues)
810 810 if issues.any?
811 811 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
812 812 issues.each do |issue|
813 813 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
814 814 end
815 815 end
816 816 end
817 817
818 818 # Preloads visible spent time for a collection of issues
819 819 def self.load_visible_spent_hours(issues, user=User.current)
820 820 if issues.any?
821 821 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
822 822 issues.each do |issue|
823 823 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
824 824 end
825 825 end
826 826 end
827 827
828 828 # Preloads visible relations for a collection of issues
829 829 def self.load_visible_relations(issues, user=User.current)
830 830 if issues.any?
831 831 issue_ids = issues.map(&:id)
832 832 # Relations with issue_from in given issues and visible issue_to
833 833 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
834 834 # Relations with issue_to in given issues and visible issue_from
835 835 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
836 836
837 837 issues.each do |issue|
838 838 relations =
839 839 relations_from.select {|relation| relation.issue_from_id == issue.id} +
840 840 relations_to.select {|relation| relation.issue_to_id == issue.id}
841 841
842 842 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
843 843 end
844 844 end
845 845 end
846 846
847 847 # Finds an issue relation given its id.
848 848 def find_relation(relation_id)
849 849 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
850 850 end
851 851
852 852 def all_dependent_issues(except=[])
853 853 except << self
854 854 dependencies = []
855 855 relations_from.each do |relation|
856 856 if relation.issue_to && !except.include?(relation.issue_to)
857 857 dependencies << relation.issue_to
858 858 dependencies += relation.issue_to.all_dependent_issues(except)
859 859 end
860 860 end
861 861 dependencies
862 862 end
863 863
864 864 # Returns an array of issues that duplicate this one
865 865 def duplicates
866 866 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
867 867 end
868 868
869 869 # Returns the due date or the target due date if any
870 870 # Used on gantt chart
871 871 def due_before
872 872 due_date || (fixed_version ? fixed_version.effective_date : nil)
873 873 end
874 874
875 875 # Returns the time scheduled for this issue.
876 876 #
877 877 # Example:
878 878 # Start Date: 2/26/09, End Date: 3/04/09
879 879 # duration => 6
880 880 def duration
881 881 (start_date && due_date) ? due_date - start_date : 0
882 882 end
883 883
884 884 # Returns the duration in working days
885 885 def working_duration
886 886 (start_date && due_date) ? working_days(start_date, due_date) : 0
887 887 end
888 888
889 889 def soonest_start(reload=false)
890 890 @soonest_start = nil if reload
891 891 @soonest_start ||= (
892 892 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
893 893 ancestors.collect(&:soonest_start)
894 894 ).compact.max
895 895 end
896 896
897 897 # Sets start_date on the given date or the next working day
898 898 # and changes due_date to keep the same working duration.
899 899 def reschedule_on(date)
900 900 wd = working_duration
901 901 date = next_working_date(date)
902 902 self.start_date = date
903 903 self.due_date = add_working_days(date, wd)
904 904 end
905 905
906 906 # Reschedules the issue on the given date or the next working day and saves the record.
907 907 # If the issue is a parent task, this is done by rescheduling its subtasks.
908 908 def reschedule_on!(date)
909 909 return if date.nil?
910 910 if leaf?
911 911 if start_date.nil? || start_date != date
912 912 if start_date && start_date > date
913 913 # Issue can not be moved earlier than its soonest start date
914 914 date = [soonest_start(true), date].compact.max
915 915 end
916 916 reschedule_on(date)
917 917 begin
918 918 save
919 919 rescue ActiveRecord::StaleObjectError
920 920 reload
921 921 reschedule_on(date)
922 922 save
923 923 end
924 924 end
925 925 else
926 926 leaves.each do |leaf|
927 927 if leaf.start_date
928 928 # Only move subtask if it starts at the same date as the parent
929 929 # or if it starts before the given date
930 930 if start_date == leaf.start_date || date > leaf.start_date
931 931 leaf.reschedule_on!(date)
932 932 end
933 933 else
934 934 leaf.reschedule_on!(date)
935 935 end
936 936 end
937 937 end
938 938 end
939 939
940 940 def <=>(issue)
941 941 if issue.nil?
942 942 -1
943 943 elsif root_id != issue.root_id
944 944 (root_id || 0) <=> (issue.root_id || 0)
945 945 else
946 946 (lft || 0) <=> (issue.lft || 0)
947 947 end
948 948 end
949 949
950 950 def to_s
951 951 "#{tracker} ##{id}: #{subject}"
952 952 end
953 953
954 954 # Returns a string of css classes that apply to the issue
955 955 def css_classes
956 956 s = "issue status-#{status_id} #{priority.try(:css_classes)}"
957 957 s << ' closed' if closed?
958 958 s << ' overdue' if overdue?
959 959 s << ' child' if child?
960 960 s << ' parent' unless leaf?
961 961 s << ' private' if is_private?
962 962 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
963 963 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
964 964 s
965 965 end
966 966
967 967 # Saves an issue and a time_entry from the parameters
968 968 def save_issue_with_child_records(params, existing_time_entry=nil)
969 969 Issue.transaction do
970 970 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
971 971 @time_entry = existing_time_entry || TimeEntry.new
972 972 @time_entry.project = project
973 973 @time_entry.issue = self
974 974 @time_entry.user = User.current
975 975 @time_entry.spent_on = User.current.today
976 976 @time_entry.attributes = params[:time_entry]
977 977 self.time_entries << @time_entry
978 978 end
979 979
980 980 # TODO: Rename hook
981 981 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
982 982 if save
983 983 # TODO: Rename hook
984 984 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
985 985 else
986 986 raise ActiveRecord::Rollback
987 987 end
988 988 end
989 989 end
990 990
991 991 # Unassigns issues from +version+ if it's no longer shared with issue's project
992 992 def self.update_versions_from_sharing_change(version)
993 993 # Update issues assigned to the version
994 994 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
995 995 end
996 996
997 997 # Unassigns issues from versions that are no longer shared
998 998 # after +project+ was moved
999 999 def self.update_versions_from_hierarchy_change(project)
1000 1000 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1001 1001 # Update issues of the moved projects and issues assigned to a version of a moved project
1002 1002 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1003 1003 end
1004 1004
1005 1005 def parent_issue_id=(arg)
1006 1006 s = arg.to_s.strip.presence
1007 1007 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1008 1008 @parent_issue.id
1009 1009 else
1010 1010 @parent_issue = nil
1011 1011 @invalid_parent_issue_id = arg
1012 1012 end
1013 1013 end
1014 1014
1015 1015 def parent_issue_id
1016 1016 if @invalid_parent_issue_id
1017 1017 @invalid_parent_issue_id
1018 1018 elsif instance_variable_defined? :@parent_issue
1019 1019 @parent_issue.nil? ? nil : @parent_issue.id
1020 1020 else
1021 1021 parent_id
1022 1022 end
1023 1023 end
1024 1024
1025 # Returns true if issue's project is a valid
1026 # parent issue project
1025 # Returns true if issue's project is a valid
1026 # parent issue project
1027 1027 def valid_parent_project?(issue=parent)
1028 1028 return true if issue.nil? || issue.project_id == project_id
1029 1029
1030 1030 case Setting.cross_project_subtasks
1031 1031 when 'system'
1032 1032 true
1033 1033 when 'tree'
1034 1034 issue.project.root == project.root
1035 1035 when 'hierarchy'
1036 1036 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1037 1037 when 'descendants'
1038 1038 issue.project.is_or_is_ancestor_of?(project)
1039 1039 else
1040 1040 false
1041 1041 end
1042 1042 end
1043 1043
1044 1044 # Extracted from the ReportsController.
1045 1045 def self.by_tracker(project)
1046 1046 count_and_group_by(:project => project,
1047 1047 :field => 'tracker_id',
1048 1048 :joins => Tracker.table_name)
1049 1049 end
1050 1050
1051 1051 def self.by_version(project)
1052 1052 count_and_group_by(:project => project,
1053 1053 :field => 'fixed_version_id',
1054 1054 :joins => Version.table_name)
1055 1055 end
1056 1056
1057 1057 def self.by_priority(project)
1058 1058 count_and_group_by(:project => project,
1059 1059 :field => 'priority_id',
1060 1060 :joins => IssuePriority.table_name)
1061 1061 end
1062 1062
1063 1063 def self.by_category(project)
1064 1064 count_and_group_by(:project => project,
1065 1065 :field => 'category_id',
1066 1066 :joins => IssueCategory.table_name)
1067 1067 end
1068 1068
1069 1069 def self.by_assigned_to(project)
1070 1070 count_and_group_by(:project => project,
1071 1071 :field => 'assigned_to_id',
1072 1072 :joins => User.table_name)
1073 1073 end
1074 1074
1075 1075 def self.by_author(project)
1076 1076 count_and_group_by(:project => project,
1077 1077 :field => 'author_id',
1078 1078 :joins => User.table_name)
1079 1079 end
1080 1080
1081 1081 def self.by_subproject(project)
1082 1082 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1083 1083 s.is_closed as closed,
1084 1084 #{Issue.table_name}.project_id as project_id,
1085 1085 count(#{Issue.table_name}.id) as total
1086 1086 from
1087 1087 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1088 1088 where
1089 1089 #{Issue.table_name}.status_id=s.id
1090 1090 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1091 1091 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1092 1092 and #{Issue.table_name}.project_id <> #{project.id}
1093 1093 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1094 1094 end
1095 1095 # End ReportsController extraction
1096 1096
1097 1097 # Returns an array of projects that user can assign the issue to
1098 1098 def allowed_target_projects(user=User.current)
1099 1099 if new_record?
1100 1100 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1101 1101 else
1102 1102 self.class.allowed_target_projects_on_move(user)
1103 1103 end
1104 1104 end
1105 1105
1106 1106 # Returns an array of projects that user can move issues to
1107 1107 def self.allowed_target_projects_on_move(user=User.current)
1108 1108 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1109 1109 end
1110 1110
1111 1111 private
1112 1112
1113 1113 def after_project_change
1114 1114 # Update project_id on related time entries
1115 1115 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1116 1116
1117 1117 # Delete issue relations
1118 1118 unless Setting.cross_project_issue_relations?
1119 1119 relations_from.clear
1120 1120 relations_to.clear
1121 1121 end
1122 1122
1123 1123 # Move subtasks that were in the same project
1124 1124 children.each do |child|
1125 1125 next unless child.project_id == project_id_was
1126 1126 # Change project and keep project
1127 1127 child.send :project=, project, true
1128 1128 unless child.save
1129 1129 raise ActiveRecord::Rollback
1130 1130 end
1131 1131 end
1132 1132 end
1133 1133
1134 1134 # Callback for after the creation of an issue by copy
1135 1135 # * adds a "copied to" relation with the copied issue
1136 1136 # * copies subtasks from the copied issue
1137 1137 def after_create_from_copy
1138 1138 return unless copy? && !@after_create_from_copy_handled
1139 1139
1140 1140 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1141 1141 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1142 1142 unless relation.save
1143 1143 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1144 1144 end
1145 1145 end
1146 1146
1147 1147 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1148 1148 @copied_from.children.each do |child|
1149 1149 unless child.visible?
1150 1150 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1151 1151 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1152 1152 next
1153 1153 end
1154 1154 copy = Issue.new.copy_from(child, @copy_options)
1155 1155 copy.author = author
1156 1156 copy.project = project
1157 1157 copy.parent_issue_id = id
1158 1158 # Children subtasks are copied recursively
1159 1159 unless copy.save
1160 1160 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1161 1161 end
1162 1162 end
1163 1163 end
1164 1164 @after_create_from_copy_handled = true
1165 1165 end
1166 1166
1167 1167 def update_nested_set_attributes
1168 1168 if root_id.nil?
1169 1169 # issue was just created
1170 1170 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1171 1171 set_default_left_and_right
1172 1172 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
1173 1173 if @parent_issue
1174 1174 move_to_child_of(@parent_issue)
1175 1175 end
1176 1176 reload
1177 1177 elsif parent_issue_id != parent_id
1178 1178 former_parent_id = parent_id
1179 1179 # moving an existing issue
1180 1180 if @parent_issue && @parent_issue.root_id == root_id
1181 1181 # inside the same tree
1182 1182 move_to_child_of(@parent_issue)
1183 1183 else
1184 1184 # to another tree
1185 1185 unless root?
1186 1186 move_to_right_of(root)
1187 1187 reload
1188 1188 end
1189 1189 old_root_id = root_id
1190 1190 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1191 1191 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1192 1192 offset = target_maxright + 1 - lft
1193 1193 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
1194 1194 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1195 1195 self[left_column_name] = lft + offset
1196 1196 self[right_column_name] = rgt + offset
1197 1197 if @parent_issue
1198 1198 move_to_child_of(@parent_issue)
1199 1199 end
1200 1200 end
1201 1201 reload
1202 1202 # delete invalid relations of all descendants
1203 1203 self_and_descendants.each do |issue|
1204 1204 issue.relations.each do |relation|
1205 1205 relation.destroy unless relation.valid?
1206 1206 end
1207 1207 end
1208 1208 # update former parent
1209 1209 recalculate_attributes_for(former_parent_id) if former_parent_id
1210 1210 end
1211 1211 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1212 1212 end
1213 1213
1214 1214 def update_parent_attributes
1215 1215 recalculate_attributes_for(parent_id) if parent_id
1216 1216 end
1217 1217
1218 1218 def recalculate_attributes_for(issue_id)
1219 1219 if issue_id && p = Issue.find_by_id(issue_id)
1220 1220 # priority = highest priority of children
1221 1221 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1222 1222 p.priority = IssuePriority.find_by_position(priority_position)
1223 1223 end
1224 1224
1225 1225 # start/due dates = lowest/highest dates of children
1226 1226 p.start_date = p.children.minimum(:start_date)
1227 1227 p.due_date = p.children.maximum(:due_date)
1228 1228 if p.start_date && p.due_date && p.due_date < p.start_date
1229 1229 p.start_date, p.due_date = p.due_date, p.start_date
1230 1230 end
1231 1231
1232 1232 # done ratio = weighted average ratio of leaves
1233 1233 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1234 1234 leaves_count = p.leaves.count
1235 1235 if leaves_count > 0
1236 1236 average = p.leaves.average(:estimated_hours).to_f
1237 1237 if average == 0
1238 1238 average = 1
1239 1239 end
1240 1240 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1241 1241 progress = done / (average * leaves_count)
1242 1242 p.done_ratio = progress.round
1243 1243 end
1244 1244 end
1245 1245
1246 1246 # estimate = sum of leaves estimates
1247 1247 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1248 1248 p.estimated_hours = nil if p.estimated_hours == 0.0
1249 1249
1250 1250 # ancestors will be recursively updated
1251 1251 p.save(:validate => false)
1252 1252 end
1253 1253 end
1254 1254
1255 1255 # Update issues so their versions are not pointing to a
1256 1256 # fixed_version that is not shared with the issue's project
1257 1257 def self.update_versions(conditions=nil)
1258 1258 # Only need to update issues with a fixed_version from
1259 1259 # a different project and that is not systemwide shared
1260 1260 Issue.scoped(:conditions => conditions).all(
1261 1261 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1262 1262 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1263 1263 " AND #{Version.table_name}.sharing <> 'system'",
1264 1264 :include => [:project, :fixed_version]
1265 1265 ).each do |issue|
1266 1266 next if issue.project.nil? || issue.fixed_version.nil?
1267 1267 unless issue.project.shared_versions.include?(issue.fixed_version)
1268 1268 issue.init_journal(User.current)
1269 1269 issue.fixed_version = nil
1270 1270 issue.save
1271 1271 end
1272 1272 end
1273 1273 end
1274 1274
1275 1275 # Callback on file attachment
1276 1276 def attachment_added(obj)
1277 1277 if @current_journal && !obj.new_record?
1278 1278 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1279 1279 end
1280 1280 end
1281 1281
1282 1282 # Callback on attachment deletion
1283 1283 def attachment_removed(obj)
1284 1284 if @current_journal && !obj.new_record?
1285 1285 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1286 1286 @current_journal.save
1287 1287 end
1288 1288 end
1289 1289
1290 1290 # Default assignment based on category
1291 1291 def default_assign
1292 1292 if assigned_to.nil? && category && category.assigned_to
1293 1293 self.assigned_to = category.assigned_to
1294 1294 end
1295 1295 end
1296 1296
1297 1297 # Updates start/due dates of following issues
1298 1298 def reschedule_following_issues
1299 1299 if start_date_changed? || due_date_changed?
1300 1300 relations_from.each do |relation|
1301 1301 relation.set_issue_to_dates
1302 1302 end
1303 1303 end
1304 1304 end
1305 1305
1306 1306 # Closes duplicates if the issue is being closed
1307 1307 def close_duplicates
1308 1308 if closing?
1309 1309 duplicates.each do |duplicate|
1310 1310 # Reload is need in case the duplicate was updated by a previous duplicate
1311 1311 duplicate.reload
1312 1312 # Don't re-close it if it's already closed
1313 1313 next if duplicate.closed?
1314 1314 # Same user and notes
1315 1315 if @current_journal
1316 1316 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1317 1317 end
1318 1318 duplicate.update_attribute :status, self.status
1319 1319 end
1320 1320 end
1321 1321 end
1322 1322
1323 1323 # Make sure updated_on is updated when adding a note and set updated_on now
1324 1324 # so we can set closed_on with the same value on closing
1325 1325 def force_updated_on_change
1326 1326 if @current_journal || changed?
1327 1327 self.updated_on = current_time_from_proper_timezone
1328 1328 if new_record?
1329 1329 self.created_on = updated_on
1330 1330 end
1331 1331 end
1332 1332 end
1333 1333
1334 1334 # Callback for setting closed_on when the issue is closed.
1335 1335 # The closed_on attribute stores the time of the last closing
1336 1336 # and is preserved when the issue is reopened.
1337 1337 def update_closed_on
1338 1338 if closing? || (new_record? && closed?)
1339 1339 self.closed_on = updated_on
1340 1340 end
1341 1341 end
1342 1342
1343 1343 # Saves the changes in a Journal
1344 1344 # Called after_save
1345 1345 def create_journal
1346 1346 if @current_journal
1347 1347 # attributes changes
1348 1348 if @attributes_before_change
1349 1349 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1350 1350 before = @attributes_before_change[c]
1351 1351 after = send(c)
1352 1352 next if before == after || (before.blank? && after.blank?)
1353 1353 @current_journal.details << JournalDetail.new(:property => 'attr',
1354 1354 :prop_key => c,
1355 1355 :old_value => before,
1356 1356 :value => after)
1357 1357 }
1358 1358 end
1359 1359 if @custom_values_before_change
1360 1360 # custom fields changes
1361 1361 custom_field_values.each {|c|
1362 1362 before = @custom_values_before_change[c.custom_field_id]
1363 1363 after = c.value
1364 1364 next if before == after || (before.blank? && after.blank?)
1365 1365
1366 1366 if before.is_a?(Array) || after.is_a?(Array)
1367 1367 before = [before] unless before.is_a?(Array)
1368 1368 after = [after] unless after.is_a?(Array)
1369 1369
1370 1370 # values removed
1371 1371 (before - after).reject(&:blank?).each do |value|
1372 1372 @current_journal.details << JournalDetail.new(:property => 'cf',
1373 1373 :prop_key => c.custom_field_id,
1374 1374 :old_value => value,
1375 1375 :value => nil)
1376 1376 end
1377 1377 # values added
1378 1378 (after - before).reject(&:blank?).each do |value|
1379 1379 @current_journal.details << JournalDetail.new(:property => 'cf',
1380 1380 :prop_key => c.custom_field_id,
1381 1381 :old_value => nil,
1382 1382 :value => value)
1383 1383 end
1384 1384 else
1385 1385 @current_journal.details << JournalDetail.new(:property => 'cf',
1386 1386 :prop_key => c.custom_field_id,
1387 1387 :old_value => before,
1388 1388 :value => after)
1389 1389 end
1390 1390 }
1391 1391 end
1392 1392 @current_journal.save
1393 1393 # reset current journal
1394 1394 init_journal @current_journal.user, @current_journal.notes
1395 1395 end
1396 1396 end
1397 1397
1398 1398 # Query generator for selecting groups of issue counts for a project
1399 1399 # based on specific criteria
1400 1400 #
1401 1401 # Options
1402 1402 # * project - Project to search in.
1403 1403 # * field - String. Issue field to key off of in the grouping.
1404 1404 # * joins - String. The table name to join against.
1405 1405 def self.count_and_group_by(options)
1406 1406 project = options.delete(:project)
1407 1407 select_field = options.delete(:field)
1408 1408 joins = options.delete(:joins)
1409 1409
1410 1410 where = "#{Issue.table_name}.#{select_field}=j.id"
1411 1411
1412 1412 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1413 1413 s.is_closed as closed,
1414 1414 j.id as #{select_field},
1415 1415 count(#{Issue.table_name}.id) as total
1416 1416 from
1417 1417 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1418 1418 where
1419 1419 #{Issue.table_name}.status_id=s.id
1420 1420 and #{where}
1421 1421 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1422 1422 and #{visible_condition(User.current, :project => project)}
1423 1423 group by s.id, s.is_closed, j.id")
1424 1424 end
1425 1425 end
General Comments 0
You need to be logged in to leave comments. Login now