jro_apps/redmine Commit - r3682:e7790bb6b5a9

Fix nil method error when no issue params are submitted. #5123...

Eric Davis -

r3682:e7790bb6b5a9

parent child

Context file:

r3682:e7790bb6b5a9

app/controllers/issues_controller.rb +1 -1

                 if request.get? || request.xhr?
                   @issue.start_date ||= Date.today
                 else
-                  requested_status = IssueStatus.find_by_id(params[:issue][:status_id])
+                  requested_status = IssueStatus.find_by_id(params[:issue][:status_id]) if params[:issue]
                   # Check that the user is allowed to apply the requested status
                   @issue.status = (@allowed_statuses.include? requested_status) ? requested_status : default_status
                   call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

test/functional/issues_controller_test.rb +6 0

                                                     :value => 'Value for field 2'}
               end
+              test "POST new with no issue params" do
+                @request.session[:user_id] = 2
+                post :new, :project_id => 1
+                assert_response :success
+              end
               def test_copy_routing
                 assert_routing(
                   {:method => :get, :path => '/projects/world_domination/issues/567/copy'},

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages