jro_apps/redmine Commit - r13292:e7518a9e0c19

Remove contexts in QueryTest....

Jean-Philippe Lang -

r13292:e7518a9e0c19

parent child

Context file:

r13292:e7518a9e0c19

Collapse all files

test/unit/query_test.rb +29 -33

                  end
                end
-               context "#statement" do
-                 context "with 'member_of_group' filter" do
-                   setup do
+               def setup_member_of_group
-                     Group.destroy_all # No fixtures
-                     @user_in_group = User.generate!
-                     @second_user_in_group = User.generate!
-                     @group2 = Group.generate!.reload
-                     @group2.users << @user_in_group2
+                 @query = IssueQuery.new(:name => '_')
-                   end
-                   should "search assigned to for users in the group" do
-                     @query = IssueQuery.new(:name => '_')
+               test "member_of_group filter should search assigned to for users in the group" do
+                 setup_member_of_group
-                     @query.add_filter('member_of_group', '=', [@group.id.to_s])
-                     assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@group.id}')"
-                     assert_find_issues_with_query_is_successful @query
-                   end
-                   should "search not assigned to any group member (none)" do
-                     @query = IssueQuery.new(:name => '_')
+               test "member_of_group filter should search not assigned to any group member (none)" do
+                 setup_member_of_group
-                     @query.add_filter('member_of_group', '!*', [''])
-                     # Users not in a group
-                     assert_find_issues_with_query_is_successful @query
-                   end
-                   should "search assigned to any group member (all)" do
-                     @query = IssueQuery.new(:name => '_')
+               test "member_of_group filter should search assigned to any group member (all)" do
+                 setup_member_of_group
-                     @query.add_filter('member_of_group', '*', [''])
-                     # Only users in a group
-                     assert_find_issues_with_query_is_successful @query
-                   end
-                   should "return an empty set with = empty group" do
+               test "member_of_group filter should return an empty set with = empty group" do
+                 setup_member_of_group
-                     @empty_group = Group.generate!
-                     @query = IssueQuery.new(:name => '_')
-                     @query.add_filter('member_of_group', '=', [@empty_group.id.to_s])
-                     assert_equal [], find_issues_with_query(@query)
-                   end
-                   should "return issues with ! empty group" do
+               test "member_of_group filter should return issues with ! empty group" do
+                 setup_member_of_group
-                     @empty_group = Group.generate!
-                     @query = IssueQuery.new(:name => '_')
-                     @query.add_filter('member_of_group', '!', [@empty_group.id.to_s])
-                     assert_find_issues_with_query_is_successful @query
-                   end
-                 end
-                 context "with 'assigned_to_role' filter" do
-                   setup do
+               def setup_assigned_to_role
-                     @manager_role = Role.find_by_name('Manager')
-                     @developer_role = Role.find_by_name('Developer')
-                     @issue3 = Issue.generate!(:project => @project, :assigned_to_id => @boss.id)
-                     @issue4 = Issue.generate!(:project => @project, :assigned_to_id => @guest.id)
-                     @issue5 = Issue.generate!(:project => @project)
-                   end
-                   should "search assigned to for users with the Role" do
-                     @query = IssueQuery.new(:name => '_', :project => @project)
+               end
+               test "assigned_to_role filter should search assigned to for users with the Role" do
+                 setup_assigned_to_role
-                     @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
-                     assert_query_result [@issue1, @issue3], @query
-                   end
-                   should "search assigned to for users with the Role on the issue project" do
+               test "assigned_to_role filter should search assigned to for users with the Role on the issue project" do
+                 setup_assigned_to_role
-                     other_project = Project.generate!
-                     User.add_to_project(@developer, other_project, @manager_role)
-                     @query = IssueQuery.new(:name => '_', :project => @project)
-                     @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
-                     assert_query_result [@issue1, @issue3], @query
-                   end
-                   should "return an empty set with empty role" do
+               test "assigned_to_role filter should return an empty set with empty role" do
+                 setup_assigned_to_role
-                     @empty_role = Role.generate!
-                     @query = IssueQuery.new(:name => '_', :project => @project)
-                     @query.add_filter('assigned_to_role', '=', [@empty_role.id.to_s])
-                     assert_query_result [], @query
-                   end
-                   should "search assigned to for users without the Role" do
-                     @query = IssueQuery.new(:name => '_', :project => @project)
+               test "assigned_to_role filter should search assigned to for users without the Role" do
+                 setup_assigned_to_role
-                     @query.add_filter('assigned_to_role', '!', [@manager_role.id.to_s])
-                     assert_query_result [@issue2, @issue4, @issue5], @query
-                   end
-                   should "search assigned to for users not assigned to any Role (none)" do
-                     @query = IssueQuery.new(:name => '_', :project => @project)
+               test "assigned_to_role filter should search assigned to for users not assigned to any Role (none)" do
+                 setup_assigned_to_role
-                     @query.add_filter('assigned_to_role', '!*', [''])
-                     assert_query_result [@issue4, @issue5], @query
-                   end
-                   should "search assigned to for users assigned to any Role (all)" do
-                     @query = IssueQuery.new(:name => '_', :project => @project)
+               test "assigned_to_role filter should search assigned to for users assigned to any Role (all)" do
+                 setup_assigned_to_role
-                     @query.add_filter('assigned_to_role', '*', [''])
-                     assert_query_result [@issue1, @issue2, @issue3], @query
-                   end
-                   should "return issues with ! empty role" do
+               test "assigned_to_role filter should return issues with ! empty role" do
+                 setup_assigned_to_role
-                     @empty_role = Role.generate!
-                     @query = IssueQuery.new(:name => '_', :project => @project)
-                     @query.add_filter('assigned_to_role', '!', [@empty_role.id.to_s])
-                     assert_query_result [@issue1, @issue2, @issue3, @issue4, @issue5], @query
-                   end
-                 end
-               end
                def test_query_column_should_accept_a_symbol_as_caption
                  set_language_if_valid 'en'

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages