jro_apps/redmine Commit - r8827:e6a64aa00bea

Adds functional tests....

Jean-Philippe Lang -

r8827:e6a64aa00bea

parent child

Context file:

r8827:e6a64aa00bea

Collapse all files

test/functional/enumerations_controller_test.rb +10 0

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class EnumerationsControllerTest < ActionController::TestCase
               fixtures :enumerations, :issues, :users
               def setup
                 @request.session[:user_id] = 1 # admin
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
               end
               def test_new
                 get :new, :type => 'IssuePriority'
                 assert_response :success
                 assert_template 'new'
                 assert_kind_of IssuePriority, assigns(:enumeration)
                 assert_tag 'input', :attributes => {:name => 'enumeration[type]', :value => 'IssuePriority'}
                 assert_tag 'input', :attributes => {:name => 'enumeration[name]'}
               end
+              def test_new_with_invalid_type_should_respond_with_404
+                get :new, :type => 'UnknownType'
+                assert_response 404
+              end
               def test_create
                 assert_difference 'IssuePriority.count' do
                   post :create, :enumeration => {:type => 'IssuePriority', :name => 'Lowest'}
                 end
                 assert_redirected_to '/enumerations?type=IssuePriority'
                 e = IssuePriority.first(:order => 'id DESC')
                 assert_equal 'Lowest', e.name
               end
               def test_create_with_failure
                 assert_no_difference 'IssuePriority.count' do
                   post :create, :enumeration => {:type => 'IssuePriority', :name => ''}
                 end
                 assert_response :success
                 assert_template 'new'
               end
               def test_edit
                 get :edit, :id => 6
                 assert_response :success
                 assert_template 'edit'
                 assert_tag 'input', :attributes => {:name => 'enumeration[name]', :value => 'High'}
               end
+              def test_edit_invalid_should_respond_with_404
+                get :edit, :id => 999
+                assert_response 404
+              end
               def test_update
                 assert_no_difference 'IssuePriority.count' do
                   put :update, :id => 6, :enumeration => {:type => 'IssuePriority', :name => 'New name'}
                 end
                 assert_redirected_to '/enumerations?type=IssuePriority'
                 e = IssuePriority.find(6)
                 assert_equal 'New name', e.name
               end
               def test_update_with_failure
                 assert_no_difference 'IssuePriority.count' do
                   put :update, :id => 6, :enumeration => {:type => 'IssuePriority', :name => ''}
                 end
                 assert_response :success
                 assert_template 'edit'
               end
               def test_destroy_enumeration_not_in_use
                 assert_difference 'IssuePriority.count', -1 do
                   delete :destroy, :id => 7
                 end
                 assert_redirected_to :controller => 'enumerations', :action => 'index'
                 assert_nil Enumeration.find_by_id(7)
               end
               def test_destroy_enumeration_in_use
                 assert_no_difference 'IssuePriority.count' do
                   delete :destroy, :id => 4
                 end
                 assert_response :success
                 assert_template 'destroy'
                 assert_not_nil Enumeration.find_by_id(4)
               end
               def test_destroy_enumeration_in_use_with_reassignment
                 issue = Issue.find(:first, :conditions => {:priority_id => 4})
                 assert_difference 'IssuePriority.count', -1 do
                   delete :destroy, :id => 4, :reassign_to_id => 6
                 end
                 assert_redirected_to :controller => 'enumerations', :action => 'index'
                 assert_nil Enumeration.find_by_id(4)
                 # check that the issue was reassign
                 assert_equal 6, issue.reload.priority_id
               end
             end

test/functional/roles_controller_test.rb +5 0

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RolesControllerTest < ActionController::TestCase
               fixtures :roles, :users, :members, :member_roles, :workflows, :trackers
               def setup
                 User.current = nil
                 @request.session[:user_id] = 1 # admin
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:roles)
                 assert_equal Role.find(:all, :order => 'builtin, position'), assigns(:roles)
                 assert_tag :tag => 'a', :attributes => { :href => '/roles/1/edit' },
                                         :content => 'Manager'
               end
               def test_new
                 get :new
                 assert_response :success
                 assert_template 'new'
               end
               def test_create_with_validaton_failure
                 post :create, :role => {:name => '',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'}
                 assert_response :success
                 assert_template 'new'
                 assert_tag :tag => 'div', :attributes => { :id => 'errorExplanation' }
               end
               def test_create_without_workflow_copy
                 post :create, :role => {:name => 'RoleWithoutWorkflowCopy',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'}
                 assert_redirected_to '/roles'
                 role = Role.find_by_name('RoleWithoutWorkflowCopy')
                 assert_not_nil role
                 assert_equal [:add_issues, :edit_issues, :log_time], role.permissions
                 assert !role.assignable?
               end
               def test_create_with_workflow_copy
                 post :create, :role => {:name => 'RoleWithWorkflowCopy',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'},
                            :copy_workflow_from => '1'
                 assert_redirected_to '/roles'
                 role = Role.find_by_name('RoleWithWorkflowCopy')
                 assert_not_nil role
                 assert_equal Role.find(1).workflows.size, role.workflows.size
               end
               def test_edit
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
                 assert_equal Role.find(1), assigns(:role)
               end
+              def test_edit_invalid_should_respond_with_404
+                get :edit, :id => 999
+                assert_response 404
+              end
               def test_update
                 put :update, :id => 1,
                             :role => {:name => 'Manager',
                                       :permissions => ['edit_project', ''],
                                       :assignable => '0'}
                 assert_redirected_to '/roles'
                 role = Role.find(1)
                 assert_equal [:edit_project], role.permissions
               end
               def test_update_with_failure
                 put :update, :id => 1, :role => {:name => ''}
                 assert_response :success
                 assert_template 'edit'
               end
               def test_destroy
                 r = Role.create!(:name => 'ToBeDestroyed', :permissions => [:view_wiki_pages])
                 delete :destroy, :id => r
                 assert_redirected_to '/roles'
                 assert_nil Role.find_by_id(r.id)
               end
               def test_destroy_role_in_use
                 delete :destroy, :id => 1
                 assert_redirected_to '/roles'
                 assert_equal 'This role is in use and cannot be deleted.', flash[:error]
                 assert_not_nil Role.find_by_id(1)
               end
               def test_get_permissions
                 get :permissions
                 assert_response :success
                 assert_template 'permissions'
                 assert_not_nil assigns(:roles)
                 assert_equal Role.find(:all, :order => 'builtin, position'), assigns(:roles)
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'permissions[3][]',
                                                              :value => 'add_issues',
                                                              :checked => 'checked' }
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'permissions[3][]',
                                                              :value => 'delete_issues',
                                                              :checked => nil }
               end
               def test_post_permissions
                 post :permissions, :permissions => { '0' => '', '1' => ['edit_issues'], '3' => ['add_issues', 'delete_issues']}
                 assert_redirected_to '/roles'
                 assert_equal [:edit_issues], Role.find(1).permissions
                 assert_equal [:add_issues, :delete_issues], Role.find(3).permissions
                 assert Role.find(2).permissions.empty?
               end
               def test_clear_all_permissions
                 post :permissions, :permissions => { '0' => '' }
                 assert_redirected_to '/roles'
                 assert Role.find(1).permissions.empty?
               end
               def test_move_highest
                 put :update, :id => 3, :role => {:move_to => 'highest'}
                 assert_redirected_to '/roles'
                 assert_equal 1, Role.find(3).position
               end
               def test_move_higher
                 position = Role.find(3).position
                 put :update, :id => 3, :role => {:move_to => 'higher'}
                 assert_redirected_to '/roles'
                 assert_equal position - 1, Role.find(3).position
               end
               def test_move_lower
                 position = Role.find(2).position
                 put :update, :id => 2, :role => {:move_to => 'lower'}
                 assert_redirected_to '/roles'
                 assert_equal position + 1, Role.find(2).position
               end
               def test_move_lowest
                 put :update, :id => 2, :role => {:move_to => 'lowest'}
                 assert_redirected_to '/roles'
                 assert_equal Role.count, Role.find(2).position
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages