jro_apps/redmine Commit - r3256:e5d300af0a4d

Refactor: Pull up several #find_project methods to ApplicationController...

Eric Davis -

r3256:e5d300af0a4d

parent child

Context file:

r3256:e5d300af0a4d

app/controllers/application_controller.rb +7 0

               def authorize_global(ctrl = params[:controller], action = params[:action], global = true)
                 authorize(ctrl, action, global)
               end
+              # Find project of id params[:id]
+              def find_project
+                @project = Project.find(params[:id])
+              rescue ActiveRecord::RecordNotFound
+                render_404
+              end
               # make sure that the user is a member of the project (or admin) if project is private
               # used as a before_filter for actions that do not require any particular permission on the project

app/controllers/members_controller.rb 0 -6

               end
             private
-              def find_project
-                @project = Project.find(params[:id])
-              rescue ActiveRecord::RecordNotFound
-                render_404
-              end
               def find_member
                 @member = Member.find(params[:id])
                 @project = @member.project

app/controllers/projects_controller.rb 0 -9

@@ -413,15 +413,6 class ProjectsController < ApplicationController
413	end	413	end
414		414
415	private	415	private
416	# Find project of id params[:id]
417	# if not found, redirect to project list
418	# Used as a before_filter
419	def find_project
420	@project = Project.find(params[:id])
421	rescue ActiveRecord::RecordNotFound
422	render_404
423	end
424
425	def find_optional_project	416	def find_optional_project
426	return true unless params[:id]	417	return true unless params[:id]
427	@project = Project.find(params[:id])	418	@project = Project.find(params[:id])

app/controllers/reports_controller.rb 0 -7

               end
             private
-              # Find project of id params[:id]
-              def find_project
-                @project = Project.find(params[:id])
-              rescue ActiveRecord::RecordNotFound
-                render_404
-              end
               def issues_by_tracker
                 @issues_by_tracker ||= Issue.by_tracker(@project)
               end

app/controllers/repositories_controller.rb 0 -6

               end
             private
-              def find_project
-                @project = Project.find(params[:id])
-              rescue ActiveRecord::RecordNotFound
-                render_404
-              end
               def find_repository
                 @project = Project.find(params[:id])
                 @repository = @project.repository

app/controllers/wikis_controller.rb 0 -7

@@ -34,11 +34,4 class WikisController < ApplicationController
34	redirect_to :controller => 'projects', :action => 'settings', :id => @project, :tab => 'wiki'	34	redirect_to :controller => 'projects', :action => 'settings', :id => @project, :tab => 'wiki'
35	end	35	end
36	end	36	end
37
38	private
39	def find_project
40	@project = Project.find(params[:id])
41	rescue ActiveRecord::RecordNotFound
42	render_404
43	end
44	end	37	end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages