jro_apps/redmine Commit - r15916:e360394be7a4

Merged r16287 to r16289 (#24416)....

Jean-Philippe Lang -

r15916:e360394be7a4

parent child

Context file:

r15916:e360394be7a4

Collapse all files

app/controllers/account_controller.rb +10 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class AccountController < ApplicationController
               helper :custom_fields
               include CustomFieldsHelper
               # prevents login action to be filtered by check_if_login_required application scope filter
               skip_before_filter :check_if_login_required, :check_password_change
               # Overrides ApplicationController#verify_authenticity_token to disable
               # token verification on openid callbacks
               def verify_authenticity_token
                 unless using_open_id?
                   super
                 end
               end
               # Login request and validation
               def login
                 if request.get?
                   if User.current.logged?
                     redirect_back_or_default home_url, :referer => true
                   end
                 else
                   authenticate_user
                 end
               rescue AuthSourceException => e
                 logger.error "An error occured when authenticating #{params[:username]}: #{e.message}"
                 render_error :message => e.message
               end
               # Log out current user and redirect to welcome page
               def logout
                 if User.current.anonymous?
                   redirect_to home_url
                 elsif request.post?
                   logout_user
                   redirect_to home_url
                 end
                 # display the logout form
               end
               # Lets user choose a new password
               def lost_password
                 (redirect_to(home_url); return) unless Setting.lost_password?
-                if params[:token]
+                if prt = (params[:token] || session[:password_recovery_token])
-                  @token = Token.find_token("recovery", params[:token].to_s)
+                  @token = Token.find_token("recovery", prt.to_s)
                   if @token.nil? || @token.expired?
                     redirect_to home_url
                     return
                   end
+                  # redirect to remove the token query parameter from the URL and add it to the session
+                  if request.query_parameters[:token].present?
+                    session[:password_recovery_token] = @token.value
+                    redirect_to lost_password_url
+                    return
+                  end
                   @user = @token.user
                   unless @user && @user.active?
                     redirect_to home_url
                     return
                   end
                   if request.post?
                     @user.password, @user.password_confirmation = params[:new_password], params[:new_password_confirmation]
                     if @user.save
                       @token.destroy
                       Mailer.password_updated(@user)
                       flash[:notice] = l(:notice_account_password_updated)
                       redirect_to signin_path
                       return
                     end
                   end
                   render :template => "account/password_recovery"
                   return
                 else
                   if request.post?
                     email = params[:mail].to_s
                     user = User.find_by_mail(email)
                     # user not found
                     unless user
                       flash.now[:error] = l(:notice_account_unknown_email)
                       return
                     end
                     unless user.active?
                       handle_inactive_user(user, lost_password_path)
                       return
                     end
                     # user cannot change its password
                     unless user.change_password_allowed?
                       flash.now[:error] = l(:notice_can_t_change_password)
                       return
                     end
                     # create a new token for password recovery
                     token = Token.new(:user => user, :action => "recovery")
                     if token.save
                       # Don't use the param to send the email
                       recipent = user.mails.detect {|e| email.casecmp(e) == 0} || user.mail
                       Mailer.lost_password(token, recipent).deliver
                       flash[:notice] = l(:notice_account_lost_email_sent)
                       redirect_to signin_path
                       return
                     end
                   end
                 end
               end
               # User self-registration
               def register
                 (redirect_to(home_url); return) unless Setting.self_registration? || session[:auth_source_registration]
                 if request.get?
                   session[:auth_source_registration] = nil
                   @user = User.new(:language => current_language.to_s)
                 else
                   user_params = params[:user] || {}
                   @user = User.new
                   @user.safe_attributes = user_params
                   @user.pref.attributes = params[:pref] if params[:pref]
                   @user.admin = false
                   @user.register
                   if session[:auth_source_registration]
                     @user.activate
                     @user.login = session[:auth_source_registration][:login]
                     @user.auth_source_id = session[:auth_source_registration][:auth_source_id]
                     if @user.save
                       session[:auth_source_registration] = nil
                       self.logged_user = @user
                       flash[:notice] = l(:notice_account_activated)
                       redirect_to my_account_path
                     end
                   else
                     @user.login = params[:user][:login]
                     unless user_params[:identity_url].present? && user_params[:password].blank? && user_params[:password_confirmation].blank?
                       @user.password, @user.password_confirmation = user_params[:password], user_params[:password_confirmation]
                     end
                     case Setting.self_registration
                     when '1'
                       register_by_email_activation(@user)
                     when '3'
                       register_automatically(@user)
                     else
                       register_manually_by_administrator(@user)
                     end
                   end
                 end
               end
               # Token based account activation
               def activate
                 (redirect_to(home_url); return) unless Setting.self_registration? && params[:token].present?
                 token = Token.find_token('register', params[:token].to_s)
                 (redirect_to(home_url); return) unless token and !token.expired?
                 user = token.user
                 (redirect_to(home_url); return) unless user.registered?
                 user.activate
                 if user.save
                   token.destroy
                   flash[:notice] = l(:notice_account_activated)
                 end
                 redirect_to signin_path
               end
               # Sends a new account activation email
               def activation_email
                 if session[:registered_user_id] && Setting.self_registration == '1'
                   user_id = session.delete(:registered_user_id).to_i
                   user = User.find_by_id(user_id)
                   if user && user.registered?
                     register_by_email_activation(user)
                     return
                   end
                 end
                 redirect_to(home_url)
               end
               private
               def authenticate_user
                 if Setting.openid? && using_open_id?
                   open_id_authenticate(params[:openid_url])
                 else
                   password_authentication
                 end
               end
               def password_authentication
                 user = User.try_to_login(params[:username], params[:password], false)
                 if user.nil?
                   invalid_credentials
                 elsif user.new_record?
                   onthefly_creation_failed(user, {:login => user.login, :auth_source_id => user.auth_source_id })
                 else
                   # Valid user
                   if user.active?
                     successful_authentication(user)
                     update_sudo_timestamp! # activate Sudo Mode
                   else
                     handle_inactive_user(user)
                   end
                 end
               end
               def open_id_authenticate(openid_url)
                 back_url = signin_url(:autologin => params[:autologin])
                 authenticate_with_open_id(
                       openid_url, :required => [:nickname, :fullname, :email],
                       :return_to => back_url, :method => :post
                 ) do |result, identity_url, registration|
                   if result.successful?
                     user = User.find_or_initialize_by_identity_url(identity_url)
                     if user.new_record?
                       # Self-registration off
                       (redirect_to(home_url); return) unless Setting.self_registration?
                       # Create on the fly
                       user.login = registration['nickname'] unless registration['nickname'].nil?
                       user.mail = registration['email'] unless registration['email'].nil?
                       user.firstname, user.lastname = registration['fullname'].split(' ') unless registration['fullname'].nil?
                       user.random_password
                       user.register
                       case Setting.self_registration
                       when '1'
                         register_by_email_activation(user) do
                           onthefly_creation_failed(user)
                         end
                       when '3'
                         register_automatically(user) do
                           onthefly_creation_failed(user)
                         end
                       else
                         register_manually_by_administrator(user) do
                           onthefly_creation_failed(user)
                         end
                       end
                     else
                       # Existing record
                       if user.active?
                         successful_authentication(user)
                       else
                         handle_inactive_user(user)
                       end
                     end
                   end
                 end
               end
               def successful_authentication(user)
                 logger.info "Successful authentication for '#{user.login}' from #{request.remote_ip} at #{Time.now.utc}"
                 # Valid user
                 self.logged_user = user
                 # generate a key and set cookie if autologin
                 if params[:autologin] && Setting.autologin?
                   set_autologin_cookie(user)
                 end
                 call_hook(:controller_account_success_authentication_after, {:user => user })
                 redirect_back_or_default my_page_path
               end
               def set_autologin_cookie(user)
                 token = Token.create(:user => user, :action => 'autologin')
                 secure = Redmine::Configuration['autologin_cookie_secure']
                 if secure.nil?
                   secure = request.ssl?
                 end
                 cookie_options = {
                   :value => token.value,
                   :expires => 1.year.from_now,
                   :path => (Redmine::Configuration['autologin_cookie_path'] || RedmineApp::Application.config.relative_url_root || '/'),
                   :secure => secure,
                   :httponly => true
                 }
                 cookies[autologin_cookie_name] = cookie_options
               end
               # Onthefly creation failed, display the registration form to fill/fix attributes
               def onthefly_creation_failed(user, auth_source_options = { })
                 @user = user
                 session[:auth_source_registration] = auth_source_options unless auth_source_options.empty?
                 render :action => 'register'
               end
               def invalid_credentials
                 logger.warn "Failed login for '#{params[:username]}' from #{request.remote_ip} at #{Time.now.utc}"
                 flash.now[:error] = l(:notice_account_invalid_credentials)
               end
               # Register a user for email activation.
               #
               # Pass a block for behavior when a user fails to save
               def register_by_email_activation(user, &block)
                 token = Token.new(:user => user, :action => "register")
                 if user.save and token.save
                   Mailer.register(token).deliver
                   flash[:notice] = l(:notice_account_register_done, :email => ERB::Util.h(user.mail))
                   redirect_to signin_path
                 else
                   yield if block_given?
                 end
               end
               # Automatically register a user
               #
               # Pass a block for behavior when a user fails to save
               def register_automatically(user, &block)
                 # Automatic activation
                 user.activate
                 user.last_login_on = Time.now
                 if user.save
                   self.logged_user = user
                   flash[:notice] = l(:notice_account_activated)
                   redirect_to my_account_path
                 else
                   yield if block_given?
                 end
               end
               # Manual activation by the administrator
               #
               # Pass a block for behavior when a user fails to save
               def register_manually_by_administrator(user, &block)
                 if user.save
                   # Sends an email to the administrators
                   Mailer.account_activation_request(user).deliver
                   account_pending(user)
                 else
                   yield if block_given?
                 end
               end
               def handle_inactive_user(user, redirect_path=signin_path)
                 if user.registered?
                   account_pending(user, redirect_path)
                 else
                   account_locked(user, redirect_path)
                 end
               end
               def account_pending(user, redirect_path=signin_path)
                 if Setting.self_registration == '1'
                   flash[:error] = l(:notice_account_not_activated_yet, :url => activation_email_path)
                   session[:registered_user_id] = user.id
                 else
                   flash[:error] = l(:notice_account_pending)
                 end
                 redirect_to redirect_path
               end
               def account_locked(user, redirect_path=signin_path)
                 flash[:error] = l(:notice_account_locked)
                 redirect_to redirect_path
               end
             end

test/functional/account_controller_test.rb +12 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AccountControllerTest < ActionController::TestCase
               fixtures :users, :email_addresses, :roles
               def setup
                 User.current = nil
               end
               def test_get_login
                 get :login
                 assert_response :success
                 assert_template 'login'
                 assert_select 'input[name=username]'
                 assert_select 'input[name=password]'
               end
               def test_get_login_while_logged_in_should_redirect_to_back_url_if_present
                 @request.session[:user_id] = 2
                 @request.env["HTTP_REFERER"] = 'http://test.host/issues/show/1'
                 get :login, :back_url => 'http://test.host/issues/show/1'
                 assert_redirected_to '/issues/show/1'
                 assert_equal 2, @request.session[:user_id]
               end
               def test_get_login_while_logged_in_should_redirect_to_referer_without_back_url
                 @request.session[:user_id] = 2
                 @request.env["HTTP_REFERER"] = 'http://test.host/issues/show/1'
                 get :login
                 assert_redirected_to '/issues/show/1'
                 assert_equal 2, @request.session[:user_id]
               end
               def test_get_login_while_logged_in_should_redirect_to_home_by_default
                 @request.session[:user_id] = 2
                 get :login
                 assert_redirected_to '/'
                 assert_equal 2, @request.session[:user_id]
               end
               def test_login_should_redirect_to_back_url_param
                 # request.uri is "test.host" in test environment
                 back_urls = [
                   'http://test.host/issues/show/1',
                   'http://test.host/',
                   '/'
                 ]
                 back_urls.each do |back_url|
                   post :login, :username => 'jsmith', :password => 'jsmith', :back_url => back_url
                   assert_redirected_to back_url
                 end
               end
               def test_login_with_suburi_should_redirect_to_back_url_param
                 @relative_url_root = Redmine::Utils.relative_url_root
                 Redmine::Utils.relative_url_root = '/redmine'
                 back_urls = [
                   'http://test.host/redmine/issues/show/1',
                   '/redmine'
                 ]
                 back_urls.each do |back_url|
                   post :login, :username => 'jsmith', :password => 'jsmith', :back_url => back_url
                   assert_redirected_to back_url
                 end
               ensure
                 Redmine::Utils.relative_url_root = @relative_url_root
               end
               def test_login_should_not_redirect_to_another_host
                 back_urls = [
                   'http://test.foo/fake',
                   '//test.foo/fake'
                 ]
                 back_urls.each do |back_url|
                   post :login, :username => 'jsmith', :password => 'jsmith', :back_url => back_url
                   assert_redirected_to '/my/page'
                 end
               end
               def test_login_with_suburi_should_not_redirect_to_another_suburi
                 @relative_url_root = Redmine::Utils.relative_url_root
                 Redmine::Utils.relative_url_root = '/redmine'
                 back_urls = [
                   'http://test.host/',
                   'http://test.host/fake',
                   'http://test.host/fake/issues',
                   'http://test.host/redmine/../fake',
                   'http://test.host/redmine/../fake/issues',
                   'http://test.host/redmine/%2e%2e/fake',
                   '//test.foo/fake',
                   'http://test.host//fake',
                   'http://test.host/\n//fake',
                   '//bar@test.foo',
                   '//test.foo',
                   '////test.foo',
                   '@test.foo',
                   'fake@test.foo',
                   '.test.foo'
                 ]
                 back_urls.each do |back_url|
                   post :login, :username => 'jsmith', :password => 'jsmith', :back_url => back_url
                   assert_redirected_to '/my/page'
                 end
               ensure
                 Redmine::Utils.relative_url_root = @relative_url_root
               end
               def test_login_with_wrong_password
                 post :login, :username => 'admin', :password => 'bad'
                 assert_response :success
                 assert_template 'login'
                 assert_select 'div.flash.error', :text => /Invalid user or password/
                 assert_select 'input[name=username][value=admin]'
                 assert_select 'input[name=password]'
                 assert_select 'input[name=password][value]', 0
               end
               def test_login_with_locked_account_should_fail
                 User.find(2).update_attribute :status, User::STATUS_LOCKED
                 post :login, :username => 'jsmith', :password => 'jsmith'
                 assert_redirected_to '/login'
                 assert_include 'locked', flash[:error]
                 assert_nil @request.session[:user_id]
               end
               def test_login_as_registered_user_with_manual_activation_should_inform_user
                 User.find(2).update_attribute :status, User::STATUS_REGISTERED
                 with_settings :self_registration => '2', :default_language => 'en' do
                   post :login, :username => 'jsmith', :password => 'jsmith'
                   assert_redirected_to '/login'
                   assert_include 'pending administrator approval', flash[:error]
                 end
               end
               def test_login_as_registered_user_with_email_activation_should_propose_new_activation_email
                 User.find(2).update_attribute :status, User::STATUS_REGISTERED
                 with_settings :self_registration => '1', :default_language => 'en' do
                   post :login, :username => 'jsmith', :password => 'jsmith'
                   assert_redirected_to '/login'
                   assert_equal 2, @request.session[:registered_user_id]
                   assert_include 'new activation email', flash[:error]
                 end
               end
               def test_login_should_rescue_auth_source_exception
                 source = AuthSource.create!(:name => 'Test')
                 User.find(2).update_attribute :auth_source_id, source.id
                 AuthSource.any_instance.stubs(:authenticate).raises(AuthSourceException.new("Something wrong"))
                 post :login, :username => 'jsmith', :password => 'jsmith'
                 assert_response 500
                 assert_select_error /Something wrong/
               end
               def test_login_should_reset_session
                 @controller.expects(:reset_session).once
                 post :login, :username => 'jsmith', :password => 'jsmith'
                 assert_response 302
               end
               def test_get_logout_should_not_logout
                 @request.session[:user_id] = 2
                 get :logout
                 assert_response :success
                 assert_template 'logout'
                 assert_equal 2, @request.session[:user_id]
               end
               def test_get_logout_with_anonymous_should_redirect
                 get :logout
                 assert_redirected_to '/'
               end
               def test_logout
                 @request.session[:user_id] = 2
                 post :logout
                 assert_redirected_to '/'
                 assert_nil @request.session[:user_id]
               end
               def test_logout_should_reset_session
                 @controller.expects(:reset_session).once
                 @request.session[:user_id] = 2
                 post :logout
                 assert_response 302
               end
               def test_get_register_with_registration_on
                 with_settings :self_registration => '3' do
                   get :register
                   assert_response :success
                   assert_template 'register'
                   assert_not_nil assigns(:user)
                   assert_select 'input[name=?]', 'user[password]'
                   assert_select 'input[name=?]', 'user[password_confirmation]'
                 end
               end
               def test_get_register_should_detect_user_language
                 with_settings :self_registration => '3' do
                   @request.env['HTTP_ACCEPT_LANGUAGE'] = 'fr,fr-fr;q=0.8,en-us;q=0.5,en;q=0.3'
                   get :register
                   assert_response :success
                   assert_not_nil assigns(:user)
                   assert_equal 'fr', assigns(:user).language
                   assert_select 'select[name=?]', 'user[language]' do
                     assert_select 'option[value=fr][selected=selected]'
                   end
                 end
               end
               def test_get_register_with_registration_off_should_redirect
                 with_settings :self_registration => '0' do
                   get :register
                   assert_redirected_to '/'
                 end
               end
               def test_get_register_should_show_hide_mail_preference
                 get :register
                 assert_select 'input[name=?][checked=checked]', 'pref[hide_mail]'
               end
               def test_get_register_should_show_hide_mail_preference_with_setting_turned_off
                 with_settings :default_users_hide_mail => '0' do
                   get :register
                   assert_select 'input[name=?]:not([checked=checked])', 'pref[hide_mail]'
                 end
               end
               # See integration/account_test.rb for the full test
               def test_post_register_with_registration_on
                 with_settings :self_registration => '3' do
                   assert_difference 'User.count' do
                     post :register, :user => {
                       :login => 'register',
                       :password => 'secret123',
                       :password_confirmation => 'secret123',
                       :firstname => 'John',
                       :lastname => 'Doe',
                       :mail => 'register@example.com'
                     }
                     assert_redirected_to '/my/account'
                   end
                   user = User.order('id DESC').first
                   assert_equal 'register', user.login
                   assert_equal 'John', user.firstname
                   assert_equal 'Doe', user.lastname
                   assert_equal 'register@example.com', user.mail
                   assert user.check_password?('secret123')
                   assert user.active?
                 end
               end
               def test_post_register_with_registration_off_should_redirect
                 with_settings :self_registration => '0' do
                   assert_no_difference 'User.count' do
                     post :register, :user => {
                       :login => 'register',
                       :password => 'test',
                       :password_confirmation => 'test',
                       :firstname => 'John',
                       :lastname => 'Doe',
                       :mail => 'register@example.com'
                     }
                     assert_redirected_to '/'
                   end
                 end
               end
               def test_post_register_should_create_user_with_hide_mail_preference
                 with_settings :default_users_hide_mail => '0' do
                   user = new_record(User) do
                     post :register, :user => {
                       :login => 'register',
                       :password => 'secret123', :password_confirmation => 'secret123',
                       :firstname => 'John', :lastname => 'Doe',
                       :mail => 'register@example.com'
                     }, :pref => {
                       :hide_mail => '1'
                     }
                   end
                   assert_equal true, user.pref.hide_mail
                 end
               end
               def test_get_lost_password_should_display_lost_password_form
                 get :lost_password
                 assert_response :success
                 assert_select 'input[name=mail]'
               end
               def test_lost_password_for_active_user_should_create_a_token
                 Token.delete_all
                 ActionMailer::Base.deliveries.clear
                 assert_difference 'ActionMailer::Base.deliveries.size' do
                   assert_difference 'Token.count' do
                     post :lost_password, :mail => 'JSmith@somenet.foo'
                     assert_redirected_to '/login'
                   end
                 end
                 token = Token.order('id DESC').first
                 assert_equal User.find(2), token.user
                 assert_equal 'recovery', token.action
                 assert_select_email do
                   assert_select "a[href=?]", "http://localhost:3000/account/lost_password?token=#{token.value}"
                 end
               end
               def test_lost_password_using_additional_email_address_should_send_email_to_the_address
                 EmailAddress.create!(:user_id => 2, :address => 'anotherAddress@foo.bar')
                 Token.delete_all
                 assert_difference 'ActionMailer::Base.deliveries.size' do
                   assert_difference 'Token.count' do
                     post :lost_password, :mail => 'ANOTHERaddress@foo.bar'
                     assert_redirected_to '/login'
                   end
                 end
                 mail = ActionMailer::Base.deliveries.last
                 assert_equal ['anotherAddress@foo.bar'], mail.bcc
               end
               def test_lost_password_for_unknown_user_should_fail
                 Token.delete_all
                 assert_no_difference 'Token.count' do
                   post :lost_password, :mail => 'invalid@somenet.foo'
                   assert_response :success
                 end
               end
               def test_lost_password_for_non_active_user_should_fail
                 Token.delete_all
                 assert User.find(2).lock!
                 assert_no_difference 'Token.count' do
                   post :lost_password, :mail => 'JSmith@somenet.foo'
                   assert_redirected_to '/account/lost_password'
                 end
               end
               def test_lost_password_for_user_who_cannot_change_password_should_fail
                 User.any_instance.stubs(:change_password_allowed?).returns(false)
                 assert_no_difference 'Token.count' do
                   post :lost_password, :mail => 'JSmith@somenet.foo'
                   assert_response :success
                 end
               end
-              def test_get_lost_password_with_token_should_display_the_password_recovery_form
+              def test_get_lost_password_with_token_should_redirect_with_token_in_session
                 user = User.find(2)
                 token = Token.create!(:action => 'recovery', :user => user)
                 get :lost_password, :token => token.value
+                assert_redirected_to '/account/lost_password'
+                assert_equal token.value, request.session[:password_recovery_token]
+              end
+              def test_get_lost_password_with_token_in_session_should_display_the_password_recovery_form
+                user = User.find(2)
+                token = Token.create!(:action => 'recovery', :user => user)
+                request.session[:password_recovery_token] = token.value
+                get :lost_password
                 assert_response :success
                 assert_template 'password_recovery'
                 assert_select 'input[type=hidden][name=token][value=?]', token.value
               end
               def test_get_lost_password_with_invalid_token_should_redirect
                 get :lost_password, :token => "abcdef"
                 assert_redirected_to '/'
               end
               def test_post_lost_password_with_token_should_change_the_user_password
                 ActionMailer::Base.deliveries.clear
                 user = User.find(2)
                 token = Token.create!(:action => 'recovery', :user => user)
                 post :lost_password, :token => token.value, :new_password => 'newpass123', :new_password_confirmation => 'newpass123'
                 assert_redirected_to '/login'
                 user.reload
                 assert user.check_password?('newpass123')
                 assert_nil Token.find_by_id(token.id), "Token was not deleted"
                 assert_not_nil (mail = ActionMailer::Base.deliveries.last)
                 assert_select_email do
                   assert_select 'a[href^=?]', 'http://localhost:3000/my/password', :text => 'Change password'
                 end
               end
               def test_post_lost_password_with_token_for_non_active_user_should_fail
                 user = User.find(2)
                 token = Token.create!(:action => 'recovery', :user => user)
                 user.lock!
                 post :lost_password, :token => token.value, :new_password => 'newpass123', :new_password_confirmation => 'newpass123'
                 assert_redirected_to '/'
                 assert ! user.check_password?('newpass123')
               end
               def test_post_lost_password_with_token_and_password_confirmation_failure_should_redisplay_the_form
                 user = User.find(2)
                 token = Token.create!(:action => 'recovery', :user => user)
                 post :lost_password, :token => token.value, :new_password => 'newpass', :new_password_confirmation => 'wrongpass'
                 assert_response :success
                 assert_template 'password_recovery'
                 assert_not_nil Token.find_by_id(token.id), "Token was deleted"
                 assert_select 'input[type=hidden][name=token][value=?]', token.value
               end
               def test_post_lost_password_with_invalid_token_should_redirect
                 post :lost_password, :token => "abcdef", :new_password => 'newpass', :new_password_confirmation => 'newpass'
                 assert_redirected_to '/'
               end
               def test_activation_email_should_send_an_activation_email
                 User.find(2).update_attribute :status, User::STATUS_REGISTERED
                 @request.session[:registered_user_id] = 2
                 with_settings :self_registration => '1' do
                   assert_difference 'ActionMailer::Base.deliveries.size' do
                     get :activation_email
                     assert_redirected_to '/login'
                   end
                 end
               end
               def test_activation_email_without_session_data_should_fail
                 User.find(2).update_attribute :status, User::STATUS_REGISTERED
                 with_settings :self_registration => '1' do
                   assert_no_difference 'ActionMailer::Base.deliveries.size' do
                     get :activation_email
                     assert_redirected_to '/'
                   end
                 end
               end
             end

test/integration/account_test.rb +3 0

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AccountTest < Redmine::IntegrationTest
               fixtures :users, :email_addresses, :roles
               def test_login
                 get "/my/page"
                 assert_redirected_to "/login?back_url=http%3A%2F%2Fwww.example.com%2Fmy%2Fpage"
                 log_user('jsmith', 'jsmith')
                 get "/my/account"
                 assert_response :success
                 assert_template "my/account"
               end
               def test_login_should_set_session_token
                 assert_difference 'Token.count' do
                   log_user('jsmith', 'jsmith')
                   assert_equal 2, session[:user_id]
                   assert_not_nil session[:tk]
                 end
               end
               def test_autologin
                 user = User.find(1)
                 Token.delete_all
                 with_settings :autologin => '7' do
                   assert_difference 'Token.count', 2 do
                     # User logs in with 'autologin' checked
                     post '/login', :username => user.login, :password => 'admin', :autologin => 1
                     assert_redirected_to '/my/page'
                   end
                   token = Token.where(:action => 'autologin').order(:id => :desc).first
                   assert_not_nil token
                   assert_equal user, token.user
                   assert_equal 'autologin', token.action
                   assert_equal user.id, session[:user_id]
                   assert_equal token.value, cookies['autologin']
                   # Session is cleared
                   reset!
                   User.current = nil
                   # Clears user's last login timestamp
                   user.update_attribute :last_login_on, nil
                   assert_nil user.reload.last_login_on
                   # User comes back with user's autologin cookie
                   cookies[:autologin] = token.value
                   get '/my/page'
                   assert_response :success
                   assert_template 'my/page'
                   assert_equal user.id, session[:user_id]
                   assert_not_nil user.reload.last_login_on
                 end
               end
               def test_autologin_should_use_autologin_cookie_name
                 Token.delete_all
                 Redmine::Configuration.stubs(:[]).with('autologin_cookie_name').returns('custom_autologin')
                 Redmine::Configuration.stubs(:[]).with('autologin_cookie_path').returns('/')
                 Redmine::Configuration.stubs(:[]).with('autologin_cookie_secure').returns(false)
                 Redmine::Configuration.stubs(:[]).with('sudo_mode_timeout').returns(15)
                 with_settings :autologin => '7' do
                   assert_difference 'Token.count', 2 do
                     post '/login', :username => 'admin', :password => 'admin', :autologin => 1
                     assert_response 302
                   end
                   assert cookies['custom_autologin'].present?
                   token = cookies['custom_autologin']
                   # Session is cleared
                   reset!
                   cookies['custom_autologin'] = token
                   get '/my/page'
                   assert_response :success
                   assert_difference 'Token.count', -2 do
                     post '/logout'
                   end
                   assert cookies['custom_autologin'].blank?
                 end
               end
               def test_lost_password
                 Token.delete_all
                 get "/account/lost_password"
                 assert_response :success
                 assert_template "account/lost_password"
                 assert_select 'input[name=mail]'
                 post "/account/lost_password", :mail => 'jSmith@somenet.foo'
                 assert_redirected_to "/login"
                 token = Token.first
                 assert_equal 'recovery', token.action
                 assert_equal 'jsmith@somenet.foo', token.user.mail
                 assert !token.expired?
                 get "/account/lost_password", :token => token.value
+                assert_redirected_to '/account/lost_password'
+                follow_redirect!
                 assert_response :success
                 assert_template "account/password_recovery"
                 assert_select 'input[type=hidden][name=token][value=?]', token.value
                 assert_select 'input[name=new_password]'
                 assert_select 'input[name=new_password_confirmation]'
                 post "/account/lost_password",
                      :token => token.value, :new_password => 'newpass123',
                      :new_password_confirmation => 'newpass123'
                 assert_redirected_to "/login"
                 assert_equal 'Password was successfully updated.', flash[:notice]
                 log_user('jsmith', 'newpass123')
                 assert_equal false, Token.exists?(token.id), "Password recovery token was not deleted"
               end
               def test_user_with_must_change_passwd_should_be_forced_to_change_its_password
                 User.find_by_login('jsmith').update_attribute :must_change_passwd, true
                 post '/login', :username => 'jsmith', :password => 'jsmith'
                 assert_redirected_to '/my/page'
                 follow_redirect!
                 assert_redirected_to '/my/password'
                 get '/issues'
                 assert_redirected_to '/my/password'
               end
               def test_flash_message_should_use_user_language_when_redirecting_user_for_password_change
                 user = User.find_by_login('jsmith')
                 user.must_change_passwd = true
                 user.language = 'it'
                 user.save!
                 post '/login', :username => 'jsmith', :password => 'jsmith'
                 assert_redirected_to '/my/page'
                 follow_redirect!
                 assert_redirected_to '/my/password'
                 follow_redirect!
                 assert_select 'div.error', :text => /richiesto che sia cambiata/
               end
               def test_user_with_must_change_passwd_should_be_able_to_change_its_password
                 User.find_by_login('jsmith').update_attribute :must_change_passwd, true
                 post '/login', :username => 'jsmith', :password => 'jsmith'
                 assert_redirected_to '/my/page'
                 follow_redirect!
                 assert_redirected_to '/my/password'
                 follow_redirect!
                 assert_response :success
                 post '/my/password', :password => 'jsmith', :new_password => 'newpassword', :new_password_confirmation => 'newpassword'
                 assert_redirected_to '/my/account'
                 follow_redirect!
                 assert_response :success
                 assert_equal false, User.find_by_login('jsmith').must_change_passwd?
               end
               def test_user_with_expired_password_should_be_forced_to_change_its_password
                 User.find_by_login('jsmith').update_attribute :passwd_changed_on, 14.days.ago
                 with_settings :password_max_age => 7 do
                   post '/login', :username => 'jsmith', :password => 'jsmith'
                   assert_redirected_to '/my/page'
                   follow_redirect!
                   assert_redirected_to '/my/password'
                   get '/issues'
                   assert_redirected_to '/my/password'
                 end
               end
               def test_user_with_expired_password_should_be_able_to_change_its_password
                 User.find_by_login('jsmith').update_attribute :passwd_changed_on, 14.days.ago
                 with_settings :password_max_age => 7 do
                   post '/login', :username => 'jsmith', :password => 'jsmith'
                   assert_redirected_to '/my/page'
                   follow_redirect!
                   assert_redirected_to '/my/password'
                   follow_redirect!
                   assert_response :success
                   post '/my/password', :password => 'jsmith', :new_password => 'newpassword', :new_password_confirmation => 'newpassword'
                   assert_redirected_to '/my/account'
                   follow_redirect!
                   assert_response :success
                   assert_equal false, User.find_by_login('jsmith').must_change_passwd?
                 end
               end
               def test_register_with_automatic_activation
                 Setting.self_registration = '3'
                 get '/account/register'
                 assert_response :success
                 assert_template 'account/register'
                 post '/account/register',
                      :user => {:login => "newuser", :language => "en",
                                :firstname => "New", :lastname => "User", :mail => "newuser@foo.bar",
                                :password => "newpass123", :password_confirmation => "newpass123"}
                 assert_redirected_to '/my/account'
                 follow_redirect!
                 assert_response :success
                 assert_template 'my/account'
                 user = User.find_by_login('newuser')
                 assert_not_nil user
                 assert user.active?
                 assert_not_nil user.last_login_on
               end
               def test_register_with_manual_activation
                 Setting.self_registration = '2'
                 post '/account/register',
                      :user => {:login => "newuser", :language => "en",
                                :firstname => "New", :lastname => "User", :mail => "newuser@foo.bar",
                                :password => "newpass123", :password_confirmation => "newpass123"}
                 assert_redirected_to '/login'
                 assert !User.find_by_login('newuser').active?
               end
               def test_register_with_email_activation
                 Setting.self_registration = '1'
                 Token.delete_all
                 post '/account/register',
                      :user => {:login => "newuser", :language => "en",
                                :firstname => "New", :lastname => "User", :mail => "newuser@foo.bar",
                                :password => "newpass123", :password_confirmation => "newpass123"}
                 assert_redirected_to '/login'
                 assert !User.find_by_login('newuser').active?
                 token = Token.first
                 assert_equal 'register', token.action
                 assert_equal 'newuser@foo.bar', token.user.mail
                 assert !token.expired?
                 get '/account/activate', :token => token.value
                 assert_redirected_to '/login'
                 log_user('newuser', 'newpass123')
               end
               def test_onthefly_registration
                 # disable registration
                 Setting.self_registration = '0'
                 AuthSource.expects(:authenticate).returns(
                   {:login => 'foo', :firstname => 'Foo', :lastname => 'Smith',
                    :mail => 'foo@bar.com', :auth_source_id => 66})
                 post '/login', :username => 'foo', :password => 'bar'
                 assert_redirected_to '/my/page'
                 user = User.find_by_login('foo')
                 assert user.is_a?(User)
                 assert_equal 66, user.auth_source_id
                 assert user.hashed_password.blank?
               end
               def test_onthefly_registration_with_invalid_attributes
                 # disable registration
                 Setting.self_registration = '0'
                 AuthSource.expects(:authenticate).returns(
                   {:login => 'foo', :lastname => 'Smith', :auth_source_id => 66})
                 post '/login', :username => 'foo', :password => 'bar'
                 assert_response :success
                 assert_template 'account/register'
                 assert_select 'input[name=?][value=""]', 'user[firstname]'
                 assert_select 'input[name=?][value=Smith]', 'user[lastname]'
                 assert_select 'input[name=?]', 'user[login]', 0
                 assert_select 'input[name=?]', 'user[password]', 0
                 post '/account/register',
                      :user => {:firstname => 'Foo', :lastname => 'Smith', :mail => 'foo@bar.com'}
                 assert_redirected_to '/my/account'
                 user = User.find_by_login('foo')
                 assert user.is_a?(User)
                 assert_equal 66, user.auth_source_id
                 assert user.hashed_password.blank?
               end
               def test_registered_user_should_be_able_to_get_a_new_activation_email
                 Token.delete_all
                 with_settings :self_registration => '1', :default_language => 'en' do
                   # register a new account
                   assert_difference 'User.count' do
                     assert_difference 'Token.count' do
                       post '/account/register',
                          :user => {:login => "newuser", :language => "en",
                                    :firstname => "New", :lastname => "User", :mail => "newuser@foo.bar",
                                    :password => "newpass123", :password_confirmation => "newpass123"}
                     end
                   end
                   user = User.order('id desc').first
                   assert_equal User::STATUS_REGISTERED, user.status
                   reset!
                   # try to use "lost password"
                   assert_no_difference 'ActionMailer::Base.deliveries.size' do
                     post '/account/lost_password', :mail => 'newuser@foo.bar'
                   end
                   assert_redirected_to '/account/lost_password'
                   follow_redirect!
                   assert_response :success
                   assert_select 'div.flash', :text => /new activation email/
                   assert_select 'div.flash a[href="/account/activation_email"]'
                   # request a new action activation email
                   assert_difference 'ActionMailer::Base.deliveries.size' do
                     get '/account/activation_email'
                   end
                   assert_redirected_to '/login'
                   token = Token.order('id desc').first
                   activation_path = "/account/activate?token=#{token.value}"
                   assert_include activation_path, mail_body(ActionMailer::Base.deliveries.last)
                   # activate the account
                   get activation_path
                   assert_redirected_to '/login'
                   post '/login', :username => 'newuser', :password => 'newpass123'
                   assert_redirected_to '/my/page'
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages