| @@ -1,575 +1,562 | |||
|
|
1 | 1 | # Redmine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2008 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | class IssuesController < ApplicationController |
|
|
19 | 19 | menu_item :new_issue, :only => :new |
|
|
20 | 20 | default_search_scope :issues |
|
|
21 | 21 | |
|
|
22 | 22 | before_filter :find_issue, :only => [:show, :edit, :reply] |
|
|
23 | 23 | before_filter :find_issues, :only => [:bulk_edit, :move, :destroy] |
|
|
24 | 24 | before_filter :find_project, :only => [:new, :update_form, :preview] |
|
|
25 | 25 | before_filter :authorize, :except => [:index, :changes, :gantt, :calendar, :preview, :context_menu] |
|
|
26 | 26 | before_filter :find_optional_project, :only => [:index, :changes, :gantt, :calendar] |
|
|
27 | 27 | accept_key_auth :index, :show, :changes |
|
|
28 | 28 | |
|
|
29 | 29 | rescue_from Query::StatementInvalid, :with => :query_statement_invalid |
|
|
30 | 30 | |
|
|
31 | 31 | helper :journals |
|
|
32 | 32 | helper :projects |
|
|
33 | 33 | include ProjectsHelper |
|
|
34 | 34 | helper :custom_fields |
|
|
35 | 35 | include CustomFieldsHelper |
|
|
36 | 36 | helper :issue_relations |
|
|
37 | 37 | include IssueRelationsHelper |
|
|
38 | 38 | helper :watchers |
|
|
39 | 39 | include WatchersHelper |
|
|
40 | 40 | helper :attachments |
|
|
41 | 41 | include AttachmentsHelper |
|
|
42 | 42 | helper :queries |
|
|
43 | 43 | include QueriesHelper |
|
|
44 | 44 | helper :sort |
|
|
45 | 45 | include SortHelper |
|
|
46 | 46 | include IssuesHelper |
|
|
47 | 47 | helper :timelog |
|
|
48 | 48 | include Redmine::Export::PDF |
|
|
49 | 49 | |
|
|
50 | 50 | verify :method => [:post, :delete], |
|
|
51 | 51 | :only => :destroy, |
|
|
52 | 52 | :render => { :nothing => true, :status => :method_not_allowed } |
|
|
53 | 53 | |
|
|
54 | 54 | def index |
|
|
55 | 55 | retrieve_query |
|
|
56 | 56 | sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria) |
|
|
57 | 57 | sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h})) |
|
|
58 | 58 | |
|
|
59 | 59 | if @query.valid? |
|
|
60 | 60 | limit = case params[:format] |
|
|
61 | 61 | when 'csv', 'pdf' |
|
|
62 | 62 | Setting.issues_export_limit.to_i |
|
|
63 | 63 | when 'atom' |
|
|
64 | 64 | Setting.feeds_limit.to_i |
|
|
65 | 65 | else |
|
|
66 | 66 | per_page_option |
|
|
67 | 67 | end |
|
|
68 | 68 | |
|
|
69 | 69 | @issue_count = @query.issue_count |
|
|
70 | 70 | @issue_pages = Paginator.new self, @issue_count, limit, params['page'] |
|
|
71 | 71 | @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version], |
|
|
72 | 72 | :order => sort_clause, |
|
|
73 | 73 | :offset => @issue_pages.current.offset, |
|
|
74 | 74 | :limit => limit) |
|
|
75 | 75 | @issue_count_by_group = @query.issue_count_by_group |
|
|
76 | 76 | |
|
|
77 | 77 | respond_to do |format| |
|
|
78 | 78 | format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? } |
|
|
79 | 79 | format.xml { render :layout => false } |
|
|
80 | 80 | format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") } |
|
|
81 | 81 | format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') } |
|
|
82 | 82 | format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') } |
|
|
83 | 83 | end |
|
|
84 | 84 | else |
|
|
85 | 85 | # Send html if the query is not valid |
|
|
86 | 86 | render(:template => 'issues/index.rhtml', :layout => !request.xhr?) |
|
|
87 | 87 | end |
|
|
88 | 88 | rescue ActiveRecord::RecordNotFound |
|
|
89 | 89 | render_404 |
|
|
90 | 90 | end |
|
|
91 | 91 | |
|
|
92 | 92 | def changes |
|
|
93 | 93 | retrieve_query |
|
|
94 | 94 | sort_init 'id', 'desc' |
|
|
95 | 95 | sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h})) |
|
|
96 | 96 | |
|
|
97 | 97 | if @query.valid? |
|
|
98 | 98 | @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC", |
|
|
99 | 99 | :limit => 25) |
|
|
100 | 100 | end |
|
|
101 | 101 | @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name) |
|
|
102 | 102 | render :layout => false, :content_type => 'application/atom+xml' |
|
|
103 | 103 | rescue ActiveRecord::RecordNotFound |
|
|
104 | 104 | render_404 |
|
|
105 | 105 | end |
|
|
106 | 106 | |
|
|
107 | 107 | def show |
|
|
108 | 108 | @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC") |
|
|
109 | 109 | @journals.each_with_index {|j,i| j.indice = i+1} |
|
|
110 | 110 | @journals.reverse! if User.current.wants_comments_in_reverse_order? |
|
|
111 | 111 | @changesets = @issue.changesets.visible.all |
|
|
112 | 112 | @changesets.reverse! if User.current.wants_comments_in_reverse_order? |
|
|
113 | 113 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
114 | 114 | @edit_allowed = User.current.allowed_to?(:edit_issues, @project) |
|
|
115 | 115 | @priorities = IssuePriority.all |
|
|
116 | 116 | @time_entry = TimeEntry.new |
|
|
117 | 117 | respond_to do |format| |
|
|
118 | 118 | format.html { render :template => 'issues/show.rhtml' } |
|
|
119 | 119 | format.xml { render :layout => false } |
|
|
120 | 120 | format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' } |
|
|
121 | 121 | format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") } |
|
|
122 | 122 | end |
|
|
123 | 123 | end |
|
|
124 | 124 | |
|
|
125 | 125 | # Add a new issue |
|
|
126 | 126 | # The new issue will be created from an existing one if copy_from parameter is given |
|
|
127 | 127 | def new |
|
|
128 | 128 | @issue = Issue.new |
|
|
129 | 129 | @issue.copy_from(params[:copy_from]) if params[:copy_from] |
|
|
130 | 130 | @issue.project = @project |
|
|
131 | 131 | # Tracker must be set before custom field values |
|
|
132 | 132 | @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first) |
|
|
133 | 133 | if @issue.tracker.nil? |
|
|
134 | 134 | render_error l(:error_no_tracker_in_project) |
|
|
135 | 135 | return |
|
|
136 | 136 | end |
|
|
137 | 137 | if params[:issue].is_a?(Hash) |
|
|
138 | 138 | @issue.safe_attributes = params[:issue] |
|
|
139 | 139 | @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project) |
|
|
140 | 140 | end |
|
|
141 | 141 | @issue.author = User.current |
|
|
142 | 142 | |
|
|
143 | 143 | default_status = IssueStatus.default |
|
|
144 | 144 | unless default_status |
|
|
145 | 145 | render_error l(:error_no_default_issue_status) |
|
|
146 | 146 | return |
|
|
147 | 147 | end |
|
|
148 | 148 | @issue.status = default_status |
|
|
149 | 149 | @allowed_statuses = ([default_status] + default_status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq |
|
|
150 | 150 | |
|
|
151 | 151 | if request.get? || request.xhr? |
|
|
152 | 152 | @issue.start_date ||= Date.today |
|
|
153 | 153 | else |
|
|
154 | 154 | requested_status = IssueStatus.find_by_id(params[:issue][:status_id]) |
|
|
155 | 155 | # Check that the user is allowed to apply the requested status |
|
|
156 | 156 | @issue.status = (@allowed_statuses.include? requested_status) ? requested_status : default_status |
|
|
157 | 157 | call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue }) |
|
|
158 | 158 | if @issue.save |
|
|
159 | 159 | attach_files(@issue, params[:attachments]) |
|
|
160 | 160 | flash[:notice] = l(:notice_successful_create) |
|
|
161 | 161 | call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue}) |
|
|
162 | 162 | respond_to do |format| |
|
|
163 | 163 | format.html { |
|
|
164 | 164 | redirect_to(params[:continue] ? { :action => 'new', :tracker_id => @issue.tracker } : |
|
|
165 | 165 | { :action => 'show', :id => @issue }) |
|
|
166 | 166 | } |
|
|
167 | 167 | format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) } |
|
|
168 | 168 | end |
|
|
169 | 169 | return |
|
|
170 | 170 | else |
|
|
171 | 171 | respond_to do |format| |
|
|
172 | 172 | format.html { } |
|
|
173 | 173 | format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return } |
|
|
174 | 174 | end |
|
|
175 | 175 | end |
|
|
176 | 176 | end |
|
|
177 | 177 | @priorities = IssuePriority.all |
|
|
178 | 178 | render :layout => !request.xhr? |
|
|
179 | 179 | end |
|
|
180 | 180 | |
|
|
181 | 181 | # Attributes that can be updated on workflow transition (without :edit permission) |
|
|
182 | 182 | # TODO: make it configurable (at least per role) |
|
|
183 | 183 | UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION) |
|
|
184 | 184 | |
|
|
185 | 185 | def edit |
|
|
186 | 186 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
187 | 187 | @priorities = IssuePriority.all |
|
|
188 | 188 | @edit_allowed = User.current.allowed_to?(:edit_issues, @project) |
|
|
189 | 189 | @time_entry = TimeEntry.new |
|
|
190 | 190 | |
|
|
191 | 191 | @notes = params[:notes] |
|
|
192 | 192 | journal = @issue.init_journal(User.current, @notes) |
|
|
193 | 193 | # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed |
|
|
194 | 194 | if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue] |
|
|
195 | 195 | attrs = params[:issue].dup |
|
|
196 | 196 | attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed |
|
|
197 | 197 | attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s} |
|
|
198 | 198 | @issue.safe_attributes = attrs |
|
|
199 | 199 | end |
|
|
200 | 200 | |
|
|
201 | 201 | if request.get? |
|
|
202 | 202 | # nop |
|
|
203 | 203 | else |
|
|
204 | 204 | @time_entry = TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today) |
|
|
205 | 205 | @time_entry.attributes = params[:time_entry] |
|
|
206 | 206 | if (@time_entry.hours.nil? || @time_entry.valid?) && @issue.valid? |
|
|
207 | 207 | attachments = attach_files(@issue, params[:attachments]) |
|
|
208 | 208 | attachments.each {|a| journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)} |
|
|
209 | 209 | call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal}) |
|
|
210 | 210 | if @issue.save |
|
|
211 | 211 | # Log spend time |
|
|
212 | 212 | if User.current.allowed_to?(:log_time, @project) |
|
|
213 | 213 | @time_entry.save |
|
|
214 | 214 | end |
|
|
215 | 215 | if !journal.new_record? |
|
|
216 | 216 | # Only send notification if something was actually changed |
|
|
217 | 217 | flash[:notice] = l(:notice_successful_update) |
|
|
218 | 218 | end |
|
|
219 | 219 | call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal}) |
|
|
220 | 220 | respond_to do |format| |
|
|
221 | 221 | format.html { redirect_back_or_default({:action => 'show', :id => @issue}) } |
|
|
222 | 222 | format.xml { head :ok } |
|
|
223 | 223 | end |
|
|
224 | 224 | return |
|
|
225 | 225 | end |
|
|
226 | 226 | end |
|
|
227 | 227 | # failure |
|
|
228 | 228 | respond_to do |format| |
|
|
229 | 229 | format.html { } |
|
|
230 | 230 | format.xml { render :xml => @issue.errors, :status => :unprocessable_entity } |
|
|
231 | 231 | end |
|
|
232 | 232 | end |
|
|
233 | 233 | rescue ActiveRecord::StaleObjectError |
|
|
234 | 234 | # Optimistic locking exception |
|
|
235 | 235 | flash.now[:error] = l(:notice_locking_conflict) |
|
|
236 | 236 | # Remove the previously added attachments if issue was not updated |
|
|
237 | 237 | attachments.each(&:destroy) |
|
|
238 | 238 | end |
|
|
239 | 239 | |
|
|
240 | 240 | def reply |
|
|
241 | 241 | journal = Journal.find(params[:journal_id]) if params[:journal_id] |
|
|
242 | 242 | if journal |
|
|
243 | 243 | user = journal.user |
|
|
244 | 244 | text = journal.notes |
|
|
245 | 245 | else |
|
|
246 | 246 | user = @issue.author |
|
|
247 | 247 | text = @issue.description |
|
|
248 | 248 | end |
|
|
249 | 249 | content = "#{ll(Setting.default_language, :text_user_wrote, user)}\\n> " |
|
|
250 | 250 | content << text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]').gsub('"', '\"').gsub(/(\r?\n|\r\n?)/, "\\n> ") + "\\n\\n" |
|
|
251 | 251 | render(:update) { |page| |
|
|
252 | 252 | page.<< "$('notes').value = \"#{content}\";" |
|
|
253 | 253 | page.show 'update' |
|
|
254 | 254 | page << "Form.Element.focus('notes');" |
|
|
255 | 255 | page << "Element.scrollTo('update');" |
|
|
256 | 256 | page << "$('notes').scrollTop = $('notes').scrollHeight - $('notes').clientHeight;" |
|
|
257 | 257 | } |
|
|
258 | 258 | end |
|
|
259 | 259 | |
|
|
260 | 260 | # Bulk edit a set of issues |
|
|
261 | 261 | def bulk_edit |
|
|
262 | 262 | if request.post? |
|
|
263 | tracker = params[:tracker_id].blank? ? nil : @project.trackers.find_by_id(params[:tracker_id]) | |
|
|
264 | status = params[:status_id].blank? ? nil : IssueStatus.find_by_id(params[:status_id]) | |
|
|
265 | priority = params[:priority_id].blank? ? nil : IssuePriority.find_by_id(params[:priority_id]) | |
|
|
266 | assigned_to = (params[:assigned_to_id].blank? || params[:assigned_to_id] == 'none') ? nil : User.find_by_id(params[:assigned_to_id]) | |
|
|
267 | category = (params[:category_id].blank? || params[:category_id] == 'none') ? nil : @project.issue_categories.find_by_id(params[:category_id]) | |
|
|
268 | fixed_version = (params[:fixed_version_id].blank? || params[:fixed_version_id] == 'none') ? nil : @project.shared_versions.find_by_id(params[:fixed_version_id]) | |
|
|
269 | custom_field_values = params[:custom_field_values] ? params[:custom_field_values].reject {|k,v| v.blank?} : nil | |
|
|
270 | ||
|
|
271 | # Need to merge in the records found above for Issue#bulk_edit. | |
|
|
272 | # Assuming this is done so the associations are only looked up once. | |
|
|
273 | merged_params = params.merge({ | |
|
|
274 | :tracker => tracker, | |
|
|
275 | :status => status, | |
|
|
276 | :priority => priority, | |
|
|
277 | :assigned_to => assigned_to, | |
|
|
278 | :category => category, | |
|
|
279 | :fixed_version => fixed_version, | |
|
|
280 | :custom_field_values => custom_field_values | |
|
|
281 | }) | |
|
|
263 | attributes = (params[:issue] || {}).reject {|k,v| v.blank?} | |
|
|
264 | attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'} | |
|
|
265 | attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values] | |
|
|
282 | 266 | |
|
|
283 | 267 |
unsaved_issue_ids = [] |
|
|
284 | 268 | @issues.each do |issue| |
|
|
285 | unless issue.bulk_edit(merged_params) | |
|
|
269 | journal = issue.init_journal(User.current, params[:notes]) | |
|
|
270 | issue.safe_attributes = attributes | |
|
|
271 | call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue }) | |
|
|
272 | unless issue.save | |
|
|
286 | 273 | # Keep unsaved issue ids to display them in flash error |
|
|
287 | 274 | unsaved_issue_ids << issue.id |
|
|
288 | 275 | end |
|
|
289 | 276 | end |
|
|
290 | 277 | if unsaved_issue_ids.empty? |
|
|
291 | 278 | flash[:notice] = l(:notice_successful_update) unless @issues.empty? |
|
|
292 | 279 | else |
|
|
293 | 280 | flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size, |
|
|
294 | 281 | :total => @issues.size, |
|
|
295 | 282 | :ids => '#' + unsaved_issue_ids.join(', #')) |
|
|
296 | 283 | end |
|
|
297 | 284 | redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project}) |
|
|
298 | 285 | return |
|
|
299 | 286 | end |
|
|
300 | 287 | @available_statuses = Workflow.available_statuses(@project) |
|
|
301 | 288 | @custom_fields = @project.all_issue_custom_fields |
|
|
302 | 289 | end |
|
|
303 | 290 | |
|
|
304 | 291 | def move |
|
|
305 | 292 | @copy = params[:copy_options] && params[:copy_options][:copy] |
|
|
306 | 293 | @allowed_projects = [] |
|
|
307 | 294 | # find projects to which the user is allowed to move the issue |
|
|
308 | 295 | if User.current.admin? |
|
|
309 | 296 | # admin is allowed to move issues to any active (visible) project |
|
|
310 | 297 | @allowed_projects = Project.find(:all, :conditions => Project.visible_by(User.current)) |
|
|
311 | 298 | else |
|
|
312 | 299 | User.current.memberships.each {|m| @allowed_projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}} |
|
|
313 | 300 | end |
|
|
314 | 301 | @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:new_project_id]} if params[:new_project_id] |
|
|
315 | 302 | @target_project ||= @project |
|
|
316 | 303 | @trackers = @target_project.trackers |
|
|
317 | 304 | @available_statuses = Workflow.available_statuses(@project) |
|
|
318 | 305 | if request.post? |
|
|
319 | 306 | new_tracker = params[:new_tracker_id].blank? ? nil : @target_project.trackers.find_by_id(params[:new_tracker_id]) |
|
|
320 | 307 | unsaved_issue_ids = [] |
|
|
321 | 308 | moved_issues = [] |
|
|
322 | 309 | @issues.each do |issue| |
|
|
323 | 310 | changed_attributes = {} |
|
|
324 | 311 | [:assigned_to_id, :status_id, :start_date, :due_date].each do |valid_attribute| |
|
|
325 | 312 | unless params[valid_attribute].blank? |
|
|
326 | 313 | changed_attributes[valid_attribute] = (params[valid_attribute] == 'none' ? nil : params[valid_attribute]) |
|
|
327 | 314 | end |
|
|
328 | 315 | end |
|
|
329 | 316 | issue.init_journal(User.current) |
|
|
330 | 317 | call_hook(:controller_issues_move_before_save, { :params => params, :issue => issue, :target_project => @target_project, :copy => !!@copy }) |
|
|
331 | 318 | if r = issue.move_to(@target_project, new_tracker, {:copy => @copy, :attributes => changed_attributes}) |
|
|
332 | 319 | moved_issues << r |
|
|
333 | 320 | else |
|
|
334 | 321 | unsaved_issue_ids << issue.id |
|
|
335 | 322 | end |
|
|
336 | 323 | end |
|
|
337 | 324 | if unsaved_issue_ids.empty? |
|
|
338 | 325 | flash[:notice] = l(:notice_successful_update) unless @issues.empty? |
|
|
339 | 326 | else |
|
|
340 | 327 | flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size, |
|
|
341 | 328 | :total => @issues.size, |
|
|
342 | 329 | :ids => '#' + unsaved_issue_ids.join(', #')) |
|
|
343 | 330 | end |
|
|
344 | 331 | if params[:follow] |
|
|
345 | 332 | if @issues.size == 1 && moved_issues.size == 1 |
|
|
346 | 333 | redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first |
|
|
347 | 334 | else |
|
|
348 | 335 | redirect_to :controller => 'issues', :action => 'index', :project_id => (@target_project || @project) |
|
|
349 | 336 | end |
|
|
350 | 337 | else |
|
|
351 | 338 | redirect_to :controller => 'issues', :action => 'index', :project_id => @project |
|
|
352 | 339 | end |
|
|
353 | 340 | return |
|
|
354 | 341 | end |
|
|
355 | 342 | render :layout => false if request.xhr? |
|
|
356 | 343 | end |
|
|
357 | 344 | |
|
|
358 | 345 | def destroy |
|
|
359 | 346 | @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f |
|
|
360 | 347 | if @hours > 0 |
|
|
361 | 348 | case params[:todo] |
|
|
362 | 349 | when 'destroy' |
|
|
363 | 350 | # nothing to do |
|
|
364 | 351 | when 'nullify' |
|
|
365 | 352 | TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues]) |
|
|
366 | 353 | when 'reassign' |
|
|
367 | 354 | reassign_to = @project.issues.find_by_id(params[:reassign_to_id]) |
|
|
368 | 355 | if reassign_to.nil? |
|
|
369 | 356 | flash.now[:error] = l(:error_issue_not_found_in_project) |
|
|
370 | 357 | return |
|
|
371 | 358 | else |
|
|
372 | 359 | TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues]) |
|
|
373 | 360 | end |
|
|
374 | 361 | else |
|
|
375 | 362 | unless params[:format] == 'xml' |
|
|
376 | 363 | # display the destroy form if it's a user request |
|
|
377 | 364 | return |
|
|
378 | 365 | end |
|
|
379 | 366 | end |
|
|
380 | 367 | end |
|
|
381 | 368 | @issues.each(&:destroy) |
|
|
382 | 369 | respond_to do |format| |
|
|
383 | 370 | format.html { redirect_to :action => 'index', :project_id => @project } |
|
|
384 | 371 | format.xml { head :ok } |
|
|
385 | 372 | end |
|
|
386 | 373 | end |
|
|
387 | 374 | |
|
|
388 | 375 | def gantt |
|
|
389 | 376 | @gantt = Redmine::Helpers::Gantt.new(params) |
|
|
390 | 377 | retrieve_query |
|
|
391 | 378 | @query.group_by = nil |
|
|
392 | 379 | if @query.valid? |
|
|
393 | 380 | events = [] |
|
|
394 | 381 | # Issues that have start and due dates |
|
|
395 | 382 | events += @query.issues(:include => [:tracker, :assigned_to, :priority], |
|
|
396 | 383 | :order => "start_date, due_date", |
|
|
397 | 384 | :conditions => ["(((start_date>=? and start_date<=?) or (due_date>=? and due_date<=?) or (start_date<? and due_date>?)) and start_date is not null and due_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to] |
|
|
398 | 385 | ) |
|
|
399 | 386 | # Issues that don't have a due date but that are assigned to a version with a date |
|
|
400 | 387 | events += @query.issues(:include => [:tracker, :assigned_to, :priority, :fixed_version], |
|
|
401 | 388 | :order => "start_date, effective_date", |
|
|
402 | 389 | :conditions => ["(((start_date>=? and start_date<=?) or (effective_date>=? and effective_date<=?) or (start_date<? and effective_date>?)) and start_date is not null and due_date is null and effective_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to] |
|
|
403 | 390 | ) |
|
|
404 | 391 | # Versions |
|
|
405 | 392 | events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @gantt.date_from, @gantt.date_to]) |
|
|
406 | 393 | |
|
|
407 | 394 | @gantt.events = events |
|
|
408 | 395 | end |
|
|
409 | 396 | |
|
|
410 | 397 | basename = (@project ? "#{@project.identifier}-" : '') + 'gantt' |
|
|
411 | 398 | |
|
|
412 | 399 | respond_to do |format| |
|
|
413 | 400 | format.html { render :template => "issues/gantt.rhtml", :layout => !request.xhr? } |
|
|
414 | 401 | format.png { send_data(@gantt.to_image, :disposition => 'inline', :type => 'image/png', :filename => "#{basename}.png") } if @gantt.respond_to?('to_image') |
|
|
415 | 402 | format.pdf { send_data(gantt_to_pdf(@gantt, @project), :type => 'application/pdf', :filename => "#{basename}.pdf") } |
|
|
416 | 403 | end |
|
|
417 | 404 | end |
|
|
418 | 405 | |
|
|
419 | 406 | def calendar |
|
|
420 | 407 | if params[:year] and params[:year].to_i > 1900 |
|
|
421 | 408 | @year = params[:year].to_i |
|
|
422 | 409 | if params[:month] and params[:month].to_i > 0 and params[:month].to_i < 13 |
|
|
423 | 410 | @month = params[:month].to_i |
|
|
424 | 411 | end |
|
|
425 | 412 | end |
|
|
426 | 413 | @year ||= Date.today.year |
|
|
427 | 414 | @month ||= Date.today.month |
|
|
428 | 415 | |
|
|
429 | 416 | @calendar = Redmine::Helpers::Calendar.new(Date.civil(@year, @month, 1), current_language, :month) |
|
|
430 | 417 | retrieve_query |
|
|
431 | 418 | @query.group_by = nil |
|
|
432 | 419 | if @query.valid? |
|
|
433 | 420 | events = [] |
|
|
434 | 421 | events += @query.issues(:include => [:tracker, :assigned_to, :priority], |
|
|
435 | 422 | :conditions => ["((start_date BETWEEN ? AND ?) OR (due_date BETWEEN ? AND ?))", @calendar.startdt, @calendar.enddt, @calendar.startdt, @calendar.enddt] |
|
|
436 | 423 | ) |
|
|
437 | 424 | events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @calendar.startdt, @calendar.enddt]) |
|
|
438 | 425 | |
|
|
439 | 426 | @calendar.events = events |
|
|
440 | 427 | end |
|
|
441 | 428 | |
|
|
442 | 429 | render :layout => false if request.xhr? |
|
|
443 | 430 | end |
|
|
444 | 431 | |
|
|
445 | 432 | def context_menu |
|
|
446 | 433 | @issues = Issue.find_all_by_id(params[:ids], :include => :project) |
|
|
447 | 434 | if (@issues.size == 1) |
|
|
448 | 435 | @issue = @issues.first |
|
|
449 | 436 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
450 | 437 | end |
|
|
451 | 438 | projects = @issues.collect(&:project).compact.uniq |
|
|
452 | 439 | @project = projects.first if projects.size == 1 |
|
|
453 | 440 | |
|
|
454 | 441 | @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)), |
|
|
455 | 442 | :log_time => (@project && User.current.allowed_to?(:log_time, @project)), |
|
|
456 | 443 | :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))), |
|
|
457 | 444 | :move => (@project && User.current.allowed_to?(:move_issues, @project)), |
|
|
458 | 445 | :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)), |
|
|
459 | 446 | :delete => (@project && User.current.allowed_to?(:delete_issues, @project)) |
|
|
460 | 447 | } |
|
|
461 | 448 | if @project |
|
|
462 | 449 | @assignables = @project.assignable_users |
|
|
463 | 450 | @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to) |
|
|
464 | 451 | @trackers = @project.trackers |
|
|
465 | 452 | end |
|
|
466 | 453 | |
|
|
467 | 454 | @priorities = IssuePriority.all.reverse |
|
|
468 | 455 | @statuses = IssueStatus.find(:all, :order => 'position') |
|
|
469 | 456 | @back = params[:back_url] || request.env['HTTP_REFERER'] |
|
|
470 | 457 | |
|
|
471 | 458 | render :layout => false |
|
|
472 | 459 | end |
|
|
473 | 460 | |
|
|
474 | 461 | def update_form |
|
|
475 | 462 | if params[:id].blank? |
|
|
476 | 463 | @issue = Issue.new |
|
|
477 | 464 | @issue.project = @project |
|
|
478 | 465 | else |
|
|
479 | 466 | @issue = @project.issues.visible.find(params[:id]) |
|
|
480 | 467 | end |
|
|
481 | 468 | @issue.attributes = params[:issue] |
|
|
482 | 469 | @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq |
|
|
483 | 470 | @priorities = IssuePriority.all |
|
|
484 | 471 | |
|
|
485 | 472 | render :partial => 'attributes' |
|
|
486 | 473 | end |
|
|
487 | 474 | |
|
|
488 | 475 | def preview |
|
|
489 | 476 | @issue = @project.issues.find_by_id(params[:id]) unless params[:id].blank? |
|
|
490 | 477 | @attachements = @issue.attachments if @issue |
|
|
491 | 478 | @text = params[:notes] || (params[:issue] ? params[:issue][:description] : nil) |
|
|
492 | 479 | render :partial => 'common/preview' |
|
|
493 | 480 | end |
|
|
494 | 481 | |
|
|
495 | 482 | private |
|
|
496 | 483 | def find_issue |
|
|
497 | 484 | @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category]) |
|
|
498 | 485 | @project = @issue.project |
|
|
499 | 486 | rescue ActiveRecord::RecordNotFound |
|
|
500 | 487 | render_404 |
|
|
501 | 488 | end |
|
|
502 | 489 | |
|
|
503 | 490 | # Filter for bulk operations |
|
|
504 | 491 | def find_issues |
|
|
505 | 492 | @issues = Issue.find_all_by_id(params[:id] || params[:ids]) |
|
|
506 | 493 | raise ActiveRecord::RecordNotFound if @issues.empty? |
|
|
507 | 494 | projects = @issues.collect(&:project).compact.uniq |
|
|
508 | 495 | if projects.size == 1 |
|
|
509 | 496 | @project = projects.first |
|
|
510 | 497 | else |
|
|
511 | 498 | # TODO: let users bulk edit/move/destroy issues from different projects |
|
|
512 | 499 | render_error 'Can not bulk edit/move/destroy issues from different projects' |
|
|
513 | 500 | return false |
|
|
514 | 501 | end |
|
|
515 | 502 | rescue ActiveRecord::RecordNotFound |
|
|
516 | 503 | render_404 |
|
|
517 | 504 | end |
|
|
518 | 505 | |
|
|
519 | 506 | def find_project |
|
|
520 | 507 | project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id] |
|
|
521 | 508 | @project = Project.find(project_id) |
|
|
522 | 509 | rescue ActiveRecord::RecordNotFound |
|
|
523 | 510 | render_404 |
|
|
524 | 511 | end |
|
|
525 | 512 | |
|
|
526 | 513 | def find_optional_project |
|
|
527 | 514 | @project = Project.find(params[:project_id]) unless params[:project_id].blank? |
|
|
528 | 515 | allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true) |
|
|
529 | 516 | allowed ? true : deny_access |
|
|
530 | 517 | rescue ActiveRecord::RecordNotFound |
|
|
531 | 518 | render_404 |
|
|
532 | 519 | end |
|
|
533 | 520 | |
|
|
534 | 521 | # Retrieve query from session or build a new query |
|
|
535 | 522 | def retrieve_query |
|
|
536 | 523 | if !params[:query_id].blank? |
|
|
537 | 524 | cond = "project_id IS NULL" |
|
|
538 | 525 | cond << " OR project_id = #{@project.id}" if @project |
|
|
539 | 526 | @query = Query.find(params[:query_id], :conditions => cond) |
|
|
540 | 527 | @query.project = @project |
|
|
541 | 528 | session[:query] = {:id => @query.id, :project_id => @query.project_id} |
|
|
542 | 529 | sort_clear |
|
|
543 | 530 | else |
|
|
544 | 531 | if api_request? || params[:set_filter] || session[:query].nil? || session[:query][:project_id] != (@project ? @project.id : nil) |
|
|
545 | 532 | # Give it a name, required to be valid |
|
|
546 | 533 | @query = Query.new(:name => "_") |
|
|
547 | 534 | @query.project = @project |
|
|
548 | 535 | if params[:fields] and params[:fields].is_a? Array |
|
|
549 | 536 | params[:fields].each do |field| |
|
|
550 | 537 | @query.add_filter(field, params[:operators][field], params[:values][field]) |
|
|
551 | 538 | end |
|
|
552 | 539 | else |
|
|
553 | 540 | @query.available_filters.keys.each do |field| |
|
|
554 | 541 | @query.add_short_filter(field, params[field]) if params[field] |
|
|
555 | 542 | end |
|
|
556 | 543 | end |
|
|
557 | 544 | @query.group_by = params[:group_by] |
|
|
558 | 545 | @query.column_names = params[:query] && params[:query][:column_names] |
|
|
559 | 546 | session[:query] = {:project_id => @query.project_id, :filters => @query.filters, :group_by => @query.group_by, :column_names => @query.column_names} |
|
|
560 | 547 | else |
|
|
561 | 548 | @query = Query.find_by_id(session[:query][:id]) if session[:query][:id] |
|
|
562 | 549 | @query ||= Query.new(:name => "_", :project => @project, :filters => session[:query][:filters], :group_by => session[:query][:group_by], :column_names => session[:query][:column_names]) |
|
|
563 | 550 | @query.project = @project |
|
|
564 | 551 | end |
|
|
565 | 552 | end |
|
|
566 | 553 | end |
|
|
567 | 554 | |
|
|
568 | 555 | # Rescues an invalid query statement. Just in case... |
|
|
569 | 556 | def query_statement_invalid(exception) |
|
|
570 | 557 | logger.error "Query::StatementInvalid: #{exception.message}" if logger |
|
|
571 | 558 | session.delete(:query) |
|
|
572 | 559 | sort_clear |
|
|
573 | 560 | render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator." |
|
|
574 | 561 | end |
|
|
575 | 562 | end |
| @@ -1,113 +1,113 | |||
|
|
1 | 1 | # redMine - project management software |
|
|
2 | 2 | # Copyright (C) 2006 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | module CustomFieldsHelper |
|
|
19 | 19 | |
|
|
20 | 20 | def custom_fields_tabs |
|
|
21 | 21 | tabs = [{:name => 'IssueCustomField', :partial => 'custom_fields/index', :label => :label_issue_plural}, |
|
|
22 | 22 | {:name => 'TimeEntryCustomField', :partial => 'custom_fields/index', :label => :label_spent_time}, |
|
|
23 | 23 | {:name => 'ProjectCustomField', :partial => 'custom_fields/index', :label => :label_project_plural}, |
|
|
24 | 24 | {:name => 'VersionCustomField', :partial => 'custom_fields/index', :label => :label_version_plural}, |
|
|
25 | 25 | {:name => 'UserCustomField', :partial => 'custom_fields/index', :label => :label_user_plural}, |
|
|
26 | 26 | {:name => 'GroupCustomField', :partial => 'custom_fields/index', :label => :label_group_plural}, |
|
|
27 | 27 | {:name => 'TimeEntryActivityCustomField', :partial => 'custom_fields/index', :label => TimeEntryActivity::OptionName}, |
|
|
28 | 28 | {:name => 'IssuePriorityCustomField', :partial => 'custom_fields/index', :label => IssuePriority::OptionName}, |
|
|
29 | 29 | {:name => 'DocumentCategoryCustomField', :partial => 'custom_fields/index', :label => DocumentCategory::OptionName} |
|
|
30 | 30 | ] |
|
|
31 | 31 | end |
|
|
32 | 32 | |
|
|
33 | 33 | # Return custom field html tag corresponding to its format |
|
|
34 | 34 | def custom_field_tag(name, custom_value) |
|
|
35 | 35 | custom_field = custom_value.custom_field |
|
|
36 | 36 | field_name = "#{name}[custom_field_values][#{custom_field.id}]" |
|
|
37 | 37 | field_id = "#{name}_custom_field_values_#{custom_field.id}" |
|
|
38 | 38 | |
|
|
39 | 39 | case custom_field.field_format |
|
|
40 | 40 | when "date" |
|
|
41 | 41 | text_field_tag(field_name, custom_value.value, :id => field_id, :size => 10) + |
|
|
42 | 42 | calendar_for(field_id) |
|
|
43 | 43 | when "text" |
|
|
44 | 44 | text_area_tag(field_name, custom_value.value, :id => field_id, :rows => 3, :style => 'width:90%') |
|
|
45 | 45 | when "bool" |
|
|
46 | 46 | hidden_field_tag(field_name, '0') + check_box_tag(field_name, '1', custom_value.true?, :id => field_id) |
|
|
47 | 47 | when "list" |
|
|
48 | 48 | blank_option = custom_field.is_required? ? |
|
|
49 | 49 | (custom_field.default_value.blank? ? "<option value=\"\">--- #{l(:actionview_instancetag_blank_option)} ---</option>" : '') : |
|
|
50 | 50 | '<option></option>' |
|
|
51 | 51 | select_tag(field_name, blank_option + options_for_select(custom_field.possible_values, custom_value.value), :id => field_id) |
|
|
52 | 52 | else |
|
|
53 | 53 | text_field_tag(field_name, custom_value.value, :id => field_id) |
|
|
54 | 54 | end |
|
|
55 | 55 | end |
|
|
56 | 56 | |
|
|
57 | 57 | # Return custom field label tag |
|
|
58 | 58 | def custom_field_label_tag(name, custom_value) |
|
|
59 | 59 | content_tag "label", custom_value.custom_field.name + |
|
|
60 | 60 | (custom_value.custom_field.is_required? ? " <span class=\"required\">*</span>" : ""), |
|
|
61 | 61 | :for => "#{name}_custom_field_values_#{custom_value.custom_field.id}", |
|
|
62 | 62 | :class => (custom_value.errors.empty? ? nil : "error" ) |
|
|
63 | 63 | end |
|
|
64 | 64 | |
|
|
65 | 65 | # Return custom field tag with its label tag |
|
|
66 | 66 | def custom_field_tag_with_label(name, custom_value) |
|
|
67 | 67 | custom_field_label_tag(name, custom_value) + custom_field_tag(name, custom_value) |
|
|
68 | 68 | end |
|
|
69 | 69 | |
|
|
70 | def custom_field_tag_for_bulk_edit(custom_field) | |
|
|
71 | field_name = "custom_field_values[#{custom_field.id}]" | |
|
|
72 | field_id = "custom_field_values_#{custom_field.id}" | |
|
|
70 | def custom_field_tag_for_bulk_edit(name, custom_field) | |
|
|
71 | field_name = "#{name}[custom_field_values][#{custom_field.id}]" | |
|
|
72 | field_id = "#{name}_custom_field_values_#{custom_field.id}" | |
|
|
73 | 73 | case custom_field.field_format |
|
|
74 | 74 | when "date" |
|
|
75 | 75 | text_field_tag(field_name, '', :id => field_id, :size => 10) + |
|
|
76 | 76 | calendar_for(field_id) |
|
|
77 | 77 | when "text" |
|
|
78 | 78 | text_area_tag(field_name, '', :id => field_id, :rows => 3, :style => 'width:90%') |
|
|
79 | 79 | when "bool" |
|
|
80 | 80 | select_tag(field_name, options_for_select([[l(:label_no_change_option), ''], |
|
|
81 | 81 | [l(:general_text_yes), '1'], |
|
|
82 | 82 | [l(:general_text_no), '0']]), :id => field_id) |
|
|
83 | 83 | when "list" |
|
|
84 | 84 | select_tag(field_name, options_for_select([[l(:label_no_change_option), '']] + custom_field.possible_values), :id => field_id) |
|
|
85 | 85 | else |
|
|
86 | 86 | text_field_tag(field_name, '', :id => field_id) |
|
|
87 | 87 | end |
|
|
88 | 88 | end |
|
|
89 | 89 | |
|
|
90 | 90 | # Return a string used to display a custom value |
|
|
91 | 91 | def show_value(custom_value) |
|
|
92 | 92 | return "" unless custom_value |
|
|
93 | 93 | format_value(custom_value.value, custom_value.custom_field.field_format) |
|
|
94 | 94 | end |
|
|
95 | 95 | |
|
|
96 | 96 | # Return a string used to display a custom value |
|
|
97 | 97 | def format_value(value, field_format) |
|
|
98 | 98 | return "" unless value && !value.empty? |
|
|
99 | 99 | case field_format |
|
|
100 | 100 | when "date" |
|
|
101 | 101 | begin; format_date(value.to_date); rescue; value end |
|
|
102 | 102 | when "bool" |
|
|
103 | 103 | l(value == "1" ? :general_text_Yes : :general_text_No) |
|
|
104 | 104 | else |
|
|
105 | 105 | value |
|
|
106 | 106 | end |
|
|
107 | 107 | end |
|
|
108 | 108 | |
|
|
109 | 109 | # Return an array of custom field formats which can be used in select_tag |
|
|
110 | 110 | def custom_field_formats_for_select |
|
|
111 | 111 | CustomField::FIELD_FORMATS.sort {|a,b| a[1][:order]<=>b[1][:order]}.collect { |k| [ l(k[1][:name]), k[0] ] } |
|
|
112 | 112 | end |
|
|
113 | 113 | end |
| @@ -1,569 +1,557 | |||
|
|
1 | 1 | # redMine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2007 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | class Issue < ActiveRecord::Base |
|
|
19 | 19 | belongs_to :project |
|
|
20 | 20 | belongs_to :tracker |
|
|
21 | 21 | belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id' |
|
|
22 | 22 | belongs_to :author, :class_name => 'User', :foreign_key => 'author_id' |
|
|
23 | 23 | belongs_to :assigned_to, :class_name => 'User', :foreign_key => 'assigned_to_id' |
|
|
24 | 24 | belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id' |
|
|
25 | 25 | belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id' |
|
|
26 | 26 | belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id' |
|
|
27 | 27 | |
|
|
28 | 28 | has_many :journals, :as => :journalized, :dependent => :destroy |
|
|
29 | 29 | has_many :time_entries, :dependent => :delete_all |
|
|
30 | 30 | has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC" |
|
|
31 | 31 | |
|
|
32 | 32 | has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all |
|
|
33 | 33 | has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all |
|
|
34 | 34 | |
|
|
35 | 35 | acts_as_attachable :after_remove => :attachment_removed |
|
|
36 | 36 | acts_as_customizable |
|
|
37 | 37 | acts_as_watchable |
|
|
38 | 38 | acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"], |
|
|
39 | 39 | :include => [:project, :journals], |
|
|
40 | 40 | # sort by id so that limited eager loading doesn't break with postgresql |
|
|
41 | 41 | :order_column => "#{table_name}.id" |
|
|
42 | 42 | acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"}, |
|
|
43 | 43 | :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}}, |
|
|
44 | 44 | :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') } |
|
|
45 | 45 | |
|
|
46 | 46 | acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]}, |
|
|
47 | 47 | :author_key => :author_id |
|
|
48 | 48 | |
|
|
49 | 49 | DONE_RATIO_OPTIONS = %w(issue_field issue_status) |
|
|
50 | 50 | |
|
|
51 | 51 | validates_presence_of :subject, :priority, :project, :tracker, :author, :status |
|
|
52 | 52 | validates_length_of :subject, :maximum => 255 |
|
|
53 | 53 | validates_inclusion_of :done_ratio, :in => 0..100 |
|
|
54 | 54 | validates_numericality_of :estimated_hours, :allow_nil => true |
|
|
55 | 55 | |
|
|
56 | 56 | named_scope :visible, lambda {|*args| { :include => :project, |
|
|
57 | 57 | :conditions => Project.allowed_to_condition(args.first || User.current, :view_issues) } } |
|
|
58 | 58 | |
|
|
59 | 59 | named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status |
|
|
60 | 60 | |
|
|
61 | 61 | before_save :update_done_ratio_from_issue_status |
|
|
62 | 62 | after_save :create_journal |
|
|
63 | 63 | |
|
|
64 | 64 | # Returns true if usr or current user is allowed to view the issue |
|
|
65 | 65 | def visible?(usr=nil) |
|
|
66 | 66 | (usr || User.current).allowed_to?(:view_issues, self.project) |
|
|
67 | 67 | end |
|
|
68 | 68 | |
|
|
69 | 69 | def after_initialize |
|
|
70 | 70 | if new_record? |
|
|
71 | 71 | # set default values for new records only |
|
|
72 | 72 | self.status ||= IssueStatus.default |
|
|
73 | 73 | self.priority ||= IssuePriority.default |
|
|
74 | 74 | end |
|
|
75 | 75 | end |
|
|
76 | 76 | |
|
|
77 | 77 | # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields |
|
|
78 | 78 | def available_custom_fields |
|
|
79 | 79 | (project && tracker) ? project.all_issue_custom_fields.select {|c| tracker.custom_fields.include? c } : [] |
|
|
80 | 80 | end |
|
|
81 | 81 | |
|
|
82 | 82 | def copy_from(arg) |
|
|
83 | 83 | issue = arg.is_a?(Issue) ? arg : Issue.find(arg) |
|
|
84 | 84 | self.attributes = issue.attributes.dup.except("id", "created_on", "updated_on") |
|
|
85 | 85 | self.custom_values = issue.custom_values.collect {|v| v.clone} |
|
|
86 | 86 | self.status = issue.status |
|
|
87 | 87 | self |
|
|
88 | 88 | end |
|
|
89 | 89 | |
|
|
90 | 90 | # Moves/copies an issue to a new project and tracker |
|
|
91 | 91 | # Returns the moved/copied issue on success, false on failure |
|
|
92 | 92 | def move_to(new_project, new_tracker = nil, options = {}) |
|
|
93 | 93 | options ||= {} |
|
|
94 | 94 | issue = options[:copy] ? self.clone : self |
|
|
95 | 95 | transaction do |
|
|
96 | 96 | if new_project && issue.project_id != new_project.id |
|
|
97 | 97 | # delete issue relations |
|
|
98 | 98 | unless Setting.cross_project_issue_relations? |
|
|
99 | 99 | issue.relations_from.clear |
|
|
100 | 100 | issue.relations_to.clear |
|
|
101 | 101 | end |
|
|
102 | 102 | # issue is moved to another project |
|
|
103 | 103 | # reassign to the category with same name if any |
|
|
104 | 104 | new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name) |
|
|
105 | 105 | issue.category = new_category |
|
|
106 | 106 | # Keep the fixed_version if it's still valid in the new_project |
|
|
107 | 107 | unless new_project.shared_versions.include?(issue.fixed_version) |
|
|
108 | 108 | issue.fixed_version = nil |
|
|
109 | 109 | end |
|
|
110 | 110 | issue.project = new_project |
|
|
111 | 111 | end |
|
|
112 | 112 | if new_tracker |
|
|
113 | 113 | issue.tracker = new_tracker |
|
|
114 | 114 | end |
|
|
115 | 115 | if options[:copy] |
|
|
116 | 116 | issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h} |
|
|
117 | 117 | issue.status = if options[:attributes] && options[:attributes][:status_id] |
|
|
118 | 118 | IssueStatus.find_by_id(options[:attributes][:status_id]) |
|
|
119 | 119 | else |
|
|
120 | 120 | self.status |
|
|
121 | 121 | end |
|
|
122 | 122 | end |
|
|
123 | 123 | # Allow bulk setting of attributes on the issue |
|
|
124 | 124 | if options[:attributes] |
|
|
125 | 125 | issue.attributes = options[:attributes] |
|
|
126 | 126 | end |
|
|
127 | 127 | if issue.save |
|
|
128 | 128 | unless options[:copy] |
|
|
129 | 129 | # Manually update project_id on related time entries |
|
|
130 | 130 | TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id}) |
|
|
131 | 131 | end |
|
|
132 | 132 | else |
|
|
133 | 133 | Issue.connection.rollback_db_transaction |
|
|
134 | 134 | return false |
|
|
135 | 135 | end |
|
|
136 | 136 | end |
|
|
137 | 137 | return issue |
|
|
138 | 138 | end |
|
|
139 | 139 | |
|
|
140 | def bulk_edit(params) | |
|
|
141 | journal = init_journal(User.current, params[:notes]) | |
|
|
142 | self.tracker = params[:tracker] if params[:tracker] | |
|
|
143 | self.priority = params[:priority] if params[:priority] | |
|
|
144 | self.assigned_to = params[:assigned_to] if params[:assigned_to] || params[:assigned_to_id] == 'none' | |
|
|
145 | self.category = params[:category] if params[:category] || params[:category_id] == 'none' | |
|
|
146 | self.fixed_version = params[:fixed_version] if params[:fixed_version] || params[:fixed_version_id] == 'none' | |
|
|
147 | self.start_date = params[:start_date] unless params[:start_date].blank? | |
|
|
148 | self.due_date = params[:due_date] unless params[:due_date].blank? | |
|
|
149 | self.done_ratio = params[:done_ratio] unless params[:done_ratio].blank? | |
|
|
150 | self.custom_field_values = params[:custom_field_values] if params[:custom_field_values] && !params[:custom_field_values].empty? | |
|
|
151 | # TODO: Edit hook name | |
|
|
152 | Redmine::Hook.call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => self }) | |
|
|
153 | ||
|
|
154 | # Don't save any change to the issue if the user is not authorized to apply the requested status | |
|
|
155 | return (params[:status].nil? || (new_statuses_allowed_to(User.current).include?(params[:status]) && self.status = params[:status])) && save | |
|
|
156 | end | |
|
|
157 | ||
|
|
158 | 140 | def priority_id=(pid) |
|
|
159 | 141 | self.priority = nil |
|
|
160 | 142 | write_attribute(:priority_id, pid) |
|
|
161 | 143 | end |
|
|
162 | 144 | |
|
|
163 | 145 | def tracker_id=(tid) |
|
|
164 | 146 | self.tracker = nil |
|
|
165 | 147 | result = write_attribute(:tracker_id, tid) |
|
|
166 | 148 | @custom_field_values = nil |
|
|
167 | 149 | result |
|
|
168 | 150 | end |
|
|
169 | 151 | |
|
|
170 | 152 | # Overrides attributes= so that tracker_id gets assigned first |
|
|
171 | 153 | def attributes_with_tracker_first=(new_attributes, *args) |
|
|
172 | 154 | return if new_attributes.nil? |
|
|
173 | 155 | new_tracker_id = new_attributes['tracker_id'] || new_attributes[:tracker_id] |
|
|
174 | 156 | if new_tracker_id |
|
|
175 | 157 | self.tracker_id = new_tracker_id |
|
|
176 | 158 | end |
|
|
177 | 159 | send :attributes_without_tracker_first=, new_attributes, *args |
|
|
178 | 160 | end |
|
|
179 | 161 | # Do not redefine alias chain on reload (see #4838) |
|
|
180 | 162 | alias_method_chain(:attributes=, :tracker_first) unless method_defined?(:attributes_without_tracker_first=) |
|
|
181 | 163 | |
|
|
182 | 164 | def estimated_hours=(h) |
|
|
183 | 165 | write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h) |
|
|
184 | 166 | end |
|
|
185 | 167 | |
|
|
186 | 168 | SAFE_ATTRIBUTES = %w( |
|
|
187 | 169 | tracker_id |
|
|
188 | 170 | status_id |
|
|
189 | 171 | category_id |
|
|
190 | 172 | assigned_to_id |
|
|
191 | 173 | priority_id |
|
|
192 | 174 | fixed_version_id |
|
|
193 | 175 | subject |
|
|
194 | 176 | description |
|
|
195 | 177 | start_date |
|
|
196 | 178 | due_date |
|
|
197 | 179 | done_ratio |
|
|
198 | 180 | estimated_hours |
|
|
199 | 181 | custom_field_values |
|
|
200 | 182 | ) unless const_defined?(:SAFE_ATTRIBUTES) |
|
|
201 | 183 | |
|
|
202 | 184 | # Safely sets attributes |
|
|
203 | 185 | # Should be called from controllers instead of #attributes= |
|
|
204 | 186 | # attr_accessible is too rough because we still want things like |
|
|
205 | 187 | # Issue.new(:project => foo) to work |
|
|
206 | 188 | # TODO: move workflow/permission checks from controllers to here |
|
|
207 | 189 | def safe_attributes=(attrs, user=User.current) |
|
|
208 | 190 | return if attrs.nil? |
|
|
209 |
|
|
|
|
191 | attrs = attrs.reject {|k,v| !SAFE_ATTRIBUTES.include?(k)} | |
|
|
192 | if attrs['status_id'] | |
|
|
193 | unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i) | |
|
|
194 | attrs.delete('status_id') | |
|
|
195 | end | |
|
|
196 | end | |
|
|
197 | self.attributes = attrs | |
|
|
210 | 198 | end |
|
|
211 | 199 | |
|
|
212 | 200 | def done_ratio |
|
|
213 | 201 | if Issue.use_status_for_done_ratio? && status && status.default_done_ratio? |
|
|
214 | 202 | status.default_done_ratio |
|
|
215 | 203 | else |
|
|
216 | 204 | read_attribute(:done_ratio) |
|
|
217 | 205 | end |
|
|
218 | 206 | end |
|
|
219 | 207 | |
|
|
220 | 208 | def self.use_status_for_done_ratio? |
|
|
221 | 209 | Setting.issue_done_ratio == 'issue_status' |
|
|
222 | 210 | end |
|
|
223 | 211 | |
|
|
224 | 212 | def self.use_field_for_done_ratio? |
|
|
225 | 213 | Setting.issue_done_ratio == 'issue_field' |
|
|
226 | 214 | end |
|
|
227 | 215 | |
|
|
228 | 216 | def validate |
|
|
229 | 217 | if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty? |
|
|
230 | 218 | errors.add :due_date, :not_a_date |
|
|
231 | 219 | end |
|
|
232 | 220 | |
|
|
233 | 221 | if self.due_date and self.start_date and self.due_date < self.start_date |
|
|
234 | 222 | errors.add :due_date, :greater_than_start_date |
|
|
235 | 223 | end |
|
|
236 | 224 | |
|
|
237 | 225 | if start_date && soonest_start && start_date < soonest_start |
|
|
238 | 226 | errors.add :start_date, :invalid |
|
|
239 | 227 | end |
|
|
240 | 228 | |
|
|
241 | 229 | if fixed_version |
|
|
242 | 230 | if !assignable_versions.include?(fixed_version) |
|
|
243 | 231 | errors.add :fixed_version_id, :inclusion |
|
|
244 | 232 | elsif reopened? && fixed_version.closed? |
|
|
245 | 233 | errors.add_to_base I18n.t(:error_can_not_reopen_issue_on_closed_version) |
|
|
246 | 234 | end |
|
|
247 | 235 | end |
|
|
248 | 236 | |
|
|
249 | 237 | # Checks that the issue can not be added/moved to a disabled tracker |
|
|
250 | 238 | if project && (tracker_id_changed? || project_id_changed?) |
|
|
251 | 239 | unless project.trackers.include?(tracker) |
|
|
252 | 240 | errors.add :tracker_id, :inclusion |
|
|
253 | 241 | end |
|
|
254 | 242 | end |
|
|
255 | 243 | end |
|
|
256 | 244 | |
|
|
257 | 245 | def before_create |
|
|
258 | 246 | # default assignment based on category |
|
|
259 | 247 | if assigned_to.nil? && category && category.assigned_to |
|
|
260 | 248 | self.assigned_to = category.assigned_to |
|
|
261 | 249 | end |
|
|
262 | 250 | end |
|
|
263 | 251 | |
|
|
264 | 252 | # Set the done_ratio using the status if that setting is set. This will keep the done_ratios |
|
|
265 | 253 | # even if the user turns off the setting later |
|
|
266 | 254 | def update_done_ratio_from_issue_status |
|
|
267 | 255 | if Issue.use_status_for_done_ratio? && status && status.default_done_ratio? |
|
|
268 | 256 | self.done_ratio = status.default_done_ratio |
|
|
269 | 257 | end |
|
|
270 | 258 | end |
|
|
271 | 259 | |
|
|
272 | 260 | def after_save |
|
|
273 | 261 | # Reload is needed in order to get the right status |
|
|
274 | 262 | reload |
|
|
275 | 263 | |
|
|
276 | 264 | # Update start/due dates of following issues |
|
|
277 | 265 | relations_from.each(&:set_issue_to_dates) |
|
|
278 | 266 | |
|
|
279 | 267 | # Close duplicates if the issue was closed |
|
|
280 | 268 | if @issue_before_change && !@issue_before_change.closed? && self.closed? |
|
|
281 | 269 | duplicates.each do |duplicate| |
|
|
282 | 270 | # Reload is need in case the duplicate was updated by a previous duplicate |
|
|
283 | 271 | duplicate.reload |
|
|
284 | 272 | # Don't re-close it if it's already closed |
|
|
285 | 273 | next if duplicate.closed? |
|
|
286 | 274 | # Same user and notes |
|
|
287 | 275 | duplicate.init_journal(@current_journal.user, @current_journal.notes) |
|
|
288 | 276 | duplicate.update_attribute :status, self.status |
|
|
289 | 277 | end |
|
|
290 | 278 | end |
|
|
291 | 279 | end |
|
|
292 | 280 | |
|
|
293 | 281 | def init_journal(user, notes = "") |
|
|
294 | 282 | @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes) |
|
|
295 | 283 | @issue_before_change = self.clone |
|
|
296 | 284 | @issue_before_change.status = self.status |
|
|
297 | 285 | @custom_values_before_change = {} |
|
|
298 | 286 | self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value } |
|
|
299 | 287 | # Make sure updated_on is updated when adding a note. |
|
|
300 | 288 | updated_on_will_change! |
|
|
301 | 289 | @current_journal |
|
|
302 | 290 | end |
|
|
303 | 291 | |
|
|
304 | 292 | # Return true if the issue is closed, otherwise false |
|
|
305 | 293 | def closed? |
|
|
306 | 294 | self.status.is_closed? |
|
|
307 | 295 | end |
|
|
308 | 296 | |
|
|
309 | 297 | # Return true if the issue is being reopened |
|
|
310 | 298 | def reopened? |
|
|
311 | 299 | if !new_record? && status_id_changed? |
|
|
312 | 300 | status_was = IssueStatus.find_by_id(status_id_was) |
|
|
313 | 301 | status_new = IssueStatus.find_by_id(status_id) |
|
|
314 | 302 | if status_was && status_new && status_was.is_closed? && !status_new.is_closed? |
|
|
315 | 303 | return true |
|
|
316 | 304 | end |
|
|
317 | 305 | end |
|
|
318 | 306 | false |
|
|
319 | 307 | end |
|
|
320 | 308 | |
|
|
321 | 309 | # Returns true if the issue is overdue |
|
|
322 | 310 | def overdue? |
|
|
323 | 311 | !due_date.nil? && (due_date < Date.today) && !status.is_closed? |
|
|
324 | 312 | end |
|
|
325 | 313 | |
|
|
326 | 314 | # Users the issue can be assigned to |
|
|
327 | 315 | def assignable_users |
|
|
328 | 316 | project.assignable_users |
|
|
329 | 317 | end |
|
|
330 | 318 | |
|
|
331 | 319 | # Versions that the issue can be assigned to |
|
|
332 | 320 | def assignable_versions |
|
|
333 | 321 | @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort |
|
|
334 | 322 | end |
|
|
335 | 323 | |
|
|
336 | 324 | # Returns true if this issue is blocked by another issue that is still open |
|
|
337 | 325 | def blocked? |
|
|
338 | 326 | !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil? |
|
|
339 | 327 | end |
|
|
340 | 328 | |
|
|
341 | 329 | # Returns an array of status that user is able to apply |
|
|
342 | 330 | def new_statuses_allowed_to(user) |
|
|
343 | 331 | statuses = status.find_new_statuses_allowed_to(user.roles_for_project(project), tracker) |
|
|
344 | 332 | statuses << status unless statuses.empty? |
|
|
345 | 333 | statuses = statuses.uniq.sort |
|
|
346 | 334 | blocked? ? statuses.reject {|s| s.is_closed?} : statuses |
|
|
347 | 335 | end |
|
|
348 | 336 | |
|
|
349 | 337 | # Returns the mail adresses of users that should be notified |
|
|
350 | 338 | def recipients |
|
|
351 | 339 | notified = project.notified_users |
|
|
352 | 340 | # Author and assignee are always notified unless they have been locked |
|
|
353 | 341 | notified << author if author && author.active? |
|
|
354 | 342 | notified << assigned_to if assigned_to && assigned_to.active? |
|
|
355 | 343 | notified.uniq! |
|
|
356 | 344 | # Remove users that can not view the issue |
|
|
357 | 345 | notified.reject! {|user| !visible?(user)} |
|
|
358 | 346 | notified.collect(&:mail) |
|
|
359 | 347 | end |
|
|
360 | 348 | |
|
|
361 | 349 | # Returns the total number of hours spent on this issue. |
|
|
362 | 350 | # |
|
|
363 | 351 | # Example: |
|
|
364 | 352 | # spent_hours => 0 |
|
|
365 | 353 | # spent_hours => 50 |
|
|
366 | 354 | def spent_hours |
|
|
367 | 355 | @spent_hours ||= time_entries.sum(:hours) || 0 |
|
|
368 | 356 | end |
|
|
369 | 357 | |
|
|
370 | 358 | def relations |
|
|
371 | 359 | (relations_from + relations_to).sort |
|
|
372 | 360 | end |
|
|
373 | 361 | |
|
|
374 | 362 | def all_dependent_issues |
|
|
375 | 363 | dependencies = [] |
|
|
376 | 364 | relations_from.each do |relation| |
|
|
377 | 365 | dependencies << relation.issue_to |
|
|
378 | 366 | dependencies += relation.issue_to.all_dependent_issues |
|
|
379 | 367 | end |
|
|
380 | 368 | dependencies |
|
|
381 | 369 | end |
|
|
382 | 370 | |
|
|
383 | 371 | # Returns an array of issues that duplicate this one |
|
|
384 | 372 | def duplicates |
|
|
385 | 373 | relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from} |
|
|
386 | 374 | end |
|
|
387 | 375 | |
|
|
388 | 376 | # Returns the due date or the target due date if any |
|
|
389 | 377 | # Used on gantt chart |
|
|
390 | 378 | def due_before |
|
|
391 | 379 | due_date || (fixed_version ? fixed_version.effective_date : nil) |
|
|
392 | 380 | end |
|
|
393 | 381 | |
|
|
394 | 382 | # Returns the time scheduled for this issue. |
|
|
395 | 383 | # |
|
|
396 | 384 | # Example: |
|
|
397 | 385 | # Start Date: 2/26/09, End Date: 3/04/09 |
|
|
398 | 386 | # duration => 6 |
|
|
399 | 387 | def duration |
|
|
400 | 388 | (start_date && due_date) ? due_date - start_date : 0 |
|
|
401 | 389 | end |
|
|
402 | 390 | |
|
|
403 | 391 | def soonest_start |
|
|
404 | 392 | @soonest_start ||= relations_to.collect{|relation| relation.successor_soonest_start}.compact.min |
|
|
405 | 393 | end |
|
|
406 | 394 | |
|
|
407 | 395 | def to_s |
|
|
408 | 396 | "#{tracker} ##{id}: #{subject}" |
|
|
409 | 397 | end |
|
|
410 | 398 | |
|
|
411 | 399 | # Returns a string of css classes that apply to the issue |
|
|
412 | 400 | def css_classes |
|
|
413 | 401 | s = "issue status-#{status.position} priority-#{priority.position}" |
|
|
414 | 402 | s << ' closed' if closed? |
|
|
415 | 403 | s << ' overdue' if overdue? |
|
|
416 | 404 | s << ' created-by-me' if User.current.logged? && author_id == User.current.id |
|
|
417 | 405 | s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id |
|
|
418 | 406 | s |
|
|
419 | 407 | end |
|
|
420 | 408 | |
|
|
421 | 409 | # Unassigns issues from +version+ if it's no longer shared with issue's project |
|
|
422 | 410 | def self.update_versions_from_sharing_change(version) |
|
|
423 | 411 | # Update issues assigned to the version |
|
|
424 | 412 | update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id]) |
|
|
425 | 413 | end |
|
|
426 | 414 | |
|
|
427 | 415 | # Unassigns issues from versions that are no longer shared |
|
|
428 | 416 | # after +project+ was moved |
|
|
429 | 417 | def self.update_versions_from_hierarchy_change(project) |
|
|
430 | 418 | moved_project_ids = project.self_and_descendants.reload.collect(&:id) |
|
|
431 | 419 | # Update issues of the moved projects and issues assigned to a version of a moved project |
|
|
432 | 420 | Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids]) |
|
|
433 | 421 | end |
|
|
434 | 422 | |
|
|
435 | 423 | # Extracted from the ReportsController. |
|
|
436 | 424 | def self.by_tracker(project) |
|
|
437 | 425 | count_and_group_by(:project => project, |
|
|
438 | 426 | :field => 'tracker_id', |
|
|
439 | 427 | :joins => Tracker.table_name) |
|
|
440 | 428 | end |
|
|
441 | 429 | |
|
|
442 | 430 | def self.by_version(project) |
|
|
443 | 431 | count_and_group_by(:project => project, |
|
|
444 | 432 | :field => 'fixed_version_id', |
|
|
445 | 433 | :joins => Version.table_name) |
|
|
446 | 434 | end |
|
|
447 | 435 | |
|
|
448 | 436 | def self.by_priority(project) |
|
|
449 | 437 | count_and_group_by(:project => project, |
|
|
450 | 438 | :field => 'priority_id', |
|
|
451 | 439 | :joins => IssuePriority.table_name) |
|
|
452 | 440 | end |
|
|
453 | 441 | |
|
|
454 | 442 | def self.by_category(project) |
|
|
455 | 443 | count_and_group_by(:project => project, |
|
|
456 | 444 | :field => 'category_id', |
|
|
457 | 445 | :joins => IssueCategory.table_name) |
|
|
458 | 446 | end |
|
|
459 | 447 | |
|
|
460 | 448 | def self.by_assigned_to(project) |
|
|
461 | 449 | count_and_group_by(:project => project, |
|
|
462 | 450 | :field => 'assigned_to_id', |
|
|
463 | 451 | :joins => User.table_name) |
|
|
464 | 452 | end |
|
|
465 | 453 | |
|
|
466 | 454 | def self.by_author(project) |
|
|
467 | 455 | count_and_group_by(:project => project, |
|
|
468 | 456 | :field => 'author_id', |
|
|
469 | 457 | :joins => User.table_name) |
|
|
470 | 458 | end |
|
|
471 | 459 | |
|
|
472 | 460 | def self.by_subproject(project) |
|
|
473 | 461 | ActiveRecord::Base.connection.select_all("select s.id as status_id, |
|
|
474 | 462 | s.is_closed as closed, |
|
|
475 | 463 | i.project_id as project_id, |
|
|
476 | 464 | count(i.id) as total |
|
|
477 | 465 | from |
|
|
478 | 466 | #{Issue.table_name} i, #{IssueStatus.table_name} s |
|
|
479 | 467 | where |
|
|
480 | 468 | i.status_id=s.id |
|
|
481 | 469 | and i.project_id IN (#{project.descendants.active.collect{|p| p.id}.join(',')}) |
|
|
482 | 470 | group by s.id, s.is_closed, i.project_id") if project.descendants.active.any? |
|
|
483 | 471 | end |
|
|
484 | 472 | # End ReportsController extraction |
|
|
485 | 473 | |
|
|
486 | 474 | private |
|
|
487 | 475 | |
|
|
488 | 476 | # Update issues so their versions are not pointing to a |
|
|
489 | 477 | # fixed_version that is not shared with the issue's project |
|
|
490 | 478 | def self.update_versions(conditions=nil) |
|
|
491 | 479 | # Only need to update issues with a fixed_version from |
|
|
492 | 480 | # a different project and that is not systemwide shared |
|
|
493 | 481 | Issue.all(:conditions => merge_conditions("#{Issue.table_name}.fixed_version_id IS NOT NULL" + |
|
|
494 | 482 | " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" + |
|
|
495 | 483 | " AND #{Version.table_name}.sharing <> 'system'", |
|
|
496 | 484 | conditions), |
|
|
497 | 485 | :include => [:project, :fixed_version] |
|
|
498 | 486 | ).each do |issue| |
|
|
499 | 487 | next if issue.project.nil? || issue.fixed_version.nil? |
|
|
500 | 488 | unless issue.project.shared_versions.include?(issue.fixed_version) |
|
|
501 | 489 | issue.init_journal(User.current) |
|
|
502 | 490 | issue.fixed_version = nil |
|
|
503 | 491 | issue.save |
|
|
504 | 492 | end |
|
|
505 | 493 | end |
|
|
506 | 494 | end |
|
|
507 | 495 | |
|
|
508 | 496 | # Callback on attachment deletion |
|
|
509 | 497 | def attachment_removed(obj) |
|
|
510 | 498 | journal = init_journal(User.current) |
|
|
511 | 499 | journal.details << JournalDetail.new(:property => 'attachment', |
|
|
512 | 500 | :prop_key => obj.id, |
|
|
513 | 501 | :old_value => obj.filename) |
|
|
514 | 502 | journal.save |
|
|
515 | 503 | end |
|
|
516 | 504 | |
|
|
517 | 505 | # Saves the changes in a Journal |
|
|
518 | 506 | # Called after_save |
|
|
519 | 507 | def create_journal |
|
|
520 | 508 | if @current_journal |
|
|
521 | 509 | # attributes changes |
|
|
522 | 510 | (Issue.column_names - %w(id description lock_version created_on updated_on)).each {|c| |
|
|
523 | 511 | @current_journal.details << JournalDetail.new(:property => 'attr', |
|
|
524 | 512 | :prop_key => c, |
|
|
525 | 513 | :old_value => @issue_before_change.send(c), |
|
|
526 | 514 | :value => send(c)) unless send(c)==@issue_before_change.send(c) |
|
|
527 | 515 | } |
|
|
528 | 516 | # custom fields changes |
|
|
529 | 517 | custom_values.each {|c| |
|
|
530 | 518 | next if (@custom_values_before_change[c.custom_field_id]==c.value || |
|
|
531 | 519 | (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?)) |
|
|
532 | 520 | @current_journal.details << JournalDetail.new(:property => 'cf', |
|
|
533 | 521 | :prop_key => c.custom_field_id, |
|
|
534 | 522 | :old_value => @custom_values_before_change[c.custom_field_id], |
|
|
535 | 523 | :value => c.value) |
|
|
536 | 524 | } |
|
|
537 | 525 | @current_journal.save |
|
|
538 | 526 | end |
|
|
539 | 527 | end |
|
|
540 | 528 | |
|
|
541 | 529 | # Query generator for selecting groups of issue counts for a project |
|
|
542 | 530 | # based on specific criteria |
|
|
543 | 531 | # |
|
|
544 | 532 | # Options |
|
|
545 | 533 | # * project - Project to search in. |
|
|
546 | 534 | # * field - String. Issue field to key off of in the grouping. |
|
|
547 | 535 | # * joins - String. The table name to join against. |
|
|
548 | 536 | def self.count_and_group_by(options) |
|
|
549 | 537 | project = options.delete(:project) |
|
|
550 | 538 | select_field = options.delete(:field) |
|
|
551 | 539 | joins = options.delete(:joins) |
|
|
552 | 540 | |
|
|
553 | 541 | where = "i.#{select_field}=j.id" |
|
|
554 | 542 | |
|
|
555 | 543 | ActiveRecord::Base.connection.select_all("select s.id as status_id, |
|
|
556 | 544 | s.is_closed as closed, |
|
|
557 | 545 | j.id as #{select_field}, |
|
|
558 | 546 | count(i.id) as total |
|
|
559 | 547 | from |
|
|
560 | 548 | #{Issue.table_name} i, #{IssueStatus.table_name} s, #{joins} as j |
|
|
561 | 549 | where |
|
|
562 | 550 | i.status_id=s.id |
|
|
563 | 551 | and #{where} |
|
|
564 | 552 | and i.project_id=#{project.id} |
|
|
565 | 553 | group by s.id, s.is_closed, j.id") |
|
|
566 | 554 | end |
|
|
567 | 555 | |
|
|
568 | 556 | |
|
|
569 | 557 | end |
| @@ -1,78 +1,78 | |||
|
|
1 | 1 | <h2><%= l(:label_bulk_edit_selected_issues) %></h2> |
|
|
2 | 2 | |
|
|
3 | 3 | <ul><%= @issues.collect {|i| content_tag('li', link_to(h("#{i.tracker} ##{i.id}"), { :action => 'show', :id => i }) + h(": #{i.subject}")) }.join("\n") %></ul> |
|
|
4 | 4 | |
|
|
5 | 5 | <% form_tag() do %> |
|
|
6 | 6 | <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join %> |
|
|
7 | 7 | <div class="box tabular"> |
|
|
8 | 8 | <fieldset> |
|
|
9 | 9 | <legend><%= l(:label_change_properties) %></legend> |
|
|
10 | 10 | |
|
|
11 | 11 | <div class="splitcontentleft"> |
|
|
12 | 12 | <p> |
|
|
13 | 13 | <label><%= l(:field_tracker) %></label> |
|
|
14 | <%= select_tag('tracker_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@project.trackers, :id, :name)) %> | |
|
|
14 | <%= select_tag('issue[tracker_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@project.trackers, :id, :name)) %> | |
|
|
15 | 15 | </p> |
|
|
16 | 16 | <% if @available_statuses.any? %> |
|
|
17 | 17 | <p> |
|
|
18 | 18 | <label><%= l(:field_status) %></label> |
|
|
19 | <%= select_tag('status_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %> | |
|
|
19 | <%= select_tag('issue[status_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %> | |
|
|
20 | 20 | </p> |
|
|
21 | 21 | <% end %> |
|
|
22 | 22 | <p> |
|
|
23 | 23 | <label><%= l(:field_priority) %></label> |
|
|
24 | <%= select_tag('priority_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(IssuePriority.all, :id, :name)) %> | |
|
|
24 | <%= select_tag('issue[priority_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(IssuePriority.all, :id, :name)) %> | |
|
|
25 | 25 | </p> |
|
|
26 | 26 | <p> |
|
|
27 | 27 | <label><%= l(:field_assigned_to) %></label> |
|
|
28 | <%= select_tag('assigned_to_id', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
28 | <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
29 | 29 | content_tag('option', l(:label_nobody), :value => 'none') + |
|
|
30 | 30 | options_from_collection_for_select(@project.assignable_users, :id, :name)) %> |
|
|
31 | 31 | </p> |
|
|
32 | 32 | <p> |
|
|
33 | 33 | <label><%= l(:field_category) %></label> |
|
|
34 | <%= select_tag('category_id', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
34 | <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
35 | 35 | content_tag('option', l(:label_none), :value => 'none') + |
|
|
36 | 36 | options_from_collection_for_select(@project.issue_categories, :id, :name)) %> |
|
|
37 | 37 | </p> |
|
|
38 | 38 | <p> |
|
|
39 | 39 | <label><%= l(:field_fixed_version) %></label> |
|
|
40 | <%= select_tag('fixed_version_id', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
40 | <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
41 | 41 | content_tag('option', l(:label_none), :value => 'none') + |
|
|
42 | 42 | version_options_for_select(@project.shared_versions.open)) %> |
|
|
43 | 43 | </p> |
|
|
44 | 44 | |
|
|
45 | 45 | <% @custom_fields.each do |custom_field| %> |
|
|
46 | <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit(custom_field) %></p> | |
|
|
46 | <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field) %></p> | |
|
|
47 | 47 | <% end %> |
|
|
48 | 48 | |
|
|
49 | 49 | <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %> |
|
|
50 | 50 | </div> |
|
|
51 | 51 | |
|
|
52 | 52 | <div class="splitcontentright"> |
|
|
53 | 53 | <p> |
|
|
54 | 54 | <label><%= l(:field_start_date) %></label> |
|
|
55 | <%= text_field_tag 'start_date', '', :size => 10 %><%= calendar_for('start_date') %> | |
|
|
55 | <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %> | |
|
|
56 | 56 | </p> |
|
|
57 | 57 | <p> |
|
|
58 | 58 | <label><%= l(:field_due_date) %></label> |
|
|
59 | <%= text_field_tag 'due_date', '', :size => 10 %><%= calendar_for('due_date') %> | |
|
|
59 | <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %> | |
|
|
60 | 60 | </p> |
|
|
61 | 61 | <% if Issue.use_field_for_done_ratio? %> |
|
|
62 | 62 | <p> |
|
|
63 | 63 | <label><%= l(:field_done_ratio) %></label> |
|
|
64 | <%= select_tag 'done_ratio', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %> | |
|
|
64 | <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %> | |
|
|
65 | 65 | </p> |
|
|
66 | 66 | <% end %> |
|
|
67 | 67 | </div> |
|
|
68 | 68 | |
|
|
69 | 69 | </fieldset> |
|
|
70 | 70 | |
|
|
71 | 71 | <fieldset><legend><%= l(:field_notes) %></legend> |
|
|
72 | 72 | <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %> |
|
|
73 | 73 | <%= wikitoolbar_for 'notes' %> |
|
|
74 | 74 | </fieldset> |
|
|
75 | 75 | </div> |
|
|
76 | 76 | |
|
|
77 | 77 | <p><%= submit_tag l(:button_submit) %></p> |
|
|
78 | 78 | <% end %> |
| @@ -1,1230 +1,1233 | |||
|
|
1 | 1 | # Redmine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2008 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | require File.dirname(__FILE__) + '/../test_helper' |
|
|
19 | 19 | require 'issues_controller' |
|
|
20 | 20 | |
|
|
21 | 21 | # Re-raise errors caught by the controller. |
|
|
22 | 22 | class IssuesController; def rescue_action(e) raise e end; end |
|
|
23 | 23 | |
|
|
24 | 24 | class IssuesControllerTest < ActionController::TestCase |
|
|
25 | 25 | fixtures :projects, |
|
|
26 | 26 | :users, |
|
|
27 | 27 | :roles, |
|
|
28 | 28 | :members, |
|
|
29 | 29 | :member_roles, |
|
|
30 | 30 | :issues, |
|
|
31 | 31 | :issue_statuses, |
|
|
32 | 32 | :versions, |
|
|
33 | 33 | :trackers, |
|
|
34 | 34 | :projects_trackers, |
|
|
35 | 35 | :issue_categories, |
|
|
36 | 36 | :enabled_modules, |
|
|
37 | 37 | :enumerations, |
|
|
38 | 38 | :attachments, |
|
|
39 | 39 | :workflows, |
|
|
40 | 40 | :custom_fields, |
|
|
41 | 41 | :custom_values, |
|
|
42 | 42 | :custom_fields_projects, |
|
|
43 | 43 | :custom_fields_trackers, |
|
|
44 | 44 | :time_entries, |
|
|
45 | 45 | :journals, |
|
|
46 | 46 | :journal_details, |
|
|
47 | 47 | :queries |
|
|
48 | 48 | |
|
|
49 | 49 | def setup |
|
|
50 | 50 | @controller = IssuesController.new |
|
|
51 | 51 | @request = ActionController::TestRequest.new |
|
|
52 | 52 | @response = ActionController::TestResponse.new |
|
|
53 | 53 | User.current = nil |
|
|
54 | 54 | end |
|
|
55 | 55 | |
|
|
56 | 56 | def test_index |
|
|
57 | 57 | Setting.default_language = 'en' |
|
|
58 | 58 | |
|
|
59 | 59 | get :index |
|
|
60 | 60 | assert_response :success |
|
|
61 | 61 | assert_template 'index.rhtml' |
|
|
62 | 62 | assert_not_nil assigns(:issues) |
|
|
63 | 63 | assert_nil assigns(:project) |
|
|
64 | 64 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
65 | 65 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
66 | 66 | # private projects hidden |
|
|
67 | 67 | assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
68 | 68 | assert_no_tag :tag => 'a', :content => /Issue on project 2/ |
|
|
69 | 69 | # project column |
|
|
70 | 70 | assert_tag :tag => 'th', :content => /Project/ |
|
|
71 | 71 | end |
|
|
72 | 72 | |
|
|
73 | 73 | def test_index_should_not_list_issues_when_module_disabled |
|
|
74 | 74 | EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") |
|
|
75 | 75 | get :index |
|
|
76 | 76 | assert_response :success |
|
|
77 | 77 | assert_template 'index.rhtml' |
|
|
78 | 78 | assert_not_nil assigns(:issues) |
|
|
79 | 79 | assert_nil assigns(:project) |
|
|
80 | 80 | assert_no_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
81 | 81 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
82 | 82 | end |
|
|
83 | 83 | |
|
|
84 | 84 | def test_index_should_not_list_issues_when_module_disabled |
|
|
85 | 85 | EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") |
|
|
86 | 86 | get :index |
|
|
87 | 87 | assert_response :success |
|
|
88 | 88 | assert_template 'index.rhtml' |
|
|
89 | 89 | assert_not_nil assigns(:issues) |
|
|
90 | 90 | assert_nil assigns(:project) |
|
|
91 | 91 | assert_no_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
92 | 92 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
93 | 93 | end |
|
|
94 | 94 | |
|
|
95 | 95 | def test_index_with_project |
|
|
96 | 96 | Setting.display_subprojects_issues = 0 |
|
|
97 | 97 | get :index, :project_id => 1 |
|
|
98 | 98 | assert_response :success |
|
|
99 | 99 | assert_template 'index.rhtml' |
|
|
100 | 100 | assert_not_nil assigns(:issues) |
|
|
101 | 101 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
102 | 102 | assert_no_tag :tag => 'a', :content => /Subproject issue/ |
|
|
103 | 103 | end |
|
|
104 | 104 | |
|
|
105 | 105 | def test_index_with_project_and_subprojects |
|
|
106 | 106 | Setting.display_subprojects_issues = 1 |
|
|
107 | 107 | get :index, :project_id => 1 |
|
|
108 | 108 | assert_response :success |
|
|
109 | 109 | assert_template 'index.rhtml' |
|
|
110 | 110 | assert_not_nil assigns(:issues) |
|
|
111 | 111 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
112 | 112 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
113 | 113 | assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
114 | 114 | end |
|
|
115 | 115 | |
|
|
116 | 116 | def test_index_with_project_and_subprojects_should_show_private_subprojects |
|
|
117 | 117 | @request.session[:user_id] = 2 |
|
|
118 | 118 | Setting.display_subprojects_issues = 1 |
|
|
119 | 119 | get :index, :project_id => 1 |
|
|
120 | 120 | assert_response :success |
|
|
121 | 121 | assert_template 'index.rhtml' |
|
|
122 | 122 | assert_not_nil assigns(:issues) |
|
|
123 | 123 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
124 | 124 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
125 | 125 | assert_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
126 | 126 | end |
|
|
127 | 127 | |
|
|
128 | 128 | def test_index_with_project_and_filter |
|
|
129 | 129 | get :index, :project_id => 1, :set_filter => 1 |
|
|
130 | 130 | assert_response :success |
|
|
131 | 131 | assert_template 'index.rhtml' |
|
|
132 | 132 | assert_not_nil assigns(:issues) |
|
|
133 | 133 | end |
|
|
134 | 134 | |
|
|
135 | 135 | def test_index_with_query |
|
|
136 | 136 | get :index, :project_id => 1, :query_id => 5 |
|
|
137 | 137 | assert_response :success |
|
|
138 | 138 | assert_template 'index.rhtml' |
|
|
139 | 139 | assert_not_nil assigns(:issues) |
|
|
140 | 140 | assert_nil assigns(:issue_count_by_group) |
|
|
141 | 141 | end |
|
|
142 | 142 | |
|
|
143 | 143 | def test_index_with_query_grouped_by_tracker |
|
|
144 | 144 | get :index, :project_id => 1, :query_id => 6 |
|
|
145 | 145 | assert_response :success |
|
|
146 | 146 | assert_template 'index.rhtml' |
|
|
147 | 147 | assert_not_nil assigns(:issues) |
|
|
148 | 148 | assert_not_nil assigns(:issue_count_by_group) |
|
|
149 | 149 | end |
|
|
150 | 150 | |
|
|
151 | 151 | def test_index_with_query_grouped_by_list_custom_field |
|
|
152 | 152 | get :index, :project_id => 1, :query_id => 9 |
|
|
153 | 153 | assert_response :success |
|
|
154 | 154 | assert_template 'index.rhtml' |
|
|
155 | 155 | assert_not_nil assigns(:issues) |
|
|
156 | 156 | assert_not_nil assigns(:issue_count_by_group) |
|
|
157 | 157 | end |
|
|
158 | 158 | |
|
|
159 | 159 | def test_index_sort_by_field_not_included_in_columns |
|
|
160 | 160 | Setting.issue_list_default_columns = %w(subject author) |
|
|
161 | 161 | get :index, :sort => 'tracker' |
|
|
162 | 162 | end |
|
|
163 | 163 | |
|
|
164 | 164 | def test_index_csv_with_project |
|
|
165 | 165 | Setting.default_language = 'en' |
|
|
166 | 166 | |
|
|
167 | 167 | get :index, :format => 'csv' |
|
|
168 | 168 | assert_response :success |
|
|
169 | 169 | assert_not_nil assigns(:issues) |
|
|
170 | 170 | assert_equal 'text/csv', @response.content_type |
|
|
171 | 171 | assert @response.body.starts_with?("#,") |
|
|
172 | 172 | |
|
|
173 | 173 | get :index, :project_id => 1, :format => 'csv' |
|
|
174 | 174 | assert_response :success |
|
|
175 | 175 | assert_not_nil assigns(:issues) |
|
|
176 | 176 | assert_equal 'text/csv', @response.content_type |
|
|
177 | 177 | end |
|
|
178 | 178 | |
|
|
179 | 179 | def test_index_pdf |
|
|
180 | 180 | get :index, :format => 'pdf' |
|
|
181 | 181 | assert_response :success |
|
|
182 | 182 | assert_not_nil assigns(:issues) |
|
|
183 | 183 | assert_equal 'application/pdf', @response.content_type |
|
|
184 | 184 | |
|
|
185 | 185 | get :index, :project_id => 1, :format => 'pdf' |
|
|
186 | 186 | assert_response :success |
|
|
187 | 187 | assert_not_nil assigns(:issues) |
|
|
188 | 188 | assert_equal 'application/pdf', @response.content_type |
|
|
189 | 189 | |
|
|
190 | 190 | get :index, :project_id => 1, :query_id => 6, :format => 'pdf' |
|
|
191 | 191 | assert_response :success |
|
|
192 | 192 | assert_not_nil assigns(:issues) |
|
|
193 | 193 | assert_equal 'application/pdf', @response.content_type |
|
|
194 | 194 | end |
|
|
195 | 195 | |
|
|
196 | 196 | def test_index_pdf_with_query_grouped_by_list_custom_field |
|
|
197 | 197 | get :index, :project_id => 1, :query_id => 9, :format => 'pdf' |
|
|
198 | 198 | assert_response :success |
|
|
199 | 199 | assert_not_nil assigns(:issues) |
|
|
200 | 200 | assert_not_nil assigns(:issue_count_by_group) |
|
|
201 | 201 | assert_equal 'application/pdf', @response.content_type |
|
|
202 | 202 | end |
|
|
203 | 203 | |
|
|
204 | 204 | def test_index_sort |
|
|
205 | 205 | get :index, :sort => 'tracker,id:desc' |
|
|
206 | 206 | assert_response :success |
|
|
207 | 207 | |
|
|
208 | 208 | sort_params = @request.session['issues_index_sort'] |
|
|
209 | 209 | assert sort_params.is_a?(String) |
|
|
210 | 210 | assert_equal 'tracker,id:desc', sort_params |
|
|
211 | 211 | |
|
|
212 | 212 | issues = assigns(:issues) |
|
|
213 | 213 | assert_not_nil issues |
|
|
214 | 214 | assert !issues.empty? |
|
|
215 | 215 | assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id) |
|
|
216 | 216 | end |
|
|
217 | 217 | |
|
|
218 | 218 | def test_index_with_columns |
|
|
219 | 219 | columns = ['tracker', 'subject', 'assigned_to'] |
|
|
220 | 220 | get :index, :set_filter => 1, :query => { 'column_names' => columns} |
|
|
221 | 221 | assert_response :success |
|
|
222 | 222 | |
|
|
223 | 223 | # query should use specified columns |
|
|
224 | 224 | query = assigns(:query) |
|
|
225 | 225 | assert_kind_of Query, query |
|
|
226 | 226 | assert_equal columns, query.column_names.map(&:to_s) |
|
|
227 | 227 | |
|
|
228 | 228 | # columns should be stored in session |
|
|
229 | 229 | assert_kind_of Hash, session[:query] |
|
|
230 | 230 | assert_kind_of Array, session[:query][:column_names] |
|
|
231 | 231 | assert_equal columns, session[:query][:column_names].map(&:to_s) |
|
|
232 | 232 | end |
|
|
233 | 233 | |
|
|
234 | 234 | def test_gantt |
|
|
235 | 235 | get :gantt, :project_id => 1 |
|
|
236 | 236 | assert_response :success |
|
|
237 | 237 | assert_template 'gantt.rhtml' |
|
|
238 | 238 | assert_not_nil assigns(:gantt) |
|
|
239 | 239 | events = assigns(:gantt).events |
|
|
240 | 240 | assert_not_nil events |
|
|
241 | 241 | # Issue with start and due dates |
|
|
242 | 242 | i = Issue.find(1) |
|
|
243 | 243 | assert_not_nil i.due_date |
|
|
244 | 244 | assert events.include?(Issue.find(1)) |
|
|
245 | 245 | # Issue with without due date but targeted to a version with date |
|
|
246 | 246 | i = Issue.find(2) |
|
|
247 | 247 | assert_nil i.due_date |
|
|
248 | 248 | assert events.include?(i) |
|
|
249 | 249 | end |
|
|
250 | 250 | |
|
|
251 | 251 | def test_cross_project_gantt |
|
|
252 | 252 | get :gantt |
|
|
253 | 253 | assert_response :success |
|
|
254 | 254 | assert_template 'gantt.rhtml' |
|
|
255 | 255 | assert_not_nil assigns(:gantt) |
|
|
256 | 256 | events = assigns(:gantt).events |
|
|
257 | 257 | assert_not_nil events |
|
|
258 | 258 | end |
|
|
259 | 259 | |
|
|
260 | 260 | def test_gantt_export_to_pdf |
|
|
261 | 261 | get :gantt, :project_id => 1, :format => 'pdf' |
|
|
262 | 262 | assert_response :success |
|
|
263 | 263 | assert_equal 'application/pdf', @response.content_type |
|
|
264 | 264 | assert @response.body.starts_with?('%PDF') |
|
|
265 | 265 | assert_not_nil assigns(:gantt) |
|
|
266 | 266 | end |
|
|
267 | 267 | |
|
|
268 | 268 | def test_cross_project_gantt_export_to_pdf |
|
|
269 | 269 | get :gantt, :format => 'pdf' |
|
|
270 | 270 | assert_response :success |
|
|
271 | 271 | assert_equal 'application/pdf', @response.content_type |
|
|
272 | 272 | assert @response.body.starts_with?('%PDF') |
|
|
273 | 273 | assert_not_nil assigns(:gantt) |
|
|
274 | 274 | end |
|
|
275 | 275 | |
|
|
276 | 276 | if Object.const_defined?(:Magick) |
|
|
277 | 277 | def test_gantt_image |
|
|
278 | 278 | get :gantt, :project_id => 1, :format => 'png' |
|
|
279 | 279 | assert_response :success |
|
|
280 | 280 | assert_equal 'image/png', @response.content_type |
|
|
281 | 281 | end |
|
|
282 | 282 | else |
|
|
283 | 283 | puts "RMagick not installed. Skipping tests !!!" |
|
|
284 | 284 | end |
|
|
285 | 285 | |
|
|
286 | 286 | def test_calendar |
|
|
287 | 287 | get :calendar, :project_id => 1 |
|
|
288 | 288 | assert_response :success |
|
|
289 | 289 | assert_template 'calendar' |
|
|
290 | 290 | assert_not_nil assigns(:calendar) |
|
|
291 | 291 | end |
|
|
292 | 292 | |
|
|
293 | 293 | def test_cross_project_calendar |
|
|
294 | 294 | get :calendar |
|
|
295 | 295 | assert_response :success |
|
|
296 | 296 | assert_template 'calendar' |
|
|
297 | 297 | assert_not_nil assigns(:calendar) |
|
|
298 | 298 | end |
|
|
299 | 299 | |
|
|
300 | 300 | def test_changes |
|
|
301 | 301 | get :changes, :project_id => 1 |
|
|
302 | 302 | assert_response :success |
|
|
303 | 303 | assert_not_nil assigns(:journals) |
|
|
304 | 304 | assert_equal 'application/atom+xml', @response.content_type |
|
|
305 | 305 | end |
|
|
306 | 306 | |
|
|
307 | 307 | def test_show_by_anonymous |
|
|
308 | 308 | get :show, :id => 1 |
|
|
309 | 309 | assert_response :success |
|
|
310 | 310 | assert_template 'show.rhtml' |
|
|
311 | 311 | assert_not_nil assigns(:issue) |
|
|
312 | 312 | assert_equal Issue.find(1), assigns(:issue) |
|
|
313 | 313 | |
|
|
314 | 314 | # anonymous role is allowed to add a note |
|
|
315 | 315 | assert_tag :tag => 'form', |
|
|
316 | 316 | :descendant => { :tag => 'fieldset', |
|
|
317 | 317 | :child => { :tag => 'legend', |
|
|
318 | 318 | :content => /Notes/ } } |
|
|
319 | 319 | end |
|
|
320 | 320 | |
|
|
321 | 321 | def test_show_by_manager |
|
|
322 | 322 | @request.session[:user_id] = 2 |
|
|
323 | 323 | get :show, :id => 1 |
|
|
324 | 324 | assert_response :success |
|
|
325 | 325 | |
|
|
326 | 326 | assert_tag :tag => 'form', |
|
|
327 | 327 | :descendant => { :tag => 'fieldset', |
|
|
328 | 328 | :child => { :tag => 'legend', |
|
|
329 | 329 | :content => /Change properties/ } }, |
|
|
330 | 330 | :descendant => { :tag => 'fieldset', |
|
|
331 | 331 | :child => { :tag => 'legend', |
|
|
332 | 332 | :content => /Log time/ } }, |
|
|
333 | 333 | :descendant => { :tag => 'fieldset', |
|
|
334 | 334 | :child => { :tag => 'legend', |
|
|
335 | 335 | :content => /Notes/ } } |
|
|
336 | 336 | end |
|
|
337 | 337 | |
|
|
338 | 338 | def test_show_should_deny_anonymous_access_without_permission |
|
|
339 | 339 | Role.anonymous.remove_permission!(:view_issues) |
|
|
340 | 340 | get :show, :id => 1 |
|
|
341 | 341 | assert_response :redirect |
|
|
342 | 342 | end |
|
|
343 | 343 | |
|
|
344 | 344 | def test_show_should_deny_non_member_access_without_permission |
|
|
345 | 345 | Role.non_member.remove_permission!(:view_issues) |
|
|
346 | 346 | @request.session[:user_id] = 9 |
|
|
347 | 347 | get :show, :id => 1 |
|
|
348 | 348 | assert_response 403 |
|
|
349 | 349 | end |
|
|
350 | 350 | |
|
|
351 | 351 | def test_show_should_deny_member_access_without_permission |
|
|
352 | 352 | Role.find(1).remove_permission!(:view_issues) |
|
|
353 | 353 | @request.session[:user_id] = 2 |
|
|
354 | 354 | get :show, :id => 1 |
|
|
355 | 355 | assert_response 403 |
|
|
356 | 356 | end |
|
|
357 | 357 | |
|
|
358 | 358 | def test_show_should_not_disclose_relations_to_invisible_issues |
|
|
359 | 359 | Setting.cross_project_issue_relations = '1' |
|
|
360 | 360 | IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates') |
|
|
361 | 361 | # Relation to a private project issue |
|
|
362 | 362 | IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates') |
|
|
363 | 363 | |
|
|
364 | 364 | get :show, :id => 1 |
|
|
365 | 365 | assert_response :success |
|
|
366 | 366 | |
|
|
367 | 367 | assert_tag :div, :attributes => { :id => 'relations' }, |
|
|
368 | 368 | :descendant => { :tag => 'a', :content => /#2$/ } |
|
|
369 | 369 | assert_no_tag :div, :attributes => { :id => 'relations' }, |
|
|
370 | 370 | :descendant => { :tag => 'a', :content => /#4$/ } |
|
|
371 | 371 | end |
|
|
372 | 372 | |
|
|
373 | 373 | def test_show_atom |
|
|
374 | 374 | get :show, :id => 2, :format => 'atom' |
|
|
375 | 375 | assert_response :success |
|
|
376 | 376 | assert_template 'changes.rxml' |
|
|
377 | 377 | # Inline image |
|
|
378 | 378 | assert @response.body.include?("<img src=\"http://test.host/attachments/download/10\" alt=\"\" />"), "Body did not match. Body: #{@response.body}" |
|
|
379 | 379 | end |
|
|
380 | 380 | |
|
|
381 | 381 | def test_show_export_to_pdf |
|
|
382 | 382 | get :show, :id => 3, :format => 'pdf' |
|
|
383 | 383 | assert_response :success |
|
|
384 | 384 | assert_equal 'application/pdf', @response.content_type |
|
|
385 | 385 | assert @response.body.starts_with?('%PDF') |
|
|
386 | 386 | assert_not_nil assigns(:issue) |
|
|
387 | 387 | end |
|
|
388 | 388 | |
|
|
389 | 389 | def test_get_new |
|
|
390 | 390 | @request.session[:user_id] = 2 |
|
|
391 | 391 | get :new, :project_id => 1, :tracker_id => 1 |
|
|
392 | 392 | assert_response :success |
|
|
393 | 393 | assert_template 'new' |
|
|
394 | 394 | |
|
|
395 | 395 | assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]', |
|
|
396 | 396 | :value => 'Default string' } |
|
|
397 | 397 | end |
|
|
398 | 398 | |
|
|
399 | 399 | def test_get_new_without_tracker_id |
|
|
400 | 400 | @request.session[:user_id] = 2 |
|
|
401 | 401 | get :new, :project_id => 1 |
|
|
402 | 402 | assert_response :success |
|
|
403 | 403 | assert_template 'new' |
|
|
404 | 404 | |
|
|
405 | 405 | issue = assigns(:issue) |
|
|
406 | 406 | assert_not_nil issue |
|
|
407 | 407 | assert_equal Project.find(1).trackers.first, issue.tracker |
|
|
408 | 408 | end |
|
|
409 | 409 | |
|
|
410 | 410 | def test_get_new_with_no_default_status_should_display_an_error |
|
|
411 | 411 | @request.session[:user_id] = 2 |
|
|
412 | 412 | IssueStatus.delete_all |
|
|
413 | 413 | |
|
|
414 | 414 | get :new, :project_id => 1 |
|
|
415 | 415 | assert_response 500 |
|
|
416 | 416 | assert_not_nil flash[:error] |
|
|
417 | 417 | assert_tag :tag => 'div', :attributes => { :class => /error/ }, |
|
|
418 | 418 | :content => /No default issue/ |
|
|
419 | 419 | end |
|
|
420 | 420 | |
|
|
421 | 421 | def test_get_new_with_no_tracker_should_display_an_error |
|
|
422 | 422 | @request.session[:user_id] = 2 |
|
|
423 | 423 | Tracker.delete_all |
|
|
424 | 424 | |
|
|
425 | 425 | get :new, :project_id => 1 |
|
|
426 | 426 | assert_response 500 |
|
|
427 | 427 | assert_not_nil flash[:error] |
|
|
428 | 428 | assert_tag :tag => 'div', :attributes => { :class => /error/ }, |
|
|
429 | 429 | :content => /No tracker/ |
|
|
430 | 430 | end |
|
|
431 | 431 | |
|
|
432 | 432 | def test_update_new_form |
|
|
433 | 433 | @request.session[:user_id] = 2 |
|
|
434 | 434 | xhr :post, :update_form, :project_id => 1, |
|
|
435 | 435 | :issue => {:tracker_id => 2, |
|
|
436 | 436 | :subject => 'This is the test_new issue', |
|
|
437 | 437 | :description => 'This is the description', |
|
|
438 | 438 | :priority_id => 5} |
|
|
439 | 439 | assert_response :success |
|
|
440 | 440 | assert_template 'attributes' |
|
|
441 | 441 | |
|
|
442 | 442 | issue = assigns(:issue) |
|
|
443 | 443 | assert_kind_of Issue, issue |
|
|
444 | 444 | assert_equal 1, issue.project_id |
|
|
445 | 445 | assert_equal 2, issue.tracker_id |
|
|
446 | 446 | assert_equal 'This is the test_new issue', issue.subject |
|
|
447 | 447 | end |
|
|
448 | 448 | |
|
|
449 | 449 | def test_post_new |
|
|
450 | 450 | @request.session[:user_id] = 2 |
|
|
451 | 451 | assert_difference 'Issue.count' do |
|
|
452 | 452 | post :new, :project_id => 1, |
|
|
453 | 453 | :issue => {:tracker_id => 3, |
|
|
454 | 454 | :subject => 'This is the test_new issue', |
|
|
455 | 455 | :description => 'This is the description', |
|
|
456 | 456 | :priority_id => 5, |
|
|
457 | 457 | :estimated_hours => '', |
|
|
458 | 458 | :custom_field_values => {'2' => 'Value for field 2'}} |
|
|
459 | 459 | end |
|
|
460 | 460 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
461 | 461 | |
|
|
462 | 462 | issue = Issue.find_by_subject('This is the test_new issue') |
|
|
463 | 463 | assert_not_nil issue |
|
|
464 | 464 | assert_equal 2, issue.author_id |
|
|
465 | 465 | assert_equal 3, issue.tracker_id |
|
|
466 | 466 | assert_nil issue.estimated_hours |
|
|
467 | 467 | v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2}) |
|
|
468 | 468 | assert_not_nil v |
|
|
469 | 469 | assert_equal 'Value for field 2', v.value |
|
|
470 | 470 | end |
|
|
471 | 471 | |
|
|
472 | 472 | def test_post_new_and_continue |
|
|
473 | 473 | @request.session[:user_id] = 2 |
|
|
474 | 474 | post :new, :project_id => 1, |
|
|
475 | 475 | :issue => {:tracker_id => 3, |
|
|
476 | 476 | :subject => 'This is first issue', |
|
|
477 | 477 | :priority_id => 5}, |
|
|
478 | 478 | :continue => '' |
|
|
479 | 479 | assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3 |
|
|
480 | 480 | end |
|
|
481 | 481 | |
|
|
482 | 482 | def test_post_new_without_custom_fields_param |
|
|
483 | 483 | @request.session[:user_id] = 2 |
|
|
484 | 484 | assert_difference 'Issue.count' do |
|
|
485 | 485 | post :new, :project_id => 1, |
|
|
486 | 486 | :issue => {:tracker_id => 1, |
|
|
487 | 487 | :subject => 'This is the test_new issue', |
|
|
488 | 488 | :description => 'This is the description', |
|
|
489 | 489 | :priority_id => 5} |
|
|
490 | 490 | end |
|
|
491 | 491 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
492 | 492 | end |
|
|
493 | 493 | |
|
|
494 | 494 | def test_post_new_with_required_custom_field_and_without_custom_fields_param |
|
|
495 | 495 | field = IssueCustomField.find_by_name('Database') |
|
|
496 | 496 | field.update_attribute(:is_required, true) |
|
|
497 | 497 | |
|
|
498 | 498 | @request.session[:user_id] = 2 |
|
|
499 | 499 | post :new, :project_id => 1, |
|
|
500 | 500 | :issue => {:tracker_id => 1, |
|
|
501 | 501 | :subject => 'This is the test_new issue', |
|
|
502 | 502 | :description => 'This is the description', |
|
|
503 | 503 | :priority_id => 5} |
|
|
504 | 504 | assert_response :success |
|
|
505 | 505 | assert_template 'new' |
|
|
506 | 506 | issue = assigns(:issue) |
|
|
507 | 507 | assert_not_nil issue |
|
|
508 | 508 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) |
|
|
509 | 509 | end |
|
|
510 | 510 | |
|
|
511 | 511 | def test_post_new_with_watchers |
|
|
512 | 512 | @request.session[:user_id] = 2 |
|
|
513 | 513 | ActionMailer::Base.deliveries.clear |
|
|
514 | 514 | |
|
|
515 | 515 | assert_difference 'Watcher.count', 2 do |
|
|
516 | 516 | post :new, :project_id => 1, |
|
|
517 | 517 | :issue => {:tracker_id => 1, |
|
|
518 | 518 | :subject => 'This is a new issue with watchers', |
|
|
519 | 519 | :description => 'This is the description', |
|
|
520 | 520 | :priority_id => 5, |
|
|
521 | 521 | :watcher_user_ids => ['2', '3']} |
|
|
522 | 522 | end |
|
|
523 | 523 | issue = Issue.find_by_subject('This is a new issue with watchers') |
|
|
524 | 524 | assert_not_nil issue |
|
|
525 | 525 | assert_redirected_to :controller => 'issues', :action => 'show', :id => issue |
|
|
526 | 526 | |
|
|
527 | 527 | # Watchers added |
|
|
528 | 528 | assert_equal [2, 3], issue.watcher_user_ids.sort |
|
|
529 | 529 | assert issue.watched_by?(User.find(3)) |
|
|
530 | 530 | # Watchers notified |
|
|
531 | 531 | mail = ActionMailer::Base.deliveries.last |
|
|
532 | 532 | assert_kind_of TMail::Mail, mail |
|
|
533 | 533 | assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail) |
|
|
534 | 534 | end |
|
|
535 | 535 | |
|
|
536 | 536 | def test_post_new_should_send_a_notification |
|
|
537 | 537 | ActionMailer::Base.deliveries.clear |
|
|
538 | 538 | @request.session[:user_id] = 2 |
|
|
539 | 539 | assert_difference 'Issue.count' do |
|
|
540 | 540 | post :new, :project_id => 1, |
|
|
541 | 541 | :issue => {:tracker_id => 3, |
|
|
542 | 542 | :subject => 'This is the test_new issue', |
|
|
543 | 543 | :description => 'This is the description', |
|
|
544 | 544 | :priority_id => 5, |
|
|
545 | 545 | :estimated_hours => '', |
|
|
546 | 546 | :custom_field_values => {'2' => 'Value for field 2'}} |
|
|
547 | 547 | end |
|
|
548 | 548 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
549 | 549 | |
|
|
550 | 550 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
551 | 551 | end |
|
|
552 | 552 | |
|
|
553 | 553 | def test_post_should_preserve_fields_values_on_validation_failure |
|
|
554 | 554 | @request.session[:user_id] = 2 |
|
|
555 | 555 | post :new, :project_id => 1, |
|
|
556 | 556 | :issue => {:tracker_id => 1, |
|
|
557 | 557 | # empty subject |
|
|
558 | 558 | :subject => '', |
|
|
559 | 559 | :description => 'This is a description', |
|
|
560 | 560 | :priority_id => 6, |
|
|
561 | 561 | :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}} |
|
|
562 | 562 | assert_response :success |
|
|
563 | 563 | assert_template 'new' |
|
|
564 | 564 | |
|
|
565 | 565 | assert_tag :textarea, :attributes => { :name => 'issue[description]' }, |
|
|
566 | 566 | :content => 'This is a description' |
|
|
567 | 567 | assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, |
|
|
568 | 568 | :child => { :tag => 'option', :attributes => { :selected => 'selected', |
|
|
569 | 569 | :value => '6' }, |
|
|
570 | 570 | :content => 'High' } |
|
|
571 | 571 | # Custom fields |
|
|
572 | 572 | assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' }, |
|
|
573 | 573 | :child => { :tag => 'option', :attributes => { :selected => 'selected', |
|
|
574 | 574 | :value => 'Oracle' }, |
|
|
575 | 575 | :content => 'Oracle' } |
|
|
576 | 576 | assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]', |
|
|
577 | 577 | :value => 'Value for field 2'} |
|
|
578 | 578 | end |
|
|
579 | 579 | |
|
|
580 | 580 | def test_post_new_should_ignore_non_safe_attributes |
|
|
581 | 581 | @request.session[:user_id] = 2 |
|
|
582 | 582 | assert_nothing_raised do |
|
|
583 | 583 | post :new, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" } |
|
|
584 | 584 | end |
|
|
585 | 585 | end |
|
|
586 | 586 | |
|
|
587 | 587 | def test_copy_issue |
|
|
588 | 588 | @request.session[:user_id] = 2 |
|
|
589 | 589 | get :new, :project_id => 1, :copy_from => 1 |
|
|
590 | 590 | assert_template 'new' |
|
|
591 | 591 | assert_not_nil assigns(:issue) |
|
|
592 | 592 | orig = Issue.find(1) |
|
|
593 | 593 | assert_equal orig.subject, assigns(:issue).subject |
|
|
594 | 594 | end |
|
|
595 | 595 | |
|
|
596 | 596 | def test_get_edit |
|
|
597 | 597 | @request.session[:user_id] = 2 |
|
|
598 | 598 | get :edit, :id => 1 |
|
|
599 | 599 | assert_response :success |
|
|
600 | 600 | assert_template 'edit' |
|
|
601 | 601 | assert_not_nil assigns(:issue) |
|
|
602 | 602 | assert_equal Issue.find(1), assigns(:issue) |
|
|
603 | 603 | end |
|
|
604 | 604 | |
|
|
605 | 605 | def test_get_edit_with_params |
|
|
606 | 606 | @request.session[:user_id] = 2 |
|
|
607 | 607 | get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 } |
|
|
608 | 608 | assert_response :success |
|
|
609 | 609 | assert_template 'edit' |
|
|
610 | 610 | |
|
|
611 | 611 | issue = assigns(:issue) |
|
|
612 | 612 | assert_not_nil issue |
|
|
613 | 613 | |
|
|
614 | 614 | assert_equal 5, issue.status_id |
|
|
615 | 615 | assert_tag :select, :attributes => { :name => 'issue[status_id]' }, |
|
|
616 | 616 | :child => { :tag => 'option', |
|
|
617 | 617 | :content => 'Closed', |
|
|
618 | 618 | :attributes => { :selected => 'selected' } } |
|
|
619 | 619 | |
|
|
620 | 620 | assert_equal 7, issue.priority_id |
|
|
621 | 621 | assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, |
|
|
622 | 622 | :child => { :tag => 'option', |
|
|
623 | 623 | :content => 'Urgent', |
|
|
624 | 624 | :attributes => { :selected => 'selected' } } |
|
|
625 | 625 | end |
|
|
626 | 626 | |
|
|
627 | 627 | def test_update_edit_form |
|
|
628 | 628 | @request.session[:user_id] = 2 |
|
|
629 | 629 | xhr :post, :update_form, :project_id => 1, |
|
|
630 | 630 | :id => 1, |
|
|
631 | 631 | :issue => {:tracker_id => 2, |
|
|
632 | 632 | :subject => 'This is the test_new issue', |
|
|
633 | 633 | :description => 'This is the description', |
|
|
634 | 634 | :priority_id => 5} |
|
|
635 | 635 | assert_response :success |
|
|
636 | 636 | assert_template 'attributes' |
|
|
637 | 637 | |
|
|
638 | 638 | issue = assigns(:issue) |
|
|
639 | 639 | assert_kind_of Issue, issue |
|
|
640 | 640 | assert_equal 1, issue.id |
|
|
641 | 641 | assert_equal 1, issue.project_id |
|
|
642 | 642 | assert_equal 2, issue.tracker_id |
|
|
643 | 643 | assert_equal 'This is the test_new issue', issue.subject |
|
|
644 | 644 | end |
|
|
645 | 645 | |
|
|
646 | 646 | def test_reply_to_issue |
|
|
647 | 647 | @request.session[:user_id] = 2 |
|
|
648 | 648 | get :reply, :id => 1 |
|
|
649 | 649 | assert_response :success |
|
|
650 | 650 | assert_select_rjs :show, "update" |
|
|
651 | 651 | end |
|
|
652 | 652 | |
|
|
653 | 653 | def test_reply_to_note |
|
|
654 | 654 | @request.session[:user_id] = 2 |
|
|
655 | 655 | get :reply, :id => 1, :journal_id => 2 |
|
|
656 | 656 | assert_response :success |
|
|
657 | 657 | assert_select_rjs :show, "update" |
|
|
658 | 658 | end |
|
|
659 | 659 | |
|
|
660 | 660 | def test_post_edit_without_custom_fields_param |
|
|
661 | 661 | @request.session[:user_id] = 2 |
|
|
662 | 662 | ActionMailer::Base.deliveries.clear |
|
|
663 | 663 | |
|
|
664 | 664 | issue = Issue.find(1) |
|
|
665 | 665 | assert_equal '125', issue.custom_value_for(2).value |
|
|
666 | 666 | old_subject = issue.subject |
|
|
667 | 667 | new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' |
|
|
668 | 668 | |
|
|
669 | 669 | assert_difference('Journal.count') do |
|
|
670 | 670 | assert_difference('JournalDetail.count', 2) do |
|
|
671 | 671 | post :edit, :id => 1, :issue => {:subject => new_subject, |
|
|
672 | 672 | :priority_id => '6', |
|
|
673 | 673 | :category_id => '1' # no change |
|
|
674 | 674 | } |
|
|
675 | 675 | end |
|
|
676 | 676 | end |
|
|
677 | 677 | assert_redirected_to :action => 'show', :id => '1' |
|
|
678 | 678 | issue.reload |
|
|
679 | 679 | assert_equal new_subject, issue.subject |
|
|
680 | 680 | # Make sure custom fields were not cleared |
|
|
681 | 681 | assert_equal '125', issue.custom_value_for(2).value |
|
|
682 | 682 | |
|
|
683 | 683 | mail = ActionMailer::Base.deliveries.last |
|
|
684 | 684 | assert_kind_of TMail::Mail, mail |
|
|
685 | 685 | assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]") |
|
|
686 | 686 | assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}") |
|
|
687 | 687 | end |
|
|
688 | 688 | |
|
|
689 | 689 | def test_post_edit_with_custom_field_change |
|
|
690 | 690 | @request.session[:user_id] = 2 |
|
|
691 | 691 | issue = Issue.find(1) |
|
|
692 | 692 | assert_equal '125', issue.custom_value_for(2).value |
|
|
693 | 693 | |
|
|
694 | 694 | assert_difference('Journal.count') do |
|
|
695 | 695 | assert_difference('JournalDetail.count', 3) do |
|
|
696 | 696 | post :edit, :id => 1, :issue => {:subject => 'Custom field change', |
|
|
697 | 697 | :priority_id => '6', |
|
|
698 | 698 | :category_id => '1', # no change |
|
|
699 | 699 | :custom_field_values => { '2' => 'New custom value' } |
|
|
700 | 700 | } |
|
|
701 | 701 | end |
|
|
702 | 702 | end |
|
|
703 | 703 | assert_redirected_to :action => 'show', :id => '1' |
|
|
704 | 704 | issue.reload |
|
|
705 | 705 | assert_equal 'New custom value', issue.custom_value_for(2).value |
|
|
706 | 706 | |
|
|
707 | 707 | mail = ActionMailer::Base.deliveries.last |
|
|
708 | 708 | assert_kind_of TMail::Mail, mail |
|
|
709 | 709 | assert mail.body.include?("Searchable field changed from 125 to New custom value") |
|
|
710 | 710 | end |
|
|
711 | 711 | |
|
|
712 | 712 | def test_post_edit_with_status_and_assignee_change |
|
|
713 | 713 | issue = Issue.find(1) |
|
|
714 | 714 | assert_equal 1, issue.status_id |
|
|
715 | 715 | @request.session[:user_id] = 2 |
|
|
716 | 716 | assert_difference('TimeEntry.count', 0) do |
|
|
717 | 717 | post :edit, |
|
|
718 | 718 | :id => 1, |
|
|
719 | 719 | :issue => { :status_id => 2, :assigned_to_id => 3 }, |
|
|
720 | 720 | :notes => 'Assigned to dlopper', |
|
|
721 | 721 | :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first } |
|
|
722 | 722 | end |
|
|
723 | 723 | assert_redirected_to :action => 'show', :id => '1' |
|
|
724 | 724 | issue.reload |
|
|
725 | 725 | assert_equal 2, issue.status_id |
|
|
726 | 726 | j = Journal.find(:first, :order => 'id DESC') |
|
|
727 | 727 | assert_equal 'Assigned to dlopper', j.notes |
|
|
728 | 728 | assert_equal 2, j.details.size |
|
|
729 | 729 | |
|
|
730 | 730 | mail = ActionMailer::Base.deliveries.last |
|
|
731 | 731 | assert mail.body.include?("Status changed from New to Assigned") |
|
|
732 | 732 | # subject should contain the new status |
|
|
733 | 733 | assert mail.subject.include?("(#{ IssueStatus.find(2).name })") |
|
|
734 | 734 | end |
|
|
735 | 735 | |
|
|
736 | 736 | def test_post_edit_with_note_only |
|
|
737 | 737 | notes = 'Note added by IssuesControllerTest#test_update_with_note_only' |
|
|
738 | 738 | # anonymous user |
|
|
739 | 739 | post :edit, |
|
|
740 | 740 | :id => 1, |
|
|
741 | 741 | :notes => notes |
|
|
742 | 742 | assert_redirected_to :action => 'show', :id => '1' |
|
|
743 | 743 | j = Journal.find(:first, :order => 'id DESC') |
|
|
744 | 744 | assert_equal notes, j.notes |
|
|
745 | 745 | assert_equal 0, j.details.size |
|
|
746 | 746 | assert_equal User.anonymous, j.user |
|
|
747 | 747 | |
|
|
748 | 748 | mail = ActionMailer::Base.deliveries.last |
|
|
749 | 749 | assert mail.body.include?(notes) |
|
|
750 | 750 | end |
|
|
751 | 751 | |
|
|
752 | 752 | def test_post_edit_with_note_and_spent_time |
|
|
753 | 753 | @request.session[:user_id] = 2 |
|
|
754 | 754 | spent_hours_before = Issue.find(1).spent_hours |
|
|
755 | 755 | assert_difference('TimeEntry.count') do |
|
|
756 | 756 | post :edit, |
|
|
757 | 757 | :id => 1, |
|
|
758 | 758 | :notes => '2.5 hours added', |
|
|
759 | 759 | :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first } |
|
|
760 | 760 | end |
|
|
761 | 761 | assert_redirected_to :action => 'show', :id => '1' |
|
|
762 | 762 | |
|
|
763 | 763 | issue = Issue.find(1) |
|
|
764 | 764 | |
|
|
765 | 765 | j = Journal.find(:first, :order => 'id DESC') |
|
|
766 | 766 | assert_equal '2.5 hours added', j.notes |
|
|
767 | 767 | assert_equal 0, j.details.size |
|
|
768 | 768 | |
|
|
769 | 769 | t = issue.time_entries.find(:first, :order => 'id DESC') |
|
|
770 | 770 | assert_not_nil t |
|
|
771 | 771 | assert_equal 2.5, t.hours |
|
|
772 | 772 | assert_equal spent_hours_before + 2.5, issue.spent_hours |
|
|
773 | 773 | end |
|
|
774 | 774 | |
|
|
775 | 775 | def test_post_edit_with_attachment_only |
|
|
776 | 776 | set_tmp_attachments_directory |
|
|
777 | 777 | |
|
|
778 | 778 | # Delete all fixtured journals, a race condition can occur causing the wrong |
|
|
779 | 779 | # journal to get fetched in the next find. |
|
|
780 | 780 | Journal.delete_all |
|
|
781 | 781 | |
|
|
782 | 782 | # anonymous user |
|
|
783 | 783 | post :edit, |
|
|
784 | 784 | :id => 1, |
|
|
785 | 785 | :notes => '', |
|
|
786 | 786 | :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} |
|
|
787 | 787 | assert_redirected_to :action => 'show', :id => '1' |
|
|
788 | 788 | j = Issue.find(1).journals.find(:first, :order => 'id DESC') |
|
|
789 | 789 | assert j.notes.blank? |
|
|
790 | 790 | assert_equal 1, j.details.size |
|
|
791 | 791 | assert_equal 'testfile.txt', j.details.first.value |
|
|
792 | 792 | assert_equal User.anonymous, j.user |
|
|
793 | 793 | |
|
|
794 | 794 | mail = ActionMailer::Base.deliveries.last |
|
|
795 | 795 | assert mail.body.include?('testfile.txt') |
|
|
796 | 796 | end |
|
|
797 | 797 | |
|
|
798 | 798 | def test_post_edit_with_no_change |
|
|
799 | 799 | issue = Issue.find(1) |
|
|
800 | 800 | issue.journals.clear |
|
|
801 | 801 | ActionMailer::Base.deliveries.clear |
|
|
802 | 802 | |
|
|
803 | 803 | post :edit, |
|
|
804 | 804 | :id => 1, |
|
|
805 | 805 | :notes => '' |
|
|
806 | 806 | assert_redirected_to :action => 'show', :id => '1' |
|
|
807 | 807 | |
|
|
808 | 808 | issue.reload |
|
|
809 | 809 | assert issue.journals.empty? |
|
|
810 | 810 | # No email should be sent |
|
|
811 | 811 | assert ActionMailer::Base.deliveries.empty? |
|
|
812 | 812 | end |
|
|
813 | 813 | |
|
|
814 | 814 | def test_post_edit_should_send_a_notification |
|
|
815 | 815 | @request.session[:user_id] = 2 |
|
|
816 | 816 | ActionMailer::Base.deliveries.clear |
|
|
817 | 817 | issue = Issue.find(1) |
|
|
818 | 818 | old_subject = issue.subject |
|
|
819 | 819 | new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' |
|
|
820 | 820 | |
|
|
821 | 821 | post :edit, :id => 1, :issue => {:subject => new_subject, |
|
|
822 | 822 | :priority_id => '6', |
|
|
823 | 823 | :category_id => '1' # no change |
|
|
824 | 824 | } |
|
|
825 | 825 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
826 | 826 | end |
|
|
827 | 827 | |
|
|
828 | 828 | def test_post_edit_with_invalid_spent_time |
|
|
829 | 829 | @request.session[:user_id] = 2 |
|
|
830 | 830 | notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time' |
|
|
831 | 831 | |
|
|
832 | 832 | assert_no_difference('Journal.count') do |
|
|
833 | 833 | post :edit, |
|
|
834 | 834 | :id => 1, |
|
|
835 | 835 | :notes => notes, |
|
|
836 | 836 | :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"} |
|
|
837 | 837 | end |
|
|
838 | 838 | assert_response :success |
|
|
839 | 839 | assert_template 'edit' |
|
|
840 | 840 | |
|
|
841 | 841 | assert_tag :textarea, :attributes => { :name => 'notes' }, |
|
|
842 | 842 | :content => notes |
|
|
843 | 843 | assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" } |
|
|
844 | 844 | end |
|
|
845 | 845 | |
|
|
846 | 846 | def test_post_edit_should_allow_fixed_version_to_be_set_to_a_subproject |
|
|
847 | 847 | issue = Issue.find(2) |
|
|
848 | 848 | @request.session[:user_id] = 2 |
|
|
849 | 849 | |
|
|
850 | 850 | post :edit, |
|
|
851 | 851 | :id => issue.id, |
|
|
852 | 852 | :issue => { |
|
|
853 | 853 | :fixed_version_id => 4 |
|
|
854 | 854 | } |
|
|
855 | 855 | |
|
|
856 | 856 | assert_response :redirect |
|
|
857 | 857 | issue.reload |
|
|
858 | 858 | assert_equal 4, issue.fixed_version_id |
|
|
859 | 859 | assert_not_equal issue.project_id, issue.fixed_version.project_id |
|
|
860 | 860 | end |
|
|
861 | 861 | |
|
|
862 | 862 | def test_post_edit_should_redirect_back_using_the_back_url_parameter |
|
|
863 | 863 | issue = Issue.find(2) |
|
|
864 | 864 | @request.session[:user_id] = 2 |
|
|
865 | 865 | |
|
|
866 | 866 | post :edit, |
|
|
867 | 867 | :id => issue.id, |
|
|
868 | 868 | :issue => { |
|
|
869 | 869 | :fixed_version_id => 4 |
|
|
870 | 870 | }, |
|
|
871 | 871 | :back_url => '/issues' |
|
|
872 | 872 | |
|
|
873 | 873 | assert_response :redirect |
|
|
874 | 874 | assert_redirected_to '/issues' |
|
|
875 | 875 | end |
|
|
876 | 876 | |
|
|
877 | 877 | def test_post_edit_should_not_redirect_back_using_the_back_url_parameter_off_the_host |
|
|
878 | 878 | issue = Issue.find(2) |
|
|
879 | 879 | @request.session[:user_id] = 2 |
|
|
880 | 880 | |
|
|
881 | 881 | post :edit, |
|
|
882 | 882 | :id => issue.id, |
|
|
883 | 883 | :issue => { |
|
|
884 | 884 | :fixed_version_id => 4 |
|
|
885 | 885 | }, |
|
|
886 | 886 | :back_url => 'http://google.com' |
|
|
887 | 887 | |
|
|
888 | 888 | assert_response :redirect |
|
|
889 | 889 | assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id |
|
|
890 | 890 | end |
|
|
891 | 891 | |
|
|
892 | 892 | def test_get_bulk_edit |
|
|
893 | 893 | @request.session[:user_id] = 2 |
|
|
894 | 894 | get :bulk_edit, :ids => [1, 2] |
|
|
895 | 895 | assert_response :success |
|
|
896 | 896 | assert_template 'bulk_edit' |
|
|
897 | 897 | |
|
|
898 | 898 | # Project specific custom field, date type |
|
|
899 | 899 | field = CustomField.find(9) |
|
|
900 | 900 | assert !field.is_for_all? |
|
|
901 | 901 | assert_equal 'date', field.field_format |
|
|
902 | assert_tag :input, :attributes => {:name => 'custom_field_values[9]'} | |
|
|
902 | assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'} | |
|
|
903 | 903 | |
|
|
904 | 904 | # System wide custom field |
|
|
905 | 905 | assert CustomField.find(1).is_for_all? |
|
|
906 | assert_tag :select, :attributes => {:name => 'custom_field_values[1]'} | |
|
|
906 | assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'} | |
|
|
907 | 907 | end |
|
|
908 | 908 | |
|
|
909 | 909 | def test_bulk_edit |
|
|
910 | 910 | @request.session[:user_id] = 2 |
|
|
911 | 911 | # update issues priority |
|
|
912 |
post :bulk_edit, :ids => [1, 2], : |
|
|
|
912 | post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing', | |
|
|
913 | :issue => {:priority_id => 7, | |
|
|
913 | 914 | :assigned_to_id => '', |
|
|
914 |
:custom_field_values => {'2' => ''} |
|
|
|
915 |
|
|
|
|
915 | :custom_field_values => {'2' => ''}} | |
|
|
916 | ||
|
|
916 | 917 | assert_response 302 |
|
|
917 | 918 | # check that the issues were updated |
|
|
918 | 919 | assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id} |
|
|
919 | 920 | |
|
|
920 | 921 | issue = Issue.find(1) |
|
|
921 | 922 | journal = issue.journals.find(:first, :order => 'created_on DESC') |
|
|
922 | 923 | assert_equal '125', issue.custom_value_for(2).value |
|
|
923 | 924 | assert_equal 'Bulk editing', journal.notes |
|
|
924 | 925 | assert_equal 1, journal.details.size |
|
|
925 | 926 | end |
|
|
926 | 927 | |
|
|
927 | 928 | def test_bullk_edit_should_send_a_notification |
|
|
928 | 929 | @request.session[:user_id] = 2 |
|
|
929 | 930 | ActionMailer::Base.deliveries.clear |
|
|
930 | 931 | post(:bulk_edit, |
|
|
931 | 932 | { |
|
|
932 | 933 | :ids => [1, 2], |
|
|
934 | :notes => 'Bulk editing', | |
|
|
935 | :issue => { | |
|
|
933 | 936 | :priority_id => 7, |
|
|
934 | 937 | :assigned_to_id => '', |
|
|
935 |
:custom_field_values => {'2' => ''} |
|
|
|
936 | :notes => 'Bulk editing' | |
|
|
938 | :custom_field_values => {'2' => ''} | |
|
|
939 | } | |
|
|
937 | 940 | }) |
|
|
938 | 941 | |
|
|
939 | 942 | assert_response 302 |
|
|
940 | 943 | assert_equal 2, ActionMailer::Base.deliveries.size |
|
|
941 | 944 | end |
|
|
942 | 945 | |
|
|
943 | 946 | def test_bulk_edit_status |
|
|
944 | 947 | @request.session[:user_id] = 2 |
|
|
945 | 948 | # update issues priority |
|
|
946 |
post :bulk_edit, :ids => [1, 2], : |
|
|
|
949 | post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing status', | |
|
|
950 | :issue => {:priority_id => '', | |
|
|
947 | 951 | :assigned_to_id => '', |
|
|
948 |
:status_id => '5' |
|
|
|
949 |
|
|
|
|
952 | :status_id => '5'} | |
|
|
953 | ||
|
|
950 | 954 | assert_response 302 |
|
|
951 | 955 | issue = Issue.find(1) |
|
|
952 | 956 | assert issue.closed? |
|
|
953 | 957 | end |
|
|
954 | 958 | |
|
|
955 | 959 | def test_bulk_edit_custom_field |
|
|
956 | 960 | @request.session[:user_id] = 2 |
|
|
957 | 961 | # update issues priority |
|
|
958 |
post :bulk_edit, :ids => [1, 2], : |
|
|
|
962 | post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing custom field', | |
|
|
963 | :issue => {:priority_id => '', | |
|
|
959 | 964 | :assigned_to_id => '', |
|
|
960 |
:custom_field_values => {'2' => '777'} |
|
|
|
961 |
|
|
|
|
965 | :custom_field_values => {'2' => '777'}} | |
|
|
966 | ||
|
|
962 | 967 | assert_response 302 |
|
|
963 | 968 | |
|
|
964 | 969 | issue = Issue.find(1) |
|
|
965 | 970 | journal = issue.journals.find(:first, :order => 'created_on DESC') |
|
|
966 | 971 | assert_equal '777', issue.custom_value_for(2).value |
|
|
967 | 972 | assert_equal 1, journal.details.size |
|
|
968 | 973 | assert_equal '125', journal.details.first.old_value |
|
|
969 | 974 | assert_equal '777', journal.details.first.value |
|
|
970 | 975 | end |
|
|
971 | 976 | |
|
|
972 | 977 | def test_bulk_unassign |
|
|
973 | 978 | assert_not_nil Issue.find(2).assigned_to |
|
|
974 | 979 | @request.session[:user_id] = 2 |
|
|
975 | 980 | # unassign issues |
|
|
976 |
|
|
|
|
981 | post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'} | |
|
|
977 | 982 | assert_response 302 |
|
|
978 | 983 | # check that the issues were updated |
|
|
979 | 984 | assert_nil Issue.find(2).assigned_to |
|
|
980 | 985 | end |
|
|
981 | 986 | |
|
|
982 | 987 | def test_post_bulk_edit_should_allow_fixed_version_to_be_set_to_a_subproject |
|
|
983 | 988 | @request.session[:user_id] = 2 |
|
|
984 | 989 | |
|
|
985 | post :bulk_edit, | |
|
|
986 | :ids => [1,2], | |
|
|
987 | :fixed_version_id => 4 | |
|
|
990 | post :bulk_edit, :ids => [1,2], :issue => {:fixed_version_id => 4} | |
|
|
988 | 991 | |
|
|
989 | 992 | assert_response :redirect |
|
|
990 | 993 | issues = Issue.find([1,2]) |
|
|
991 | 994 | issues.each do |issue| |
|
|
992 | 995 | assert_equal 4, issue.fixed_version_id |
|
|
993 | 996 | assert_not_equal issue.project_id, issue.fixed_version.project_id |
|
|
994 | 997 | end |
|
|
995 | 998 | end |
|
|
996 | 999 | |
|
|
997 | 1000 | def test_post_bulk_edit_should_redirect_back_using_the_back_url_parameter |
|
|
998 | 1001 | @request.session[:user_id] = 2 |
|
|
999 | 1002 | post :bulk_edit, :ids => [1,2], :back_url => '/issues' |
|
|
1000 | 1003 | |
|
|
1001 | 1004 | assert_response :redirect |
|
|
1002 | 1005 | assert_redirected_to '/issues' |
|
|
1003 | 1006 | end |
|
|
1004 | 1007 | |
|
|
1005 | 1008 | def test_post_bulk_edit_should_not_redirect_back_using_the_back_url_parameter_off_the_host |
|
|
1006 | 1009 | @request.session[:user_id] = 2 |
|
|
1007 | 1010 | post :bulk_edit, :ids => [1,2], :back_url => 'http://google.com' |
|
|
1008 | 1011 | |
|
|
1009 | 1012 | assert_response :redirect |
|
|
1010 | 1013 | assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier |
|
|
1011 | 1014 | end |
|
|
1012 | 1015 | |
|
|
1013 | 1016 | def test_move_one_issue_to_another_project |
|
|
1014 | 1017 | @request.session[:user_id] = 2 |
|
|
1015 | 1018 | post :move, :id => 1, :new_project_id => 2, :tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => '' |
|
|
1016 | 1019 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1017 | 1020 | assert_equal 2, Issue.find(1).project_id |
|
|
1018 | 1021 | end |
|
|
1019 | 1022 | |
|
|
1020 | 1023 | def test_move_one_issue_to_another_project_should_follow_when_needed |
|
|
1021 | 1024 | @request.session[:user_id] = 2 |
|
|
1022 | 1025 | post :move, :id => 1, :new_project_id => 2, :follow => '1' |
|
|
1023 | 1026 | assert_redirected_to '/issues/1' |
|
|
1024 | 1027 | end |
|
|
1025 | 1028 | |
|
|
1026 | 1029 | def test_bulk_move_to_another_project |
|
|
1027 | 1030 | @request.session[:user_id] = 2 |
|
|
1028 | 1031 | post :move, :ids => [1, 2], :new_project_id => 2 |
|
|
1029 | 1032 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1030 | 1033 | # Issues moved to project 2 |
|
|
1031 | 1034 | assert_equal 2, Issue.find(1).project_id |
|
|
1032 | 1035 | assert_equal 2, Issue.find(2).project_id |
|
|
1033 | 1036 | # No tracker change |
|
|
1034 | 1037 | assert_equal 1, Issue.find(1).tracker_id |
|
|
1035 | 1038 | assert_equal 2, Issue.find(2).tracker_id |
|
|
1036 | 1039 | end |
|
|
1037 | 1040 | |
|
|
1038 | 1041 | def test_bulk_move_to_another_tracker |
|
|
1039 | 1042 | @request.session[:user_id] = 2 |
|
|
1040 | 1043 | post :move, :ids => [1, 2], :new_tracker_id => 2 |
|
|
1041 | 1044 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1042 | 1045 | assert_equal 2, Issue.find(1).tracker_id |
|
|
1043 | 1046 | assert_equal 2, Issue.find(2).tracker_id |
|
|
1044 | 1047 | end |
|
|
1045 | 1048 | |
|
|
1046 | 1049 | def test_bulk_copy_to_another_project |
|
|
1047 | 1050 | @request.session[:user_id] = 2 |
|
|
1048 | 1051 | assert_difference 'Issue.count', 2 do |
|
|
1049 | 1052 | assert_no_difference 'Project.find(1).issues.count' do |
|
|
1050 | 1053 | post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'} |
|
|
1051 | 1054 | end |
|
|
1052 | 1055 | end |
|
|
1053 | 1056 | assert_redirected_to 'projects/ecookbook/issues' |
|
|
1054 | 1057 | end |
|
|
1055 | 1058 | |
|
|
1056 | 1059 | context "#move via bulk copy" do |
|
|
1057 | 1060 | should "allow not changing the issue's attributes" do |
|
|
1058 | 1061 | @request.session[:user_id] = 2 |
|
|
1059 | 1062 | issue_before_move = Issue.find(1) |
|
|
1060 | 1063 | assert_difference 'Issue.count', 1 do |
|
|
1061 | 1064 | assert_no_difference 'Project.find(1).issues.count' do |
|
|
1062 | 1065 | post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => '' |
|
|
1063 | 1066 | end |
|
|
1064 | 1067 | end |
|
|
1065 | 1068 | issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2}) |
|
|
1066 | 1069 | assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id |
|
|
1067 | 1070 | assert_equal issue_before_move.status_id, issue_after_move.status_id |
|
|
1068 | 1071 | assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id |
|
|
1069 | 1072 | end |
|
|
1070 | 1073 | |
|
|
1071 | 1074 | should "allow changing the issue's attributes" do |
|
|
1072 | 1075 | @request.session[:user_id] = 2 |
|
|
1073 | 1076 | assert_difference 'Issue.count', 2 do |
|
|
1074 | 1077 | assert_no_difference 'Project.find(1).issues.count' do |
|
|
1075 | 1078 | post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => 4, :status_id => 3, :start_date => '2009-12-01', :due_date => '2009-12-31' |
|
|
1076 | 1079 | end |
|
|
1077 | 1080 | end |
|
|
1078 | 1081 | |
|
|
1079 | 1082 | copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2}) |
|
|
1080 | 1083 | assert_equal 2, copied_issues.size |
|
|
1081 | 1084 | copied_issues.each do |issue| |
|
|
1082 | 1085 | assert_equal 2, issue.project_id, "Project is incorrect" |
|
|
1083 | 1086 | assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect" |
|
|
1084 | 1087 | assert_equal 3, issue.status_id, "Status is incorrect" |
|
|
1085 | 1088 | assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect" |
|
|
1086 | 1089 | assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect" |
|
|
1087 | 1090 | end |
|
|
1088 | 1091 | end |
|
|
1089 | 1092 | end |
|
|
1090 | 1093 | |
|
|
1091 | 1094 | def test_copy_to_another_project_should_follow_when_needed |
|
|
1092 | 1095 | @request.session[:user_id] = 2 |
|
|
1093 | 1096 | post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1' |
|
|
1094 | 1097 | issue = Issue.first(:order => 'id DESC') |
|
|
1095 | 1098 | assert_redirected_to :controller => 'issues', :action => 'show', :id => issue |
|
|
1096 | 1099 | end |
|
|
1097 | 1100 | |
|
|
1098 | 1101 | def test_context_menu_one_issue |
|
|
1099 | 1102 | @request.session[:user_id] = 2 |
|
|
1100 | 1103 | get :context_menu, :ids => [1] |
|
|
1101 | 1104 | assert_response :success |
|
|
1102 | 1105 | assert_template 'context_menu' |
|
|
1103 | 1106 | assert_tag :tag => 'a', :content => 'Edit', |
|
|
1104 | 1107 | :attributes => { :href => '/issues/1/edit', |
|
|
1105 | 1108 | :class => 'icon-edit' } |
|
|
1106 | 1109 | assert_tag :tag => 'a', :content => 'Closed', |
|
|
1107 | 1110 | :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5', |
|
|
1108 | 1111 | :class => '' } |
|
|
1109 | 1112 | assert_tag :tag => 'a', :content => 'Immediate', |
|
|
1110 | 1113 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&priority_id=8', |
|
|
1111 | 1114 | :class => '' } |
|
|
1112 | 1115 | # Versions |
|
|
1113 | 1116 | assert_tag :tag => 'a', :content => '2.0', |
|
|
1114 | 1117 | :attributes => { :href => '/issues/bulk_edit?fixed_version_id=3&ids%5B%5D=1', |
|
|
1115 | 1118 | :class => '' } |
|
|
1116 | 1119 | assert_tag :tag => 'a', :content => 'eCookbook Subproject 1 - 2.0', |
|
|
1117 | 1120 | :attributes => { :href => '/issues/bulk_edit?fixed_version_id=4&ids%5B%5D=1', |
|
|
1118 | 1121 | :class => '' } |
|
|
1119 | 1122 | |
|
|
1120 | 1123 | assert_tag :tag => 'a', :content => 'Dave Lopper', |
|
|
1121 | 1124 | :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&ids%5B%5D=1', |
|
|
1122 | 1125 | :class => '' } |
|
|
1123 | 1126 | assert_tag :tag => 'a', :content => 'Duplicate', |
|
|
1124 | 1127 | :attributes => { :href => '/projects/ecookbook/issues/1/copy', |
|
|
1125 | 1128 | :class => 'icon-duplicate' } |
|
|
1126 | 1129 | assert_tag :tag => 'a', :content => 'Copy', |
|
|
1127 | 1130 | :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&ids%5B%5D=1', |
|
|
1128 | 1131 | :class => 'icon-copy' } |
|
|
1129 | 1132 | assert_tag :tag => 'a', :content => 'Move', |
|
|
1130 | 1133 | :attributes => { :href => '/issues/move?ids%5B%5D=1', |
|
|
1131 | 1134 | :class => 'icon-move' } |
|
|
1132 | 1135 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1133 | 1136 | :attributes => { :href => '/issues/destroy?ids%5B%5D=1', |
|
|
1134 | 1137 | :class => 'icon-del' } |
|
|
1135 | 1138 | end |
|
|
1136 | 1139 | |
|
|
1137 | 1140 | def test_context_menu_one_issue_by_anonymous |
|
|
1138 | 1141 | get :context_menu, :ids => [1] |
|
|
1139 | 1142 | assert_response :success |
|
|
1140 | 1143 | assert_template 'context_menu' |
|
|
1141 | 1144 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1142 | 1145 | :attributes => { :href => '#', |
|
|
1143 | 1146 | :class => 'icon-del disabled' } |
|
|
1144 | 1147 | end |
|
|
1145 | 1148 | |
|
|
1146 | 1149 | def test_context_menu_multiple_issues_of_same_project |
|
|
1147 | 1150 | @request.session[:user_id] = 2 |
|
|
1148 | 1151 | get :context_menu, :ids => [1, 2] |
|
|
1149 | 1152 | assert_response :success |
|
|
1150 | 1153 | assert_template 'context_menu' |
|
|
1151 | 1154 | assert_tag :tag => 'a', :content => 'Edit', |
|
|
1152 | 1155 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1153 | 1156 | :class => 'icon-edit' } |
|
|
1154 | 1157 | assert_tag :tag => 'a', :content => 'Immediate', |
|
|
1155 | 1158 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&ids%5B%5D=2&priority_id=8', |
|
|
1156 | 1159 | :class => '' } |
|
|
1157 | 1160 | assert_tag :tag => 'a', :content => 'Dave Lopper', |
|
|
1158 | 1161 | :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&ids%5B%5D=1&ids%5B%5D=2', |
|
|
1159 | 1162 | :class => '' } |
|
|
1160 | 1163 | assert_tag :tag => 'a', :content => 'Copy', |
|
|
1161 | 1164 | :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&ids%5B%5D=1&ids%5B%5D=2', |
|
|
1162 | 1165 | :class => 'icon-copy' } |
|
|
1163 | 1166 | assert_tag :tag => 'a', :content => 'Move', |
|
|
1164 | 1167 | :attributes => { :href => '/issues/move?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1165 | 1168 | :class => 'icon-move' } |
|
|
1166 | 1169 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1167 | 1170 | :attributes => { :href => '/issues/destroy?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1168 | 1171 | :class => 'icon-del' } |
|
|
1169 | 1172 | end |
|
|
1170 | 1173 | |
|
|
1171 | 1174 | def test_context_menu_multiple_issues_of_different_project |
|
|
1172 | 1175 | @request.session[:user_id] = 2 |
|
|
1173 | 1176 | get :context_menu, :ids => [1, 2, 4] |
|
|
1174 | 1177 | assert_response :success |
|
|
1175 | 1178 | assert_template 'context_menu' |
|
|
1176 | 1179 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1177 | 1180 | :attributes => { :href => '#', |
|
|
1178 | 1181 | :class => 'icon-del disabled' } |
|
|
1179 | 1182 | end |
|
|
1180 | 1183 | |
|
|
1181 | 1184 | def test_destroy_issue_with_no_time_entries |
|
|
1182 | 1185 | assert_nil TimeEntry.find_by_issue_id(2) |
|
|
1183 | 1186 | @request.session[:user_id] = 2 |
|
|
1184 | 1187 | post :destroy, :id => 2 |
|
|
1185 | 1188 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1186 | 1189 | assert_nil Issue.find_by_id(2) |
|
|
1187 | 1190 | end |
|
|
1188 | 1191 | |
|
|
1189 | 1192 | def test_destroy_issues_with_time_entries |
|
|
1190 | 1193 | @request.session[:user_id] = 2 |
|
|
1191 | 1194 | post :destroy, :ids => [1, 3] |
|
|
1192 | 1195 | assert_response :success |
|
|
1193 | 1196 | assert_template 'destroy' |
|
|
1194 | 1197 | assert_not_nil assigns(:hours) |
|
|
1195 | 1198 | assert Issue.find_by_id(1) && Issue.find_by_id(3) |
|
|
1196 | 1199 | end |
|
|
1197 | 1200 | |
|
|
1198 | 1201 | def test_destroy_issues_and_destroy_time_entries |
|
|
1199 | 1202 | @request.session[:user_id] = 2 |
|
|
1200 | 1203 | post :destroy, :ids => [1, 3], :todo => 'destroy' |
|
|
1201 | 1204 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1202 | 1205 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1203 | 1206 | assert_nil TimeEntry.find_by_id([1, 2]) |
|
|
1204 | 1207 | end |
|
|
1205 | 1208 | |
|
|
1206 | 1209 | def test_destroy_issues_and_assign_time_entries_to_project |
|
|
1207 | 1210 | @request.session[:user_id] = 2 |
|
|
1208 | 1211 | post :destroy, :ids => [1, 3], :todo => 'nullify' |
|
|
1209 | 1212 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1210 | 1213 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1211 | 1214 | assert_nil TimeEntry.find(1).issue_id |
|
|
1212 | 1215 | assert_nil TimeEntry.find(2).issue_id |
|
|
1213 | 1216 | end |
|
|
1214 | 1217 | |
|
|
1215 | 1218 | def test_destroy_issues_and_reassign_time_entries_to_another_issue |
|
|
1216 | 1219 | @request.session[:user_id] = 2 |
|
|
1217 | 1220 | post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2 |
|
|
1218 | 1221 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1219 | 1222 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1220 | 1223 | assert_equal 2, TimeEntry.find(1).issue_id |
|
|
1221 | 1224 | assert_equal 2, TimeEntry.find(2).issue_id |
|
|
1222 | 1225 | end |
|
|
1223 | 1226 | |
|
|
1224 | 1227 | def test_default_search_scope |
|
|
1225 | 1228 | get :index |
|
|
1226 | 1229 | assert_tag :div, :attributes => {:id => 'quick-search'}, |
|
|
1227 | 1230 | :child => {:tag => 'form', |
|
|
1228 | 1231 | :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}} |
|
|
1229 | 1232 | end |
|
|
1230 | 1233 | end |
General Comments 0
You need to be logged in to leave comments.
Login now