jro_apps/redmine Commit - r2317:e1f96ca4db64

Replaces the obsolete robots.txt with a cached action (#2491)....

Jean-Philippe Lang -

r2317:e1f96ca4db64

parent child

Context file:

r2317:e1f96ca4db64

app/views/welcome/robots.rhtml created 644 +9 0

@@ -0,0 +1,9
	1	User-agent: *
	2	<% @projects.each do \|p\| -%>
	3	Disallow: /projects/<%= p.to_param %>/repository
	4	Disallow: /projects/<%= p.to_param %>/issues
	5	Disallow: /projects/<%= p.to_param %>/activity
	6	<% end -%>
	7	Disallow: /issues/gantt
	8	Disallow: /issues/calendar
	9	Disallow: /activity

app/controllers/projects_controller.rb +6 0

               before_filter :require_admin, :only => [ :add, :archive, :unarchive, :destroy ]
               accept_key_auth :activity
+              after_filter :only => [:add, :edit, :archive, :unarchive, :destroy] do |controller|
+                if controller.request.post?
+                  controller.send :expire_action, :controller => 'welcome', :action => 'robots.txt'
+                end
+              end
               helper :sort
               include SortHelper
               helper :custom_fields

app/controllers/welcome_controller.rb +6 0

             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class WelcomeController < ApplicationController
+              caches_action :robots
               def index
                 @news = News.latest User.current
                 @projects = Project.latest User.current
               end
+              def robots
+                @projects = Project.public.active
+                render :layout => false, :content_type => 'text/plain'
+              end
             end

app/models/project.rb +1 0

               named_scope :has_module, lambda { |mod| { :conditions => ["#{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name=?)", mod.to_s] } }
               named_scope :active, { :conditions => "#{Project.table_name}.status = #{STATUS_ACTIVE}"}
+              named_scope :public, { :conditions => { :is_public => true } }
               named_scope :visible, lambda { { :conditions => Project.visible_by(User.current) } }
               def identifier=(identifier)

config/routes.rb +1 0

               # Install the default route as the lowest priority.
               map.connect ':controller/:action/:id'
+              map.connect 'robots.txt', :controller => 'welcome', :action => 'robots'
             end

test/functional/welcome_controller_test.rb +7 0

@@ -60,4 +60,11 class WelcomeControllerTest < Test::Unit::TestCase
60	get :index	60	get :index
61	assert_equal :fr, @controller.current_language	61	assert_equal :fr, @controller.current_language
62	end	62	end
		63
		64	def test_robots
		65	get :robots
		66	assert_response :success
		67	assert_equal 'text/plain', @response.content_type
		68	assert @response.body.match(%r{^Disallow: /projects/ecookbook/issues$})
		69	end
63	end	70	end

public/robots.txt removed 0 -4

NO CONTENT: file was removed

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages