| @@ -1,533 +1,537 | |||
|
|
1 | 1 | # Redmine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2008 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | class IssuesController < ApplicationController |
|
|
19 | 19 | menu_item :new_issue, :only => :new |
|
|
20 | 20 | default_search_scope :issues |
|
|
21 | 21 | |
|
|
22 | 22 | before_filter :find_issue, :only => [:show, :edit, :reply] |
|
|
23 | 23 | before_filter :find_issues, :only => [:bulk_edit, :move, :destroy] |
|
|
24 | 24 | before_filter :find_project, :only => [:new, :update_form, :preview] |
|
|
25 | 25 | before_filter :authorize, :except => [:index, :changes, :gantt, :calendar, :preview, :context_menu] |
|
|
26 | 26 | before_filter :find_optional_project, :only => [:index, :changes, :gantt, :calendar] |
|
|
27 | 27 | accept_key_auth :index, :show, :changes |
|
|
28 | 28 | |
|
|
29 | 29 | rescue_from Query::StatementInvalid, :with => :query_statement_invalid |
|
|
30 | 30 | |
|
|
31 | 31 | helper :journals |
|
|
32 | 32 | helper :projects |
|
|
33 | 33 | include ProjectsHelper |
|
|
34 | 34 | helper :custom_fields |
|
|
35 | 35 | include CustomFieldsHelper |
|
|
36 | 36 | helper :issue_relations |
|
|
37 | 37 | include IssueRelationsHelper |
|
|
38 | 38 | helper :watchers |
|
|
39 | 39 | include WatchersHelper |
|
|
40 | 40 | helper :attachments |
|
|
41 | 41 | include AttachmentsHelper |
|
|
42 | 42 | helper :queries |
|
|
43 | 43 | helper :sort |
|
|
44 | 44 | include SortHelper |
|
|
45 | 45 | include IssuesHelper |
|
|
46 | 46 | helper :timelog |
|
|
47 | 47 | include Redmine::Export::PDF |
|
|
48 | 48 | |
|
|
49 | 49 | verify :method => :post, |
|
|
50 | 50 | :only => :destroy, |
|
|
51 | 51 | :render => { :nothing => true, :status => :method_not_allowed } |
|
|
52 | 52 | |
|
|
53 | 53 | def index |
|
|
54 | 54 | retrieve_query |
|
|
55 | 55 | sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria) |
|
|
56 | 56 | sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h})) |
|
|
57 | 57 | |
|
|
58 | 58 | if @query.valid? |
|
|
59 | 59 | limit = per_page_option |
|
|
60 | 60 | respond_to do |format| |
|
|
61 | 61 | format.html { } |
|
|
62 | 62 | format.atom { limit = Setting.feeds_limit.to_i } |
|
|
63 | 63 | format.csv { limit = Setting.issues_export_limit.to_i } |
|
|
64 | 64 | format.pdf { limit = Setting.issues_export_limit.to_i } |
|
|
65 | 65 | end |
|
|
66 | 66 | |
|
|
67 | 67 | @issue_count = @query.issue_count |
|
|
68 | 68 | @issue_pages = Paginator.new self, @issue_count, limit, params['page'] |
|
|
69 | 69 | @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version], |
|
|
70 | 70 | :order => sort_clause, |
|
|
71 | 71 | :offset => @issue_pages.current.offset, |
|
|
72 | 72 | :limit => limit) |
|
|
73 | 73 | @issue_count_by_group = @query.issue_count_by_group |
|
|
74 | 74 | |
|
|
75 | 75 | respond_to do |format| |
|
|
76 | 76 | format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? } |
|
|
77 | 77 | format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") } |
|
|
78 | 78 | format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') } |
|
|
79 | 79 | format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') } |
|
|
80 | 80 | end |
|
|
81 | 81 | else |
|
|
82 | 82 | # Send html if the query is not valid |
|
|
83 | 83 | render(:template => 'issues/index.rhtml', :layout => !request.xhr?) |
|
|
84 | 84 | end |
|
|
85 | 85 | rescue ActiveRecord::RecordNotFound |
|
|
86 | 86 | render_404 |
|
|
87 | 87 | end |
|
|
88 | 88 | |
|
|
89 | 89 | def changes |
|
|
90 | 90 | retrieve_query |
|
|
91 | 91 | sort_init 'id', 'desc' |
|
|
92 | 92 | sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h})) |
|
|
93 | 93 | |
|
|
94 | 94 | if @query.valid? |
|
|
95 | 95 | @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC", |
|
|
96 | 96 | :limit => 25) |
|
|
97 | 97 | end |
|
|
98 | 98 | @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name) |
|
|
99 | 99 | render :layout => false, :content_type => 'application/atom+xml' |
|
|
100 | 100 | rescue ActiveRecord::RecordNotFound |
|
|
101 | 101 | render_404 |
|
|
102 | 102 | end |
|
|
103 | 103 | |
|
|
104 | 104 | def show |
|
|
105 | 105 | @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC") |
|
|
106 | 106 | @journals.each_with_index {|j,i| j.indice = i+1} |
|
|
107 | 107 | @journals.reverse! if User.current.wants_comments_in_reverse_order? |
|
|
108 | 108 | @changesets = @issue.changesets |
|
|
109 | 109 | @changesets.reverse! if User.current.wants_comments_in_reverse_order? |
|
|
110 | 110 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
111 | 111 | @edit_allowed = User.current.allowed_to?(:edit_issues, @project) |
|
|
112 | 112 | @priorities = IssuePriority.all |
|
|
113 | 113 | @time_entry = TimeEntry.new |
|
|
114 | 114 | respond_to do |format| |
|
|
115 | 115 | format.html { render :template => 'issues/show.rhtml' } |
|
|
116 | 116 | format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' } |
|
|
117 | 117 | format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") } |
|
|
118 | 118 | end |
|
|
119 | 119 | end |
|
|
120 | 120 | |
|
|
121 | 121 | # Add a new issue |
|
|
122 | 122 | # The new issue will be created from an existing one if copy_from parameter is given |
|
|
123 | 123 | def new |
|
|
124 | 124 | @issue = Issue.new |
|
|
125 | 125 | @issue.copy_from(params[:copy_from]) if params[:copy_from] |
|
|
126 | 126 | @issue.project = @project |
|
|
127 | 127 | # Tracker must be set before custom field values |
|
|
128 | 128 | @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first) |
|
|
129 | 129 | if @issue.tracker.nil? |
|
|
130 | 130 | render_error l(:error_no_tracker_in_project) |
|
|
131 | 131 | return |
|
|
132 | 132 | end |
|
|
133 | 133 | if params[:issue].is_a?(Hash) |
|
|
134 | 134 | @issue.attributes = params[:issue] |
|
|
135 | 135 | @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project) |
|
|
136 | 136 | end |
|
|
137 | 137 | @issue.author = User.current |
|
|
138 | 138 | |
|
|
139 | 139 | default_status = IssueStatus.default |
|
|
140 | 140 | unless default_status |
|
|
141 | 141 | render_error l(:error_no_default_issue_status) |
|
|
142 | 142 | return |
|
|
143 | 143 | end |
|
|
144 | 144 | @issue.status = default_status |
|
|
145 | 145 | @allowed_statuses = ([default_status] + default_status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq |
|
|
146 | 146 | |
|
|
147 | 147 | if request.get? || request.xhr? |
|
|
148 | 148 | @issue.start_date ||= Date.today |
|
|
149 | 149 | else |
|
|
150 | 150 | requested_status = IssueStatus.find_by_id(params[:issue][:status_id]) |
|
|
151 | 151 | # Check that the user is allowed to apply the requested status |
|
|
152 | 152 | @issue.status = (@allowed_statuses.include? requested_status) ? requested_status : default_status |
|
|
153 | 153 | if @issue.save |
|
|
154 | 154 | attach_files(@issue, params[:attachments]) |
|
|
155 | 155 | flash[:notice] = l(:notice_successful_create) |
|
|
156 | 156 | call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue}) |
|
|
157 | 157 | redirect_to(params[:continue] ? { :action => 'new', :tracker_id => @issue.tracker } : |
|
|
158 | 158 | { :action => 'show', :id => @issue }) |
|
|
159 | 159 | return |
|
|
160 | 160 | end |
|
|
161 | 161 | end |
|
|
162 | 162 | @priorities = IssuePriority.all |
|
|
163 | 163 | render :layout => !request.xhr? |
|
|
164 | 164 | end |
|
|
165 | 165 | |
|
|
166 | 166 | # Attributes that can be updated on workflow transition (without :edit permission) |
|
|
167 | 167 | # TODO: make it configurable (at least per role) |
|
|
168 | 168 | UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION) |
|
|
169 | 169 | |
|
|
170 | 170 | def edit |
|
|
171 | 171 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
172 | 172 | @priorities = IssuePriority.all |
|
|
173 | 173 | @edit_allowed = User.current.allowed_to?(:edit_issues, @project) |
|
|
174 | 174 | @time_entry = TimeEntry.new |
|
|
175 | 175 | |
|
|
176 | 176 | @notes = params[:notes] |
|
|
177 | 177 | journal = @issue.init_journal(User.current, @notes) |
|
|
178 | 178 | # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed |
|
|
179 | 179 | if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue] |
|
|
180 | 180 | attrs = params[:issue].dup |
|
|
181 | 181 | attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed |
|
|
182 | 182 | attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s} |
|
|
183 | 183 | @issue.attributes = attrs |
|
|
184 | 184 | end |
|
|
185 | 185 | |
|
|
186 | 186 | if request.post? |
|
|
187 | 187 | @time_entry = TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today) |
|
|
188 | 188 | @time_entry.attributes = params[:time_entry] |
|
|
189 | 189 | attachments = attach_files(@issue, params[:attachments]) |
|
|
190 | 190 | attachments.each {|a| journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)} |
|
|
191 | 191 | |
|
|
192 | 192 | call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal}) |
|
|
193 | 193 | |
|
|
194 | 194 | if (@time_entry.hours.nil? || @time_entry.valid?) && @issue.save |
|
|
195 | 195 | # Log spend time |
|
|
196 | 196 | if User.current.allowed_to?(:log_time, @project) |
|
|
197 | 197 | @time_entry.save |
|
|
198 | 198 | end |
|
|
199 | 199 | if !journal.new_record? |
|
|
200 | 200 | # Only send notification if something was actually changed |
|
|
201 | 201 | flash[:notice] = l(:notice_successful_update) |
|
|
202 | 202 | end |
|
|
203 | 203 | call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal}) |
|
|
204 | 204 | redirect_to(params[:back_to] || {:action => 'show', :id => @issue}) |
|
|
205 | 205 | end |
|
|
206 | 206 | end |
|
|
207 | 207 | rescue ActiveRecord::StaleObjectError |
|
|
208 | 208 | # Optimistic locking exception |
|
|
209 | 209 | flash.now[:error] = l(:notice_locking_conflict) |
|
|
210 | 210 | # Remove the previously added attachments if issue was not updated |
|
|
211 | 211 | attachments.each(&:destroy) |
|
|
212 | 212 | end |
|
|
213 | 213 | |
|
|
214 | 214 | def reply |
|
|
215 | 215 | journal = Journal.find(params[:journal_id]) if params[:journal_id] |
|
|
216 | 216 | if journal |
|
|
217 | 217 | user = journal.user |
|
|
218 | 218 | text = journal.notes |
|
|
219 | 219 | else |
|
|
220 | 220 | user = @issue.author |
|
|
221 | 221 | text = @issue.description |
|
|
222 | 222 | end |
|
|
223 | 223 | content = "#{ll(Setting.default_language, :text_user_wrote, user)}\\n> " |
|
|
224 | 224 | content << text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]').gsub('"', '\"').gsub(/(\r?\n|\r\n?)/, "\\n> ") + "\\n\\n" |
|
|
225 | 225 | render(:update) { |page| |
|
|
226 | 226 | page.<< "$('notes').value = \"#{content}\";" |
|
|
227 | 227 | page.show 'update' |
|
|
228 | 228 | page << "Form.Element.focus('notes');" |
|
|
229 | 229 | page << "Element.scrollTo('update');" |
|
|
230 | 230 | page << "$('notes').scrollTop = $('notes').scrollHeight - $('notes').clientHeight;" |
|
|
231 | 231 | } |
|
|
232 | 232 | end |
|
|
233 | 233 | |
|
|
234 | 234 | # Bulk edit a set of issues |
|
|
235 | 235 | def bulk_edit |
|
|
236 | 236 | if request.post? |
|
|
237 | 237 | tracker = params[:tracker_id].blank? ? nil : @project.trackers.find_by_id(params[:tracker_id]) |
|
|
238 | 238 | status = params[:status_id].blank? ? nil : IssueStatus.find_by_id(params[:status_id]) |
|
|
239 | 239 | priority = params[:priority_id].blank? ? nil : IssuePriority.find_by_id(params[:priority_id]) |
|
|
240 | 240 | assigned_to = (params[:assigned_to_id].blank? || params[:assigned_to_id] == 'none') ? nil : User.find_by_id(params[:assigned_to_id]) |
|
|
241 | 241 | category = (params[:category_id].blank? || params[:category_id] == 'none') ? nil : @project.issue_categories.find_by_id(params[:category_id]) |
|
|
242 | 242 | fixed_version = (params[:fixed_version_id].blank? || params[:fixed_version_id] == 'none') ? nil : @project.versions.find_by_id(params[:fixed_version_id]) |
|
|
243 | 243 | custom_field_values = params[:custom_field_values] ? params[:custom_field_values].reject {|k,v| v.blank?} : nil |
|
|
244 | 244 | |
|
|
245 | 245 | unsaved_issue_ids = [] |
|
|
246 | 246 | @issues.each do |issue| |
|
|
247 | 247 | journal = issue.init_journal(User.current, params[:notes]) |
|
|
248 | 248 | issue.tracker = tracker if tracker |
|
|
249 | 249 | issue.priority = priority if priority |
|
|
250 | 250 | issue.assigned_to = assigned_to if assigned_to || params[:assigned_to_id] == 'none' |
|
|
251 | 251 | issue.category = category if category || params[:category_id] == 'none' |
|
|
252 | 252 | issue.fixed_version = fixed_version if fixed_version || params[:fixed_version_id] == 'none' |
|
|
253 | 253 | issue.start_date = params[:start_date] unless params[:start_date].blank? |
|
|
254 | 254 | issue.due_date = params[:due_date] unless params[:due_date].blank? |
|
|
255 | 255 | issue.done_ratio = params[:done_ratio] unless params[:done_ratio].blank? |
|
|
256 | 256 | issue.custom_field_values = custom_field_values if custom_field_values && !custom_field_values.empty? |
|
|
257 | 257 | call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue }) |
|
|
258 | 258 | # Don't save any change to the issue if the user is not authorized to apply the requested status |
|
|
259 | 259 | unless (status.nil? || (issue.new_statuses_allowed_to(User.current).include?(status) && issue.status = status)) && issue.save |
|
|
260 | 260 | # Keep unsaved issue ids to display them in flash error |
|
|
261 | 261 | unsaved_issue_ids << issue.id |
|
|
262 | 262 | end |
|
|
263 | 263 | end |
|
|
264 | 264 | if unsaved_issue_ids.empty? |
|
|
265 | 265 | flash[:notice] = l(:notice_successful_update) unless @issues.empty? |
|
|
266 | 266 | else |
|
|
267 | 267 | flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size, |
|
|
268 | 268 | :total => @issues.size, |
|
|
269 | 269 | :ids => '#' + unsaved_issue_ids.join(', #')) |
|
|
270 | 270 | end |
|
|
271 | 271 | redirect_to(params[:back_to] || {:controller => 'issues', :action => 'index', :project_id => @project}) |
|
|
272 | 272 | return |
|
|
273 | 273 | end |
|
|
274 | # Find potential statuses the user could be allowed to switch issues to | |
|
|
275 | @available_statuses = Workflow.find(:all, :include => :new_status, | |
|
|
276 | :conditions => {:role_id => User.current.roles_for_project(@project).collect(&:id)}).collect(&:new_status).compact.uniq.sort | |
|
|
274 | @available_statuses = Workflow.available_statuses(@project) | |
|
|
277 | 275 | @custom_fields = @project.issue_custom_fields.select {|f| f.field_format == 'list'} |
|
|
278 | 276 | end |
|
|
279 | 277 | |
|
|
280 | 278 | def move |
|
|
279 | @copy = params[:copy_options] && params[:copy_options][:copy] | |
|
|
281 | 280 | @allowed_projects = [] |
|
|
282 | 281 | # find projects to which the user is allowed to move the issue |
|
|
283 | 282 | if User.current.admin? |
|
|
284 | 283 | # admin is allowed to move issues to any active (visible) project |
|
|
285 | 284 | @allowed_projects = Project.find(:all, :conditions => Project.visible_by(User.current)) |
|
|
286 | 285 | else |
|
|
287 | 286 | User.current.memberships.each {|m| @allowed_projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}} |
|
|
288 | 287 | end |
|
|
289 | 288 | @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:new_project_id]} if params[:new_project_id] |
|
|
290 | 289 | @target_project ||= @project |
|
|
291 | 290 | @trackers = @target_project.trackers |
|
|
291 | @available_statuses = Workflow.available_statuses(@project) | |
|
|
292 | 292 | if request.post? |
|
|
293 | 293 | new_tracker = params[:new_tracker_id].blank? ? nil : @target_project.trackers.find_by_id(params[:new_tracker_id]) |
|
|
294 | 294 | unsaved_issue_ids = [] |
|
|
295 | 295 | moved_issues = [] |
|
|
296 | 296 | @issues.each do |issue| |
|
|
297 | changed_attributes = {} | |
|
|
298 | [:assigned_to_id, :status_id, :start_date, :due_date].each do |valid_attribute| | |
|
|
299 | changed_attributes[valid_attribute] = params[valid_attribute] if params[valid_attribute] | |
|
|
300 | end | |
|
|
297 | 301 | issue.init_journal(User.current) |
|
|
298 |
if r = issue.move_to(@target_project, new_tracker, |
|
|
|
302 | if r = issue.move_to(@target_project, new_tracker, {:copy => @copy, :attributes => changed_attributes}) | |
|
|
299 | 303 | moved_issues << r |
|
|
300 | 304 | else |
|
|
301 | 305 | unsaved_issue_ids << issue.id |
|
|
302 | 306 | end |
|
|
303 | 307 | end |
|
|
304 | 308 | if unsaved_issue_ids.empty? |
|
|
305 | 309 | flash[:notice] = l(:notice_successful_update) unless @issues.empty? |
|
|
306 | 310 | else |
|
|
307 | 311 | flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size, |
|
|
308 | 312 | :total => @issues.size, |
|
|
309 | 313 | :ids => '#' + unsaved_issue_ids.join(', #')) |
|
|
310 | 314 | end |
|
|
311 | 315 | if params[:follow] |
|
|
312 | 316 | if @issues.size == 1 && moved_issues.size == 1 |
|
|
313 | 317 | redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first |
|
|
314 | 318 | else |
|
|
315 | 319 | redirect_to :controller => 'issues', :action => 'index', :project_id => (@target_project || @project) |
|
|
316 | 320 | end |
|
|
317 | 321 | else |
|
|
318 | 322 | redirect_to :controller => 'issues', :action => 'index', :project_id => @project |
|
|
319 | 323 | end |
|
|
320 | 324 | return |
|
|
321 | 325 | end |
|
|
322 | 326 | render :layout => false if request.xhr? |
|
|
323 | 327 | end |
|
|
324 | 328 | |
|
|
325 | 329 | def destroy |
|
|
326 | 330 | @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f |
|
|
327 | 331 | if @hours > 0 |
|
|
328 | 332 | case params[:todo] |
|
|
329 | 333 | when 'destroy' |
|
|
330 | 334 | # nothing to do |
|
|
331 | 335 | when 'nullify' |
|
|
332 | 336 | TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues]) |
|
|
333 | 337 | when 'reassign' |
|
|
334 | 338 | reassign_to = @project.issues.find_by_id(params[:reassign_to_id]) |
|
|
335 | 339 | if reassign_to.nil? |
|
|
336 | 340 | flash.now[:error] = l(:error_issue_not_found_in_project) |
|
|
337 | 341 | return |
|
|
338 | 342 | else |
|
|
339 | 343 | TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues]) |
|
|
340 | 344 | end |
|
|
341 | 345 | else |
|
|
342 | 346 | # display the destroy form |
|
|
343 | 347 | return |
|
|
344 | 348 | end |
|
|
345 | 349 | end |
|
|
346 | 350 | @issues.each(&:destroy) |
|
|
347 | 351 | redirect_to :action => 'index', :project_id => @project |
|
|
348 | 352 | end |
|
|
349 | 353 | |
|
|
350 | 354 | def gantt |
|
|
351 | 355 | @gantt = Redmine::Helpers::Gantt.new(params) |
|
|
352 | 356 | retrieve_query |
|
|
353 | 357 | if @query.valid? |
|
|
354 | 358 | events = [] |
|
|
355 | 359 | # Issues that have start and due dates |
|
|
356 | 360 | events += @query.issues(:include => [:tracker, :assigned_to, :priority], |
|
|
357 | 361 | :order => "start_date, due_date", |
|
|
358 | 362 | :conditions => ["(((start_date>=? and start_date<=?) or (due_date>=? and due_date<=?) or (start_date<? and due_date>?)) and start_date is not null and due_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to] |
|
|
359 | 363 | ) |
|
|
360 | 364 | # Issues that don't have a due date but that are assigned to a version with a date |
|
|
361 | 365 | events += @query.issues(:include => [:tracker, :assigned_to, :priority, :fixed_version], |
|
|
362 | 366 | :order => "start_date, effective_date", |
|
|
363 | 367 | :conditions => ["(((start_date>=? and start_date<=?) or (effective_date>=? and effective_date<=?) or (start_date<? and effective_date>?)) and start_date is not null and due_date is null and effective_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to] |
|
|
364 | 368 | ) |
|
|
365 | 369 | # Versions |
|
|
366 | 370 | events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @gantt.date_from, @gantt.date_to]) |
|
|
367 | 371 | |
|
|
368 | 372 | @gantt.events = events |
|
|
369 | 373 | end |
|
|
370 | 374 | |
|
|
371 | 375 | basename = (@project ? "#{@project.identifier}-" : '') + 'gantt' |
|
|
372 | 376 | |
|
|
373 | 377 | respond_to do |format| |
|
|
374 | 378 | format.html { render :template => "issues/gantt.rhtml", :layout => !request.xhr? } |
|
|
375 | 379 | format.png { send_data(@gantt.to_image, :disposition => 'inline', :type => 'image/png', :filename => "#{basename}.png") } if @gantt.respond_to?('to_image') |
|
|
376 | 380 | format.pdf { send_data(gantt_to_pdf(@gantt, @project), :type => 'application/pdf', :filename => "#{basename}.pdf") } |
|
|
377 | 381 | end |
|
|
378 | 382 | end |
|
|
379 | 383 | |
|
|
380 | 384 | def calendar |
|
|
381 | 385 | if params[:year] and params[:year].to_i > 1900 |
|
|
382 | 386 | @year = params[:year].to_i |
|
|
383 | 387 | if params[:month] and params[:month].to_i > 0 and params[:month].to_i < 13 |
|
|
384 | 388 | @month = params[:month].to_i |
|
|
385 | 389 | end |
|
|
386 | 390 | end |
|
|
387 | 391 | @year ||= Date.today.year |
|
|
388 | 392 | @month ||= Date.today.month |
|
|
389 | 393 | |
|
|
390 | 394 | @calendar = Redmine::Helpers::Calendar.new(Date.civil(@year, @month, 1), current_language, :month) |
|
|
391 | 395 | retrieve_query |
|
|
392 | 396 | if @query.valid? |
|
|
393 | 397 | events = [] |
|
|
394 | 398 | events += @query.issues(:include => [:tracker, :assigned_to, :priority], |
|
|
395 | 399 | :conditions => ["((start_date BETWEEN ? AND ?) OR (due_date BETWEEN ? AND ?))", @calendar.startdt, @calendar.enddt, @calendar.startdt, @calendar.enddt] |
|
|
396 | 400 | ) |
|
|
397 | 401 | events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @calendar.startdt, @calendar.enddt]) |
|
|
398 | 402 | |
|
|
399 | 403 | @calendar.events = events |
|
|
400 | 404 | end |
|
|
401 | 405 | |
|
|
402 | 406 | render :layout => false if request.xhr? |
|
|
403 | 407 | end |
|
|
404 | 408 | |
|
|
405 | 409 | def context_menu |
|
|
406 | 410 | @issues = Issue.find_all_by_id(params[:ids], :include => :project) |
|
|
407 | 411 | if (@issues.size == 1) |
|
|
408 | 412 | @issue = @issues.first |
|
|
409 | 413 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) |
|
|
410 | 414 | end |
|
|
411 | 415 | projects = @issues.collect(&:project).compact.uniq |
|
|
412 | 416 | @project = projects.first if projects.size == 1 |
|
|
413 | 417 | |
|
|
414 | 418 | @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)), |
|
|
415 | 419 | :log_time => (@project && User.current.allowed_to?(:log_time, @project)), |
|
|
416 | 420 | :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))), |
|
|
417 | 421 | :move => (@project && User.current.allowed_to?(:move_issues, @project)), |
|
|
418 | 422 | :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)), |
|
|
419 | 423 | :delete => (@project && User.current.allowed_to?(:delete_issues, @project)) |
|
|
420 | 424 | } |
|
|
421 | 425 | if @project |
|
|
422 | 426 | @assignables = @project.assignable_users |
|
|
423 | 427 | @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to) |
|
|
424 | 428 | @trackers = @project.trackers |
|
|
425 | 429 | end |
|
|
426 | 430 | |
|
|
427 | 431 | @priorities = IssuePriority.all.reverse |
|
|
428 | 432 | @statuses = IssueStatus.find(:all, :order => 'position') |
|
|
429 | 433 | @back = params[:back_url] || request.env['HTTP_REFERER'] |
|
|
430 | 434 | |
|
|
431 | 435 | render :layout => false |
|
|
432 | 436 | end |
|
|
433 | 437 | |
|
|
434 | 438 | def update_form |
|
|
435 | 439 | if params[:id] |
|
|
436 | 440 | @issue = @project.issues.visible.find(params[:id]) |
|
|
437 | 441 | else |
|
|
438 | 442 | @issue = Issue.new |
|
|
439 | 443 | @issue.project = @project |
|
|
440 | 444 | end |
|
|
441 | 445 | @issue.attributes = params[:issue] |
|
|
442 | 446 | @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq |
|
|
443 | 447 | @priorities = IssuePriority.all |
|
|
444 | 448 | |
|
|
445 | 449 | render :partial => 'attributes' |
|
|
446 | 450 | end |
|
|
447 | 451 | |
|
|
448 | 452 | def preview |
|
|
449 | 453 | @issue = @project.issues.find_by_id(params[:id]) unless params[:id].blank? |
|
|
450 | 454 | @attachements = @issue.attachments if @issue |
|
|
451 | 455 | @text = params[:notes] || (params[:issue] ? params[:issue][:description] : nil) |
|
|
452 | 456 | render :partial => 'common/preview' |
|
|
453 | 457 | end |
|
|
454 | 458 | |
|
|
455 | 459 | private |
|
|
456 | 460 | def find_issue |
|
|
457 | 461 | @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category]) |
|
|
458 | 462 | @project = @issue.project |
|
|
459 | 463 | rescue ActiveRecord::RecordNotFound |
|
|
460 | 464 | render_404 |
|
|
461 | 465 | end |
|
|
462 | 466 | |
|
|
463 | 467 | # Filter for bulk operations |
|
|
464 | 468 | def find_issues |
|
|
465 | 469 | @issues = Issue.find_all_by_id(params[:id] || params[:ids]) |
|
|
466 | 470 | raise ActiveRecord::RecordNotFound if @issues.empty? |
|
|
467 | 471 | projects = @issues.collect(&:project).compact.uniq |
|
|
468 | 472 | if projects.size == 1 |
|
|
469 | 473 | @project = projects.first |
|
|
470 | 474 | else |
|
|
471 | 475 | # TODO: let users bulk edit/move/destroy issues from different projects |
|
|
472 | 476 | render_error 'Can not bulk edit/move/destroy issues from different projects' and return false |
|
|
473 | 477 | end |
|
|
474 | 478 | rescue ActiveRecord::RecordNotFound |
|
|
475 | 479 | render_404 |
|
|
476 | 480 | end |
|
|
477 | 481 | |
|
|
478 | 482 | def find_project |
|
|
479 | 483 | @project = Project.find(params[:project_id]) |
|
|
480 | 484 | rescue ActiveRecord::RecordNotFound |
|
|
481 | 485 | render_404 |
|
|
482 | 486 | end |
|
|
483 | 487 | |
|
|
484 | 488 | def find_optional_project |
|
|
485 | 489 | @project = Project.find(params[:project_id]) unless params[:project_id].blank? |
|
|
486 | 490 | allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true) |
|
|
487 | 491 | allowed ? true : deny_access |
|
|
488 | 492 | rescue ActiveRecord::RecordNotFound |
|
|
489 | 493 | render_404 |
|
|
490 | 494 | end |
|
|
491 | 495 | |
|
|
492 | 496 | # Retrieve query from session or build a new query |
|
|
493 | 497 | def retrieve_query |
|
|
494 | 498 | if !params[:query_id].blank? |
|
|
495 | 499 | cond = "project_id IS NULL" |
|
|
496 | 500 | cond << " OR project_id = #{@project.id}" if @project |
|
|
497 | 501 | @query = Query.find(params[:query_id], :conditions => cond) |
|
|
498 | 502 | @query.project = @project |
|
|
499 | 503 | session[:query] = {:id => @query.id, :project_id => @query.project_id} |
|
|
500 | 504 | sort_clear |
|
|
501 | 505 | else |
|
|
502 | 506 | if params[:set_filter] || session[:query].nil? || session[:query][:project_id] != (@project ? @project.id : nil) |
|
|
503 | 507 | # Give it a name, required to be valid |
|
|
504 | 508 | @query = Query.new(:name => "_") |
|
|
505 | 509 | @query.project = @project |
|
|
506 | 510 | if params[:fields] and params[:fields].is_a? Array |
|
|
507 | 511 | params[:fields].each do |field| |
|
|
508 | 512 | @query.add_filter(field, params[:operators][field], params[:values][field]) |
|
|
509 | 513 | end |
|
|
510 | 514 | else |
|
|
511 | 515 | @query.available_filters.keys.each do |field| |
|
|
512 | 516 | @query.add_short_filter(field, params[field]) if params[field] |
|
|
513 | 517 | end |
|
|
514 | 518 | end |
|
|
515 | 519 | @query.group_by = params[:group_by] |
|
|
516 | 520 | @query.column_names = params[:query] && params[:query][:column_names] |
|
|
517 | 521 | session[:query] = {:project_id => @query.project_id, :filters => @query.filters, :group_by => @query.group_by, :column_names => @query.column_names} |
|
|
518 | 522 | else |
|
|
519 | 523 | @query = Query.find_by_id(session[:query][:id]) if session[:query][:id] |
|
|
520 | 524 | @query ||= Query.new(:name => "_", :project => @project, :filters => session[:query][:filters], :group_by => session[:query][:group_by], :column_names => session[:query][:column_names]) |
|
|
521 | 525 | @query.project = @project |
|
|
522 | 526 | end |
|
|
523 | 527 | end |
|
|
524 | 528 | end |
|
|
525 | 529 | |
|
|
526 | 530 | # Rescues an invalid query statement. Just in case... |
|
|
527 | 531 | def query_statement_invalid(exception) |
|
|
528 | 532 | logger.error "Query::StatementInvalid: #{exception.message}" if logger |
|
|
529 | 533 | session.delete(:query) |
|
|
530 | 534 | sort_clear |
|
|
531 | 535 | render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator." |
|
|
532 | 536 | end |
|
|
533 | 537 | end |
| @@ -1,366 +1,374 | |||
|
|
1 | 1 | # redMine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2007 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | class Issue < ActiveRecord::Base |
|
|
19 | 19 | belongs_to :project |
|
|
20 | 20 | belongs_to :tracker |
|
|
21 | 21 | belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id' |
|
|
22 | 22 | belongs_to :author, :class_name => 'User', :foreign_key => 'author_id' |
|
|
23 | 23 | belongs_to :assigned_to, :class_name => 'User', :foreign_key => 'assigned_to_id' |
|
|
24 | 24 | belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id' |
|
|
25 | 25 | belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id' |
|
|
26 | 26 | belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id' |
|
|
27 | 27 | |
|
|
28 | 28 | has_many :journals, :as => :journalized, :dependent => :destroy |
|
|
29 | 29 | has_many :time_entries, :dependent => :delete_all |
|
|
30 | 30 | has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC" |
|
|
31 | 31 | |
|
|
32 | 32 | has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all |
|
|
33 | 33 | has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all |
|
|
34 | 34 | |
|
|
35 | 35 | acts_as_attachable :after_remove => :attachment_removed |
|
|
36 | 36 | acts_as_customizable |
|
|
37 | 37 | acts_as_watchable |
|
|
38 | 38 | acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"], |
|
|
39 | 39 | :include => [:project, :journals], |
|
|
40 | 40 | # sort by id so that limited eager loading doesn't break with postgresql |
|
|
41 | 41 | :order_column => "#{table_name}.id" |
|
|
42 | 42 | acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"}, |
|
|
43 | 43 | :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}}, |
|
|
44 | 44 | :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') } |
|
|
45 | 45 | |
|
|
46 | 46 | acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]}, |
|
|
47 | 47 | :author_key => :author_id |
|
|
48 | 48 | |
|
|
49 | 49 | validates_presence_of :subject, :priority, :project, :tracker, :author, :status |
|
|
50 | 50 | validates_length_of :subject, :maximum => 255 |
|
|
51 | 51 | validates_inclusion_of :done_ratio, :in => 0..100 |
|
|
52 | 52 | validates_numericality_of :estimated_hours, :allow_nil => true |
|
|
53 | 53 | |
|
|
54 | 54 | named_scope :visible, lambda {|*args| { :include => :project, |
|
|
55 | 55 | :conditions => Project.allowed_to_condition(args.first || User.current, :view_issues) } } |
|
|
56 | 56 | |
|
|
57 | 57 | named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status |
|
|
58 | 58 | |
|
|
59 | 59 | after_save :create_journal |
|
|
60 | 60 | |
|
|
61 | 61 | # Returns true if usr or current user is allowed to view the issue |
|
|
62 | 62 | def visible?(usr=nil) |
|
|
63 | 63 | (usr || User.current).allowed_to?(:view_issues, self.project) |
|
|
64 | 64 | end |
|
|
65 | 65 | |
|
|
66 | 66 | def after_initialize |
|
|
67 | 67 | if new_record? |
|
|
68 | 68 | # set default values for new records only |
|
|
69 | 69 | self.status ||= IssueStatus.default |
|
|
70 | 70 | self.priority ||= IssuePriority.default |
|
|
71 | 71 | end |
|
|
72 | 72 | end |
|
|
73 | 73 | |
|
|
74 | 74 | # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields |
|
|
75 | 75 | def available_custom_fields |
|
|
76 | 76 | (project && tracker) ? project.all_issue_custom_fields.select {|c| tracker.custom_fields.include? c } : [] |
|
|
77 | 77 | end |
|
|
78 | 78 | |
|
|
79 | 79 | def copy_from(arg) |
|
|
80 | 80 | issue = arg.is_a?(Issue) ? arg : Issue.find(arg) |
|
|
81 | 81 | self.attributes = issue.attributes.dup.except("id", "created_on", "updated_on") |
|
|
82 | 82 | self.custom_values = issue.custom_values.collect {|v| v.clone} |
|
|
83 | 83 | self.status = issue.status |
|
|
84 | 84 | self |
|
|
85 | 85 | end |
|
|
86 | 86 | |
|
|
87 | 87 | # Moves/copies an issue to a new project and tracker |
|
|
88 | 88 | # Returns the moved/copied issue on success, false on failure |
|
|
89 | 89 | def move_to(new_project, new_tracker = nil, options = {}) |
|
|
90 | 90 | options ||= {} |
|
|
91 | 91 | issue = options[:copy] ? self.clone : self |
|
|
92 | 92 | transaction do |
|
|
93 | 93 | if new_project && issue.project_id != new_project.id |
|
|
94 | 94 | # delete issue relations |
|
|
95 | 95 | unless Setting.cross_project_issue_relations? |
|
|
96 | 96 | issue.relations_from.clear |
|
|
97 | 97 | issue.relations_to.clear |
|
|
98 | 98 | end |
|
|
99 | 99 | # issue is moved to another project |
|
|
100 | 100 | # reassign to the category with same name if any |
|
|
101 | 101 | new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name) |
|
|
102 | 102 | issue.category = new_category |
|
|
103 | 103 | issue.fixed_version = nil |
|
|
104 | 104 | issue.project = new_project |
|
|
105 | 105 | end |
|
|
106 | 106 | if new_tracker |
|
|
107 | 107 | issue.tracker = new_tracker |
|
|
108 | 108 | end |
|
|
109 | 109 | if options[:copy] |
|
|
110 | 110 | issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h} |
|
|
111 | issue.status = self.status | |
|
|
111 | issue.status = if options[:attributes] && options[:attributes][:status_id] | |
|
|
112 | IssueStatus.find_by_id(options[:attributes][:status_id]) | |
|
|
113 | else | |
|
|
114 | self.status | |
|
|
115 | end | |
|
|
116 | end | |
|
|
117 | # Allow bulk setting of attributes on the issue | |
|
|
118 | if options[:attributes] | |
|
|
119 | issue.attributes = options[:attributes] | |
|
|
112 | 120 | end |
|
|
113 | 121 | if issue.save |
|
|
114 | 122 | unless options[:copy] |
|
|
115 | 123 | # Manually update project_id on related time entries |
|
|
116 | 124 | TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id}) |
|
|
117 | 125 | end |
|
|
118 | 126 | else |
|
|
119 | 127 | Issue.connection.rollback_db_transaction |
|
|
120 | 128 | return false |
|
|
121 | 129 | end |
|
|
122 | 130 | end |
|
|
123 | 131 | return issue |
|
|
124 | 132 | end |
|
|
125 | 133 | |
|
|
126 | 134 | def priority_id=(pid) |
|
|
127 | 135 | self.priority = nil |
|
|
128 | 136 | write_attribute(:priority_id, pid) |
|
|
129 | 137 | end |
|
|
130 | 138 | |
|
|
131 | 139 | def tracker_id=(tid) |
|
|
132 | 140 | self.tracker = nil |
|
|
133 | 141 | write_attribute(:tracker_id, tid) |
|
|
134 | 142 | end |
|
|
135 | 143 | |
|
|
136 | 144 | def estimated_hours=(h) |
|
|
137 | 145 | write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h) |
|
|
138 | 146 | end |
|
|
139 | 147 | |
|
|
140 | 148 | def validate |
|
|
141 | 149 | if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty? |
|
|
142 | 150 | errors.add :due_date, :not_a_date |
|
|
143 | 151 | end |
|
|
144 | 152 | |
|
|
145 | 153 | if self.due_date and self.start_date and self.due_date < self.start_date |
|
|
146 | 154 | errors.add :due_date, :greater_than_start_date |
|
|
147 | 155 | end |
|
|
148 | 156 | |
|
|
149 | 157 | if start_date && soonest_start && start_date < soonest_start |
|
|
150 | 158 | errors.add :start_date, :invalid |
|
|
151 | 159 | end |
|
|
152 | 160 | |
|
|
153 | 161 | if fixed_version |
|
|
154 | 162 | if !assignable_versions.include?(fixed_version) |
|
|
155 | 163 | errors.add :fixed_version_id, :inclusion |
|
|
156 | 164 | elsif reopened? && fixed_version.closed? |
|
|
157 | 165 | errors.add_to_base I18n.t(:error_can_not_reopen_issue_on_closed_version) |
|
|
158 | 166 | end |
|
|
159 | 167 | end |
|
|
160 | 168 | |
|
|
161 | 169 | # Checks that the issue can not be added/moved to a disabled tracker |
|
|
162 | 170 | if project && (tracker_id_changed? || project_id_changed?) |
|
|
163 | 171 | unless project.trackers.include?(tracker) |
|
|
164 | 172 | errors.add :tracker_id, :inclusion |
|
|
165 | 173 | end |
|
|
166 | 174 | end |
|
|
167 | 175 | end |
|
|
168 | 176 | |
|
|
169 | 177 | def before_create |
|
|
170 | 178 | # default assignment based on category |
|
|
171 | 179 | if assigned_to.nil? && category && category.assigned_to |
|
|
172 | 180 | self.assigned_to = category.assigned_to |
|
|
173 | 181 | end |
|
|
174 | 182 | end |
|
|
175 | 183 | |
|
|
176 | 184 | def after_save |
|
|
177 | 185 | # Reload is needed in order to get the right status |
|
|
178 | 186 | reload |
|
|
179 | 187 | |
|
|
180 | 188 | # Update start/due dates of following issues |
|
|
181 | 189 | relations_from.each(&:set_issue_to_dates) |
|
|
182 | 190 | |
|
|
183 | 191 | # Close duplicates if the issue was closed |
|
|
184 | 192 | if @issue_before_change && !@issue_before_change.closed? && self.closed? |
|
|
185 | 193 | duplicates.each do |duplicate| |
|
|
186 | 194 | # Reload is need in case the duplicate was updated by a previous duplicate |
|
|
187 | 195 | duplicate.reload |
|
|
188 | 196 | # Don't re-close it if it's already closed |
|
|
189 | 197 | next if duplicate.closed? |
|
|
190 | 198 | # Same user and notes |
|
|
191 | 199 | duplicate.init_journal(@current_journal.user, @current_journal.notes) |
|
|
192 | 200 | duplicate.update_attribute :status, self.status |
|
|
193 | 201 | end |
|
|
194 | 202 | end |
|
|
195 | 203 | end |
|
|
196 | 204 | |
|
|
197 | 205 | def init_journal(user, notes = "") |
|
|
198 | 206 | @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes) |
|
|
199 | 207 | @issue_before_change = self.clone |
|
|
200 | 208 | @issue_before_change.status = self.status |
|
|
201 | 209 | @custom_values_before_change = {} |
|
|
202 | 210 | self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value } |
|
|
203 | 211 | # Make sure updated_on is updated when adding a note. |
|
|
204 | 212 | updated_on_will_change! |
|
|
205 | 213 | @current_journal |
|
|
206 | 214 | end |
|
|
207 | 215 | |
|
|
208 | 216 | # Return true if the issue is closed, otherwise false |
|
|
209 | 217 | def closed? |
|
|
210 | 218 | self.status.is_closed? |
|
|
211 | 219 | end |
|
|
212 | 220 | |
|
|
213 | 221 | # Return true if the issue is being reopened |
|
|
214 | 222 | def reopened? |
|
|
215 | 223 | if !new_record? && status_id_changed? |
|
|
216 | 224 | status_was = IssueStatus.find_by_id(status_id_was) |
|
|
217 | 225 | status_new = IssueStatus.find_by_id(status_id) |
|
|
218 | 226 | if status_was && status_new && status_was.is_closed? && !status_new.is_closed? |
|
|
219 | 227 | return true |
|
|
220 | 228 | end |
|
|
221 | 229 | end |
|
|
222 | 230 | false |
|
|
223 | 231 | end |
|
|
224 | 232 | |
|
|
225 | 233 | # Returns true if the issue is overdue |
|
|
226 | 234 | def overdue? |
|
|
227 | 235 | !due_date.nil? && (due_date < Date.today) && !status.is_closed? |
|
|
228 | 236 | end |
|
|
229 | 237 | |
|
|
230 | 238 | # Users the issue can be assigned to |
|
|
231 | 239 | def assignable_users |
|
|
232 | 240 | project.assignable_users |
|
|
233 | 241 | end |
|
|
234 | 242 | |
|
|
235 | 243 | # Versions that the issue can be assigned to |
|
|
236 | 244 | def assignable_versions |
|
|
237 | 245 | @assignable_versions ||= (project.versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort |
|
|
238 | 246 | end |
|
|
239 | 247 | |
|
|
240 | 248 | # Returns true if this issue is blocked by another issue that is still open |
|
|
241 | 249 | def blocked? |
|
|
242 | 250 | !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil? |
|
|
243 | 251 | end |
|
|
244 | 252 | |
|
|
245 | 253 | # Returns an array of status that user is able to apply |
|
|
246 | 254 | def new_statuses_allowed_to(user) |
|
|
247 | 255 | statuses = status.find_new_statuses_allowed_to(user.roles_for_project(project), tracker) |
|
|
248 | 256 | statuses << status unless statuses.empty? |
|
|
249 | 257 | statuses = statuses.uniq.sort |
|
|
250 | 258 | blocked? ? statuses.reject {|s| s.is_closed?} : statuses |
|
|
251 | 259 | end |
|
|
252 | 260 | |
|
|
253 | 261 | # Returns the mail adresses of users that should be notified |
|
|
254 | 262 | def recipients |
|
|
255 | 263 | notified = project.notified_users |
|
|
256 | 264 | # Author and assignee are always notified unless they have been locked |
|
|
257 | 265 | notified << author if author && author.active? |
|
|
258 | 266 | notified << assigned_to if assigned_to && assigned_to.active? |
|
|
259 | 267 | notified.uniq! |
|
|
260 | 268 | # Remove users that can not view the issue |
|
|
261 | 269 | notified.reject! {|user| !visible?(user)} |
|
|
262 | 270 | notified.collect(&:mail) |
|
|
263 | 271 | end |
|
|
264 | 272 | |
|
|
265 | 273 | # Returns the mail adresses of watchers that should be notified |
|
|
266 | 274 | def watcher_recipients |
|
|
267 | 275 | notified = watcher_users |
|
|
268 | 276 | notified.reject! {|user| !user.active? || !visible?(user)} |
|
|
269 | 277 | notified.collect(&:mail) |
|
|
270 | 278 | end |
|
|
271 | 279 | |
|
|
272 | 280 | # Returns the total number of hours spent on this issue. |
|
|
273 | 281 | # |
|
|
274 | 282 | # Example: |
|
|
275 | 283 | # spent_hours => 0 |
|
|
276 | 284 | # spent_hours => 50 |
|
|
277 | 285 | def spent_hours |
|
|
278 | 286 | @spent_hours ||= time_entries.sum(:hours) || 0 |
|
|
279 | 287 | end |
|
|
280 | 288 | |
|
|
281 | 289 | def relations |
|
|
282 | 290 | (relations_from + relations_to).sort |
|
|
283 | 291 | end |
|
|
284 | 292 | |
|
|
285 | 293 | def all_dependent_issues |
|
|
286 | 294 | dependencies = [] |
|
|
287 | 295 | relations_from.each do |relation| |
|
|
288 | 296 | dependencies << relation.issue_to |
|
|
289 | 297 | dependencies += relation.issue_to.all_dependent_issues |
|
|
290 | 298 | end |
|
|
291 | 299 | dependencies |
|
|
292 | 300 | end |
|
|
293 | 301 | |
|
|
294 | 302 | # Returns an array of issues that duplicate this one |
|
|
295 | 303 | def duplicates |
|
|
296 | 304 | relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from} |
|
|
297 | 305 | end |
|
|
298 | 306 | |
|
|
299 | 307 | # Returns the due date or the target due date if any |
|
|
300 | 308 | # Used on gantt chart |
|
|
301 | 309 | def due_before |
|
|
302 | 310 | due_date || (fixed_version ? fixed_version.effective_date : nil) |
|
|
303 | 311 | end |
|
|
304 | 312 | |
|
|
305 | 313 | # Returns the time scheduled for this issue. |
|
|
306 | 314 | # |
|
|
307 | 315 | # Example: |
|
|
308 | 316 | # Start Date: 2/26/09, End Date: 3/04/09 |
|
|
309 | 317 | # duration => 6 |
|
|
310 | 318 | def duration |
|
|
311 | 319 | (start_date && due_date) ? due_date - start_date : 0 |
|
|
312 | 320 | end |
|
|
313 | 321 | |
|
|
314 | 322 | def soonest_start |
|
|
315 | 323 | @soonest_start ||= relations_to.collect{|relation| relation.successor_soonest_start}.compact.min |
|
|
316 | 324 | end |
|
|
317 | 325 | |
|
|
318 | 326 | def to_s |
|
|
319 | 327 | "#{tracker} ##{id}: #{subject}" |
|
|
320 | 328 | end |
|
|
321 | 329 | |
|
|
322 | 330 | # Returns a string of css classes that apply to the issue |
|
|
323 | 331 | def css_classes |
|
|
324 | 332 | s = "issue status-#{status.position} priority-#{priority.position}" |
|
|
325 | 333 | s << ' closed' if closed? |
|
|
326 | 334 | s << ' overdue' if overdue? |
|
|
327 | 335 | s << ' created-by-me' if User.current.logged? && author_id == User.current.id |
|
|
328 | 336 | s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id |
|
|
329 | 337 | s |
|
|
330 | 338 | end |
|
|
331 | 339 | |
|
|
332 | 340 | private |
|
|
333 | 341 | |
|
|
334 | 342 | # Callback on attachment deletion |
|
|
335 | 343 | def attachment_removed(obj) |
|
|
336 | 344 | journal = init_journal(User.current) |
|
|
337 | 345 | journal.details << JournalDetail.new(:property => 'attachment', |
|
|
338 | 346 | :prop_key => obj.id, |
|
|
339 | 347 | :old_value => obj.filename) |
|
|
340 | 348 | journal.save |
|
|
341 | 349 | end |
|
|
342 | 350 | |
|
|
343 | 351 | # Saves the changes in a Journal |
|
|
344 | 352 | # Called after_save |
|
|
345 | 353 | def create_journal |
|
|
346 | 354 | if @current_journal |
|
|
347 | 355 | # attributes changes |
|
|
348 | 356 | (Issue.column_names - %w(id description lock_version created_on updated_on)).each {|c| |
|
|
349 | 357 | @current_journal.details << JournalDetail.new(:property => 'attr', |
|
|
350 | 358 | :prop_key => c, |
|
|
351 | 359 | :old_value => @issue_before_change.send(c), |
|
|
352 | 360 | :value => send(c)) unless send(c)==@issue_before_change.send(c) |
|
|
353 | 361 | } |
|
|
354 | 362 | # custom fields changes |
|
|
355 | 363 | custom_values.each {|c| |
|
|
356 | 364 | next if (@custom_values_before_change[c.custom_field_id]==c.value || |
|
|
357 | 365 | (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?)) |
|
|
358 | 366 | @current_journal.details << JournalDetail.new(:property => 'cf', |
|
|
359 | 367 | :prop_key => c.custom_field_id, |
|
|
360 | 368 | :old_value => @custom_values_before_change[c.custom_field_id], |
|
|
361 | 369 | :value => c.value) |
|
|
362 | 370 | } |
|
|
363 | 371 | @current_journal.save |
|
|
364 | 372 | end |
|
|
365 | 373 | end |
|
|
366 | 374 | end |
| @@ -1,43 +1,54 | |||
|
|
1 | 1 | # redMine - project management software |
|
|
2 | 2 | # Copyright (C) 2006 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | class Workflow < ActiveRecord::Base |
|
|
19 | 19 | belongs_to :role |
|
|
20 | 20 | belongs_to :old_status, :class_name => 'IssueStatus', :foreign_key => 'old_status_id' |
|
|
21 | 21 | belongs_to :new_status, :class_name => 'IssueStatus', :foreign_key => 'new_status_id' |
|
|
22 | 22 | |
|
|
23 | 23 | validates_presence_of :role, :old_status, :new_status |
|
|
24 | 24 | |
|
|
25 | 25 | # Returns workflow transitions count by tracker and role |
|
|
26 | 26 | def self.count_by_tracker_and_role |
|
|
27 | 27 | counts = connection.select_all("SELECT role_id, tracker_id, count(id) AS c FROM #{Workflow.table_name} GROUP BY role_id, tracker_id") |
|
|
28 | 28 | roles = Role.find(:all, :order => 'builtin, position') |
|
|
29 | 29 | trackers = Tracker.find(:all, :order => 'position') |
|
|
30 | 30 | |
|
|
31 | 31 | result = [] |
|
|
32 | 32 | trackers.each do |tracker| |
|
|
33 | 33 | t = [] |
|
|
34 | 34 | roles.each do |role| |
|
|
35 | 35 | row = counts.detect {|c| c['role_id'] == role.id.to_s && c['tracker_id'] == tracker.id.to_s} |
|
|
36 | 36 | t << [role, (row.nil? ? 0 : row['c'].to_i)] |
|
|
37 | 37 | end |
|
|
38 | 38 | result << [tracker, t] |
|
|
39 | 39 | end |
|
|
40 | 40 | |
|
|
41 | 41 | result |
|
|
42 | 42 | end |
|
|
43 | ||
|
|
44 | # Find potential statuses the user could be allowed to switch issues to | |
|
|
45 | def self.available_statuses(project, user=User.current) | |
|
|
46 | Workflow.find(:all, | |
|
|
47 | :include => :new_status, | |
|
|
48 | :conditions => {:role_id => user.roles_for_project(project).collect(&:id)}). | |
|
|
49 | collect(&:new_status). | |
|
|
50 | compact. | |
|
|
51 | uniq. | |
|
|
52 | sort | |
|
|
53 | end | |
|
|
43 | 54 | end |
| @@ -1,108 +1,114 | |||
|
|
1 | 1 | <ul> |
|
|
2 | 2 | <%= call_hook(:view_issues_context_menu_start, {:issues => @issues, :can => @can, :back => @back }) %> |
|
|
3 | 3 | |
|
|
4 | 4 | <% if !@issue.nil? -%> |
|
|
5 | 5 | <li><%= context_menu_link l(:button_edit), {:controller => 'issues', :action => 'edit', :id => @issue}, |
|
|
6 | 6 | :class => 'icon-edit', :disabled => !@can[:edit] %></li> |
|
|
7 | 7 | <li class="folder"> |
|
|
8 | 8 | <a href="#" class="submenu" onclick="return false;"><%= l(:field_status) %></a> |
|
|
9 | 9 | <ul> |
|
|
10 | 10 | <% @statuses.each do |s| -%> |
|
|
11 | 11 | <li><%= context_menu_link s.name, {:controller => 'issues', :action => 'edit', :id => @issue, :issue => {:status_id => s}, :back_to => @back}, :method => :post, |
|
|
12 | 12 | :selected => (s == @issue.status), :disabled => !(@can[:update] && @allowed_statuses.include?(s)) %></li> |
|
|
13 | 13 | <% end -%> |
|
|
14 | 14 | </ul> |
|
|
15 | 15 | </li> |
|
|
16 | 16 | <% else %> |
|
|
17 | 17 | <li><%= context_menu_link l(:button_edit), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id)}, |
|
|
18 | 18 | :class => 'icon-edit', :disabled => !@can[:edit] %></li> |
|
|
19 | 19 | <% end %> |
|
|
20 | 20 | |
|
|
21 | 21 | <% unless @trackers.nil? %> |
|
|
22 | 22 | <li class="folder"> |
|
|
23 | 23 | <a href="#" class="submenu"><%= l(:field_tracker) %></a> |
|
|
24 | 24 | <ul> |
|
|
25 | 25 | <% @trackers.each do |t| -%> |
|
|
26 | 26 | <li><%= context_menu_link t.name, {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'tracker_id' => t, :back_to => @back}, :method => :post, |
|
|
27 | 27 | :selected => (@issue && t == @issue.tracker), :disabled => !@can[:edit] %></li> |
|
|
28 | 28 | <% end -%> |
|
|
29 | 29 | </ul> |
|
|
30 | 30 | </li> |
|
|
31 | 31 | <% end %> |
|
|
32 | 32 | <li class="folder"> |
|
|
33 | 33 | <a href="#" class="submenu"><%= l(:field_priority) %></a> |
|
|
34 | 34 | <ul> |
|
|
35 | 35 | <% @priorities.each do |p| -%> |
|
|
36 | 36 | <li><%= context_menu_link p.name, {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'priority_id' => p, :back_to => @back}, :method => :post, |
|
|
37 | 37 | :selected => (@issue && p == @issue.priority), :disabled => !@can[:edit] %></li> |
|
|
38 | 38 | <% end -%> |
|
|
39 | 39 | </ul> |
|
|
40 | 40 | </li> |
|
|
41 | 41 | <% unless @project.nil? || @project.versions.open.empty? -%> |
|
|
42 | 42 | <li class="folder"> |
|
|
43 | 43 | <a href="#" class="submenu"><%= l(:field_fixed_version) %></a> |
|
|
44 | 44 | <ul> |
|
|
45 | 45 | <% @project.versions.open.sort.each do |v| -%> |
|
|
46 | 46 | <li><%= context_menu_link v.name, {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'fixed_version_id' => v, :back_to => @back}, :method => :post, |
|
|
47 | 47 | :selected => (@issue && v == @issue.fixed_version), :disabled => !@can[:update] %></li> |
|
|
48 | 48 | <% end -%> |
|
|
49 | 49 | <li><%= context_menu_link l(:label_none), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'fixed_version_id' => 'none', :back_to => @back}, :method => :post, |
|
|
50 | 50 | :selected => (@issue && @issue.fixed_version.nil?), :disabled => !@can[:update] %></li> |
|
|
51 | 51 | </ul> |
|
|
52 | 52 | </li> |
|
|
53 | 53 | <% end %> |
|
|
54 | 54 | <% unless @assignables.nil? || @assignables.empty? -%> |
|
|
55 | 55 | <li class="folder"> |
|
|
56 | 56 | <a href="#" class="submenu"><%= l(:field_assigned_to) %></a> |
|
|
57 | 57 | <ul> |
|
|
58 | 58 | <% @assignables.each do |u| -%> |
|
|
59 | 59 | <li><%= context_menu_link u.name, {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'assigned_to_id' => u, :back_to => @back}, :method => :post, |
|
|
60 | 60 | :selected => (@issue && u == @issue.assigned_to), :disabled => !@can[:update] %></li> |
|
|
61 | 61 | <% end -%> |
|
|
62 | 62 | <li><%= context_menu_link l(:label_nobody), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'assigned_to_id' => 'none', :back_to => @back}, :method => :post, |
|
|
63 | 63 | :selected => (@issue && @issue.assigned_to.nil?), :disabled => !@can[:update] %></li> |
|
|
64 | 64 | </ul> |
|
|
65 | 65 | </li> |
|
|
66 | 66 | <% end %> |
|
|
67 | 67 | <% unless @project.nil? || @project.issue_categories.empty? -%> |
|
|
68 | 68 | <li class="folder"> |
|
|
69 | 69 | <a href="#" class="submenu"><%= l(:field_category) %></a> |
|
|
70 | 70 | <ul> |
|
|
71 | 71 | <% @project.issue_categories.each do |u| -%> |
|
|
72 | 72 | <li><%= context_menu_link u.name, {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'category_id' => u, :back_to => @back}, :method => :post, |
|
|
73 | 73 | :selected => (@issue && u == @issue.category), :disabled => !@can[:update] %></li> |
|
|
74 | 74 | <% end -%> |
|
|
75 | 75 | <li><%= context_menu_link l(:label_none), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'category_id' => 'none', :back_to => @back}, :method => :post, |
|
|
76 | 76 | :selected => (@issue && @issue.category.nil?), :disabled => !@can[:update] %></li> |
|
|
77 | 77 | </ul> |
|
|
78 | 78 | </li> |
|
|
79 | 79 | <% end -%> |
|
|
80 | 80 | <li class="folder"> |
|
|
81 | 81 | <a href="#" class="submenu"><%= l(:field_done_ratio) %></a> |
|
|
82 | 82 | <ul> |
|
|
83 | 83 | <% (0..10).map{|x|x*10}.each do |p| -%> |
|
|
84 | 84 | <li><%= context_menu_link "#{p}%", {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), 'done_ratio' => p, :back_to => @back}, :method => :post, |
|
|
85 | 85 | :selected => (@issue && p == @issue.done_ratio), :disabled => !@can[:edit] %></li> |
|
|
86 | 86 | <% end -%> |
|
|
87 | 87 | </ul> |
|
|
88 | 88 | </li> |
|
|
89 | 89 | |
|
|
90 | 90 | <% if !@issue.nil? %> |
|
|
91 | <li><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'new', :project_id => @project, :copy_from => @issue}, | |
|
|
92 | :class => 'icon-copy', :disabled => !@can[:copy] %></li> | |
|
|
93 | 91 | <% if @can[:log_time] -%> |
|
|
94 | 92 | <li><%= context_menu_link l(:button_log_time), {:controller => 'timelog', :action => 'edit', :issue_id => @issue}, |
|
|
95 | 93 | :class => 'icon-time-add' %></li> |
|
|
96 | 94 | <% end %> |
|
|
97 | 95 | <% if User.current.logged? %> |
|
|
98 | 96 | <li><%= watcher_link(@issue, User.current) %></li> |
|
|
99 | 97 | <% end %> |
|
|
100 | 98 | <% end %> |
|
|
101 | 99 | |
|
|
100 | <% if @issue.present? %> | |
|
|
101 | <li><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'new', :project_id => @project, :copy_from => @issue}, | |
|
|
102 | :class => 'icon-copy', :disabled => !@can[:copy] %></li> | |
|
|
103 | <% else %> | |
|
|
104 | <li><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'move', :ids => @issues.collect(&:id), :copy_options => {:copy => 't'}}, | |
|
|
105 | :class => 'icon-copy', :disabled => !@can[:move] %></li> | |
|
|
106 | <% end %> | |
|
|
107 | ||
|
|
102 | 108 | <li><%= context_menu_link l(:button_move), {:controller => 'issues', :action => 'move', :ids => @issues.collect(&:id)}, |
|
|
103 | 109 | :class => 'icon-move', :disabled => !@can[:move] %></li> |
|
|
104 | 110 | <li><%= context_menu_link l(:button_delete), {:controller => 'issues', :action => 'destroy', :ids => @issues.collect(&:id)}, |
|
|
105 | 111 | :method => :post, :confirm => l(:text_issues_destroy_confirmation), :class => 'icon-del', :disabled => !@can[:delete] %></li> |
|
|
106 | 112 | |
|
|
107 | 113 | <%= call_hook(:view_issues_context_menu_end, {:issues => @issues, :can => @can, :back => @back }) %> |
|
|
108 | 114 | </ul> |
| @@ -1,30 +1,52 | |||
|
|
1 | 1 | <h2><%= l(:button_move) %></h2> |
|
|
2 | 2 | |
|
|
3 | 3 | <ul> |
|
|
4 | 4 | <% @issues.each do |issue| -%> |
|
|
5 | 5 | <li><%= link_to_issue issue %></li> |
|
|
6 | 6 | <% end -%> |
|
|
7 | 7 | </ul> |
|
|
8 | 8 | |
|
|
9 | 9 | <% form_tag({}, :id => 'move_form') do %> |
|
|
10 | 10 | <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join %> |
|
|
11 | 11 | |
|
|
12 | 12 | <div class="box tabular"> |
|
|
13 | 13 | <p><label for="new_project_id"><%=l(:field_project)%>:</label> |
|
|
14 | 14 | <%= select_tag "new_project_id", |
|
|
15 | 15 | project_tree_options_for_select(@allowed_projects, :selected => @target_project), |
|
|
16 | 16 | :onchange => remote_function(:url => { :action => 'move' }, |
|
|
17 | 17 | :method => :get, |
|
|
18 | 18 | :update => 'content', |
|
|
19 | 19 | :with => "Form.serialize('move_form')") %></p> |
|
|
20 | 20 | |
|
|
21 | 21 | <p><label for="new_tracker_id"><%=l(:field_tracker)%>:</label> |
|
|
22 | 22 | <%= select_tag "new_tracker_id", "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, "id", "name") %></p> |
|
|
23 | 23 | |
|
|
24 | <p> | |
|
|
25 | <label><%= l(:field_assigned_to) %></label> | |
|
|
26 | <%= select_tag('assigned_to_id', content_tag('option', l(:label_no_change_option), :value => '') + | |
|
|
27 | content_tag('option', l(:label_nobody), :value => 'none') + | |
|
|
28 | options_from_collection_for_select(@target_project.assignable_users, :id, :name)) %> | |
|
|
29 | </p> | |
|
|
30 | ||
|
|
31 | <p> | |
|
|
32 | <label><%= l(:field_status) %></label> | |
|
|
33 | <%= select_tag('status_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %> | |
|
|
34 | </p> | |
|
|
35 | ||
|
|
36 | <p> | |
|
|
37 | <label><%= l(:field_start_date) %></label> | |
|
|
38 | <%= text_field_tag 'start_date', '', :size => 10 %><%= calendar_for('start_date') %> | |
|
|
39 | </p> | |
|
|
40 | ||
|
|
41 | <p> | |
|
|
42 | <label><%= l(:field_due_date) %></label> | |
|
|
43 | <%= text_field_tag 'due_date', '', :size => 10 %><%= calendar_for('due_date') %> | |
|
|
44 | </p> | |
|
|
45 | ||
|
|
24 | 46 | <p><label for="copy_options_copy"><%= l(:button_copy)%></label> |
|
|
25 | <%= check_box_tag "copy_options[copy]", "1" %></p> | |
|
|
47 | <%= check_box_tag "copy_options[copy]", "1", @copy %></p> | |
|
|
26 | 48 | </div> |
|
|
27 | 49 | |
|
|
28 | 50 | <%= submit_tag l(:button_move) %> |
|
|
29 | 51 | <%= submit_tag l(:button_move_and_follow), :name => 'follow' %> |
|
|
30 | 52 | <% end %> |
| @@ -1,1194 +1,1218 | |||
|
|
1 | 1 | # Redmine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2008 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | require File.dirname(__FILE__) + '/../test_helper' |
|
|
19 | 19 | require 'issues_controller' |
|
|
20 | 20 | |
|
|
21 | 21 | # Re-raise errors caught by the controller. |
|
|
22 | 22 | class IssuesController; def rescue_action(e) raise e end; end |
|
|
23 | 23 | |
|
|
24 | 24 | class IssuesControllerTest < ActionController::TestCase |
|
|
25 | 25 | fixtures :projects, |
|
|
26 | 26 | :users, |
|
|
27 | 27 | :roles, |
|
|
28 | 28 | :members, |
|
|
29 | 29 | :member_roles, |
|
|
30 | 30 | :issues, |
|
|
31 | 31 | :issue_statuses, |
|
|
32 | 32 | :versions, |
|
|
33 | 33 | :trackers, |
|
|
34 | 34 | :projects_trackers, |
|
|
35 | 35 | :issue_categories, |
|
|
36 | 36 | :enabled_modules, |
|
|
37 | 37 | :enumerations, |
|
|
38 | 38 | :attachments, |
|
|
39 | 39 | :workflows, |
|
|
40 | 40 | :custom_fields, |
|
|
41 | 41 | :custom_values, |
|
|
42 | 42 | :custom_fields_projects, |
|
|
43 | 43 | :custom_fields_trackers, |
|
|
44 | 44 | :time_entries, |
|
|
45 | 45 | :journals, |
|
|
46 | 46 | :journal_details, |
|
|
47 | 47 | :queries |
|
|
48 | 48 | |
|
|
49 | 49 | def setup |
|
|
50 | 50 | @controller = IssuesController.new |
|
|
51 | 51 | @request = ActionController::TestRequest.new |
|
|
52 | 52 | @response = ActionController::TestResponse.new |
|
|
53 | 53 | User.current = nil |
|
|
54 | 54 | end |
|
|
55 | 55 | |
|
|
56 | 56 | def test_index_routing |
|
|
57 | 57 | assert_routing( |
|
|
58 | 58 | {:method => :get, :path => '/issues'}, |
|
|
59 | 59 | :controller => 'issues', :action => 'index' |
|
|
60 | 60 | ) |
|
|
61 | 61 | end |
|
|
62 | 62 | |
|
|
63 | 63 | def test_index |
|
|
64 | 64 | Setting.default_language = 'en' |
|
|
65 | 65 | |
|
|
66 | 66 | get :index |
|
|
67 | 67 | assert_response :success |
|
|
68 | 68 | assert_template 'index.rhtml' |
|
|
69 | 69 | assert_not_nil assigns(:issues) |
|
|
70 | 70 | assert_nil assigns(:project) |
|
|
71 | 71 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
72 | 72 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
73 | 73 | # private projects hidden |
|
|
74 | 74 | assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
75 | 75 | assert_no_tag :tag => 'a', :content => /Issue on project 2/ |
|
|
76 | 76 | # project column |
|
|
77 | 77 | assert_tag :tag => 'th', :content => /Project/ |
|
|
78 | 78 | end |
|
|
79 | 79 | |
|
|
80 | 80 | def test_index_should_not_list_issues_when_module_disabled |
|
|
81 | 81 | EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") |
|
|
82 | 82 | get :index |
|
|
83 | 83 | assert_response :success |
|
|
84 | 84 | assert_template 'index.rhtml' |
|
|
85 | 85 | assert_not_nil assigns(:issues) |
|
|
86 | 86 | assert_nil assigns(:project) |
|
|
87 | 87 | assert_no_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
88 | 88 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
89 | 89 | end |
|
|
90 | 90 | |
|
|
91 | 91 | def test_index_with_project_routing |
|
|
92 | 92 | assert_routing( |
|
|
93 | 93 | {:method => :get, :path => '/projects/23/issues'}, |
|
|
94 | 94 | :controller => 'issues', :action => 'index', :project_id => '23' |
|
|
95 | 95 | ) |
|
|
96 | 96 | end |
|
|
97 | 97 | |
|
|
98 | 98 | def test_index_should_not_list_issues_when_module_disabled |
|
|
99 | 99 | EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") |
|
|
100 | 100 | get :index |
|
|
101 | 101 | assert_response :success |
|
|
102 | 102 | assert_template 'index.rhtml' |
|
|
103 | 103 | assert_not_nil assigns(:issues) |
|
|
104 | 104 | assert_nil assigns(:project) |
|
|
105 | 105 | assert_no_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
106 | 106 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
107 | 107 | end |
|
|
108 | 108 | |
|
|
109 | 109 | def test_index_with_project_routing |
|
|
110 | 110 | assert_routing( |
|
|
111 | 111 | {:method => :get, :path => 'projects/23/issues'}, |
|
|
112 | 112 | :controller => 'issues', :action => 'index', :project_id => '23' |
|
|
113 | 113 | ) |
|
|
114 | 114 | end |
|
|
115 | 115 | |
|
|
116 | 116 | def test_index_with_project |
|
|
117 | 117 | Setting.display_subprojects_issues = 0 |
|
|
118 | 118 | get :index, :project_id => 1 |
|
|
119 | 119 | assert_response :success |
|
|
120 | 120 | assert_template 'index.rhtml' |
|
|
121 | 121 | assert_not_nil assigns(:issues) |
|
|
122 | 122 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
123 | 123 | assert_no_tag :tag => 'a', :content => /Subproject issue/ |
|
|
124 | 124 | end |
|
|
125 | 125 | |
|
|
126 | 126 | def test_index_with_project_and_subprojects |
|
|
127 | 127 | Setting.display_subprojects_issues = 1 |
|
|
128 | 128 | get :index, :project_id => 1 |
|
|
129 | 129 | assert_response :success |
|
|
130 | 130 | assert_template 'index.rhtml' |
|
|
131 | 131 | assert_not_nil assigns(:issues) |
|
|
132 | 132 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
133 | 133 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
134 | 134 | assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
135 | 135 | end |
|
|
136 | 136 | |
|
|
137 | 137 | def test_index_with_project_and_subprojects_should_show_private_subprojects |
|
|
138 | 138 | @request.session[:user_id] = 2 |
|
|
139 | 139 | Setting.display_subprojects_issues = 1 |
|
|
140 | 140 | get :index, :project_id => 1 |
|
|
141 | 141 | assert_response :success |
|
|
142 | 142 | assert_template 'index.rhtml' |
|
|
143 | 143 | assert_not_nil assigns(:issues) |
|
|
144 | 144 | assert_tag :tag => 'a', :content => /Can't print recipes/ |
|
|
145 | 145 | assert_tag :tag => 'a', :content => /Subproject issue/ |
|
|
146 | 146 | assert_tag :tag => 'a', :content => /Issue of a private subproject/ |
|
|
147 | 147 | end |
|
|
148 | 148 | |
|
|
149 | 149 | def test_index_with_project_routing_formatted |
|
|
150 | 150 | assert_routing( |
|
|
151 | 151 | {:method => :get, :path => 'projects/23/issues.pdf'}, |
|
|
152 | 152 | :controller => 'issues', :action => 'index', :project_id => '23', :format => 'pdf' |
|
|
153 | 153 | ) |
|
|
154 | 154 | assert_routing( |
|
|
155 | 155 | {:method => :get, :path => 'projects/23/issues.atom'}, |
|
|
156 | 156 | :controller => 'issues', :action => 'index', :project_id => '23', :format => 'atom' |
|
|
157 | 157 | ) |
|
|
158 | 158 | end |
|
|
159 | 159 | |
|
|
160 | 160 | def test_index_with_project_and_filter |
|
|
161 | 161 | get :index, :project_id => 1, :set_filter => 1 |
|
|
162 | 162 | assert_response :success |
|
|
163 | 163 | assert_template 'index.rhtml' |
|
|
164 | 164 | assert_not_nil assigns(:issues) |
|
|
165 | 165 | end |
|
|
166 | 166 | |
|
|
167 | 167 | def test_index_with_query |
|
|
168 | 168 | get :index, :project_id => 1, :query_id => 5 |
|
|
169 | 169 | assert_response :success |
|
|
170 | 170 | assert_template 'index.rhtml' |
|
|
171 | 171 | assert_not_nil assigns(:issues) |
|
|
172 | 172 | assert_nil assigns(:issue_count_by_group) |
|
|
173 | 173 | end |
|
|
174 | 174 | |
|
|
175 | 175 | def test_index_with_query_grouped_by_tracker |
|
|
176 | 176 | get :index, :project_id => 1, :query_id => 6 |
|
|
177 | 177 | assert_response :success |
|
|
178 | 178 | assert_template 'index.rhtml' |
|
|
179 | 179 | assert_not_nil assigns(:issues) |
|
|
180 | 180 | assert_not_nil assigns(:issue_count_by_group) |
|
|
181 | 181 | end |
|
|
182 | 182 | |
|
|
183 | 183 | def test_index_with_query_grouped_by_list_custom_field |
|
|
184 | 184 | get :index, :project_id => 1, :query_id => 9 |
|
|
185 | 185 | assert_response :success |
|
|
186 | 186 | assert_template 'index.rhtml' |
|
|
187 | 187 | assert_not_nil assigns(:issues) |
|
|
188 | 188 | assert_not_nil assigns(:issue_count_by_group) |
|
|
189 | 189 | end |
|
|
190 | 190 | |
|
|
191 | 191 | def test_index_sort_by_field_not_included_in_columns |
|
|
192 | 192 | Setting.issue_list_default_columns = %w(subject author) |
|
|
193 | 193 | get :index, :sort => 'tracker' |
|
|
194 | 194 | end |
|
|
195 | 195 | |
|
|
196 | 196 | def test_index_csv_with_project |
|
|
197 | 197 | Setting.default_language = 'en' |
|
|
198 | 198 | |
|
|
199 | 199 | get :index, :format => 'csv' |
|
|
200 | 200 | assert_response :success |
|
|
201 | 201 | assert_not_nil assigns(:issues) |
|
|
202 | 202 | assert_equal 'text/csv', @response.content_type |
|
|
203 | 203 | assert @response.body.starts_with?("#,") |
|
|
204 | 204 | |
|
|
205 | 205 | get :index, :project_id => 1, :format => 'csv' |
|
|
206 | 206 | assert_response :success |
|
|
207 | 207 | assert_not_nil assigns(:issues) |
|
|
208 | 208 | assert_equal 'text/csv', @response.content_type |
|
|
209 | 209 | end |
|
|
210 | 210 | |
|
|
211 | 211 | def test_index_formatted |
|
|
212 | 212 | assert_routing( |
|
|
213 | 213 | {:method => :get, :path => 'issues.pdf'}, |
|
|
214 | 214 | :controller => 'issues', :action => 'index', :format => 'pdf' |
|
|
215 | 215 | ) |
|
|
216 | 216 | assert_routing( |
|
|
217 | 217 | {:method => :get, :path => 'issues.atom'}, |
|
|
218 | 218 | :controller => 'issues', :action => 'index', :format => 'atom' |
|
|
219 | 219 | ) |
|
|
220 | 220 | end |
|
|
221 | 221 | |
|
|
222 | 222 | def test_index_pdf |
|
|
223 | 223 | get :index, :format => 'pdf' |
|
|
224 | 224 | assert_response :success |
|
|
225 | 225 | assert_not_nil assigns(:issues) |
|
|
226 | 226 | assert_equal 'application/pdf', @response.content_type |
|
|
227 | 227 | |
|
|
228 | 228 | get :index, :project_id => 1, :format => 'pdf' |
|
|
229 | 229 | assert_response :success |
|
|
230 | 230 | assert_not_nil assigns(:issues) |
|
|
231 | 231 | assert_equal 'application/pdf', @response.content_type |
|
|
232 | 232 | |
|
|
233 | 233 | get :index, :project_id => 1, :query_id => 6, :format => 'pdf' |
|
|
234 | 234 | assert_response :success |
|
|
235 | 235 | assert_not_nil assigns(:issues) |
|
|
236 | 236 | assert_equal 'application/pdf', @response.content_type |
|
|
237 | 237 | end |
|
|
238 | 238 | |
|
|
239 | 239 | def test_index_sort |
|
|
240 | 240 | get :index, :sort => 'tracker,id:desc' |
|
|
241 | 241 | assert_response :success |
|
|
242 | 242 | |
|
|
243 | 243 | sort_params = @request.session['issues_index_sort'] |
|
|
244 | 244 | assert sort_params.is_a?(String) |
|
|
245 | 245 | assert_equal 'tracker,id:desc', sort_params |
|
|
246 | 246 | |
|
|
247 | 247 | issues = assigns(:issues) |
|
|
248 | 248 | assert_not_nil issues |
|
|
249 | 249 | assert !issues.empty? |
|
|
250 | 250 | assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id) |
|
|
251 | 251 | end |
|
|
252 | 252 | |
|
|
253 | 253 | def test_index_with_columns |
|
|
254 | 254 | columns = ['tracker', 'subject', 'assigned_to'] |
|
|
255 | 255 | get :index, :set_filter => 1, :query => { 'column_names' => columns} |
|
|
256 | 256 | assert_response :success |
|
|
257 | 257 | |
|
|
258 | 258 | # query should use specified columns |
|
|
259 | 259 | query = assigns(:query) |
|
|
260 | 260 | assert_kind_of Query, query |
|
|
261 | 261 | assert_equal columns, query.column_names.map(&:to_s) |
|
|
262 | 262 | |
|
|
263 | 263 | # columns should be stored in session |
|
|
264 | 264 | assert_kind_of Hash, session[:query] |
|
|
265 | 265 | assert_kind_of Array, session[:query][:column_names] |
|
|
266 | 266 | assert_equal columns, session[:query][:column_names].map(&:to_s) |
|
|
267 | 267 | end |
|
|
268 | 268 | |
|
|
269 | 269 | def test_gantt |
|
|
270 | 270 | get :gantt, :project_id => 1 |
|
|
271 | 271 | assert_response :success |
|
|
272 | 272 | assert_template 'gantt.rhtml' |
|
|
273 | 273 | assert_not_nil assigns(:gantt) |
|
|
274 | 274 | events = assigns(:gantt).events |
|
|
275 | 275 | assert_not_nil events |
|
|
276 | 276 | # Issue with start and due dates |
|
|
277 | 277 | i = Issue.find(1) |
|
|
278 | 278 | assert_not_nil i.due_date |
|
|
279 | 279 | assert events.include?(Issue.find(1)) |
|
|
280 | 280 | # Issue with without due date but targeted to a version with date |
|
|
281 | 281 | i = Issue.find(2) |
|
|
282 | 282 | assert_nil i.due_date |
|
|
283 | 283 | assert events.include?(i) |
|
|
284 | 284 | end |
|
|
285 | 285 | |
|
|
286 | 286 | def test_cross_project_gantt |
|
|
287 | 287 | get :gantt |
|
|
288 | 288 | assert_response :success |
|
|
289 | 289 | assert_template 'gantt.rhtml' |
|
|
290 | 290 | assert_not_nil assigns(:gantt) |
|
|
291 | 291 | events = assigns(:gantt).events |
|
|
292 | 292 | assert_not_nil events |
|
|
293 | 293 | end |
|
|
294 | 294 | |
|
|
295 | 295 | def test_gantt_export_to_pdf |
|
|
296 | 296 | get :gantt, :project_id => 1, :format => 'pdf' |
|
|
297 | 297 | assert_response :success |
|
|
298 | 298 | assert_equal 'application/pdf', @response.content_type |
|
|
299 | 299 | assert @response.body.starts_with?('%PDF') |
|
|
300 | 300 | assert_not_nil assigns(:gantt) |
|
|
301 | 301 | end |
|
|
302 | 302 | |
|
|
303 | 303 | def test_cross_project_gantt_export_to_pdf |
|
|
304 | 304 | get :gantt, :format => 'pdf' |
|
|
305 | 305 | assert_response :success |
|
|
306 | 306 | assert_equal 'application/pdf', @response.content_type |
|
|
307 | 307 | assert @response.body.starts_with?('%PDF') |
|
|
308 | 308 | assert_not_nil assigns(:gantt) |
|
|
309 | 309 | end |
|
|
310 | 310 | |
|
|
311 | 311 | if Object.const_defined?(:Magick) |
|
|
312 | 312 | def test_gantt_image |
|
|
313 | 313 | get :gantt, :project_id => 1, :format => 'png' |
|
|
314 | 314 | assert_response :success |
|
|
315 | 315 | assert_equal 'image/png', @response.content_type |
|
|
316 | 316 | end |
|
|
317 | 317 | else |
|
|
318 | 318 | puts "RMagick not installed. Skipping tests !!!" |
|
|
319 | 319 | end |
|
|
320 | 320 | |
|
|
321 | 321 | def test_calendar |
|
|
322 | 322 | get :calendar, :project_id => 1 |
|
|
323 | 323 | assert_response :success |
|
|
324 | 324 | assert_template 'calendar' |
|
|
325 | 325 | assert_not_nil assigns(:calendar) |
|
|
326 | 326 | end |
|
|
327 | 327 | |
|
|
328 | 328 | def test_cross_project_calendar |
|
|
329 | 329 | get :calendar |
|
|
330 | 330 | assert_response :success |
|
|
331 | 331 | assert_template 'calendar' |
|
|
332 | 332 | assert_not_nil assigns(:calendar) |
|
|
333 | 333 | end |
|
|
334 | 334 | |
|
|
335 | 335 | def test_changes |
|
|
336 | 336 | get :changes, :project_id => 1 |
|
|
337 | 337 | assert_response :success |
|
|
338 | 338 | assert_not_nil assigns(:journals) |
|
|
339 | 339 | assert_equal 'application/atom+xml', @response.content_type |
|
|
340 | 340 | end |
|
|
341 | 341 | |
|
|
342 | 342 | def test_show_routing |
|
|
343 | 343 | assert_routing( |
|
|
344 | 344 | {:method => :get, :path => '/issues/64'}, |
|
|
345 | 345 | :controller => 'issues', :action => 'show', :id => '64' |
|
|
346 | 346 | ) |
|
|
347 | 347 | end |
|
|
348 | 348 | |
|
|
349 | 349 | def test_show_routing_formatted |
|
|
350 | 350 | assert_routing( |
|
|
351 | 351 | {:method => :get, :path => '/issues/2332.pdf'}, |
|
|
352 | 352 | :controller => 'issues', :action => 'show', :id => '2332', :format => 'pdf' |
|
|
353 | 353 | ) |
|
|
354 | 354 | assert_routing( |
|
|
355 | 355 | {:method => :get, :path => '/issues/23123.atom'}, |
|
|
356 | 356 | :controller => 'issues', :action => 'show', :id => '23123', :format => 'atom' |
|
|
357 | 357 | ) |
|
|
358 | 358 | end |
|
|
359 | 359 | |
|
|
360 | 360 | def test_show_by_anonymous |
|
|
361 | 361 | get :show, :id => 1 |
|
|
362 | 362 | assert_response :success |
|
|
363 | 363 | assert_template 'show.rhtml' |
|
|
364 | 364 | assert_not_nil assigns(:issue) |
|
|
365 | 365 | assert_equal Issue.find(1), assigns(:issue) |
|
|
366 | 366 | |
|
|
367 | 367 | # anonymous role is allowed to add a note |
|
|
368 | 368 | assert_tag :tag => 'form', |
|
|
369 | 369 | :descendant => { :tag => 'fieldset', |
|
|
370 | 370 | :child => { :tag => 'legend', |
|
|
371 | 371 | :content => /Notes/ } } |
|
|
372 | 372 | end |
|
|
373 | 373 | |
|
|
374 | 374 | def test_show_by_manager |
|
|
375 | 375 | @request.session[:user_id] = 2 |
|
|
376 | 376 | get :show, :id => 1 |
|
|
377 | 377 | assert_response :success |
|
|
378 | 378 | |
|
|
379 | 379 | assert_tag :tag => 'form', |
|
|
380 | 380 | :descendant => { :tag => 'fieldset', |
|
|
381 | 381 | :child => { :tag => 'legend', |
|
|
382 | 382 | :content => /Change properties/ } }, |
|
|
383 | 383 | :descendant => { :tag => 'fieldset', |
|
|
384 | 384 | :child => { :tag => 'legend', |
|
|
385 | 385 | :content => /Log time/ } }, |
|
|
386 | 386 | :descendant => { :tag => 'fieldset', |
|
|
387 | 387 | :child => { :tag => 'legend', |
|
|
388 | 388 | :content => /Notes/ } } |
|
|
389 | 389 | end |
|
|
390 | 390 | |
|
|
391 | 391 | def test_show_should_deny_anonymous_access_without_permission |
|
|
392 | 392 | Role.anonymous.remove_permission!(:view_issues) |
|
|
393 | 393 | get :show, :id => 1 |
|
|
394 | 394 | assert_response :redirect |
|
|
395 | 395 | end |
|
|
396 | 396 | |
|
|
397 | 397 | def test_show_should_deny_non_member_access_without_permission |
|
|
398 | 398 | Role.non_member.remove_permission!(:view_issues) |
|
|
399 | 399 | @request.session[:user_id] = 9 |
|
|
400 | 400 | get :show, :id => 1 |
|
|
401 | 401 | assert_response 403 |
|
|
402 | 402 | end |
|
|
403 | 403 | |
|
|
404 | 404 | def test_show_should_deny_member_access_without_permission |
|
|
405 | 405 | Role.find(1).remove_permission!(:view_issues) |
|
|
406 | 406 | @request.session[:user_id] = 2 |
|
|
407 | 407 | get :show, :id => 1 |
|
|
408 | 408 | assert_response 403 |
|
|
409 | 409 | end |
|
|
410 | 410 | |
|
|
411 | 411 | def test_show_should_not_disclose_relations_to_invisible_issues |
|
|
412 | 412 | Setting.cross_project_issue_relations = '1' |
|
|
413 | 413 | IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates') |
|
|
414 | 414 | # Relation to a private project issue |
|
|
415 | 415 | IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates') |
|
|
416 | 416 | |
|
|
417 | 417 | get :show, :id => 1 |
|
|
418 | 418 | assert_response :success |
|
|
419 | 419 | |
|
|
420 | 420 | assert_tag :div, :attributes => { :id => 'relations' }, |
|
|
421 | 421 | :descendant => { :tag => 'a', :content => /#2$/ } |
|
|
422 | 422 | assert_no_tag :div, :attributes => { :id => 'relations' }, |
|
|
423 | 423 | :descendant => { :tag => 'a', :content => /#4$/ } |
|
|
424 | 424 | end |
|
|
425 | 425 | |
|
|
426 | 426 | def test_show_atom |
|
|
427 | 427 | get :show, :id => 2, :format => 'atom' |
|
|
428 | 428 | assert_response :success |
|
|
429 | 429 | assert_template 'changes.rxml' |
|
|
430 | 430 | # Inline image |
|
|
431 | 431 | assert @response.body.include?("<img src=\"http://test.host/attachments/download/10\" alt=\"\" />"), "Body did not match. Body: #{@response.body}" |
|
|
432 | 432 | end |
|
|
433 | 433 | |
|
|
434 | 434 | def test_new_routing |
|
|
435 | 435 | assert_routing( |
|
|
436 | 436 | {:method => :get, :path => '/projects/1/issues/new'}, |
|
|
437 | 437 | :controller => 'issues', :action => 'new', :project_id => '1' |
|
|
438 | 438 | ) |
|
|
439 | 439 | assert_recognizes( |
|
|
440 | 440 | {:controller => 'issues', :action => 'new', :project_id => '1'}, |
|
|
441 | 441 | {:method => :post, :path => '/projects/1/issues'} |
|
|
442 | 442 | ) |
|
|
443 | 443 | end |
|
|
444 | 444 | |
|
|
445 | 445 | def test_show_export_to_pdf |
|
|
446 | 446 | get :show, :id => 3, :format => 'pdf' |
|
|
447 | 447 | assert_response :success |
|
|
448 | 448 | assert_equal 'application/pdf', @response.content_type |
|
|
449 | 449 | assert @response.body.starts_with?('%PDF') |
|
|
450 | 450 | assert_not_nil assigns(:issue) |
|
|
451 | 451 | end |
|
|
452 | 452 | |
|
|
453 | 453 | def test_get_new |
|
|
454 | 454 | @request.session[:user_id] = 2 |
|
|
455 | 455 | get :new, :project_id => 1, :tracker_id => 1 |
|
|
456 | 456 | assert_response :success |
|
|
457 | 457 | assert_template 'new' |
|
|
458 | 458 | |
|
|
459 | 459 | assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]', |
|
|
460 | 460 | :value => 'Default string' } |
|
|
461 | 461 | end |
|
|
462 | 462 | |
|
|
463 | 463 | def test_get_new_without_tracker_id |
|
|
464 | 464 | @request.session[:user_id] = 2 |
|
|
465 | 465 | get :new, :project_id => 1 |
|
|
466 | 466 | assert_response :success |
|
|
467 | 467 | assert_template 'new' |
|
|
468 | 468 | |
|
|
469 | 469 | issue = assigns(:issue) |
|
|
470 | 470 | assert_not_nil issue |
|
|
471 | 471 | assert_equal Project.find(1).trackers.first, issue.tracker |
|
|
472 | 472 | end |
|
|
473 | 473 | |
|
|
474 | 474 | def test_get_new_with_no_default_status_should_display_an_error |
|
|
475 | 475 | @request.session[:user_id] = 2 |
|
|
476 | 476 | IssueStatus.delete_all |
|
|
477 | 477 | |
|
|
478 | 478 | get :new, :project_id => 1 |
|
|
479 | 479 | assert_response 500 |
|
|
480 | 480 | assert_not_nil flash[:error] |
|
|
481 | 481 | assert_tag :tag => 'div', :attributes => { :class => /error/ }, |
|
|
482 | 482 | :content => /No default issue/ |
|
|
483 | 483 | end |
|
|
484 | 484 | |
|
|
485 | 485 | def test_get_new_with_no_tracker_should_display_an_error |
|
|
486 | 486 | @request.session[:user_id] = 2 |
|
|
487 | 487 | Tracker.delete_all |
|
|
488 | 488 | |
|
|
489 | 489 | get :new, :project_id => 1 |
|
|
490 | 490 | assert_response 500 |
|
|
491 | 491 | assert_not_nil flash[:error] |
|
|
492 | 492 | assert_tag :tag => 'div', :attributes => { :class => /error/ }, |
|
|
493 | 493 | :content => /No tracker/ |
|
|
494 | 494 | end |
|
|
495 | 495 | |
|
|
496 | 496 | def test_update_new_form |
|
|
497 | 497 | @request.session[:user_id] = 2 |
|
|
498 | 498 | xhr :post, :update_form, :project_id => 1, |
|
|
499 | 499 | :issue => {:tracker_id => 2, |
|
|
500 | 500 | :subject => 'This is the test_new issue', |
|
|
501 | 501 | :description => 'This is the description', |
|
|
502 | 502 | :priority_id => 5} |
|
|
503 | 503 | assert_response :success |
|
|
504 | 504 | assert_template 'attributes' |
|
|
505 | 505 | |
|
|
506 | 506 | issue = assigns(:issue) |
|
|
507 | 507 | assert_kind_of Issue, issue |
|
|
508 | 508 | assert_equal 1, issue.project_id |
|
|
509 | 509 | assert_equal 2, issue.tracker_id |
|
|
510 | 510 | assert_equal 'This is the test_new issue', issue.subject |
|
|
511 | 511 | end |
|
|
512 | 512 | |
|
|
513 | 513 | def test_post_new |
|
|
514 | 514 | @request.session[:user_id] = 2 |
|
|
515 | 515 | assert_difference 'Issue.count' do |
|
|
516 | 516 | post :new, :project_id => 1, |
|
|
517 | 517 | :issue => {:tracker_id => 3, |
|
|
518 | 518 | :subject => 'This is the test_new issue', |
|
|
519 | 519 | :description => 'This is the description', |
|
|
520 | 520 | :priority_id => 5, |
|
|
521 | 521 | :estimated_hours => '', |
|
|
522 | 522 | :custom_field_values => {'2' => 'Value for field 2'}} |
|
|
523 | 523 | end |
|
|
524 | 524 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
525 | 525 | |
|
|
526 | 526 | issue = Issue.find_by_subject('This is the test_new issue') |
|
|
527 | 527 | assert_not_nil issue |
|
|
528 | 528 | assert_equal 2, issue.author_id |
|
|
529 | 529 | assert_equal 3, issue.tracker_id |
|
|
530 | 530 | assert_nil issue.estimated_hours |
|
|
531 | 531 | v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2}) |
|
|
532 | 532 | assert_not_nil v |
|
|
533 | 533 | assert_equal 'Value for field 2', v.value |
|
|
534 | 534 | end |
|
|
535 | 535 | |
|
|
536 | 536 | def test_post_new_and_continue |
|
|
537 | 537 | @request.session[:user_id] = 2 |
|
|
538 | 538 | post :new, :project_id => 1, |
|
|
539 | 539 | :issue => {:tracker_id => 3, |
|
|
540 | 540 | :subject => 'This is first issue', |
|
|
541 | 541 | :priority_id => 5}, |
|
|
542 | 542 | :continue => '' |
|
|
543 | 543 | assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3 |
|
|
544 | 544 | end |
|
|
545 | 545 | |
|
|
546 | 546 | def test_post_new_without_custom_fields_param |
|
|
547 | 547 | @request.session[:user_id] = 2 |
|
|
548 | 548 | assert_difference 'Issue.count' do |
|
|
549 | 549 | post :new, :project_id => 1, |
|
|
550 | 550 | :issue => {:tracker_id => 1, |
|
|
551 | 551 | :subject => 'This is the test_new issue', |
|
|
552 | 552 | :description => 'This is the description', |
|
|
553 | 553 | :priority_id => 5} |
|
|
554 | 554 | end |
|
|
555 | 555 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
556 | 556 | end |
|
|
557 | 557 | |
|
|
558 | 558 | def test_post_new_with_required_custom_field_and_without_custom_fields_param |
|
|
559 | 559 | field = IssueCustomField.find_by_name('Database') |
|
|
560 | 560 | field.update_attribute(:is_required, true) |
|
|
561 | 561 | |
|
|
562 | 562 | @request.session[:user_id] = 2 |
|
|
563 | 563 | post :new, :project_id => 1, |
|
|
564 | 564 | :issue => {:tracker_id => 1, |
|
|
565 | 565 | :subject => 'This is the test_new issue', |
|
|
566 | 566 | :description => 'This is the description', |
|
|
567 | 567 | :priority_id => 5} |
|
|
568 | 568 | assert_response :success |
|
|
569 | 569 | assert_template 'new' |
|
|
570 | 570 | issue = assigns(:issue) |
|
|
571 | 571 | assert_not_nil issue |
|
|
572 | 572 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) |
|
|
573 | 573 | end |
|
|
574 | 574 | |
|
|
575 | 575 | def test_post_new_with_watchers |
|
|
576 | 576 | @request.session[:user_id] = 2 |
|
|
577 | 577 | ActionMailer::Base.deliveries.clear |
|
|
578 | 578 | |
|
|
579 | 579 | assert_difference 'Watcher.count', 2 do |
|
|
580 | 580 | post :new, :project_id => 1, |
|
|
581 | 581 | :issue => {:tracker_id => 1, |
|
|
582 | 582 | :subject => 'This is a new issue with watchers', |
|
|
583 | 583 | :description => 'This is the description', |
|
|
584 | 584 | :priority_id => 5, |
|
|
585 | 585 | :watcher_user_ids => ['2', '3']} |
|
|
586 | 586 | end |
|
|
587 | 587 | issue = Issue.find_by_subject('This is a new issue with watchers') |
|
|
588 | 588 | assert_not_nil issue |
|
|
589 | 589 | assert_redirected_to :controller => 'issues', :action => 'show', :id => issue |
|
|
590 | 590 | |
|
|
591 | 591 | # Watchers added |
|
|
592 | 592 | assert_equal [2, 3], issue.watcher_user_ids.sort |
|
|
593 | 593 | assert issue.watched_by?(User.find(3)) |
|
|
594 | 594 | # Watchers notified |
|
|
595 | 595 | mail = ActionMailer::Base.deliveries.last |
|
|
596 | 596 | assert_kind_of TMail::Mail, mail |
|
|
597 | 597 | assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail) |
|
|
598 | 598 | end |
|
|
599 | 599 | |
|
|
600 | 600 | def test_post_new_should_send_a_notification |
|
|
601 | 601 | ActionMailer::Base.deliveries.clear |
|
|
602 | 602 | @request.session[:user_id] = 2 |
|
|
603 | 603 | assert_difference 'Issue.count' do |
|
|
604 | 604 | post :new, :project_id => 1, |
|
|
605 | 605 | :issue => {:tracker_id => 3, |
|
|
606 | 606 | :subject => 'This is the test_new issue', |
|
|
607 | 607 | :description => 'This is the description', |
|
|
608 | 608 | :priority_id => 5, |
|
|
609 | 609 | :estimated_hours => '', |
|
|
610 | 610 | :custom_field_values => {'2' => 'Value for field 2'}} |
|
|
611 | 611 | end |
|
|
612 | 612 | assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id |
|
|
613 | 613 | |
|
|
614 | 614 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
615 | 615 | end |
|
|
616 | 616 | |
|
|
617 | 617 | def test_post_should_preserve_fields_values_on_validation_failure |
|
|
618 | 618 | @request.session[:user_id] = 2 |
|
|
619 | 619 | post :new, :project_id => 1, |
|
|
620 | 620 | :issue => {:tracker_id => 1, |
|
|
621 | 621 | # empty subject |
|
|
622 | 622 | :subject => '', |
|
|
623 | 623 | :description => 'This is a description', |
|
|
624 | 624 | :priority_id => 6, |
|
|
625 | 625 | :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}} |
|
|
626 | 626 | assert_response :success |
|
|
627 | 627 | assert_template 'new' |
|
|
628 | 628 | |
|
|
629 | 629 | assert_tag :textarea, :attributes => { :name => 'issue[description]' }, |
|
|
630 | 630 | :content => 'This is a description' |
|
|
631 | 631 | assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, |
|
|
632 | 632 | :child => { :tag => 'option', :attributes => { :selected => 'selected', |
|
|
633 | 633 | :value => '6' }, |
|
|
634 | 634 | :content => 'High' } |
|
|
635 | 635 | # Custom fields |
|
|
636 | 636 | assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' }, |
|
|
637 | 637 | :child => { :tag => 'option', :attributes => { :selected => 'selected', |
|
|
638 | 638 | :value => 'Oracle' }, |
|
|
639 | 639 | :content => 'Oracle' } |
|
|
640 | 640 | assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]', |
|
|
641 | 641 | :value => 'Value for field 2'} |
|
|
642 | 642 | end |
|
|
643 | 643 | |
|
|
644 | 644 | def test_copy_routing |
|
|
645 | 645 | assert_routing( |
|
|
646 | 646 | {:method => :get, :path => '/projects/world_domination/issues/567/copy'}, |
|
|
647 | 647 | :controller => 'issues', :action => 'new', :project_id => 'world_domination', :copy_from => '567' |
|
|
648 | 648 | ) |
|
|
649 | 649 | end |
|
|
650 | 650 | |
|
|
651 | 651 | def test_copy_issue |
|
|
652 | 652 | @request.session[:user_id] = 2 |
|
|
653 | 653 | get :new, :project_id => 1, :copy_from => 1 |
|
|
654 | 654 | assert_template 'new' |
|
|
655 | 655 | assert_not_nil assigns(:issue) |
|
|
656 | 656 | orig = Issue.find(1) |
|
|
657 | 657 | assert_equal orig.subject, assigns(:issue).subject |
|
|
658 | 658 | end |
|
|
659 | 659 | |
|
|
660 | 660 | def test_edit_routing |
|
|
661 | 661 | assert_routing( |
|
|
662 | 662 | {:method => :get, :path => '/issues/1/edit'}, |
|
|
663 | 663 | :controller => 'issues', :action => 'edit', :id => '1' |
|
|
664 | 664 | ) |
|
|
665 | 665 | assert_recognizes( #TODO: use a PUT on the issue URI isntead, need to adjust form |
|
|
666 | 666 | {:controller => 'issues', :action => 'edit', :id => '1'}, |
|
|
667 | 667 | {:method => :post, :path => '/issues/1/edit'} |
|
|
668 | 668 | ) |
|
|
669 | 669 | end |
|
|
670 | 670 | |
|
|
671 | 671 | def test_get_edit |
|
|
672 | 672 | @request.session[:user_id] = 2 |
|
|
673 | 673 | get :edit, :id => 1 |
|
|
674 | 674 | assert_response :success |
|
|
675 | 675 | assert_template 'edit' |
|
|
676 | 676 | assert_not_nil assigns(:issue) |
|
|
677 | 677 | assert_equal Issue.find(1), assigns(:issue) |
|
|
678 | 678 | end |
|
|
679 | 679 | |
|
|
680 | 680 | def test_get_edit_with_params |
|
|
681 | 681 | @request.session[:user_id] = 2 |
|
|
682 | 682 | get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 } |
|
|
683 | 683 | assert_response :success |
|
|
684 | 684 | assert_template 'edit' |
|
|
685 | 685 | |
|
|
686 | 686 | issue = assigns(:issue) |
|
|
687 | 687 | assert_not_nil issue |
|
|
688 | 688 | |
|
|
689 | 689 | assert_equal 5, issue.status_id |
|
|
690 | 690 | assert_tag :select, :attributes => { :name => 'issue[status_id]' }, |
|
|
691 | 691 | :child => { :tag => 'option', |
|
|
692 | 692 | :content => 'Closed', |
|
|
693 | 693 | :attributes => { :selected => 'selected' } } |
|
|
694 | 694 | |
|
|
695 | 695 | assert_equal 7, issue.priority_id |
|
|
696 | 696 | assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, |
|
|
697 | 697 | :child => { :tag => 'option', |
|
|
698 | 698 | :content => 'Urgent', |
|
|
699 | 699 | :attributes => { :selected => 'selected' } } |
|
|
700 | 700 | end |
|
|
701 | 701 | |
|
|
702 | 702 | def test_update_edit_form |
|
|
703 | 703 | @request.session[:user_id] = 2 |
|
|
704 | 704 | xhr :post, :update_form, :project_id => 1, |
|
|
705 | 705 | :id => 1, |
|
|
706 | 706 | :issue => {:tracker_id => 2, |
|
|
707 | 707 | :subject => 'This is the test_new issue', |
|
|
708 | 708 | :description => 'This is the description', |
|
|
709 | 709 | :priority_id => 5} |
|
|
710 | 710 | assert_response :success |
|
|
711 | 711 | assert_template 'attributes' |
|
|
712 | 712 | |
|
|
713 | 713 | issue = assigns(:issue) |
|
|
714 | 714 | assert_kind_of Issue, issue |
|
|
715 | 715 | assert_equal 1, issue.id |
|
|
716 | 716 | assert_equal 1, issue.project_id |
|
|
717 | 717 | assert_equal 2, issue.tracker_id |
|
|
718 | 718 | assert_equal 'This is the test_new issue', issue.subject |
|
|
719 | 719 | end |
|
|
720 | 720 | |
|
|
721 | 721 | def test_reply_routing |
|
|
722 | 722 | assert_routing( |
|
|
723 | 723 | {:method => :post, :path => '/issues/1/quoted'}, |
|
|
724 | 724 | :controller => 'issues', :action => 'reply', :id => '1' |
|
|
725 | 725 | ) |
|
|
726 | 726 | end |
|
|
727 | 727 | |
|
|
728 | 728 | def test_reply_to_issue |
|
|
729 | 729 | @request.session[:user_id] = 2 |
|
|
730 | 730 | get :reply, :id => 1 |
|
|
731 | 731 | assert_response :success |
|
|
732 | 732 | assert_select_rjs :show, "update" |
|
|
733 | 733 | end |
|
|
734 | 734 | |
|
|
735 | 735 | def test_reply_to_note |
|
|
736 | 736 | @request.session[:user_id] = 2 |
|
|
737 | 737 | get :reply, :id => 1, :journal_id => 2 |
|
|
738 | 738 | assert_response :success |
|
|
739 | 739 | assert_select_rjs :show, "update" |
|
|
740 | 740 | end |
|
|
741 | 741 | |
|
|
742 | 742 | def test_post_edit_without_custom_fields_param |
|
|
743 | 743 | @request.session[:user_id] = 2 |
|
|
744 | 744 | ActionMailer::Base.deliveries.clear |
|
|
745 | 745 | |
|
|
746 | 746 | issue = Issue.find(1) |
|
|
747 | 747 | assert_equal '125', issue.custom_value_for(2).value |
|
|
748 | 748 | old_subject = issue.subject |
|
|
749 | 749 | new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' |
|
|
750 | 750 | |
|
|
751 | 751 | assert_difference('Journal.count') do |
|
|
752 | 752 | assert_difference('JournalDetail.count', 2) do |
|
|
753 | 753 | post :edit, :id => 1, :issue => {:subject => new_subject, |
|
|
754 | 754 | :priority_id => '6', |
|
|
755 | 755 | :category_id => '1' # no change |
|
|
756 | 756 | } |
|
|
757 | 757 | end |
|
|
758 | 758 | end |
|
|
759 | 759 | assert_redirected_to :action => 'show', :id => '1' |
|
|
760 | 760 | issue.reload |
|
|
761 | 761 | assert_equal new_subject, issue.subject |
|
|
762 | 762 | # Make sure custom fields were not cleared |
|
|
763 | 763 | assert_equal '125', issue.custom_value_for(2).value |
|
|
764 | 764 | |
|
|
765 | 765 | mail = ActionMailer::Base.deliveries.last |
|
|
766 | 766 | assert_kind_of TMail::Mail, mail |
|
|
767 | 767 | assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]") |
|
|
768 | 768 | assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}") |
|
|
769 | 769 | end |
|
|
770 | 770 | |
|
|
771 | 771 | def test_post_edit_with_custom_field_change |
|
|
772 | 772 | @request.session[:user_id] = 2 |
|
|
773 | 773 | issue = Issue.find(1) |
|
|
774 | 774 | assert_equal '125', issue.custom_value_for(2).value |
|
|
775 | 775 | |
|
|
776 | 776 | assert_difference('Journal.count') do |
|
|
777 | 777 | assert_difference('JournalDetail.count', 3) do |
|
|
778 | 778 | post :edit, :id => 1, :issue => {:subject => 'Custom field change', |
|
|
779 | 779 | :priority_id => '6', |
|
|
780 | 780 | :category_id => '1', # no change |
|
|
781 | 781 | :custom_field_values => { '2' => 'New custom value' } |
|
|
782 | 782 | } |
|
|
783 | 783 | end |
|
|
784 | 784 | end |
|
|
785 | 785 | assert_redirected_to :action => 'show', :id => '1' |
|
|
786 | 786 | issue.reload |
|
|
787 | 787 | assert_equal 'New custom value', issue.custom_value_for(2).value |
|
|
788 | 788 | |
|
|
789 | 789 | mail = ActionMailer::Base.deliveries.last |
|
|
790 | 790 | assert_kind_of TMail::Mail, mail |
|
|
791 | 791 | assert mail.body.include?("Searchable field changed from 125 to New custom value") |
|
|
792 | 792 | end |
|
|
793 | 793 | |
|
|
794 | 794 | def test_post_edit_with_status_and_assignee_change |
|
|
795 | 795 | issue = Issue.find(1) |
|
|
796 | 796 | assert_equal 1, issue.status_id |
|
|
797 | 797 | @request.session[:user_id] = 2 |
|
|
798 | 798 | assert_difference('TimeEntry.count', 0) do |
|
|
799 | 799 | post :edit, |
|
|
800 | 800 | :id => 1, |
|
|
801 | 801 | :issue => { :status_id => 2, :assigned_to_id => 3 }, |
|
|
802 | 802 | :notes => 'Assigned to dlopper', |
|
|
803 | 803 | :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first } |
|
|
804 | 804 | end |
|
|
805 | 805 | assert_redirected_to :action => 'show', :id => '1' |
|
|
806 | 806 | issue.reload |
|
|
807 | 807 | assert_equal 2, issue.status_id |
|
|
808 | 808 | j = issue.journals.find(:first, :order => 'id DESC') |
|
|
809 | 809 | assert_equal 'Assigned to dlopper', j.notes |
|
|
810 | 810 | assert_equal 2, j.details.size |
|
|
811 | 811 | |
|
|
812 | 812 | mail = ActionMailer::Base.deliveries.last |
|
|
813 | 813 | assert mail.body.include?("Status changed from New to Assigned") |
|
|
814 | 814 | # subject should contain the new status |
|
|
815 | 815 | assert mail.subject.include?("(#{ IssueStatus.find(2).name })") |
|
|
816 | 816 | end |
|
|
817 | 817 | |
|
|
818 | 818 | def test_post_edit_with_note_only |
|
|
819 | 819 | notes = 'Note added by IssuesControllerTest#test_update_with_note_only' |
|
|
820 | 820 | # anonymous user |
|
|
821 | 821 | post :edit, |
|
|
822 | 822 | :id => 1, |
|
|
823 | 823 | :notes => notes |
|
|
824 | 824 | assert_redirected_to :action => 'show', :id => '1' |
|
|
825 | 825 | j = Issue.find(1).journals.find(:first, :order => 'id DESC') |
|
|
826 | 826 | assert_equal notes, j.notes |
|
|
827 | 827 | assert_equal 0, j.details.size |
|
|
828 | 828 | assert_equal User.anonymous, j.user |
|
|
829 | 829 | |
|
|
830 | 830 | mail = ActionMailer::Base.deliveries.last |
|
|
831 | 831 | assert mail.body.include?(notes) |
|
|
832 | 832 | end |
|
|
833 | 833 | |
|
|
834 | 834 | def test_post_edit_with_note_and_spent_time |
|
|
835 | 835 | @request.session[:user_id] = 2 |
|
|
836 | 836 | spent_hours_before = Issue.find(1).spent_hours |
|
|
837 | 837 | assert_difference('TimeEntry.count') do |
|
|
838 | 838 | post :edit, |
|
|
839 | 839 | :id => 1, |
|
|
840 | 840 | :notes => '2.5 hours added', |
|
|
841 | 841 | :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first } |
|
|
842 | 842 | end |
|
|
843 | 843 | assert_redirected_to :action => 'show', :id => '1' |
|
|
844 | 844 | |
|
|
845 | 845 | issue = Issue.find(1) |
|
|
846 | 846 | |
|
|
847 | 847 | j = issue.journals.find(:first, :order => 'id DESC') |
|
|
848 | 848 | assert_equal '2.5 hours added', j.notes |
|
|
849 | 849 | assert_equal 0, j.details.size |
|
|
850 | 850 | |
|
|
851 | 851 | t = issue.time_entries.find(:first, :order => 'id DESC') |
|
|
852 | 852 | assert_not_nil t |
|
|
853 | 853 | assert_equal 2.5, t.hours |
|
|
854 | 854 | assert_equal spent_hours_before + 2.5, issue.spent_hours |
|
|
855 | 855 | end |
|
|
856 | 856 | |
|
|
857 | 857 | def test_post_edit_with_attachment_only |
|
|
858 | 858 | set_tmp_attachments_directory |
|
|
859 | 859 | |
|
|
860 | 860 | # Delete all fixtured journals, a race condition can occur causing the wrong |
|
|
861 | 861 | # journal to get fetched in the next find. |
|
|
862 | 862 | Journal.delete_all |
|
|
863 | 863 | |
|
|
864 | 864 | # anonymous user |
|
|
865 | 865 | post :edit, |
|
|
866 | 866 | :id => 1, |
|
|
867 | 867 | :notes => '', |
|
|
868 | 868 | :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} |
|
|
869 | 869 | assert_redirected_to :action => 'show', :id => '1' |
|
|
870 | 870 | j = Issue.find(1).journals.find(:first, :order => 'id DESC') |
|
|
871 | 871 | assert j.notes.blank? |
|
|
872 | 872 | assert_equal 1, j.details.size |
|
|
873 | 873 | assert_equal 'testfile.txt', j.details.first.value |
|
|
874 | 874 | assert_equal User.anonymous, j.user |
|
|
875 | 875 | |
|
|
876 | 876 | mail = ActionMailer::Base.deliveries.last |
|
|
877 | 877 | assert mail.body.include?('testfile.txt') |
|
|
878 | 878 | end |
|
|
879 | 879 | |
|
|
880 | 880 | def test_post_edit_with_no_change |
|
|
881 | 881 | issue = Issue.find(1) |
|
|
882 | 882 | issue.journals.clear |
|
|
883 | 883 | ActionMailer::Base.deliveries.clear |
|
|
884 | 884 | |
|
|
885 | 885 | post :edit, |
|
|
886 | 886 | :id => 1, |
|
|
887 | 887 | :notes => '' |
|
|
888 | 888 | assert_redirected_to :action => 'show', :id => '1' |
|
|
889 | 889 | |
|
|
890 | 890 | issue.reload |
|
|
891 | 891 | assert issue.journals.empty? |
|
|
892 | 892 | # No email should be sent |
|
|
893 | 893 | assert ActionMailer::Base.deliveries.empty? |
|
|
894 | 894 | end |
|
|
895 | 895 | |
|
|
896 | 896 | def test_post_edit_should_send_a_notification |
|
|
897 | 897 | @request.session[:user_id] = 2 |
|
|
898 | 898 | ActionMailer::Base.deliveries.clear |
|
|
899 | 899 | issue = Issue.find(1) |
|
|
900 | 900 | old_subject = issue.subject |
|
|
901 | 901 | new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' |
|
|
902 | 902 | |
|
|
903 | 903 | post :edit, :id => 1, :issue => {:subject => new_subject, |
|
|
904 | 904 | :priority_id => '6', |
|
|
905 | 905 | :category_id => '1' # no change |
|
|
906 | 906 | } |
|
|
907 | 907 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
908 | 908 | end |
|
|
909 | 909 | |
|
|
910 | 910 | def test_post_edit_with_invalid_spent_time |
|
|
911 | 911 | @request.session[:user_id] = 2 |
|
|
912 | 912 | notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time' |
|
|
913 | 913 | |
|
|
914 | 914 | assert_no_difference('Journal.count') do |
|
|
915 | 915 | post :edit, |
|
|
916 | 916 | :id => 1, |
|
|
917 | 917 | :notes => notes, |
|
|
918 | 918 | :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"} |
|
|
919 | 919 | end |
|
|
920 | 920 | assert_response :success |
|
|
921 | 921 | assert_template 'edit' |
|
|
922 | 922 | |
|
|
923 | 923 | assert_tag :textarea, :attributes => { :name => 'notes' }, |
|
|
924 | 924 | :content => notes |
|
|
925 | 925 | assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" } |
|
|
926 | 926 | end |
|
|
927 | 927 | |
|
|
928 | 928 | def test_get_bulk_edit |
|
|
929 | 929 | @request.session[:user_id] = 2 |
|
|
930 | 930 | get :bulk_edit, :ids => [1, 2] |
|
|
931 | 931 | assert_response :success |
|
|
932 | 932 | assert_template 'bulk_edit' |
|
|
933 | 933 | end |
|
|
934 | 934 | |
|
|
935 | 935 | def test_bulk_edit |
|
|
936 | 936 | @request.session[:user_id] = 2 |
|
|
937 | 937 | # update issues priority |
|
|
938 | 938 | post :bulk_edit, :ids => [1, 2], :priority_id => 7, |
|
|
939 | 939 | :assigned_to_id => '', |
|
|
940 | 940 | :custom_field_values => {'2' => ''}, |
|
|
941 | 941 | :notes => 'Bulk editing' |
|
|
942 | 942 | assert_response 302 |
|
|
943 | 943 | # check that the issues were updated |
|
|
944 | 944 | assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id} |
|
|
945 | 945 | |
|
|
946 | 946 | issue = Issue.find(1) |
|
|
947 | 947 | journal = issue.journals.find(:first, :order => 'created_on DESC') |
|
|
948 | 948 | assert_equal '125', issue.custom_value_for(2).value |
|
|
949 | 949 | assert_equal 'Bulk editing', journal.notes |
|
|
950 | 950 | assert_equal 1, journal.details.size |
|
|
951 | 951 | end |
|
|
952 | 952 | |
|
|
953 | 953 | def test_bullk_edit_should_send_a_notification |
|
|
954 | 954 | @request.session[:user_id] = 2 |
|
|
955 | 955 | ActionMailer::Base.deliveries.clear |
|
|
956 | 956 | post(:bulk_edit, |
|
|
957 | 957 | { |
|
|
958 | 958 | :ids => [1, 2], |
|
|
959 | 959 | :priority_id => 7, |
|
|
960 | 960 | :assigned_to_id => '', |
|
|
961 | 961 | :custom_field_values => {'2' => ''}, |
|
|
962 | 962 | :notes => 'Bulk editing' |
|
|
963 | 963 | }) |
|
|
964 | 964 | |
|
|
965 | 965 | assert_response 302 |
|
|
966 | 966 | assert_equal 2, ActionMailer::Base.deliveries.size |
|
|
967 | 967 | end |
|
|
968 | 968 | |
|
|
969 | 969 | def test_bulk_edit_status |
|
|
970 | 970 | @request.session[:user_id] = 2 |
|
|
971 | 971 | # update issues priority |
|
|
972 | 972 | post :bulk_edit, :ids => [1, 2], :priority_id => '', |
|
|
973 | 973 | :assigned_to_id => '', |
|
|
974 | 974 | :status_id => '5', |
|
|
975 | 975 | :notes => 'Bulk editing status' |
|
|
976 | 976 | assert_response 302 |
|
|
977 | 977 | issue = Issue.find(1) |
|
|
978 | 978 | assert issue.closed? |
|
|
979 | 979 | end |
|
|
980 | 980 | |
|
|
981 | 981 | def test_bulk_edit_custom_field |
|
|
982 | 982 | @request.session[:user_id] = 2 |
|
|
983 | 983 | # update issues priority |
|
|
984 | 984 | post :bulk_edit, :ids => [1, 2], :priority_id => '', |
|
|
985 | 985 | :assigned_to_id => '', |
|
|
986 | 986 | :custom_field_values => {'2' => '777'}, |
|
|
987 | 987 | :notes => 'Bulk editing custom field' |
|
|
988 | 988 | assert_response 302 |
|
|
989 | 989 | |
|
|
990 | 990 | issue = Issue.find(1) |
|
|
991 | 991 | journal = issue.journals.find(:first, :order => 'created_on DESC') |
|
|
992 | 992 | assert_equal '777', issue.custom_value_for(2).value |
|
|
993 | 993 | assert_equal 1, journal.details.size |
|
|
994 | 994 | assert_equal '125', journal.details.first.old_value |
|
|
995 | 995 | assert_equal '777', journal.details.first.value |
|
|
996 | 996 | end |
|
|
997 | 997 | |
|
|
998 | 998 | def test_bulk_unassign |
|
|
999 | 999 | assert_not_nil Issue.find(2).assigned_to |
|
|
1000 | 1000 | @request.session[:user_id] = 2 |
|
|
1001 | 1001 | # unassign issues |
|
|
1002 | 1002 | post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :assigned_to_id => 'none' |
|
|
1003 | 1003 | assert_response 302 |
|
|
1004 | 1004 | # check that the issues were updated |
|
|
1005 | 1005 | assert_nil Issue.find(2).assigned_to |
|
|
1006 | 1006 | end |
|
|
1007 | 1007 | |
|
|
1008 | 1008 | def test_move_routing |
|
|
1009 | 1009 | assert_routing( |
|
|
1010 | 1010 | {:method => :get, :path => '/issues/1/move'}, |
|
|
1011 | 1011 | :controller => 'issues', :action => 'move', :id => '1' |
|
|
1012 | 1012 | ) |
|
|
1013 | 1013 | assert_recognizes( |
|
|
1014 | 1014 | {:controller => 'issues', :action => 'move', :id => '1'}, |
|
|
1015 | 1015 | {:method => :post, :path => '/issues/1/move'} |
|
|
1016 | 1016 | ) |
|
|
1017 | 1017 | end |
|
|
1018 | 1018 | |
|
|
1019 | 1019 | def test_move_one_issue_to_another_project |
|
|
1020 | 1020 | @request.session[:user_id] = 2 |
|
|
1021 | 1021 | post :move, :id => 1, :new_project_id => 2 |
|
|
1022 | 1022 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1023 | 1023 | assert_equal 2, Issue.find(1).project_id |
|
|
1024 | 1024 | end |
|
|
1025 | 1025 | |
|
|
1026 | 1026 | def test_move_one_issue_to_another_project_should_follow_when_needed |
|
|
1027 | 1027 | @request.session[:user_id] = 2 |
|
|
1028 | 1028 | post :move, :id => 1, :new_project_id => 2, :follow => '1' |
|
|
1029 | 1029 | assert_redirected_to '/issues/1' |
|
|
1030 | 1030 | end |
|
|
1031 | 1031 | |
|
|
1032 | 1032 | def test_bulk_move_to_another_project |
|
|
1033 | 1033 | @request.session[:user_id] = 2 |
|
|
1034 | 1034 | post :move, :ids => [1, 2], :new_project_id => 2 |
|
|
1035 | 1035 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1036 | 1036 | # Issues moved to project 2 |
|
|
1037 | 1037 | assert_equal 2, Issue.find(1).project_id |
|
|
1038 | 1038 | assert_equal 2, Issue.find(2).project_id |
|
|
1039 | 1039 | # No tracker change |
|
|
1040 | 1040 | assert_equal 1, Issue.find(1).tracker_id |
|
|
1041 | 1041 | assert_equal 2, Issue.find(2).tracker_id |
|
|
1042 | 1042 | end |
|
|
1043 | 1043 | |
|
|
1044 | 1044 | def test_bulk_move_to_another_tracker |
|
|
1045 | 1045 | @request.session[:user_id] = 2 |
|
|
1046 | 1046 | post :move, :ids => [1, 2], :new_tracker_id => 2 |
|
|
1047 | 1047 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1048 | 1048 | assert_equal 2, Issue.find(1).tracker_id |
|
|
1049 | 1049 | assert_equal 2, Issue.find(2).tracker_id |
|
|
1050 | 1050 | end |
|
|
1051 | 1051 | |
|
|
1052 | 1052 | def test_bulk_copy_to_another_project |
|
|
1053 | 1053 | @request.session[:user_id] = 2 |
|
|
1054 | 1054 | assert_difference 'Issue.count', 2 do |
|
|
1055 | 1055 | assert_no_difference 'Project.find(1).issues.count' do |
|
|
1056 | 1056 | post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'} |
|
|
1057 | 1057 | end |
|
|
1058 | 1058 | end |
|
|
1059 | 1059 | assert_redirected_to 'projects/ecookbook/issues' |
|
|
1060 | 1060 | end |
|
|
1061 | 1061 | |
|
|
1062 | context "#move via bulk copy" do | |
|
|
1063 | should "allow changing the issue's attributes" do | |
|
|
1064 | @request.session[:user_id] = 2 | |
|
|
1065 | assert_difference 'Issue.count', 2 do | |
|
|
1066 | assert_no_difference 'Project.find(1).issues.count' do | |
|
|
1067 | post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}, :assigned_to_id => 4, :status_id => 3, :start_date => '2009-12-01', :due_date => '2009-12-31' | |
|
|
1068 | end | |
|
|
1069 | end | |
|
|
1070 | ||
|
|
1071 | copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2}) | |
|
|
1072 | assert_equal 2, copied_issues.size | |
|
|
1073 | copied_issues.each do |issue| | |
|
|
1074 | assert_equal 2, issue.project_id, "Project is incorrect" | |
|
|
1075 | assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect" | |
|
|
1076 | assert_equal 3, issue.status_id, "Status is incorrect" | |
|
|
1077 | assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect" | |
|
|
1078 | assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect" | |
|
|
1079 | end | |
|
|
1080 | end | |
|
|
1081 | end | |
|
|
1082 | ||
|
|
1062 | 1083 | def test_copy_to_another_project_should_follow_when_needed |
|
|
1063 | 1084 | @request.session[:user_id] = 2 |
|
|
1064 | 1085 | post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1' |
|
|
1065 | 1086 | issue = Issue.first(:order => 'id DESC') |
|
|
1066 | 1087 | assert_redirected_to :controller => 'issues', :action => 'show', :id => issue |
|
|
1067 | 1088 | end |
|
|
1068 | 1089 | |
|
|
1069 | 1090 | def test_context_menu_one_issue |
|
|
1070 | 1091 | @request.session[:user_id] = 2 |
|
|
1071 | 1092 | get :context_menu, :ids => [1] |
|
|
1072 | 1093 | assert_response :success |
|
|
1073 | 1094 | assert_template 'context_menu' |
|
|
1074 | 1095 | assert_tag :tag => 'a', :content => 'Edit', |
|
|
1075 | 1096 | :attributes => { :href => '/issues/1/edit', |
|
|
1076 | 1097 | :class => 'icon-edit' } |
|
|
1077 | 1098 | assert_tag :tag => 'a', :content => 'Closed', |
|
|
1078 | 1099 | :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5', |
|
|
1079 | 1100 | :class => '' } |
|
|
1080 | 1101 | assert_tag :tag => 'a', :content => 'Immediate', |
|
|
1081 | 1102 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&priority_id=8', |
|
|
1082 | 1103 | :class => '' } |
|
|
1083 | 1104 | assert_tag :tag => 'a', :content => 'Dave Lopper', |
|
|
1084 | 1105 | :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&ids%5B%5D=1', |
|
|
1085 | 1106 | :class => '' } |
|
|
1086 | 1107 | assert_tag :tag => 'a', :content => 'Copy', |
|
|
1087 | 1108 | :attributes => { :href => '/projects/ecookbook/issues/1/copy', |
|
|
1088 | 1109 | :class => 'icon-copy' } |
|
|
1089 | 1110 | assert_tag :tag => 'a', :content => 'Move', |
|
|
1090 | 1111 | :attributes => { :href => '/issues/move?ids%5B%5D=1', |
|
|
1091 | 1112 | :class => 'icon-move' } |
|
|
1092 | 1113 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1093 | 1114 | :attributes => { :href => '/issues/destroy?ids%5B%5D=1', |
|
|
1094 | 1115 | :class => 'icon-del' } |
|
|
1095 | 1116 | end |
|
|
1096 | 1117 | |
|
|
1097 | 1118 | def test_context_menu_one_issue_by_anonymous |
|
|
1098 | 1119 | get :context_menu, :ids => [1] |
|
|
1099 | 1120 | assert_response :success |
|
|
1100 | 1121 | assert_template 'context_menu' |
|
|
1101 | 1122 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1102 | 1123 | :attributes => { :href => '#', |
|
|
1103 | 1124 | :class => 'icon-del disabled' } |
|
|
1104 | 1125 | end |
|
|
1105 | 1126 | |
|
|
1106 | 1127 | def test_context_menu_multiple_issues_of_same_project |
|
|
1107 | 1128 | @request.session[:user_id] = 2 |
|
|
1108 | 1129 | get :context_menu, :ids => [1, 2] |
|
|
1109 | 1130 | assert_response :success |
|
|
1110 | 1131 | assert_template 'context_menu' |
|
|
1111 | 1132 | assert_tag :tag => 'a', :content => 'Edit', |
|
|
1112 | 1133 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1113 | 1134 | :class => 'icon-edit' } |
|
|
1114 | 1135 | assert_tag :tag => 'a', :content => 'Immediate', |
|
|
1115 | 1136 | :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&ids%5B%5D=2&priority_id=8', |
|
|
1116 | 1137 | :class => '' } |
|
|
1117 | 1138 | assert_tag :tag => 'a', :content => 'Dave Lopper', |
|
|
1118 | 1139 | :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&ids%5B%5D=1&ids%5B%5D=2', |
|
|
1119 | 1140 | :class => '' } |
|
|
1141 | assert_tag :tag => 'a', :content => 'Copy', | |
|
|
1142 | :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&ids%5B%5D=1&ids%5B%5D=2', | |
|
|
1143 | :class => 'icon-copy' } | |
|
|
1120 | 1144 | assert_tag :tag => 'a', :content => 'Move', |
|
|
1121 | 1145 | :attributes => { :href => '/issues/move?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1122 | 1146 | :class => 'icon-move' } |
|
|
1123 | 1147 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1124 | 1148 | :attributes => { :href => '/issues/destroy?ids%5B%5D=1&ids%5B%5D=2', |
|
|
1125 | 1149 | :class => 'icon-del' } |
|
|
1126 | 1150 | end |
|
|
1127 | 1151 | |
|
|
1128 | 1152 | def test_context_menu_multiple_issues_of_different_project |
|
|
1129 | 1153 | @request.session[:user_id] = 2 |
|
|
1130 | 1154 | get :context_menu, :ids => [1, 2, 4] |
|
|
1131 | 1155 | assert_response :success |
|
|
1132 | 1156 | assert_template 'context_menu' |
|
|
1133 | 1157 | assert_tag :tag => 'a', :content => 'Delete', |
|
|
1134 | 1158 | :attributes => { :href => '#', |
|
|
1135 | 1159 | :class => 'icon-del disabled' } |
|
|
1136 | 1160 | end |
|
|
1137 | 1161 | |
|
|
1138 | 1162 | def test_destroy_routing |
|
|
1139 | 1163 | assert_recognizes( #TODO: use DELETE on issue URI (need to change forms) |
|
|
1140 | 1164 | {:controller => 'issues', :action => 'destroy', :id => '1'}, |
|
|
1141 | 1165 | {:method => :post, :path => '/issues/1/destroy'} |
|
|
1142 | 1166 | ) |
|
|
1143 | 1167 | end |
|
|
1144 | 1168 | |
|
|
1145 | 1169 | def test_destroy_issue_with_no_time_entries |
|
|
1146 | 1170 | assert_nil TimeEntry.find_by_issue_id(2) |
|
|
1147 | 1171 | @request.session[:user_id] = 2 |
|
|
1148 | 1172 | post :destroy, :id => 2 |
|
|
1149 | 1173 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1150 | 1174 | assert_nil Issue.find_by_id(2) |
|
|
1151 | 1175 | end |
|
|
1152 | 1176 | |
|
|
1153 | 1177 | def test_destroy_issues_with_time_entries |
|
|
1154 | 1178 | @request.session[:user_id] = 2 |
|
|
1155 | 1179 | post :destroy, :ids => [1, 3] |
|
|
1156 | 1180 | assert_response :success |
|
|
1157 | 1181 | assert_template 'destroy' |
|
|
1158 | 1182 | assert_not_nil assigns(:hours) |
|
|
1159 | 1183 | assert Issue.find_by_id(1) && Issue.find_by_id(3) |
|
|
1160 | 1184 | end |
|
|
1161 | 1185 | |
|
|
1162 | 1186 | def test_destroy_issues_and_destroy_time_entries |
|
|
1163 | 1187 | @request.session[:user_id] = 2 |
|
|
1164 | 1188 | post :destroy, :ids => [1, 3], :todo => 'destroy' |
|
|
1165 | 1189 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1166 | 1190 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1167 | 1191 | assert_nil TimeEntry.find_by_id([1, 2]) |
|
|
1168 | 1192 | end |
|
|
1169 | 1193 | |
|
|
1170 | 1194 | def test_destroy_issues_and_assign_time_entries_to_project |
|
|
1171 | 1195 | @request.session[:user_id] = 2 |
|
|
1172 | 1196 | post :destroy, :ids => [1, 3], :todo => 'nullify' |
|
|
1173 | 1197 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1174 | 1198 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1175 | 1199 | assert_nil TimeEntry.find(1).issue_id |
|
|
1176 | 1200 | assert_nil TimeEntry.find(2).issue_id |
|
|
1177 | 1201 | end |
|
|
1178 | 1202 | |
|
|
1179 | 1203 | def test_destroy_issues_and_reassign_time_entries_to_another_issue |
|
|
1180 | 1204 | @request.session[:user_id] = 2 |
|
|
1181 | 1205 | post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2 |
|
|
1182 | 1206 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' |
|
|
1183 | 1207 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) |
|
|
1184 | 1208 | assert_equal 2, TimeEntry.find(1).issue_id |
|
|
1185 | 1209 | assert_equal 2, TimeEntry.find(2).issue_id |
|
|
1186 | 1210 | end |
|
|
1187 | 1211 | |
|
|
1188 | 1212 | def test_default_search_scope |
|
|
1189 | 1213 | get :index |
|
|
1190 | 1214 | assert_tag :div, :attributes => {:id => 'quick-search'}, |
|
|
1191 | 1215 | :child => {:tag => 'form', |
|
|
1192 | 1216 | :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}} |
|
|
1193 | 1217 | end |
|
|
1194 | 1218 | end |
| @@ -1,443 +1,475 | |||
|
|
1 | 1 | # redMine - project management software |
|
|
2 | 2 | # Copyright (C) 2006-2007 Jean-Philippe Lang |
|
|
3 | 3 | # |
|
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
|
7 | 7 | # of the License, or (at your option) any later version. |
|
|
8 | 8 | # |
|
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
12 | 12 | # GNU General Public License for more details. |
|
|
13 | 13 | # |
|
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
|
17 | 17 | |
|
|
18 | 18 | require File.dirname(__FILE__) + '/../test_helper' |
|
|
19 | 19 | |
|
|
20 | 20 | class IssueTest < ActiveSupport::TestCase |
|
|
21 | 21 | fixtures :projects, :users, :members, :member_roles, :roles, |
|
|
22 | 22 | :trackers, :projects_trackers, |
|
|
23 | 23 | :versions, |
|
|
24 | 24 | :issue_statuses, :issue_categories, :issue_relations, :workflows, |
|
|
25 | 25 | :enumerations, |
|
|
26 | 26 | :issues, |
|
|
27 | 27 | :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values, |
|
|
28 | 28 | :time_entries |
|
|
29 | 29 | |
|
|
30 | 30 | def test_create |
|
|
31 | 31 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30') |
|
|
32 | 32 | assert issue.save |
|
|
33 | 33 | issue.reload |
|
|
34 | 34 | assert_equal 1.5, issue.estimated_hours |
|
|
35 | 35 | end |
|
|
36 | 36 | |
|
|
37 | 37 | def test_create_minimal |
|
|
38 | 38 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create') |
|
|
39 | 39 | assert issue.save |
|
|
40 | 40 | assert issue.description.nil? |
|
|
41 | 41 | end |
|
|
42 | 42 | |
|
|
43 | 43 | def test_create_with_required_custom_field |
|
|
44 | 44 | field = IssueCustomField.find_by_name('Database') |
|
|
45 | 45 | field.update_attribute(:is_required, true) |
|
|
46 | 46 | |
|
|
47 | 47 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field') |
|
|
48 | 48 | assert issue.available_custom_fields.include?(field) |
|
|
49 | 49 | # No value for the custom field |
|
|
50 | 50 | assert !issue.save |
|
|
51 | 51 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) |
|
|
52 | 52 | # Blank value |
|
|
53 | 53 | issue.custom_field_values = { field.id => '' } |
|
|
54 | 54 | assert !issue.save |
|
|
55 | 55 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) |
|
|
56 | 56 | # Invalid value |
|
|
57 | 57 | issue.custom_field_values = { field.id => 'SQLServer' } |
|
|
58 | 58 | assert !issue.save |
|
|
59 | 59 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) |
|
|
60 | 60 | # Valid value |
|
|
61 | 61 | issue.custom_field_values = { field.id => 'PostgreSQL' } |
|
|
62 | 62 | assert issue.save |
|
|
63 | 63 | issue.reload |
|
|
64 | 64 | assert_equal 'PostgreSQL', issue.custom_value_for(field).value |
|
|
65 | 65 | end |
|
|
66 | 66 | |
|
|
67 | 67 | def test_visible_scope_for_anonymous |
|
|
68 | 68 | # Anonymous user should see issues of public projects only |
|
|
69 | 69 | issues = Issue.visible(User.anonymous).all |
|
|
70 | 70 | assert issues.any? |
|
|
71 | 71 | assert_nil issues.detect {|issue| !issue.project.is_public?} |
|
|
72 | 72 | # Anonymous user should not see issues without permission |
|
|
73 | 73 | Role.anonymous.remove_permission!(:view_issues) |
|
|
74 | 74 | issues = Issue.visible(User.anonymous).all |
|
|
75 | 75 | assert issues.empty? |
|
|
76 | 76 | end |
|
|
77 | 77 | |
|
|
78 | 78 | def test_visible_scope_for_user |
|
|
79 | 79 | user = User.find(9) |
|
|
80 | 80 | assert user.projects.empty? |
|
|
81 | 81 | # Non member user should see issues of public projects only |
|
|
82 | 82 | issues = Issue.visible(user).all |
|
|
83 | 83 | assert issues.any? |
|
|
84 | 84 | assert_nil issues.detect {|issue| !issue.project.is_public?} |
|
|
85 | 85 | # Non member user should not see issues without permission |
|
|
86 | 86 | Role.non_member.remove_permission!(:view_issues) |
|
|
87 | 87 | user.reload |
|
|
88 | 88 | issues = Issue.visible(user).all |
|
|
89 | 89 | assert issues.empty? |
|
|
90 | 90 | # User should see issues of projects for which he has view_issues permissions only |
|
|
91 | 91 | Member.create!(:principal => user, :project_id => 2, :role_ids => [1]) |
|
|
92 | 92 | user.reload |
|
|
93 | 93 | issues = Issue.visible(user).all |
|
|
94 | 94 | assert issues.any? |
|
|
95 | 95 | assert_nil issues.detect {|issue| issue.project_id != 2} |
|
|
96 | 96 | end |
|
|
97 | 97 | |
|
|
98 | 98 | def test_visible_scope_for_admin |
|
|
99 | 99 | user = User.find(1) |
|
|
100 | 100 | user.members.each(&:destroy) |
|
|
101 | 101 | assert user.projects.empty? |
|
|
102 | 102 | issues = Issue.visible(user).all |
|
|
103 | 103 | assert issues.any? |
|
|
104 | 104 | # Admin should see issues on private projects that he does not belong to |
|
|
105 | 105 | assert issues.detect {|issue| !issue.project.is_public?} |
|
|
106 | 106 | end |
|
|
107 | 107 | |
|
|
108 | 108 | def test_errors_full_messages_should_include_custom_fields_errors |
|
|
109 | 109 | field = IssueCustomField.find_by_name('Database') |
|
|
110 | 110 | |
|
|
111 | 111 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field') |
|
|
112 | 112 | assert issue.available_custom_fields.include?(field) |
|
|
113 | 113 | # Invalid value |
|
|
114 | 114 | issue.custom_field_values = { field.id => 'SQLServer' } |
|
|
115 | 115 | |
|
|
116 | 116 | assert !issue.valid? |
|
|
117 | 117 | assert_equal 1, issue.errors.full_messages.size |
|
|
118 | 118 | assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first |
|
|
119 | 119 | end |
|
|
120 | 120 | |
|
|
121 | 121 | def test_update_issue_with_required_custom_field |
|
|
122 | 122 | field = IssueCustomField.find_by_name('Database') |
|
|
123 | 123 | field.update_attribute(:is_required, true) |
|
|
124 | 124 | |
|
|
125 | 125 | issue = Issue.find(1) |
|
|
126 | 126 | assert_nil issue.custom_value_for(field) |
|
|
127 | 127 | assert issue.available_custom_fields.include?(field) |
|
|
128 | 128 | # No change to custom values, issue can be saved |
|
|
129 | 129 | assert issue.save |
|
|
130 | 130 | # Blank value |
|
|
131 | 131 | issue.custom_field_values = { field.id => '' } |
|
|
132 | 132 | assert !issue.save |
|
|
133 | 133 | # Valid value |
|
|
134 | 134 | issue.custom_field_values = { field.id => 'PostgreSQL' } |
|
|
135 | 135 | assert issue.save |
|
|
136 | 136 | issue.reload |
|
|
137 | 137 | assert_equal 'PostgreSQL', issue.custom_value_for(field).value |
|
|
138 | 138 | end |
|
|
139 | 139 | |
|
|
140 | 140 | def test_should_not_update_attributes_if_custom_fields_validation_fails |
|
|
141 | 141 | issue = Issue.find(1) |
|
|
142 | 142 | field = IssueCustomField.find_by_name('Database') |
|
|
143 | 143 | assert issue.available_custom_fields.include?(field) |
|
|
144 | 144 | |
|
|
145 | 145 | issue.custom_field_values = { field.id => 'Invalid' } |
|
|
146 | 146 | issue.subject = 'Should be not be saved' |
|
|
147 | 147 | assert !issue.save |
|
|
148 | 148 | |
|
|
149 | 149 | issue.reload |
|
|
150 | 150 | assert_equal "Can't print recipes", issue.subject |
|
|
151 | 151 | end |
|
|
152 | 152 | |
|
|
153 | 153 | def test_should_not_recreate_custom_values_objects_on_update |
|
|
154 | 154 | field = IssueCustomField.find_by_name('Database') |
|
|
155 | 155 | |
|
|
156 | 156 | issue = Issue.find(1) |
|
|
157 | 157 | issue.custom_field_values = { field.id => 'PostgreSQL' } |
|
|
158 | 158 | assert issue.save |
|
|
159 | 159 | custom_value = issue.custom_value_for(field) |
|
|
160 | 160 | issue.reload |
|
|
161 | 161 | issue.custom_field_values = { field.id => 'MySQL' } |
|
|
162 | 162 | assert issue.save |
|
|
163 | 163 | issue.reload |
|
|
164 | 164 | assert_equal custom_value.id, issue.custom_value_for(field).id |
|
|
165 | 165 | end |
|
|
166 | 166 | |
|
|
167 | 167 | def test_should_update_issue_with_disabled_tracker |
|
|
168 | 168 | p = Project.find(1) |
|
|
169 | 169 | issue = Issue.find(1) |
|
|
170 | 170 | |
|
|
171 | 171 | p.trackers.delete(issue.tracker) |
|
|
172 | 172 | assert !p.trackers.include?(issue.tracker) |
|
|
173 | 173 | |
|
|
174 | 174 | issue.reload |
|
|
175 | 175 | issue.subject = 'New subject' |
|
|
176 | 176 | assert issue.save |
|
|
177 | 177 | end |
|
|
178 | 178 | |
|
|
179 | 179 | def test_should_not_set_a_disabled_tracker |
|
|
180 | 180 | p = Project.find(1) |
|
|
181 | 181 | p.trackers.delete(Tracker.find(2)) |
|
|
182 | 182 | |
|
|
183 | 183 | issue = Issue.find(1) |
|
|
184 | 184 | issue.tracker_id = 2 |
|
|
185 | 185 | issue.subject = 'New subject' |
|
|
186 | 186 | assert !issue.save |
|
|
187 | 187 | assert_not_nil issue.errors.on(:tracker_id) |
|
|
188 | 188 | end |
|
|
189 | 189 | |
|
|
190 | 190 | def test_category_based_assignment |
|
|
191 | 191 | issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1) |
|
|
192 | 192 | assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to |
|
|
193 | 193 | end |
|
|
194 | 194 | |
|
|
195 | 195 | def test_copy |
|
|
196 | 196 | issue = Issue.new.copy_from(1) |
|
|
197 | 197 | assert issue.save |
|
|
198 | 198 | issue.reload |
|
|
199 | 199 | orig = Issue.find(1) |
|
|
200 | 200 | assert_equal orig.subject, issue.subject |
|
|
201 | 201 | assert_equal orig.tracker, issue.tracker |
|
|
202 | 202 | assert_equal orig.custom_values.first.value, issue.custom_values.first.value |
|
|
203 | 203 | end |
|
|
204 | 204 | |
|
|
205 | 205 | def test_copy_should_copy_status |
|
|
206 | 206 | orig = Issue.find(8) |
|
|
207 | 207 | assert orig.status != IssueStatus.default |
|
|
208 | 208 | |
|
|
209 | 209 | issue = Issue.new.copy_from(orig) |
|
|
210 | 210 | assert issue.save |
|
|
211 | 211 | issue.reload |
|
|
212 | 212 | assert_equal orig.status, issue.status |
|
|
213 | 213 | end |
|
|
214 | 214 | |
|
|
215 | 215 | def test_should_close_duplicates |
|
|
216 | 216 | # Create 3 issues |
|
|
217 | 217 | issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test') |
|
|
218 | 218 | assert issue1.save |
|
|
219 | 219 | issue2 = issue1.clone |
|
|
220 | 220 | assert issue2.save |
|
|
221 | 221 | issue3 = issue1.clone |
|
|
222 | 222 | assert issue3.save |
|
|
223 | 223 | |
|
|
224 | 224 | # 2 is a dupe of 1 |
|
|
225 | 225 | IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES) |
|
|
226 | 226 | # And 3 is a dupe of 2 |
|
|
227 | 227 | IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES) |
|
|
228 | 228 | # And 3 is a dupe of 1 (circular duplicates) |
|
|
229 | 229 | IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES) |
|
|
230 | 230 | |
|
|
231 | 231 | assert issue1.reload.duplicates.include?(issue2) |
|
|
232 | 232 | |
|
|
233 | 233 | # Closing issue 1 |
|
|
234 | 234 | issue1.init_journal(User.find(:first), "Closing issue1") |
|
|
235 | 235 | issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true} |
|
|
236 | 236 | assert issue1.save |
|
|
237 | 237 | # 2 and 3 should be also closed |
|
|
238 | 238 | assert issue2.reload.closed? |
|
|
239 | 239 | assert issue3.reload.closed? |
|
|
240 | 240 | end |
|
|
241 | 241 | |
|
|
242 | 242 | def test_should_not_close_duplicated_issue |
|
|
243 | 243 | # Create 3 issues |
|
|
244 | 244 | issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test') |
|
|
245 | 245 | assert issue1.save |
|
|
246 | 246 | issue2 = issue1.clone |
|
|
247 | 247 | assert issue2.save |
|
|
248 | 248 | |
|
|
249 | 249 | # 2 is a dupe of 1 |
|
|
250 | 250 | IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES) |
|
|
251 | 251 | # 2 is a dup of 1 but 1 is not a duplicate of 2 |
|
|
252 | 252 | assert !issue2.reload.duplicates.include?(issue1) |
|
|
253 | 253 | |
|
|
254 | 254 | # Closing issue 2 |
|
|
255 | 255 | issue2.init_journal(User.find(:first), "Closing issue2") |
|
|
256 | 256 | issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true} |
|
|
257 | 257 | assert issue2.save |
|
|
258 | 258 | # 1 should not be also closed |
|
|
259 | 259 | assert !issue1.reload.closed? |
|
|
260 | 260 | end |
|
|
261 | 261 | |
|
|
262 | 262 | def test_assignable_versions |
|
|
263 | 263 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue') |
|
|
264 | 264 | assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq |
|
|
265 | 265 | end |
|
|
266 | 266 | |
|
|
267 | 267 | def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version |
|
|
268 | 268 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue') |
|
|
269 | 269 | assert !issue.save |
|
|
270 | 270 | assert_not_nil issue.errors.on(:fixed_version_id) |
|
|
271 | 271 | end |
|
|
272 | 272 | |
|
|
273 | 273 | def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version |
|
|
274 | 274 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue') |
|
|
275 | 275 | assert !issue.save |
|
|
276 | 276 | assert_not_nil issue.errors.on(:fixed_version_id) |
|
|
277 | 277 | end |
|
|
278 | 278 | |
|
|
279 | 279 | def test_should_be_able_to_assign_a_new_issue_to_an_open_version |
|
|
280 | 280 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue') |
|
|
281 | 281 | assert issue.save |
|
|
282 | 282 | end |
|
|
283 | 283 | |
|
|
284 | 284 | def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version |
|
|
285 | 285 | issue = Issue.find(11) |
|
|
286 | 286 | assert_equal 'closed', issue.fixed_version.status |
|
|
287 | 287 | issue.subject = 'Subject changed' |
|
|
288 | 288 | assert issue.save |
|
|
289 | 289 | end |
|
|
290 | 290 | |
|
|
291 | 291 | def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version |
|
|
292 | 292 | issue = Issue.find(11) |
|
|
293 | 293 | issue.status_id = 1 |
|
|
294 | 294 | assert !issue.save |
|
|
295 | 295 | assert_not_nil issue.errors.on_base |
|
|
296 | 296 | end |
|
|
297 | 297 | |
|
|
298 | 298 | def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version |
|
|
299 | 299 | issue = Issue.find(11) |
|
|
300 | 300 | issue.status_id = 1 |
|
|
301 | 301 | issue.fixed_version_id = 3 |
|
|
302 | 302 | assert issue.save |
|
|
303 | 303 | end |
|
|
304 | 304 | |
|
|
305 | 305 | def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version |
|
|
306 | 306 | issue = Issue.find(12) |
|
|
307 | 307 | assert_equal 'locked', issue.fixed_version.status |
|
|
308 | 308 | issue.status_id = 1 |
|
|
309 | 309 | assert issue.save |
|
|
310 | 310 | end |
|
|
311 | 311 | |
|
|
312 | 312 | def test_move_to_another_project_with_same_category |
|
|
313 | 313 | issue = Issue.find(1) |
|
|
314 | 314 | assert issue.move_to(Project.find(2)) |
|
|
315 | 315 | issue.reload |
|
|
316 | 316 | assert_equal 2, issue.project_id |
|
|
317 | 317 | # Category changes |
|
|
318 | 318 | assert_equal 4, issue.category_id |
|
|
319 | 319 | # Make sure time entries were move to the target project |
|
|
320 | 320 | assert_equal 2, issue.time_entries.first.project_id |
|
|
321 | 321 | end |
|
|
322 | 322 | |
|
|
323 | 323 | def test_move_to_another_project_without_same_category |
|
|
324 | 324 | issue = Issue.find(2) |
|
|
325 | 325 | assert issue.move_to(Project.find(2)) |
|
|
326 | 326 | issue.reload |
|
|
327 | 327 | assert_equal 2, issue.project_id |
|
|
328 | 328 | # Category cleared |
|
|
329 | 329 | assert_nil issue.category_id |
|
|
330 | 330 | end |
|
|
331 | 331 | |
|
|
332 | 332 | def test_copy_to_the_same_project |
|
|
333 | 333 | issue = Issue.find(1) |
|
|
334 | 334 | copy = nil |
|
|
335 | 335 | assert_difference 'Issue.count' do |
|
|
336 | 336 | copy = issue.move_to(issue.project, nil, :copy => true) |
|
|
337 | 337 | end |
|
|
338 | 338 | assert_kind_of Issue, copy |
|
|
339 | 339 | assert_equal issue.project, copy.project |
|
|
340 | 340 | assert_equal "125", copy.custom_value_for(2).value |
|
|
341 | 341 | end |
|
|
342 | 342 | |
|
|
343 | 343 | def test_copy_to_another_project_and_tracker |
|
|
344 | 344 | issue = Issue.find(1) |
|
|
345 | 345 | copy = nil |
|
|
346 | 346 | assert_difference 'Issue.count' do |
|
|
347 | 347 | copy = issue.move_to(Project.find(3), Tracker.find(2), :copy => true) |
|
|
348 | 348 | end |
|
|
349 | 349 | assert_kind_of Issue, copy |
|
|
350 | 350 | assert_equal Project.find(3), copy.project |
|
|
351 | 351 | assert_equal Tracker.find(2), copy.tracker |
|
|
352 | 352 | # Custom field #2 is not associated with target tracker |
|
|
353 | 353 | assert_nil copy.custom_value_for(2) |
|
|
354 | 354 | end |
|
|
355 | ||
|
|
356 | context "#move_to" do | |
|
|
357 | context "as a copy" do | |
|
|
358 | setup do | |
|
|
359 | @issue = Issue.find(1) | |
|
|
360 | @copy = nil | |
|
|
361 | end | |
|
|
362 | ||
|
|
363 | should "allow assigned_to changes" do | |
|
|
364 | @copy = @issue.move_to(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}}) | |
|
|
365 | assert_equal 3, @copy.assigned_to_id | |
|
|
366 | end | |
|
|
367 | ||
|
|
368 | should "allow status changes" do | |
|
|
369 | @copy = @issue.move_to(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}}) | |
|
|
370 | assert_equal 2, @copy.status_id | |
|
|
371 | end | |
|
|
372 | ||
|
|
373 | should "allow start date changes" do | |
|
|
374 | date = Date.today | |
|
|
375 | @copy = @issue.move_to(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}}) | |
|
|
376 | assert_equal date, @copy.start_date | |
|
|
377 | end | |
|
|
378 | ||
|
|
379 | should "allow due date changes" do | |
|
|
380 | date = Date.today | |
|
|
381 | @copy = @issue.move_to(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}}) | |
|
|
382 | ||
|
|
383 | assert_equal date, @copy.due_date | |
|
|
384 | end | |
|
|
385 | end | |
|
|
386 | end | |
|
|
355 | 387 | |
|
|
356 | 388 | def test_recipients_should_not_include_users_that_cannot_view_the_issue |
|
|
357 | 389 | issue = Issue.find(12) |
|
|
358 | 390 | assert issue.recipients.include?(issue.author.mail) |
|
|
359 | 391 | # move the issue to a private project |
|
|
360 | 392 | copy = issue.move_to(Project.find(5), Tracker.find(2), :copy => true) |
|
|
361 | 393 | # author is not a member of project anymore |
|
|
362 | 394 | assert !copy.recipients.include?(copy.author.mail) |
|
|
363 | 395 | end |
|
|
364 | 396 | |
|
|
365 | 397 | def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue |
|
|
366 | 398 | user = User.find(3) |
|
|
367 | 399 | issue = Issue.find(9) |
|
|
368 | 400 | Watcher.create!(:user => user, :watchable => issue) |
|
|
369 | 401 | assert issue.watched_by?(user) |
|
|
370 | 402 | assert !issue.watcher_recipients.include?(user.mail) |
|
|
371 | 403 | end |
|
|
372 | 404 | |
|
|
373 | 405 | def test_issue_destroy |
|
|
374 | 406 | Issue.find(1).destroy |
|
|
375 | 407 | assert_nil Issue.find_by_id(1) |
|
|
376 | 408 | assert_nil TimeEntry.find_by_issue_id(1) |
|
|
377 | 409 | end |
|
|
378 | 410 | |
|
|
379 | 411 | def test_blocked |
|
|
380 | 412 | blocked_issue = Issue.find(9) |
|
|
381 | 413 | blocking_issue = Issue.find(10) |
|
|
382 | 414 | |
|
|
383 | 415 | assert blocked_issue.blocked? |
|
|
384 | 416 | assert !blocking_issue.blocked? |
|
|
385 | 417 | end |
|
|
386 | 418 | |
|
|
387 | 419 | def test_blocked_issues_dont_allow_closed_statuses |
|
|
388 | 420 | blocked_issue = Issue.find(9) |
|
|
389 | 421 | |
|
|
390 | 422 | allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002)) |
|
|
391 | 423 | assert !allowed_statuses.empty? |
|
|
392 | 424 | closed_statuses = allowed_statuses.select {|st| st.is_closed?} |
|
|
393 | 425 | assert closed_statuses.empty? |
|
|
394 | 426 | end |
|
|
395 | 427 | |
|
|
396 | 428 | def test_unblocked_issues_allow_closed_statuses |
|
|
397 | 429 | blocking_issue = Issue.find(10) |
|
|
398 | 430 | |
|
|
399 | 431 | allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002)) |
|
|
400 | 432 | assert !allowed_statuses.empty? |
|
|
401 | 433 | closed_statuses = allowed_statuses.select {|st| st.is_closed?} |
|
|
402 | 434 | assert !closed_statuses.empty? |
|
|
403 | 435 | end |
|
|
404 | 436 | |
|
|
405 | 437 | def test_overdue |
|
|
406 | 438 | assert Issue.new(:due_date => 1.day.ago.to_date).overdue? |
|
|
407 | 439 | assert !Issue.new(:due_date => Date.today).overdue? |
|
|
408 | 440 | assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue? |
|
|
409 | 441 | assert !Issue.new(:due_date => nil).overdue? |
|
|
410 | 442 | assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue? |
|
|
411 | 443 | end |
|
|
412 | 444 | |
|
|
413 | 445 | def test_assignable_users |
|
|
414 | 446 | assert_kind_of User, Issue.find(1).assignable_users.first |
|
|
415 | 447 | end |
|
|
416 | 448 | |
|
|
417 | 449 | def test_create_should_send_email_notification |
|
|
418 | 450 | ActionMailer::Base.deliveries.clear |
|
|
419 | 451 | issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30') |
|
|
420 | 452 | |
|
|
421 | 453 | assert issue.save |
|
|
422 | 454 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
423 | 455 | end |
|
|
424 | 456 | |
|
|
425 | 457 | def test_stale_issue_should_not_send_email_notification |
|
|
426 | 458 | ActionMailer::Base.deliveries.clear |
|
|
427 | 459 | issue = Issue.find(1) |
|
|
428 | 460 | stale = Issue.find(1) |
|
|
429 | 461 | |
|
|
430 | 462 | issue.init_journal(User.find(1)) |
|
|
431 | 463 | issue.subject = 'Subjet update' |
|
|
432 | 464 | assert issue.save |
|
|
433 | 465 | assert_equal 1, ActionMailer::Base.deliveries.size |
|
|
434 | 466 | ActionMailer::Base.deliveries.clear |
|
|
435 | 467 | |
|
|
436 | 468 | stale.init_journal(User.find(1)) |
|
|
437 | 469 | stale.subject = 'Another subjet update' |
|
|
438 | 470 | assert_raise ActiveRecord::StaleObjectError do |
|
|
439 | 471 | stale.save |
|
|
440 | 472 | end |
|
|
441 | 473 | assert ActionMailer::Base.deliveries.empty? |
|
|
442 | 474 | end |
|
|
443 | 475 | end |
General Comments 0
You need to be logged in to leave comments.
Login now