jro_apps/redmine Commit - r11227:e14caf8e33fb

Use User#generate_password in MailHandler....

Jean-Philippe Lang -

r11227:e14caf8e33fb

parent child

Context file:

r11227:e14caf8e33fb

app/models/mail_handler.rb +1 -3

                 assign_string_attribute_with_limit(user, 'firstname', names.shift, 30)
                 assign_string_attribute_with_limit(user, 'lastname', names.join(' '), 30)
                 user.lastname = '-' if user.lastname.blank?
-                password_length = [Setting.password_min_length.to_i, 10].max
-                user.password = Redmine::Utils.random_hex(password_length / 2 + 1)
                 user.language = Setting.default_language
+                user.generate_password = true
                 unless user.valid?
                   user.login = "user#{Redmine::Utils.random_hex(6)}" unless user.errors[:login].blank?

test/unit/mail_handler_test.rb 0 -8

                 end
               end
-              def test_new_user_from_attributes_should_respect_minimum_password_length
-                with_settings :password_min_length => 15 do
-                  user = MailHandler.new_user_from_attributes('jsmith@example.net')
-                  assert user.valid?
-                  assert user.password.length >= 15
-                end
-              end
               def test_new_user_from_attributes_should_use_default_login_if_invalid
                 user = MailHandler.new_user_from_attributes('foo+bar@example.net')
                 assert user.valid?

test/unit/user_test.rb +14 0

@@ -70,6 +70,20 class UserTest < ActiveSupport::TestCase
70	assert user.save	70	assert user.save
71	end	71	end
72		72
		73	def test_generate_password_should_respect_minimum_password_length
		74	with_settings :password_min_length => 15 do
		75	user = User.generate!(:generate_password => true)
		76	assert user.password.length >= 15
		77	end
		78	end
		79
		80	def test_generate_password_should_not_generate_password_with_less_than_10_characters
		81	with_settings :password_min_length => 4 do
		82	user = User.generate!(:generate_password => true)
		83	assert user.password.length >= 10
		84	end
		85	end
		86
73	def test_generate_password_on_create_should_set_password	87	def test_generate_password_on_create_should_set_password
74	user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")	88	user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
75	user.login = "newuser"	89	user.login = "newuser"

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages