##// END OF EJS Templates
jro_apps » redmine
RSS
Fixed: Files assigned to a version can not be deleted if Issue Tracking module is disabled (#17163)....
Jean-Philippe Lang -
r13027:e124da548829
parent child
Show More
Side by Side Unified
Context file:
r13027:e124da548829 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,295 +1,299
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Version < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 after_update :update_issues_from_sharing_change
21 21 belongs_to :project
22 22 has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id', :dependent => :nullify
23 23 acts_as_customizable
24 24 acts_as_attachable :view_permission => :view_files,
25 25 :delete_permission => :manage_files
26 26
27 27 VERSION_STATUSES = %w(open locked closed)
28 28 VERSION_SHARINGS = %w(none descendants hierarchy tree system)
29 29
30 30 validates_presence_of :name
31 31 validates_uniqueness_of :name, :scope => [:project_id]
32 32 validates_length_of :name, :maximum => 60
33 33 validates :effective_date, :date => true
34 34 validates_inclusion_of :status, :in => VERSION_STATUSES
35 35 validates_inclusion_of :sharing, :in => VERSION_SHARINGS
36 36
37 37 scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
38 38 scope :open, lambda { where(:status => 'open') }
39 39 scope :visible, lambda {|*args|
40 40 includes(:project).where(Project.allowed_to_condition(args.first || User.current, :view_issues))
41 41 }
42 42
43 43 safe_attributes 'name',
44 44 'description',
45 45 'effective_date',
46 46 'due_date',
47 47 'wiki_page_title',
48 48 'status',
49 49 'sharing',
50 50 'custom_field_values',
51 51 'custom_fields'
52 52
53 53 # Returns true if +user+ or current user is allowed to view the version
54 54 def visible?(user=User.current)
55 55 user.allowed_to?(:view_issues, self.project)
56 56 end
57 57
58 58 # Version files have same visibility as project files
59 59 def attachments_visible?(*args)
60 60 project.present? && project.attachments_visible?(*args)
61 61 end
62 62
63 def attachments_deletable?(usr=User.current)
64 project.present? && project.attachments_deletable?(usr)
65 end
66
63 67 def start_date
64 68 @start_date ||= fixed_issues.minimum('start_date')
65 69 end
66 70
67 71 def due_date
68 72 effective_date
69 73 end
70 74
71 75 def due_date=(arg)
72 76 self.effective_date=(arg)
73 77 end
74 78
75 79 # Returns the total estimated time for this version
76 80 # (sum of leaves estimated_hours)
77 81 def estimated_hours
78 82 @estimated_hours ||= fixed_issues.leaves.sum(:estimated_hours).to_f
79 83 end
80 84
81 85 # Returns the total reported time for this version
82 86 def spent_hours
83 87 @spent_hours ||= TimeEntry.joins(:issue).where("#{Issue.table_name}.fixed_version_id = ?", id).sum(:hours).to_f
84 88 end
85 89
86 90 def closed?
87 91 status == 'closed'
88 92 end
89 93
90 94 def open?
91 95 status == 'open'
92 96 end
93 97
94 98 # Returns true if the version is completed: due date reached and no open issues
95 99 def completed?
96 100 effective_date && (effective_date < Date.today) && (open_issues_count == 0)
97 101 end
98 102
99 103 def behind_schedule?
100 104 if completed_percent == 100
101 105 return false
102 106 elsif due_date && start_date
103 107 done_date = start_date + ((due_date - start_date+1)* completed_percent/100).floor
104 108 return done_date <= Date.today
105 109 else
106 110 false # No issues so it's not late
107 111 end
108 112 end
109 113
110 114 # Returns the completion percentage of this version based on the amount of open/closed issues
111 115 # and the time spent on the open issues.
112 116 def completed_percent
113 117 if issues_count == 0
114 118 0
115 119 elsif open_issues_count == 0
116 120 100
117 121 else
118 122 issues_progress(false) + issues_progress(true)
119 123 end
120 124 end
121 125
122 126 # TODO: remove in Redmine 3.0
123 127 def completed_pourcent
124 128 ActiveSupport::Deprecation.warn "Version#completed_pourcent is deprecated and will be removed in Redmine 3.0. Please use #completed_percent instead."
125 129 completed_percent
126 130 end
127 131
128 132 # Returns the percentage of issues that have been marked as 'closed'.
129 133 def closed_percent
130 134 if issues_count == 0
131 135 0
132 136 else
133 137 issues_progress(false)
134 138 end
135 139 end
136 140
137 141 # TODO: remove in Redmine 3.0
138 142 def closed_pourcent
139 143 ActiveSupport::Deprecation.warn "Version#closed_pourcent is deprecated and will be removed in Redmine 3.0. Please use #closed_percent instead."
140 144 closed_percent
141 145 end
142 146
143 147 # Returns true if the version is overdue: due date reached and some open issues
144 148 def overdue?
145 149 effective_date && (effective_date < Date.today) && (open_issues_count > 0)
146 150 end
147 151
148 152 # Returns assigned issues count
149 153 def issues_count
150 154 load_issue_counts
151 155 @issue_count
152 156 end
153 157
154 158 # Returns the total amount of open issues for this version.
155 159 def open_issues_count
156 160 load_issue_counts
157 161 @open_issues_count
158 162 end
159 163
160 164 # Returns the total amount of closed issues for this version.
161 165 def closed_issues_count
162 166 load_issue_counts
163 167 @closed_issues_count
164 168 end
165 169
166 170 def wiki_page
167 171 if project.wiki && !wiki_page_title.blank?
168 172 @wiki_page ||= project.wiki.find_page(wiki_page_title)
169 173 end
170 174 @wiki_page
171 175 end
172 176
173 177 def to_s; name end
174 178
175 179 def to_s_with_project
176 180 "#{project} - #{name}"
177 181 end
178 182
179 183 # Versions are sorted by effective_date and name
180 184 # Those with no effective_date are at the end, sorted by name
181 185 def <=>(version)
182 186 if self.effective_date
183 187 if version.effective_date
184 188 if self.effective_date == version.effective_date
185 189 name == version.name ? id <=> version.id : name <=> version.name
186 190 else
187 191 self.effective_date <=> version.effective_date
188 192 end
189 193 else
190 194 -1
191 195 end
192 196 else
193 197 if version.effective_date
194 198 1
195 199 else
196 200 name == version.name ? id <=> version.id : name <=> version.name
197 201 end
198 202 end
199 203 end
200 204
201 205 def self.fields_for_order_statement(table=nil)
202 206 table ||= table_name
203 207 ["(CASE WHEN #{table}.effective_date IS NULL THEN 1 ELSE 0 END)", "#{table}.effective_date", "#{table}.name", "#{table}.id"]
204 208 end
205 209
206 210 scope :sorted, lambda { order(fields_for_order_statement) }
207 211
208 212 # Returns the sharings that +user+ can set the version to
209 213 def allowed_sharings(user = User.current)
210 214 VERSION_SHARINGS.select do |s|
211 215 if sharing == s
212 216 true
213 217 else
214 218 case s
215 219 when 'system'
216 220 # Only admin users can set a systemwide sharing
217 221 user.admin?
218 222 when 'hierarchy', 'tree'
219 223 # Only users allowed to manage versions of the root project can
220 224 # set sharing to hierarchy or tree
221 225 project.nil? || user.allowed_to?(:manage_versions, project.root)
222 226 else
223 227 true
224 228 end
225 229 end
226 230 end
227 231 end
228 232
229 233 # Returns true if the version is shared, otherwise false
230 234 def shared?
231 235 sharing != 'none'
232 236 end
233 237
234 238 private
235 239
236 240 def load_issue_counts
237 241 unless @issue_count
238 242 @open_issues_count = 0
239 243 @closed_issues_count = 0
240 244 fixed_issues.group(:status).count.each do |status, count|
241 245 if status.is_closed?
242 246 @closed_issues_count += count
243 247 else
244 248 @open_issues_count += count
245 249 end
246 250 end
247 251 @issue_count = @open_issues_count + @closed_issues_count
248 252 end
249 253 end
250 254
251 255 # Update the issue's fixed versions. Used if a version's sharing changes.
252 256 def update_issues_from_sharing_change
253 257 if sharing_changed?
254 258 if VERSION_SHARINGS.index(sharing_was).nil? ||
255 259 VERSION_SHARINGS.index(sharing).nil? ||
256 260 VERSION_SHARINGS.index(sharing_was) > VERSION_SHARINGS.index(sharing)
257 261 Issue.update_versions_from_sharing_change self
258 262 end
259 263 end
260 264 end
261 265
262 266 # Returns the average estimated time of assigned issues
263 267 # or 1 if no issue has an estimated time
264 268 # Used to weight unestimated issues in progress calculation
265 269 def estimated_average
266 270 if @estimated_average.nil?
267 271 average = fixed_issues.average(:estimated_hours).to_f
268 272 if average == 0
269 273 average = 1
270 274 end
271 275 @estimated_average = average
272 276 end
273 277 @estimated_average
274 278 end
275 279
276 280 # Returns the total progress of open or closed issues. The returned percentage takes into account
277 281 # the amount of estimated time set for this version.
278 282 #
279 283 # Examples:
280 284 # issues_progress(true) => returns the progress percentage for open issues.
281 285 # issues_progress(false) => returns the progress percentage for closed issues.
282 286 def issues_progress(open)
283 287 @issues_progress ||= {}
284 288 @issues_progress[open] ||= begin
285 289 progress = 0
286 290 if issues_count > 0
287 291 ratio = open ? 'done_ratio' : 100
288 292
289 293 done = fixed_issues.open(open).sum("COALESCE(estimated_hours, #{estimated_average}) * #{ratio}").to_f
290 294 progress = done / (estimated_average * issues_count)
291 295 end
292 296 progress
293 297 end
294 298 end
295 299 end
Show file before | Show file after | Hide comments
@@ -1,398 +1,408
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2014 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 require File.expand_path('../../test_helper', __FILE__)
21 21
22 22 class AttachmentsControllerTest < ActionController::TestCase
23 23 fixtures :users, :projects, :roles, :members, :member_roles,
24 24 :enabled_modules, :issues, :trackers, :attachments,
25 25 :versions, :wiki_pages, :wikis, :documents
26 26
27 27 def setup
28 28 User.current = nil
29 29 set_fixtures_attachments_directory
30 30 end
31 31
32 32 def teardown
33 33 set_tmp_attachments_directory
34 34 end
35 35
36 36 def test_show_diff
37 37 ['inline', 'sbs'].each do |dt|
38 38 # 060719210727_changeset_utf8.diff
39 39 get :show, :id => 14, :type => dt
40 40 assert_response :success
41 41 assert_template 'diff'
42 42 assert_equal 'text/html', @response.content_type
43 43 assert_tag 'th',
44 44 :attributes => {:class => /filename/},
45 45 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
46 46 assert_tag 'td',
47 47 :attributes => {:class => /line-code/},
48 48 :content => /Demande créée avec succès/
49 49 end
50 50 set_tmp_attachments_directory
51 51 end
52 52
53 53 def test_show_diff_replace_cannot_convert_content
54 54 with_settings :repositories_encodings => 'UTF-8' do
55 55 ['inline', 'sbs'].each do |dt|
56 56 # 060719210727_changeset_iso8859-1.diff
57 57 get :show, :id => 5, :type => dt
58 58 assert_response :success
59 59 assert_template 'diff'
60 60 assert_equal 'text/html', @response.content_type
61 61 assert_tag 'th',
62 62 :attributes => {:class => "filename"},
63 63 :content => /issues_controller.rb\t\(r\?vision 1484\)/
64 64 assert_tag 'td',
65 65 :attributes => {:class => /line-code/},
66 66 :content => /Demande cr\?\?e avec succ\?s/
67 67 end
68 68 end
69 69 set_tmp_attachments_directory
70 70 end
71 71
72 72 def test_show_diff_latin_1
73 73 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
74 74 ['inline', 'sbs'].each do |dt|
75 75 # 060719210727_changeset_iso8859-1.diff
76 76 get :show, :id => 5, :type => dt
77 77 assert_response :success
78 78 assert_template 'diff'
79 79 assert_equal 'text/html', @response.content_type
80 80 assert_tag 'th',
81 81 :attributes => {:class => "filename"},
82 82 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
83 83 assert_tag 'td',
84 84 :attributes => {:class => /line-code/},
85 85 :content => /Demande créée avec succès/
86 86 end
87 87 end
88 88 set_tmp_attachments_directory
89 89 end
90 90
91 91 def test_save_diff_type
92 92 user1 = User.find(1)
93 93 user1.pref[:diff_type] = nil
94 94 user1.preference.save
95 95 user = User.find(1)
96 96 assert_nil user.pref[:diff_type]
97 97
98 98 @request.session[:user_id] = 1 # admin
99 99 get :show, :id => 5
100 100 assert_response :success
101 101 assert_template 'diff'
102 102 user.reload
103 103 assert_equal "inline", user.pref[:diff_type]
104 104 get :show, :id => 5, :type => 'sbs'
105 105 assert_response :success
106 106 assert_template 'diff'
107 107 user.reload
108 108 assert_equal "sbs", user.pref[:diff_type]
109 109 end
110 110
111 111 def test_diff_show_filename_in_mercurial_export
112 112 set_tmp_attachments_directory
113 113 a = Attachment.new(:container => Issue.find(1),
114 114 :file => uploaded_test_file("hg-export.diff", "text/plain"),
115 115 :author => User.find(1))
116 116 assert a.save
117 117 assert_equal 'hg-export.diff', a.filename
118 118
119 119 get :show, :id => a.id, :type => 'inline'
120 120 assert_response :success
121 121 assert_template 'diff'
122 122 assert_equal 'text/html', @response.content_type
123 123 assert_select 'th.filename', :text => 'test1.txt'
124 124 end
125 125
126 126 def test_show_text_file
127 127 get :show, :id => 4
128 128 assert_response :success
129 129 assert_template 'file'
130 130 assert_equal 'text/html', @response.content_type
131 131 set_tmp_attachments_directory
132 132 end
133 133
134 134 def test_show_text_file_utf_8
135 135 set_tmp_attachments_directory
136 136 a = Attachment.new(:container => Issue.find(1),
137 137 :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
138 138 :author => User.find(1))
139 139 assert a.save
140 140 assert_equal 'japanese-utf-8.txt', a.filename
141 141
142 142 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
143 143 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
144 144
145 145 get :show, :id => a.id
146 146 assert_response :success
147 147 assert_template 'file'
148 148 assert_equal 'text/html', @response.content_type
149 149 assert_tag :tag => 'th',
150 150 :content => '1',
151 151 :attributes => { :class => 'line-num' },
152 152 :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
153 153 end
154 154
155 155 def test_show_text_file_replace_cannot_convert_content
156 156 set_tmp_attachments_directory
157 157 with_settings :repositories_encodings => 'UTF-8' do
158 158 a = Attachment.new(:container => Issue.find(1),
159 159 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
160 160 :author => User.find(1))
161 161 assert a.save
162 162 assert_equal 'iso8859-1.txt', a.filename
163 163
164 164 get :show, :id => a.id
165 165 assert_response :success
166 166 assert_template 'file'
167 167 assert_equal 'text/html', @response.content_type
168 168 assert_tag :tag => 'th',
169 169 :content => '7',
170 170 :attributes => { :class => 'line-num' },
171 171 :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
172 172 end
173 173 end
174 174
175 175 def test_show_text_file_latin_1
176 176 set_tmp_attachments_directory
177 177 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
178 178 a = Attachment.new(:container => Issue.find(1),
179 179 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
180 180 :author => User.find(1))
181 181 assert a.save
182 182 assert_equal 'iso8859-1.txt', a.filename
183 183
184 184 get :show, :id => a.id
185 185 assert_response :success
186 186 assert_template 'file'
187 187 assert_equal 'text/html', @response.content_type
188 188 assert_tag :tag => 'th',
189 189 :content => '7',
190 190 :attributes => { :class => 'line-num' },
191 191 :sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
192 192 end
193 193 end
194 194
195 195 def test_show_text_file_should_send_if_too_big
196 196 with_settings :file_max_size_displayed => 512 do
197 197 Attachment.find(4).update_attribute :filesize, 754.kilobyte
198 198 get :show, :id => 4
199 199 assert_response :success
200 200 assert_equal 'application/x-ruby', @response.content_type
201 201 end
202 202 set_tmp_attachments_directory
203 203 end
204 204
205 205 def test_show_other
206 206 get :show, :id => 6
207 207 assert_response :success
208 208 assert_equal 'application/octet-stream', @response.content_type
209 209 set_tmp_attachments_directory
210 210 end
211 211
212 212 def test_show_file_from_private_issue_without_permission
213 213 get :show, :id => 15
214 214 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
215 215 set_tmp_attachments_directory
216 216 end
217 217
218 218 def test_show_file_from_private_issue_with_permission
219 219 @request.session[:user_id] = 2
220 220 get :show, :id => 15
221 221 assert_response :success
222 222 assert_tag 'h2', :content => /private.diff/
223 223 set_tmp_attachments_directory
224 224 end
225 225
226 226 def test_show_file_without_container_should_be_allowed_to_author
227 227 set_tmp_attachments_directory
228 228 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
229 229
230 230 @request.session[:user_id] = 2
231 231 get :show, :id => attachment.id
232 232 assert_response 200
233 233 end
234 234
235 235 def test_show_file_without_container_should_be_denied_to_other_users
236 236 set_tmp_attachments_directory
237 237 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
238 238
239 239 @request.session[:user_id] = 3
240 240 get :show, :id => attachment.id
241 241 assert_response 403
242 242 end
243 243
244 244 def test_show_invalid_should_respond_with_404
245 245 get :show, :id => 999
246 246 assert_response 404
247 247 end
248 248
249 249 def test_download_text_file
250 250 get :download, :id => 4
251 251 assert_response :success
252 252 assert_equal 'application/x-ruby', @response.content_type
253 253 etag = @response.etag
254 254 assert_not_nil etag
255 255
256 256 @request.env["HTTP_IF_NONE_MATCH"] = etag
257 257 get :download, :id => 4
258 258 assert_response 304
259 259
260 260 set_tmp_attachments_directory
261 261 end
262 262
263 263 def test_download_version_file_with_issue_tracking_disabled
264 264 Project.find(1).disable_module! :issue_tracking
265 265 get :download, :id => 9
266 266 assert_response :success
267 267 end
268 268
269 269 def test_download_should_assign_content_type_if_blank
270 270 Attachment.find(4).update_attribute(:content_type, '')
271 271
272 272 get :download, :id => 4
273 273 assert_response :success
274 274 assert_equal 'text/x-ruby', @response.content_type
275 275 set_tmp_attachments_directory
276 276 end
277 277
278 278 def test_download_missing_file
279 279 get :download, :id => 2
280 280 assert_response 404
281 281 set_tmp_attachments_directory
282 282 end
283 283
284 284 def test_download_should_be_denied_without_permission
285 285 get :download, :id => 7
286 286 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
287 287 set_tmp_attachments_directory
288 288 end
289 289
290 290 if convert_installed?
291 291 def test_thumbnail
292 292 Attachment.clear_thumbnails
293 293 @request.session[:user_id] = 2
294 294 get :thumbnail, :id => 16
295 295 assert_response :success
296 296 assert_equal 'image/png', response.content_type
297 297
298 298 etag = @response.etag
299 299 assert_not_nil etag
300 300
301 301 @request.env["HTTP_IF_NONE_MATCH"] = etag
302 302 get :thumbnail, :id => 16
303 303 assert_response 304
304 304 end
305 305
306 306 def test_thumbnail_should_not_exceed_maximum_size
307 307 Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 800}
308 308
309 309 @request.session[:user_id] = 2
310 310 get :thumbnail, :id => 16, :size => 2000
311 311 end
312 312
313 313 def test_thumbnail_should_round_size
314 314 Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 250}
315 315
316 316 @request.session[:user_id] = 2
317 317 get :thumbnail, :id => 16, :size => 260
318 318 end
319 319
320 320 def test_thumbnail_should_return_404_for_non_image_attachment
321 321 @request.session[:user_id] = 2
322 322
323 323 get :thumbnail, :id => 15
324 324 assert_response 404
325 325 end
326 326
327 327 def test_thumbnail_should_return_404_if_thumbnail_generation_failed
328 328 Attachment.any_instance.stubs(:thumbnail).returns(nil)
329 329 @request.session[:user_id] = 2
330 330
331 331 get :thumbnail, :id => 16
332 332 assert_response 404
333 333 end
334 334
335 335 def test_thumbnail_should_be_denied_without_permission
336 336 get :thumbnail, :id => 16
337 337 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fthumbnail%2F16'
338 338 end
339 339 else
340 340 puts '(ImageMagick convert not available)'
341 341 end
342 342
343 343 def test_destroy_issue_attachment
344 344 set_tmp_attachments_directory
345 345 issue = Issue.find(3)
346 346 @request.session[:user_id] = 2
347 347
348 348 assert_difference 'issue.attachments.count', -1 do
349 349 assert_difference 'Journal.count' do
350 350 delete :destroy, :id => 1
351 351 assert_redirected_to '/projects/ecookbook'
352 352 end
353 353 end
354 354 assert_nil Attachment.find_by_id(1)
355 355 j = Journal.order('id DESC').first
356 356 assert_equal issue, j.journalized
357 357 assert_equal 'attachment', j.details.first.property
358 358 assert_equal '1', j.details.first.prop_key
359 359 assert_equal 'error281.txt', j.details.first.old_value
360 360 assert_equal User.find(2), j.user
361 361 end
362 362
363 363 def test_destroy_wiki_page_attachment
364 364 set_tmp_attachments_directory
365 365 @request.session[:user_id] = 2
366 366 assert_difference 'Attachment.count', -1 do
367 367 delete :destroy, :id => 3
368 368 assert_response 302
369 369 end
370 370 end
371 371
372 372 def test_destroy_project_attachment
373 373 set_tmp_attachments_directory
374 374 @request.session[:user_id] = 2
375 375 assert_difference 'Attachment.count', -1 do
376 376 delete :destroy, :id => 8
377 377 assert_response 302
378 378 end
379 379 end
380 380
381 381 def test_destroy_version_attachment
382 382 set_tmp_attachments_directory
383 383 @request.session[:user_id] = 2
384 384 assert_difference 'Attachment.count', -1 do
385 385 delete :destroy, :id => 9
386 386 assert_response 302
387 387 end
388 388 end
389 389
390 def test_destroy_version_attachment_with_issue_tracking_disabled
391 Project.find(1).disable_module! :issue_tracking
392 set_tmp_attachments_directory
393 @request.session[:user_id] = 2
394 assert_difference 'Attachment.count', -1 do
395 delete :destroy, :id => 9
396 assert_response 302
397 end
398 end
399
390 400 def test_destroy_without_permission
391 401 set_tmp_attachments_directory
392 402 assert_no_difference 'Attachment.count' do
393 403 delete :destroy, :id => 3
394 404 end
395 405 assert_response 302
396 406 assert Attachment.find_by_id(3)
397 407 end
398 408 end
General Comments 0
You need to be logged in to leave comments. Login now