jro_apps/redmine Commit - r13954:e12322dac3ba

0

config/configuration.yml.example +7 0

                # same secret token on each machine.
                #secret_token: 'change it to a long random string'
+               # Requires users to re-enter their password for sensitive actions (editing
+               # of account data, project memberships, application settings, user, group,
+               # role, auth source management and project deletion).
+               # Disabled by default.
+               #
+               #sudo_mode: true
                # Absolute path (e.g. /usr/bin/convert, c:/im/convert.exe) to
                # the ImageMagick's `convert` binary. Used to generate attachment thumbnails.
                #imagemagick_convert_command:

0

lib/redmine/sudo_mode.rb +3 -4

                  end
                  def self.possible?
-                   !disabled? && User.current.logged?
+                   enabled? && User.current.logged?
                  end
                  # Turn off sudo mode (never require password entry).
                    RequestStore.store[:sudo_mode_disabled] = nil
                  end
-                 def self.disabled?
-                   !!RequestStore.store[:sudo_mode_disabled]
+                 def self.enabled?
+                   Redmine::Configuration['sudo_mode'] && !RequestStore.store[:sudo_mode_disabled]
                  end
                end
              end

0

test/functional/auth_sources_controller_test.rb 0 -1

                def setup
                  @request.session[:user_id] = 1
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/functional/email_addresses_controller_test.rb 0 -1

                def setup
                  User.current = nil
-                 Redmine::SudoMode.disable!
                end
                def test_index_with_no_additional_emails

0

test/functional/groups_controller_test.rb 0 -1

                def setup
                  @request.session[:user_id] = 1
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/functional/members_controller_test.rb 0 -1

                def setup
                  User.current = nil
                  @request.session[:user_id] = 2
-                 Redmine::SudoMode.disable!
                end
                def test_new

0

test/functional/my_controller_test.rb 0 -1

                def setup
                  @request.session[:user_id] = 2
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/functional/projects_controller_test.rb 0 -1

                def setup
                  @request.session[:user_id] = nil
                  Setting.default_language = 'en'
-                 Redmine::SudoMode.disable!
                end
                def test_index_by_anonymous_should_not_show_private_projects

0

test/functional/roles_controller_test.rb 0 -1

                def setup
                  User.current = nil
                  @request.session[:user_id] = 1 # admin
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/functional/settings_controller_test.rb 0 -1

                def setup
                  User.current = nil
                  @request.session[:user_id] = 1 # admin
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/functional/users_controller_test.rb 0 -1

                def setup
                  User.current = nil
                  @request.session[:user_id] = 1 # admin
-                 Redmine::SudoMode.disable!
                end
                def test_index

0

test/integration/admin_test.rb 0 -17

                         :members,
                         :enabled_modules
-               def setup
-                 Redmine::SudoMode.enable!
-               end
-               def teardown
-                 Redmine::SudoMode.disable!
-               end
                def test_add_user
                  log_user("admin", "admin")
                  get "/users/new"
                                  :lastname => "Smith", :mail => "psmith@somenet.foo",
                                  :language => "en", :password => "psmith09",
                                  :password_confirmation => "psmith09" }
-                 assert_response :success
-                 assert_nil User.find_by_login("psmith")
-                 post "/users",
-                      :user => { :login => "psmith", :firstname => "Paul",
-                                 :lastname => "Smith", :mail => "psmith@somenet.foo",
-                                 :language => "en", :password => "psmith09",
-                                 :password_confirmation => "psmith09" },
-                      :sudo_password => 'admin'
                  user = User.find_by_login("psmith")
                  assert_kind_of User, user

0

test/integration/sudo_test.rb +23 -3

                fixtures :projects, :members, :member_roles, :roles, :users
                def setup
-                 Redmine::SudoMode.enable!
+                 Redmine::SudoMode.stubs(:enabled?).returns(true)
                end
-               def teardown
-                 Redmine::SudoMode.disable!
+               def test_add_user
+                 log_user("admin", "admin")
+                 get "/users/new"
+                 assert_response :success
+                 post "/users",
+                      :user => { :login => "psmith", :firstname => "Paul",
+                                 :lastname => "Smith", :mail => "psmith@somenet.foo",
+                                 :language => "en", :password => "psmith09",
+                                 :password_confirmation => "psmith09" }
+                 assert_response :success
+                 assert_nil User.find_by_login("psmith")
+                 post "/users",
+                      :user => { :login => "psmith", :firstname => "Paul",
+                                 :lastname => "Smith", :mail => "psmith@somenet.foo",
+                                 :language => "en", :password => "psmith09",
+                                 :password_confirmation => "psmith09" },
+                      :sudo_password => 'admin'
+                 assert_response 302
+                 user = User.find_by_login("psmith")
+                 assert_kind_of User, user
                end
                def test_create_member_xhr

0

test/test_helper.rb +2 0

              require 'net/ldap'
              require 'mocha/setup'
+             Redmine::SudoMode.disable!
              class ActionView::TestCase
                helper :application
                include ApplicationHelper

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages