jro_apps/redmine Commit - r15423:ddc575564744

Use a single hash as argument....

Jean-Philippe Lang -

r15423:ddc575564744

parent child

Context file:

r15423:ddc575564744

test/functional/issues_controller_test.rb +1 -1

                  @request.session[:user_id] = 2
                  tracker = Tracker.find(2)
                  tracker.update! :default_status_id => 2
-                 tracker.generate_transitions! 2, 1, :clear => true
+                 tracker.generate_transitions! 2 => 1, :clear => true
                  post :new, :project_id => 1,
                             :issue => {:tracker_id => 2,

test/object_helpers.rb +8 -8

              end
              module TrackerObjectHelpers
-               def generate_transitions!(*args)
-                 options = args.last.is_a?(Hash) ? args.pop : {}
-                 if args.size == 1
-                   args << args.first
-                 end
-                 if options[:clear]
+               def generate_transitions!(arg)
+                 if arg.delete(:clear)
                    WorkflowTransition.where(:tracker_id => id).delete_all
                  end
-                 args.each_cons(2) do |old_status_id, new_status_id|
+                 role_id = arg.delete(:role_id) || 1
+                 arg.each do |old_status_id, new_status_ids|
+                   Array.wrap(new_status_ids).each do |new_status_id|
                    WorkflowTransition.create!(
                      :tracker => self,
-                     :role_id => (options[:role_id] || 1),
+                       :role_id => role_id,
                      :old_status_id => old_status_id,
                      :new_status_id => new_status_id
                    )
                  end
                end
              end
+             end
              Tracker.send :include, TrackerObjectHelpers
              module IssueObjectHelpers

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages