jro_apps/redmine Commit - r14962:dcc569fa34f7

Removed the "New issue" menu item (#6204)....

Jean-Philippe Lang -

r14962:dcc569fa34f7

parent child

Context file:

r14962:dcc569fa34f7

Collapse all files

The requested changes are too big and content was truncated. Show full diff

app/controllers/issues_controller.rb 0 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
-              menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
               before_filter :authorize, :except => [:index, :new, :create]
               before_filter :find_optional_project, :only => [:index, :new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_rss_auth :index, :show
               accept_api_auth :index, :show, :create, :update, :destroy
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               helper :custom_fields
               helper :issue_relations
               helper :watchers
               helper :attachments
               helper :queries
               include QueriesHelper
               helper :repositories
               helper :sort
               include SortHelper
               helper :timelog
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 @query.sort_criteria = sort_criteria.to_a
                 if @query.valid?
                   case params[:format]
                   when 'csv', 'pdf'
                     @limit = Setting.issues_export_limit.to_i
                     if params[:columns] == 'all'
                       @query.column_names = @query.available_inline_columns.map(&:name)
                     end
                   when 'atom'
                     @limit = Setting.feeds_limit.to_i
                   when 'xml', 'json'
                     @offset, @limit = api_offset_and_limit
                     @query.column_names = %w(author)
                   else
                     @limit = per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new @issue_count, @limit, params['page']
                   @offset ||= @issue_pages.offset
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @offset,
                                           :limit => @limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index', :layout => !request.xhr? }
                     format.api  {
                       Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
                     }
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(query_to_csv(@issues, @query, params[:csv]), :type => 'text/csv; header=present', :filename => 'issues.csv') }
                     format.pdf  { send_file_headers! :type => 'application/pdf', :filename => 'issues.pdf' }
                   end
                 else
                   respond_to do |format|
                     format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
                     format.any(:atom, :csv, :pdf) { render(:nothing => true) }
                     format.api { render_validation_errors(@query) }
                   end
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.includes(:user, :details).
                                 references(:user, :details).
                                 reorder(:created_on, :id).to_a
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                 Journal.preload_journals_details_custom_fields(@journals)
                 @journals.select! {|journal| journal.notes? || journal.visible_details.any?}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.preload(:repository, :user).to_a
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.active
                 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 @relation = IssueRelation.new
                 respond_to do |format|
                   format.html {
                     retrieve_previous_and_next_issue_ids
                     render :template => 'issues/show'
                   }
                   format.api
                   format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  {
                     send_file_headers! :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf"
                   }
                 end
               end
               def new
                 respond_to do |format|
                   format.html { render :action => 'new', :layout => !request.xhr? }
                   format.js
                 end
               end
               def create
                 unless User.current.allowed_to?(:add_issues, @issue.project, :global => true)
                   raise ::Unauthorized
                 end
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                 if @issue.save
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       render_attachment_warning_if_needed(@issue)
                       flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
                       redirect_after_create
                     }
                     format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html {
                       if @issue.project.nil?
                         render_error :status => 422
                       else
                         render :action => 'new'
                       end
                     }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               def edit
                 return unless update_issue_from_params
                 respond_to do |format|
                   format.html { }
                   format.js
                 end
               end
               def update
                 return unless update_issue_from_params
                 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                 saved = false
                 begin
                   saved = save_issue_with_child_records
                 rescue ActiveRecord::StaleObjectError
                   @conflict = true
                   if params[:last_journal_id]
                     @conflict_journals = @issue.journals_after(params[:last_journal_id]).to_a
                     @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                   end
                 end
                 if saved
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default issue_path(@issue, previous_and_next_issue_ids_params) }
                     format.api  { render_api_ok }
                   end
                 else
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               # Bulk edit/copy a set of issues
               def bulk_edit
                 @issues.sort!
                 @copy = params[:copy].present?
                 @notes = params[:notes]
                 if @copy
                   unless User.current.allowed_to?(:copy_issues, @projects)
                     raise ::Unauthorized
                   end
                 end
                 @allowed_projects = Issue.allowed_target_projects
                 if params[:issue]
                   @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
                   if @target_project
                     target_projects = [@target_project]
                   end
                 end
                 target_projects ||= @projects
                 if @copy
                   # Copied issues will get their default statuses
                   @available_statuses = []
                 else
                   @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
                 end
                 @custom_fields = @issues.map{|i|i.editable_custom_fields}.reduce(:&)
                 @assignables = target_projects.map(&:assignable_users).reduce(:&)
                 @trackers = target_projects.map(&:trackers).reduce(:&)
                 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
                 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
                 if @copy
                   @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
                   @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
                 end
                 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
                 @issue_params = params[:issue] || {}
                 @issue_params[:custom_field_values] ||= {}
               end
               def bulk_update
                 @issues.sort!
                 @copy = params[:copy].present?
                 attributes = parse_params_for_bulk_issue_attributes(params)
                 copy_subtasks = (params[:copy_subtasks] == '1')
                 copy_attachments = (params[:copy_attachments] == '1')
                 if @copy
                   unless User.current.allowed_to?(:copy_issues, @projects)
                     raise ::Unauthorized
                   end
                   target_projects = @projects
                   if attributes['project_id'].present?
                     target_projects = Project.where(:id => attributes['project_id']).to_a
                   end
                   unless User.current.allowed_to?(:add_issues, target_projects)
                     raise ::Unauthorized
                   end
                 end
                 unsaved_issues = []
                 saved_issues = []
                 if @copy && copy_subtasks
                   # Descendant issues will be copied with the parent task
                   # Don't copy them twice
                   @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
                 end
                 @issues.each do |orig_issue|
                   orig_issue.reload
                   if @copy
                     issue = orig_issue.copy({},
                       :attachments => copy_attachments,
                       :subtasks => copy_subtasks,
                       :link => link_copy?(params[:link_copy])
                     )
                   else
                     issue = orig_issue
                   end
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                   if issue.save
                     saved_issues << issue
                   else
                     unsaved_issues << orig_issue
                   end
                 end
                 if unsaved_issues.empty?
                   flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
                   if params[:follow]
                     if @issues.size == 1 && saved_issues.size == 1
                       redirect_to issue_path(saved_issues.first)
                     elsif saved_issues.map(&:project).uniq.size == 1
                       redirect_to project_issues_path(saved_issues.map(&:project).first)
                     end
                   else
                     redirect_back_or_default _project_issues_path(@project)
                   end
                 else
                   @saved_issues = @issues
                   @unsaved_issues = unsaved_issues
                   @issues = Issue.visible.where(:id => @unsaved_issues.map(&:id)).to_a
                   bulk_edit
                   render :action => 'bulk_edit'
                 end
               end
               def destroy
                 @hours = TimeEntry.where(:issue_id => @issues.map(&:id)).sum(:hours).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.where(['issue_id IN (?)', @issues]).update_all('issue_id = NULL')
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.where(['issue_id IN (?)', @issues]).
                         update_all("issue_id = #{reassign_to.id}")
                     end
                   else
                     # display the destroy form if it's a user request
                     return unless api_request?
                   end
                 end
                 @issues.each do |issue|
                   begin
                     issue.reload.destroy
                   rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
                     # nothing to do, issue was already deleted (eg. by a parent)
                   end
                 end
                 respond_to do |format|
                   format.html { redirect_back_or_default _project_issues_path(@project) }
                   format.api  { render_api_ok }
                 end
               end
               private
               def retrieve_previous_and_next_issue_ids
                 if params[:prev_issue_id].present? || params[:next_issue_id].present?
                   @prev_issue_id = params[:prev_issue_id].presence.try(:to_i)
                   @next_issue_id = params[:next_issue_id].presence.try(:to_i)
                   @issue_position = params[:issue_position].presence.try(:to_i)
                   @issue_count = params[:issue_count].presence.try(:to_i)
                 else
                   retrieve_query_from_session
                   if @query
                     sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                     sort_update(@query.sortable_columns, 'issues_index_sort')
                     limit = 500
                     issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
                     if (idx = issue_ids.index(@issue.id)) && idx < limit
                       if issue_ids.size < 500
                         @issue_position = idx + 1
                         @issue_count = issue_ids.size
                       end
                       @prev_issue_id = issue_ids[idx - 1] if idx > 0
                       @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
                     end
                   end
                 end
               end
               def previous_and_next_issue_ids_params
                 {
                   :prev_issue_id => params[:prev_issue_id],
                   :next_issue_id => params[:next_issue_id],
                   :issue_position => params[:issue_position],
                   :issue_count => params[:issue_count]
                 }.reject {|k,v| k.blank?}
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               def update_issue_from_params
                 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 if params[:time_entry]
                   @time_entry.safe_attributes = params[:time_entry]
                 end
                 @issue.init_journal(User.current)
                 issue_attributes = params[:issue]
                 if issue_attributes && params[:conflict_resolution]
                   case params[:conflict_resolution]
                   when 'overwrite'
                     issue_attributes = issue_attributes.dup
                     issue_attributes.delete(:lock_version)
                   when 'add_notes'
                     issue_attributes = issue_attributes.slice(:notes, :private_notes)
                   when 'cancel'
                     redirect_to issue_path(@issue)
                     return false
                   end
                 end
                 @issue.safe_attributes = issue_attributes
                 @priorities = IssuePriority.active
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 true
               end
               # Used by #new and #create to build a new issue from the params
               # The new issue will be copied from an existing one if copy_from parameter is given
               def build_new_issue_from_params
                 @issue = Issue.new
                 if params[:copy_from]
                   begin
                     @issue.init_journal(User.current)
                     @copy_from = Issue.visible.find(params[:copy_from])
                     unless User.current.allowed_to?(:copy_issues, @copy_from.project)
                       raise ::Unauthorized
                     end
                     @link_copy = link_copy?(params[:link_copy]) || request.get?
                     @copy_attachments = params[:copy_attachments].present? || request.get?
                     @copy_subtasks = params[:copy_subtasks].present? || request.get?
                     @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks, :link => @link_copy)
                     @issue.parent_issue_id = @copy_from.parent_id
                   rescue ActiveRecord::RecordNotFound
                     render_404
                     return
                   end
                 end
                 @issue.project = @project
                 if request.get?
                   @issue.project ||= @issue.allowed_target_projects.first
                 end
                 @issue.author ||= User.current
                 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
                 attrs = (params[:issue] || {}).deep_dup
                 if action_name == 'new' && params[:was_default_status] == attrs[:status_id]
                   attrs.delete(:status_id)
                 end
                 if action_name == 'new' && params[:form_update_triggered_by] == 'issue_project_id'
                   # Discard submitted version when changing the project on the issue form
                   # so we can use the default version for the new project
                   attrs.delete(:fixed_version_id)
                 end
                 @issue.safe_attributes = attrs
                 if @issue.project
                   @issue.tracker ||= @issue.project.trackers.first
                   if @issue.tracker.nil?
                     render_error l(:error_no_tracker_in_project)
                     return false
                   end
                   if @issue.status.nil?
                     render_error l(:error_no_default_issue_status)
                     return false
                   end
                 end
                 @priorities = IssuePriority.active
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
               end
               def parse_params_for_bulk_issue_attributes(params)
                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                 if custom = attributes[:custom_field_values]
                   custom.reject! {|k,v| v.blank?}
                   custom.keys.each do |k|
                     if custom[k].is_a?(Array)
                       custom[k] << '' if custom[k].delete('__none__')
                     else
                       custom[k] = '' if custom[k] == '__none__'
                     end
                   end
                 end
                 attributes
               end
               # Saves @issue and a time_entry from the parameters
               def save_issue_with_child_records
                 Issue.transaction do
                   if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, @issue.project)
                     time_entry = @time_entry || TimeEntry.new
                     time_entry.project = @issue.project
                     time_entry.issue = @issue
                     time_entry.user = User.current
                     time_entry.spent_on = User.current.today
                     time_entry.attributes = params[:time_entry]
                     @issue.time_entries << time_entry
                   end
                   call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
                   if @issue.save
                     call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => time_entry, :journal => @issue.current_journal})
                   else
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               # Returns true if the issue copy should be linked
               # to the original issue
               def link_copy?(param)
                 case Setting.link_copied_issue
                 when 'yes'
                   true
                 when 'no'
                   false
                 when 'ask'
                   param == '1'
                 end
               end
               # Redirects user after a successful issue creation
               def redirect_after_create
                 if params[:continue]
                   attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
                   if params[:project_id]
                     redirect_to new_project_issue_path(@issue.project, :issue => attrs)
                   else
                     attrs.merge! :project_id => @issue.project_id
                     redirect_to new_issue_path(:issue => attrs)
                   end
                 else
                   redirect_to issue_path(@issue)
                 end
               end
             end

app/views/issues/index.html.erb +10 -4

             <div class="contextual">
-            <% if !@query.new_record? && @query.editable_by?(User.current) %>
+              <% if @project && User.current.allowed_to?(:add_issues, @project) && @project.trackers.any? %>
-              <%= link_to l(:button_edit), edit_query_path(@query), :class => 'icon icon-edit' %>
+                <%= link_to l(:label_issue_new), new_project_issue_path(@project), :class => 'icon icon-add new-issue' %>
-              <%= delete_link query_path(@query) %>
               <% end %>
             </div>
             <h2><%= @query.new_record? ? l(:label_issue_plural) : @query.name %></h2>
             <% html_title(@query.new_record? ? l(:label_issue_plural) : @query.name) %>
             <%= form_tag({ :controller => 'issues', :action => 'index', :project_id => @project },
                         :method => :get, :id => 'query_form') do %>
               <div id="query_form_with_buttons" class="hide-when-print">
                 <%= hidden_field_tag 'set_filter', '1' %>
                 <div id="query_form_content">
                 <fieldset id="filters" class="collapsible <%= @query.new_record? ? "" : "collapsed" %>">
                   <legend onclick="toggleFieldset(this);"><%= l(:label_filter_plural) %></legend>
                   <div style="<%= @query.new_record? ? "" : "display: none;" %>">
                     <%= render :partial => 'queries/filters', :locals => {:query => @query} %>
                   </div>
                 </fieldset>
                 <fieldset id="options" class="collapsible collapsed">
                   <legend onclick="toggleFieldset(this);"><%= l(:label_options) %></legend>
                   <div style="display: none;">
                     <table>
                       <tr>
                         <td class="field"><%= l(:field_column_names) %></td>
                         <td><%= render_query_columns_selection(@query) %></td>
                       </tr>
                       <tr>
                         <td class="field"><label for='group_by'><%= l(:field_group_by) %></label></td>
                         <td><%= select_tag('group_by',
                                            options_for_select(
                                              [[]] + @query.groupable_columns.collect {|c| [c.caption, c.name.to_s]},
                                              @query.group_by)
                                    ) %></td>
                       </tr>
                       <tr>
                         <td class="field"><%= l(:button_show) %></td>
                         <td><%= available_block_columns_tags(@query) %></td>
                       </tr>
                       <tr>
                         <td><%= l(:label_total_plural) %></td>
                         <td><%= available_totalable_columns_tags(@query) %></td>
                       </tr>
                     </table>
                   </div>
                 </fieldset>
                 </div>
                 <p class="buttons">
                 <%= link_to_function l(:button_apply), '$("#query_form").submit()', :class => 'icon icon-checked' %>
                 <%= link_to l(:button_clear), { :set_filter => 1, :project_id => @project }, :class => 'icon icon-reload'  %>
-                <% if @query.new_record? && User.current.allowed_to?(:save_queries, @project, :global => true) %>
+                <% if @query.new_record? %>
+                  <% if User.current.allowed_to?(:save_queries, @project, :global => true) %>
                     <%= link_to_function l(:button_save),
                                          "$('#query_form').attr('action', '#{ @project ? new_project_query_path(@project) : new_query_path }').submit()",
                                          :class => 'icon icon-save' %>
                   <% end %>
+                <% else %>
+                  <% if @query.editable_by?(User.current) %>
+                    <%= link_to l(:button_edit), edit_query_path(@query), :class => 'icon icon-edit' %>
+                    <%= delete_link query_path(@query) %>
+                  <% end %>
+                <% end %>
                 </p>
               </div>
             <% end %>
             <%= error_messages_for 'query' %>
             <% if @query.valid? %>
             <% if @issues.empty? %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% else %>
             <%= render_query_totals(@query) %>
             <%= render :partial => 'issues/list', :locals => {:issues => @issues, :query => @query} %>
             <span class="pagination"><%= pagination_links_full @issue_pages, @issue_count %></span>
             <% end %>
             <% other_formats_links do |f| %>
               <%= f.link_to 'Atom', :url => params.merge(:key => User.current.rss_key) %>
               <%= f.link_to 'CSV', :url => params, :onclick => "showModal('csv-export-options', '350px'); return false;" %>
               <%= f.link_to 'PDF', :url => params %>
             <% end %>
             <div id="csv-export-options" style="display:none;">
               <h3 class="title"><%= l(:label_export_options, :export_format => 'CSV') %></h3>
               <%= form_tag(_project_issues_path(@project, :format => 'csv'), :method => :get, :id => 'csv-export-form') do %>
               <%= query_as_hidden_field_tags(@query) %>
               <%= hidden_field_tag 'sort', @sort_criteria.to_param, :id => nil %>
               <p>
                 <label><%= radio_button_tag 'csv[columns]', '', true %> <%= l(:description_selected_columns) %></label><br />
                 <label><%= radio_button_tag 'csv[columns]', 'all' %> <%= l(:description_all_columns) %></label>
               </p>
               <p>
                 <label><%= check_box_tag 'csv[description]', '1', @query.has_column?(:description) %> <%= l(:field_description) %></label>
               </p>
               <% if @issue_count > Setting.issues_export_limit.to_i %>
               <p class="icon icon-warning">
                 <%= l(:setting_issues_export_limit) %>: <%= Setting.issues_export_limit.to_i %>
               </p>
               <% end %>
               <p class="buttons">
                 <%= submit_tag l(:button_export), :name => nil, :onclick => "hideModal(this);" %>
                 <%= submit_tag l(:button_cancel), :name => nil, :onclick => "hideModal(this);", :type => 'button' %>
               </p>
               <% end %>
             </div>
             <% end %>
             <%= call_hook(:view_issues_index_bottom, { :issues => @issues, :project => @project, :query => @query }) %>
             <% content_for :sidebar do %>
                 <%= render :partial => 'issues/sidebar' %>
             <% end %>
             <% content_for :header_tags do %>
                 <%= auto_discovery_link_tag(:atom,
                                             {:query_id => @query, :format => 'atom',
                                              :page => nil, :key => User.current.rss_key},
                                             :title => l(:label_issue_plural)) %>
                 <%= auto_discovery_link_tag(:atom,
                                             {:controller => 'journals', :action => 'index',
                                              :query_id => @query, :format => 'atom',
                                              :page => nil, :key => User.current.rss_key},
                                             :title => l(:label_changes_details)) %>
             <% end %>
             <%= context_menu issues_context_menu_path %>

lib/redmine.rb 0 -4

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'redmine/core_ext'
             begin
               require 'rmagick' unless Object.const_defined?(:Magick)
             rescue LoadError
               # RMagick is not available
             end
             begin
               require 'redcarpet' unless Object.const_defined?(:Redcarpet)
             rescue LoadError
               # Redcarpet is not available
             end
             require 'redmine/acts/positioned'
             require 'redmine/scm/base'
             require 'redmine/access_control'
             require 'redmine/access_keys'
             require 'redmine/activity'
             require 'redmine/activity/fetcher'
             require 'redmine/ciphering'
             require 'redmine/codeset_util'
             require 'redmine/field_format'
             require 'redmine/menu_manager'
             require 'redmine/notifiable'
             require 'redmine/platform'
             require 'redmine/mime_type'
             require 'redmine/notifiable'
             require 'redmine/search'
             require 'redmine/syntax_highlighting'
             require 'redmine/thumbnail'
             require 'redmine/unified_diff'
             require 'redmine/utils'
             require 'redmine/version'
             require 'redmine/wiki_formatting'
             require 'redmine/default_data/loader'
             require 'redmine/helpers/calendar'
             require 'redmine/helpers/diff'
             require 'redmine/helpers/gantt'
             require 'redmine/helpers/time_report'
             require 'redmine/views/other_formats_builder'
             require 'redmine/views/labelled_form_builder'
             require 'redmine/views/builders'
             require 'redmine/themes'
             require 'redmine/hook'
             require 'redmine/hook/listener'
             require 'redmine/hook/view_listener'
             require 'redmine/plugin'
             Redmine::Scm::Base.add "Subversion"
             Redmine::Scm::Base.add "Darcs"
             Redmine::Scm::Base.add "Mercurial"
             Redmine::Scm::Base.add "Cvs"
             Redmine::Scm::Base.add "Bazaar"
             Redmine::Scm::Base.add "Git"
             Redmine::Scm::Base.add "Filesystem"
             # Permissions
             Redmine::AccessControl.map do |map|
               map.permission :view_project, {:projects => [:show], :activities => [:index]}, :public => true, :read => true
               map.permission :search_project, {:search => :index}, :public => true, :read => true
               map.permission :add_project, {:projects => [:new, :create]}, :require => :loggedin
               map.permission :edit_project, {:projects => [:settings, :edit, :update]}, :require => :member
               map.permission :close_project, {:projects => [:close, :reopen]}, :require => :member, :read => true
               map.permission :select_project_modules, {:projects => :modules}, :require => :member
               map.permission :view_members, {:members => [:index, :show]}, :public => true, :read => true
               map.permission :manage_members, {:projects => :settings, :members => [:index, :show, :new, :create, :update, :destroy, :autocomplete]}, :require => :member
               map.permission :manage_versions, {:projects => :settings, :versions => [:new, :create, :edit, :update, :close_completed, :destroy]}, :require => :member
               map.permission :add_subprojects, {:projects => [:new, :create]}, :require => :member
               map.project_module :issue_tracking do |map|
                 # Issue categories
                 map.permission :manage_categories, {:projects => :settings, :issue_categories => [:index, :show, :new, :create, :edit, :update, :destroy]}, :require => :member
                 # Issues
                 map.permission :view_issues, {:issues => [:index, :show],
                                               :auto_complete => [:issues],
                                               :context_menus => [:issues],
                                               :versions => [:index, :show, :status_by],
                                               :journals => [:index, :diff],
                                               :queries => :index,
                                               :reports => [:issue_report, :issue_report_details]},
                                               :read => true
                 map.permission :add_issues, {:issues => [:new, :create], :attachments => :upload}
                 map.permission :edit_issues, {:issues => [:edit, :update, :bulk_edit, :bulk_update], :journals => [:new], :attachments => :upload}
                 map.permission :copy_issues, {:issues => [:new, :create, :bulk_edit, :bulk_update], :attachments => :upload}
                 map.permission :manage_issue_relations, {:issue_relations => [:index, :show, :create, :destroy]}
                 map.permission :manage_subtasks, {}
                 map.permission :set_issues_private, {}
                 map.permission :set_own_issues_private, {}, :require => :loggedin
                 map.permission :add_issue_notes, {:issues => [:edit, :update], :journals => [:new], :attachments => :upload}
                 map.permission :edit_issue_notes, {:journals => [:edit, :update]}, :require => :loggedin
                 map.permission :edit_own_issue_notes, {:journals => [:edit, :update]}, :require => :loggedin
                 map.permission :view_private_notes, {}, :read => true, :require => :member
                 map.permission :set_notes_private, {}, :require => :member
                 map.permission :delete_issues, {:issues => :destroy}, :require => :member
                 # Queries
                 map.permission :manage_public_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :member
                 map.permission :save_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :loggedin
                 # Watchers
                 map.permission :view_issue_watchers, {}, :read => true
                 map.permission :add_issue_watchers, {:watchers => [:new, :create, :append, :autocomplete_for_user]}
                 map.permission :delete_issue_watchers, {:watchers => :destroy}
                 map.permission :import_issues, {:imports => [:new, :create, :settings, :mapping, :run, :show]}
               end
               map.project_module :time_tracking do |map|
                 map.permission :log_time, {:timelog => [:new, :create]}, :require => :loggedin
                 map.permission :view_time_entries, {:timelog => [:index, :report, :show]}, :read => true
                 map.permission :edit_time_entries, {:timelog => [:edit, :update, :destroy, :bulk_edit, :bulk_update]}, :require => :member
                 map.permission :edit_own_time_entries, {:timelog => [:edit, :update, :destroy,:bulk_edit, :bulk_update]}, :require => :loggedin
                 map.permission :manage_project_activities, {:project_enumerations => [:update, :destroy]}, :require => :member
               end
               map.project_module :news do |map|
                 map.permission :manage_news, {:news => [:new, :create, :edit, :update, :destroy], :comments => [:destroy], :attachments => :upload}, :require => :member
                 map.permission :view_news, {:news => [:index, :show]}, :public => true, :read => true
                 map.permission :comment_news, {:comments => :create}
               end
               map.project_module :documents do |map|
                 map.permission :add_documents, {:documents => [:new, :create, :add_attachment], :attachments => :upload}, :require => :loggedin
                 map.permission :edit_documents, {:documents => [:edit, :update, :add_attachment], :attachments => :upload}, :require => :loggedin
                 map.permission :delete_documents, {:documents => [:destroy]}, :require => :loggedin
                 map.permission :view_documents, {:documents => [:index, :show, :download]}, :read => true
               end
               map.project_module :files do |map|
                 map.permission :manage_files, {:files => [:new, :create], :attachments => :upload}, :require => :loggedin
                 map.permission :view_files, {:files => :index, :versions => :download}, :read => true
               end
               map.project_module :wiki do |map|
                 map.permission :manage_wiki, {:wikis => [:edit, :destroy]}, :require => :member
                 map.permission :rename_wiki_pages, {:wiki => :rename}, :require => :member
                 map.permission :delete_wiki_pages, {:wiki => [:destroy, :destroy_version]}, :require => :member
                 map.permission :view_wiki_pages, {:wiki => [:index, :show, :special, :date_index]}, :read => true
                 map.permission :export_wiki_pages, {:wiki => [:export]}, :read => true
                 map.permission :view_wiki_edits, {:wiki => [:history, :diff, :annotate]}, :read => true
                 map.permission :edit_wiki_pages, :wiki => [:edit, :update, :preview, :add_attachment], :attachments => :upload
                 map.permission :delete_wiki_pages_attachments, {}
                 map.permission :protect_wiki_pages, {:wiki => :protect}, :require => :member
               end
               map.project_module :repository do |map|
                 map.permission :manage_repository, {:repositories => [:new, :create, :edit, :update, :committers, :destroy]}, :require => :member
                 map.permission :browse_repository, {:repositories => [:show, :browse, :entry, :raw, :annotate, :changes, :diff, :stats, :graph]}, :read => true
                 map.permission :view_changesets, {:repositories => [:show, :revisions, :revision]}, :read => true
                 map.permission :commit_access, {}
                 map.permission :manage_related_issues, {:repositories => [:add_related_issue, :remove_related_issue]}
               end
               map.project_module :boards do |map|
                 map.permission :manage_boards, {:boards => [:new, :create, :edit, :update, :destroy]}, :require => :member
                 map.permission :view_messages, {:boards => [:index, :show], :messages => [:show]}, :public => true, :read => true
                 map.permission :add_messages, {:messages => [:new, :reply, :quote], :attachments => :upload}
                 map.permission :edit_messages, {:messages => :edit, :attachments => :upload}, :require => :member
                 map.permission :edit_own_messages, {:messages => :edit, :attachments => :upload}, :require => :loggedin
                 map.permission :delete_messages, {:messages => :destroy}, :require => :member
                 map.permission :delete_own_messages, {:messages => :destroy}, :require => :loggedin
               end
               map.project_module :calendar do |map|
                 map.permission :view_calendar, {:calendars => [:show, :update]}, :read => true
               end
               map.project_module :gantt do |map|
                 map.permission :view_gantt, {:gantts => [:show, :update]}, :read => true
               end
             end
             Redmine::MenuManager.map :top_menu do |menu|
               menu.push :home, :home_path
               menu.push :my_page, { :controller => 'my', :action => 'page' }, :if => Proc.new { User.current.logged? }
               menu.push :projects, { :controller => 'projects', :action => 'index' }, :caption => :label_project_plural
               menu.push :administration, { :controller => 'admin', :action => 'index' }, :if => Proc.new { User.current.admin? }, :last => true
               menu.push :help, Redmine::Info.help_url, :last => true
             end
             Redmine::MenuManager.map :account_menu do |menu|
               menu.push :login, :signin_path, :if => Proc.new { !User.current.logged? }
               menu.push :register, :register_path, :if => Proc.new { !User.current.logged? && Setting.self_registration? }
               menu.push :my_account, { :controller => 'my', :action => 'account' }, :if => Proc.new { User.current.logged? }
               menu.push :logout, :signout_path, :html => {:method => 'post'}, :if => Proc.new { User.current.logged? }
             end
             Redmine::MenuManager.map :application_menu do |menu|
               # Empty
             end
             Redmine::MenuManager.map :admin_menu do |menu|
               menu.push :projects, {:controller => 'admin', :action => 'projects'}, :caption => :label_project_plural
               menu.push :users, {:controller => 'users'}, :caption => :label_user_plural
               menu.push :groups, {:controller => 'groups'}, :caption => :label_group_plural
               menu.push :roles, {:controller => 'roles'}, :caption => :label_role_and_permissions
               menu.push :trackers, {:controller => 'trackers'}, :caption => :label_tracker_plural
               menu.push :issue_statuses, {:controller => 'issue_statuses'}, :caption => :label_issue_status_plural,
                         :html => {:class => 'issue_statuses'}
               menu.push :workflows, {:controller => 'workflows', :action => 'edit'}, :caption => :label_workflow
               menu.push :custom_fields, {:controller => 'custom_fields'},  :caption => :label_custom_field_plural,
                         :html => {:class => 'custom_fields'}
               menu.push :enumerations, {:controller => 'enumerations'}
               menu.push :settings, {:controller => 'settings'}
               menu.push :ldap_authentication, {:controller => 'auth_sources', :action => 'index'},
                         :html => {:class => 'server_authentication'}
               menu.push :plugins, {:controller => 'admin', :action => 'plugins'}, :last => true
               menu.push :info, {:controller => 'admin', :action => 'info'}, :caption => :label_information_plural, :last => true
             end
             Redmine::MenuManager.map :project_menu do |menu|
               menu.push :overview, { :controller => 'projects', :action => 'show' }
               menu.push :activity, { :controller => 'activities', :action => 'index' }
               menu.push :roadmap, { :controller => 'versions', :action => 'index' }, :param => :project_id,
                           :if => Proc.new { |p| p.shared_versions.any? }
               menu.push :issues, { :controller => 'issues', :action => 'index' }, :param => :project_id, :caption => :label_issue_plural
-              menu.push :new_issue, { :controller => 'issues', :action => 'new', :copy_from => nil }, :param => :project_id, :caption => :label_issue_new,
-                          :html => { :accesskey => Redmine::AccessKeys.key_for(:new_issue) },
-                          :if => Proc.new { |p| p.trackers.any? },
-                          :permission => :add_issues
               menu.push :gantt, { :controller => 'gantts', :action => 'show' }, :param => :project_id, :caption => :label_gantt
               menu.push :calendar, { :controller => 'calendars', :action => 'show' }, :param => :project_id, :caption => :label_calendar
               menu.push :news, { :controller => 'news', :action => 'index' }, :param => :project_id, :caption => :label_news_plural
               menu.push :documents, { :controller => 'documents', :action => 'index' }, :param => :project_id, :caption => :label_document_plural
               menu.push :wiki, { :controller => 'wiki', :action => 'show', :id => nil }, :param => :project_id,
                           :if => Proc.new { |p| p.wiki && !p.wiki.new_record? }
               menu.push :boards, { :controller => 'boards', :action => 'index', :id => nil }, :param => :project_id,
                           :if => Proc.new { |p| p.boards.any? }, :caption => :label_board_plural
               menu.push :files, { :controller => 'files', :action => 'index' }, :caption => :label_file_plural, :param => :project_id
               menu.push :repository, { :controller => 'repositories', :action => 'show', :repository_id => nil, :path => nil, :rev => nil },
                           :if => Proc.new { |p| p.repository && !p.repository.new_record? }
               menu.push :settings, { :controller => 'projects', :action => 'settings' }, :last => true
             end
             Redmine::Activity.map do |activity|
               activity.register :issues, :class_name => %w(Issue Journal)
               activity.register :changesets
               activity.register :news
               activity.register :documents, :class_name => %w(Document Attachment)
               activity.register :files, :class_name => 'Attachment'
               activity.register :wiki_edits, :class_name => 'WikiContent::Version', :default => false
               activity.register :messages, :default => false
               activity.register :time_entries, :default => false
             end
             Redmine::Search.map do |search|
               search.register :issues
               search.register :news
               search.register :documents
               search.register :changesets
               search.register :wiki_pages
               search.register :messages
               search.register :projects
             end
             Redmine::WikiFormatting.map do |format|
               format.register :textile
               format.register :markdown if Object.const_defined?(:Redcarpet)
             end
             ActionView::Template.register_template_handler :rsb, Redmine::Views::ApiTemplateHandler

test/functional/issues_controller_test.rb 0 0

	1	NO CONTENT: modified file			NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff

test/functional/projects_controller_test.rb 0 -24

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class ProjectsControllerTest < ActionController::TestCase
               fixtures :projects, :versions, :users, :email_addresses, :roles, :members,
                        :member_roles, :issues, :journals, :journal_details,
                        :trackers, :projects_trackers, :issue_statuses,
                        :enabled_modules, :enumerations, :boards, :messages,
                        :attachments, :custom_fields, :custom_values, :time_entries,
                        :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions
               def setup
                 @request.session[:user_id] = nil
                 Setting.default_language = 'en'
               end
               def test_index_by_anonymous_should_not_show_private_projects
                 get :index
                 assert_response :success
                 assert_template 'index'
                 projects = assigns(:projects)
                 assert_not_nil projects
                 assert projects.all?(&:is_public?)
                 assert_select 'ul' do
                   assert_select 'li' do
                     assert_select 'a', :text => 'eCookbook'
                     assert_select 'ul' do
                       assert_select 'a', :text => 'Child of private child'
                     end
                   end
                 end
                 assert_select 'a', :text => /Private child of eCookbook/, :count => 0
               end
               def test_index_atom
                 get :index, :format => 'atom'
                 assert_response :success
                 assert_template 'common/feed'
                 assert_select 'feed>title', :text => 'Redmine: Latest projects'
                 assert_select 'feed>entry', :count => Project.visible(User.current).count
               end
               test "#index by non-admin user with view_time_entries permission should show overall spent time link" do
                 @request.session[:user_id] = 3
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/time_entries'
               end
               test "#index by non-admin user without view_time_entries permission should not show overall spent time link" do
                 Role.find(2).remove_permission! :view_time_entries
                 Role.non_member.remove_permission! :view_time_entries
                 Role.anonymous.remove_permission! :view_time_entries
                 @request.session[:user_id] = 3
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/time_entries', 0
               end
               test "#index by non-admin user with permission should show add project link" do
                 Role.find(1).add_permission! :add_project
                 @request.session[:user_id] = 2
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/projects/new'
               end
               test "#new by admin user should accept get" do
                 @request.session[:user_id] = 1
                 get :new
                 assert_response :success
                 assert_template 'new'
               end
               test "#new by non-admin user with add_project permission should accept get" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 get :new
                 assert_response :success
                 assert_template 'new'
                 assert_select 'select[name=?]', 'project[parent_id]', 0
               end
               test "#new by non-admin user with add_subprojects permission should accept get" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 get :new, :parent_id => 'ecookbook'
                 assert_response :success
                 assert_template 'new'
                 assert_select 'select[name=?]', 'project[parent_id]' do
                   # parent project selected
                   assert_select 'option[value="1"][selected=selected]'
                   # no empty value
                   assert_select 'option[value=""]', 0
                 end
               end
               def test_new_should_not_display_invalid_search_link
                 @request.session[:user_id] = 1
                 get :new
                 assert_response :success
                 assert_select '#quick-search form[action=?]', '/search'
                 assert_select '#quick-search a[href=?]', '/search'
               end
               test "#create by admin user should create a new project" do
                 @request.session[:user_id] = 1
                 post :create,
                   :project => {
                     :name => "blog",
                     :description => "weblog",
                     :homepage => 'http://weblog',
                     :identifier => "blog",
                     :is_public => 1,
                     :custom_field_values => { '3' => 'Beta' },
                     :tracker_ids => ['1', '3'],
                     # an issue custom field that is not for all project
                     :issue_custom_field_ids => ['9'],
                     :enabled_module_names => ['issue_tracking', 'news', 'repository']
                   }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert project.active?
                 assert_equal 'weblog', project.description
                 assert_equal 'http://weblog', project.homepage
                 assert_equal true, project.is_public?
                 assert_nil project.parent
                 assert_equal 'Beta', project.custom_value_for(3).value
                 assert_equal [1, 3], project.trackers.map(&:id).sort
                 assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                 assert project.issue_custom_fields.include?(IssueCustomField.find(9))
               end
               test "#create by admin user should create a new subproject" do
                 @request.session[:user_id] = 1
                 assert_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 1
                                           }
                   assert_redirected_to '/projects/blog/settings'
                 end
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert_equal Project.find(1), project.parent
               end
               test "#create by admin user should continue" do
                 @request.session[:user_id] = 1
                 assert_difference 'Project.count' do
                   post :create, :project => {:name => "blog", :identifier => "blog"}, :continue => 'Create and continue'
                 end
                 assert_redirected_to '/projects/new'
               end
               test "#create by non-admin user with add_project permission should create a new project" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 post :create, :project => { :name => "blog",
                                          :description => "weblog",
                                          :identifier => "blog",
                                          :is_public => 1,
                                          :custom_field_values => { '3' => 'Beta' },
                                          :tracker_ids => ['1', '3'],
                                          :enabled_module_names => ['issue_tracking', 'news', 'repository']
                                         }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert_equal 'weblog', project.description
                 assert_equal true, project.is_public?
                 assert_equal [1, 3], project.trackers.map(&:id).sort
                 assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                 # User should be added as a project member
                 assert User.find(9).member_of?(project)
                 assert_equal 1, project.members.size
               end
               test "#create by non-admin user with add_project permission should fail with parent_id" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 1
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 post :create, :project => { :name => "blog",
                                          :description => "weblog",
                                          :identifier => "blog",
                                          :is_public => 1,
                                          :custom_field_values => { '3' => 'Beta' },
                                          :parent_id => 1
                                         }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
               end
               test "#create by non-admin user with add_subprojects permission should fail without parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' }
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 assert !User.find(2).member_of?(Project.find(6))
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 6
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               def test_create_subproject_with_inherit_members_should_inherit_members
                 Role.find_by_name('Manager').add_permission! :add_subprojects
                 parent = Project.find(1)
                 @request.session[:user_id] = 2
                 assert_difference 'Project.count' do
                   post :create, :project => {
                     :name => 'inherited', :identifier => 'inherited', :parent_id => parent.id, :inherit_members => '1'
                   }
                   assert_response 302
                 end
                 project = Project.order('id desc').first
                 assert_equal 'inherited', project.name
                 assert_equal parent, project.parent
                 assert project.memberships.count > 0
                 assert_equal parent.memberships.count, project.memberships.count
               end
               def test_create_should_preserve_modules_on_validation_failure
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   @request.session[:user_id] = 1
                   assert_no_difference 'Project.count' do
                     post :create, :project => {
                       :name => "blog",
                       :identifier => "",
                       :enabled_module_names => %w(issue_tracking news)
                     }
                   end
                   assert_response :success
                   project = assigns(:project)
                   assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                 end
               end
               def test_show_by_id
                 get :show, :id => 1
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
               end
               def test_show_by_identifier
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                 assert_select 'li', :text => /Development status/
               end
               def test_show_should_not_display_empty_sidebar
                 p = Project.find(1)
                 p.enabled_module_names = []
                 p.save!
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_select '#main.nosidebar'
               end
               def test_show_should_not_display_hidden_custom_fields
                 ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_select 'li', :text => /Development status/, :count => 0
               end
               def test_show_should_not_display_blank_custom_fields_with_multiple_values
                 f1 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Foo Bar), :multiple => true
                 f2 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Baz Qux), :multiple => true
                 project = Project.generate!(:custom_field_values => {f2.id.to_s => %w(Qux)})
                 get :show, :id => project.id
                 assert_response :success
                 assert_select 'li', :text => /#{f1.name}/, :count => 0
                 assert_select 'li', :text => /#{f2.name}/
               end
               def test_show_should_not_display_blank_text_custom_fields
                 f1 = ProjectCustomField.generate! :field_format => 'text'
                 get :show, :id => 1
                 assert_response :success
                 assert_select 'li', :text => /#{f1.name}/, :count => 0
               end
               def test_show_should_not_fail_when_custom_values_are_nil
                 project = Project.find_by_identifier('ecookbook')
                 project.custom_values.first.update_attribute(:value, nil)
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
               end
               def show_archived_project_should_be_denied
                 project = Project.find_by_identifier('ecookbook')
                 project.archive!
                 get :show, :id => 'ecookbook'
                 assert_response 403
                 assert_nil assigns(:project)
                 assert_select 'p', :text => /archived/
               end
               def test_show_should_not_show_private_subprojects_that_are_not_visible
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_select 'a', :text => /Private child/, :count => 0
               end
               def test_show_should_show_private_subprojects_that_are_visible
                 @request.session[:user_id] = 2 # manager who is a member of the private subproject
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_select 'a', :text => /Private child/
               end
               def test_settings
                 @request.session[:user_id] = 2 # manager
                 get :settings, :id => 1
                 assert_response :success
                 assert_template 'settings'
               end
               def test_settings_of_subproject
                 @request.session[:user_id] = 2
                 get :settings, :id => 'private-child'
                 assert_response :success
                 assert_template 'settings'
                 assert_select 'input[type=checkbox][name=?]', 'project[inherit_members]'
               end
               def test_settings_should_be_denied_for_member_on_closed_project
                 Project.find(1).close
                 @request.session[:user_id] = 2 # manager
                 get :settings, :id => 1
                 assert_response 403
               end
               def test_settings_should_be_denied_for_anonymous_on_closed_project
                 Project.find(1).close
                 get :settings, :id => 1
                 assert_response 302
               end
               def test_setting_with_wiki_module_and_no_wiki
                 Project.find(1).wiki.destroy
                 Role.find(1).add_permission! :manage_wiki
                 @request.session[:user_id] = 2
                 get :settings, :id => 1
                 assert_response :success
                 assert_template 'settings'
                 assert_select 'form[action=?]', '/projects/ecookbook/wiki' do
                   assert_select 'input[name=?]', 'wiki[start_page]'
                 end
               end
               def test_update
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => 'Test changed name',
                                                    :issue_custom_field_ids => ['']}
                 assert_redirected_to '/projects/ecookbook/settings'
                 project = Project.find(1)
                 assert_equal 'Test changed name', project.name
               end
               def test_update_with_failure
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => ''}
                 assert_response :success
                 assert_template 'settings'
                 assert_select_error /name cannot be blank/i
               end
               def test_update_should_be_denied_for_member_on_closed_project
                 Project.find(1).close
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => 'Closed'}
                 assert_response 403
                 assert_equal 'eCookbook', Project.find(1).name
               end
               def test_update_should_be_denied_for_anonymous_on_closed_project
                 Project.find(1).close
                 post :update, :id => 1, :project => {:name => 'Closed'}
                 assert_response 302
                 assert_equal 'eCookbook', Project.find(1).name
               end
               def test_update_child_project_without_parent_permission_should_not_show_validation_error
                 child = Project.generate_with_parent!
                 user = User.generate!
                 User.add_to_project(user, child, Role.generate!(:permissions => [:edit_project]))
                 @request.session[:user_id] = user.id
                 post :update, :id => child.id, :project => {:name => 'Updated'}
                 assert_response 302
                 assert_match /Successful update/, flash[:notice]
               end
               def test_modules
                 @request.session[:user_id] = 2
                 Project.find(1).enabled_module_names = ['issue_tracking', 'news']
                 post :modules, :id => 1, :enabled_module_names => ['issue_tracking', 'repository', 'documents']
                 assert_redirected_to '/projects/ecookbook/settings/modules'
                 assert_equal ['documents', 'issue_tracking', 'repository'], Project.find(1).enabled_module_names.sort
               end
               def test_destroy_leaf_project_without_confirmation_should_show_confirmation
                 @request.session[:user_id] = 1 # admin
                 assert_no_difference 'Project.count' do
                   delete :destroy, :id => 2
                   assert_response :success
                   assert_template 'destroy'
                 end
               end
               def test_destroy_without_confirmation_should_show_confirmation_with_subprojects
                 @request.session[:user_id] = 1 # admin
                 assert_no_difference 'Project.count' do
                   delete :destroy, :id => 1
                   assert_response :success
                   assert_template 'destroy'
                 end
                 assert_select 'strong',
                               :text => ['Private child of eCookbook',
                                         'Child of private child, eCookbook Subproject 1',
                                         'eCookbook Subproject 2'].join(', ')
               end
               def test_destroy_with_confirmation_should_destroy_the_project_and_subprojects
                 @request.session[:user_id] = 1 # admin
                 assert_difference 'Project.count', -5 do
                   delete :destroy, :id => 1, :confirm => 1
                   assert_redirected_to '/admin/projects'
                 end
                 assert_nil Project.find_by_id(1)
               end
               def test_archive
                 @request.session[:user_id] = 1 # admin
                 post :archive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert !Project.find(1).active?
               end
               def test_archive_with_failure
                 @request.session[:user_id] = 1
                 Project.any_instance.stubs(:archive).returns(false)
                 post :archive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert_match /project cannot be archived/i, flash[:error]
               end
               def test_unarchive
                 @request.session[:user_id] = 1 # admin
                 Project.find(1).archive
                 post :unarchive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert Project.find(1).active?
               end
               def test_close
                 @request.session[:user_id] = 2
                 post :close, :id => 1
                 assert_redirected_to '/projects/ecookbook'
                 assert_equal Project::STATUS_CLOSED, Project.find(1).status
               end
               def test_reopen
                 Project.find(1).close
                 @request.session[:user_id] = 2
                 post :reopen, :id => 1
                 assert_redirected_to '/projects/ecookbook'
                 assert Project.find(1).active?
               end
               def test_project_breadcrumbs_should_be_limited_to_3_ancestors
                 CustomField.delete_all
                 parent = nil
 .times do |i|
                   p = Project.generate_with_parent!(parent)
                   get :show, :id => p
                   assert_select '#header h1' do
                     assert_select 'a', :count => [i, 3].min
                   end
                   parent = p
                 end
               end
               def test_get_copy
                 @request.session[:user_id] = 1 # admin
                 get :copy, :id => 1
                 assert_response :success
                 assert_template 'copy'
                 assert assigns(:project)
                 assert_equal Project.find(1).description, assigns(:project).description
                 assert_nil assigns(:project).id
                 assert_select 'input[name=?][value=?]', 'project[enabled_module_names][]', 'issue_tracking', 1
               end
               def test_get_copy_with_invalid_source_should_respond_with_404
                 @request.session[:user_id] = 1
                 get :copy, :id => 99
                 assert_response 404
               end
               def test_get_copy_should_preselect_custom_fields
                 field1 = IssueCustomField.generate!(:is_for_all => false)
                 field2 = IssueCustomField.generate!(:is_for_all => false)
                 source = Project.generate!(:issue_custom_fields => [field1])
                 @request.session[:user_id] = 1
                 get :copy, :id => source.id
                 assert_response :success
                 assert_select 'fieldset#project_issue_custom_fields' do
                   assert_select 'input[type=checkbox][value=?][checked=checked]', field1.id.to_s
                   assert_select 'input[type=checkbox][value=?]:not([checked])', field2.id.to_s
                 end
               end
               def test_post_copy_should_copy_requested_items
                 @request.session[:user_id] = 1 # admin
                 CustomField.delete_all
                 assert_difference 'Project.count' do
                   post :copy, :id => 1,
                     :project => {
                       :name => 'Copy',
                       :identifier => 'unique-copy',
                       :tracker_ids => ['1', '2', '3', ''],
                       :enabled_module_names => %w(issue_tracking time_tracking)
                     },
                     :only => %w(issues versions)
                 end
                 project = Project.find('unique-copy')
                 source = Project.find(1)
                 assert_equal %w(issue_tracking time_tracking), project.enabled_module_names.sort
                 assert_equal source.versions.count, project.versions.count, "All versions were not copied"
                 assert_equal source.issues.count, project.issues.count, "All issues were not copied"
                 assert_equal 0, project.members.count
               end
               def test_post_copy_should_redirect_to_settings_when_successful
                 @request.session[:user_id] = 1 # admin
                 post :copy, :id => 1, :project => {:name => 'Copy', :identifier => 'unique-copy'}
                 assert_response :redirect
                 assert_redirected_to :controller => 'projects', :action => 'settings', :id => 'unique-copy'
               end
               def test_post_copy_with_failure
                 @request.session[:user_id] = 1
                 post :copy, :id => 1, :project => {:name => 'Copy', :identifier => ''}
                 assert_response :success
                 assert_template 'copy'
               end
               def test_jump_should_redirect_to_active_tab
                 get :show, :id => 1, :jump => 'issues'
                 assert_redirected_to '/projects/ecookbook/issues'
               end
               def test_jump_should_not_redirect_to_inactive_tab
                 get :show, :id => 3, :jump => 'documents'
                 assert_response :success
                 assert_template 'show'
               end
               def test_jump_should_not_redirect_to_unknown_tab
                 get :show, :id => 3, :jump => 'foobar'
                 assert_response :success
                 assert_template 'show'
               end
               def test_body_should_have_project_css_class
                 get :show, :id => 1
                 assert_select 'body.project-ecookbook'
               end
-              def test_project_menu_should_include_new_issue_link
-                @request.session[:user_id] = 2
-                get :show, :id => 1
-                assert_select '#main-menu a.new-issue[href="/projects/ecookbook/issues/new"]', :text => 'New issue'
-              end
-              def test_project_menu_should_not_include_new_issue_link_for_project_without_trackers
-                Project.find(1).trackers.clear
-                @request.session[:user_id] = 2
-                get :show, :id => 1
-                assert_select '#main-menu a.new-issue', 0
-              end
-              def test_project_menu_should_not_include_new_issue_link_for_users_with_copy_issues_permission_only
-                role = Role.find(1)
-                role.remove_permission! :add_issues
-                role.add_permission! :copy_issues
-                @request.session[:user_id] = 2
-                get :show, :id => 1
-                assert_select '#main-menu a.new-issue', 0
-              end
             end

test/unit/lib/redmine_test.rb +1 -7

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             module RedmineMenuTestHelper
               # Assertions
               def assert_number_of_items_in_menu(menu_name, count)
                 assert Redmine::MenuManager.items(menu_name).size >= count, "Menu has less than #{count} items"
               end
               def assert_menu_contains_item_named(menu_name, item_name)
                 assert Redmine::MenuManager.items(menu_name).collect(&:name).include?(item_name.to_sym), "Menu did not have an item named #{item_name}"
               end
               # Helpers
               def get_menu_item(menu_name, item_name)
                 Redmine::MenuManager.items(menu_name).find {|item| item.name == item_name.to_sym}
               end
             end
             class RedmineTest < ActiveSupport::TestCase
               include RedmineMenuTestHelper
               def test_top_menu
                 assert_number_of_items_in_menu :top_menu, 5
                 assert_menu_contains_item_named :top_menu, :home
                 assert_menu_contains_item_named :top_menu, :my_page
                 assert_menu_contains_item_named :top_menu, :projects
                 assert_menu_contains_item_named :top_menu, :administration
                 assert_menu_contains_item_named :top_menu, :help
               end
               def test_account_menu
                 assert_number_of_items_in_menu :account_menu, 4
                 assert_menu_contains_item_named :account_menu, :login
                 assert_menu_contains_item_named :account_menu, :register
                 assert_menu_contains_item_named :account_menu, :my_account
                 assert_menu_contains_item_named :account_menu, :logout
               end
               def test_application_menu
                 assert_number_of_items_in_menu :application_menu, 0
               end
               def test_admin_menu
                 assert_number_of_items_in_menu :admin_menu, 0
               end
               def test_project_menu
-                assert_number_of_items_in_menu :project_menu, 14
+                assert_number_of_items_in_menu :project_menu, 13
                 assert_menu_contains_item_named :project_menu, :overview
                 assert_menu_contains_item_named :project_menu, :activity
                 assert_menu_contains_item_named :project_menu, :roadmap
                 assert_menu_contains_item_named :project_menu, :issues
-                assert_menu_contains_item_named :project_menu, :new_issue
                 assert_menu_contains_item_named :project_menu, :calendar
                 assert_menu_contains_item_named :project_menu, :gantt
                 assert_menu_contains_item_named :project_menu, :news
                 assert_menu_contains_item_named :project_menu, :documents
                 assert_menu_contains_item_named :project_menu, :wiki
                 assert_menu_contains_item_named :project_menu, :boards
                 assert_menu_contains_item_named :project_menu, :files
                 assert_menu_contains_item_named :project_menu, :repository
                 assert_menu_contains_item_named :project_menu, :settings
               end
-              def test_new_issue_should_have_root_as_a_parent
-                new_issue = get_menu_item(:project_menu, :new_issue)
-                assert_equal :root, new_issue.parent.name
-              end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages