##// END OF EJS Templates
code layout clean up issues helper...
Toshi MARUYAMA -
r7905:da140238e778
parent child
Show More
@@ -1,302 +1,304
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 module IssuesHelper
18 module IssuesHelper
19 include ApplicationHelper
19 include ApplicationHelper
20
20
21 def issue_list(issues, &block)
21 def issue_list(issues, &block)
22 ancestors = []
22 ancestors = []
23 issues.each do |issue|
23 issues.each do |issue|
24 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
24 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
25 ancestors.pop
25 ancestors.pop
26 end
26 end
27 yield issue, ancestors.size
27 yield issue, ancestors.size
28 ancestors << issue unless issue.leaf?
28 ancestors << issue unless issue.leaf?
29 end
29 end
30 end
30 end
31
31
32 # Renders a HTML/CSS tooltip
32 # Renders a HTML/CSS tooltip
33 #
33 #
34 # To use, a trigger div is needed. This is a div with the class of "tooltip"
34 # To use, a trigger div is needed. This is a div with the class of "tooltip"
35 # that contains this method wrapped in a span with the class of "tip"
35 # that contains this method wrapped in a span with the class of "tip"
36 #
36 #
37 # <div class="tooltip"><%= link_to_issue(issue) %>
37 # <div class="tooltip"><%= link_to_issue(issue) %>
38 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
38 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
39 # </div>
39 # </div>
40 #
40 #
41 def render_issue_tooltip(issue)
41 def render_issue_tooltip(issue)
42 @cached_label_status ||= l(:field_status)
42 @cached_label_status ||= l(:field_status)
43 @cached_label_start_date ||= l(:field_start_date)
43 @cached_label_start_date ||= l(:field_start_date)
44 @cached_label_due_date ||= l(:field_due_date)
44 @cached_label_due_date ||= l(:field_due_date)
45 @cached_label_assigned_to ||= l(:field_assigned_to)
45 @cached_label_assigned_to ||= l(:field_assigned_to)
46 @cached_label_priority ||= l(:field_priority)
46 @cached_label_priority ||= l(:field_priority)
47 @cached_label_project ||= l(:field_project)
47 @cached_label_project ||= l(:field_project)
48
48
49 (link_to_issue(issue) + "<br /><br />" +
49 (link_to_issue(issue) + "<br /><br />" +
50 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />" +
50 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />" +
51 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />" +
51 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />" +
52 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />" +
52 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />" +
53 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />" +
53 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />" +
54 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />" +
54 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />" +
55 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}").html_safe
55 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}").html_safe
56 end
56 end
57
57
58 def issue_heading(issue)
58 def issue_heading(issue)
59 h("#{issue.tracker} ##{issue.id}")
59 h("#{issue.tracker} ##{issue.id}")
60 end
60 end
61
61
62 def render_issue_subject_with_tree(issue)
62 def render_issue_subject_with_tree(issue)
63 s = ''
63 s = ''
64 ancestors = issue.root? ? [] : issue.ancestors.visible.all
64 ancestors = issue.root? ? [] : issue.ancestors.visible.all
65 ancestors.each do |ancestor|
65 ancestors.each do |ancestor|
66 s << '<div>' + content_tag('p', link_to_issue(ancestor))
66 s << '<div>' + content_tag('p', link_to_issue(ancestor))
67 end
67 end
68 s << '<div>'
68 s << '<div>'
69 subject = h(issue.subject)
69 subject = h(issue.subject)
70 if issue.is_private?
70 if issue.is_private?
71 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
71 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
72 end
72 end
73 s << content_tag('h3', subject)
73 s << content_tag('h3', subject)
74 s << '</div>' * (ancestors.size + 1)
74 s << '</div>' * (ancestors.size + 1)
75 s.html_safe
75 s.html_safe
76 end
76 end
77
77
78 def render_descendants_tree(issue)
78 def render_descendants_tree(issue)
79 s = '<form><table class="list issues">'
79 s = '<form><table class="list issues">'
80 issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
80 issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
81 s << content_tag('tr',
81 s << content_tag('tr',
82 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
82 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
83 content_tag('td', link_to_issue(child, :truncate => 60), :class => 'subject') +
83 content_tag('td', link_to_issue(child, :truncate => 60), :class => 'subject') +
84 content_tag('td', h(child.status)) +
84 content_tag('td', h(child.status)) +
85 content_tag('td', link_to_user(child.assigned_to)) +
85 content_tag('td', link_to_user(child.assigned_to)) +
86 content_tag('td', progress_bar(child.done_ratio, :width => '80px')),
86 content_tag('td', progress_bar(child.done_ratio, :width => '80px')),
87 :class => "issue issue-#{child.id} hascontextmenu #{level > 0 ? "idnt idnt-#{level}" : nil}")
87 :class => "issue issue-#{child.id} hascontextmenu #{level > 0 ? "idnt idnt-#{level}" : nil}")
88 end
88 end
89 s << '</form></table>'
89 s << '</form></table>'
90 s.html_safe
90 s.html_safe
91 end
91 end
92
92
93 def render_custom_fields_rows(issue)
93 def render_custom_fields_rows(issue)
94 return if issue.custom_field_values.empty?
94 return if issue.custom_field_values.empty?
95 ordered_values = []
95 ordered_values = []
96 half = (issue.custom_field_values.size / 2.0).ceil
96 half = (issue.custom_field_values.size / 2.0).ceil
97 half.times do |i|
97 half.times do |i|
98 ordered_values << issue.custom_field_values[i]
98 ordered_values << issue.custom_field_values[i]
99 ordered_values << issue.custom_field_values[i + half]
99 ordered_values << issue.custom_field_values[i + half]
100 end
100 end
101 s = "<tr>\n"
101 s = "<tr>\n"
102 n = 0
102 n = 0
103 ordered_values.compact.each do |value|
103 ordered_values.compact.each do |value|
104 s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
104 s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
105 s << "\t<th>#{ h(value.custom_field.name) }:</th><td>#{ simple_format_without_paragraph(h(show_value(value))) }</td>\n"
105 s << "\t<th>#{ h(value.custom_field.name) }:</th><td>#{ simple_format_without_paragraph(h(show_value(value))) }</td>\n"
106 n += 1
106 n += 1
107 end
107 end
108 s << "</tr>\n"
108 s << "</tr>\n"
109 s.html_safe
109 s.html_safe
110 end
110 end
111
111
112 def issues_destroy_confirmation_message(issues)
112 def issues_destroy_confirmation_message(issues)
113 issues = [issues] unless issues.is_a?(Array)
113 issues = [issues] unless issues.is_a?(Array)
114 message = l(:text_issues_destroy_confirmation)
114 message = l(:text_issues_destroy_confirmation)
115 descendant_count = issues.inject(0) {|memo, i| memo += (i.right - i.left - 1)/2}
115 descendant_count = issues.inject(0) {|memo, i| memo += (i.right - i.left - 1)/2}
116 if descendant_count > 0
116 if descendant_count > 0
117 issues.each do |issue|
117 issues.each do |issue|
118 next if issue.root?
118 next if issue.root?
119 issues.each do |other_issue|
119 issues.each do |other_issue|
120 descendant_count -= 1 if issue.is_descendant_of?(other_issue)
120 descendant_count -= 1 if issue.is_descendant_of?(other_issue)
121 end
121 end
122 end
122 end
123 if descendant_count > 0
123 if descendant_count > 0
124 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
124 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
125 end
125 end
126 end
126 end
127 message
127 message
128 end
128 end
129
129
130 def sidebar_queries
130 def sidebar_queries
131 unless @sidebar_queries
131 unless @sidebar_queries
132 # User can see public queries and his own queries
132 # User can see public queries and his own queries
133 visible = ARCondition.new(["is_public = ? OR user_id = ?", true, (User.current.logged? ? User.current.id : 0)])
133 visible = ARCondition.new(["is_public = ? OR user_id = ?", true, (User.current.logged? ? User.current.id : 0)])
134 # Project specific queries and global queries
134 # Project specific queries and global queries
135 visible << (@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id])
135 visible << (@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id])
136 @sidebar_queries = Query.find(:all,
136 @sidebar_queries = Query.find(:all,
137 :select => 'id, name, is_public',
137 :select => 'id, name, is_public',
138 :order => "name ASC",
138 :order => "name ASC",
139 :conditions => visible.conditions)
139 :conditions => visible.conditions)
140 end
140 end
141 @sidebar_queries
141 @sidebar_queries
142 end
142 end
143
143
144 def query_links(title, queries)
144 def query_links(title, queries)
145 # links to #index on issues/show
145 # links to #index on issues/show
146 url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
146 url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
147
147
148 content_tag('h3', h(title)) +
148 content_tag('h3', h(title)) +
149 queries.collect {|query|
149 queries.collect {|query|
150 link_to(h(query.name), url_params.merge(:query_id => query))
150 link_to(h(query.name), url_params.merge(:query_id => query))
151 }.join('<br />')
151 }.join('<br />')
152 end
152 end
153
153
154 def render_sidebar_queries
154 def render_sidebar_queries
155 out = ''
155 out = ''
156 queries = sidebar_queries.select {|q| !q.is_public?}
156 queries = sidebar_queries.select {|q| !q.is_public?}
157 out << query_links(l(:label_my_queries), queries) if queries.any?
157 out << query_links(l(:label_my_queries), queries) if queries.any?
158 queries = sidebar_queries.select {|q| q.is_public?}
158 queries = sidebar_queries.select {|q| q.is_public?}
159 out << query_links(l(:label_query_plural), queries) if queries.any?
159 out << query_links(l(:label_query_plural), queries) if queries.any?
160 out
160 out
161 end
161 end
162
162
163 def show_detail(detail, no_html=false)
163 def show_detail(detail, no_html=false)
164 case detail.property
164 case detail.property
165 when 'attr'
165 when 'attr'
166 field = detail.prop_key.to_s.gsub(/\_id$/, "")
166 field = detail.prop_key.to_s.gsub(/\_id$/, "")
167 label = l(("field_" + field).to_sym)
167 label = l(("field_" + field).to_sym)
168 case
168 case
169 when ['due_date', 'start_date'].include?(detail.prop_key)
169 when ['due_date', 'start_date'].include?(detail.prop_key)
170 value = format_date(detail.value.to_date) if detail.value
170 value = format_date(detail.value.to_date) if detail.value
171 old_value = format_date(detail.old_value.to_date) if detail.old_value
171 old_value = format_date(detail.old_value.to_date) if detail.old_value
172
172
173 when ['project_id', 'status_id', 'tracker_id', 'assigned_to_id', 'priority_id', 'category_id', 'fixed_version_id'].include?(detail.prop_key)
173 when ['project_id', 'status_id', 'tracker_id', 'assigned_to_id',
174 'priority_id', 'category_id', 'fixed_version_id'].include?(detail.prop_key)
174 value = find_name_by_reflection(field, detail.value)
175 value = find_name_by_reflection(field, detail.value)
175 old_value = find_name_by_reflection(field, detail.old_value)
176 old_value = find_name_by_reflection(field, detail.old_value)
176
177
177 when detail.prop_key == 'estimated_hours'
178 when detail.prop_key == 'estimated_hours'
178 value = "%0.02f" % detail.value.to_f unless detail.value.blank?
179 value = "%0.02f" % detail.value.to_f unless detail.value.blank?
179 old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
180 old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
180
181
181 when detail.prop_key == 'parent_id'
182 when detail.prop_key == 'parent_id'
182 label = l(:field_parent_issue)
183 label = l(:field_parent_issue)
183 value = "##{detail.value}" unless detail.value.blank?
184 value = "##{detail.value}" unless detail.value.blank?
184 old_value = "##{detail.old_value}" unless detail.old_value.blank?
185 old_value = "##{detail.old_value}" unless detail.old_value.blank?
185
186
186 when detail.prop_key == 'is_private'
187 when detail.prop_key == 'is_private'
187 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
188 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
188 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
189 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
189 end
190 end
190 when 'cf'
191 when 'cf'
191 custom_field = CustomField.find_by_id(detail.prop_key)
192 custom_field = CustomField.find_by_id(detail.prop_key)
192 if custom_field
193 if custom_field
193 label = custom_field.name
194 label = custom_field.name
194 value = format_value(detail.value, custom_field.field_format) if detail.value
195 value = format_value(detail.value, custom_field.field_format) if detail.value
195 old_value = format_value(detail.old_value, custom_field.field_format) if detail.old_value
196 old_value = format_value(detail.old_value, custom_field.field_format) if detail.old_value
196 end
197 end
197 when 'attachment'
198 when 'attachment'
198 label = l(:label_attachment)
199 label = l(:label_attachment)
199 end
200 end
200 call_hook(:helper_issues_show_detail_after_setting, {:detail => detail, :label => label, :value => value, :old_value => old_value })
201 call_hook(:helper_issues_show_detail_after_setting,
202 {:detail => detail, :label => label, :value => value, :old_value => old_value })
201
203
202 label ||= detail.prop_key
204 label ||= detail.prop_key
203 value ||= detail.value
205 value ||= detail.value
204 old_value ||= detail.old_value
206 old_value ||= detail.old_value
205
207
206 unless no_html
208 unless no_html
207 label = content_tag('strong', label)
209 label = content_tag('strong', label)
208 old_value = content_tag("i", h(old_value)) if detail.old_value
210 old_value = content_tag("i", h(old_value)) if detail.old_value
209 old_value = content_tag("strike", old_value) if detail.old_value and detail.value.blank?
211 old_value = content_tag("strike", old_value) if detail.old_value and detail.value.blank?
210 if detail.property == 'attachment' && !value.blank? && a = Attachment.find_by_id(detail.prop_key)
212 if detail.property == 'attachment' && !value.blank? && a = Attachment.find_by_id(detail.prop_key)
211 # Link to the attachment if it has not been removed
213 # Link to the attachment if it has not been removed
212 value = link_to_attachment(a)
214 value = link_to_attachment(a)
213 else
215 else
214 value = content_tag("i", h(value)) if value
216 value = content_tag("i", h(value)) if value
215 end
217 end
216 end
218 end
217
219
218 if detail.property == 'attr' && detail.prop_key == 'description'
220 if detail.property == 'attr' && detail.prop_key == 'description'
219 s = l(:text_journal_changed_no_detail, :label => label)
221 s = l(:text_journal_changed_no_detail, :label => label)
220 unless no_html
222 unless no_html
221 diff_link = link_to 'diff',
223 diff_link = link_to 'diff',
222 {:controller => 'journals', :action => 'diff', :id => detail.journal_id, :detail_id => detail.id},
224 {:controller => 'journals', :action => 'diff', :id => detail.journal_id, :detail_id => detail.id},
223 :title => l(:label_view_diff)
225 :title => l(:label_view_diff)
224 s << " (#{ diff_link })"
226 s << " (#{ diff_link })"
225 end
227 end
226 s.html_safe
228 s.html_safe
227 elsif !detail.value.blank?
229 elsif !detail.value.blank?
228 case detail.property
230 case detail.property
229 when 'attr', 'cf'
231 when 'attr', 'cf'
230 if !detail.old_value.blank?
232 if !detail.old_value.blank?
231 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
233 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
232 else
234 else
233 l(:text_journal_set_to, :label => label, :value => value).html_safe
235 l(:text_journal_set_to, :label => label, :value => value).html_safe
234 end
236 end
235 when 'attachment'
237 when 'attachment'
236 l(:text_journal_added, :label => label, :value => value).html_safe
238 l(:text_journal_added, :label => label, :value => value).html_safe
237 end
239 end
238 else
240 else
239 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
241 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
240 end
242 end
241 end
243 end
242
244
243 # Find the name of an associated record stored in the field attribute
245 # Find the name of an associated record stored in the field attribute
244 def find_name_by_reflection(field, id)
246 def find_name_by_reflection(field, id)
245 association = Issue.reflect_on_association(field.to_sym)
247 association = Issue.reflect_on_association(field.to_sym)
246 if association
248 if association
247 record = association.class_name.constantize.find_by_id(id)
249 record = association.class_name.constantize.find_by_id(id)
248 return record.name if record
250 return record.name if record
249 end
251 end
250 end
252 end
251
253
252 # Renders issue children recursively
254 # Renders issue children recursively
253 def render_api_issue_children(issue, api)
255 def render_api_issue_children(issue, api)
254 return if issue.leaf?
256 return if issue.leaf?
255 api.array :children do
257 api.array :children do
256 issue.children.each do |child|
258 issue.children.each do |child|
257 api.issue(:id => child.id) do
259 api.issue(:id => child.id) do
258 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
260 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
259 api.subject child.subject
261 api.subject child.subject
260 render_api_issue_children(child, api)
262 render_api_issue_children(child, api)
261 end
263 end
262 end
264 end
263 end
265 end
264 end
266 end
265
267
266 def issues_to_csv(issues, project, query, options={})
268 def issues_to_csv(issues, project, query, options={})
267 decimal_separator = l(:general_csv_decimal_separator)
269 decimal_separator = l(:general_csv_decimal_separator)
268 encoding = l(:general_csv_encoding)
270 encoding = l(:general_csv_encoding)
269 columns = (options[:columns] == 'all' ? query.available_columns : query.columns)
271 columns = (options[:columns] == 'all' ? query.available_columns : query.columns)
270
272
271 export = FCSV.generate(:col_sep => l(:general_csv_separator)) do |csv|
273 export = FCSV.generate(:col_sep => l(:general_csv_separator)) do |csv|
272 # csv header fields
274 # csv header fields
273 csv << [ "#" ] + columns.collect {|c| Redmine::CodesetUtil.from_utf8(c.caption.to_s, encoding) } +
275 csv << [ "#" ] + columns.collect {|c| Redmine::CodesetUtil.from_utf8(c.caption.to_s, encoding) } +
274 (options[:description] ? [Redmine::CodesetUtil.from_utf8(l(:field_description), encoding)] : [])
276 (options[:description] ? [Redmine::CodesetUtil.from_utf8(l(:field_description), encoding)] : [])
275
277
276 # csv lines
278 # csv lines
277 issues.each do |issue|
279 issues.each do |issue|
278 col_values = columns.collect do |column|
280 col_values = columns.collect do |column|
279 s = if column.is_a?(QueryCustomFieldColumn)
281 s = if column.is_a?(QueryCustomFieldColumn)
280 cv = issue.custom_values.detect {|v| v.custom_field_id == column.custom_field.id}
282 cv = issue.custom_values.detect {|v| v.custom_field_id == column.custom_field.id}
281 show_value(cv)
283 show_value(cv)
282 else
284 else
283 value = issue.send(column.name)
285 value = issue.send(column.name)
284 if value.is_a?(Date)
286 if value.is_a?(Date)
285 format_date(value)
287 format_date(value)
286 elsif value.is_a?(Time)
288 elsif value.is_a?(Time)
287 format_time(value)
289 format_time(value)
288 elsif value.is_a?(Float)
290 elsif value.is_a?(Float)
289 value.to_s.gsub('.', decimal_separator)
291 value.to_s.gsub('.', decimal_separator)
290 else
292 else
291 value
293 value
292 end
294 end
293 end
295 end
294 s.to_s
296 s.to_s
295 end
297 end
296 csv << [ issue.id.to_s ] + col_values.collect {|c| Redmine::CodesetUtil.from_utf8(c.to_s, encoding) } +
298 csv << [ issue.id.to_s ] + col_values.collect {|c| Redmine::CodesetUtil.from_utf8(c.to_s, encoding) } +
297 (options[:description] ? [Redmine::CodesetUtil.from_utf8(issue.description, encoding)] : [])
299 (options[:description] ? [Redmine::CodesetUtil.from_utf8(issue.description, encoding)] : [])
298 end
300 end
299 end
301 end
300 export
302 export
301 end
303 end
302 end
304 end
General Comments 0
You need to be logged in to leave comments. Login now