##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_category_based_assignment at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7352:d9a22bb7c37b
parent child
Show More
Side by Side Unified
Context file:
r7352:d9a22bb7c37b Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1081 +1,1084
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
33 33 assert issue.save
34 34 issue.reload
35 35 assert_equal 1.5, issue.estimated_hours
36 36 end
37 37
38 38 def test_create_minimal
39 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
40 40 assert issue.save
41 41 assert issue.description.nil?
42 42 end
43 43
44 44 def test_create_with_required_custom_field
45 45 field = IssueCustomField.find_by_name('Database')
46 46 field.update_attribute(:is_required, true)
47 47
48 48 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
49 49 assert issue.available_custom_fields.include?(field)
50 50 # No value for the custom field
51 51 assert !issue.save
52 52 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
53 53 # Blank value
54 54 issue.custom_field_values = { field.id => '' }
55 55 assert !issue.save
56 56 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
57 57 # Invalid value
58 58 issue.custom_field_values = { field.id => 'SQLServer' }
59 59 assert !issue.save
60 60 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
61 61 # Valid value
62 62 issue.custom_field_values = { field.id => 'PostgreSQL' }
63 63 assert issue.save
64 64 issue.reload
65 65 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
66 66 end
67 67
68 68 def test_create_with_group_assignment
69 69 with_settings :issue_group_assignment => '1' do
70 70 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'Group assignment', :assigned_to_id => 11).save
71 71 issue = Issue.first(:order => 'id DESC')
72 72 assert_kind_of Group, issue.assigned_to
73 73 assert_equal Group.find(11), issue.assigned_to
74 74 end
75 75 end
76 76
77 77 def assert_visibility_match(user, issues)
78 78 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
79 79 end
80 80
81 81 def test_visible_scope_for_anonymous
82 82 # Anonymous user should see issues of public projects only
83 83 issues = Issue.visible(User.anonymous).all
84 84 assert issues.any?
85 85 assert_nil issues.detect {|issue| !issue.project.is_public?}
86 86 assert_nil issues.detect {|issue| issue.is_private?}
87 87 assert_visibility_match User.anonymous, issues
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous_with_own_issues_visibility
91 91 Role.anonymous.update_attribute :issues_visibility, 'own'
92 92 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
93 93
94 94 issues = Issue.visible(User.anonymous).all
95 95 assert issues.any?
96 96 assert_nil issues.detect {|issue| issue.author != User.anonymous}
97 97 assert_visibility_match User.anonymous, issues
98 98 end
99 99
100 100 def test_visible_scope_for_anonymous_without_view_issues_permissions
101 101 # Anonymous user should not see issues without permission
102 102 Role.anonymous.remove_permission!(:view_issues)
103 103 issues = Issue.visible(User.anonymous).all
104 104 assert issues.empty?
105 105 assert_visibility_match User.anonymous, issues
106 106 end
107 107
108 108 def test_visible_scope_for_non_member
109 109 user = User.find(9)
110 110 assert user.projects.empty?
111 111 # Non member user should see issues of public projects only
112 112 issues = Issue.visible(user).all
113 113 assert issues.any?
114 114 assert_nil issues.detect {|issue| !issue.project.is_public?}
115 115 assert_nil issues.detect {|issue| issue.is_private?}
116 116 assert_visibility_match user, issues
117 117 end
118 118
119 119 def test_visible_scope_for_non_member_with_own_issues_visibility
120 120 Role.non_member.update_attribute :issues_visibility, 'own'
121 121 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
122 122 user = User.find(9)
123 123
124 124 issues = Issue.visible(user).all
125 125 assert issues.any?
126 126 assert_nil issues.detect {|issue| issue.author != user}
127 127 assert_visibility_match user, issues
128 128 end
129 129
130 130 def test_visible_scope_for_non_member_without_view_issues_permissions
131 131 # Non member user should not see issues without permission
132 132 Role.non_member.remove_permission!(:view_issues)
133 133 user = User.find(9)
134 134 assert user.projects.empty?
135 135 issues = Issue.visible(user).all
136 136 assert issues.empty?
137 137 assert_visibility_match user, issues
138 138 end
139 139
140 140 def test_visible_scope_for_member
141 141 user = User.find(9)
142 142 # User should see issues of projects for which he has view_issues permissions only
143 143 Role.non_member.remove_permission!(:view_issues)
144 144 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
145 145 issues = Issue.visible(user).all
146 146 assert issues.any?
147 147 assert_nil issues.detect {|issue| issue.project_id != 3}
148 148 assert_nil issues.detect {|issue| issue.is_private?}
149 149 assert_visibility_match user, issues
150 150 end
151 151
152 152 def test_visible_scope_for_admin
153 153 user = User.find(1)
154 154 user.members.each(&:destroy)
155 155 assert user.projects.empty?
156 156 issues = Issue.visible(user).all
157 157 assert issues.any?
158 158 # Admin should see issues on private projects that he does not belong to
159 159 assert issues.detect {|issue| !issue.project.is_public?}
160 160 # Admin should see private issues of other users
161 161 assert issues.detect {|issue| issue.is_private? && issue.author != user}
162 162 assert_visibility_match user, issues
163 163 end
164 164
165 165 def test_visible_scope_with_project
166 166 project = Project.find(1)
167 167 issues = Issue.visible(User.find(2), :project => project).all
168 168 projects = issues.collect(&:project).uniq
169 169 assert_equal 1, projects.size
170 170 assert_equal project, projects.first
171 171 end
172 172
173 173 def test_visible_scope_with_project_and_subprojects
174 174 project = Project.find(1)
175 175 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
176 176 projects = issues.collect(&:project).uniq
177 177 assert projects.size > 1
178 178 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
179 179 end
180 180
181 181 def test_visible_and_nested_set_scopes
182 182 assert_equal 0, Issue.find(1).descendants.visible.all.size
183 183 end
184 184
185 185 def test_errors_full_messages_should_include_custom_fields_errors
186 186 field = IssueCustomField.find_by_name('Database')
187 187
188 188 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
189 189 assert issue.available_custom_fields.include?(field)
190 190 # Invalid value
191 191 issue.custom_field_values = { field.id => 'SQLServer' }
192 192
193 193 assert !issue.valid?
194 194 assert_equal 1, issue.errors.full_messages.size
195 195 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
196 196 end
197 197
198 198 def test_update_issue_with_required_custom_field
199 199 field = IssueCustomField.find_by_name('Database')
200 200 field.update_attribute(:is_required, true)
201 201
202 202 issue = Issue.find(1)
203 203 assert_nil issue.custom_value_for(field)
204 204 assert issue.available_custom_fields.include?(field)
205 205 # No change to custom values, issue can be saved
206 206 assert issue.save
207 207 # Blank value
208 208 issue.custom_field_values = { field.id => '' }
209 209 assert !issue.save
210 210 # Valid value
211 211 issue.custom_field_values = { field.id => 'PostgreSQL' }
212 212 assert issue.save
213 213 issue.reload
214 214 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
215 215 end
216 216
217 217 def test_should_not_update_attributes_if_custom_fields_validation_fails
218 218 issue = Issue.find(1)
219 219 field = IssueCustomField.find_by_name('Database')
220 220 assert issue.available_custom_fields.include?(field)
221 221
222 222 issue.custom_field_values = { field.id => 'Invalid' }
223 223 issue.subject = 'Should be not be saved'
224 224 assert !issue.save
225 225
226 226 issue.reload
227 227 assert_equal "Can't print recipes", issue.subject
228 228 end
229 229
230 230 def test_should_not_recreate_custom_values_objects_on_update
231 231 field = IssueCustomField.find_by_name('Database')
232 232
233 233 issue = Issue.find(1)
234 234 issue.custom_field_values = { field.id => 'PostgreSQL' }
235 235 assert issue.save
236 236 custom_value = issue.custom_value_for(field)
237 237 issue.reload
238 238 issue.custom_field_values = { field.id => 'MySQL' }
239 239 assert issue.save
240 240 issue.reload
241 241 assert_equal custom_value.id, issue.custom_value_for(field).id
242 242 end
243 243
244 244 def test_assigning_tracker_id_should_reload_custom_fields_values
245 245 issue = Issue.new(:project => Project.find(1))
246 246 assert issue.custom_field_values.empty?
247 247 issue.tracker_id = 1
248 248 assert issue.custom_field_values.any?
249 249 end
250 250
251 251 def test_assigning_attributes_should_assign_tracker_id_first
252 252 attributes = ActiveSupport::OrderedHash.new
253 253 attributes['custom_field_values'] = { '1' => 'MySQL' }
254 254 attributes['tracker_id'] = '1'
255 255 issue = Issue.new(:project => Project.find(1))
256 256 issue.attributes = attributes
257 257 assert_not_nil issue.custom_value_for(1)
258 258 assert_equal 'MySQL', issue.custom_value_for(1).value
259 259 end
260 260
261 261 def test_should_update_issue_with_disabled_tracker
262 262 p = Project.find(1)
263 263 issue = Issue.find(1)
264 264
265 265 p.trackers.delete(issue.tracker)
266 266 assert !p.trackers.include?(issue.tracker)
267 267
268 268 issue.reload
269 269 issue.subject = 'New subject'
270 270 assert issue.save
271 271 end
272 272
273 273 def test_should_not_set_a_disabled_tracker
274 274 p = Project.find(1)
275 275 p.trackers.delete(Tracker.find(2))
276 276
277 277 issue = Issue.find(1)
278 278 issue.tracker_id = 2
279 279 issue.subject = 'New subject'
280 280 assert !issue.save
281 281 assert_not_nil issue.errors.on(:tracker_id)
282 282 end
283 283
284 284 def test_category_based_assignment
285 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1)
285 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
286 :status_id => 1, :priority => IssuePriority.all.first,
287 :subject => 'Assignment test',
288 :description => 'Assignment test', :category_id => 1)
286 289 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
287 290 end
288 291
289 292 def test_new_statuses_allowed_to
290 293 Workflow.delete_all
291 294
292 295 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
293 296 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
294 297 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
295 298 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
296 299 status = IssueStatus.find(1)
297 300 role = Role.find(1)
298 301 tracker = Tracker.find(1)
299 302 user = User.find(2)
300 303
301 304 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
302 305 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
303 306
304 307 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
305 308 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
306 309
307 310 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
308 311 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
309 312
310 313 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
311 314 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
312 315 end
313 316
314 317 def test_copy
315 318 issue = Issue.new.copy_from(1)
316 319 assert issue.save
317 320 issue.reload
318 321 orig = Issue.find(1)
319 322 assert_equal orig.subject, issue.subject
320 323 assert_equal orig.tracker, issue.tracker
321 324 assert_equal "125", issue.custom_value_for(2).value
322 325 end
323 326
324 327 def test_copy_should_copy_status
325 328 orig = Issue.find(8)
326 329 assert orig.status != IssueStatus.default
327 330
328 331 issue = Issue.new.copy_from(orig)
329 332 assert issue.save
330 333 issue.reload
331 334 assert_equal orig.status, issue.status
332 335 end
333 336
334 337 def test_should_close_duplicates
335 338 # Create 3 issues
336 339 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
337 340 assert issue1.save
338 341 issue2 = issue1.clone
339 342 assert issue2.save
340 343 issue3 = issue1.clone
341 344 assert issue3.save
342 345
343 346 # 2 is a dupe of 1
344 347 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
345 348 # And 3 is a dupe of 2
346 349 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
347 350 # And 3 is a dupe of 1 (circular duplicates)
348 351 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
349 352
350 353 assert issue1.reload.duplicates.include?(issue2)
351 354
352 355 # Closing issue 1
353 356 issue1.init_journal(User.find(:first), "Closing issue1")
354 357 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
355 358 assert issue1.save
356 359 # 2 and 3 should be also closed
357 360 assert issue2.reload.closed?
358 361 assert issue3.reload.closed?
359 362 end
360 363
361 364 def test_should_not_close_duplicated_issue
362 365 # Create 3 issues
363 366 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
364 367 assert issue1.save
365 368 issue2 = issue1.clone
366 369 assert issue2.save
367 370
368 371 # 2 is a dupe of 1
369 372 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
370 373 # 2 is a dup of 1 but 1 is not a duplicate of 2
371 374 assert !issue2.reload.duplicates.include?(issue1)
372 375
373 376 # Closing issue 2
374 377 issue2.init_journal(User.find(:first), "Closing issue2")
375 378 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
376 379 assert issue2.save
377 380 # 1 should not be also closed
378 381 assert !issue1.reload.closed?
379 382 end
380 383
381 384 def test_assignable_versions
382 385 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
383 386 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
384 387 end
385 388
386 389 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
387 390 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
388 391 assert !issue.save
389 392 assert_not_nil issue.errors.on(:fixed_version_id)
390 393 end
391 394
392 395 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
393 396 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
394 397 assert !issue.save
395 398 assert_not_nil issue.errors.on(:fixed_version_id)
396 399 end
397 400
398 401 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
399 402 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
400 403 assert issue.save
401 404 end
402 405
403 406 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
404 407 issue = Issue.find(11)
405 408 assert_equal 'closed', issue.fixed_version.status
406 409 issue.subject = 'Subject changed'
407 410 assert issue.save
408 411 end
409 412
410 413 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
411 414 issue = Issue.find(11)
412 415 issue.status_id = 1
413 416 assert !issue.save
414 417 assert_not_nil issue.errors.on_base
415 418 end
416 419
417 420 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
418 421 issue = Issue.find(11)
419 422 issue.status_id = 1
420 423 issue.fixed_version_id = 3
421 424 assert issue.save
422 425 end
423 426
424 427 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
425 428 issue = Issue.find(12)
426 429 assert_equal 'locked', issue.fixed_version.status
427 430 issue.status_id = 1
428 431 assert issue.save
429 432 end
430 433
431 434 def test_move_to_another_project_with_same_category
432 435 issue = Issue.find(1)
433 436 assert issue.move_to_project(Project.find(2))
434 437 issue.reload
435 438 assert_equal 2, issue.project_id
436 439 # Category changes
437 440 assert_equal 4, issue.category_id
438 441 # Make sure time entries were move to the target project
439 442 assert_equal 2, issue.time_entries.first.project_id
440 443 end
441 444
442 445 def test_move_to_another_project_without_same_category
443 446 issue = Issue.find(2)
444 447 assert issue.move_to_project(Project.find(2))
445 448 issue.reload
446 449 assert_equal 2, issue.project_id
447 450 # Category cleared
448 451 assert_nil issue.category_id
449 452 end
450 453
451 454 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
452 455 issue = Issue.find(1)
453 456 issue.update_attribute(:fixed_version_id, 1)
454 457 assert issue.move_to_project(Project.find(2))
455 458 issue.reload
456 459 assert_equal 2, issue.project_id
457 460 # Cleared fixed_version
458 461 assert_equal nil, issue.fixed_version
459 462 end
460 463
461 464 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
462 465 issue = Issue.find(1)
463 466 issue.update_attribute(:fixed_version_id, 4)
464 467 assert issue.move_to_project(Project.find(5))
465 468 issue.reload
466 469 assert_equal 5, issue.project_id
467 470 # Keep fixed_version
468 471 assert_equal 4, issue.fixed_version_id
469 472 end
470 473
471 474 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
472 475 issue = Issue.find(1)
473 476 issue.update_attribute(:fixed_version_id, 1)
474 477 assert issue.move_to_project(Project.find(5))
475 478 issue.reload
476 479 assert_equal 5, issue.project_id
477 480 # Cleared fixed_version
478 481 assert_equal nil, issue.fixed_version
479 482 end
480 483
481 484 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
482 485 issue = Issue.find(1)
483 486 issue.update_attribute(:fixed_version_id, 7)
484 487 assert issue.move_to_project(Project.find(2))
485 488 issue.reload
486 489 assert_equal 2, issue.project_id
487 490 # Keep fixed_version
488 491 assert_equal 7, issue.fixed_version_id
489 492 end
490 493
491 494 def test_move_to_another_project_with_disabled_tracker
492 495 issue = Issue.find(1)
493 496 target = Project.find(2)
494 497 target.tracker_ids = [3]
495 498 target.save
496 499 assert_equal false, issue.move_to_project(target)
497 500 issue.reload
498 501 assert_equal 1, issue.project_id
499 502 end
500 503
501 504 def test_copy_to_the_same_project
502 505 issue = Issue.find(1)
503 506 copy = nil
504 507 assert_difference 'Issue.count' do
505 508 copy = issue.move_to_project(issue.project, nil, :copy => true)
506 509 end
507 510 assert_kind_of Issue, copy
508 511 assert_equal issue.project, copy.project
509 512 assert_equal "125", copy.custom_value_for(2).value
510 513 end
511 514
512 515 def test_copy_to_another_project_and_tracker
513 516 issue = Issue.find(1)
514 517 copy = nil
515 518 assert_difference 'Issue.count' do
516 519 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
517 520 end
518 521 copy.reload
519 522 assert_kind_of Issue, copy
520 523 assert_equal Project.find(3), copy.project
521 524 assert_equal Tracker.find(2), copy.tracker
522 525 # Custom field #2 is not associated with target tracker
523 526 assert_nil copy.custom_value_for(2)
524 527 end
525 528
526 529 context "#move_to_project" do
527 530 context "as a copy" do
528 531 setup do
529 532 @issue = Issue.find(1)
530 533 @copy = nil
531 534 end
532 535
533 536 should "not create a journal" do
534 537 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
535 538 assert_equal 0, @copy.reload.journals.size
536 539 end
537 540
538 541 should "allow assigned_to changes" do
539 542 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
540 543 assert_equal 3, @copy.assigned_to_id
541 544 end
542 545
543 546 should "allow status changes" do
544 547 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
545 548 assert_equal 2, @copy.status_id
546 549 end
547 550
548 551 should "allow start date changes" do
549 552 date = Date.today
550 553 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
551 554 assert_equal date, @copy.start_date
552 555 end
553 556
554 557 should "allow due date changes" do
555 558 date = Date.today
556 559 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
557 560
558 561 assert_equal date, @copy.due_date
559 562 end
560 563
561 564 should "set current user as author" do
562 565 User.current = User.find(9)
563 566 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
564 567
565 568 assert_equal User.current, @copy.author
566 569 end
567 570
568 571 should "keep journal notes" do
569 572 date = Date.today
570 573 notes = "Notes added when copying"
571 574 User.current = User.find(9)
572 575 @issue.init_journal(User.current, notes)
573 576 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
574 577
575 578 assert_equal 1, @copy.journals.size
576 579 journal = @copy.journals.first
577 580 assert_equal 0, journal.details.size
578 581 assert_equal notes, journal.notes
579 582 end
580 583 end
581 584 end
582 585
583 586 def test_recipients_should_not_include_users_that_cannot_view_the_issue
584 587 issue = Issue.find(12)
585 588 assert issue.recipients.include?(issue.author.mail)
586 589 # move the issue to a private project
587 590 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
588 591 # author is not a member of project anymore
589 592 assert !copy.recipients.include?(copy.author.mail)
590 593 end
591 594
592 595 def test_recipients_should_include_the_assigned_group_members
593 596 group_member = User.generate_with_protected!
594 597 group = Group.generate!
595 598 group.users << group_member
596 599
597 600 issue = Issue.find(12)
598 601 issue.assigned_to = group
599 602 assert issue.recipients.include?(group_member.mail)
600 603 end
601 604
602 605 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
603 606 user = User.find(3)
604 607 issue = Issue.find(9)
605 608 Watcher.create!(:user => user, :watchable => issue)
606 609 assert issue.watched_by?(user)
607 610 assert !issue.watcher_recipients.include?(user.mail)
608 611 end
609 612
610 613 def test_issue_destroy
611 614 Issue.find(1).destroy
612 615 assert_nil Issue.find_by_id(1)
613 616 assert_nil TimeEntry.find_by_issue_id(1)
614 617 end
615 618
616 619 def test_blocked
617 620 blocked_issue = Issue.find(9)
618 621 blocking_issue = Issue.find(10)
619 622
620 623 assert blocked_issue.blocked?
621 624 assert !blocking_issue.blocked?
622 625 end
623 626
624 627 def test_blocked_issues_dont_allow_closed_statuses
625 628 blocked_issue = Issue.find(9)
626 629
627 630 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
628 631 assert !allowed_statuses.empty?
629 632 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
630 633 assert closed_statuses.empty?
631 634 end
632 635
633 636 def test_unblocked_issues_allow_closed_statuses
634 637 blocking_issue = Issue.find(10)
635 638
636 639 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
637 640 assert !allowed_statuses.empty?
638 641 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
639 642 assert !closed_statuses.empty?
640 643 end
641 644
642 645 def test_rescheduling_an_issue_should_reschedule_following_issue
643 646 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
644 647 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
645 648 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
646 649 assert_equal issue1.due_date + 1, issue2.reload.start_date
647 650
648 651 issue1.due_date = Date.today + 5
649 652 issue1.save!
650 653 assert_equal issue1.due_date + 1, issue2.reload.start_date
651 654 end
652 655
653 656 def test_overdue
654 657 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
655 658 assert !Issue.new(:due_date => Date.today).overdue?
656 659 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
657 660 assert !Issue.new(:due_date => nil).overdue?
658 661 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
659 662 end
660 663
661 664 context "#behind_schedule?" do
662 665 should "be false if the issue has no start_date" do
663 666 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
664 667 end
665 668
666 669 should "be false if the issue has no end_date" do
667 670 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
668 671 end
669 672
670 673 should "be false if the issue has more done than it's calendar time" do
671 674 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
672 675 end
673 676
674 677 should "be true if the issue hasn't been started at all" do
675 678 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
676 679 end
677 680
678 681 should "be true if the issue has used more calendar time than it's done ratio" do
679 682 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
680 683 end
681 684 end
682 685
683 686 context "#assignable_users" do
684 687 should "be Users" do
685 688 assert_kind_of User, Issue.find(1).assignable_users.first
686 689 end
687 690
688 691 should "include the issue author" do
689 692 project = Project.find(1)
690 693 non_project_member = User.generate!
691 694 issue = Issue.generate_for_project!(project, :author => non_project_member)
692 695
693 696 assert issue.assignable_users.include?(non_project_member)
694 697 end
695 698
696 699 should "include the current assignee" do
697 700 project = Project.find(1)
698 701 user = User.generate!
699 702 issue = Issue.generate_for_project!(project, :assigned_to => user)
700 703 user.lock!
701 704
702 705 assert Issue.find(issue.id).assignable_users.include?(user)
703 706 end
704 707
705 708 should "not show the issue author twice" do
706 709 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
707 710 assert_equal 2, assignable_user_ids.length
708 711
709 712 assignable_user_ids.each do |user_id|
710 713 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
711 714 end
712 715 end
713 716
714 717 context "with issue_group_assignment" do
715 718 should "include groups" do
716 719 issue = Issue.new(:project => Project.find(2))
717 720
718 721 with_settings :issue_group_assignment => '1' do
719 722 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
720 723 assert issue.assignable_users.include?(Group.find(11))
721 724 end
722 725 end
723 726 end
724 727
725 728 context "without issue_group_assignment" do
726 729 should "not include groups" do
727 730 issue = Issue.new(:project => Project.find(2))
728 731
729 732 with_settings :issue_group_assignment => '0' do
730 733 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
731 734 assert !issue.assignable_users.include?(Group.find(11))
732 735 end
733 736 end
734 737 end
735 738 end
736 739
737 740 def test_create_should_send_email_notification
738 741 ActionMailer::Base.deliveries.clear
739 742 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
740 743
741 744 assert issue.save
742 745 assert_equal 1, ActionMailer::Base.deliveries.size
743 746 end
744 747
745 748 def test_stale_issue_should_not_send_email_notification
746 749 ActionMailer::Base.deliveries.clear
747 750 issue = Issue.find(1)
748 751 stale = Issue.find(1)
749 752
750 753 issue.init_journal(User.find(1))
751 754 issue.subject = 'Subjet update'
752 755 assert issue.save
753 756 assert_equal 1, ActionMailer::Base.deliveries.size
754 757 ActionMailer::Base.deliveries.clear
755 758
756 759 stale.init_journal(User.find(1))
757 760 stale.subject = 'Another subjet update'
758 761 assert_raise ActiveRecord::StaleObjectError do
759 762 stale.save
760 763 end
761 764 assert ActionMailer::Base.deliveries.empty?
762 765 end
763 766
764 767 def test_journalized_description
765 768 IssueCustomField.delete_all
766 769
767 770 i = Issue.first
768 771 old_description = i.description
769 772 new_description = "This is the new description"
770 773
771 774 i.init_journal(User.find(2))
772 775 i.description = new_description
773 776 assert_difference 'Journal.count', 1 do
774 777 assert_difference 'JournalDetail.count', 1 do
775 778 i.save!
776 779 end
777 780 end
778 781
779 782 detail = JournalDetail.first(:order => 'id DESC')
780 783 assert_equal i, detail.journal.journalized
781 784 assert_equal 'attr', detail.property
782 785 assert_equal 'description', detail.prop_key
783 786 assert_equal old_description, detail.old_value
784 787 assert_equal new_description, detail.value
785 788 end
786 789
787 790 def test_blank_descriptions_should_not_be_journalized
788 791 IssueCustomField.delete_all
789 792 Issue.update_all("description = NULL", "id=1")
790 793
791 794 i = Issue.find(1)
792 795 i.init_journal(User.find(2))
793 796 i.subject = "blank description"
794 797 i.description = "\r\n"
795 798
796 799 assert_difference 'Journal.count', 1 do
797 800 assert_difference 'JournalDetail.count', 1 do
798 801 i.save!
799 802 end
800 803 end
801 804 end
802 805
803 806 def test_description_eol_should_be_normalized
804 807 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
805 808 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
806 809 end
807 810
808 811 def test_saving_twice_should_not_duplicate_journal_details
809 812 i = Issue.find(:first)
810 813 i.init_journal(User.find(2), 'Some notes')
811 814 # initial changes
812 815 i.subject = 'New subject'
813 816 i.done_ratio = i.done_ratio + 10
814 817 assert_difference 'Journal.count' do
815 818 assert i.save
816 819 end
817 820 # 1 more change
818 821 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
819 822 assert_no_difference 'Journal.count' do
820 823 assert_difference 'JournalDetail.count', 1 do
821 824 i.save
822 825 end
823 826 end
824 827 # no more change
825 828 assert_no_difference 'Journal.count' do
826 829 assert_no_difference 'JournalDetail.count' do
827 830 i.save
828 831 end
829 832 end
830 833 end
831 834
832 835 def test_all_dependent_issues
833 836 IssueRelation.delete_all
834 837 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
835 838 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
836 839 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
837 840
838 841 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
839 842 end
840 843
841 844 def test_all_dependent_issues_with_persistent_circular_dependency
842 845 IssueRelation.delete_all
843 846 assert IssueRelation.create!(:issue_from => Issue.find(1),
844 847 :issue_to => Issue.find(2),
845 848 :relation_type => IssueRelation::TYPE_PRECEDES)
846 849 assert IssueRelation.create!(:issue_from => Issue.find(2),
847 850 :issue_to => Issue.find(3),
848 851 :relation_type => IssueRelation::TYPE_PRECEDES)
849 852 # Validation skipping
850 853 assert IssueRelation.new(:issue_from => Issue.find(3),
851 854 :issue_to => Issue.find(1),
852 855 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
853 856
854 857 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
855 858 end
856 859
857 860 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
858 861 IssueRelation.delete_all
859 862 assert IssueRelation.create!(:issue_from => Issue.find(1),
860 863 :issue_to => Issue.find(2),
861 864 :relation_type => IssueRelation::TYPE_RELATES)
862 865 assert IssueRelation.create!(:issue_from => Issue.find(2),
863 866 :issue_to => Issue.find(3),
864 867 :relation_type => IssueRelation::TYPE_RELATES)
865 868 assert IssueRelation.create!(:issue_from => Issue.find(3),
866 869 :issue_to => Issue.find(8),
867 870 :relation_type => IssueRelation::TYPE_RELATES)
868 871 # Validation skipping
869 872 assert IssueRelation.new(:issue_from => Issue.find(8),
870 873 :issue_to => Issue.find(2),
871 874 :relation_type => IssueRelation::TYPE_RELATES).save(false)
872 875 assert IssueRelation.new(:issue_from => Issue.find(3),
873 876 :issue_to => Issue.find(1),
874 877 :relation_type => IssueRelation::TYPE_RELATES).save(false)
875 878
876 879 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
877 880 end
878 881
879 882 context "#done_ratio" do
880 883 setup do
881 884 @issue = Issue.find(1)
882 885 @issue_status = IssueStatus.find(1)
883 886 @issue_status.update_attribute(:default_done_ratio, 50)
884 887 @issue2 = Issue.find(2)
885 888 @issue_status2 = IssueStatus.find(2)
886 889 @issue_status2.update_attribute(:default_done_ratio, 0)
887 890 end
888 891
889 892 context "with Setting.issue_done_ratio using the issue_field" do
890 893 setup do
891 894 Setting.issue_done_ratio = 'issue_field'
892 895 end
893 896
894 897 should "read the issue's field" do
895 898 assert_equal 0, @issue.done_ratio
896 899 assert_equal 30, @issue2.done_ratio
897 900 end
898 901 end
899 902
900 903 context "with Setting.issue_done_ratio using the issue_status" do
901 904 setup do
902 905 Setting.issue_done_ratio = 'issue_status'
903 906 end
904 907
905 908 should "read the Issue Status's default done ratio" do
906 909 assert_equal 50, @issue.done_ratio
907 910 assert_equal 0, @issue2.done_ratio
908 911 end
909 912 end
910 913 end
911 914
912 915 context "#update_done_ratio_from_issue_status" do
913 916 setup do
914 917 @issue = Issue.find(1)
915 918 @issue_status = IssueStatus.find(1)
916 919 @issue_status.update_attribute(:default_done_ratio, 50)
917 920 @issue2 = Issue.find(2)
918 921 @issue_status2 = IssueStatus.find(2)
919 922 @issue_status2.update_attribute(:default_done_ratio, 0)
920 923 end
921 924
922 925 context "with Setting.issue_done_ratio using the issue_field" do
923 926 setup do
924 927 Setting.issue_done_ratio = 'issue_field'
925 928 end
926 929
927 930 should "not change the issue" do
928 931 @issue.update_done_ratio_from_issue_status
929 932 @issue2.update_done_ratio_from_issue_status
930 933
931 934 assert_equal 0, @issue.read_attribute(:done_ratio)
932 935 assert_equal 30, @issue2.read_attribute(:done_ratio)
933 936 end
934 937 end
935 938
936 939 context "with Setting.issue_done_ratio using the issue_status" do
937 940 setup do
938 941 Setting.issue_done_ratio = 'issue_status'
939 942 end
940 943
941 944 should "change the issue's done ratio" do
942 945 @issue.update_done_ratio_from_issue_status
943 946 @issue2.update_done_ratio_from_issue_status
944 947
945 948 assert_equal 50, @issue.read_attribute(:done_ratio)
946 949 assert_equal 0, @issue2.read_attribute(:done_ratio)
947 950 end
948 951 end
949 952 end
950 953
951 954 test "#by_tracker" do
952 955 User.current = User.anonymous
953 956 groups = Issue.by_tracker(Project.find(1))
954 957 assert_equal 3, groups.size
955 958 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
956 959 end
957 960
958 961 test "#by_version" do
959 962 User.current = User.anonymous
960 963 groups = Issue.by_version(Project.find(1))
961 964 assert_equal 3, groups.size
962 965 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
963 966 end
964 967
965 968 test "#by_priority" do
966 969 User.current = User.anonymous
967 970 groups = Issue.by_priority(Project.find(1))
968 971 assert_equal 4, groups.size
969 972 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
970 973 end
971 974
972 975 test "#by_category" do
973 976 User.current = User.anonymous
974 977 groups = Issue.by_category(Project.find(1))
975 978 assert_equal 2, groups.size
976 979 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
977 980 end
978 981
979 982 test "#by_assigned_to" do
980 983 User.current = User.anonymous
981 984 groups = Issue.by_assigned_to(Project.find(1))
982 985 assert_equal 2, groups.size
983 986 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
984 987 end
985 988
986 989 test "#by_author" do
987 990 User.current = User.anonymous
988 991 groups = Issue.by_author(Project.find(1))
989 992 assert_equal 4, groups.size
990 993 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
991 994 end
992 995
993 996 test "#by_subproject" do
994 997 User.current = User.anonymous
995 998 groups = Issue.by_subproject(Project.find(1))
996 999 # Private descendant not visible
997 1000 assert_equal 1, groups.size
998 1001 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
999 1002 end
1000 1003
1001 1004 context ".allowed_target_projects_on_move" do
1002 1005 should "return all active projects for admin users" do
1003 1006 User.current = User.find(1)
1004 1007 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1005 1008 end
1006 1009
1007 1010 should "return allowed projects for non admin users" do
1008 1011 User.current = User.find(2)
1009 1012 Role.non_member.remove_permission! :move_issues
1010 1013 assert_equal 3, Issue.allowed_target_projects_on_move.size
1011 1014
1012 1015 Role.non_member.add_permission! :move_issues
1013 1016 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1014 1017 end
1015 1018 end
1016 1019
1017 1020 def test_recently_updated_with_limit_scopes
1018 1021 #should return the last updated issue
1019 1022 assert_equal 1, Issue.recently_updated.with_limit(1).length
1020 1023 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1021 1024 end
1022 1025
1023 1026 def test_on_active_projects_scope
1024 1027 assert Project.find(2).archive
1025 1028
1026 1029 before = Issue.on_active_project.length
1027 1030 # test inclusion to results
1028 1031 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1029 1032 assert_equal before + 1, Issue.on_active_project.length
1030 1033
1031 1034 # Move to an archived project
1032 1035 issue.project = Project.find(2)
1033 1036 assert issue.save
1034 1037 assert_equal before, Issue.on_active_project.length
1035 1038 end
1036 1039
1037 1040 context "Issue#recipients" do
1038 1041 setup do
1039 1042 @project = Project.find(1)
1040 1043 @author = User.generate_with_protected!
1041 1044 @assignee = User.generate_with_protected!
1042 1045 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1043 1046 end
1044 1047
1045 1048 should "include project recipients" do
1046 1049 assert @project.recipients.present?
1047 1050 @project.recipients.each do |project_recipient|
1048 1051 assert @issue.recipients.include?(project_recipient)
1049 1052 end
1050 1053 end
1051 1054
1052 1055 should "include the author if the author is active" do
1053 1056 assert @issue.author, "No author set for Issue"
1054 1057 assert @issue.recipients.include?(@issue.author.mail)
1055 1058 end
1056 1059
1057 1060 should "include the assigned to user if the assigned to user is active" do
1058 1061 assert @issue.assigned_to, "No assigned_to set for Issue"
1059 1062 assert @issue.recipients.include?(@issue.assigned_to.mail)
1060 1063 end
1061 1064
1062 1065 should "not include users who opt out of all email" do
1063 1066 @author.update_attribute(:mail_notification, :none)
1064 1067
1065 1068 assert !@issue.recipients.include?(@issue.author.mail)
1066 1069 end
1067 1070
1068 1071 should "not include the issue author if they are only notified of assigned issues" do
1069 1072 @author.update_attribute(:mail_notification, :only_assigned)
1070 1073
1071 1074 assert !@issue.recipients.include?(@issue.author.mail)
1072 1075 end
1073 1076
1074 1077 should "not include the assigned user if they are only notified of owned issues" do
1075 1078 @assignee.update_attribute(:mail_notification, :only_owner)
1076 1079
1077 1080 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1078 1081 end
1079 1082
1080 1083 end
1081 1084 end
General Comments 0
You need to be logged in to leave comments. Login now