jro_apps/redmine Commit - r7864:d92c204ed389

Fixed: version files in Files module cannot be downloaded if issue tracking is disabled (#9055)....

Jean-Philippe Lang -

r7864:d92c204ed389

parent child

Context file:

r7864:d92c204ed389

app/models/version.rb +5 0

                  user.allowed_to?(:view_issues, self.project)
                end
+               # Version files have same visibility as project files
+               def attachments_visible?(*args)
+                 project.present? && project.attachments_visible?(*args)
+               end
                def start_date
                  @start_date ||= fixed_issues.minimum('start_date')
                end

test/fixtures/attachments.yml +1 -1

                container_type: Version
                container_id: 1
                downloads: 0
-               disk_filename: 060719210727_version_file.zip
+               disk_filename: 060719210727_archive.zip
                digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
                id: 9
                filesize: 452

test/functional/attachments_controller_test.rb +6 0

                  set_tmp_attachments_directory
                end
+               def test_download_version_file_with_issue_tracking_disabled
+                 Project.find(1).disable_module! :issue_tracking
+                 get :download, :id => 9
+                 assert_response :success
+               end
                def test_download_should_assign_content_type_if_blank
                  Attachment.find(4).update_attribute(:content_type, '')

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages