jro_apps/redmine Commit - r13815:d904292635b1

Merged r14156 and r14161 (#19400)....

Jean-Philippe Lang -

r13815:d904292635b1

parent child

Context file:

r13815:d904292635b1

Collapse all files

app/models/repository.rb +5 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class ScmFetchError < Exception; end
             class Repository < ActiveRecord::Base
               include Redmine::Ciphering
               include Redmine::SafeAttributes
               # Maximum length for repository identifiers
               IDENTIFIER_MAX_LENGTH = 255
               belongs_to :project
               has_many :changesets, lambda{order("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC")}
               has_many :filechanges, :class_name => 'Change', :through => :changesets
               serialize :extra_info
+              before_validation :normalize_identifier
               before_save :check_default
               # Raw SQL to delete changesets and changes in the database
               # has_many :changesets, :dependent => :destroy is too slow for big repositories
               before_destroy :clear_changesets
               validates_length_of :password, :maximum => 255, :allow_nil => true
               validates_length_of :identifier, :maximum => IDENTIFIER_MAX_LENGTH, :allow_blank => true
               validates_uniqueness_of :identifier, :scope => :project_id
               validates_exclusion_of :identifier, :in => %w(browse show entry raw changes annotate diff statistics graph revisions revision)
               # donwcase letters, digits, dashes, underscores but not digits only
               validates_format_of :identifier, :with => /\A(?!\d+$)[a-z0-9\-_]*\z/, :allow_blank => true
               # Checks if the SCM is enabled when creating a repository
               validate :repo_create_validation, :on => :create
               validate :validate_repository_path
               attr_protected :id
               safe_attributes 'identifier',
                 'login',
                 'password',
                 'path_encoding',
                 'log_encoding',
                 'is_default'
               safe_attributes 'url',
                 :if => lambda {|repository, user| repository.new_record?}
               def repo_create_validation
                 unless Setting.enabled_scm.include?(self.class.name.demodulize)
                   errors.add(:type, :invalid)
                 end
               end
               def self.human_attribute_name(attribute_key_name, *args)
                 attr_name = attribute_key_name.to_s
                 if attr_name == "log_encoding"
                   attr_name = "commit_logs_encoding"
                 end
                 super(attr_name, *args)
               end
               # Removes leading and trailing whitespace
               def url=(arg)
                 write_attribute(:url, arg ? arg.to_s.strip : nil)
               end
               # Removes leading and trailing whitespace
               def root_url=(arg)
                 write_attribute(:root_url, arg ? arg.to_s.strip : nil)
               end
               def password
                 read_ciphered_attribute(:password)
               end
               def password=(arg)
                 write_ciphered_attribute(:password, arg)
               end
               def scm_adapter
                 self.class.scm_adapter_class
               end
               def scm
                 unless @scm
                   @scm = self.scm_adapter.new(url, root_url,
                                               login, password, path_encoding)
                   if root_url.blank? && @scm.root_url.present?
                     update_attribute(:root_url, @scm.root_url)
                   end
                 end
                 @scm
               end
               def scm_name
                 self.class.scm_name
               end
               def name
                 if identifier.present?
                   identifier
                 elsif is_default?
                   l(:field_repository_is_default)
                 else
                   scm_name
                 end
               end
               def identifier=(identifier)
                 super unless identifier_frozen?
               end
               def identifier_frozen?
                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
               end
               def identifier_param
                 if is_default?
                   nil
                 elsif identifier.present?
                   identifier
                 else
                   id.to_s
                 end
               end
               def <=>(repository)
                 if is_default?
                   -1
                 elsif repository.is_default?
                 else
                   identifier.to_s <=> repository.identifier.to_s
                 end
               end
               def self.find_by_identifier_param(param)
                 if param.to_s =~ /^\d+$/
                   find_by_id(param)
                 else
                   find_by_identifier(param)
                 end
               end
               # TODO: should return an empty hash instead of nil to avoid many ||{}
               def extra_info
                 h = read_attribute(:extra_info)
                 h.is_a?(Hash) ? h : nil
               end
               def merge_extra_info(arg)
                 h = extra_info || {}
                 return h if arg.nil?
                 h.merge!(arg)
                 write_attribute(:extra_info, h)
               end
               def report_last_commit
                 true
               end
               def supports_cat?
                 scm.supports_cat?
               end
               def supports_annotate?
                 scm.supports_annotate?
               end
               def supports_all_revisions?
                 true
               end
               def supports_directory_revisions?
                 false
               end
               def supports_revision_graph?
                 false
               end
               def entry(path=nil, identifier=nil)
                 scm.entry(path, identifier)
               end
               def scm_entries(path=nil, identifier=nil)
                 scm.entries(path, identifier)
               end
               protected :scm_entries
               def entries(path=nil, identifier=nil)
                 entries = scm_entries(path, identifier)
                 load_entries_changesets(entries)
                 entries
               end
               def branches
                 scm.branches
               end
               def tags
                 scm.tags
               end
               def default_branch
                 nil
               end
               def properties(path, identifier=nil)
                 scm.properties(path, identifier)
               end
               def cat(path, identifier=nil)
                 scm.cat(path, identifier)
               end
               def diff(path, rev, rev_to)
                 scm.diff(path, rev, rev_to)
               end
               def diff_format_revisions(cs, cs_to, sep=':')
                 text = ""
                 text << cs_to.format_identifier + sep if cs_to
                 text << cs.format_identifier if cs
                 text
               end
               # Returns a path relative to the url of the repository
               def relative_path(path)
                 path
               end
               # Finds and returns a revision with a number or the beginning of a hash
               def find_changeset_by_name(name)
                 return nil if name.blank?
                 s = name.to_s
                 if s.match(/^\d*$/)
                   changesets.where("revision = ?", s).first
                 else
                   changesets.where("revision LIKE ?", s + '%').first
                 end
               end
               def latest_changeset
                 @latest_changeset ||= changesets.first
               end
               # Returns the latest changesets for +path+
               # Default behaviour is to search in cached changesets
               def latest_changesets(path, rev, limit=10)
                 if path.blank?
                   changesets.
                     reorder("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC").
                     limit(limit).
                     preload(:user).
                     to_a
                 else
                   filechanges.
                     where("path = ?", path.with_leading_slash).
                     reorder("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC").
                     limit(limit).
                     preload(:changeset => :user).
                     collect(&:changeset)
                 end
               end
               def scan_changesets_for_issue_ids
                 self.changesets.each(&:scan_comment_for_issue_ids)
               end
               # Returns an array of committers usernames and associated user_id
               def committers
                 @committers ||= Changeset.where(:repository_id => id).uniq.pluck(:committer, :user_id)
               end
               # Maps committers username to a user ids
               def committer_ids=(h)
                 if h.is_a?(Hash)
                   committers.each do |committer, user_id|
                     new_user_id = h[committer]
                     if new_user_id && (new_user_id.to_i != user_id.to_i)
                       new_user_id = (new_user_id.to_i > 0 ? new_user_id.to_i : nil)
                       Changeset.where(["repository_id = ? AND committer = ?", id, committer]).
                         update_all("user_id = #{new_user_id.nil? ? 'NULL' : new_user_id}")
                     end
                   end
                   @committers            = nil
                   @found_committer_users = nil
                   true
                 else
                   false
                 end
               end
               # Returns the Redmine User corresponding to the given +committer+
               # It will return nil if the committer is not yet mapped and if no User
               # with the same username or email was found
               def find_committer_user(committer)
                 unless committer.blank?
                   @found_committer_users ||= {}
                   return @found_committer_users[committer] if @found_committer_users.has_key?(committer)
                   user = nil
                   c = changesets.where(:committer => committer).
                         includes(:user).references(:user).first
                   if c && c.user
                     user = c.user
                   elsif committer.strip =~ /^([^<]+)(<(.*)>)?$/
                     username, email = $1.strip, $3
                     u = User.find_by_login(username)
                     u ||= User.find_by_mail(email) unless email.blank?
                     user = u
                   end
                   @found_committer_users[committer] = user
                   user
                 end
               end
               def repo_log_encoding
                 encoding = log_encoding.to_s.strip
                 encoding.blank? ? 'UTF-8' : encoding
               end
               # Fetches new changesets for all repositories of active projects
               # Can be called periodically by an external script
               # eg. ruby script/runner "Repository.fetch_changesets"
               def self.fetch_changesets
                 Project.active.has_module(:repository).all.each do |project|
                   project.repositories.each do |repository|
                     begin
                       repository.fetch_changesets
                     rescue Redmine::Scm::Adapters::CommandFailed => e
                       logger.error "scm: error during fetching changesets: #{e.message}"
                     end
                   end
                 end
               end
               # scan changeset comments to find related and fixed issues for all repositories
               def self.scan_changesets_for_issue_ids
                 all.each(&:scan_changesets_for_issue_ids)
               end
               def self.scm_name
                 'Abstract'
               end
               def self.available_scm
                 subclasses.collect {|klass| [klass.scm_name, klass.name]}
               end
               def self.factory(klass_name, *args)
                 klass = "Repository::#{klass_name}".constantize
                 klass.new(*args)
               rescue
                 nil
               end
               def self.scm_adapter_class
                 nil
               end
               def self.scm_command
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_command if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get command: #{e.message}"
                 end
                 ret
               end
               def self.scm_version_string
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_version_string if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get version string: #{e.message}"
                 end
                 ret
               end
               def self.scm_available
                 ret = false
                 begin
                   ret = self.scm_adapter_class.client_available if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get scm available: #{e.message}"
                 end
                 ret
               end
               def set_as_default?
                 new_record? && project && Repository.where(:project_id => project.id).empty?
               end
               # Returns a hash with statistics by author in the following form:
               # {
               #   "John Smith" => { :commits => 45, :changes => 324 },
               #   "Bob" => { ... }
               # }
               #
               # Notes:
               # - this hash honnors the users mapping defined for the repository
               def stats_by_author
                 commits = Changeset.where("repository_id = ?", id).select("committer, user_id, count(*) as count").group("committer, user_id")
                 #TODO: restore ordering ; this line probably never worked
                 #commits.to_a.sort! {|x, y| x.last <=> y.last}
                 changes = Change.joins(:changeset).where("#{Changeset.table_name}.repository_id = ?", id).select("committer, user_id, count(*) as count").group("committer, user_id")
                 user_ids = changesets.map(&:user_id).compact.uniq
                 authors_names = User.where(:id => user_ids).inject({}) do |memo, user|
                   memo[user.id] = user.to_s
                   memo
                 end
                 (commits + changes).inject({}) do |hash, element|
                   mapped_name = element.committer
                   if username = authors_names[element.user_id.to_i]
                     mapped_name = username
                   end
                   hash[mapped_name] ||= { :commits_count => 0, :changes_count => 0 }
                   if element.is_a?(Changeset)
                     hash[mapped_name][:commits_count] += element.count.to_i
                   else
                     hash[mapped_name][:changes_count] += element.count.to_i
                   end
                   hash
                 end
               end
               # Returns a scope of changesets that come from the same commit as the given changeset
               # in different repositories that point to the same backend
               def same_commits_in_scope(scope, changeset)
                 scope = scope.joins(:repository).where(:repositories => {:url => url, :root_url => root_url, :type => type})
                 if changeset.scmid.present?
                   scope = scope.where(:scmid => changeset.scmid)
                 else
                   scope = scope.where(:revision => changeset.revision)
                 end
                 scope
               end
               protected
               # Validates repository url based against an optional regular expression
               # that can be set in the Redmine configuration file.
               def validate_repository_path(attribute=:url)
                 regexp = Redmine::Configuration["scm_#{scm_name.to_s.downcase}_path_regexp"]
                 if changes[attribute] && regexp.present?
                   regexp = regexp.to_s.strip.gsub('%project%') {Regexp.escape(project.try(:identifier).to_s)}
                   unless send(attribute).to_s.match(Regexp.new("\\A#{regexp}\\z"))
                     errors.add(attribute, :invalid)
                   end
                 end
               end
+              def normalize_identifier
+                self.identifier = identifier.to_s.strip
+              end
               def check_default
                 if !is_default? && set_as_default?
                   self.is_default = true
                 end
                 if is_default? && is_default_changed?
                   Repository.where(["project_id = ?", project_id]).update_all(["is_default = ?", false])
                 end
               end
               def load_entries_changesets(entries)
                 if entries
                   entries.each do |entry|
                     if entry.lastrev && entry.lastrev.identifier
                       entry.changeset = find_changeset_by_name(entry.lastrev.identifier)
                     end
                   end
                 end
               end
               private
               # Deletes repository data
               def clear_changesets
                 cs = Changeset.table_name
                 ch = Change.table_name
                 ci = "#{table_name_prefix}changesets_issues#{table_name_suffix}"
                 cp = "#{table_name_prefix}changeset_parents#{table_name_suffix}"
                 self.class.connection.delete("DELETE FROM #{ch} WHERE #{ch}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{ci} WHERE #{ci}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{cp} WHERE #{cp}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{cs} WHERE #{cs}.repository_id = #{id}")
                 clear_extra_info_of_changesets
               end
               def clear_extra_info_of_changesets
               end
             end

test/functional/repositories_git_controller_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoriesGitControllerTest < ActionController::TestCase
               tests RepositoriesController
               fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
                        :repositories, :enabled_modules
               REPOSITORY_PATH = Rails.root.join('tmp/test/git_repository').to_s
               REPOSITORY_PATH.gsub!(/\//, "\\") if Redmine::Platform.mswin?
               PRJ_ID     = 3
               CHAR_1_HEX = "\xc3\x9c".force_encoding('UTF-8')
               FELIX_HEX  = "Felix Sch\xC3\xA4fer".force_encoding('UTF-8')
               NUM_REV = 28
               ## Git, Mercurial and CVS path encodings are binary.
               ## Subversion supports URL encoding for path.
               ## Redmine Mercurial adapter and extension use URL encoding.
               ## Git accepts only binary path in command line parameter.
               ## So, there is no way to use binary command line parameter in JRuby.
               JRUBY_SKIP     = (RUBY_PLATFORM == 'java')
               JRUBY_SKIP_STR = "TODO: This test fails in JRuby"
               def setup
                 @ruby19_non_utf8_pass = Encoding.default_external.to_s != 'UTF-8'
                 User.current = nil
                 @project    = Project.find(PRJ_ID)
                 @repository = Repository::Git.create(
                                   :project       => @project,
                                   :url           => REPOSITORY_PATH,
                                   :path_encoding => 'ISO-8859-1'
                                   )
                 assert @repository
               end
               def test_create_and_update
                 @request.session[:user_id] = 1
                 assert_difference 'Repository.count' do
                   post :create, :project_id => 'subproject1',
                                 :repository_scm => 'Git',
                                 :repository => {
                                    :url => '/test',
                                    :is_default => '0',
                                    :identifier => 'test-create',
                                    :extra_report_last_commit => '1',
                                  }
                 end
                 assert_response 302
                 repository = Repository.order('id DESC').first
                 assert_kind_of Repository::Git, repository
                 assert_equal '/test', repository.url
                 assert_equal true, repository.extra_report_last_commit
                 put :update, :id => repository.id,
                              :repository => {
                                  :extra_report_last_commit => '0'
                              }
                 assert_response 302
                 repo2 = Repository.find(repository.id)
                 assert_equal false, repo2.extra_report_last_commit
               end
               if File.directory?(REPOSITORY_PATH)
                 ## Ruby uses ANSI api to fork a process on Windows.
                 ## Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem
                 ## and these are incompatible with ASCII.
                 ## Git for Windows (msysGit) changed internal API from ANSI to Unicode in 1.7.10
                 ## http://code.google.com/p/msysgit/issues/detail?id=80
                 ## So, Latin-1 path tests fail on Japanese Windows
                 WINDOWS_PASS = (Redmine::Platform.mswin? &&
                                      Redmine::Scm::Adapters::GitAdapter.client_version_above?([1, 7, 10]))
                 WINDOWS_SKIP_STR = "TODO: This test fails in Git for Windows above 1.7.10"
                 def test_get_new
                   @request.session[:user_id] = 1
                   @project.repository.destroy
                   get :new, :project_id => 'subproject1', :repository_scm => 'Git'
                   assert_response :success
                   assert_template 'new'
                   assert_kind_of Repository::Git, assigns(:repository)
                   assert assigns(:repository).new_record?
                 end
                 def test_browse_root
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :show, :id => PRJ_ID
                   assert_response :success
                   assert_template 'show'
                   assert_not_nil assigns(:entries)
                   assert_equal 9, assigns(:entries).size
                   assert assigns(:entries).detect {|e| e.name == 'images' && e.kind == 'dir'}
                   assert assigns(:entries).detect {|e| e.name == 'this_is_a_really_long_and_verbose_directory_name' && e.kind == 'dir'}
                   assert assigns(:entries).detect {|e| e.name == 'sources' && e.kind == 'dir'}
                   assert assigns(:entries).detect {|e| e.name == 'README' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == 'copied_README' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == 'new_file.txt' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == 'renamed_test.txt' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == 'filemane with spaces.txt' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == ' filename with a leading space.txt ' && e.kind == 'file'}
                   assert_not_nil assigns(:changesets)
                   assert assigns(:changesets).size > 0
                 end
                 def test_browse_branch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :show, :id => PRJ_ID, :rev => 'test_branch'
                   assert_response :success
                   assert_template 'show'
                   assert_not_nil assigns(:entries)
                   assert_equal 4, assigns(:entries).size
                   assert assigns(:entries).detect {|e| e.name == 'images' && e.kind == 'dir'}
                   assert assigns(:entries).detect {|e| e.name == 'sources' && e.kind == 'dir'}
                   assert assigns(:entries).detect {|e| e.name == 'README' && e.kind == 'file'}
                   assert assigns(:entries).detect {|e| e.name == 'test.txt' && e.kind == 'file'}
                   assert_not_nil assigns(:changesets)
                   assert assigns(:changesets).size > 0
                 end
                 def test_browse_tag
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                    [
                     "tag00.lightweight",
                     "tag01.annotated",
                    ].each do |t1|
                     get :show, :id => PRJ_ID, :rev => t1
                     assert_response :success
                     assert_template 'show'
                     assert_not_nil assigns(:entries)
                     assert assigns(:entries).size > 0
                     assert_not_nil assigns(:changesets)
                     assert assigns(:changesets).size > 0
                   end
                 end
                 def test_browse_directory
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :show, :id => PRJ_ID, :path => repository_path_hash(['images'])[:param]
                   assert_response :success
                   assert_template 'show'
                   assert_not_nil assigns(:entries)
                   assert_equal ['edit.png'], assigns(:entries).collect(&:name)
                   entry = assigns(:entries).detect {|e| e.name == 'edit.png'}
                   assert_not_nil entry
                   assert_equal 'file', entry.kind
                   assert_equal 'images/edit.png', entry.path
                   assert_not_nil assigns(:changesets)
                   assert assigns(:changesets).size > 0
                 end
                 def test_browse_at_given_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :show, :id => PRJ_ID, :path => repository_path_hash(['images'])[:param],
                       :rev => '7234cb2750b63f47bff735edc50a1c0a433c2518'
                   assert_response :success
                   assert_template 'show'
                   assert_not_nil assigns(:entries)
                   assert_equal ['delete.png'], assigns(:entries).collect(&:name)
                   assert_not_nil assigns(:changesets)
                   assert assigns(:changesets).size > 0
                 end
                 def test_changes
                   get :changes, :id => PRJ_ID,
                       :path => repository_path_hash(['images', 'edit.png'])[:param]
                   assert_response :success
                   assert_template 'changes'
                   assert_select 'h2', :text => /edit.png/
                 end
                 def test_entry_show
                   get :entry, :id => PRJ_ID,
                       :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param]
                   assert_response :success
                   assert_template 'entry'
                   # Line 11
                   assert_select 'tr#L11 td.line-code', :text => /WITHOUT ANY WARRANTY/
                 end
                 def test_entry_show_latin_1
                   if @ruby19_non_utf8_pass
                     puts_ruby19_non_utf8_pass()
                   elsif WINDOWS_PASS
                     puts WINDOWS_SKIP_STR
                   elsif JRUBY_SKIP
                     puts JRUBY_SKIP_STR
                   else
                     with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                       ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
                         get :entry, :id => PRJ_ID,
                             :path => repository_path_hash(['latin-1-dir', "test-#{CHAR_1_HEX}.txt"])[:param],
                             :rev => r1
                         assert_response :success
                         assert_template 'entry'
                         assert_select 'tr#L1 td.line-code', :text => /test-#{CHAR_1_HEX}.txt/
                       end
                     end
                   end
                 end
                 def test_entry_download
                   get :entry, :id => PRJ_ID,
                       :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param],
                       :format => 'raw'
                   assert_response :success
                   # File content
                   assert @response.body.include?('WITHOUT ANY WARRANTY')
                 end
                 def test_directory_entry
                   get :entry, :id => PRJ_ID,
                       :path => repository_path_hash(['sources'])[:param]
                   assert_response :success
                   assert_template 'show'
                   assert_not_nil assigns(:entry)
                   assert_equal 'sources', assigns(:entry).name
                 end
                 def test_diff
                   assert_equal true, @repository.is_default
-                  assert_nil @repository.identifier
+                  assert @repository.identifier.blank?
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # Full diff of changeset 2f9c0091
                   ['inline', 'sbs'].each do |dt|
                     get :diff,
                         :id   => PRJ_ID,
                         :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
                         :type => dt
                     assert_response :success
                     assert_template 'diff'
                     # Line 22 removed
                     assert_select 'th.line-num:contains(22) ~ td.diff_out', :text => /def remove/
                     assert_select 'h2', :text => /2f9c0091/
                   end
                 end
                 def test_diff_with_rev_and_path
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   with_settings :diff_max_lines_displayed => 1000 do
                     # Full diff of changeset 2f9c0091
                     ['inline', 'sbs'].each do |dt|
                       get :diff,
                           :id   => PRJ_ID,
                           :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
                           :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param],
                           :type => dt
                       assert_response :success
                       assert_template 'diff'
                       # Line 22 removed
                       assert_select 'th.line-num:contains(22) ~ td.diff_out', :text => /def remove/
                       assert_select 'h2', :text => /2f9c0091/
                     end
                   end
                 end
                 def test_diff_truncated
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   with_settings :diff_max_lines_displayed => 5 do
                     # Truncated diff of changeset 2f9c0091
                     with_cache do
                       with_settings :default_language => 'en' do
                         get :diff, :id   => PRJ_ID, :type => 'inline',
                             :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
                         assert_response :success
                         assert @response.body.include?("... This diff was truncated")
                       end
                       with_settings :default_language => 'fr' do
                         get :diff, :id   => PRJ_ID, :type => 'inline',
                             :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
                         assert_response :success
                         assert ! @response.body.include?("... This diff was truncated")
                         assert @response.body.include?("... Ce diff")
                       end
                     end
                   end
                 end
                 def test_diff_two_revs
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['inline', 'sbs'].each do |dt|
                     get :diff,
                         :id     => PRJ_ID,
                         :rev    => '61b685fbe55ab05b5ac68402d5720c1a6ac973d1',
                         :rev_to => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
                         :type   => dt
                     assert_response :success
                     assert_template 'diff'
                     diff = assigns(:diff)
                     assert_not_nil diff
                     assert_select 'h2', :text => /2f9c0091:61b685fb/
                     assert_select 'form[action=?]', '/projects/subproject1/repository/revisions/61b685fbe55ab05b5ac68402d5720c1a6ac973d1/diff'
                     assert_select 'input#rev_to[type=hidden][name=rev_to][value=?]', '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
                   end
                 end
                 def test_diff_path_in_subrepo
                   repo = Repository::Git.create(
                                   :project       => @project,
                                   :url           => REPOSITORY_PATH,
                                   :identifier => 'test-diff-path',
                                   :path_encoding => 'ISO-8859-1'
                                   )
                   assert repo
                   assert_equal false, repo.is_default
                   assert_equal 'test-diff-path', repo.identifier
                   get :diff,
                       :id     => PRJ_ID,
                       :repository_id => 'test-diff-path',
                       :rev    => '61b685fbe55ab05b',
                       :rev_to => '2f9c0091c754a91a',
                       :type   => 'inline'
                   assert_response :success
                   assert_template 'diff'
                   diff = assigns(:diff)
                   assert_not_nil diff
                   assert_select 'form[action=?]', '/projects/subproject1/repository/test-diff-path/revisions/61b685fbe55ab05b/diff'
                   assert_select 'input#rev_to[type=hidden][name=rev_to][value=?]', '2f9c0091c754a91a'
                 end
                 def test_diff_latin_1
                   if @ruby19_non_utf8_pass
                     puts_ruby19_non_utf8_pass()
                   else
                     with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                       ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
                         ['inline', 'sbs'].each do |dt|
                           get :diff, :id => PRJ_ID, :rev => r1, :type => dt
                           assert_response :success
                           assert_template 'diff'
                           assert_select 'table' do
                             assert_select 'thead th.filename', :text => /latin-1-dir\/test-#{CHAR_1_HEX}.txt/
                             assert_select 'tbody td.diff_in', :text => /test-#{CHAR_1_HEX}.txt/
                           end
                         end
                       end
                     end
                   end
                 end
                 def test_diff_should_show_filenames
                   get :diff, :id => PRJ_ID, :rev => 'deff712f05a90d96edbd70facc47d944be5897e3', :type => 'inline'
                   assert_response :success
                   assert_template 'diff'
                   # modified file
                   assert_select 'th.filename', :text => 'sources/watchers_controller.rb'
                   # deleted file
                   assert_select 'th.filename', :text => 'test.txt'
                 end
                 def test_save_diff_type
                   user1 = User.find(1)
                   user1.pref[:diff_type] = nil
                   user1.preference.save
                   user = User.find(1)
                   assert_nil user.pref[:diff_type]
                   @request.session[:user_id] = 1 # admin
                   get :diff,
                       :id   => PRJ_ID,
                       :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7'
                   assert_response :success
                   assert_template 'diff'
                   user.reload
                   assert_equal "inline", user.pref[:diff_type]
                   get :diff,
                       :id   => PRJ_ID,
                       :rev  => '2f9c0091c754a91af7a9c478e36556b4bde8dcf7',
                       :type => 'sbs'
                   assert_response :success
                   assert_template 'diff'
                   user.reload
                   assert_equal "sbs", user.pref[:diff_type]
                 end
                 def test_annotate
                   get :annotate, :id => PRJ_ID,
                       :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param]
                   assert_response :success
                   assert_template 'annotate'
                   # Line 23, changeset 2f9c0091
                   assert_select 'tr' do
                     assert_select 'th.line-num', :text => '23'
                     assert_select 'td.revision', :text => /2f9c0091/
                     assert_select 'td.author', :text => 'jsmith'
                     assert_select 'td', :text => /remove_watcher/
                   end
                 end
                 def test_annotate_at_given_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :annotate, :id => PRJ_ID, :rev => 'deff7',
                       :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param]
                   assert_response :success
                   assert_template 'annotate'
                   assert_select 'h2', :text => /@ deff712f/
                 end
                 def test_annotate_binary_file
                   with_settings :default_language => 'en' do
                     get :annotate, :id => PRJ_ID,
                         :path => repository_path_hash(['images', 'edit.png'])[:param]
                     assert_response 500
                     assert_select 'p#errorExplanation', :text => /cannot be annotated/
                   end
                 end
                 def test_annotate_error_when_too_big
                   with_settings :file_max_size_displayed => 1 do
                     get :annotate, :id => PRJ_ID,
                         :path => repository_path_hash(['sources', 'watchers_controller.rb'])[:param],
                         :rev => 'deff712f'
                     assert_response 500
                     assert_select 'p#errorExplanation', :text => /exceeds the maximum text file size/
                     get :annotate, :id => PRJ_ID,
                         :path => repository_path_hash(['README'])[:param],
                         :rev => '7234cb2'
                     assert_response :success
                     assert_template 'annotate'
                   end
                 end
                 def test_annotate_latin_1
                   if @ruby19_non_utf8_pass
                     puts_ruby19_non_utf8_pass()
                   elsif WINDOWS_PASS
                     puts WINDOWS_SKIP_STR
                   elsif JRUBY_SKIP
                     puts JRUBY_SKIP_STR
                   else
                     with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                       ['57ca437c', '57ca437c0acbbcb749821fdf3726a1367056d364'].each do |r1|
                         get :annotate, :id => PRJ_ID,
                             :path => repository_path_hash(['latin-1-dir', "test-#{CHAR_1_HEX}.txt"])[:param],
                             :rev => r1
                         assert_select "th.line-num", :text => '1' do
                           assert_select "+ td.revision" do
                             assert_select "a", :text => '57ca437c'
                             assert_select "+ td.author", :text => "jsmith" do
                               assert_select "+ td",
                                             :text => "test-#{CHAR_1_HEX}.txt"
                             end
                           end
                         end
                       end
                     end
                   end
                 end
                 def test_annotate_latin_1_author
                   ['83ca5fd546063a3c7dc2e568ba3355661a9e2b2c', '83ca5fd546063a'].each do |r1|
                     get :annotate, :id => PRJ_ID,
                         :path => repository_path_hash([" filename with a leading space.txt "])[:param],
                         :rev => r1
                     assert_select "th.line-num", :text => '1' do
                       assert_select "+ td.revision" do
                         assert_select "a", :text => '83ca5fd5'
                         assert_select "+ td.author", :text => FELIX_HEX do
                           assert_select "+ td",
                                         :text => "And this is a file with a leading and trailing space..."
                         end
                       end
                     end
                   end
                 end
                 def test_revisions
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   get :revisions, :id => PRJ_ID
                   assert_response :success
                   assert_template 'revisions'
                   assert_select 'form[method=get][action=?]', '/projects/subproject1/repository/revision'
                 end
                 def test_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['61b685fbe55ab05b5ac68402d5720c1a6ac973d1', '61b685f'].each do |r|
                     get :revision, :id => PRJ_ID, :rev => r
                     assert_response :success
                     assert_template 'revision'
                   end
                 end
                 def test_empty_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['', ' ', nil].each do |r|
                     get :revision, :id => PRJ_ID, :rev => r
                     assert_response 404
                     assert_select_error /was not found/
                   end
                 end
                 def test_destroy_valid_repository
                   @request.session[:user_id] = 1 # admin
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_difference 'Repository.count', -1 do
                     delete :destroy, :id => @repository.id
                   end
                   assert_response 302
                   @project.reload
                   assert_nil @project.repository
                 end
                 def test_destroy_invalid_repository
                   @request.session[:user_id] = 1 # admin
                   @project.repository.destroy
                   @repository = Repository::Git.create!(
                                   :project       => @project,
                                   :url           => "/invalid",
                                   :path_encoding => 'ISO-8859-1'
                                   )
                   @repository.fetch_changesets
                   @repository.reload
                   assert_equal 0, @repository.changesets.count
                   assert_difference 'Repository.count', -1 do
                     delete :destroy, :id => @repository.id
                   end
                   assert_response 302
                   @project.reload
                   assert_nil @project.repository
                 end
                 private
                 def puts_ruby19_non_utf8_pass
                   puts "TODO: This test fails " +
                        "when Encoding.default_external is not UTF-8. " +
                        "Current value is '#{Encoding.default_external.to_s}'"
                 end
               else
                 puts "Git test repository NOT FOUND. Skipping functional tests !!!"
                 def test_fake; assert true end
               end
               private
               def with_cache(&block)
                 before = ActionController::Base.perform_caching
                 ActionController::Base.perform_caching = true
                 block.call
                 ActionController::Base.perform_caching = before
               end
             end

test/unit/repository_git_test.rb +2 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoryGitTest < ActiveSupport::TestCase
               fixtures :projects, :repositories, :enabled_modules, :users, :roles
               include Redmine::I18n
               REPOSITORY_PATH = Rails.root.join('tmp/test/git_repository').to_s
               REPOSITORY_PATH.gsub!(/\//, "\\") if Redmine::Platform.mswin?
               NUM_REV = 28
               NUM_HEAD = 6
               FELIX_HEX  = "Felix Sch\xC3\xA4fer".force_encoding('UTF-8')
               CHAR_1_HEX = "\xc3\x9c".force_encoding('UTF-8')
               ## Git, Mercurial and CVS path encodings are binary.
               ## Subversion supports URL encoding for path.
               ## Redmine Mercurial adapter and extension use URL encoding.
               ## Git accepts only binary path in command line parameter.
               ## So, there is no way to use binary command line parameter in JRuby.
               JRUBY_SKIP     = (RUBY_PLATFORM == 'java')
               JRUBY_SKIP_STR = "TODO: This test fails in JRuby"
               def setup
                 @project = Project.find(3)
                 @repository = Repository::Git.create(
                                     :project       => @project,
                                     :url           => REPOSITORY_PATH,
                                     :path_encoding => 'ISO-8859-1'
                                     )
                 assert @repository
               end
               def test_nondefault_repo_with_blank_identifier_destruction
+                Repository.delete_all
                 repo1 = Repository::Git.new(
                                       :project    => @project,
                                       :url        => REPOSITORY_PATH,
                                       :identifier => '',
                                       :is_default => true
                                     )
                 assert repo1.save
                 repo1.fetch_changesets
                 repo2 = Repository::Git.new(
                                       :project    => @project,
                                       :url        => REPOSITORY_PATH,
                                       :identifier => 'repo2',
                                       :is_default => true
                                 )
                 assert repo2.save
                 repo2.fetch_changesets
                 repo1.reload
                 repo2.reload
                 assert !repo1.is_default?
                 assert  repo2.is_default?
                 assert_difference 'Repository.count', -1 do
                   repo1.destroy
                 end
               end
               def test_blank_path_to_repository_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Git.new(
                                       :project      => @project,
                                       :identifier   => 'test'
                                     )
                 assert !repo.save
                 assert_include "Path to repository cannot be blank",
                                repo.errors.full_messages
               end
               def test_blank_path_to_repository_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Chemin du d\xc3\xa9p\xc3\xb4t doit \xc3\xaatre renseign\xc3\xa9(e)".force_encoding('UTF-8')
                 repo = Repository::Git.new(
                                       :project      => @project,
                                       :url          => "",
                                       :identifier   => 'test',
                                       :path_encoding => ''
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               if File.directory?(REPOSITORY_PATH)
                 ## Ruby uses ANSI api to fork a process on Windows.
                 ## Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem
                 ## and these are incompatible with ASCII.
                 ## Git for Windows (msysGit) changed internal API from ANSI to Unicode in 1.7.10
                 ## http://code.google.com/p/msysgit/issues/detail?id=80
                 ## So, Latin-1 path tests fail on Japanese Windows
                 WINDOWS_PASS = (Redmine::Platform.mswin? &&
                                      Redmine::Scm::Adapters::GitAdapter.client_version_above?([1, 7, 10]))
                 WINDOWS_SKIP_STR = "TODO: This test fails in Git for Windows above 1.7.10"
                 def test_scm_available
                   klass = Repository::Git
                   assert_equal "Git", klass.scm_name
                   assert klass.scm_adapter_class
                   assert_not_equal "", klass.scm_command
                   assert_equal true, klass.scm_available
                 end
                 def test_entries
                   entries = @repository.entries
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                 end
                 def test_fetch_changesets_from_scratch
                   assert_nil @repository.extra_info
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal 39, @repository.filechanges.count
                   commit = @repository.changesets.find_by_revision("7234cb2750b63f47bff735edc50a1c0a433c2518")
                   assert_equal "7234cb2750b63f47bff735edc50a1c0a433c2518", commit.scmid
                   assert_equal "Initial import.\nThe repository contains 3 files.", commit.comments
                   assert_equal "jsmith <jsmith@foo.bar>", commit.committer
                   assert_equal User.find_by_login('jsmith'), commit.user
                   # TODO: add a commit with commit time <> author time to the test repository
                   assert_equal Time.gm(2007, 12, 14, 9, 22, 52), commit.committed_on
                   assert_equal "2007-12-14".to_date, commit.commit_date
                   assert_equal 3, commit.filechanges.count
                   change = commit.filechanges.sort_by(&:path).first
                   assert_equal "README", change.path
                   assert_equal nil, change.from_path
                   assert_equal "A", change.action
                   assert_equal NUM_HEAD, @repository.extra_info["heads"].size
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   extra_info_heads = @repository.extra_info["heads"].dup
                   assert_equal NUM_HEAD, extra_info_heads.size
                   extra_info_heads.delete_if { |x| x == "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c" }
                   assert_equal 4, extra_info_heads.size
                   del_revs = [
                       "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c",
                       "ed5bb786bbda2dee66a2d50faf51429dbc043a7b",
                       "4f26664364207fa8b1af9f8722647ab2d4ac5d43",
                       "deff712f05a90d96edbd70facc47d944be5897e3",
                       "32ae898b720c2f7eec2723d5bdd558b4cb2d3ddf",
                       "7e61ac704deecde634b51e59daa8110435dcb3da",
                      ]
                   @repository.changesets.each do |rev|
                     rev.destroy if del_revs.detect {|r| r == rev.scmid.to_s }
                   end
                   @project.reload
                   cs1 = @repository.changesets
                   assert_equal NUM_REV - 6, cs1.count
                   extra_info_heads << "4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8"
                   h = {}
                   h["heads"] = extra_info_heads
                   @repository.merge_extra_info(h)
                   @repository.save
                   @project.reload
                   assert @repository.extra_info["heads"].index("4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8")
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal NUM_HEAD, @repository.extra_info["heads"].size
                   assert @repository.extra_info["heads"].index("83ca5fd546063a3c7dc2e568ba3355661a9e2b2c")
                 end
                 def test_fetch_changesets_history_editing
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   extra_info_heads = @repository.extra_info["heads"].dup
                   assert_equal NUM_HEAD, extra_info_heads.size
                   extra_info_heads.delete_if { |x| x == "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c" }
                   assert_equal 4, extra_info_heads.size
                   del_revs = [
                       "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c",
                       "ed5bb786bbda2dee66a2d50faf51429dbc043a7b",
                       "4f26664364207fa8b1af9f8722647ab2d4ac5d43",
                       "deff712f05a90d96edbd70facc47d944be5897e3",
                       "32ae898b720c2f7eec2723d5bdd558b4cb2d3ddf",
                       "7e61ac704deecde634b51e59daa8110435dcb3da",
                      ]
                   @repository.changesets.each do |rev|
                     rev.destroy if del_revs.detect {|r| r == rev.scmid.to_s }
                   end
                   @project.reload
                   assert_equal NUM_REV - 6, @repository.changesets.count
                   c = Changeset.new(:repository   => @repository,
                                     :committed_on => Time.now,
                                     :revision     => "abcd1234efgh",
                                     :scmid        => "abcd1234efgh",
                                     :comments     => 'test')
                   assert c.save
                   @project.reload
                   assert_equal NUM_REV - 5, @repository.changesets.count
                   extra_info_heads << "1234abcd5678"
                   h = {}
                   h["heads"] = extra_info_heads
                   @repository.merge_extra_info(h)
                   @repository.save
                   @project.reload
                   h1 = @repository.extra_info["heads"].dup
                   assert h1.index("1234abcd5678")
                   assert_equal 5, h1.size
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV - 5, @repository.changesets.count
                   h2 = @repository.extra_info["heads"].dup
                   assert_equal h1, h2
                 end
                 def test_keep_extra_report_last_commit_in_clear_changesets
                   assert_nil @repository.extra_info
                   h = {}
                   h["extra_report_last_commit"] = "1"
                   @repository.merge_extra_info(h)
                   @repository.save
                   @project.reload
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   @repository.send(:clear_changesets)
                   assert_equal 1, @repository.extra_info.size
                   assert_equal "1", @repository.extra_info["extra_report_last_commit"]
                 end
                 def test_refetch_after_clear_changesets
                   assert_nil @repository.extra_info
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   @repository.send(:clear_changesets)
                   @project.reload
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                 end
                 def test_parents
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   r1 = @repository.find_changeset_by_name("7234cb2750b63")
                   assert_equal [], r1.parents
                   r2 = @repository.find_changeset_by_name("899a15dba03a3")
                   assert_equal 1, r2.parents.length
                   assert_equal "7234cb2750b63f47bff735edc50a1c0a433c2518",
                                r2.parents[0].identifier
                   r3 = @repository.find_changeset_by_name("32ae898b720c2")
                   assert_equal 2, r3.parents.length
                   r4 = [r3.parents[0].identifier, r3.parents[1].identifier].sort
                   assert_equal "4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8", r4[0]
                   assert_equal "7e61ac704deecde634b51e59daa8110435dcb3da", r4[1]
                 end
                 def test_db_consistent_ordering_init
                   assert_nil @repository.extra_info
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal 1, @repository.extra_info["db_consistent"]["ordering"]
                 end
                 def test_db_consistent_ordering_before_1_2
                   assert_nil @repository.extra_info
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_not_nil @repository.extra_info
                   h = {}
                   h["heads"] = []
                   h["branches"] = {}
                   h["db_consistent"] = {}
                   @repository.merge_extra_info(h)
                   @repository.save
                   assert_equal NUM_REV, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal 0, @repository.extra_info["db_consistent"]["ordering"]
                   extra_info_heads = @repository.extra_info["heads"].dup
                   extra_info_heads.delete_if { |x| x == "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c" }
                   del_revs = [
                       "83ca5fd546063a3c7dc2e568ba3355661a9e2b2c",
                       "ed5bb786bbda2dee66a2d50faf51429dbc043a7b",
                       "4f26664364207fa8b1af9f8722647ab2d4ac5d43",
                       "deff712f05a90d96edbd70facc47d944be5897e3",
                       "32ae898b720c2f7eec2723d5bdd558b4cb2d3ddf",
                       "7e61ac704deecde634b51e59daa8110435dcb3da",
                      ]
                   @repository.changesets.each do |rev|
                     rev.destroy if del_revs.detect {|r| r == rev.scmid.to_s }
                   end
                   @project.reload
                   cs1 = @repository.changesets
                   assert_equal NUM_REV - 6, cs1.count
                   assert_equal 0, @repository.extra_info["db_consistent"]["ordering"]
                   extra_info_heads << "4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8"
                   h = {}
                   h["heads"] = extra_info_heads
                   @repository.merge_extra_info(h)
                   @repository.save
                   @project.reload
                   assert @repository.extra_info["heads"].index("4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8")
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal NUM_HEAD, @repository.extra_info["heads"].size
                   assert_equal 0, @repository.extra_info["db_consistent"]["ordering"]
                 end
                 def test_heads_from_branches_hash
                   assert_nil @repository.extra_info
                   assert_equal 0, @repository.changesets.count
                   assert_equal [], @repository.heads_from_branches_hash
                   h = {}
                   h["branches"] = {}
                   h["branches"]["test1"] = {}
                   h["branches"]["test1"]["last_scmid"] = "1234abcd"
                   h["branches"]["test2"] = {}
                   h["branches"]["test2"]["last_scmid"] = "abcd1234"
                   @repository.merge_extra_info(h)
                   @repository.save
                   @project.reload
                   assert_equal ["1234abcd", "abcd1234"], @repository.heads_from_branches_hash.sort
                 end
                 def test_latest_changesets
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # with limit
                   changesets = @repository.latest_changesets('', 'master', 2)
                   assert_equal 2, changesets.size
                   # with path
                   changesets = @repository.latest_changesets('images', 'master')
                   assert_equal [
                           'deff712f05a90d96edbd70facc47d944be5897e3',
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', nil)
                   assert_equal [
                           '32ae898b720c2f7eec2723d5bdd558b4cb2d3ddf',
                           '4a07fe31bffcf2888791f3e6cbc9c4545cefe3e8',
                           '713f4944648826f558cf548222f813dabe7cbb04',
                           '61b685fbe55ab05b5ac68402d5720c1a6ac973d1',
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   # with path, revision and limit
                   changesets = @repository.latest_changesets('images', '899a15dba')
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('images', '899a15dba', 1)
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', '899a15dba')
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', '899a15dba', 1)
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                       ], changesets.collect(&:revision)
                   # with path, tag and limit
                   changesets = @repository.latest_changesets('images', 'tag01.annotated')
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('images', 'tag01.annotated', 1)
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', 'tag01.annotated')
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', 'tag01.annotated', 1)
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                       ], changesets.collect(&:revision)
                   # with path, branch and limit
                   changesets = @repository.latest_changesets('images', 'test_branch')
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('images', 'test_branch', 1)
                   assert_equal [
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', 'test_branch')
                   assert_equal [
                           '713f4944648826f558cf548222f813dabe7cbb04',
                           '61b685fbe55ab05b5ac68402d5720c1a6ac973d1',
                           '899a15dba03a3b350b89c3f537e4bbe02a03cdc9',
                           '7234cb2750b63f47bff735edc50a1c0a433c2518',
                       ], changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', 'test_branch', 2)
                   assert_equal [
                           '713f4944648826f558cf548222f813dabe7cbb04',
                           '61b685fbe55ab05b5ac68402d5720c1a6ac973d1',
                       ], changesets.collect(&:revision)
                   if WINDOWS_PASS
                     puts WINDOWS_SKIP_STR
                   elsif JRUBY_SKIP
                     puts JRUBY_SKIP_STR
                   else
                     # latin-1 encoding path
                     changesets = @repository.latest_changesets(
                                   "latin-1-dir/test-#{CHAR_1_HEX}-2.txt", '64f1f3e89')
                     assert_equal [
                           '64f1f3e89ad1cb57976ff0ad99a107012ba3481d',
                           '4fc55c43bf3d3dc2efb66145365ddc17639ce81e',
                       ], changesets.collect(&:revision)
                     changesets = @repository.latest_changesets(
                                 "latin-1-dir/test-#{CHAR_1_HEX}-2.txt", '64f1f3e89', 1)
                     assert_equal [
                           '64f1f3e89ad1cb57976ff0ad99a107012ba3481d',
                       ], changesets.collect(&:revision)
                   end
                 end
                 def test_latest_changesets_latin_1_dir
                   if WINDOWS_PASS
                     puts WINDOWS_SKIP_STR
                   elsif JRUBY_SKIP
                     puts JRUBY_SKIP_STR
                   else
                     assert_equal 0, @repository.changesets.count
                     @repository.fetch_changesets
                     @project.reload
                     assert_equal NUM_REV, @repository.changesets.count
                     changesets = @repository.latest_changesets(
                                 "latin-1-dir/test-#{CHAR_1_HEX}-subdir", '1ca7f5ed')
                     assert_equal [
                           '1ca7f5ed374f3cb31a93ae5215c2e25cc6ec5127',
                       ], changesets.collect(&:revision)
                   end
                 end
                 def test_find_changeset_by_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['7234cb2750b63f47bff735edc50a1c0a433c2518', '7234cb2750b'].each do |r|
                     assert_equal '7234cb2750b63f47bff735edc50a1c0a433c2518',
                                  @repository.find_changeset_by_name(r).revision
                   end
                 end
                 def test_find_changeset_by_empty_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['', ' ', nil].each do |r|
                     assert_nil @repository.find_changeset_by_name(r)
                   end
                 end
                 def test_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision(
                                       '7234cb2750b63f47bff735edc50a1c0a433c2518')
                   assert_equal c.scmid, c.identifier
                 end
                 def test_format_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision(
                                       '7234cb2750b63f47bff735edc50a1c0a433c2518')
                   assert_equal '7234cb27', c.format_identifier
                 end
                 def test_activities
                   c = Changeset.new(:repository => @repository,
                                     :committed_on => Time.now,
                                     :revision => 'abc7234cb2750b63f47bff735edc50a1c0a433c2',
                                     :scmid    => 'abc7234cb2750b63f47bff735edc50a1c0a433c2',
                                     :comments => 'test')
                   assert c.event_title.include?('abc7234c:')
                   assert_equal 'abc7234cb2750b63f47bff735edc50a1c0a433c2', c.event_url[:rev]
                 end
                 def test_log_utf8
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision(
                                     'ed5bb786bbda2dee66a2d50faf51429dbc043a7b')
                   assert_equal "#{FELIX_HEX} <felix@fachschaften.org>", c.committer
                 end
                 def test_previous
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|1ca7f5ed374f3cb31a93ae5215c2e25cc6ec5127 1ca7f5ed|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     %w|64f1f3e89ad1cb57976ff0ad99a107012ba3481d 64f1f3e89ad1|.each do |r2|
                       assert_equal @repository.find_changeset_by_name(r2), changeset.previous
                     end
                   end
                 end
                 def test_previous_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|7234cb2750b63f47bff735edc50a1c0a433c2518 7234cb275|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     assert_nil changeset.previous
                   end
                 end
                 def test_next
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|64f1f3e89ad1cb57976ff0ad99a107012ba3481d 64f1f3e89ad1|.each do |r2|
                     changeset = @repository.find_changeset_by_name(r2)
                     %w|1ca7f5ed374f3cb31a93ae5215c2e25cc6ec5127 1ca7f5ed|.each do |r1|
                     assert_equal @repository.find_changeset_by_name(r1), changeset.next
                     end
                   end
                 end
                 def test_next_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|2a682156a3b6e77a8bf9cd4590e8db757f3c6c78 2a682156a3b6e77a|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     assert_nil changeset.next
                   end
                 end
               else
                 puts "Git test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

test/unit/repository_test.rb +12 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoryTest < ActiveSupport::TestCase
               fixtures :projects,
                        :trackers,
                        :projects_trackers,
                        :enabled_modules,
                        :repositories,
                        :issues,
                        :issue_statuses,
                        :issue_categories,
                        :changesets,
                        :changes,
                        :users,
                        :email_addresses,
                        :members,
                        :member_roles,
                        :roles,
                        :enumerations
               include Redmine::I18n
               def setup
                 @repository = Project.find(1).repository
               end
               def test_blank_log_encoding_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Bazaar.new(
                                     :project      => Project.find(3),
                                     :url          => "/test",
                                     :log_encoding => ''
                                   )
                 assert !repo.save
                 assert_include "Commit messages encoding cannot be blank",
                                repo.errors.full_messages
               end
               def test_blank_log_encoding_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Encodage des messages de commit doit \xc3\xaatre renseign\xc3\xa9(e)".force_encoding('UTF-8')
                 repo = Repository::Bazaar.new(
                                     :project      => Project.find(3),
                                     :url          => "/test"
                                   )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               def test_create
                 repository = Repository::Subversion.new(:project => Project.find(3))
                 assert !repository.save
                 repository.url = "svn://localhost"
                 assert repository.save
                 repository.reload
                 project = Project.find(3)
                 assert_equal repository, project.repository
               end
               def test_2_repositories_with_same_identifier_in_different_projects_should_be_valid
                 Repository::Subversion.create!(:project_id => 2, :identifier => 'foo', :url => 'file:///foo')
                 r = Repository::Subversion.new(:project_id => 3, :identifier => 'foo', :url => 'file:///bar')
                 assert r.save
               end
               def test_2_repositories_with_same_identifier_should_not_be_valid
                 Repository::Subversion.create!(:project_id => 3, :identifier => 'foo', :url => 'file:///foo')
                 r = Repository::Subversion.new(:project_id => 3, :identifier => 'foo', :url => 'file:///bar')
                 assert !r.save
               end
               def test_2_repositories_with_blank_identifier_should_not_be_valid
                 Repository::Subversion.create!(:project_id => 3, :identifier => '', :url => 'file:///foo')
                 r = Repository::Subversion.new(:project_id => 3, :identifier => '', :url => 'file:///bar')
                 assert !r.save
               end
+              def test_2_repositories_with_blank_identifier_and_one_as_default_should_not_be_valid
+                Repository::Subversion.create!(:project_id => 3, :identifier => '', :url => 'file:///foo', :is_default => true)
+                r = Repository::Subversion.new(:project_id => 3, :identifier => '', :url => 'file:///bar')
+                assert !r.save
+              end
+              def test_2_repositories_with_blank_and_nil_identifier_should_not_be_valid
+                Repository::Subversion.create!(:project_id => 3, :identifier => nil, :url => 'file:///foo')
+                r = Repository::Subversion.new(:project_id => 3, :identifier => '', :url => 'file:///bar')
+                assert !r.save
+              end
               def test_first_repository_should_be_set_as_default
                 repository1 = Repository::Subversion.new(
                                   :project => Project.find(3),
                                   :identifier => 'svn1',
                                   :url => 'file:///svn1'
                                 )
                 assert repository1.save
                 assert repository1.is_default?
                 repository2 = Repository::Subversion.new(
                                   :project => Project.find(3),
                                   :identifier => 'svn2',
                                   :url => 'file:///svn2'
                                 )
                 assert repository2.save
                 assert !repository2.is_default?
                 assert_equal repository1, Project.find(3).repository
                 assert_equal [repository1, repository2], Project.find(3).repositories.sort
               end
               def test_default_repository_should_be_one
                 assert_equal 0, Project.find(3).repositories.count
                 repository1 = Repository::Subversion.new(
                                   :project => Project.find(3),
                                   :identifier => 'svn1',
                                   :url => 'file:///svn1'
                                 )
                 assert repository1.save
                 assert repository1.is_default?
                 repository2 = Repository::Subversion.new(
                                   :project => Project.find(3),
                                   :identifier => 'svn2',
                                   :url => 'file:///svn2',
                                   :is_default => true
                                 )
                 assert repository2.save
                 assert repository2.is_default?
                 repository1.reload
                 assert !repository1.is_default?
                 assert_equal repository2, Project.find(3).repository
                 assert_equal [repository2, repository1], Project.find(3).repositories.sort
               end
               def test_identifier_should_accept_letters_digits_dashes_and_underscores
                 r = Repository::Subversion.new(
                   :project_id => 3,
                   :identifier => 'svn-123_45',
                   :url => 'file:///svn'
                 )
                 assert r.save
               end
               def test_identifier_should_not_be_frozen_for_a_new_repository
                 assert_equal false, Repository.new.identifier_frozen?
               end
               def test_identifier_should_not_be_frozen_for_a_saved_repository_with_blank_identifier
                 Repository.where(:id => 10).update_all(["identifier = ''"])
                 assert_equal false, Repository.find(10).identifier_frozen?
               end
               def test_identifier_should_be_frozen_for_a_saved_repository_with_valid_identifier
                 Repository.where(:id => 10).update_all(["identifier = 'abc123'"])
                 assert_equal true, Repository.find(10).identifier_frozen?
               end
               def test_identifier_should_not_accept_change_if_frozen
                 r = Repository.new(:identifier => 'foo')
                 r.stubs(:identifier_frozen?).returns(true)
                 r.identifier = 'bar'
                 assert_equal 'foo', r.identifier
               end
               def test_identifier_should_accept_change_if_not_frozen
                 r = Repository.new(:identifier => 'foo')
                 r.stubs(:identifier_frozen?).returns(false)
                 r.identifier = 'bar'
                 assert_equal 'bar', r.identifier
               end
               def test_destroy
                 repository = Repository.find(10)
                 changesets = repository.changesets.count
                 changes = repository.filechanges.count
                 assert_difference 'Changeset.count', -changesets do
                   assert_difference 'Change.count', -changes do
                     Repository.find(10).destroy
                   end
                 end
               end
               def test_destroy_should_delete_parents_associations
                 changeset = Changeset.find(102)
                 changeset.parents = Changeset.where(:id => [100, 101]).to_a
                 assert_difference 'Changeset.connection.select_all("select * from changeset_parents").count', -2 do
                   Repository.find(10).destroy
                 end
               end
               def test_destroy_should_delete_issues_associations
                 changeset = Changeset.find(102)
                 changeset.issues = Issue.where(:id => [1, 2]).to_a
                 assert_difference 'Changeset.connection.select_all("select * from changesets_issues").count', -2 do
                   Repository.find(10).destroy
                 end
               end
               def test_should_not_create_with_disabled_scm
                 # disable Subversion
                 with_settings :enabled_scm => ['Darcs', 'Git'] do
                   repository = Repository::Subversion.new(
                                   :project => Project.find(3), :url => "svn://localhost")
                   assert !repository.save
                   assert_include I18n.translate('activerecord.errors.messages.invalid'),
                                  repository.errors[:type]
                 end
               end
               def test_scan_changesets_for_issue_ids
                 Setting.default_language = 'en'
                 Setting.commit_ref_keywords = 'refs , references, IssueID'
                 Setting.commit_update_keywords = [
                   {'keywords' => 'fixes , closes',
                    'status_id' => IssueStatus.where(:is_closed => true).first.id,
                    'done_ratio' => '90'}
                 ]
                 Setting.default_language = 'en'
                 ActionMailer::Base.deliveries.clear
                 # make sure issue 1 is not already closed
                 fixed_issue = Issue.find(1)
                 assert !fixed_issue.closed?
                 old_status = fixed_issue.status
                 with_settings :notified_events => %w(issue_added issue_updated) do
                   Repository.scan_changesets_for_issue_ids
                 end
                 assert_equal [101, 102], Issue.find(3).changeset_ids
                 # fixed issues
                 fixed_issue.reload
                 assert fixed_issue.closed?
                 assert_equal 90, fixed_issue.done_ratio
                 assert_equal [101], fixed_issue.changeset_ids
                 # issue change
                 journal = fixed_issue.journals.reorder('created_on desc').first
                 assert_equal User.find_by_login('dlopper'), journal.user
                 assert_equal 'Applied in changeset r2.', journal.notes
                 # 2 email notifications
                 assert_equal 2, ActionMailer::Base.deliveries.size
                 mail = ActionMailer::Base.deliveries.first
                 assert_not_nil mail
                 assert mail.subject.starts_with?(
                     "[#{fixed_issue.project.name} - #{fixed_issue.tracker.name} ##{fixed_issue.id}]")
                 assert_mail_body_match(
                     "Status changed from #{old_status} to #{fixed_issue.status}", mail)
                 # ignoring commits referencing an issue of another project
                 assert_equal [], Issue.find(4).changesets
               end
               def test_for_changeset_comments_strip
                 repository = Repository::Mercurial.create(
                                 :project => Project.find( 4 ),
                                 :url => '/foo/bar/baz' )
                 comment = <<-COMMENT
                 This is a loooooooooooooooooooooooooooong comment
                 COMMENT
                 changeset = Changeset.new(
                   :comments => comment, :commit_date => Time.now,
                   :revision => 0, :scmid => 'f39b7922fb3c',
                   :committer => 'foo <foo@example.com>',
                   :committed_on => Time.now, :repository => repository )
                 assert( changeset.save )
                 assert_not_equal( comment, changeset.comments )
                 assert_equal( 'This is a loooooooooooooooooooooooooooong comment',
                               changeset.comments )
               end
               def test_for_urls_strip_cvs
                 repository = Repository::Cvs.create(
                     :project => Project.find(4),
                     :url => ' :pserver:login:password@host:/path/to/the/repository',
                     :root_url => 'foo  ',
                     :log_encoding => 'UTF-8')
                 assert repository.save
                 repository.reload
                 assert_equal ':pserver:login:password@host:/path/to/the/repository',
                               repository.url
                 assert_equal 'foo', repository.root_url
               end
               def test_for_urls_strip_subversion
                 repository = Repository::Subversion.create(
                     :project => Project.find(4),
                     :url => ' file:///dummy   ')
                 assert repository.save
                 repository.reload
                 assert_equal 'file:///dummy', repository.url
               end
               def test_for_urls_strip_git
                 repository = Repository::Git.create(
                     :project => Project.find(4),
                     :url => ' c:\dummy   ')
                 assert repository.save
                 repository.reload
                 assert_equal 'c:\dummy', repository.url
               end
               def test_manual_user_mapping
                 assert_no_difference "Changeset.where('user_id <> 2').count" do
                   c = Changeset.create!(
                           :repository => @repository,
                           :committer => 'foo',
                           :committed_on => Time.now,
                           :revision => 100,
                           :comments => 'Committed by foo.'
                         )
                   assert_nil c.user
                   @repository.committer_ids = {'foo' => '2'}
                   assert_equal User.find(2), c.reload.user
                   # committer is now mapped
                   c = Changeset.create!(
                           :repository => @repository,
                           :committer => 'foo',
                           :committed_on => Time.now,
                           :revision => 101,
                           :comments => 'Another commit by foo.'
                         )
                   assert_equal User.find(2), c.user
                 end
               end
               def test_auto_user_mapping_by_username
                 c = Changeset.create!(
                       :repository   => @repository,
                       :committer    => 'jsmith',
                       :committed_on => Time.now,
                       :revision     => 100,
                       :comments     => 'Committed by john.'
                     )
                 assert_equal User.find(2), c.user
               end
               def test_auto_user_mapping_by_email
                 c = Changeset.create!(
                       :repository   => @repository,
                       :committer    => 'john <jsmith@somenet.foo>',
                       :committed_on => Time.now,
                       :revision     => 100,
                       :comments     => 'Committed by john.'
                     )
                 assert_equal User.find(2), c.user
               end
               def test_filesystem_avaialbe
                 klass = Repository::Filesystem
                 assert klass.scm_adapter_class
                 assert_equal true, klass.scm_available
               end
               def test_extra_info_should_not_return_non_hash_value
                 repo = Repository.new
                 repo.extra_info = "foo"
                 assert_nil repo.extra_info
               end
               def test_merge_extra_info
                 repo = Repository::Subversion.new(:project => Project.find(3))
                 assert !repo.save
                 repo.url = "svn://localhost"
                 assert repo.save
                 repo.reload
                 project = Project.find(3)
                 assert_equal repo, project.repository
                 assert_nil repo.extra_info
                 h1 = {"test_1" => {"test_11" => "test_value_11"}}
                 repo.merge_extra_info(h1)
                 assert_equal h1, repo.extra_info
                 h2 = {"test_2" => {
                                "test_21" => "test_value_21",
                                "test_22" => "test_value_22",
                               }}
                 repo.merge_extra_info(h2)
                 assert_equal (h = {"test_11" => "test_value_11"}),
                              repo.extra_info["test_1"]
                 assert_equal "test_value_21",
                              repo.extra_info["test_2"]["test_21"]
                 h3 = {"test_2" => {
                                "test_23" => "test_value_23",
                                "test_24" => "test_value_24",
                               }}
                 repo.merge_extra_info(h3)
                 assert_equal (h = {"test_11" => "test_value_11"}),
                              repo.extra_info["test_1"]
                 assert_nil repo.extra_info["test_2"]["test_21"]
                 assert_equal "test_value_23",
                              repo.extra_info["test_2"]["test_23"]
               end
               def test_sort_should_not_raise_an_error_with_nil_identifiers
                 r1 = Repository.new
                 r2 = Repository.new
                 assert_nothing_raised do
                   [r1, r2].sort
                 end
               end
               def test_stats_by_author_reflect_changesets_and_changes
                 repository = Repository.find(10)
                 expected = {"Dave Lopper"=>{:commits_count=>10, :changes_count=>3}}
                 assert_equal expected, repository.stats_by_author
                 set = Changeset.create!(
                   :repository => repository,
                   :committer => 'dlopper',
                   :committed_on => Time.now,
                   :revision => 101,
                   :comments => 'Another commit by foo.'
                 )
                 Change.create!(:changeset => set, :action => 'A', :path => '/path/to/file1')
                 Change.create!(:changeset => set, :action => 'A', :path => '/path/to/file2')
                 expected = {"Dave Lopper"=>{:commits_count=>11, :changes_count=>5}}
                 assert_equal expected, repository.stats_by_author
               end
               def test_stats_by_author_honnor_committers
                 # in fact it is really tested above, but let's have a dedicated test
                 # to ensure things are dynamically linked to Users
                 User.find_by_login("dlopper").update_attribute(:firstname, "Dave's")
                 repository = Repository.find(10)
                 expected = {"Dave's Lopper"=>{:commits_count=>10, :changes_count=>3}}
                 assert_equal expected, repository.stats_by_author
               end
               def test_stats_by_author_doesnt_drop_unmapped_users
                 repository = Repository.find(10)
                 Changeset.create!(
                   :repository => repository,
                   :committer => 'unnamed <foo@bar.net>',
                   :committed_on => Time.now,
                   :revision => 101,
                   :comments => 'Another commit by foo.'
                 )
                 assert repository.stats_by_author.has_key?("unnamed <foo@bar.net>")
               end
               def test_stats_by_author_merge_correctly
                 # as we honnor users->committer map and it's not injective,
                 # we must be sure merges happen correctly and stats are not
                 # wiped out when two source counts map to the same user.
                 #
                 # Here we have Changeset's with committer="dlopper" and others
                 # with committer="dlopper <dlopper@somefoo.net>"
                 repository = Repository.find(10)
                 expected = {"Dave Lopper"=>{:commits_count=>10, :changes_count=>3}}
                 assert_equal expected, repository.stats_by_author
                 set = Changeset.create!(
                   :repository => repository,
                   :committer => 'dlopper <dlopper@somefoo.net>',
                   :committed_on => Time.now,
                   :revision => 101,
                   :comments => 'Another commit by foo.'
                 )
                 expected = {"Dave Lopper"=>{:commits_count=>11, :changes_count=>3}}
                 assert_equal expected, repository.stats_by_author
               end
               def test_fetch_changesets
                 # 2 repositories in fixtures
                 Repository::Subversion.any_instance.expects(:fetch_changesets).twice.returns(true)
                 Repository.fetch_changesets
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages