jro_apps/redmine Commit - r12020:d89c968bb116

Accept issue id with leading sharp when adding a related issue....

Jean-Philippe Lang -

r12020:d89c968bb116

parent child

Context file:

r12020:d89c968bb116

app/controllers/repositories_controller.rb +2 -1

               # Adds a related issue to a changeset
               # POST /projects/:project_id/repository/(:repository_id/)revisions/:rev/issues
               def add_related_issue
-                @issue = @changeset.find_referenced_issue_by_id(params[:issue_id])
+                issue_id = params[:issue_id].to_s.sub(/^#/,'')
+                @issue = @changeset.find_referenced_issue_by_id(issue_id)
                 if @issue && (!@issue.visible? || @changeset.issues.include?(@issue))
                   @issue = nil
                 end

test/functional/repositories_controller_test.rb +8 0

                 assert_include 'Feature request #2', response.body
               end
+              def test_add_related_issue_should_accept_issue_id_with_sharp
+                @request.session[:user_id] = 2
+                assert_difference 'Changeset.find(103).issues.size' do
+                  xhr :post, :add_related_issue, :id => 1, :rev => 4, :issue_id => "#2", :format => 'js'
+                end
+                assert_equal [2], Changeset.find(103).issue_ids
+              end
               def test_add_related_issue_with_invalid_issue_id
                 @request.session[:user_id] = 2
                 assert_no_difference 'Changeset.find(103).issues.size' do

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages