##// END OF EJS Templates
Fixed that bulk copy raises an error on validation failure (#13943)....
Jean-Philippe Lang -
r11558:d69de691a79b
parent child
Show More

The requested changes are too big and content was truncated. Show full diff

@@ -1,450 +1,452
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 24 before_filter :find_project, :only => [:new, :create, :update_form]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create, :update_form]
29 29 accept_rss_auth :index, :show
30 30 accept_api_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 47 helper :repositories
48 48 include RepositoriesHelper
49 49 helper :sort
50 50 include SortHelper
51 51 include IssuesHelper
52 52 helper :timelog
53 53 include Redmine::Export::PDF
54 54
55 55 def index
56 56 retrieve_query
57 57 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
58 58 sort_update(@query.sortable_columns)
59 59 @query.sort_criteria = sort_criteria.to_a
60 60
61 61 if @query.valid?
62 62 case params[:format]
63 63 when 'csv', 'pdf'
64 64 @limit = Setting.issues_export_limit.to_i
65 65 when 'atom'
66 66 @limit = Setting.feeds_limit.to_i
67 67 when 'xml', 'json'
68 68 @offset, @limit = api_offset_and_limit
69 69 else
70 70 @limit = per_page_option
71 71 end
72 72
73 73 @issue_count = @query.issue_count
74 74 @issue_pages = Paginator.new @issue_count, @limit, params['page']
75 75 @offset ||= @issue_pages.offset
76 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
77 77 :order => sort_clause,
78 78 :offset => @offset,
79 79 :limit => @limit)
80 80 @issue_count_by_group = @query.issue_count_by_group
81 81
82 82 respond_to do |format|
83 83 format.html { render :template => 'issues/index', :layout => !request.xhr? }
84 84 format.api {
85 85 Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
86 86 }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'issues.pdf') }
90 90 end
91 91 else
92 92 respond_to do |format|
93 93 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
94 94 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
95 95 format.api { render_validation_errors(@query) }
96 96 end
97 97 end
98 98 rescue ActiveRecord::RecordNotFound
99 99 render_404
100 100 end
101 101
102 102 def show
103 103 @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
104 104 @journals.each_with_index {|j,i| j.indice = i+1}
105 105 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
106 106 @journals.reverse! if User.current.wants_comments_in_reverse_order?
107 107
108 108 @changesets = @issue.changesets.visible.all
109 109 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
110 110
111 111 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
112 112 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
113 113 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
114 114 @priorities = IssuePriority.active
115 115 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
116 116 @relation = IssueRelation.new
117 117
118 118 respond_to do |format|
119 119 format.html {
120 120 retrieve_previous_and_next_issue_ids
121 121 render :template => 'issues/show'
122 122 }
123 123 format.api
124 124 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
125 125 format.pdf {
126 126 pdf = issue_to_pdf(@issue, :journals => @journals)
127 127 send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
128 128 }
129 129 end
130 130 end
131 131
132 132 # Add a new issue
133 133 # The new issue will be created from an existing one if copy_from parameter is given
134 134 def new
135 135 respond_to do |format|
136 136 format.html { render :action => 'new', :layout => !request.xhr? }
137 137 end
138 138 end
139 139
140 140 def create
141 141 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
142 142 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
143 143 if @issue.save
144 144 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
145 145 respond_to do |format|
146 146 format.html {
147 147 render_attachment_warning_if_needed(@issue)
148 148 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
149 149 if params[:continue]
150 150 attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
151 151 redirect_to new_project_issue_path(@issue.project, :issue => attrs)
152 152 else
153 153 redirect_to issue_path(@issue)
154 154 end
155 155 }
156 156 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
157 157 end
158 158 return
159 159 else
160 160 respond_to do |format|
161 161 format.html { render :action => 'new' }
162 162 format.api { render_validation_errors(@issue) }
163 163 end
164 164 end
165 165 end
166 166
167 167 def edit
168 168 return unless update_issue_from_params
169 169
170 170 respond_to do |format|
171 171 format.html { }
172 172 format.xml { }
173 173 end
174 174 end
175 175
176 176 def update
177 177 return unless update_issue_from_params
178 178 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
179 179 saved = false
180 180 begin
181 181 saved = @issue.save_issue_with_child_records(params, @time_entry)
182 182 rescue ActiveRecord::StaleObjectError
183 183 @conflict = true
184 184 if params[:last_journal_id]
185 185 @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
186 186 @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
187 187 end
188 188 end
189 189
190 190 if saved
191 191 render_attachment_warning_if_needed(@issue)
192 192 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
193 193
194 194 respond_to do |format|
195 195 format.html { redirect_back_or_default issue_path(@issue) }
196 196 format.api { render_api_ok }
197 197 end
198 198 else
199 199 respond_to do |format|
200 200 format.html { render :action => 'edit' }
201 201 format.api { render_validation_errors(@issue) }
202 202 end
203 203 end
204 204 end
205 205
206 206 # Updates the issue form when changing the project, status or tracker
207 207 # on issue creation/update
208 208 def update_form
209 209 end
210 210
211 211 # Bulk edit/copy a set of issues
212 212 def bulk_edit
213 213 @issues.sort!
214 214 @copy = params[:copy].present?
215 215 @notes = params[:notes]
216 216
217 217 if User.current.allowed_to?(:move_issues, @projects)
218 218 @allowed_projects = Issue.allowed_target_projects_on_move
219 219 if params[:issue]
220 220 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
221 221 if @target_project
222 222 target_projects = [@target_project]
223 223 end
224 224 end
225 225 end
226 226 target_projects ||= @projects
227 227
228 228 if @copy
229 229 @available_statuses = [IssueStatus.default]
230 230 else
231 231 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
232 232 end
233 233 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
234 234 @assignables = target_projects.map(&:assignable_users).reduce(:&)
235 235 @trackers = target_projects.map(&:trackers).reduce(:&)
236 236 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
237 237 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
238 238 if @copy
239 239 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
240 240 @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
241 241 end
242 242
243 243 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
244 244
245 245 @issue_params = params[:issue] || {}
246 246 @issue_params[:custom_field_values] ||= {}
247 247 end
248 248
249 249 def bulk_update
250 250 @issues.sort!
251 251 @copy = params[:copy].present?
252 252 attributes = parse_params_for_bulk_issue_attributes(params)
253 253
254 254 unsaved_issues = []
255 255 saved_issues = []
256 256
257 257 if @copy && params[:copy_subtasks].present?
258 258 # Descendant issues will be copied with the parent task
259 259 # Don't copy them twice
260 260 @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
261 261 end
262 262
263 @issues.each do |issue|
264 issue.reload
263 @issues.each do |orig_issue|
264 orig_issue.reload
265 265 if @copy
266 issue = issue.copy({},
266 issue = orig_issue.copy({},
267 267 :attachments => params[:copy_attachments].present?,
268 268 :subtasks => params[:copy_subtasks].present?
269 269 )
270 else
271 issue = orig_issue
270 272 end
271 273 journal = issue.init_journal(User.current, params[:notes])
272 274 issue.safe_attributes = attributes
273 275 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
274 276 if issue.save
275 277 saved_issues << issue
276 278 else
277 unsaved_issues << issue
279 unsaved_issues << orig_issue
278 280 end
279 281 end
280 282
281 283 if unsaved_issues.empty?
282 284 flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
283 285 if params[:follow]
284 286 if @issues.size == 1 && saved_issues.size == 1
285 287 redirect_to issue_path(saved_issues.first)
286 288 elsif saved_issues.map(&:project).uniq.size == 1
287 289 redirect_to project_issues_path(saved_issues.map(&:project).first)
288 290 end
289 291 else
290 292 redirect_back_or_default _project_issues_path(@project)
291 293 end
292 294 else
293 295 @saved_issues = @issues
294 296 @unsaved_issues = unsaved_issues
295 297 @issues = Issue.visible.find_all_by_id(@unsaved_issues.map(&:id))
296 298 bulk_edit
297 299 render :action => 'bulk_edit'
298 300 end
299 301 end
300 302
301 303 def destroy
302 304 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
303 305 if @hours > 0
304 306 case params[:todo]
305 307 when 'destroy'
306 308 # nothing to do
307 309 when 'nullify'
308 310 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
309 311 when 'reassign'
310 312 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
311 313 if reassign_to.nil?
312 314 flash.now[:error] = l(:error_issue_not_found_in_project)
313 315 return
314 316 else
315 317 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
316 318 end
317 319 else
318 320 # display the destroy form if it's a user request
319 321 return unless api_request?
320 322 end
321 323 end
322 324 @issues.each do |issue|
323 325 begin
324 326 issue.reload.destroy
325 327 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
326 328 # nothing to do, issue was already deleted (eg. by a parent)
327 329 end
328 330 end
329 331 respond_to do |format|
330 332 format.html { redirect_back_or_default _project_issues_path(@project) }
331 333 format.api { render_api_ok }
332 334 end
333 335 end
334 336
335 337 private
336 338
337 339 def find_project
338 340 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
339 341 @project = Project.find(project_id)
340 342 rescue ActiveRecord::RecordNotFound
341 343 render_404
342 344 end
343 345
344 346 def retrieve_previous_and_next_issue_ids
345 347 retrieve_query_from_session
346 348 if @query
347 349 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
348 350 sort_update(@query.sortable_columns, 'issues_index_sort')
349 351 limit = 500
350 352 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
351 353 if (idx = issue_ids.index(@issue.id)) && idx < limit
352 354 if issue_ids.size < 500
353 355 @issue_position = idx + 1
354 356 @issue_count = issue_ids.size
355 357 end
356 358 @prev_issue_id = issue_ids[idx - 1] if idx > 0
357 359 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
358 360 end
359 361 end
360 362 end
361 363
362 364 # Used by #edit and #update to set some common instance variables
363 365 # from the params
364 366 # TODO: Refactor, not everything in here is needed by #edit
365 367 def update_issue_from_params
366 368 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
367 369 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
368 370 @time_entry.attributes = params[:time_entry]
369 371
370 372 @issue.init_journal(User.current)
371 373
372 374 issue_attributes = params[:issue]
373 375 if issue_attributes && params[:conflict_resolution]
374 376 case params[:conflict_resolution]
375 377 when 'overwrite'
376 378 issue_attributes = issue_attributes.dup
377 379 issue_attributes.delete(:lock_version)
378 380 when 'add_notes'
379 381 issue_attributes = issue_attributes.slice(:notes)
380 382 when 'cancel'
381 383 redirect_to issue_path(@issue)
382 384 return false
383 385 end
384 386 end
385 387 @issue.safe_attributes = issue_attributes
386 388 @priorities = IssuePriority.active
387 389 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
388 390 true
389 391 end
390 392
391 393 # TODO: Refactor, lots of extra code in here
392 394 # TODO: Changing tracker on an existing issue should not trigger this
393 395 def build_new_issue_from_params
394 396 if params[:id].blank?
395 397 @issue = Issue.new
396 398 if params[:copy_from]
397 399 begin
398 400 @copy_from = Issue.visible.find(params[:copy_from])
399 401 @copy_attachments = params[:copy_attachments].present? || request.get?
400 402 @copy_subtasks = params[:copy_subtasks].present? || request.get?
401 403 @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
402 404 rescue ActiveRecord::RecordNotFound
403 405 render_404
404 406 return
405 407 end
406 408 end
407 409 @issue.project = @project
408 410 else
409 411 @issue = @project.issues.visible.find(params[:id])
410 412 end
411 413
412 414 @issue.project = @project
413 415 @issue.author ||= User.current
414 416 # Tracker must be set before custom field values
415 417 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
416 418 if @issue.tracker.nil?
417 419 render_error l(:error_no_tracker_in_project)
418 420 return false
419 421 end
420 422 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
421 423 @issue.safe_attributes = params[:issue]
422 424
423 425 @priorities = IssuePriority.active
424 426 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
425 427 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
426 428 end
427 429
428 430 def check_for_default_issue_status
429 431 if IssueStatus.default.nil?
430 432 render_error l(:error_no_default_issue_status)
431 433 return false
432 434 end
433 435 end
434 436
435 437 def parse_params_for_bulk_issue_attributes(params)
436 438 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
437 439 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
438 440 if custom = attributes[:custom_field_values]
439 441 custom.reject! {|k,v| v.blank?}
440 442 custom.keys.each do |k|
441 443 if custom[k].is_a?(Array)
442 444 custom[k] << '' if custom[k].delete('__none__')
443 445 else
444 446 custom[k] = '' if custom[k] == '__none__'
445 447 end
446 448 end
447 449 end
448 450 attributes
449 451 end
450 452 end
1 NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff
General Comments 0
You need to be logged in to leave comments. Login now