jro_apps/redmine Commit - r11558:d69de691a79b

Fixed that bulk copy raises an error on validation failure (#13943)....

Jean-Philippe Lang -

r11558:d69de691a79b

parent child

Context file:

r11558:d69de691a79b

app/controllers/issues_controller.rb +6 -4

                   @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
                 end
-                @issues.each do |issue|
+                @issues.each do |orig_issue|
-                  issue.reload
+                  orig_issue.reload
                   if @copy
-                    issue = issue.copy({},
+                    issue = orig_issue.copy({},
                       :attachments => params[:copy_attachments].present?,
                       :subtasks => params[:copy_subtasks].present?
                     )
+                  else
+                    issue = orig_issue
                   end
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   if issue.save
                     saved_issues << issue
                   else
-                    unsaved_issues << issue
+                    unsaved_issues << orig_issue
                   end
                 end

test/functional/issues_controller_test.rb +7 0

                 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
               end
+              def test_bulk_copy_with_all_failures_should_display_errors
+                @request.session[:user_id] = 2
+                post :bulk_update, :ids => [1, 2], :copy => '1', :issue => {:start_date => 'foo'}
+                assert_response :success
+              end
               def test_destroy_issue_with_no_time_entries
                 assert_nil TimeEntry.find_by_issue_id(2)
                 @request.session[:user_id] = 2

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages