jro_apps/redmine Commit - r13880:d640f7b249b9

Adds private issue option to receiving emails (#8424)....

Jean-Philippe Lang -

r13880:d640f7b249b9

parent child

Context file:

r13880:d640f7b249b9

app/models/mail_handler.rb +4 0

                 %w(allow_override unknown_user no_permission_check no_account_notice default_group).each do |option|
                   options[option.to_sym] = env[option] if env[option]
                 end
+                if env['private']
+                  options[:issue][:is_private] = '1'
+                end
                 options
               end
                 end
                 issue.description = cleaned_up_text_body
                 issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
+                issue.is_private = (handler_options[:issue][:is_private] == '1')
                 # add To and Cc as watchers before saving so the watchers can reply to Redmine
                 add_watchers(issue)

extra/mail_handler/rdm-mailhandler.rb +1 0

                   opts.on("-t", "--tracker TRACKER",      "name of the target tracker") {|v| self.issue_attributes['tracker'] = v}
                   opts.on(      "--category CATEGORY",    "name of the target category") {|v| self.issue_attributes['category'] = v}
                   opts.on(      "--priority PRIORITY",    "name of the target priority") {|v| self.issue_attributes['priority'] = v}
+                  opts.on(      "--private",              "create new issues as private") {|v| self.issue_attributes['is_private'] = '1'}
                   opts.on("-o", "--allow-override ATTRS", "allow email content to override attributes",
                                                           "specified by previous options",
                                                           "ATTRS is a comma separated list of attributes") {|v| self.allow_override = v}

lib/tasks/email.rake +1 0

               tracker=TRACKER          name of the target tracker
               category=CATEGORY        name of the target category
               priority=PRIORITY        name of the target priority
+              private                  create new issues as private
               allow_override=ATTRS     allow email content to override attributes
                                        specified by previous options
                                        ATTRS is a comma separated list of attributes

test/functional/mail_handler_controller_test.rb +15 0

@@ -38,6 +38,21 class MailHandlerControllerTest < ActionController::TestCase
38	assert_response 201	38	assert_response 201
39	end	39	end
40		40
		41	def test_should_create_issue_with_options
		42	# Enable API and set a key
		43	Setting.mail_handler_api_enabled = 1
		44	Setting.mail_handler_api_key = 'secret'
		45
		46	assert_difference 'Issue.count' do
		47	post :index, :key => 'secret',
		48	:email => IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml')),
		49	:issue => {:is_private => '1'}
		50	end
		51	assert_response 201
		52	issue = Issue.order(:id => :desc).first
		53	assert_equal true, issue.is_private
		54	end
		55
41	def test_should_respond_with_422_if_not_created	56	def test_should_respond_with_422_if_not_created
42	Project.find('onlinestore').destroy	57	Project.find('onlinestore').destroy
43		58

test/unit/mail_handler_test.rb +7 0

                 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
               end
+              def test_add_issue_should_accept_is_private_attribute
+                issue = submit_email('ticket_on_given_project.eml', :issue => {:is_private => '1'})
+                assert issue.is_a?(Issue)
+                assert !issue.new_record?
+                assert_equal true, issue.reload.is_private
+              end
               def test_add_issue_with_attributes_override
                 issue = submit_email(
                           'ticket_with_attributes.eml',

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages