jro_apps/redmine Commit - r13123:d62574badb1d

Code cleanup, use safer #closed?...

Jean-Philippe Lang -

r13123:d62574badb1d

parent child

Context file:

r13123:d62574badb1d

app/models/issue.rb +2 -2

                # Return true if the issue is closed, otherwise false
                def closed?
-                 self.status.is_closed?
+                 status.present? && status.is_closed?
                end
                # Return true if the issue is being reopened
                # Return true if the issue is being closed
                def closing?
                  if !new_record? && status_id_changed?
-                   if status_was && status && !status_was.is_closed? && status.is_closed?
+                   if closed? && status_was && !status_was.is_closed?
                      return true
                    end
                  end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages