##// END OF EJS Templates
Code cleanup, use safer #closed?...
Jean-Philippe Lang -
r13123:d62574badb1d
parent child
Show More
@@ -688,7 +688,7 class Issue < ActiveRecord::Base
688
688
689 # Return true if the issue is closed, otherwise false
689 # Return true if the issue is closed, otherwise false
690 def closed?
690 def closed?
691 self.status.is_closed?
691 status.present? && status.is_closed?
692 end
692 end
693
693
694 # Return true if the issue is being reopened
694 # Return true if the issue is being reopened
@@ -706,7 +706,7 class Issue < ActiveRecord::Base
706 # Return true if the issue is being closed
706 # Return true if the issue is being closed
707 def closing?
707 def closing?
708 if !new_record? && status_id_changed?
708 if !new_record? && status_id_changed?
709 if status_was && status && !status_was.is_closed? && status.is_closed?
709 if closed? && status_was && !status_was.is_closed?
710 return true
710 return true
711 end
711 end
712 end
712 end
General Comments 0
You need to be logged in to leave comments. Login now