jro_apps/redmine Commit - r13353:d4ebbe5ba8c8

Adds some helpers tests....

Jean-Philippe Lang -

r13353:d4ebbe5ba8c8

parent child

Context file:

r13353:d4ebbe5ba8c8

Collapse all files

test/unit/helpers/groups_helper_test.rb created 644 +42 0

@@ -0,0 +1,42
	1	# Redmine - project management software
	2	# Copyright (C) 2006-2014 Jean-Philippe Lang
	3	#
	4	# This program is free software; you can redistribute it and/or
	5	# modify it under the terms of the GNU General Public License
	6	# as published by the Free Software Foundation; either version 2
	7	# of the License, or (at your option) any later version.
	8	#
	9	# This program is distributed in the hope that it will be useful,
	10	# but WITHOUT ANY WARRANTY; without even the implied warranty of
	11	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	12	# GNU General Public License for more details.
	13	#
	14	# You should have received a copy of the GNU General Public License
	15	# along with this program; if not, write to the Free Software
	16	# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
	17
	18	require File.expand_path('../../../test_helper', __FILE__)
	19
	20	class GroupsHelperTest < ActionView::TestCase
	21	include Redmine::I18n
	22	include ERB::Util
	23	include GroupsHelper
	24
	25	fixtures :users
	26
	27	def test_render_principals_for_new_group_users
	28	group = Group.generate!
	29
	30	result = render_principals_for_new_group_users(group)
	31	assert_select_in result, 'input[name=?][value=2]', 'user_ids[]'
	32	end
	33
	34	def test_render_principals_for_new_group_users_with_limited_results_should_paginate
	35	group = Group.generate!
	36
	37	result = render_principals_for_new_group_users(group, 3)
	38	assert_select_in result, 'p.pagination'
	39	assert_select_in result, 'span.current.page', :text => '1'
	40	assert_select_in result, 'a[href=?]', "/groups/#{group.id}/autocomplete_for_user.js?page=2", :text => '2'
	41	end
	42	end

test/unit/helpers/members_helper_test.rb created 644 +42 0

@@ -0,0 +1,42
	1	# Redmine - project management software
	2	# Copyright (C) 2006-2014 Jean-Philippe Lang
	3	#
	4	# This program is free software; you can redistribute it and/or
	5	# modify it under the terms of the GNU General Public License
	6	# as published by the Free Software Foundation; either version 2
	7	# of the License, or (at your option) any later version.
	8	#
	9	# This program is distributed in the hope that it will be useful,
	10	# but WITHOUT ANY WARRANTY; without even the implied warranty of
	11	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	12	# GNU General Public License for more details.
	13	#
	14	# You should have received a copy of the GNU General Public License
	15	# along with this program; if not, write to the Free Software
	16	# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
	17
	18	require File.expand_path('../../../test_helper', __FILE__)
	19
	20	class MembersHelperTest < ActionView::TestCase
	21	include Redmine::I18n
	22	include ERB::Util
	23	include MembersHelper
	24
	25	fixtures :projects, :users, :members, :member_roles
	26
	27	def test_render_principals_for_new_members
	28	project = Project.generate!
	29
	30	result = render_principals_for_new_members(project)
	31	assert_select_in result, 'input[name=?][value=2]', 'membership[user_ids][]'
	32	end
	33
	34	def test_render_principals_for_new_members_with_limited_results_should_paginate
	35	project = Project.generate!
	36
	37	result = render_principals_for_new_members(project, 3)
	38	assert_select_in result, 'p.pagination'
	39	assert_select_in result, 'span.current.page', :text => '1'
	40	assert_select_in result, 'a[href=?]', "/projects/#{project.identifier}/memberships/autocomplete.js?page=2", :text => '2'
	41	end
	42	end

app/helpers/groups_helper.rb +2 -2

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module GroupsHelper
               def group_settings_tabs(group)
                 tabs = []
                 tabs << {:name => 'general', :partial => 'groups/general', :label => :label_general}
                 tabs << {:name => 'users', :partial => 'groups/users', :label => :label_user_plural} if group.givable?
                 tabs << {:name => 'memberships', :partial => 'groups/memberships', :label => :label_project_plural}
                 tabs
               end
-              def render_principals_for_new_group_users(group)
+              def render_principals_for_new_group_users(group, limit=100)
                 scope = User.active.sorted.not_in_group(group).like(params[:q])
                 principal_count = scope.count
-                principal_pages = Redmine::Pagination::Paginator.new principal_count, 100, params['page']
+                principal_pages = Redmine::Pagination::Paginator.new principal_count, limit, params['page']
                 principals = scope.offset(principal_pages.offset).limit(principal_pages.per_page).to_a
                 s = content_tag('div',
                   content_tag('div', principals_check_box_tags('user_ids[]', principals), :id => 'principals'),
                   :class => 'objects-selection'
                 )
                 links = pagination_links_full(principal_pages, principal_count, :per_page_links => false) {|text, parameters, options|
                   link_to text, autocomplete_for_user_group_path(group, parameters.merge(:q => params[:q], :format => 'js')), :remote => true
                 }
                 s + content_tag('p', links, :class => 'pagination')
               end
             end

app/helpers/members_helper.rb +2 -2

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module MembersHelper
-              def render_principals_for_new_members(project)
+              def render_principals_for_new_members(project, limit=100)
                 scope = Principal.active.visible.sorted.not_member_of(project).like(params[:q])
                 principal_count = scope.count
-                principal_pages = Redmine::Pagination::Paginator.new principal_count, 100, params['page']
+                principal_pages = Redmine::Pagination::Paginator.new principal_count, limit, params['page']
                 principals = scope.offset(principal_pages.offset).limit(principal_pages.per_page).to_a
                 s = content_tag('div',
                   content_tag('div', principals_check_box_tags('membership[user_ids][]', principals), :id => 'principals'),
                   :class => 'objects-selection'
                 )
                 links = pagination_links_full(principal_pages, principal_count, :per_page_links => false) {|text, parameters, options|
                   link_to text, autocomplete_project_memberships_path(project, parameters.merge(:q => params[:q], :format => 'js')), :remote => true
                 }
                 s + content_tag('p', links, :class => 'pagination')
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages